[Libreoffice-commits] core.git: Changes to 'refs/changes/32/232/4'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/32/232/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/32/232/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/32/232/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/31/231/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/31/231/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Gerrit review patch query helper...
Hi, sorry for shameless self-plugs but I think this tool has become really useful now: querrit can perform easy queries and code review. It provides shortcuts and convenience features. For example: gerrit query mine lists all open review requests that were submitted by me. (achieved by putting [shortcuts] mine = status:open project:core sebast...@sspaeth.de into ~/.config/querrit.conf) gerrit query writer You can easily do similar things for easy monitoring requests for specific git branches, where you have been CC'd etc... A typical review looks like: gerrit review 2a34e2 +2 -m looks good to me See the README for the full documentation https://gitorious.org/querrit/querrit/blobs/master/README The code is at git://gitorious.org/querrit/querrit.git and requires Python3 or Python 2.7. Sebastian pgpqA7IGUfq6Q.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Gerrit review patch query helper...
Sebastian Spaeth sebast...@sspaeth.de writes: querrit can perform easy queries and code review. It provides shortcuts and convenience features. For example: got my examples wrong. Obviously gerrit query mine -- querrit query mine While at it, one last example that is nice (all open patches mentioning fdo#35673 in the commit message): gerrit query MAB3.4 [shortcuts] MAB3.4 = status:open project:core message:fdo.35673 new_unrev = status:open age:1d not is:reviewed pgpIw4eFiyZIy.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Gerrit review patch query helper...
Hi all, I was annoyed by the oververbose gerrit query output so I fixed it for me. I learned too late that David has something similar as logerrit in the core repository. But it is in shell script, and I have written a small query helper in python. It lists outstanding patches similar to git log (it also uses less to show them). The output is like this: id: I078ad7bcd2b5dff39969deb44fd8a11076ce27c2 https://gerrit.libreoffice.org/233 Author: David Ostrovsky david.ostrov...@gmx.de Date : Fri Jun 22 07:19:12 2012, updated: Fri Jun 22 11:49:34 2012 Subject: polishing user interface The code is at git://gitorious.org/querrit/querrit.git and requires Python3. Check it out and do ./querrit -h for help. By default it tries to connect to host logerrit (but you can override the host with a parameter). To test your connection do querrit test, to do the standard query (all open patches) simply do querrit. To only see open patches that you have starred, add --qopts is:starred. Feedback is welcome. I plan to add some config file support to be able to configure the hostname. If I have plenty of time, I'll also add a userfriendly review tool. Just to let you know. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
My experience: Gerrit from a casual contributors view
Hi all, I just pushed my first test patch to gerrit and would like to share my steps and issues: 1) Registered account using openid: painless. Being able to use your gmail/yahoo/launchpad account is a boon. Not another random password :) Added ssh key. This was an easy process. 2) Failed to find out if I have to pull from the gerrit git repository somehow, no docs on this, so I started with my FDO git repo. 3) Created a patch that I want to push 4) This is the documentation on how to push: essentially it says: git push logerrit HEAD:refs/for/master So I did :-) 4a) First difficulty: It complained that the capitalization of my email address is different from the registered email address and I were not allowed to push. ARRG :). I don't want to change my push email address, so I tried to change the registered email address, which was a bit of a pain, and it required logout/login to actually work (I think). 5) Pushed again: Hurray, the patch is at https://gerrit.libreoffice.org/#/c/231/ now. Waiting for reviews :-) That should have been it from a contributors point of view, right? What happens after reviewer +1'd it? Do I have to do something or who would push to master? Lastly, I have a very hard time remembering to push to refs/for/master and know I would constantly forget this. So I wanted to automated this that when I do: git push gerrit, the local master branch would be pushed automatically as ref/for/master. I did this by adding: push = refs/heads/master:refs/for/master to .git/config:[remote gerrit]. A git push gerrit on the master branch will now push the patch into the review queue. Thanks, Sebastian P.S. core is still described as test repo that is going to be discarded in gerrit. Is it? Can I push patches there or is it going to be dropped again? Hi all, I just pushed my first test patch to gerrit and would like to share my steps and issues: 1) Registered account using openid: painless. Being able to use your gmail/yahoo/launchpad account is a boon. Not another random password :) Added ssh key. This was an easy process. 2) Failed to find out if I have to pull from the gerrit git repository somehow, no docs on this, so I started with my FDO git repo. 3) Created a patch that I want to push 4) This is the documentation on how to push: essentially it says: git push logerrit HEAD:refs/for/master So I did :-) 4a) First difficulty: It complained that the capitalization of my email address is different from the registered email address and I were not allowed to push. ARRG :). I don't want to change my push email address, so I tried to change the registered email address, which was a bit of a pain, and it required logout/login to actually work (I think). 5) Pushed again: Hurray, the patch is at https://gerrit.libreoffice.org/#/c/231/ now. Waiting for reviews :-) That should have been it from a contributors point of view, right? What happens after reviewer +1'd it? Do I have to do something or who would push to master? Lastly, I have a very hard time remembering to push to refs/for/master and know I would constantly forget this. So I wanted to automated this that when I do: git push gerrit, the local master branch would be pushed automatically as ref/for/master. I did this by adding: push = refs/heads/master:refs/for/master to .git/config:[remote gerrit]. A git push gerrit on the master branch will now push the patch into the review queue. Thanks, Sebastian P.S. core is still described as test repo that is going to be discarded in gerrit. Is it? Can I push patches there or is it going to be dropped again? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] sw/.../crsrsh.cxx: Translate some German comments
I tried hard, in some cases the German did not make any more
sense than the translations though. I also tried to carefully
improve wording with respect to doxygen comments, without
really having to understand the code...
Change-Id: I5f3abad10d1591ddc3c9a0cc77a18b80af0de5ce
Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de
---
sw/source/core/crsr/crsrsh.cxx | 127 ++--
1 file changed, 71 insertions(+), 56 deletions(-)
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 386798b..abd0447 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -77,17 +77,18 @@ using namespace util;
TYPEINIT2(SwCrsrShell,ViewShell,SwModify);
-// Funktion loescht, alle ueberlappenden Cursor aus einem Cursor-Ring
+/**
+ * Delete all overlapping Cursors from a Cursor ring.
+ * @param pointer to SwCursor (ring)
+ */
void CheckRange( SwCursor* );
//---
-/*
- * Ueberpruefe ob der pCurCrsr in einen schon bestehenden Bereich zeigt.
- * Wenn ja, dann hebe den alten Bereich auf.
+/**
+ * Check if pCurCrsr points into already existing ranges and delete those.
+ * @param Pointer to SwCursor object
*/
-
-
void CheckRange( SwCursor* pCurCrsr )
{
const SwPosition *pStt = pCurCrsr-Start(),
@@ -96,7 +97,7 @@ void CheckRange( SwCursor* pCurCrsr )
SwPaM *pTmpDel = 0,
*pTmp = (SwPaM*)pCurCrsr-GetNext();
-// durchsuche den gesamten Ring
+// Search the complete ring
while( pTmp != pCurCrsr )
{
const SwPosition *pTmpStt = pTmp-Start(),
@@ -112,54 +113,59 @@ void CheckRange( SwCursor* pCurCrsr )
if( *pStt *pTmpEnd )
pTmpDel = pTmp;
/*
- * liegt ein SPoint oder GetMark innerhalb vom Crsr-Bereich
- * muss der alte Bereich aufgehoben werden.
- * Beim Vergleich ist darauf zu achten, das SPoint nicht mehr zum
- * Bereich gehoert !
+ * If `SPoint` or `GetMark? is within the Crsr range, we
+ * need to remove the old range. Take note that SPoint does
+ * not belong to the range anymore.
*/
pTmp = (SwPaM*)pTmp-GetNext();
-delete pTmpDel; // hebe alten Bereich auf
+delete pTmpDel; // Remove old range
pTmpDel = 0;
}
}
-// -- Methoden von der SwCrsrShell -
+
+
+/**
+ Methods of SwCrsrShell
+ */
+
SwPaM * SwCrsrShell::CreateCrsr()
{
-// Innerhalb der Tabellen-SSelection keinen neuen Crsr anlegen
-OSL_ENSURE( !IsTableMode(), in Tabellen SSelection );
+// don't create Crsr in a table-SSelection (sic!)
+OSL_ENSURE( !IsTableMode(), in table SSelection );
-// neuen Cursor als Kopie vom akt. und in den Ring aufnehmen
-// Verkettung zeigt immer auf den zuerst erzeugten, also vorwaerts
+// New cursor as copy of current one. Add to the ring.
+// Links point to previously created one, ie forward.
SwShellCrsr* pNew = new SwShellCrsr( *pCurCrsr );
-// hier den akt. Pam nur logisch Hiden, weil sonst die Invertierung
-// vom kopierten Pam aufgehoben wird !!
-
-// #i75172#
+// Hide Pam logically, to avoid undoing the inverting from
+// copied Pam (#i75172#) (German comment did not make any more sense,
+// sorry :), the translator)
pNew-swapContent(*pCurCrsr);
pCurCrsr-DeleteMark();
UpdateCrsr( SwCrsrShell::SCROLLWIN );
-// return pCurCrsr;
return pNew;
}
-// loesche den aktuellen Cursor und der folgende wird zum Aktuellen
-
+/**
+ * Delete current Cursor, making the following one the current.
+ * Note, this function does not delete anything if there is no other cursor.
+ * @return - returns sal_True if there was another cursor and we deleted one.
+ */
sal_Bool SwCrsrShell::DestroyCrsr()
{
-// Innerhalb der Tabellen-SSelection keinen neuen Crsr loeschen
-OSL_ENSURE( !IsTableMode(), in Tabellen SSelection );
+// don't delete Crsr within table-sselection
+OSL_ENSURE( !IsTableMode(), in table SSelection );
-// ist ueberhaupt ein naechtser vorhanden ?
+// Is there a next one? Don't do anything if not.
if(pCurCrsr-GetNext() == pCurCrsr)
return sal_False;
-SwCallLink aLk( *this );// Crsr-Moves ueberwachen,
+SwCallLink aLk( *this );// watch Crsr-Moves
SwCursor* pNextCrsr = (SwCursor*)pCurCrsr-GetNext();
delete pCurCrsr;
pCurCrsr = dynamic_castSwShellCrsr*(pNextCrsr);
@@ -168,6 +174,11 @@ sal_Bool SwCrsrShell::DestroyCrsr()
}
+/**
+ * Create and return a new shell cursor.
+ * Simply returns the current shell cursor if there is no selection
+ * (HasSelection()).
+ */
SwPaM SwCrsrShell::CreateNewShellCursor()
{
if (HasSelection())
@@ -177,21 +188,26 @@ SwPaM SwCrsrShell::CreateNewShellCursor()
return *GetCrsr();
}
+/**
+ * Return the current shell cursor
+ * @return
MPL/LGPL blanket license
Just in case some code actually ends up in LibO: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Sebastian Spaeth ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove CREDITS.odt?
On Sat, 09 Jul 2011 15:11:53 +0200, Thomas Arnhold tho...@arnhold.org wrote: This is a good point. Is there any packaging script if a release rolls out? Maybe credits.odt update could be done automatically within this. It was planned to create it automatically via a script. For now, I simply run it from time to time on my laptop, creating an .html file which had been manually converted to .odt. Sebastian pgpaHkLj5v0PP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove CREDITS.odt?
On Mon, 11 Jul 2011 12:24:55 +0100, Michael Meeks michael.me...@novell.com wrote: It was planned to create it automatically via a script. For now, I simply run it from time to time on my laptop, creating an .html file which had been manually converted to .odt. Ah - so, we can prolly do that during the build with a little effort; is your script in git ? perhaps we can add a: 'make prerelease' type script that will do some checks, and create the updated credits file (?). Any chance of a patch for that :-) My script is currently in bitbucket https://bitbucket.org/spaetz/gitanaly/overview and uses mostly Cedric's config files for email aliases and affiliation. (git://people.freedesktop.org/~cbosdo/gitdm-lo-config) I have some local adaptations on who to count as individual and not which I promised people to keep private, but that is not needed for the credit page generation anyway. SHM_GET had intended to move things over to the git contrib repo at some point and set up the creation on one of the LO servers, but I am not sure how far he has gotten there. Sebastian pgp5p7s3BPahN.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] De-Java-ise flat XML export
On Mon, 13 Dec 2010 22:30:50 +0100, Peter Jentsch pj...@guineapics.de wrote: Hi Michael, I'm from Germany, where XSLT at least currently is slightly more popular than COBOL. But compared to, say, python, both are just background noise :) http://www.google.com/trends?q=COBOL%2C+XSLT%2C+pythonctab=0geo=degeor=alldate=allsort=0 SCNR Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes
This 2nd version also uses defines in the form of -DTHEME_CRYSTAL that are being used in the scp2 module. Untested, perhaps someone with a faster compile time than mine can see if the --enable-theme=crystal tango or --enable-theme= or --enable-theme= (the latter 2 options should enable all themes options work as intended. This v2 patch needs to be applied together with the other patch to the packimages module. Someone also might want to check if I introduced forbidden bashisms. I never know. pgpQfyqQ5gn28.pgp Description: PGP signature From 6c379488250f5a3349dfc2d805f70a0f084fe07d Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth sebast...@sspaeth.de Date: Thu, 9 Dec 2010 12:23:55 +0100 Subject: [PATCHv2] Introduce an --enable-theme=theme1 theme2... option By default, we include all defaults as before, but if given, we can limit the number of included themes with e.g. --enable-theme=oxygen tango. This is passed through set_soenv and sets the environment variable ENABLE_THEMES= which can be used by the packimages makefile in the postprocess repository. It also adds defines in the form of THEME_OXYGEN that are being used in the scp2 module to decide if we should install the theme file or not. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- configure.in | 27 +++ scp2/source/ooo/file_ooo.scp |8 set_soenv.in |1 + 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index 7fe1e95..e776f50 100755 --- a/configure.in +++ b/configure.in @@ -487,6 +487,12 @@ AC_ARG_ENABLE(extra-font, [Add extra font content.]), ,) +AC_ARG_ENABLE(theme, +AS_HELP_STRING([--enable-theme=theme1 theme2...], + [Choose which themes to include. By default all available themes are included. + Possible choices: crystal, hicontrast, oxygen, tango.]), +,) + dnl -- Deprecated since 2010-11-05 -- AC_ARG_ENABLE(mysql-connector, @@ -7635,8 +7641,29 @@ else fi AC_SUBST(WITH_EXTRA_FONT) +dnl === +dnl Test which themes to include +dnl === +AC_MSG_CHECKING([which themes to include]) +# if none given, use all available themes +if test z$enable_theme = z -o z$enable_theme = zyes; then + enable_theme=crystal hicontrast oxygen tango +fi + + ENABLE_THEMES= + for theme in $enable_theme + do +ENABLE_THEMES=$ENABLE_THEMES $theme +SCPDEFS=$SCPDEFS -DTHEME_`echo $theme|tr '[a-z]' '[A-Z]'` + done + AC_MSG_RESULT([$ENABLE_THEMES $SCPDEFS]) + +AC_SUBST(ENABLE_THEMES) AC_SUBST(SCPDEFS) +dnl === +dnl Test whether to enable ActiveX embedding +dnl === if test $_os = WINNT; then AC_MSG_CHECKING([whether to enable ActiveX embedding of LibO components]) if test $enable_activex_component = yes -o $enable_activex_component = TRUE -o $enable_activex_component = ; then diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp index 0ab9fa2..64d91e5 100644 --- a/scp2/source/ooo/file_ooo.scp +++ b/scp2/source/ooo/file_ooo.scp @@ -1843,33 +1843,41 @@ File gid_File_Images_Zip Styles = (PACKED); End +#ifdef THEME_CRYSTAL File gid_File_ImagesCrystal_Zip TXT_FILE_BODY; Dir = gid_Dir_Share_Config; Name = images_crystal.zip; Styles = (PACKED); End +#endif +#ifdef THEME_OXYGEN File gid_File_ImagesOxygen_Zip TXT_FILE_BODY; Dir = gid_Dir_Share_Config; Name = images_oxygen.zip; Styles = (PACKED); End +#endif +#ifdef THEME_HICONTRAST File gid_File_ImagesHicontrast_Zip TXT_FILE_BODY; Dir = gid_Dir_Share_Config; Name = images_hicontrast.zip; Styles = (PACKED); End +#endif +#ifdef THEME_TANGO File gid_File_ImagesTango_Zip TXT_FILE_BODY; Dir = gid_Dir_Share_Config; Name = images_tango.zip; Styles = (PACKED); End +#endif File gid_File_Share_Registry_Lingucomponent_Xcd TXT_FILE_BODY; diff --git a/set_soenv.in b/set_soenv.in index cc41e61..4985cb0 100644 --- a/set_soenv.in +++ b/set_soenv.in @@ -1694,6 +1694,7 @@ ToFile( ENABLE_MINIMIZER, @ENABLE_MINIMIZER@,e ); ToFile( ENABLE_PRESENTER_SCREEN,@ENABLE_PRESENTER_SCREEN@,e ); ToFile( ENABLE_REPORTBUILDER,@ENABLE_REPORTBUILDER@,e ); ToFile( ENABLE_UNIX_QUICKSTARTER, @ENABLE_UNIX_QUICKSTARTER@, e ); +ToFile( ENABLE_THEMES, @ENABLE_THEMES@,e); ToFile( SYSTEM_JFREEREPORT,@SYSTEM_JFREEREPORT@,e ); ToFile( OOO_JUNIT_JAR, @OOO_JUNIT_JAR@,e ); ToFile( SAC_JAR, @SAC_JAR@, e ); -- 1.7.1 Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes
On Thu, 9 Dec 2010 13:20:08 +0100, Christian Lohmaier wrote: I'd prefer if those would only be set in scp2 module when those are actually used, and not globally. Sorry, for this my build system foo of LibO is too limited and *I* am not capable of just creating defines in a single module. This means touching dmake files, I would think. Something that I have vowed to avoid at any cost :). So patches and help for that appreciated. --enable is a bad choice for options that accept multiple values IMHO. For multiple argument style ones, I'd prefer --with options.. From the autoconf doc: - If a software package has optional compile-time features, the user can give `configure' command line options to specify whether to compile them. The options have one of these forms: --enable-FEATURE[=ARG] --disable-FEATURE Some packages require, or can optionally use, other software packages which are already installed. The user can give `configure' command line options to specify which such external software to use. The options have one of these forms: --with-package[=ARG] --without-package - I would say, bundling themes fall into the area of compile-time features rather than specifying which external software to use, that's why *I* would go for enable. That having said, I don't feel like fighting over this one, and we can make it a --with option too. Sebastian pgpBW0fgaqEKq.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO status bar annoyances
On Thu, 9 Dec 2010 22:59:37 +0100, Friedrich Strohmaier damokles4-lis...@bits-fritz.de wrote: What You as an individual do use or don't *must not* be a criterium for UI and feature changes. Even and especially not because You are a software developer! Hi Friedrich, this thread already became bigger than I ever intended, and I heard that the state of the statusbar is a regular flamefest. I don't want to awake any flames or add more fuel. over users shoulders. And be assured: *Every* bloddy feature you hid anywhere in the UI has a user(base) using it. That's more valid for the one click available as in the status bar. All I am going to add is: which user prefers single-clicks for some status bar items and double-clicks on others, while some are not clickable at all?. Which user wants to launch dialogs when clicking on apparently empty areas in the statusbar? and finally which user wants 2 separators between icon areas that are really empty? which user wants exclamation marks for default situations rather than suitably subtle icons that show modified doc status? :-) Some things can be universally be improved, other should remain customizable. I do know that there is a reason and a proponent behind all those items. The only proper way to have a Sebastian Spaeth UI of LibreOffice I see: Convince your developer collegues to build an UI framework which allows such changes without affecting other users. :o)) Ohh, but there is much of that possible already. I was able to make myself much happier with a few lines of editing of the statusbar.xml definition. I am not sure what the right approach to finding good UI is. I therefore defer those designs to others. I only know when something bothers me so much that I really want it changed :). Sebastian pgpBVVn5gvgdi.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RC1 / size redux ...
On Tue, 07 Dec 2010 17:55:19 +, Michael Meeks wrote: So - as we all know, RC1 is too large; ... http://users.freedesktop.org/~michael/sizes.ods This is a phantastic analysis, thanks for doing that Michael. Amazing that OTP + license files make 50% of our used space :). As someone who basically never uses those templates I would argue that they could even be split out into some extra ( optional package). People with crappy download rates might more often than not also still be bound by smaller disk sizes. Loosing 40% of the file size sounds like a nice win in itself. Sebastian P.S. BTW, the extension breakdown in my Linux install (including sdk and without language support) looks like this: so 190 Mb html 53 Mb dat 24 Mb ttf 21 Mb No_ext 18 Mb 40 16 Mb 1 16 Mb zip 15 Mb rdb 14 Mb idl 13 Mb jar 12 Mb ott 7 Mb otp 7 Mb db 5 Mb dic 4 Mb ht 4 Mb cfs 4 Mb xsl 3 Mb idx 3 Mb 3 3 Mb wav 2 Mb xcd 2 Mb java 1 Mb res 1 Mb key 1 Mb hxx 1 Mb afm 1 Mb xml 1 Mb bin 1 Mb ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Bundled fonts
By default, we bundle 20MB of TTF fonts that I mostly have installed as system fonts already. We have 2 badly documented configure options: --without-fonts (--with-fonts is the default) and --enable-extra-font (not enabled by default, putting more .ttfs on your disk). Not quibbling about the option naming here (--with vs --enable etc), do we really need to bundle those fonts by default? (DejaVu, Libertine, and Gentium are already quite common on Linux boxes at least, and packages can recommend the respective font packages). I hear that we most certainly need opens___.ttf in any case, so we should bundle that universally, and make --without-fonts the default then. Win32 distros can turn it on in their distro config if they want. That would be 20MB saved on each make dev-install and I wouldnt run danger to pick up the wrong version of the DejaVu fonts. Opinions? Sebastian pgp79U6t89dSM.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Bundled fonts
Sounds good to me; go for it ! :-) OK to push this patch? USer visible changes are: Rename --with-fonts to --enable-fonts and --enable-extra-font to --enable-extra-fonts to make them consistent. Improve help texts. Make it so that --enable-extra-fonts implies --enable-fonts. Both options are turned off by default, distros that want fonts bundled need to set that in their distro conf. Optinions? opens___.ttf will still be bundled in any case From f58b6d6d322d3dbb035117644fcdf7ae3093f97a Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth sebast...@sspaeth.de Date: Wed, 8 Dec 2010 12:21:09 +0100 Subject: [PATCH] Configure --enable-fonts --enable-extra-fonts both disabled by def. Rename --with-fonts to --enable-fonts and --enable-extra-font to --enable-extra fonts to make them consistent. Both options are turned off by default, distros that want fonts bundled need to set that in their distro conf. Make it so that --enable-extra-fonts implies --enable-fonts. Move the options and checks to be next to each other in configure.in Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- configure.in | 57 ++--- 1 files changed, 30 insertions(+), 27 deletions(-) diff --git a/configure.in b/configure.in index 0e60fdd..bc9df97 100644 --- a/configure.in +++ b/configure.in @@ -482,10 +482,18 @@ AC_ARG_ENABLE(extra-sample, [Add extra sample content.]), ,) -AC_ARG_ENABLE(extra-font, -AS_HELP_STRING([--enable-extra-font], - [Add extra font content.]), -,) +AC_ARG_ENABLE(fonts, +AS_HELP_STRING([--enable-fonts], +[Include third-party fonts (DejaVu, Liberation, Gentium, + Libertine G and Linux Biolinum G) bundled with the product. + Enable this if you compile for a platform that does not contain + a sensible set of system fonts already.]), +) + +AC_ARG_ENABLE(extra-fonts, +AS_HELP_STRING([--enable-extra-fonts], + [Bundle even more fonts with the product. (implies --enable-fonts)]), +) dnl -- Deprecated since 2010-11-05 -- @@ -604,13 +612,6 @@ AC_ARG_WITH(extension-integration, [It will integrate the builded extensions to the installer of the product.]), ,) -AC_ARG_WITH(fonts, -AS_HELP_STRING([--without-fonts], -[LibO includes some third-party fonts to provide a reliable basis for - help content, templates, samples, etc. When these fonts are already - known to be available on the system then you should use this option.]), -,) - AC_ARG_WITH(ppds, AS_HELP_STRING([--without-ppds], [Removes Postscript Printer definition files from LibreOffice @@ -7496,7 +7497,7 @@ dnl === dnl Test whether to include fonts dnl === AC_MSG_CHECKING([whether to include third-party fonts]) -if test $with_fonts != no ; then +if test x$enable_fonts = xyes -o x$enable_extra_fonts = xyes; then AC_MSG_RESULT([yes]) WITH_FONTS=YES BUILD_TYPE=$BUILD_TYPE MORE_FONTS @@ -7508,6 +7509,22 @@ fi AC_SUBST(WITH_FONTS) dnl === +dnl Test whether to include extra fonts +dnl === +AC_MSG_CHECKING([whether to include additional fonts]) +if test x$enable_extra_fonts = xyes ; then + AC_MSG_RESULT([yes]) + WITH_EXTRA_FONT=YES + BUILD_TYPE=$BUILD_TYPE EXTRA_FONT + SCPDEFS=$SCPDEFS -DWITH_EXTRA_FONT +else + AC_MSG_RESULT([no]) + WITH_EXTRA_FONT=NO +fi +AC_SUBST(WITH_EXTRA_FONT) +AC_SUBST(SCPDEFS) + +dnl === dnl Test whether to include ppds dnl === AC_MSG_CHECKING([whether to include PPDs]) @@ -7579,22 +7596,8 @@ else fi AC_SUBST(WITH_EXTRA_SAMPLE) -dnl === -dnl Test whether to include extra fonts -dnl === -AC_MSG_CHECKING([whether to include extra fonts]) -if test z$enable_extra_font = z -o z$enable_extra_font = zno ; then - AC_MSG_RESULT([no]) - WITH_EXTRA_FONT=NO -else - AC_MSG_RESULT([yes]) - WITH_EXTRA_FONT=YES - BUILD_TYPE=$BUILD_TYPE EXTRA_FONT - SCPDEFS=$SCPDEFS -DWITH_EXTRA_FONT -fi -AC_SUBST(WITH_EXTRA_FONT) -AC_SUBST(SCPDEFS) + if test $_os = WINNT; then AC_MSG_CHECKING([whether to enable ActiveX embedding of LibO components]) -- 1.7.1 Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comments on RC1
On Wed, 8 Dec 2010 08:04:30 -0800 (PST), plino pedl...@gmail.com wrote: No. LO is NOT working on it. This has been discussed on other topics since late Nov (Beta1 or 2) Yes, they are. Michael Meeks disected the Windows installer and posted information about it just recently. Stop pretending you know what people do when you don't. http://nabble.documentfoundation.org/A-proposal-for-effective-volunteer-friendly-user-support-in-LibreOffice-td1954148i60.html#a1969084 I see a thread on the disc...@tdf mailing list (NOT the LO development list) in which lots of people, but no code-contributing developer participated. And from that you can deduce what people are actually working on? Congratulation to your prophetic abilities! But now Sophie Gautier says exactly the same thing and everybody listens, but the reasoning is that now is not a good time because we are already at RC1 Perhaps because she said it in the developer list? You did see the part by Michael about the correlation between whining and the motivation to actually work on things? I have collaborated (and still do) on several open source projects. I know that. But sometimes provocation is the only way to get noticed and answered to... And sometimes it is the only way to get into peoples virtual or physical kill files. I know I stopped reading mails from you as the mostly contained non-constructive whining, demanding and something that is very close to insulting. If that is what you call collaborating... My contribution is helping others on the Users forum. That is a great contribution and very welcome. Thank you. And I'm willing to report the bugs I find when a proper bug tracker is set up. http://www.documentfoundation.org/develop/ has a whole section called Filing bugs http://wiki.documentfoundation.org contains a link to Information about reporting bugs as the third sentence on the main page. If there are better ways on how to link to the bug tracker, feel free to suggest them. Until then, I propose to bring constructive criticism rather than insults (even if you'd call it provocation). It tends to win more hearts. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Easter eggs, was: Re: Comments on RC1
Your IT department should not allow the use of MS products then: http://en.wikipedia.org/wiki/Easter_eggs_in_Microsoft_products :) Emacs is the worst. It even contains Tetris :-). Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Easter eggs, was: Re: Comments on RC1
Thanks Sebastian for the link. It helps. Saddly, I don't see references on easter eggs for Office 2003 and later. They could just not be found as the code is closed. In contrast to LibO :-P Really, we are not talking virii. We are talking scrolling contributor credits on some key presses and stuff. But it's open source, if people don't want easter eggs, they can always provide a --enable-boring-version option for compilation. Gentoo has a -offensive USE flag too that disables certain stuff. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new bootstrap: How do the devellop[ install?
On Tue, 7 Dec 2010 09:19:52 +0100, Joost Eekhoorn joost.eekho...@gmail.com wrote: Now I want to do something like: bin/ooinstall -l /home/joost/work/libretest But there is no bin/ooinstall ooinstall should actually be available in the path after a build as the Linux*.sh file gets sourced during build. But it's much easier to do make install (for a real installation into /usr/local by default) or make dev-install (for an ooinstall -l installation into the install directory in your build dir). I will update the webpage to not mention bin/ooinstall anymore. Sebastian pgpL0JGPFylp8.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new bootstrap: How do the devellop[ install?
On Tue, 7 Dec 2010 10:39:41 +0100, Joost Eekhoorn wrote: Hi Sebastian, bin/ooinstall is not mentioned on the new webpage. yep, I removed it. Can you mention make dev-install on the webpage? Done, although everything going beyond there real basic instructions is supposed to be in the wiki page, I believe. Can you also mention it in the bash, when the build is ready? make, make dev-install and make check are actually mentioned after each ./configure run I think. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg
On Mon, 06 Dec 2010 14:08:36 +, Michael Meeks wrote: Thanks so much for this Christopher ! what is your next planned feat ? :-) Perhaps removing the bundled libegg project and disable copying it in our install package? :-) Sebastian pgpfAQ227kXmt.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Commit notifications (was: Use GtkStatusIcon instead of libegg)
On Mon, 06 Dec 2010 16:12:50 +, Christopher Backhouse cjbackho...@gmail.com wrote: PS - is there a git commit notification list I can subscribe to? The git web interface is a royal pain to navigate. You could subscribe to the RSS feed at: http://cia.vc/stats/project/LibreOffice which should give you reasonable information about what is happening. Alternatively, do the single repositories (19!) provide RSS feeds via the git webinterface. E.g. http://cgit.freedesktop.org/libreoffice/base/atom/?h=master that you could sign up to. HTH, Sebastian pgpEIeXu46TTj.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] defaulting to --without-java ... (?)
On Fri, 03 Dec 2010 01:50:24 -0700, Tor Lillqvist wrote: Aren't you mixing up two orthogonal issues here? Whether to use Java when building LibreOffice, and whether to have and distribute parts of the LibreOffice end product requiring a Java runtime. Isn't Java used during the build also for some *processing* of data? (Which presumably then is optional, if it is possible to build without Java on the build machine.) OK, granted, I did not think of that. I thought of --enable-java as the user-visible bits. I don't care if developers have to install this or that to get it building. And no, I don't have problems with premade binaries :). Sebastian pgpH0cIlleAL8.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new credits up, now with less contributors
On Fri, 03 Dec 2010 09:32:11 -0500, Kohei Yoshida kyosh...@novell.com wrote: Hmm. My stat looks weird. Kohei Yoshida Commits: 643 Joined: 2009-06-19 Yep, incredible but true, that happened when taking away the build repo. Per IRC discussion added back in. Stats are back to normal. Sebastian pgpuHkHcy9Qfl.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] defaulting to --without-java ... (?)
On Thu, 2 Dec 2010 17:45:17 +0100, Christian Lohmaier wrote: would anyone scream if we defaulted configure to --without-java ? I would. I would not. [ this is primarily for developers ], should make it easier to build Come on, what is hard about installing a JDK? My LibO build failed with the included openjdk, gcj, and sun-jre installed, I had to remove openjdk, and then I had to remove the gcj java stuff, and *only* when I had the sun stuff left, would LibO actually build without screaming about not being able to detect Java. (when I actually had java installed and in my path). I spent about 3 hours to get the right stuff installed. During configure time (which I run often), I am always annoyed as the checking for ant... part takes longest. +1 for disabling. Or let's include Java properly, like we include python. Perhaps dalvik, I am sure Oracle would like that. Oh no! :) Sebastian pgp2yxH0VR0KC.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] defaulting to --without-java ... (?)
On Thu, 2 Dec 2010 20:31:02 +0100, Christian Lohmaier wrote: On Thu, Dec 2, 2010 at 8:22 PM, Sebastian Spaeth wrote: On Thu, 2 Dec 2010 17:45:17 +0100, Christian Lohmaier wrote: would anyone scream if we defaulted configure to --without-java ? I would. I would not. I hope not for the wrong reasons. I hope these are not wrong reasons: - Because I dislike to rely on runtimes that we cannot redistribute on all platforms due to legal restrictions/uncertainties (or can we include the JRE on Windows now?) - Because I dislike to have to install a 65MB runtime on top of a 370MB application, to get an html export filter? (OK, breaking Base is a bummer). With ant, Java comes at 81MB here. - Because I dislike to add yet another build system (ant) on top of dmake and gmake? - Because I think that we should include and focus on as few runtimes as possible? That can be starbasic, vba, python, java, lua or whatnot, but not many of them. - Because I dislike a runtime whose patent grant explicitely does not allow to implement only a subset of the language, preventing us to just ship the parts we need? The portable people will not be happy. - Because I dislike a runtime whose past and future development is very tightly connected to the wills and wishes of a single commercial entity? LibO of all applications should know how that helps speedy development and wide-ranging outside contributions. - Because disabling by default will increase the Leidensdruck to actually implement features that people want in another language. - Being asked whether I would scream if it were disabled in developer builds, I wouldn't scream as I don't use any of the functionality that Java provides to LibO. Fair enough? You might agree with some of the above points or not, and you might give them a different weight than I do, but they are not wrong in my book. Sebastian pgpff3LG9tk2U.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Script to find undocumented classes
On Tue, 30 Nov 2010 18:50:17 +0100, Lubos Lunak l.lu...@suse.cz wrote: On Tuesday 30 of November 2010, Thorsten Behrens wrote: Additionally, I think most classes don't necessarily need detailed docs for all methods in the first place (which may also hurt later merging from OOo), but would already benefit from a two-line mission statement at class level (of course plus some module-level overview of what's inside). I beg to differ. This could be a significant factor for new possible contributors. While patches removing dead code or similar certainly help too, the codebase can move forward only by people writing new code, and that requires understanding of the existing code. I am with Lubos here I have to say. I do see Thorsten's point on that wrong documentation is worse than no documentation, and fixing wrong APIs and function names would be preferred. I also see how it makes merging worse. BUT, as a newcomers, I was very much overwhelmed with millions of lines of code, many of which were not documented at all. And as a newcomer you don't even know what is a core API and what is a seldomly used thing. People who are not intimate with but rather intimidated by the code base, do need these docs to steer around and understand the code. Being able to look up in doxygen what a bFull parameter implies and which effect it has in a function, would be a real boon. Let me give a random real world example that I just pulled up by searching the code base for a bFull parameter :): In /libs-core/editeng/inc/editeng/unofored.hxx we define: QuickFormatDoc( BOOL bFull=FALSE ); What does bFull mean? Not so quick? What portions will be formatted if this is FALSE? Looking at the function it either calls pImpEditEngine-FormatFullDoc(); or pImpEditEngine-FormatDoc(); What the heck is the difference between those functions? Now I have to go another layer deeper to those 2 (both undocumented!) functions. All that FormatFullDoc does: for ( sal_uInt16 nPortion = 0; nPortion GetParaPortions().Count(); nPortion++ ) GetParaPortions()[nPortion]-MarkSelectionInvalid( 0, GetParaPortions()[nPortion]-GetNode()-Len() ); FormatDoc() Excuse me, what does the stuff before we end up in FormatDoc() actually do? It must modify the document somehow as a sideeffect,because we call FormatDoc without any parameter. And it seems to mark some selections as invalid. So perhaps bFull=FALSE only works on selected text? For that I need to dig into what GetParaPortions and ParaPortions actually are and do, which is an *undocumented class* implemented here: libs-core/editeng/source/editeng/editdoc2.cxx. I'd give up at this point, because after reading that much code, I had forgotten what I wanted to do in the first place :). A simple docstring in QuickFormatDoc, such as /** * param bFull determines whether we need to reflow the whole document or only the pieces that are visible on the screen. */ would have saved me much time, and I could actually have improved some code rather becoming a frustrated opengrok hunter.. (note this is a bullshit comment, as I *still* don't know what bFull really does :)). Sebastian pgpAGSX9awKLR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Release note 3.4] Re: Fix for bug/feature request i#8288
On Wed, 01 Dec 2010 14:30:41 +0100, Jan Holesovsky ke...@suse.cz wrote: Patch ensures that after doing replace all the cursor is left at original position, rather than moved to the position of the last replacement. Wow! - what a great usability improvement, with few lines of code :-) Pushed, the only change was using the 8288 as the bug number, instead of 12345. And this in itself is worth a note in the next release notes. Also when people asking about improvements over OOo. We should collect these goodies for future release notes. Ideas how to do that best? Sebastian pgpvGjOBhucFW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] Fix for bug/feature request i#8288
On Wed, 1 Dec 2010 15:31:56 +0100, Lubos Lunak l.lu...@suse.cz wrote: I've figured it out. SwCrsrSaveState only saves the state on the stack, the actual restoring is done by SwCursor::RestoreSavePos(). I'll change the code to use it. While you are understanding the code, can you add some comments to the functions so it is clear how they work? That would be very helpful :). Sebastian pgpBNyB5zdtdp.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LO status bar annoyances
Am I the only one finding the current status bar pretty much useless? About the only thing I actually use there, is the zoom slidebar (and I wouldn't use that if I were able to have a single set 'optimal' zoom button in my toolbar which doesn't seem possible). - What annoys me most is the document modified indicator. If it is unmodified, I see some *empty* separators in the status bar (why do we show empty separators? these should GO GO GO away) and the mouse tooltip over the *empty* separator says this document has not been modified. When I type, I get a document with an exclamation mark, and the tooltip changes to this document has been modified. a) This is the standard state of my documents (see, I tend to modify docs in a editor, DOH), and that exclamation mark purports some sense of urgency and failure. b) We warn when closing a modified doc anyway, so there is no need to always warn me and use up precious space. I propose to just do away with it. - I have to single-click on the INSRT and STD-EXT-ADD-BLK and language selection thingies, but to double-click on the Page 1/1 and Default for something to happen. I just found out by coincidence today that I can launch some action for the latter. - Despite being a heavy writer user, I have no clue what EXT/ADD/BLK mean, or what they are being used for (so I never use it). They have no tooltip whatsoever to give me a clue either. The toolbar help button unfortunately launches the generic help, rather then the more useful what's this. In a what's this mode, I do see a tooltip help (why not always), saying this is about the selection mode. What the selection mode EXTEND, ADD, or BLOCK are, I have still no clue about. Perhaps a right-click on that thing could offer to open a more elaborate help page? (keep the tooltip always in any case). And more fundamentally, do people really change the selection style in their documents to something else? Ever? Does this really require a statusbar item? Help text: Anyway after much search I found the entry in the help page that refers to that feature. I only had to what's this the item, to get to know about Selection Mode and search the help until it discovered the selection modes in text item. It has very useful help. BLK means: A block of text can be selected.. /me slaps heads. How could I not know!!1! (err, can't I select a block of text with the STD as well? How dot they differ? But that's a topic for another day :). - Randomly trying out things and clicking on an empty area in the status bar, brought up a dialog window titled Fields which offered me to insert the Author-Name, if I get it right (playing a bit dumb here). It also has a checkbox for Fixed content (who doesn't want to fix there content, but that is also for another day). Anyway, clicking (actually double-clicking required this time) on an *empty* area should not open mysterious dialog boxes. Where in the code is that collection of mysteries being placed on the statusbar and should I file bugs to put this rant into :-)? Sebastian pgpIppcPxGZKt.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [UX] LO status bar annoyances
Part 2 on the Changed icon part. On Tue, 30 Nov 2010 22:31:44 +0100, Christoph Noack wrote: DOCUMENT CHANGED INDICATION A solution should: * just work * be unobtrusive (don't catch attention if it isn't required, don't waste space) * be self-explanatory (if possible) Right Ideally, we would not need that status bar and change the Save icon depending on whether there are changes that can be saved or not (e.g. overlay it with a yellow asterisk or so). I am one of the persons that agree that the save button should always work. But that doesn't mean that the save button cannot convey information on whether it is currently sensible to do so. (Alternatively gray it out if unmodified, but still allow it to be pressed). This would be my favorite solution. Putting that aside, let's work on making the status bar icon non-annoying, our ideas are pretty much the same. But the current solution isn't perfect, of course. Current issues: * The extended help tip still mentions the '*' for a changed document. Right, tiny issue * For unsaved documents, the normal tool tip mentions The document has not been modified since the last save. (Small issue, may not be changed). I don't have a problem with that, except that I have to mouse over an apparently empty are to see that toolbar. Why not always have an icon that changes appearance? * The red ! is indeed a bit strange considering the importance of this message. And is the main reason of my hate for the icon :). One example of how users sometimes get hung up at very tiny unimportant details. ;) * The icon does not communicate any behavioral difference - it is just a status information, but looks very similar to the view mode buttons etc. I don't have a problem with that. * The double-click behavior is inconsistent to all platforms I know of. It may even be problematic for some users ... personally, I would remove it. You are not saying I can launch an action on that one, can you? /me tries. Uhh, never thought of that. Interesting, but pretty much superfluous. Unfortunately, the discussion has pretty much gone in a direction that suggests I want to do away with a changed indication completely, which is not the case. My 2 main objections are: - the horrid exlamation mark icon (I see exclamation marks in my OS only in case of errors or other severe warnings, not for something I consider the default situation. - if unmodified, we reserve the space showing an empty area with group box separators. Your concluding advice is pretty much congruent with what would do away with my annoyance of the issue. See below: But how to address the issues you raised? My personal take: * Keep the status indicator where it is (in the status bar) Fine with me * If the document is unmodified, add some very subtle document shape. Then, there is a reason for showing a tool tip and the What's that?! effect may be reduced. Which would be great. Now, if we could remove the separator to the right (which are more icons), that would even be greater, but require more coding assume. * For the modified document, reduce the warning level and - maybe - just show a document icon with a yellow star in it. This a) is similar to the old '*', and b) is used for to indicate new documents on certain platforms. Perfect. I had thought about a faint empty doc, versus a fat-bordered doc with text in it, but you suggestion is much better, easier to recognize and more in line with what other editors do. And, just a small intentional idea - what about adding a bit more value to this feature. For example, add the Document is modified. Saved XXX minutes ago. time to the tool tip. If things go wrong, people tend to look at their data files to know how long they have been working on this document - so discarding any changes might then be safe. Would be a nice additional touch if we have that information. Well, I hope this helped anyhow ... I don't know :-) It sure did. Sebastian pgpC8XkTPaC27.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO status bar annoyances
On Tue, 30 Nov 2010 09:54:37 -0500, Kohei Yoshida wrote: a) This is the standard state of my documents (see, I tend to modify docs in a editor, DOH), and that exclamation mark purports some sense of urgency and failure. Sorry I have to disagree there. Thanks for the info Kohei. To avoid duplication, see the mail I just sent as a reply to Christoph Noack's mail. The management summary: * My favorite solution would be to have a) the save button always work but b) have the save button convey the information whether it thinks that it is currently useful or not (grayed out, or overlaid asterisk,...) * More realistically, I don't have anything against a status bar icon if done right, ie: - no tooltips over empty space, and empty separators, and no danger-implying fat exclamation marks. Christoph proposed nice items, that would make me totally happy. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO status bar annoyances
On Tue, 30 Nov 2010 19:50:28 +0100, Cor Nouws oo...@nouenoff.nl wrote: Information given by the status bar, plus the control options it gives, often is important for users I advise. Nobody, lest I, doubts or denies that. But do your users like to remember on which items they have to single, or double-click to launch actions too? :-P I am nor proposing to do away with it, I am proposing to improve it. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO status bar annoyances
On Tue, 30 Nov 2010 16:22:36 +0100, Regina Henschel wrote: Sebastian Spaeth schrieb: Am I the only one finding the current status bar pretty much useless? Yes ;) OK, let me be more precise has improvement potential in its current form :) To learn more about the status bar have a look at http://www.ooowiki.de/StatusLeiste. It is in German and needs an update, but the text shows, that the status bar is a great tool. This is a great document BUT (:-))... the need to write as the first sentence on each item whether it requires a single or a double-click already shows that the status bar items can be improved. The help text on that page is great, eg. BLK is described really nicely. My English within-LO help page say on BLK: A block of text can be selected. ahh, mmh, ohh,...right. WUT? And the item has no tooltip at all by default. If you need to point me to a 3rd party wiki page in German to explain me how selection modes work mean that *we* (as in LO) didn't do a good job. (which I exaggerate to 'useless') To get all the nice extended tips, I have added the button Extended Tips (German Aktive Hilfe) (category Application) to the symbol bar, so that I can switch it easily on and off. Ahh, that is a nice one. Unfortunately, I cannot assign an icon to it, so it is displayed as a very wide text. Thanks. Sebastian pgpX6jeuDSOiR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] rtl_alloc_cache microopt question ( patch)
On Fri, 26 Nov 2010 13:42:29 +0100, Sebastian Spaeth wrote: -if (n = SAL_MAX_SIZE - (RTL_MEMALIGN + RTL_MEMALIGN - 1)) +if (n SAL_MAX_SIZE - 2 * RTL_MEMALIGN DOH, as all those CAP-Macros are constants anyway, the compiler would probably evaluate that to a const value on compile time anyway. I still find the new version easier to read. Sorry for the noise Sebastian pgpLgzQfiC0nY.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ucb/source/ucb compilation error
On Thu, 21 Oct 2010 09:40:53 +0200, Thomas Klausner w...@netbsd.org wrote: -#define OSL_LOG_PREFIX OSL_THIS_FILE : OSL_THIS_FUNC : OSL_MACRO_VALUE_TO_STRING( __LINE__ ) ; +#define OSL_LOG_PREFIX (OSL_THIS_FILE, :, OSL_THIS_FUNC, :, OSL_MACRO_VALUE_TO_STRING( __LINE__ ), ; ) On OOo there is a bug open to remove OSL_THIS_FUNC (or was it an Easy Hack) as it is not doing anyway what it is suposed to do. I propose to check that up and rip it out completely. Sebastian pgpteDtzGGbip.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ucb/source/ucb compilation error
On Thu, 25 Nov 2010 10:47:22 +0100, Sebastian Spaeth wrote: +#define OSL_LOG_PREFIX (OSL_THIS_FILE, :, OSL_THIS_FUNC, :, OSL_MACRO_VALUE_TO_STRING( __LINE__ ), ; ) On OOo there is a bug open to remove OSL_THIS_FUNC (or was it an Easy Hack) as it is not doing anyway what it is suposed to do. This is the bug I thought of, but it is closed as fixed on 09-28: http://www.openoffice.org/issues/show_bug.cgi?id=114290 Sebastian pgp41hXjt5e90.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] main.xdg 2 largest sections not needed on startup?
Hi all, after looking at kcachegrind for a while, I found that a significant amount of our startuptime comes from allocating string memory and comparing strings 400k times, much of it reading the configuration files. I just looked at the .xcd files now and of that I focused on main.xcd because this is likely to be read in on every app start and is by far the biggest .xcd file. Here is a breakdown of all xml sections with their LOC count (as determined by xmllint --format). Each name has a component-data and a component-scheme section it seems, I have not merged them. Anyway, the 2 biggest contenders are perhaps not even needed there. File basis3.3/share/registry/main.xcd: total 63014 lines: The 2 biggest sections are: Labels 14345 + 11 lines (defining label sizes for printing envelope labels) TableWizard 8666 + 26 lines These make 1/3 of main.xdg, are both needed on startup or can those be put into a different file that is only read when it is really needed? Sebastian Breakdown follows: 14345 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Labels oor:package=org.openoffice.Office 8666 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=TableWizard oor:package=org.openoffice.Office 8539 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=VCL oor:package=org.openoffice 5414 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=GenericCommands oor:package=org.openoffice.Office.UI 5305 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Accelerators oor:package=org.openoffice.Office 1854 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=DrawImpressCommands oor:package=org.openoffice.Office.UI 1618 oor:component-schema oor:name=Common oor:package=org.openoffice.Office xml:lang=en-US 1478 oor:component-schema oor:name=Writer oor:package=org.openoffice.Office xml:lang=en-US 1447 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=WebWizard oor:package=org.openoffice.Office 969 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Math oor:package=org.openoffice.Office 785 oor:component-data oor:package=org.openoffice.TypeDetection oor:name=GraphicFilter 659 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Writer oor:package=org.openoffice.Office 653 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=DataAccess oor:package=org.openoffice.Office 609 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=ChartCommands oor:package=org.openoffice.Office.UI 595 oor:component-data oor:package=org.openoffice.TypeDetection oor:name=Types 522 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=DbuCommands oor:package=org.openoffice.Office.UI 471 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Controller oor:package=org.openoffice.Office.UI 448 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Security oor:package=org.openoffice.Office 389 oor:component-schema oor:name=Calc oor:package=org.openoffice.Office xml:lang=en-US 372 oor:component-schema oor:name=Impress oor:package=org.openoffice.Office xml:lang=en-US 323 oor:component-schema oor:name=DataAccess oor:package=org.openoffice.Office xml:lang=en-US 320 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Setup oor:package=org.openoffice 316 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Inet oor:package=org.openoffice 274 oor:component-schema oor:name=Draw oor:package=org.openoffice.Office xml:lang=en-US 245 oor:component-schema oor:name=WriterWeb oor:package=org.openoffice.Office xml:lang=en-US 238 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Accelerators oor:package=org.openoffice.Office 230 oor:component-data oor:name=Drivers oor:package=org.openoffice.Office.DataAccess 227 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=UI oor:package=org.openoffice.Office 216 oor:component-schema oor:name=UI oor:package=org.openoffice.Office xml:lang=en-US 194 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Calc oor:package=org.openoffice.Office 191 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=StartModuleCommands oor:package=org.openoffice.Office.UI 186 oor:component-schema oor:name=Math oor:package=org.openoffice.Office xml:lang=en-US 186 oor:component-data oor:name=Drivers oor:package=org.openoffice.Office.DataAccess 176 oor:component-data xmlns:install=http://openoffice.org/2004/installation; oor:name=Configuration
Re: [Libreoffice] Windows installer: what languages in multi/all_lang? - SDK: Why different version number?
On Tue, 23 Nov 2010 15:55:39 +0100, Christian Lohmaier wrote: The question was more targeted with regard to (automatically) creating a download page - first iteration http://pumbaa.ooodev.org:7780/home/download-and-sub/ - modeled after the initial one from Stefan http://wiki.documentfoundation.org/User:StefanW/Download_Selection Very cool! Can it be taught that my Ubuntu system prefers .deb rather than the .rpm? This is my user agent string in case it helps: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13pre) Gecko/20101117 Ubuntu/10.10 (maverick) Namoroka/3.6.13pre Sebastian pgpMtvJbSnik9.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
On Wed, 24 Nov 2010 11:48:01 +0100, Sebastian Spaeth wrote: To my absolute shame, I had filed the marker bug to not forget it but still haven't done or moved anything. So that should be resolved at the same time, or has Joe already done it? If so, can you mark as resolved? https://bugs.freedesktop.org/show_bug.cgi?id=31679 Now that Joe already had removed the code using this, I could move the files in git, so the above bug is resolved and the marker images are in the hicontrast theme. Thanks! Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Licenses (was: Impress)
Sorry for getting back to this minor issue, but it annoyed the heck out of me :): On Tue, 23 Nov 2010 15:33:08 +, Michael Meeks michael.me...@novell.com wrote: and are we still shipping a per-language, duplicate license ? Apropos Licenses, I had a look at our LICENSE (13kb) and the hidious THIRDPARTYLICENSES.html (411kb) in the root dir. I guess, I was the 1st human being to do so. 1) LICENSE contains LGPGL, GPLv3 + *everything* that is also in THIRDPARTYLICENSES.html (so the latter is redundant anyway). 2) THIRDPARTYLICENSES.html is a concatenation of html files, including tons of .../htmlhtml... in the middle of the file. I want to see the web browser that copes with that mess. 3) The licenses are concatenated together sometimes even without a blank line or any other separator between them, making it extremely hard to see where one license ends and another one starts. Someone reallly needs to review that. 4) We seem to put that crap dynamically together (?) but my Linux still contains the License for the MS Runtime stuff, .NET EULAs, and NSIS installer. (not sure that hurts though) 5) Our .html has less content and is 20x larger than the text variant, so something in our html is clearly wrong (besides its broken syntax). I think a table of content and some hyperlinking (to not include the LGPL multiple times) would be good, so perhaps .txt is not the best format. How should we deliver the licenses? Just .html? some markdown or .rst syntax? In any case, at least we should get rid of the redundand THIRDPARTYLICENSE.html thingie. Sebastian pgptUMraCWLtV.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 5 times LGPL installed
On Fri, 19 Nov 2010 15:45:08 +, Michael Meeks michael.me...@novell.com wrote: Hi there, On Fri, 2010-11-19 at 13:53 +0100, Sebastian Spaeth wrote: - Module readlicense_oo needs to be modified to not produce them. Patch is in git (and reverted again). oh - shame - why reverted ? Because my build was failing left and right, but as you said, a reboot (or clean shell) might have been all that was needed. I'll investigate this and if it works out this time, I'll push. So I had to revert this. If someone tackles it, can we put the README and LICENSE in the existing directories please? Currently 8 out of 13 topdir entries in our installation refer to some readme or license. Right - this is really silly. Still trying to understand what scp2 does and how it decides where to put stuff. I'll investigate and do that at some point. Sebastian pgpL7pyP5Ptvu.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] (no subject)
Hi all, here some nice stats. Summary, is that we lost 34,000 lines of code since we started to code on LO... I used SLOCCount by David A. Wheeler to check our project size. At the time of the fork ie the LIBREOFFICE_CREATE tag our clone directory was this big: Total Physical Source Lines of Code (SLOC) = 5,671,599 Totals grouped by language: cpp:4731322 (83.42%) java:401786 (7.08%) xml: 185842 (3.28%) ansic: 133211 (2.35%) pascal: 103341 (1.82%) perl: 70676 (1.25%) sh: 15889 (0.28%) Current Master is this big: == Total Physical Source Lines of Code (SLOC) = 5,638,347 Totals grouped by language: cpp:4714769 (83.62%) java:401831 (7.13%) xml: 186150 (3.30%) ansic: 119903 (2.13%) pascal: 103360 (1.83%) perl: 66601 (1.18%) sh: 15797 (0.28%) [snip] Hope you like it Sebastian pgp09iLjPbnuh.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] installation and package for Linux SYS distro sucessful
On Fri, 19 Nov 2010 07:04:56 -0400, werner wrote: I reclaimed about problems with the installer. Meanwhile, after many work by hand, I get it installed (the most complete installation I got, was with 'make install', not with 'bin/ooinstall'). The build program needs to be improved very. Glad to see you managed to install it finally. We will be the first to agree that the current build/make install system is far from optimal. But it has grown for 10 years as part of OpenOffice.org and although we would like to change it to something more standard rather today than tomorrow, it is an incredibly huge and intertangled mess of code which is not easy to change. We welcome any help to get the build system sane, but as I said, it is not easy and cannot be fixed within a day. libreoffice runs nice on my computer, appearently without problems, even the quickstart program too, and the program opens fast. Good that it seems to work for you. I dont get it compiled with the --with-lang option, because of the error what I reclaimed earlier today. So I currently have it only in english. The installer should have the possibility to compile each module (each .tar.bz2 source file) separately, specially language packages. Yes, it should. AFAIK, and I am no expert in packaging, debian at least manages to get independent language .deb packages, so it must be possible already today. I made a .tgz package, for the SYS distro, what very likely runs also on Slackware etc. Currently its rsync-ing to the mirror ftp://ftp5.gwdg.de/pub/linux/install/sys Great to see libO spreading. With this, the distro changed from Oo to libO. \o/ I hope now, that you bring forward good libO . We'l do our best. But it is 10m lines of code and changes are not easy. Help is always welcome Sebastian pgpK9yKYr4mjk.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Tango icon theme leftovers
Hi all, this is a list of 412 icons that are in the tango theme, but not in the default_images theme. Some of the are obvious High contrast icons that can be killed. But what about others? Should I delete those? (I kept the .xcb.bz2 and .svg as source files in the tango theme). See the full list of files below. Permission to kill, or should they be examined in more detail first? (On the other hand we have 3766 files more in default_images than we have in the tango theme.) ./dbaccess/res/bookmarkcontainer_sx.png ./dbaccess/res/bookmark_sx.png ./dbaccess/res/db_deleted.png ./dbaccess/res/db_modified.png ./dbaccess/res/db_new.png ./dbaccess/res/docedit_sc.png ./dbaccess/res/docopen_sc.png ./dbaccess/res/formnew_sc.png ./dbaccess/res/lc010.png ./dbaccess/res/lc011.png ./dbaccess/res/lc012.png ./dbaccess/res/lc013.png ./dbaccess/res/lc014.png ./dbaccess/res/lc021.png ./dbaccess/res/lc023.png ./dbaccess/res/lc05621.png ./dbaccess/res/lc09.png ./dbaccess/res/lc12252.png ./dbaccess/res/linkdrop_sc.png ./dbaccess/res/linkedit_sc.png ./dbaccess/res/linknew_sc.png ./dbaccess/res/querydrop_sc.png ./dbaccess/res/queryeditdesign_sc.png ./dbaccess/res/queryeditsql_sc.png ./dbaccess/res/querynewdesign_sc.png ./dbaccess/res/querynewsql_sc.png ./dbaccess/res/rename_sc.png ./dbaccess/res/sc010.png ./dbaccess/res/sc011.png ./dbaccess/res/sc012.png ./dbaccess/res/sc013.png ./dbaccess/res/sc014.png ./dbaccess/res/sc021.png ./dbaccess/res/sc023.png ./dbaccess/res/sc05621.png ./dbaccess/res/sc09.png ./dbaccess/res/sc12252.png ./dbaccess/res/tabledrop_sc.png ./dbaccess/res/tableedit_sc.png ./dbaccess/res/tablenew_sc.png ./lc10713.png ./res/commandimagelist/ar/lc_underlinedouble.png ./res/commandimagelist/ar/sc_underlinedouble.png ./res/commandimagelist/lc_adddirect32.png ./res/commandimagelist/lc_fontcolor-alt.png ./res/commandimagelist/lc_graphicdraft.png ./res/commandimagelist/lc_insertapplet.png ./res/commandimagelist/sc_graphicdraft.png ./res/commandimagelist/sc_insertapplet.png ./res/hldocntp.xcf ./res/hldoctp.xcf ./res/im30819.png ./res/lc05303.png ./res/lc05501.png ./res/lc05502.png ./res/lc0.png ./res/lc05556.png ./res/lc10107.png ./res/lc10113.png ./res/lc10243.png ./res/lc10375.png ./res/lc10376.png ./res/lc10863.png ./res/lc10864.png ./res/lc10865.png ./res/lc10866.png ./res/lc10867.png ./res/lc10868.png ./res/lc10869.png ./res/lc10907.png ./res/lc10908.png ./res/lc10937.png ./res/lc12201.png ./res/lc12203.png ./res/lc12231.png ./res/lc12235.png ./res/lc12236.png ./res/lc12237.png ./res/lc12238.png ./res/lo03123.png ./res/lo03126.png ./res/lo03127.png ./res/lo03129.png ./res/lo03130.png ./res/lo03139.png ./res/lo03144.png ./res/lo03162.png ./res/lo03163.png ./res/lo03216.png ./res/lo03226.png ./res/lo03227.png ./res/lo03228.png ./res/lo03242.png ./res/sc05303.png ./res/sc06694.png ./res/sc10108.png ./res/sc10113.png ./res/sc10116.png ./res/sc10375.png ./res/sc10376.png ./res/sc10907.png ./res/sc10908.png ./res/sc10937.png ./res/sc12201.png ./res/sc12203.png ./res/sc12231.png ./res/sc12235.png ./res/sc12236.png ./res/sc12237.png ./res/sc12238.png ./res/sch06694.png ./res/sco206.png ./res/so03123.png ./res/so03126.png ./res/so03127.png ./res/so03129.png ./res/so03130.png ./res/so03139.png ./res/so03144.png ./res/so03162.png ./res/so03163.png ./res/so03216.png ./res/so03226.png ./res/so03227.png ./res/so03228.png ./res/so03242.png ./sc10713.png ./sch ./sch/res ./sch/res/lc10242.png ./sch/res/lc30514.png ./sch/res/lc30528.png ./sch/res/lc30529.png ./sch/res/lc30530.png ./sch/res/lc30531.png ./sch/res/lc30532.png ./sch/res/lc30533.png ./sch/res/lc30534.png ./sch/res/lc30535.png ./sch/res/lc30536.png ./sch/res/lc30539.png ./sch/res/lc30586.png ./sch/res/sc10242.png ./sch/res/sc30514.png ./sch/res/sc30528.png ./sch/res/sc30529.png ./sch/res/sc30530.png ./sch/res/sc30531.png ./sch/res/sc30532.png ./sch/res/sc30533.png ./sch/res/sc30534.png ./sch/res/sc30535.png ./sch/res/sc30536.png ./sch/res/sc30539.png ./sch/res/sc30586.png ./sd/res/apply.png ./sd/res/extras.png ./sd/res/fadeout.png ./sd/res/imagelst/lc05928.png ./sd/res/imagelst/lc10245.png ./sd/res/imagelst/lc10299.png ./sd/res/imagelst/lc27008.png ./sd/res/imagelst/lc27014.png ./sd/res/imagelst/lc27015.png ./sd/res/imagelst/lc27017.png ./sd/res/imagelst/lc27019.png ./sd/res/imagelst/lc27022.png ./sd/res/imagelst/lc27028.png ./sd/res/imagelst/lc27031.png ./sd/res/imagelst/lc27032.png ./sd/res/imagelst/lc27036.png ./sd/res/imagelst/lc27037.png ./sd/res/imagelst/lc27046.png ./sd/res/imagelst/lc27051.png ./sd/res/imagelst/lc27054.png ./sd/res/imagelst/lc27055.png ./sd/res/imagelst/lc27056.png ./sd/res/imagelst/lc27057.png ./sd/res/imagelst/lc27058.png ./sd/res/imagelst/lc27059.png ./sd/res/imagelst/lc27060.png ./sd/res/imagelst/lc27062.png ./sd/res/imagelst/lc27063.png ./sd/res/imagelst/lc27064.png ./sd/res/imagelst/lc27085.png ./sd/res/imagelst/lc27090.png ./sd/res/imagelst/lc27091.png ./sd/res/imagelst/lc27095.png ./sd/res/imagelst/lc27098.png
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: 1) one would just run build -- dbglevel=2 in the desired module similarly as one runs build -- debug=true today. 2) As an alternative, we could add optional level argument to --enable-debug or add another option, say, --enable-assertions, that would do the same thing as --enable-debug and export dbglevel=1 in addition. 2) is more complicated, but also more discoverable and explicitely documented. I dislike secret ENVVARIABLE incarnations that enable things and not easily discoverable without trawling through READMEs. So: --enable-debug=2 (with 1 being the default) or --enable-assertions (==--enable-debug=1) would be my preferred choice. Sebastian pgpPBkfWTofTh.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo
On Fri, 19 Nov 2010 04:18:46 +0100, Jan Holesovsky wrote: In case you are interested to try to build without the 'build' repo (the rawbuild/ way), you can try to get the feature/rip-build-repo branch which I hope is going to become the 'official' way of building soon ;-) Very cool, I look forward to switching to this very soon, to get one canonical way of building. Personally, I would be very much in favor of doing ./g clone and ./download automatically if they haven't been done, as part of the make. This is the sequence that I intuitively (naively?) expect to work: ./autogen ./make ./make check ./make install We can always have a --disable-downloads switch that one can turn on if he wants a true ofline mode. Sebastian P.S. I don't like to clutter top-level dirs and would be in favor of keeping it as bin/g, but that's a minor issue. pgplR4MviFsbn.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] STAR_RESOURCEPATH env variable
On Thu, 18 Nov 2010 19:50:01 +, Michael Meeks wrote: This is used by 'ooenv': export STAR_RESOURCEPATH=`pwd`/../basis-link/program/resource Ooops, thanks for the pointer. I am glad I asked before removing seemingly obsolete code pieces. Perhaps I should insert a code comment explaining where it is still used :). Sebastian pgp5OQ5BzJzgb.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
On Tue, 16 Nov 2010 19:54:17 +, Andrew C. E. Dent wrote: * brand/shell * Still in Default (not sure if this is used? Would suggest deletion...):backing_hc-pt_BR.png , backing_right_hc-pt_BR.png All artwork in hicontrast is just stock (not hc). I have created a HC replacement (just hacked together), that saves 53.5KB 0.8KB! Download here:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip Deleted the identical HC ones. Did not take your HC version, as someone should make a decision whether we need a HC logo on that one, I guess. * chart2 * Move 7x HC icons from Default to hicontrast:dataeditor_icon_h0*.png done * dbaccess * Delete two extra icons from hicontrast:sx03187.png , sx16670.png Done * framework *Replace Branding images in hicontrast as before:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip Why is that duplicated in the first place? I have simply deleted the highcontrast ones for now as they are identical with the normal ones. * res * In hicontrast, delete 6x stock filetype icons:od*_32.pngThese are something we probably want to eventually replace with proper HC icons when the final Done * sfx2 * Move closedochc.png done * svx/source/svdraw * From Default, move over (and check this doesn't break LibO!):cropmarkersACC.png , markersACC.png requires code changes, so not done yet. Filed a bug so I don't forget it. * toolkit/source/awt *From Default, move over 12x HC spinner images:spinner03-32-hc_0*.png done * vcl * Move closedochc.png done * General *Remove all Placeholder icons (Red cross on Yellow square) from hicontrast theme. They have not been stripped from Default yet, but we might as well cleanup here anyway. They may be 122, 161 or 170 bytes. Can be found in (but may not be limited to...):res/ and res/commandimagelist/ not done yet, if someone comes up with a file list of those that would be appreciated. I will rebuild LO first from scratch to make sure that moving the icons over doesn't break anything and will commit then. Thanks! Sebatian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 5 times LGPL installed
We use up 3 MB in order to copy the LGPL 5 times in my LO install folder. I know we care about obeying to licensing, but isn't that a bit over the top? And I guess that if I installed more languages I would get it even more often... .: 164K LICENSE.odt 629K LICENSE.html 419K LICENSE licenses: 629K LICENSE_en-US.html 419K LICENSE_en-US Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
On Tue, 02 Nov 2010 10:21:49 +, Michael Meeks michael.me...@novell.com wrote: Currently our hicontrast theme is built by packimages/pack/makefile.mk: # generate the HiContrast icon set $(MISC)$/hicontrast.flag .PHONY : $(PERL) $(SOLARENV)$/bin$/hicontrast-to-theme.pl $(SOLARSRC)$/default_images $(MISC)$/hicontrast $(TOUCH) $@ Which runs a script that build that theme. Not anymore! I just pushed a change to master that - moved artwork/default_images/all the hicontrast images to artwork/ooo_custom_images/hicontrast/... - deleted the hicontrast-to-theme.pl script and removed the above unneccessary blurb from the makefile. So ! :-) I suggest that we start by using the above perl script to create an entirely new theme (in artwork/) hicontrast - that is essentially the results of hicontrast-to-theme.pl - with all of the 'h' variants removed from it. Done :). I do hope there is no fallout and things work as they are intended to work. Sebastian pgpQkZgTkpebf.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error Building
On Tue, 16 Nov 2010 10:06:38 +, Nigel Hawkins n.hawk...@gmx.com wrote: Just done a pull and am now getting a build error: Entering .../build/rawbuild/svtools/util Making:svten-US.res Compiling: rsc_svt f268: Error: The image(s) lxh03124 lxh03125 lxh03131 lxh03132 lxh03134 ... The high contrast images have been moved out into their own theme directory. Remove the unxl*.prj dir and rebuild. If that does not help, you might have to make a make clean. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error Building
On Tue, 16 Nov 2010 11:28:28 +0100, Sebastian Spaeth sebast...@sspaeth.de wrote: On Tue, 16 Nov 2010 10:06:38 +, Nigel Hawkins n.hawk...@gmx.com wrote: Just done a pull and am now getting a build error: Entering .../build/rawbuild/svtools/util Making:svten-US.res Compiling: rsc_svt f268: Error: The image(s) lxh03124 lxh03125 lxh03131 lxh03132 lxh03134 ... The high contrast images have been moved out into their own theme directory. Remove the unxl*.prj dir and rebuild. If that does not help, you might have to make a make clean. Let me correct myself, I still get this failure. It suffices to go to svtools/util and issue dmake. But the name of the icons doesn't occur at all in svtools (or any other repo for that matter). So I have no clue where that is coming from. Help appreciated. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (no subject)
On Tue, 16 Nov 2010 17:28:46 +, Michael Meeks wrote: Fun - so, of course, statistics without a robust interpretation can be rather dangerous :-) Right, and netto LOC is a pretty bad measure of productivity and effectiveness, even if things like COCOMO (?) models andwhatnot suggest otherwise. Most of the code loss is probably removing code that has been #ifdef 0 out, or similar. Still a fun trivia that one can ask the audience at a conference :). Sebastian pgpi4TtynrQ1E.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Easy Hacks: Translation of Comments from German to English
On Mon, 15 Nov 2010 23:54:33 +0100, Daniel Di Marco d.dima...@gmx.de wrote: PUSHED. Nice translations. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks michael.me...@novell.com wrote: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. +1 for removing that beast anyway. Sebastian pgpiwvdu3P3U0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove some comments / dead code in calc
Pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
On Sat, 13 Nov 2010 14:35:48 +0100, Kálmán „KAMI” Szalai wrote: Hi! What about to not to move but copy the HC set and crate the new HC set now? This way we have more time to test (and/or) fix @ optimize the newly created HC inconset. Copying them over would mean, our download tarballs qould bloat by another 10 MB or so ( I guess git would be able to handle that efficiently though). But why copy? THe high contrast images are not being loaded anymore anyway, so we can move them over without loss of functionality. I did a clean build today, and it finished, but failed in the very end, complaining about a missing crystal-icon.tar or whatever. I'll need to investigate this next week, and when we can build successfully, I am going to move the high contrast images over. Sebastian pgp9jXtWKTqdy.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix the last commit in build repository.
On Sat, 13 Nov 2010 16:09:26 +0100, Giuseppe Castagno wrote: --- a/bin/install-artwork +. bin/setup While that patch might fix things, I believe a script in ./bin should not assume anything about what the current working directory is. We should either use a relative directory, relative to the script location. Or we should source some configuration file created by ./configure to read in the relevant directories. Sebastian pgp422ms41TvP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in base
On Sun, 14 Nov 2010 17:32:47 +0100, Pierre-André Jacquod wrote: hello, it seems base in now clear (this one had spaces,...) PUSHED ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD
On Thu, 11 Nov 2010 21:32:44 +0100, Robert Nagy rob...@openbsd.org wrote: +if test z`uname -s` = zOpenBSD; then + TAR=gtar +else + TAR=tar +fi Just out of curiosity. In what ways is the BSD tar different that it breaks? Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove wrapcmd from perl installer
On Mon, 8 Nov 2010 20:04:11 -0600, Jordan Ayers jordan.ay...@gmail.com wrote: Minor cleanup item I saw when preparing my last patches. Reasonable enough. Pushed Sebastian pgpBEuh6O5fDz.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Removed BmpColorMode from too classes in libs-gui
Pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD
Al the stupid GNU double dash arguments, in this case --exclude :) It tries to exclude .svn. Do we need that or can't we get rid of it? We are a git-shop. :) Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD
On Fri, 12 Nov 2010 03:41:05 -0700, Tor Lillqvist tlillqv...@novell.com wrote: The outer configure.in already takes a --with-gnu-tar option and sets the GNUTAR autoconf substitution, isn't it easier to use that, and make the indicated GNU tar propagate to bin/install-artwork some way? The inner configure.in doesn't have that option, it will always bomb out if gnu tar is not installed and does AC_SUBST(GNUTAR), so we could use and propagate that as well. BTW, when do we unify our build methods? :-) Sebastian pgp5X5THx89sx.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
On Fri, 12 Nov 2010 10:32:04 +, Michael Meeks wrote: - Shift+Del permanently removes the file right then. Which makes me wonder; should shift-del give you this 'delete contents' option in that mode (or is the menu sufficient). Yes, that is how I would expect it. del doing the most common thing and special functions via modifiers Ctrl or Shift (instinctively I'd try Ctrl first) Sebastian pgpYlg2kImz8H.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
On Wed, 10 Nov 2010 13:33:22 +, Michael Meeks wrote: Hah ! it is you I guess - you just volunteered. HAH; I should have known :) We need to fixup this hicontrast-to-theme.pl script - so that we can base it from a (new) base-directory as well; say ooo_custom_images/highcontrast Busy right now, I'll have a look at it next week if nobody beats me to it. The key is (of course) to only move/rename those files for which we already have patches :-) AHA, I should have known that there is a catch! :). But isn't there a fallback mechanism? I'd rather move all images in one go and either use the fallback mechanism or have the build break until we fix all the mentions of the hi-contrast icons. Probably something that I could try in a feature branch. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Canonical has a vacancy for a LibO specialist software engineer
On Thu, 11 Nov 2010 12:03:32 +0100, Rene Engelhard r...@debian.org wrote: It's a unsolicited commercial mail. Réne, we say on the *initial* page on http://documentfoundation.org about the foundation: It welcomes corporate participation, e.g. by sponsoring individuals to work as equals alongside other contributors in the community. and on the development page we say: Come and join us! Subscribe to our mailing lists and support us with your skills! We have basically asked for these types of mails and I am very happy to see them coming in. Independent on which organizatino will be paying the bill. This one is very much on-topic. Also, it has not been the organization sending the mail, but one individual who (rightfully) thought people could be interested to get more resources to dedicate time to LO. But I am going to shut up now on this thread. Sebastian pgpTpTWFa8RYP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] High Contrast Cleanup
Attachment: 0001-Bitmap-Tree-Cleanup-base.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-calc.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-components.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-filters.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-impress.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-libs-core.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-libs-gui.patch (application/octet-stream) Attachment: 0001-Bitmap-Tree-Cleanup-writer.patch (application/octet-stream) Applied all those to current master and build. Starts fine, I opened a new text,calc,draw,impress, and database and all the toolbar icons are there, so I can't see any breakage. Pushing this now. Get us more of this! :-) Sebastian pgpw1nALJEc39.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
So who would be able to make sure that we don't bundle the high contrast icons in our buld anymore (and either purge those files or move them to a high contrast theme...) ? Sebastian pgpji8OdQCXdH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] More translations and code cleanup in Base
On Wed, 10 Nov 2010 09:35:15 +, Wols Lists wrote: Thanks, straightforward enough. Pushed. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] UX opportunity ... / Easy Hacks
On Wed, 10 Nov 2010 10:27:13 +0100, Michel RENON wrote: I've been coding with C++ years ago, now i code mostly in PHP and Python (OpenERP). I'm also interested in UX and ergonomics, and i've made a (not so complete) proposal for Renaissance project Cool, welcome. Always glad to receive suggestions, and even more people helping to fix things. Since you know some C++, you could even help with that. Don't be afraid, the time most of this C++ has been written was when you were still coding in C++. :) And in which category of easy hacks should I insert them ? Easy Hacks are usually pretty specific in terms of coding activity. But do file your requests as bugs on bugs.freedesktop.org, it is easier to work through them one-by-one. * MacOS : cursor visibility : when I type some text, mouse pointer should be hidden (the arrow or the I-beam). It's a standard behaviour on Mac since... 1984 ! Apparently our Mac OSX gui gets very little love. One person has repeatedly asked to remove the pinstripes in the dialogs too. Perhaps this is something to get involved with? - add a menu Save a copy as... Isn't that the same as the Export menu? - today, when you want to insert a spreadsheet or draw object in writer, you have to do : select menu Insert Object OLE object, then choose a line in a dialog ! It should be much simpler ! most people don't know what OLE means. Wholeheartedly agreed! Sebastian pgpoyxlB2hfx1.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] High Contrast Cleanup
Michael Meeks wrote: Did you mean to add a 'Pushed' to the Subject ? :-) [ it looks like you did ] No, because I had done that already after pushing ;-P Cheers Sebastian pgpGHZxWxLHkL.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] easy hacks, commented code removal
On Mon, 08 Nov 2010 12:42:24 -0500, Kevin Hunter wrote: Here's another set of patches. Caolán, I think I've done a little better on the comments this time, but probably not yet perfect. accessibility/ Thanks, I am taking this one. Will review then push as appropriate. Looking good so far. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] easy hacks, commented code removal
Pushed all patches but #4 which does nothing but removing #--- lines between functions, which *I personally* don't consider buggy. Otherwise mostly good. Please make sure to not remove the newlines after the last vi modeline. There were a few of that that I had to fix. Sebastian pgpzvcWBYz8p0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] accessibility easy hack, RTL
On Mon, 08 Nov 2010 12:43:45 -0500, Kevin Hunter hunt...@gmail.com wrote: Hullo List, Another RTL_CONST patch, also against accessibility/ . Pushed, thanks Sebastian pgp3oHLdWa5bJ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Renaming extension options consistently
On Wed, 10 Nov 2010 05:29:34 +0100, Jan Holesovsky wrote: 1) if the user specifies max-cpus, do we want max-jobs to default to max-cpus? Because that does make sense afaict. The buildsystem is a bit strange in this regard ;-) There are 2 levels of what is done in parallel - one on the level of directories, and one on what is done in the directory itself. Ie. if you did what you propose, you'd get max-cpus * max-jobs in the 'ideal' situation. We might explain that a bit better in the configure help text. I always forget which is the exquivalent to make -j n. Perhaps in the brave gnu (make) world, we can simplify that to one switch? 2) why is the system so keen on ice-cream? Is it because it's a java technology? I note it's incompatible with distcc (which is what I've got, and which isn't much use without a pc farm). I've noticed other people moaning about ice-cream so should we remove all the why haven't you got it? stuff, or just disable it if distcc is installed? +1 for quiet down the icecream advertisment a bit, we should rather put instructions for that in our wiki. If someone configured to use distcc, we should not output icecream related stuff at all. So who comes up with a patch :-)? Sebastian pgpmXVRTRqYOw.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] patches as attachments or mails? (Poll included)
I think, I'll add a how to prepare and send patches section to the wiki, as that causes lots of confusion. Is there consensus by committers whether we want to have patches attached to a mail or sent inline with git send-email? Depending on the outcome, I'll write up the recommendation accordingly. If you are a committer, please note your opinion on this simple 2-choice online poll with a single click: http://host1.easypolls.net/poll.html?p=29601 More elaborate options as reply to this thread :). Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [Patch] ure: Remove bogus WITH_CORE debug code which core dumps
On Mon, 08 Nov 2010 14:59:37 +0100, Sebastian Spaeth wrote: There was #ifdef'd test code depending on WITH_CORE being defined (which is never set in our build system). It is described as test code that will core dump for sure. So let's remove this and write proper cppunit tests instead. All this concerns two files in 'qa' and not real source code. This has been pushed now. Sebastian pgpfqcCSbJLNS.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Perl Installer: Remove commented out code.
On Mon, 8 Nov 2010 22:23:07 -0600, Jordan Ayers jordan.ay...@gmail.com wrote: Some more cleanup for the perl installer. Thanks, pushed as 4e7555bf001050752e7380c54dd804fa9566d7ad Removing nearly 500 lines of commented out code. I just left one hunk that seemed remotely usefull for future improvements. Sebastian pgpQEqNDfTSzG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] New credits page up (and linked from TDF)
On Mon, 8 Nov 2010 17:20:25 +0100, Thorsten Behrens wrote: Ah sorry, my backlog is building up - I actually added that feature - now we only need a nice credits .odt. ;) Mmh, I tried to import the .html into LibreOffice, but it looks pretty crappy. If someone can come up with a nice template page in .odt format, I can copy in the data table easily. Sebastian pgp39t2pETWzB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Renaming extension options
On Thu, 04 Nov 2010 21:26:43 +0200, Niko Rönkkö ron...@iki.fi wrote: Renamed all extensions to --with-ext-* Thanks, that makes sense, I just didn't get to it. I'd just still argue for --enable rather than --with. If we do want to present them together in ./configure --help, then they all must be a same type of. = Changed all extensions to be AC_ARG_WITH --enable is being used to choose optional features which certainly applies here (http://www.delorie.com/gnu/docs/autoconf/autoconf_131.html) --with is used if you require external software and decides which external software is being used. (http://www.delorie.com/gnu/docs/autoconf/autoconf_130.html) So --enable is IMHO what we really want here. What I would prefer even more is a grouping feature, ie present all extensions in a group, present all Windows-specific options in a group etc. But I did not find if that is possible. Does any auto-wizard know? Also: We don't want to break builders scripts (as Michael Meeks said) so deprecated old options not removed but commented instead. While I agree for the 3.3 branch. I don't think that doubling the output of ./configure --help is going to be helpful. It complains when being invoked with an unknown option anyway. But we can deprecate it for a while and remove it a bit later. shrug. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Convert --enable-java to --with-java
On Thu, 04 Nov 2010 18:24:04 +, Wols Lists wrote: + --with-java Build LibO with a JDK Java support.], So, what should be the default? Including Java? Then I would argue for making this a --without option and having Java enabled by default... ? pgppmfCzt4N2n.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Changing mailing list behavior
On Fri, 05 Nov 2010 11:28:24 +0100, Regina Henschel wrote: It is not about using my seamonkey, but why this list is organized different than others. It's a religious thing. Some belief that the list should set a reply-to to itself while others don't want the list to monkey around with the headers and leave it to the mail client to do the right thing. About half of the lists I'm on are this and half the other way. And on each of those lists a discussion about the current behavior will lead to a non-productive religous war, so I learned to leave these things alone. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] distro_config: adapt to new confgure options for extensions
Some extensions options for configure were renamed to --enable-ext-* Adapt all distro configs to reflect that. Sorry for the churn. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- distro-configs/GoOoLinux.conf.in | 10 +- distro-configs/GoOoMacOSX.conf.in| 10 +- distro-configs/LibreOfficeLinux.conf.in |6 +++--- distro-configs/LibreOfficeLinuxDevel.conf.in |6 +++--- distro-configs/LibreOfficeMacOSX.conf.in |6 +++--- distro-configs/LibreOfficeOpenBSD.conf.in|6 +++--- distro-configs/OOo4Kids.conf.in |2 +- distro-configs/OxygenOfficeLinux.conf.in |6 +++--- distro-configs/OxygenOfficeWindows.conf.in |6 +++--- distro-configs/SUSE-10.3.conf.in |4 ++-- distro-configs/SUSE-11.0.conf.in |6 +++--- distro-configs/SUSE-11.1.conf.in |6 +++--- distro-configs/SUSE-11.2.conf.in |6 +++--- distro-configs/SUSE.conf.in |6 +++--- 14 files changed, 43 insertions(+), 43 deletions(-) diff --git a/distro-configs/GoOoLinux.conf.in b/distro-configs/GoOoLinux.conf.in index 473f1ab..fb78eaf 100644 --- a/distro-configs/GoOoLinux.conf.in +++ b/distro-configs/GoOoLinux.conf.in @@ -38,12 +38,12 @@ --without-system-mesa-headers --without-unix-wrapper --with-fonts ---enable-minimizer ---enable-presenter-console ---enable-pdfimport +--enable-ext-presenter-minimizer +--enable-presenter-console +--enable-ext-pdfimport --without-system-poppler ---enable-wiki-publisher ---enable-report-builder +--enable-ext-wiki-publisher +--enable-report-builder --with-extension-integration --with-linker-hash-style=both --with-ant-home=$BUILDDIR/$APACHE_ANT diff --git a/distro-configs/GoOoMacOSX.conf.in b/distro-configs/GoOoMacOSX.conf.in index a38c562..ba03e81 100644 --- a/distro-configs/GoOoMacOSX.conf.in +++ b/distro-configs/GoOoMacOSX.conf.in @@ -2,9 +2,9 @@ --with-about-bitmaps=\$TOOLSDIR/src/openabout_go-oo.bmp\ --with-vendor=\Go-oo Project\ --enable-hids ---enable-minimizer ---enable-presenter-console ---enable-pdfimport ---enable-wiki-publisher ---enable-report-builder +--enable-ext-presenter-minimizer +--enable-presenter-console +--enable-ext-pdfimport +--enable-ext-wiki-publisher +--enable-report-builder --with-extension-integration diff --git a/distro-configs/LibreOfficeLinux.conf.in b/distro-configs/LibreOfficeLinux.conf.in index 7f2cb4b..cbc4339 100644 --- a/distro-configs/LibreOfficeLinux.conf.in +++ b/distro-configs/LibreOfficeLinux.conf.in @@ -33,11 +33,11 @@ --without-system-mesa-headers --without-unix-wrapper --with-fonts ---enable-minimizer +--enable-ext-presenter-minimizer --enable-presenter-console ---enable-pdfimport +--enable-ext-pdfimport --without-system-poppler ---enable-wiki-publisher +--enable-ext-wiki-publisher --enable-report-builder --with-extension-integration --with-linker-hash-style=both diff --git a/distro-configs/LibreOfficeLinuxDevel.conf.in b/distro-configs/LibreOfficeLinuxDevel.conf.in index 58b9e8d..704e43d 100644 --- a/distro-configs/LibreOfficeLinuxDevel.conf.in +++ b/distro-configs/LibreOfficeLinuxDevel.conf.in @@ -30,11 +30,11 @@ --without-system-mesa-headers --without-unix-wrapper --with-fonts ---enable-minimizer +--enable-ext-presenter-minimizer --enable-presenter-console ---enable-pdfimport +--enable-ext-pdfimport --without-system-poppler ---enable-wiki-publisher +--enable-ext-wiki-publisher --enable-report-builder --with-extension-integration --with-ant-home=$BUILDDIR/$APACHE_ANT diff --git a/distro-configs/LibreOfficeMacOSX.conf.in b/distro-configs/LibreOfficeMacOSX.conf.in index 40259cc..1ebbf3a 100644 --- a/distro-configs/LibreOfficeMacOSX.conf.in +++ b/distro-configs/LibreOfficeMacOSX.conf.in @@ -1,9 +1,9 @@ --with-vendor=\The Document Foundation\ --enable-hids ---enable-minimizer +--enable-ext-presenter-minimizer --enable-presenter-console ---enable-pdfimport ---enable-wiki-publisher +--enable-ext-pdfimport +--enable-ext-wiki-publisher --enable-report-builder --with-extension-integration --enable-broffice diff --git a/distro-configs/LibreOfficeOpenBSD.conf.in b/distro-configs/LibreOfficeOpenBSD.conf.in index cf2556c..541954c 100644 --- a/distro-configs/LibreOfficeOpenBSD.conf.in +++ b/distro-configs/LibreOfficeOpenBSD.conf.in @@ -34,11 +34,11 @@ --with-system-mesa-headers --without-unix-wrapper --with-fonts ---enable-minimizer +--enable-ext-presenter-minimizer --enable-presenter-console ---enable-pdfimport +--enable-ext-pdfimport --with-system-poppler ---enable-wiki-publisher +--enable-ext-wiki-publisher --enable-report-builder --with-extension-integration --with-ant-home=/usr/local/ant/lib diff --git a/distro-configs/OOo4Kids.conf.in b/distro-configs/OOo4Kids.conf.in index d82a286..cc1adf7 100644 --- a/distro-configs/OOo4Kids.conf.in +++ b/distro-configs/OOo4Kids.conf.in @@ -1,4 +1,4 @@ ---enable-presenter-extra-ui +--enable-ext-presenter-ui
Re: [Libreoffice] build error in desktop no 'void desktop::Migration::migrateSettingsIfNecessary()'
On Thu, 04 Nov 2010 12:45:25 +, Wols Lists wrote: Any particular reason why? Is there a reason it can't use --delete? Without knowing anything specific I would say because --delete would remove all compiled files (and the unx* directory). So you would need some exclude files as well AFAIK. Wouldn't the time be better spend making the build work in rawbuild by default? Sebastian pgpEGs9zd8fkL.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] New credits page up (and linked from TDF)
Indeed - I'm not sure that the numbers are clean enough, pwrt. releng commits, and loosing history left right to make the charts -that- meaningful. I see they are back on the page now; can we loose them again ? :-) which charts? ;-) I cannot comment about data cleanliness. But unless we lost history they should reflect reality pretty nicely. Anyway, I'll save that one for my private blog :). What would be super-nice, would be if we could have a patch a little like the Help-License info one - cf. sfx2/source/appl/appserv.cxx - that would load a nice ODF document containing the output of your work - so that we cna ship that with the binaries, and make it available off-line too, as a snapshot of that version. That would be nice, but it won't be me that creates that patch :). Let me know if you need the data in xml,csv,json or whatever format though to include it. Is that something you'd be interested in I'm afraid I won't probably be able to do that but I'm willing to assist whoever wants to work on that. I'll put it up as an easy hack. Sebastian P.S. I made the blurb in the beginning to read more politically correct as not not pretend that these people all defected to LO. Wording improvements welcome. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Pretty up your name in the wiki stats
http://libreoffice.org/credits.html contains contributions to the TDF wiki. However it is only able to retrieve the wiki usernames. If you want to see you own full name there, you can enter it on this page: http://wiki.documentfoundation.org/Development/Developers All that is being used now is the Wiki user name and the Real name for doing any mapping. Please don't change the columns as my parser relies on the columns being in this order :). When you add yourself, your full name is going to be displayed on the next stats update. Thanks, Sebastian P.S. Sorry for cross-posting but I want to reach all wiki contributors and not only developers. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some hints about git please...
On Tue, 02 Nov 2010 23:02:56 +0100, Gert Faller gertfal...@aliceadsl.fr wrote: bin/g (and it is in the bin dir of your root checkout) basically iterates over all repositories in clone and performs an operation in each. So rather than updating each repo, you would do bin/g pull do update all repos. 2) I've read that when updating 'clone', 'bin/g' must be run. I don't find any 'g' in ./bin/. It really is there: http://cgit.freedesktop.org/libreoffice/build/tree/bin/g :) 3) I don't know how to update easily the source in 'build/libreoffice-3.2.99.2' Do build in the rawbuild/ directory as that operates directly on the git repositories. 4) I edit code in 'clone/module' and 'git diff' from there but, for building, I have to go to 'build/libreoffice-3.2.99.2/submodule' where I have done a local git, modify the patch (paths are too long in it eg : a/module/submodule -- a/submodule), 'apply' it, 'build', 'apply -R', and if it's ok, get back to clone/module and undo my work (with the editor or with 'apply -R') If you work in rawbuild and make from there, you can directly go into the directory, make changes, git add files that you have changed, git commit, and extract the patch with git format-patch HEAD^1. Hope that helps, I am sure there are even more efficient workflows. Sebastian pgppWwCFhvgKi.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] bootstrap/soenv: remove tcsh version of LinuxX86-64Env.Set
Previously we would have been writing out LinuxX86-64Env.Set and
LinuxX86-64Env.Set.sh which made my autocompletion useless. Simplify the
set_soenv.in to actually only produce 1 version which makes us require
bash as interactive build shell.
Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de
---
Here is the resend after the branching to be applied in master as
requested my Michael.
I have tested the correct function of this patch on x86_64 Linux and I don't
see any reason why it should break on other platforms. I don't know how fragile
Windows is in that regard though.
set_soenv.in | 117 +-
1 files changed, 42 insertions(+), 75 deletions(-)
diff --git a/set_soenv.in b/set_soenv.in
index 5a3313c..7f55e47 100644
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -38,12 +38,12 @@ use File::Basename;
# IIa. Declaring variables for the system commands, etc.
#
#
-my ( $outfile, $outfile_sh, $bootfile, $newline, $comment,
+my ( $outfile, $bootfile, $newline, $comment,
$compiler, $unsetenv, $setenv, $unset, $set, $ds, $ps,
$wps, $cur_dir, $par_dir, $I, $L, $D, $buildenv, $answer, $tmp, $MINGW,
$USE_MINGW, $platform,
$cygwinver, $empty, $no_ant, $no_stl, $no_gcc_include,
- $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $unsetvarssh,
$unsetvarsbat, $exportvars, $win_format_var, $perl_os,
@mingw_lib_include_paths, $mingw_lib_include_path);
+ $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $exportvars,
$win_format_var, $perl_os, @mingw_lib_include_paths, $mingw_lib_include_path);
#
#-
# IIb. Declaring environment values (constants).
@@ -205,10 +205,10 @@ if ( $platform =~ m/solaris/ )
if ($platform =~ m/^i[3456]86/)
{
if ( $CC =~ gcc) {
- $outfile= SolarisX86GccEnv.Set;
+ $outfile= SolarisX86GccEnv.Set.sh;
$OUTPATH= unxsogi;
} else {
- $outfile= SolarisX86Env.Set;
+ $outfile= SolarisX86Env.Set.sh;
$OUTPATH= unxsoli4;
}
$CPU= I;
@@ -221,10 +221,10 @@ if ( $platform =~ m/solaris/ )
else
{
if ( $CC =~ gcc) {
- $outfile= SolarisSparcGccEnv.Set;
+ $outfile= SolarisSparcGccEnv.Set.sh;
$OUTPATH= unxsogs;
} else {
- $outfile= SolarisSparcEnv.Set;
+ $outfile= SolarisSparcEnv.Set.sh;
$OUTPATH= unxsols4;
}
$CPU= S;
@@ -256,7 +256,7 @@ elsif ( $platform =~ m/netbsd/ )
#Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{ print Setting NetBSD x86 specific values... ;
- $outfile= NetBSDX86Env.Set;
+ $outfile= NetBSDX86Env.Set.sh;
$CPU= I;
$CPUNAME= INTEL;
$OUTPATH= unxbsdi;
@@ -266,7 +266,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/^sparc/)
{ print Setting NetBSD Sparc specific values... ;
- $outfile= NetBSDSparcEnv.Set;
+ $outfile= NetBSDSparcEnv.Set.sh;
$CPU= S;
$CPUNAME= SPARC;
$OUTPATH= unxbsds;
@@ -276,7 +276,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/powerpc/)
{ print Setting NetBSD PPC specific values... ;
- $outfile= NetBSDPPCEnv.Set;
+ $outfile= NetBSDPPCEnv.Set.sh;
$CPU= P;
$CPUNAME= POWERPC;
$OUTPATH= unxbsdppc;
@@ -319,7 +319,7 @@ elsif ( $platform =~ m/kfreebsd/ )
#Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{ print Setting GNU/kFreeBSD x86 specific values... ;
- $outfile= GNUkFreeBSDX86Env.Set;
+ $outfile= GNUkFreeBSDX86Env.Set.sh;
$CPU= I;
$CPUNAME= INTEL;
$OUTPATH= unxkfgi6;
@@ -331,7 +331,7 @@ elsif ( $platform =~ m/kfreebsd/ )
}
elsif ($platform =~ m/^x86_64/)
{ print Setting GNU/kFreeBSD x86-64 specific values... ;
- $outfile= GNUkFreeBSDX86-64Env.Set;
+ $outfile= GNUkFreeBSDX86-64Env.Set.sh;
$CPU= X;
$CPUNAME= X86_64;
$OUTPATH= unxkfgx6;
@@ -357,7 +357,7 @@ elsif ( $platform =~ m/freebsd/ )
if ($platform =~ m/^amd64/)
{ my ( $JAVA_OS );
print Setting FreeBSD AMD64 specific values... ;
- $outfile= FreeBSDAMDEnv.Set;
+ $outfile= FreeBSDAMDEnv.Set.sh;
$CPU= X;
$CPUNAME= X86_64;
$OUTPATH= unxfbsdx;
@@ -376,7 +376,7 @@ elsif ( $platform =~ m/freebsd/ )
}
elsif ($platform =~ m/^i386/)
{ print Setting FreeBSD x86 specific values... ;
- $outfile= FreeBSDX86Env.Set;
+ $outfile
[Libreoffice] [PATCH] bootstrap/set_soenv: remove unused variables
The variables $unsetenv, $setenv, $unset, $set $D, $answer were unused in this script and have been removed. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- set_soenv.in | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/set_soenv.in b/set_soenv.in index 7f55e47..b4b1616 100644 --- a/set_soenv.in +++ b/set_soenv.in @@ -1,8 +1,6 @@ #...@perl@ -w # # Program: set_soenv.in -# Version: $Revision: 1.201 $ -# Date:$Date: 2008-09-05 14:14:29 $ # Author: Willem van Dorp, Ross Nicholson, Oisin Boydell - Sun Microsystems, Ireland. # #--- @@ -39,8 +37,8 @@ use File::Basename; # # my ( $outfile, $bootfile, $newline, $comment, - $compiler, $unsetenv, $setenv, $unset, $set, $ds, $ps, - $wps, $cur_dir, $par_dir, $I, $L, $D, $buildenv, $answer, $tmp, $MINGW, + $compiler, $ds, $ps, + $wps, $cur_dir, $par_dir, $I, $L, $tmp, $MINGW, $USE_MINGW, $platform, $cygwinver, $empty, $no_ant, $no_stl, $no_gcc_include, $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $exportvars, $win_format_var, $perl_os, @mingw_lib_include_paths, $mingw_lib_include_path); @@ -110,10 +108,6 @@ chomp( $platform ); $UPD= '@UPD@'; # the project's UPD $newline= \n; # Perl newline character -$unsetenv = unsetenv; # c-shell command -$setenv = setenv; # c-shell command -$unset = unset; # msdos batch file command -$set= set;# msdos batch file command $ds = /; # directory separator $ps = :; # path separator $wps= :; # path separator, will be set to ';' for windows later. @@ -121,7 +115,6 @@ $cur_dir= .; # current directory $par_dir= ..; # parrent directory $I = -I;# include search path $L = -L;# library search path -$D = -D;# define search path $empty = ; # used as argument $no_stl = NO_STLPORT4;# possible argument $warnfile = warn; # logfile configure warnings. -- 1.7.1 pgpRfQ1rvyd90.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Another Qt/gtk configure patch
On Mon, 01 Nov 2010 22:18:46 +, Wols Lists wrote: I've now got configure autodetecting Qt4, and created an automagic patch. Things are still partly broken because to fix things properly I need to get rid of OOO_WIDGET_FLAGS, and that's probably a big job ... Adds a new --enable-automagic option. Shouldn't automagic be the default? ie building support for whatever is available on the machine sounds a sensible default to me. People/Packagebuilder can still manually enable/disable support fot things. /me shrugs. Not sure. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] build or rawbuild dir?
On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks michael.me...@novell.com wrote: ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend (and it does not seem to have happened anyway). Neither could I find any branching plans in the latest SC minutes. I know it's annoying to keep us informed, but a quick mail would have been nice. Now we have a they did not branch and we don't know what's going on and when situation. Which is not good. Thanks for your understanding :). Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] have git diff treat dictionaries/*.idx|dic|dat as binary
The git contributor script crunches through repos and invokes git to gather data. However, the dictionaries are 100k lines of code changes and git log --numstat literally works for hours on those commits. All other LO git repos take about 5-10 minutes to analyze. lib-extern-sys takes about 5 hours! Treating those dictionaries as binary files has no side-effect other than that git won't try to show a diff for those commits and dictionary updater are no longer statistical outliers with 300kLOC added in our contributor analysis. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- .gitattributes |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 000..4750805 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,3 @@ +dictionaries/**/*.dic binary +dictionaries/**/*.dat binary +dictionaries/**/*.idx binary -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
