[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

Xisco Faulí  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|jca...@blueyonder.co.uk |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #18 from Xisco Faulí  ---
Dear Jason,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

Jason Carty  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jca...@blueyonder.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

Jason Carty  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Assignee|ed-documentfoundation@s5h.n |libreoffice-b...@lists.free
   |et  |desktop.org
 Status|ASSIGNED|NEW

--- Comment #17 from Xisco Faulí  ---
Dear ed-documentfoundat...@s5h.net,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

ed-documentfoundat...@s5h.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |ed-documentfoundation@s5h.n
   |desktop.org |et

--- Comment #13 from ed-documentfoundat...@s5h.net ---
Created attachment 158465
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158465=edit
Switch mkdir to make_path

Switch mkdir to make_path.

Since the build can run on several processors at once, mkdirs may run into
themselves. It makes sense to keep create_directory code but replace the
mkdirs. make_path only returns the directories which it created, two running at
once could be likely on a busy file system.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

jan iversen  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

jan iversen  changed:

   What|Removed |Added

   Assignee|bavincen...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #12 from jan iversen  ---
Unassigning due to lack of work, if you still work on the issue, please assign
it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

--- Comment #10 from Christian Lohmaier  ---
just read the file and you'll see that's it can be used to do a special kind of
installation using the created msi installer packages. It is not used during
building of LO.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

--- Comment #9 from Josh Baldwin  ---
I am having email issues, so I'll post this here:

I made the change to /setup_native/scripts/admin.pl.  I did

egrep -ir "admin.pl" .

to see where in libreoffice admin.pl used.  However, it does not appear to be
called anywhere.  Any ideas on how this file is used? Is it manually called and
not from any other part of libreoffice?  I wanted to know so I can properly
test the code before submitting.  Any insight will be greatly appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

--- Comment #8 from jan iversen  ---
(In reply to Jan Holesovsky from comment #7)
> Josh: Great to see you hacking on this!  Let me CC JanI who will be able to
> help you with pushing your patches etc. :-)

Yes I am here to help non-committers getting their first patch submitted.

if you have problems/questions please feel free to email me directly 
j...@documentfoundation.org

Of also using IRC and our mailing list is a good idea.

We have created a step by step guide, to help you over the first steps:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

have fun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

Jan Holesovsky  changed:

   What|Removed |Added

 CC||j...@documentfoundation.org

--- Comment #7 from Jan Holesovsky  ---
Josh: Great to see you hacking on this!  Let me CC JanI who will be able to
help you with pushing your patches etc. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

--- Comment #6 from Josh Baldwin  ---
Hello, I would like to take up this task as my first LO commit.  I will start
with just one file though, to make sure I understand the process.  Then I will
change all create_directory() to make_path().  After that, I can research more
functions we can move into the core and leave those findings here for more new
developers.

Question though for Taylor:
>I argue that there are many calls to 
>>installer::systemactions::create_directory($var), so does changing all calls 
>to >"make_path($var, {mode=0775})" make sense?  Maybe having mode in a central 
>>function is a good thing?  Not sure.

I do follow your questions.  Can you explain your thought process in more
detail?  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66754

--- Comment #4 from Taylor taylorlee...@gmail.com ---
bavincen,

I think your solution is a step in the right direction.  I find 'sub
create_directory' in the following 4 files:

 setup_native/scripts/admin.pl
 solenv/bin/modules/installer/systemactions.pm
 solenv/bin/modules/par2script/systemactions.pm
 solenv/bin/modules/pre2par/systemactions.pm

The last 2 files don't seem to need make_path as there is no implementation of
recursive directory creation; mkdir seems sufficient.

In the first 2 files, I think it makes sense to replace the contents of
create_directory() with make_path and some error detection as was implemented
in create_directory_with_privileges().

I argue that there are many calls to
installer::systemactions::create_directory($var), so does changing all calls to
make_path($var, {mode=0775}) make sense?  Maybe having mode in a central
function is a good thing?  Not sure.

 egrep -ciIR installer::systemactions::create_directory | egrep -v ':0$'
solenv/bin/modules/installer.pm:6
solenv/bin/modules/installer/parameter.pm:2
solenv/bin/modules/installer/worker.pm:6
solenv/bin/modules/installer/windows/mergemodule.pm:3
solenv/bin/modules/installer/windows/idtglobal.pm:2
solenv/bin/modules/installer/windows/strip.pm:1
solenv/bin/modules/installer/windows/update.pm:1
solenv/bin/modules/installer/windows/msp.pm:7
solenv/bin/modules/installer/windows/admin.pm:2
solenv/bin/modules/installer/strip.pm:1
solenv/bin/modules/installer/profiles.pm:1
solenv/bin/modules/installer/simplepackage.pm:9
solenv/bin/modules/installer/archivefiles.pm:2
solenv/bin/modules/installer/scpzipfiles.pm:2
solenv/bin/modules/installer/download.pm:1
solenv/bin/modules/installer/copyproject.pm:1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

--- Comment #3 from bavincen bavincen...@gmail.com ---
(In reply to comment #0)
 Some Perl knowledge is needed for this Easy Hack.
 
 solenv/bin/modules/installer/systemactions.pm implements for example
 create_directory() that can be exchanged with standard Perl's make_path()
 [http://perldoc.perl.org/File/Path.html].  Similarly other functions there,
 for which standard (or widely used) implementations exist.
 
 What needs to be done (in the create_directory case; but similarly for more
 functions there):
 
 Find all Perl scripts that use create_directory:
 
 git grep '\create_directory\'
 
 Edit all those that are Perl (end with .pl or .pm) so that you add use
 File::Path qw(make_path); at the top and then instead of create_directory()
 calls, you use make_path().
 
 Then, remove the create_directory and create_directory_with_privileges
 declarations / definitions.
 
 As the last step, make sure that everything builds  packages still :-)

Hi jan
can we keep that  create_directory and implement make path in it.
and remove  create_directory_with_privileges ,

need a breif explanation :) thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

bavincen bavincen...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bavincen...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

bavincen bavincen...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |bavincen...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Whiteboard|EasyHack,   |EasyHack DifficultyBeginner
   |DifficultyBeginner, |SkillPerl TopicCleanup
   |SkillPerl, TopicCleanup |
 CC||qu...@runcibility.com

--- Comment #2 from Qubit qu...@runcibility.com ---
Removing comma from whiteboard (please use a space to delimit values in this
field)
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Whiteboard|EasyHack,   |EasyHack DifficultyBeginner
   |DifficultyBeginner, |SkillPerl TopicCleanup
   |SkillPerl, TopicCleanup |
 CC||qu...@runcibility.com

--- Comment #2 from Qubit qu...@runcibility.com ---
Removing comma from whiteboard (please use a space to delimit values in this
field)
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #1 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #1 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66754] Remove own implementations of various Perl functions in installer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66754

Jan Holesovsky ke...@suse.cz changed:

   What|Removed |Added

 Whiteboard||EasyHack,
   ||DifficultyBeginner,
   ||SkillPerl, TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs