Re: [Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
Hi Allen, I'm picking on you because you SHOUTED ;-) but there are plenty of other problems in this thread, and my mail is fairly generic. Firstly - progress is not well served by hindering, and slowing down people committing patches - yes, some things may break when things are changed, but then - the fixes should be able to get in quickly too. I was disappointed that the first developer response was not to get on IRC, talk it through, and merge it, as I've now done. It is not the end of the world to have a temporary regression in a tinderbox snapshot - we have ~six months to spot and fix it before many end-users get it. It -is- the end of the world to de-motivate, and loose developers contributing code; we need to presume contributor sanity until proven otherwise, and merge unless we know it is certainly wrong. Otherwise we will never get anywhere IMNSHO etc. Shouting about the potential loss (though in fact it is not lost), of a minor feature, available only to expert users and sysadmins, does not seem proportionate to me. Also, by delaying developers with lots of noise, quite apart from de-motivating them, we waste opportunities for using their time for other improvements to the user interface. So - in summary, there is huge danger of de-motivation, dis-couragement and sterilization of the developer community from applying indiscriminate push-back. -Particularly- if it is inexpert push-back. In this case, it seems the distinction between a -context- menu and the main menu, that is present if you read the patch (though somewhat missing from the original mail, and the naming sadly) is quite important. Ergo - I would love to end this thread for now; if a problem or regression is found in a subsequent snapshot of master (for 3.6) - it would be great to know about it at that stage, and of course testing appreciated here. Since I just pushed the changes, hopefully (all else being equal) we'll have those builds in a day or two. Anyhow - I am sure none of us intend to cause problems, delay improvements, de-motivate developers or end up shouting :-) so - hopefully we can get back to some positive work on the product. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
I'm introducing a setting that decides if disabled menu items should be hidden. Currently the code is broken in the sense that items are hidden if disabled on all platforms and UpdateApplicationSettings which theortically does that is a) counter-intuitive and b) not set by platforms. I'm not sure I understand. I absolutely would hate it when the disabled menu-items were hidden instead of just greyed out. The current behavior is that if a menu item is disabled BY THE DISTRIBUTION PACKAGER OR SITE INSTALLATION SYSADMIN, then the menu item is hidden in LO, not grey'out out. Its not a question of what the user wants, its a question of what the distribution packager or site administrator is trying to accomplish. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
Hi Allen, *, On Wed, Apr 27, 2011 at 2:29 PM, Allen Pulsifer pulsi...@openoffice.org wrote: I'm introducing a setting that decides if disabled menu items should be hidden. Currently the code is broken in the sense that items are hidden if disabled on all platforms and UpdateApplicationSettings which theortically does that is a) counter-intuitive and b) not set by platforms. I'm not sure I understand. I absolutely would hate it when the disabled menu-items were hidden instead of just greyed out. The current behavior is that if a menu item is disabled BY THE DISTRIBUTION PACKAGER OR SITE INSTALLATION SYSADMIN, then the menu item is hidden in LO, not grey'out out. Its not a question of what the user wants, its a question of what the distribution packager or site administrator is trying to accomplish. OK, then the posting is even less clear to me, as I was thinking it was about not possible with the current selection style actions that are also greyed out by LO. No objections from my part to fully hide, removed / not-allowed-by-sysadmin ones, but when it comes to hiding entries that cannot be performed at the moment for whatever reason, then I say no, thanks. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
No objections from my part to fully hide, removed / not-allowed-by-sysadmin ones, but when it comes to hiding entries that cannot be performed at the moment for whatever reason, then I say no, thanks. That is the way it currently works under Windows. The former uses a permanent switch, while the latter depends on context or state (for example, I believe Save is grey'ed out when a document is open but not modified). I assume (hope) we are just talking about platforms where it is not currently working like this. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
Am 27.04.2011 15:40:35 schrieb Allen Pulsifer: No objections from my part to fully hide, removed / not-allowed-by-sysadmin ones, but when it comes to hiding entries that cannot be performed at the moment for whatever reason, then I say no, thanks. That is the way it currently works under Windows. The former uses a permanent switch, while the latter depends on context or state (for example, I believe Save is grey'ed out when a document is open but not The *current* behaviour is to hide disabled edit menu items in the context menu. Please see my clarification/ update, dated 11:13+00 UTC today. ciao, Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
