Re: [Libreoffice] High Contrast Cleanup
Hi there, On Sun, 2010-11-14 at 23:46 +0100, Sebastian Spaeth wrote: > Copying them over would mean, our download tarballs qould bloat by > another 10 MB or so only transiently, until we remove the duplicates. > ( I guess git would be able to handle that efficiently though). Sure, -but- git since it stores -all- history for all time, is a real issue. If you checkin and delete a 10Mb compressed tar-ball, and then delete it, then you add 10Mb to the git pull size forever - so, I would prefer to keep the repo size small, even if it means we have to (for one release) have a larger source archive. > the very end, complaining about a missing "crystal-icon.tar" or Odd; did you run 'download' in the top-level to fetch them ? ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
On Sat, 13 Nov 2010 14:35:48 +0100, Kálmán „KAMI” Szalai wrote: > Hi! > > What about to not to move but copy the HC set and crate the new HC set > now? This way we have more time to test (and/or) fix @ optimize the > newly created HC inconset. Copying them over would mean, our download tarballs qould bloat by another 10 MB or so ( I guess git would be able to handle that efficiently though). But why copy? THe high contrast images are not being loaded anymore anyway, so we can move them over without loss of functionality. I did a clean build today, and it finished, but failed in the very end, complaining about a missing "crystal-icon.tar" or whatever. I'll need to investigate this next week, and when we can build successfully, I am going to move the high contrast images over. Sebastian pgp9jXtWKTqdy.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
Title: Szalai Kálmán Hi! What about to not to move but copy the HC set and crate the new HC set now? This way we have more time to test (and/or) fix @ optimize the newly created HC inconset. KAMI 2010-11-11 12:14 keltezéssel, Sebastian Spaeth írta: Just so it doesn't get lost. Attached is the patch that moves all hi-contrast icons as per hicontrast-icons-to-theme.pl (or whatever it is called in solvenv/bin) to it's own theme directory. This patch should not yet be applied until the corresponding changes are being checked in for the makefiles at the same time. I am currently building a clean build and will try to come up with the makeline.mk patch to install those icons (retiring hicontrast-icons-to-theme.pl at the same time). It is weird to have a script to fish out some icons to put them in a separate directory, rather than separating them out in the first place. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Best regards, Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com My favorite projects: OxygenOffice Professional - office suite - for everybody | Magyarul - In Hungarian Blog | Support Follow me, if you can signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
On Wed, 10 Nov 2010 13:33:22 +, Michael Meeks wrote: > Hah ! it is you I guess - you just volunteered. HAH; I should have known :) > We need to fixup this "hicontrast-to-theme.pl" script - so that we can > base it from a (new) base-directory as well; say > ooo_custom_images/highcontrast Busy right now, I'll have a look at it next week if nobody beats me to it. > The key is (of course) to only move/rename those files for which we > already have patches :-) AHA, I should have known that there is a catch! :). But isn't there a fallback mechanism? I'd rather move all images in one go and either use the fallback mechanism or have the build break until we fix all the mentions of the hi-contrast icons. Probably something that I could try in a feature branch. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
Hi Sebastian, On Wed, 2010-11-10 at 10:13 +0100, Sebastian Spaeth wrote: > So who would be able to make sure that we don't bundle the high contrast > icons in our buld anymore (and either purge those files or move them to > a high contrast theme...) ? Hah ! it is you I guess - you just volunteered. Currently our hicontrast theme is built by packimages/pack/makefile.mk: # generate the HiContrast icon set $(MISC)$/hicontrast.flag .PHONY : $(PERL) $(SOLARENV)$/bin$/hicontrast-to-theme.pl $(SOLARSRC)$/default_images $(MISC)$/hicontrast && $(TOUCH) $@ We need to fixup this "hicontrast-to-theme.pl" script - so that we can base it from a (new) base-directory as well; say ooo_custom_images/highcontrast We need to move and rename the lch_ and sch_ etc. variants into lc_ and sc_ variants in that directory incrementally, as they are removed from the code; ie. git mv'ing the ones that Joseph has identified across [ I believe git will do this efficiently ]. That is mostly a matter of tweaking / testing the hicontrast-to-theme.pl script and doing some git movement - can you look at that Sebastian ? The key is (of course) to only move/rename those files for which we already have patches :-) Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
Title: Szalai Kálmán Hi, I start to work on it. Maybe I should work together with ACE_DENT KAMI 2010-11-10 10:13 keltezéssel, Sebastian Spaeth írta: So who would be able to make sure that we don't bundle the high contrast icons in our buld anymore (and either purge those files or move them to a high contrast theme...) ? Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Best regards, Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com My favorite projects: OxygenOffice Professional - office suite - for everybody | Magyarul - In Hungarian Blog | Support Follow me, if you can signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
So who would be able to make sure that we don't bundle the high contrast icons in our buld anymore (and either purge those files or move them to a high contrast theme...) ? Sebastian pgpji8OdQCXdH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High Contrast Cleanup
Lovely :o) 2010-11-10 07:30 keltezéssel, Joseph Powers írta: > Ok, I removed high-contrast support from two base classes: SvImpLBox & > SvTreeListBox. And then spent the next two days cleaning up the mess. The > code builds and seems to run fine on my Mac. > > > Joe P > > LGPL 3 if you want. KAMI signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] High-Contrast Cleanup
Pushed, Thanks
Norbert
On Sat, Nov 6, 2010 at 9:06 PM, Joseph Powers wrote:
> Man, you forget to delete two lines of code and someone complains...
> Sorry about that, (julien, I hope this makes you happy).
> Joe P.
> diff --git a/svx/source/tbxctrls/fontworkgallery.cxx
> b/svx/source/tbxctrls/fontworkgallery.cxx
> index 6b72567..ec222b0 100644
> --- a/svx/source/tbxctrls/fontworkgallery.cxx
> +++ b/svx/source/tbxctrls/fontworkgallery.cxx
> @@ -382,8 +382,6 @@ FontWorkAlignmentWindow::FontWorkAlignmentWindow(
> svt::ToolboxController& rContr
> , maImgAlgin5( SVX_RES( IMG_FONTWORK_ALIGN_STRETCH_16 ) )
> , msFontworkAlignment( RTL_CONSTASCII_USTRINGPARAM(
> ".uno:FontworkAlignment" ) )
> {
> - bool bHighContrast =
> GetSettings().GetStyleSettings().GetHighContrastMode();
> -
> SetHelpId( HID_POPUP_FONTWORK_ALIGN );
> SetSelectHdl( LINK( this, FontWorkAlignmentWindow, SelectHdl ) );
>
> @@ -439,8 +437,6 @@ void FontWorkAlignmentWindow::DataChanged( const
> DataChangedEvent& rDCEvt )
>
> if( ( rDCEvt.GetType() == DATACHANGED_SETTINGS ) && ( rDCEvt.GetFlags()
> & SETTINGS_STYLE ) )
> {
> - bool bHighContrast =
> GetSettings().GetStyleSettings().GetHighContrastMode();
> -
> appendEntry( 0, String( SVX_RES( STR_ALIGN_LEFT ) ), maImgAlgin1
> );
> appendEntry( 1, String( SVX_RES( STR_ALIGN_CENTER ) ), maImgAlgin2
> );
> appendEntry( 2, String( SVX_RES( STR_ALIGN_RIGHT ) ), maImgAlgin3
> );
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] High-Contrast Cleanup
Man, you forget to delete two lines of code and someone complains...
Sorry about that, (julien, I hope this makes you happy).
Joe P.
diff --git a/svx/source/tbxctrls/fontworkgallery.cxx
b/svx/source/tbxctrls/fontworkgallery.cxx
index 6b72567..ec222b0 100644
--- a/svx/source/tbxctrls/fontworkgallery.cxx
+++ b/svx/source/tbxctrls/fontworkgallery.cxx
@@ -382,8 +382,6 @@ FontWorkAlignmentWindow::FontWorkAlignmentWindow(
svt::ToolboxController& rContr
, maImgAlgin5( SVX_RES( IMG_FONTWORK_ALIGN_STRETCH_16 ) )
, msFontworkAlignment( RTL_CONSTASCII_USTRINGPARAM( ".uno:FontworkAlignment" )
)
{
-bool bHighContrast =
GetSettings().GetStyleSettings().GetHighContrastMode();
-
SetHelpId( HID_POPUP_FONTWORK_ALIGN );
SetSelectHdl( LINK( this, FontWorkAlignmentWindow, SelectHdl ) );
@@ -439,8 +437,6 @@ void FontWorkAlignmentWindow::DataChanged( const
DataChangedEvent& rDCEvt )
if( ( rDCEvt.GetType() == DATACHANGED_SETTINGS ) && ( rDCEvt.GetFlags() &
SETTINGS_STYLE ) )
{
-bool bHighContrast =
GetSettings().GetStyleSettings().GetHighContrastMode();
-
appendEntry( 0, String( SVX_RES( STR_ALIGN_LEFT) ), maImgAlgin1 );
appendEntry( 1, String( SVX_RES( STR_ALIGN_CENTER ) ), maImgAlgin2 );
appendEntry( 2, String( SVX_RES( STR_ALIGN_RIGHT ) ), maImgAlgin3 );
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
