Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
Hi Kohei, On Monday, 2012-07-23 22:15:57 -0400, Kohei Yoshida wrote: > Anyway, in case we change our mind and backport this to 3.6, commits > 4e8552993aed7caaa247bb1baf6168ddcfba159a through > 01ee7955fe6d0e25c325717fe7d5dbd56e28983c add an extra configuration > option to toggle this behavior. Great, thanks! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp7J7kmz3zev.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/23/2012 11:51 AM, Petr Mladek wrote: Eike Rathke píše v Po 23. 07. 2012 v 17:36 +0200: Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's desperately needed for 3.6. I'd appreciate if you could do it for 3.6 as well, but it would need also translation, do we add that in stable branches? If the bug was already in LO-3.3, I would not break the UI/string freeze because of it. I think that such an old bug could wait few more months for LO-3.7. I tend to agree with this. Anyway, in case we change our mind and backport this to 3.6, commits 4e8552993aed7caaa247bb1baf6168ddcfba159a through 01ee7955fe6d0e25c325717fe7d5dbd56e28983c add an extra configuration option to toggle this behavior. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
>From a translators point of view, it would be no problem. The translations are continually updated anyway. I guess it could be a little bit annoying for people that do not use pootle, but who cares about one untranslated string if it fixes a problem that breaks compatibility, not to mention there are still not that many languages that are fully translated. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
Eike Rathke píše v Po 23. 07. 2012 v 17:36 +0200: > Hi Kohei, > > On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: > > > I'll add this configuration option during 3.7 cycle if this can wait > > until 3.7. If you guys need it earlier than that I could work on it > > and push it as a late feature if it's desperately needed for 3.6. > > I'd appreciate if you could do it for 3.6 as well, but it would need > also translation, do we add that in stable branches? If the bug was already in LO-3.3, I would not break the UI/string freeze because of it. I think that such an old bug could wait few more months for LO-3.7. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/23/2012 11:36 AM, Eike Rathke wrote: Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's desperately needed for 3.6. I'd appreciate if you could do it for 3.6 as well, but it would need also translation, do we add that in stable branches? Normally we don't, but we *may* have to somehow make an exception for this. Let me CC Andras and Petr on this. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: > I'll add this configuration option during 3.7 cycle if this can wait > until 3.7. If you guys need it earlier than that I could work on it > and push it as a late feature if it's desperately needed for 3.6. I'd appreciate if you could do it for 3.6 as well, but it would need also translation, do we add that in stable branches? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpCMSzHOMTtQ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/20/2012 10:04 AM, Caolán McNamara wrote: On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : I'm also not fully convinced of this patch. This behavior has been in Libreoffice since the start so IMHO it is more important to keep the behavior for all the LibO users than to change it again to please potential users switching from OOo. I think the only sane solution that will please both sides is to have it as configuration option but I'm not thrilled to see the default behavior changed again. FWIW, what would the ideal situation be if had a time machine ? e.g. Would a compatibility option of TreatEmptyCellsAsZero that defaulted to true if unset, and LibreOffice >= X.Y exported it as false have made sense ? IMO the most sane solution is to make it configurable, and let the user choose which way she prefers. We could try to be smart and detect the version of the document and change the behavior, but that will open up another can of worms. I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's desperately needed for 3.6. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: > Hey Eike, Kohei, > 2012/7/19 Kohei Yoshida : > I'm also not fully convinced of this patch. This behavior has been in > Libreoffice since the start so IMHO it is more important to keep the > behavior for all the LibO users than to change it again to please > potential users switching from OOo. > > I think the only sane solution that will please both sides is to have > it as configuration option but I'm not thrilled to see the default > behavior changed again. FWIW, what would the ideal situation be if had a time machine ? e.g. Would a compatibility option of TreatEmptyCellsAsZero that defaulted to true if unset, and LibreOffice >= X.Y exported it as false have made sense ? I mean, if it mattered enough, I suppose one could be added that is always explicitly exported true or false and hook off the for known legacy implementations that default true/false when its not set. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/19/2012 11:58 AM, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings containing only blanks as an argument converted to numeric 0. We already discussed this on IRC, but I disagree with this "fix" since it basically breaks another valid use case that relies on the current behavior. ... I think the only sane solution that will please both sides is to have it as configuration option but I'm not thrilled to see the default behavior changed again. Sad I missed the IIRC discussion, would have loved to have seen it :-) I am surprised that the ODF specification does not dictate the behavior. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : > On 07/19/2012 10:29 AM, Eike Rathke wrote: >> >> Hi, >> >> Please review and cherry-pick to 3-6 and 3-6-0 >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a >> that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 >> to accept empty string and strings containing only blanks as an argument >> converted to numeric 0. > > > We already discussed this on IRC, but I disagree with this "fix" since it > basically breaks another valid use case that relies on the current behavior. > So, I'm afraid I cannot sign off on this. > > Having said that, if someone else wants to sign off on this, then I'll stay > silent. > I'm also not fully convinced of this patch. This behavior has been in Libreoffice since the start so IMHO it is more important to keep the behavior for all the LibO users than to change it again to please potential users switching from OOo. I think the only sane solution that will please both sides is to have it as configuration option but I'm not thrilled to see the default behavior changed again. This is just my opinion and if anyone still think it is a good idea the patch looks correct from a technical perspective. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/19/2012 10:29 AM, Eike Rathke wrote: Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings containing only blanks as an argument converted to numeric 0. We already discussed this on IRC, but I disagree with this "fix" since it basically breaks another valid use case that relies on the current behavior. So, I'm afraid I cannot sign off on this. Having said that, if someone else wants to sign off on this, then I'll stay silent. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
Hi, Please review and cherry-pick to 3-6 and 3-6-0 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a439cb5aba49d01df20f67a2c84b68542e4d3d5a that resolves https://bugs.freedesktop.org/show_bug.cgi?id=50345 to accept empty string and strings containing only blanks as an argument converted to numeric 0. Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpB7K2fHXojt.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
