Re: [Libreoffice] Icons in Specialized class ListBox
Hi Julien, On Wednesday, 2012-01-18 16:17:32 +0100, Julien Levesy wrote: I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. Don't know which SvtListBox you are referring, there is no such class. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? There's the vcl ListBox (maybe that's the one you're already using?) that has an InsertEntry() method that takes an Image parameter. You can see it in action under Tools-Options-LanguageSettings-Languages Default languages for documents where it is used to display the ABC check marks for language support. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpVEaQ1gxEIW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons in Specialized class ListBox
Hi Actually, it was ListBox, not SvtListBox ! Thanks for your help, i managed to display icons ! Best regards Julien 2012/1/18 Eike Rathke er...@redhat.com Hi Julien, On Wednesday, 2012-01-18 16:17:32 +0100, Julien Levesy wrote: I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. Don't know which SvtListBox you are referring, there is no such class. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? There's the vcl ListBox (maybe that's the one you're already using?) that has an InsertEntry() method that takes an Image parameter. You can see it in action under Tools-Options-LanguageSettings-Languages Default languages for documents where it is used to display the ABC check marks for language support. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] [PUSHED] replace StarOffice icons to LibreOffice icons in Web Wizard fdo#33229
I need one review for 3-4 (and possibly for 3-3). Cherry-picked to libreoffice-3-4 and libreoffice-3-3 , thanks. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] replace StarOffice icons to LibreOffice icons in Web Wizard fdo#33229
Hi, http://cgit.freedesktop.org/libreoffice/extras/commit/?id=1e73670e832ca6f853459832b89b6213f3861a7e I need one review for 3-4 (and possibly for 3-3). Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] icons - we should use the native theme's icon size by default.
Hi guys, On Wed, 2011-01-05 at 18:59 +0100, Christian Lohmaier wrote: On GNOME it follows the theme, wich in turn follows the gconf-setting /desktop/gnome/interface/toolbar_icons_size Right - which should be propagated via x-settings and magic to avoid the need for a gconf dependency. Thanks Christian for digging that out. so whatever your theme defines in the gtk-icon-sizes property will be used. Right; we should hook out and use this in salnativewidgets-gtk.c if that is not so, lets add an easy hack for it, or perhaps someone can jump in with some code of this form to decisively end the discussion :-) NB. this will still be only for the Automatic / default setting - the user can override it easily. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
On Tue, 16 Nov 2010 19:54:17 +, Andrew C. E. Dent wrote: * brand/shell * Still in Default (not sure if this is used? Would suggest deletion...):backing_hc-pt_BR.png , backing_right_hc-pt_BR.png All artwork in hicontrast is just stock (not hc). I have created a HC replacement (just hacked together), that saves 53.5KB 0.8KB! Download here:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip Deleted the identical HC ones. Did not take your HC version, as someone should make a decision whether we need a HC logo on that one, I guess. * chart2 * Move 7x HC icons from Default to hicontrast:dataeditor_icon_h0*.png done * dbaccess * Delete two extra icons from hicontrast:sx03187.png , sx16670.png Done * framework *Replace Branding images in hicontrast as before:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip Why is that duplicated in the first place? I have simply deleted the highcontrast ones for now as they are identical with the normal ones. * res * In hicontrast, delete 6x stock filetype icons:od*_32.pngThese are something we probably want to eventually replace with proper HC icons when the final Done * sfx2 * Move closedochc.png done * svx/source/svdraw * From Default, move over (and check this doesn't break LibO!):cropmarkersACC.png , markersACC.png requires code changes, so not done yet. Filed a bug so I don't forget it. * toolkit/source/awt *From Default, move over 12x HC spinner images:spinner03-32-hc_0*.png done * vcl * Move closedochc.png done * General *Remove all Placeholder icons (Red cross on Yellow square) from hicontrast theme. They have not been stripped from Default yet, but we might as well cleanup here anyway. They may be 122, 161 or 170 bytes. Can be found in (but may not be limited to...):res/ and res/commandimagelist/ not done yet, if someone comes up with a file list of those that would be appreciated. I will rebuild LO first from scratch to make sure that moving the icons over doesn't break anything and will commit then. Thanks! Sebatian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
On Tue, 02 Nov 2010 10:21:49 +, Michael Meeks michael.me...@novell.com wrote: Currently our hicontrast theme is built by packimages/pack/makefile.mk: # generate the HiContrast icon set $(MISC)$/hicontrast.flag .PHONY : $(PERL) $(SOLARENV)$/bin$/hicontrast-to-theme.pl $(SOLARSRC)$/default_images $(MISC)$/hicontrast $(TOUCH) $@ Which runs a script that build that theme. Not anymore! I just pushed a change to master that - moved artwork/default_images/all the hicontrast images to artwork/ooo_custom_images/hicontrast/... - deleted the hicontrast-to-theme.pl script and removed the above unneccessary blurb from the makefile. So ! :-) I suggest that we start by using the above perl script to create an entirely new theme (in artwork/) hicontrast - that is essentially the results of hicontrast-to-theme.pl - with all of the 'h' variants removed from it. Done :). I do hope there is no fallout and things work as they are intended to work. Sebastian pgpQkZgTkpebf.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
Fantastic- Will grab the archive. I will drop you an email with links to the updated other themes. I think the Classic theme should no longer be shipped, in the same way we dropped Industrial. I also can not see the point of including Oxygen, with less than 1% of original artwork... From: sebast...@sspaeth.de To: ace_d...@hotmail.com; libreoffice@lists.freedesktop.org Subject: Re: [Libreoffice] Icons Date: Tue, 16 Nov 2010 15:59:42 +0100 Hi Ace_dent, you've been asking for the new extracted images for the default set and the hicontrast set. You can see the icons 'live' here http://cgit.freedesktop.org/libreoffice/artwork/tree/ The are in the default_images and in the custom_ooo_images/hicontrast folders. You can download the whole shebang from this link, if you want it offline: http://cgit.freedesktop.org/libreoffice/artwork/snapshot/artwork-2acfe7a79a17aaa9dbcb03cd3b573d66c0fd6144.zip Hope that helps already, Sebastian P.S. One thing that would also be an easy task now, is to prune the oxygen,classic,industrial.tar balls in that repository from hicontrast icons to save disk space. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
Hi Sebastian, I had a quick look through the updated Default and Hicontrast sets.The following is a list of 'features' spotted... * brand/shell * Still in Default (not sure if this is used? Would suggest deletion...):backing_hc-pt_BR.png , backing_right_hc-pt_BR.png All artwork in hicontrast is just stock (not hc). I have created a HC replacement (just hacked together), that saves 53.5KB 0.8KB! Download here:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip * chart2 * Move 7x HC icons from Default to hicontrast:dataeditor_icon_h0*.png * dbaccess * Delete two extra icons from hicontrast:sx03187.png , sx16670.png * framework *Replace Branding images in hicontrast as before:http://people.bath.ac.uk/ea2aced/OOo/Backing_HC.zip * res * In hicontrast, delete 6x stock filetype icons:od*_32.pngThese are something we probably want to eventually replace with proper HC icons when the final artwork is designed.Note: In Default/res/ - 445 icons, in hicontrast/res/ - 307 icons. This disparity may be due to redundant icons that need stripping out eventually. * sfx2 * Move closedochc.png * svx/source/svdraw * From Default, move over (and check this doesn't break LibO!):cropmarkersACC.png , markersACC.png * toolkit/source/awt *From Default, move over 12x HC spinner images:spinner03-32-hc_0*.png * vcl * Move closedochc.png * General *Remove all Placeholder icons (Red cross on Yellow square) from hicontrast theme. They have not been stripped from Default yet, but we might as well cleanup here anyway. They may be 122, 161 or 170 bytes. Can be found in (but may not be limited to...):res/ and res/commandimagelist/ Hope that helps,Andrew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
Hi Joseph That's made my day!To make this more manageable, I think we should first agree on how to divide and conquer different aspects.A good starting point might be to fix up the fallback code: http://wiki.documentfoundation.org/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_iconsDo you use the #libreoffice IRC channel? Perhaps I can catch you there depending on timezones? I will compose a more detailed email later, and look forward to working (/hacking) with you. Cheers,Andrew From: jpower...@cox.net Subject: Icons Date: Mon, 1 Nov 2010 21:15:51 -0700 CC: libreoffice@lists.freedesktop.org To: ace_d...@hotmail.com Andrew, I'm a little crazy, but I want to work on the icon issues. I'm a programmer, so I've been looking at things from the other side... Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we have both themed and un-themed icons; thus, I can't just kill the high-contrast checks. From your earlier e-mails, you've said that each theme has both standard icons and high-contrast icons; this has to change. However, I'm stuck trying to figure out how the code knows which icon file it's requesting. The un-themed icons in chart2 are easy to tack since I found the mapping files; however, I'm having issues with the themed icons. I believe all the themes should be located the /artwork directory and we'll need to create a system for building/packaging them for inclusion into the project. We'll also need to determine a directory to house the installed themes. The current system of themes being hard coded into the build system needs to change; the users should be able to just drop a theme package and have the them auto-reconized on the change theme dialog. I'm open to suggestions from any of the other developers. I'm also in need of guidance in under standing the current icon packaging system. As far as I can determine the biggest savings would be to do the changes in this order: 1. Remove the High-Contrast check from the themed icons. a) This should cut the themes in about half. b) Reduce a lot of code over head. 2. Move the un-themed icons in to the default themes. a) This only removes some redundant code paths for retrieving icons. b) Removes the last of the High-Contrast checks. c) Will need to verify that the missing icon fall-back code actually works. 3. Make themes discoverable. a) No real savings, it's mostly a coolness factor. Plus it gives the graphics designers something to do so they leave the programmers alone. Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icons
Hi Joseph, On Mon, 2010-11-01 at 21:15 -0700, Joseph Powers wrote: I'm a little crazy, but I want to work on the icon issues. Cool - there is a rich seam of wasted run-time memory, startup-time, and worse bloat in the Win32 packages here, all of which can be easily fixed I think :-) I'm a programmer, so I've been looking at things from the other side... Great news; perhaps good to put your name in the Easy Hacks as working on this task. Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we have both themed and un-themed icons; thus, I can't just kill the high-contrast checks. Right - so - there is an easy hack for this: http://wiki.documentfoundation.org/Development/Easy_Hacks#un-screw-up_accessible_icon_code-paths_.26_shrink_theme_files We need to totally remove all references to 'BmpColorMode' that are used for selecting accessible vs. non-accessible icons - it is a total joke of an attempt at accessibility :-) Similarly - we should chase all -icon- code down that has special cases for high-contrast and remove it. Whomever implemented a11y had (apparently) no idea that there is are also -low-contrast- impairments as well as high-contrast ones :-) and the mechanism is fundamentally inextensible, as well as made obsolete by high-level theming. From your earlier e-mails, you've said that each theme has both standard icons and high-contrast icons; this has to change. However, I'm stuck trying to figure out how the code knows which icon file it's requesting. The un-themed icons in chart2 are easy to tack since I found the mapping files; however, I'm having issues with the themed icons. Well; there are lots of hacks through the code: svtools/source/contnr/templwin.cxx:bLarge ? bHiContrast ? IMG_SVT_DOCTEMPL_HC_BACK_LARGE : IMG_SVT_DOCTEMPLATE_BACK_LARGE The switch as to whether to do this is often fetched from: sal_Bool bHiContrast = GetSettings().GetStyleSettings().GetHighContrastMode(); Almost every instance of this call is a bug ;-) if it is for an icon - then it should be done using theming; if it is for a color - it should be done by building different style themes in vcl and using generic methods to fetch colors. I believe all the themes should be located the /artwork directory and we'll need to create a system for building/packaging them for inclusion into the project. We'll also need to determine a directory to house the installed themes. The current system of themes being hard coded into the build system needs to change; the users should be able to just drop a theme package and have the them auto-reconized on the change theme dialog. Yep - sounds great :-) Currently our hicontrast theme is built by packimages/pack/makefile.mk: # generate the HiContrast icon set $(MISC)$/hicontrast.flag .PHONY : $(PERL) $(SOLARENV)$/bin$/hicontrast-to-theme.pl $(SOLARSRC)$/default_images $(MISC)$/hicontrast $(TOUCH) $@ Which runs a script that build that theme. Of course - that theme has the worst of all worlds: exact duplicates of each icon twice - once as plain, once as hi contrast. I'm open to suggestions from any of the other developers. So ! :-) I suggest that we start by using the above perl script to create an entirely new theme (in artwork/) hicontrast - that is essentially the results of hicontrast-to-theme.pl - with all of the 'h' variants removed from it. I suggest we then remove the 'h' variants from default-images incrementally - as we remove their usage. So - we audit the GetHighContrastMode calls to find the one that will switch all the toolbar icons from lc_foo.png to lch_foo.png [ this will be in the 'framework' module and dependents ]. Then we remove all of that cruft; in the code, and simultaeously remove res/commandimagelist/lch_* and sch_* from default_images/ Then we iterate, incrementally removing more cruft left right, until we substantially shrink the size of images.zip :-) As far as I can determine the biggest savings would be to do the changes in this order: 1. Remove the High-Contrast check from the themed icons. a) This should cut the themes in about half. b) Reduce a lot of code over head. Right :-) 2. Move the un-themed icons in to the default themes. a) This only removes some redundant code paths for retrieving icons. b) Removes the last of the High-Contrast checks. c) Will need to verify that the missing icon fall-back code actually works. Sounds fine; I don't know how many un-themed images we have left; I suspect few enough. 3. Make themes discoverable. a) No real savings, it's mostly a coolness factor. Plus it gives the graphics designers something to do so they leave the programmers alone. Sounds cool
[Libreoffice] Icons
Andrew, I'm a little crazy, but I want to work on the icon issues. I'm a programmer, so I've been looking at things from the other side... Currently the system is a mess, the top level determines if if we're in high-contrast mode or not and then requests the correct image. On top of this, we have both themed and un-themed icons; thus, I can't just kill the high-contrast checks. From your earlier e-mails, you've said that each theme has both standard icons and high-contrast icons; this has to change. However, I'm stuck trying to figure out how the code knows which icon file it's requesting. The un-themed icons in chart2 are easy to tack since I found the mapping files; however, I'm having issues with the themed icons. I believe all the themes should be located the /artwork directory and we'll need to create a system for building/packaging them for inclusion into the project. We'll also need to determine a directory to house the installed themes. The current system of themes being hard coded into the build system needs to change; the users should be able to just drop a theme package and have the them auto-reconized on the change theme dialog. I'm open to suggestions from any of the other developers. I'm also in need of guidance in under standing the current icon packaging system. As far as I can determine the biggest savings would be to do the changes in this order: 1. Remove the High-Contrast check from the themed icons. a) This should cut the themes in about half. b) Reduce a lot of code over head. 2. Move the un-themed icons in to the default themes. a) This only removes some redundant code paths for retrieving icons. b) Removes the last of the High-Contrast checks. c) Will need to verify that the missing icon fall-back code actually works. 3. Make themes discoverable. a) No real savings, it's mostly a coolness factor. Plus it gives the graphics designers something to do so they leave the programmers alone. Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
