Re: Advice needed : making options dialog slightly wider
On Thu, 2014-01-16 at 19:47 +0100, Jean-Baptiste Faure wrote: > Doing some tests (before this commit) I discovered that the apparent > size of the font in the UI (and, as consequence, if all widgets have > enough room in the dialog) depends on at least two factors: > 1/ if the checkbox "Use the system font for the user interface" is > checked or not ; > 2/ at the OS level, what scale factor is used for the text. And I think there is another input. There is some black magic somewhere that multiplies the width of an average character by a language-dependent X, e.g. * 1.2 for French and 1.3 for Russian. I can't remember where that code/table is but hopefully we can get rid of it at some stage. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
Le 16/01/2014 16:49, Caolán McNamara a écrit : > On Fri, 2014-01-10 at 22:25 +0100, Jean-Baptiste Faure wrote: >> The second one is only partially visible. Perhaps the four checkboxes >> under Settings could be rearranged in two columns ? > > How about now after > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2&id=0d5397234b7589617970bb20d8fb3ad07a4587a1 > > ? Only one word : perfect ! :-) Thank you very much. Doing some tests (before this commit) I discovered that the apparent size of the font in the UI (and, as consequence, if all widgets have enough room in the dialog) depends on at least two factors: 1/ if the checkbox "Use the system font for the user interface" is checked or not ; 2/ at the OS level, what scale factor is used for the text. It seems that the real definition of my screen is ~121 dpi instead of 96 dpi and if I set a scale factor for text to 1.2 and font size to 10 (instead of 12) the display is correct. On the PC I use at work, the display is correct with a scale factor of 1; the screen definition is ~120 too. The graphic card is a Nvidia which is not the case for my personal PC (Intel). Both machines use Unity, the one at work on a Xubuntu base. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
On Fri, 2014-01-10 at 22:25 +0100, Jean-Baptiste Faure wrote: > The second one is only partially visible. Perhaps the four checkboxes > under Settings could be rearranged in two columns ? How about now after http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2&id=0d5397234b7589617970bb20d8fb3ad07a4587a1 ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
Le 10/01/2014 20:33, Caolán McNamara a écrit : > On Thu, 2014-01-09 at 19:42 +0100, Jean-Baptiste Faure wrote: >> So I checked each option dialog and it remains only one truncated label >> in French : in Language Settings > Languages the label "Complex text >> layout (CTL)" is truncated in French (I see only the C in "(CTL)"). > > Fixed that now I believe. Indeed, thank you. :-) > >> In LibreOffice Impress > General there is what seems to be a >> misplacement of the checkboxes under "Presentation". Both checkboxes >> could be on the same row allowing the checkbox and its label under >> Compatibility to be visible. > > I bet you are referring to a black entry in col 1 row of that grid > because the "enable remote control" thing is an optional feature which > might not be in your build. Resorted those now to put the optional stuff > in a row on its own. So I discovered that there is two, not one, checkboxes under Compatibility :-) The second one is only partially visible. Perhaps the four checkboxes under Settings could be rearranged in two columns ? Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
On Thu, 2014-01-09 at 19:42 +0100, Jean-Baptiste Faure wrote: > So I checked each option dialog and it remains only one truncated label > in French : in Language Settings > Languages the label "Complex text > layout (CTL)" is truncated in French (I see only the C in "(CTL)"). Fixed that now I believe. > In LibreOffice Impress > General there is what seems to be a > misplacement of the checkboxes under "Presentation". Both checkboxes > could be on the same row allowing the checkbox and its label under > Compatibility to be visible. I bet you are referring to a black entry in col 1 row of that grid because the "enable remote control" thing is an optional feature which might not be in your build. Resorted those now to put the optional stuff in a row on its own. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
Le 09/01/2014 16:54, Caolán McNamara a écrit : > On Wed, 2014-01-08 at 19:40 +0100, Jean-Baptiste Faure wrote: >> I suggest for cui/uiconfig/ui/optviewpage.ui to set the property >> homogeneous to false for OptViewPage so that both boxes box3 and box4 >> may have different widths. Doing that make the label "Use system font >> for user interface" not truncated when translated in French (with >> TP_WIDTH=280) > > Yeah. So I used that font and looked through the options pages in > French, German and Polish and made various tweaks like selecting what > widgets should shrink if there isn't enough space and so on and they > look good to me at least now in master and 4-2 (under Linux anyway) Thank you very much for this clean solution. :-) All my trials to allow the label "Use system font for user interface" to be wrapped if it has not enough room did not succeed. > > That doesn't mean its a bad idea to make that dialog wider. Feel free to > do that if you want, but hopefully there are no truncated labels or > similar now. Let me know if there are some I missed. So I checked each option dialog and it remains only one truncated label in French : in Language Settings > Languages the label "Complex text layout (CTL)" is truncated in French (I see only the C in "(CTL)"). In LibreOffice Impress > General there is what seems to be a misplacement of the checkboxes under "Presentation". Both checkboxes could be on the same row allowing the checkbox and its label under Compatibility to be visible. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
On Wed, 2014-01-08 at 19:40 +0100, Jean-Baptiste Faure wrote: > I suggest for cui/uiconfig/ui/optviewpage.ui to set the property > homogeneous to false for OptViewPage so that both boxes box3 and box4 > may have different widths. Doing that make the label "Use system font > for user interface" not truncated when translated in French (with > TP_WIDTH=280) Yeah. So I used that font and looked through the options pages in French, German and Polish and made various tweaks like selecting what widgets should shrink if there isn't enough space and so on and they look good to me at least now in master and 4-2 (under Linux anyway) That doesn't mean its a bad idea to make that dialog wider. Feel free to do that if you want, but hopefully there are no truncated labels or similar now. Let me know if there are some I missed. 4-2-0 review for the combined bundle of .ui tweaks if all the above is working out visually correct https://gerrit.libreoffice.org/#/c/7341/ C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Advice needed : making options dialog slightly wider
On Sat, 2014-01-04 at 13:05 +0100, Jean-Baptiste Faure wrote: > Hi Caolan, all, > > Is there a disadvantage to make the options dialog slightly wider ? > Doing that will allow French localized strings (and probably the German > ones) to find enough room. For example in Tools > Options > LibreOffice > Calc > View Well, probably not a problem to make it wider. But I'd prefer to first know first what font and size is your desktop's interface font ? so I can have a look at the problem because (needless to say) it works fine here with those translations and the .uis can be tweaked to specific what elements are to shrink when there isn't enough space. The options dialog is a special case because it has so many tabs (and its impossible to convert all the tabs in one go anyway) that it has a fixed size, while all the other ones have a flexible size. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
