Re: Problems compiling LO with Visual Studio 2008
Hi Pavel, 2013/11/1 Pavel Laštovička pavel.lastovi...@blue-point.cz Hi Michael, Dne 31.10.2013 22:58, Michael Stahl napsal(a): perhaps you will run into other issues too; since 2008 support was removed completely on master due to the high maintenace effort (uses different project files than newer versions etc.), there is probably little interest in getting the 4-1 branch to build; better to just use a newer MSVC. is it safe to use Express edition of Visual Studio or is Professional edition needed? I recommend you using the Professional Edition if you intend to distribute your build. For development, the Express Edition is fine. Please read carefully the section Getting ATL work with Visual Studio Express here to use ATL in your build: https://wiki.documentfoundation.org/Development/BuildingOnWindows Cheers, -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
Hi Thomas, 2013/10/31 Thomas Arnhold thomas-l...@arnhold.org Hi Jesús, ah sorry. I did it with the Windows 7 SDK and _WINNT_VERSION set to Windows XP. The problem is the missing SHARD_APPIDINFO definition. http://msdn.microsoft.com/en-**us/library/windows/desktop/** dd378453(v=vs.85).aspxhttp://msdn.microsoft.com/en-us/library/windows/desktop/dd378453(v=vs.85).aspx Should we just define the hex value of it? Yeah, just define SHARD_APPIDINFO. This should be easy and clean :) We'll have to refactor quite a lot of code when we drop support for Windows XP anyway, and then we can remove all those defines altogether. Unfortunately to get some of the cool stuff in Windows 8 and 8.1 you need to use a higher version. Windows 7 is the minimum you should use when compiling LibreOffice on Windows if you want to distribute your build to other users. We are quite conservative with this requisite but sometimes you just have to do it ;) -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
Hi Michael, Dne 31.10.2013 22:58, Michael Stahl napsal(a): perhaps you will run into other issues too; since 2008 support was removed completely on master due to the high maintenace effort (uses different project files than newer versions etc.), there is probably little interest in getting the 4-1 branch to build; better to just use a newer MSVC. is it safe to use Express edition of Visual Studio or is Professional edition needed? Regards, Pavel Laštovička blue.point Solutions spol. s r. o. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
Hi Pavel,
about the SHARDAPPINFO: I run into this, too. See the attached patch,
I'll commit this soon.
Thomas
On 31.10.2013 19:36, Pavel Laštovička wrote:
Hi all,
I am trying to compile LO 4.1.3 on my machine with Windows XP and Visual
Studio 2008 and I have run into some problems.
Is Visual Studio 2008 still supported? Or should I try to get a newer
version?
First problem was that build did not start at all with error in
external/Package_msvc_dlls.mk. I think it was failing on MSVC_DLL_PATH
being empty.
I tried to set it to a bogus path to make build start.
Later I got error about undefined SHARDAPPIDINFO structure. On the net I
found MSDN mentioning the structure is available from Windows 7 up.
Thanks
diff --git a/vcl/win/source/app/salinst.cxx b/vcl/win/source/app/salinst.cxx
index 22917e8..46cbbe4 100644
--- a/vcl/win/source/app/salinst.cxx
+++ b/vcl/win/source/app/salinst.cxx
@@ -1044,6 +1044,7 @@ void WinSalInstance::AddToRecentDocumentList(const OUString rFileUrl, const OUS
if (osl::FileBase::E_None == rc)
{
+#if WINVER = 0x0600
if ( aSalShlData.mbW7 )
{
typedef HRESULT ( WINAPI *SHCREATEITEMFROMPARSINGNAME )( PCWSTR, IBindCtx*, REFIID, void **ppv );
@@ -1105,6 +1106,9 @@ void WinSalInstance::AddToRecentDocumentList(const OUString rFileUrl, const OUS
}
// For whatever reason, we could not use the SHARD_APPIDINFO semantics
SHAddToRecentDocs(SHARD_PATHW, (PCWSTR) system_path.getStr());
+#else
+(void) rDocumentService;
+#endif
}
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
The patch is wrong. The reason why it's wrong is because your generated binary will not work as expected on Windows Vista and higher. The code should compile fine if you use the Windows 7 SDK to compile it. In case I am wrong and it doesn't, the proper way to fix it is to define SHARDAPPIDINFO. 2013/10/31 Thomas Arnhold thomas-l...@arnhold.org Hi Pavel, about the SHARDAPPINFO: I run into this, too. See the attached patch, I'll commit this soon. Thomas On 31.10.2013 19:36, Pavel Laštovička wrote: Hi all, I am trying to compile LO 4.1.3 on my machine with Windows XP and Visual Studio 2008 and I have run into some problems. Is Visual Studio 2008 still supported? Or should I try to get a newer version? First problem was that build did not start at all with error in external/Package_msvc_dlls.mk. I think it was failing on MSVC_DLL_PATH being empty. I tried to set it to a bogus path to make build start. Later I got error about undefined SHARDAPPIDINFO structure. On the net I found MSDN mentioning the structure is available from Windows 7 up. Thanks ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
Hi Jesús, ah sorry. I did it with the Windows 7 SDK and _WINNT_VERSION set to Windows XP. The problem is the missing SHARD_APPIDINFO definition. http://msdn.microsoft.com/en-us/library/windows/desktop/dd378453(v=vs.85).aspx Should we just define the hex value of it? SHARDAPPIDINFO was defined by Fridrich some time ago with 918ddde5be4fde7bf8679bdf19805c618deabbf5. Thomas On 31.10.2013 20:05, Jesús Corrius wrote: The patch is wrong. The reason why it's wrong is because your generated binary will not work as expected on Windows Vista and higher. The code should compile fine if you use the Windows 7 SDK to compile it. In case I am wrong and it doesn't, the proper way to fix it is to define SHARDAPPIDINFO. 2013/10/31 Thomas Arnhold thomas-l...@arnhold.org mailto:thomas-l...@arnhold.org Hi Pavel, about the SHARDAPPINFO: I run into this, too. See the attached patch, I'll commit this soon. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems compiling LO with Visual Studio 2008
On 31/10/13 19:36, Pavel Laštovička wrote: Hi all, I am trying to compile LO 4.1.3 on my machine with Windows XP and Visual Studio 2008 and I have run into some problems. Is Visual Studio 2008 still supported? Or should I try to get a newer version? i don't believe that libreoffice-4-1 branch is buildable with 2008; only 2010 and 2012 are known to work. First problem was that build did not start at all with error in external/Package_msvc_dlls.mk. I think it was failing on MSVC_DLL_PATH being empty. yes that was probably broken for MSVC 2008 by commit 5c0a2940428c5c4b8451ee4e9ce30f0b7739f3c8 and never fixed. perhaps you will run into other issues too; since 2008 support was removed completely on master due to the high maintenace effort (uses different project files than newer versions etc.), there is probably little interest in getting the 4-1 branch to build; better to just use a newer MSVC. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
