[Libreoffice-commits] core.git: Branch 'aoo/trunk' - officecfg/registry

[Jan Iversen]

 officecfg/registry/data/org/openoffice/Office/Common.xcu |  112 +++
 1 file changed, 56 insertions(+), 56 deletions(-)

New commits:
commit 4f6ba57d4733cab21821418f86219562b17141ae
Author: Jan Iversen j...@apache.org
Date:   Sat Jun 15 15:39:17 2013 +

Revert of x-no-translate. This revert is made since it is marked as a 
release

stopper.
HOWEVER, this is a misuse of the translation system, such language 
dependent specialities does not belong in files that are sent to translation 
(removing [en-US] would mean it was not sent to translatation.

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index db9480b..5edd8e6 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -33,67 +33,67 @@
 node oor:name=Localisation
   prop oor:name=AutoMnemonic
 value xml:lang=x-no-translatetrue/value
-value xml:lang=arfalse/value
-value xml:lang=catrue/value
-value xml:lang=cstrue/value
-value xml:lang=datrue/value
-value xml:lang=detrue/value
-value xml:lang=eltrue/value
 value xml:lang=en-UStrue/value
-value xml:lang=estrue/value
-value xml:lang=ettrue/value
-value xml:lang=fitrue/value
-value xml:lang=frtrue/value
-value xml:lang=hetrue/value
-value xml:lang=hi-INtrue/value
-value xml:lang=hutrue/value
-value xml:lang=ittrue/value
-value xml:lang=jatrue/value
-value xml:lang=kotrue/value
-value xml:lang=nltrue/value
-value xml:lang=pltrue/value
-value xml:lang=pttrue/value
-value xml:lang=pt-BRtrue/value
-value xml:lang=rutrue/value
-value xml:lang=sktrue/value
-value xml:lang=sltrue/value
-value xml:lang=svtrue/value
-value xml:lang=thtrue/value
-value xml:lang=trtrue/value
-value xml:lang=zh-CNtrue/value
-value xml:lang=zh-TWtrue/value
+value xml:lang=detrue/value
+  value xml:lang=arfalse/value
+  value xml:lang=catrue/value
+  value xml:lang=cstrue/value
+  value xml:lang=datrue/value
+  value xml:lang=eltrue/value
+  value xml:lang=estrue/value
+  value xml:lang=ettrue/value
+  value xml:lang=fitrue/value
+  value xml:lang=frtrue/value
+  value xml:lang=hetrue/value
+  value xml:lang=hi-INtrue/value
+  value xml:lang=hutrue/value
+  value xml:lang=ittrue/value
+  value xml:lang=jatrue/value
+  value xml:lang=kotrue/value
+  value xml:lang=nltrue/value
+  value xml:lang=pltrue/value
+  value xml:lang=pttrue/value
+  value xml:lang=pt-BRtrue/value
+  value xml:lang=rutrue/value
+  value xml:lang=sktrue/value
+  value xml:lang=sltrue/value
+  value xml:lang=svtrue/value
+  value xml:lang=thtrue/value
+  value xml:lang=trtrue/value
+  value xml:lang=zh-CNtrue/value
+  value xml:lang=zh-TWtrue/value
   /prop
   prop oor:name=DialogScale
 value xml:lang=x-no-translate10/value
-value xml:lang=ca10/value
-value xml:lang=cs10/value
-value xml:lang=da10/value
-value xml:lang=de0/value
-value xml:lang=el10/value
 value xml:lang=en-US10/value
-value xml:lang=es10/value
-value xml:lang=et10/value
-value xml:lang=fi10/value
-value xml:lang=fr10/value
-value xml:lang=he10/value
-value xml:lang=hi-IN10/value
-value xml:lang=hu10/value
-value xml:lang=it10/value
-value xml:lang=nl10/value
-value xml:lang=pl13/value
-value xml:lang=pt10/value
-value xml:lang=pt-BR10/value
-value xml:lang=sk10/value
-value xml:lang=sl10/value
-value xml:lang=sv10/value
-value xml:lang=th10/value
-value xml:lang=ar13/value
-value xml:lang=ja13/value
-value xml:lang=ko13/value
-value xml:lang=ru13/value
-value xml:lang=tr13/value
-value xml:lang=zh-CN13/value
-value xml:lang=zh-TW13/value
+value xml:lang=de0/value
+  value xml:lang=ar13/value
+  value xml:lang=ca10/value
+  value xml:lang=cs10/value
+  value xml:lang=da10/value
+  value xml:lang=el10/value
+  value xml:lang=es10/value
+  value xml:lang=et10/value
+  value xml:lang=fi10/value
+  value xml:lang=fr10/value
+  value xml:lang=he10/value
+  value xml:lang=hi-IN10/value
+  value xml:lang=hu10/value
+  value xml:lang=it10/value
+  value xml:lang=ja13/value
+  value xml:lang=ko13/value
+  value xml:lang=nl10/value
+  value xml:lang=pl13/value

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - configure.in

[Jan Iversen]

 configure.in |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b653ed6c9780961aa99cb1fc619355c5d2d94dcc
Author: Jan Iversen j...@apache.org
Date:   Tue Nov 19 20:00:28 2013 +

WITH_STLPORT is set to NO but the test later is != no.

Test is changed to NO, now it works on ubuntu.

diff --git a/configure.in b/configure.in
index 3df0746..9a3e3c0 100644
--- a/configure.in
+++ b/configure.in
@@ -2694,8 +2694,8 @@ dnl 
===
 dnl Checks for what the default STL should be
 dnl ===
AC_MSG_CHECKING([what the default STL should be])
-   DEFAULT_TO_STLPORT=no
-if test $WITH_STLPORT != no; then
+   DEFAULT_TO_STLPORT=NO
+if test $WITH_STLPORT != NO; then
AC_MSG_ERROR([Option --with-stlport is no longer available.])
 else
USE_SYSTEM_STL=YES
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - configure.in

[Jan Iversen]

 configure.in |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 48cc2c44aa27db91200bd12406fee7ab1f49fba1
Author: Jan Iversen j...@apache.org
Date:   Tue Nov 19 20:15:24 2013 +

WITH_STLPORT changed from NO to no, due to a standard set function

diff --git a/configure.in b/configure.in
index 9a3e3c0..a93c1cd 100644
--- a/configure.in
+++ b/configure.in
@@ -644,7 +644,7 @@ AC_ARG_WITH(system-redland,
 ],,)
 AC_ARG_WITH(stlport,
 [  --with-stlport Only building --without-stlport is supported.
-], WITH_STLPORT=$withval , WITH_STLPORT=NO)
+], WITH_STLPORT=$withval , WITH_STLPORT=no)
 AC_ARG_WITH(jdk-home,
 [  --with-jdk-home if you have installed JDK 1.3 or later on your 
system
   please supply the path here.
@@ -2694,8 +2694,8 @@ dnl 
===
 dnl Checks for what the default STL should be
 dnl ===
AC_MSG_CHECKING([what the default STL should be])
-   DEFAULT_TO_STLPORT=NO
-if test $WITH_STLPORT != NO; then
+   DEFAULT_TO_STLPORT=no
+if test $WITH_STLPORT != no; then
AC_MSG_ERROR([Option --with-stlport is no longer available.])
 else
USE_SYSTEM_STL=YES
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] install_cygwin.ps1

[jan iversen]

Hi.

During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not
install python3 (tested on a 64 bit system).

In fact it only installs python, due to a dependency from git.

It turns out the -P flags needs a bit of reordering, and then it works as
expected.

I have attached the new install_cygwin.ps1, since it is stored somewhere on
our web server. I hope somebody can verify the "patch" and update the
server.

Bjoern@ this is the problem we discussed in Hamburg, giving problems later
when trying to generate a visual studio solution.

rgds
jan I.


Ps: my normal email is j...@documentfoundation.com, but for logistic
reasons I am unable to use that now.


install_cygwin.ps1
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] install_cygwin.ps1

[jan iversen]

On Friday, 30 October 2015, Norbert Thiebaud <nthieb...@gmail.com> wrote:

> On Thu, Oct 29, 2015 at 6:07 PM, jan iversen <jancasacon...@gmail.com
> <javascript:;>> wrote:
> > Hi.
> >
> > During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not
> > install python3 (tested on a 64 bit system).
> >
> > In fact it only installs python, due to a dependency from git.
> >
> > It turns out the -P flags needs a bit of reordering, and then it works as
> > expected.
> >
> > I have attached the new install_cygwin.ps1, since it is stored somewhere
> on
> > our web server.
>
>
> https://gerrit.libreoffice.org/gitweb?p=lode.git;a=blob;f=bin/install_cygwin.ps1;h=596befa42226fe41e109d97ec1b335eed4f4c508;hb=refs/heads/master
>
> it is stored on a web server because people need to get it without
> having git or cygwin installed.. since it is to install cygwin...
> but the 'source' is in the lode.git repo

Thanks for the answer, I will make a copy of that repo (so much for "core
is the only repo you will ever need")

I was told (on irc) by mst that our web server content is not in git (which
in my mind seems wrong). I do of course agree that this script needs to be
on the webserver.

rgds
jan i

>
> Norbert
>


-- 
Sent from My iPad, sorry for any misspellings.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: git / gerrit best work flow ?

[jan iversen]

Thanks a lot for the input, I now have a good idea how to explain the work
flow to others.

I like the idea of branching that is a natural part of GIT.

rgds
jan i.




--
View this message in context: 
http://nabble.documentfoundation.org/git-gerrit-best-work-flow-tp4165745p4165795.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Coverity, read-only generic account.

[jan iversen]

Hi.

I would like that we have a generic account in coverity (read-only), so that
e.g. I
can show new people the issues there.

Currently (because we also seems not to have a report module), I have to
copy/paste information from coverity in order to mail it to the people I try
to help.

If we make an account e.g. "libreoffice" with password "libreoffice" and
limit it
to reading, everybody could see the coverity issues.

Thoughts ?

rgds
jan I.




--
View this message in context: 
http://nabble.documentfoundation.org/Coverity-read-only-generic-account-tp4165797.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

git / gerrit best work flow ?

[jan iversen]

Hi.

I have a lode setup with dev/core and dev/work. I use work to work on my own
patches.

Sometimes I have to correct an older patch set, I do the following in core:

git pull

make changes
./logerrit ...

Then in order to cleanup I do
git reset head~
git checkout files from changeset

This does not seem optimal, any suggestion on how to effectively work with
different changesets fast ?

thanks in advance
rgds
jan I.



--
View this message in context: 
http://nabble.documentfoundation.org/git-gerrit-best-work-flow-tp4165745.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Developer Info

[jan iversen]

Hi.

you can use eclipse or whatever you want.

Here is your first error, it is a simple one, but let us make a little bit
more challenging :-)

Look in file /qadevOOo/runner/base/java_fat_service.java in function
executeTest();

It contains 2 function calls, that has no meaning, so they can be removed
without affecting how the
code works.

when you do you local commit, please give a commit msg like:

"cid#1329596, cid#1329597 

"

and then run (in core) run ./logerrit submit master

your patch will show up in your gerrit (menu "changes"), assign me (
j...@documentfoundation.org" as reviewer.

Feel free to ask if you are unsure.

Have fun
rgds
jan i.

Ps. this is a real simple bug, but it helps you understand how gerrit works
etc.



On 9 November 2015 at 11:24, Massimiliano Fiori <massimiliano.fi...@aol.it>
wrote:

> Hi, Thank you Jan,
> i registered on gerrit platform.
> I prefer, if is possible, to see your Java problems for try to create my
> first patch, is it possible to use an IDE, like Eclipse, to edit the java
> code in easy way?
>
> Reagards,
> Massimiliano.
>
>
>
> Il giorno 08 nov 2015, alle ore 18:44, jan iversen <
> jancasacon...@gmail.com> ha scritto:
>
> Congratulations !!! that is actually the most difficult step.
>
> Now when both of you have time it would be good for you to register on the
> mailing list:
> http://nabble.documentfoundation.org/
>
> This is where we all "talk" together.
>
> Sooner or later you will also need to register in Gerrit:
> https://wiki.documentfoundation.org/Development/gerrit
>
> we use gerrit to submit and review patches, this is not mandatory for the
> first couple
> of patches, I can do it for you, but it is something you need to get used
> to.
>
> Finally here is a link to "easy hacks":
> https://wiki.documentfoundation.org/Development/Easy_Hacks
>
> Which is problems that are easy to solve, and are there for new people. I
> do however
> also have a set of problems in java, which are open. Most of the java
> problems are
> simple problems, but typically in multiple files. So whatever you prefer I
> am there
> to help you.
>
> Sukant@ Do not be stressed getting your environment up and running, there
> are plenty
> of work waiting.
>
> have a nice day.
> rgds
> jan i.
>
>
>
> On 8 November 2015 at 17:06, Massimiliano Fiori <massimiliano.fi...@aol.it
> > wrote:
>
>> Hi,
>> Yes i hadn't set CCACHE correctly. Now i have builded lode successfully.
>> Now what is my next step to create a patch for the project?
>>
>> Thanks a lot,
>> Massimiliano.
>>
>>
>> Il giorno 07 nov 2015, alle ore 21:11, jan iversen <
>> jancasacon...@gmail.com> ha scritto:
>>
>> Hi.
>>
>> I researched it a bit more, it seems that the clang compiler is not well
>> supported by lode.
>>
>> Have a look at:
>>
>> https://wiki.documentfoundation.org/Development/Building_LibreOffice_with_Clang#Setup
>>
>> the developer specialists told me, that your problem is typically caused
>> because you
>> do not have
>>
>> CCACHE_CPP2=1
>>
>> Have fun
>>
>> rgds
>>
>> jan i.
>>
>>
>>
>> On 7 November 2015 at 19:59, jan iversen <jancasacon...@gmail.com> wrote:
>>
>>> Hi.
>>>
>>> It seems to me you missed the "autogen.sh" statement.
>>>
>>> you ran "setup --dev" and checked out the source.
>>>
>>> then you need to do:
>>>
>>> cd dev/core
>>> ./autogen.sh
>>>
>>> and after that (if it does not give you any errors)
>>> ../../opt/bin/make 2>&1 | tee build.log
>>>
>>> you can run ./autogen.sh anytime, so please run it again, and make sure
>>> it does not report errors.
>>>
>>> Secondly it is important that you use "../../opt/bin/make" and NOT the
>>> make standard in OSX.
>>>
>>> Finally you need to deactivate your virus checker (this is not the
>>> problem right now).
>>>
>>> Please try my suggestion, and then let me have the whole build.log
>>>
>>> have fun
>>> jan i.
>>>
>>> On 7 November 2015 at 14:54, Massimiliano Fiori <
>>> massimiliano.fi...@aol.it> wrote:
>>>
>>>> Hi Sakunt,
>>>> nice to meet you!
>>>>
>>>> I try to build lode and i have this error after '../../opt/bin/make 2>&
>>>> 1 | tee build.log’ command :
>>>>
>>>> [build C  ] cppuhelper/source/

Re: Developer Info

[jan iversen]

Congratulations !!! that is actually the most difficult step.

Now when both of you have time it would be good for you to register on the
mailing list:
http://nabble.documentfoundation.org/

This is where we all "talk" together.

Sooner or later you will also need to register in Gerrit:
https://wiki.documentfoundation.org/Development/gerrit

we use gerrit to submit and review patches, this is not mandatory for the
first couple
of patches, I can do it for you, but it is something you need to get used
to.

Finally here is a link to "easy hacks":
https://wiki.documentfoundation.org/Development/Easy_Hacks

Which is problems that are easy to solve, and are there for new people. I
do however
also have a set of problems in java, which are open. Most of the java
problems are
simple problems, but typically in multiple files. So whatever you prefer I
am there
to help you.

Sukant@ Do not be stressed getting your environment up and running, there
are plenty
of work waiting.

have a nice day.
rgds
jan i.



On 8 November 2015 at 17:06, Massimiliano Fiori <massimiliano.fi...@aol.it>
wrote:

> Hi,
> Yes i hadn't set CCACHE correctly. Now i have builded lode successfully.
> Now what is my next step to create a patch for the project?
>
> Thanks a lot,
> Massimiliano.
>
>
> Il giorno 07 nov 2015, alle ore 21:11, jan iversen <
> jancasacon...@gmail.com> ha scritto:
>
> Hi.
>
> I researched it a bit more, it seems that the clang compiler is not well
> supported by lode.
>
> Have a look at:
>
> https://wiki.documentfoundation.org/Development/Building_LibreOffice_with_Clang#Setup
>
> the developer specialists told me, that your problem is typically caused
> because you
> do not have
>
> CCACHE_CPP2=1
>
> Have fun
>
> rgds
>
> jan i.
>
>
>
> On 7 November 2015 at 19:59, jan iversen <jancasacon...@gmail.com> wrote:
>
>> Hi.
>>
>> It seems to me you missed the "autogen.sh" statement.
>>
>> you ran "setup --dev" and checked out the source.
>>
>> then you need to do:
>>
>> cd dev/core
>> ./autogen.sh
>>
>> and after that (if it does not give you any errors)
>> ../../opt/bin/make 2>&1 | tee build.log
>>
>> you can run ./autogen.sh anytime, so please run it again, and make sure
>> it does not report errors.
>>
>> Secondly it is important that you use "../../opt/bin/make" and NOT the
>> make standard in OSX.
>>
>> Finally you need to deactivate your virus checker (this is not the
>> problem right now).
>>
>> Please try my suggestion, and then let me have the whole build.log
>>
>> have fun
>> jan i.
>>
>> On 7 November 2015 at 14:54, Massimiliano Fiori <
>> massimiliano.fi...@aol.it> wrote:
>>
>>> Hi Sakunt,
>>> nice to meet you!
>>>
>>> I try to build lode and i have this error after '../../opt/bin/make 2>&1
>>> | tee build.log’ command :
>>>
>>> [build C  ] cppuhelper/source/findsofficepath.c
>>> clang: error: argument unused during compilation: '-I
>>> /Users/Bayway/Developer/lode/dev/core/cppuhelper/source/'
>>> clang: error: argument unused during compilation: '-I
>>> /Users/Bayway/Developer/lode/dev/core/include'
>>> clang: error: argument unused during compilation: '-I
>>> /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/include'
>>> clang: error: argument unused during compilation: '-I
>>> /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/include/darwin'
>>> clang: error: argument unused during compilation: '-I
>>> /Users/Bayway/Developer/lode/dev/core/config_host'
>>> /Users/Bayway/Developer/lode/dev/core/solenv/gbuild/LinkTarget.mk:138:
>>> recipe for target
>>> '/Users/Bayway/Developer/lode/dev/core/workdir/CObject/cppuhelper/source/findsofficepath.o'
>>> failed
>>> make[1]: ***
>>> [/Users/Bayway/Developer/lode/dev/core/workdir/CObject/cppuhelper/source/findsofficepath.o]
>>> Error 1
>>> Makefile:247: recipe for target 'build' failed
>>> make: *** [build] Error 2
>>>
>>> My OS: Mac OSX 10.11.2
>>>
>>> Thanks for all,
>>> Massimiliano
>>>
>>>
>>> Il giorno 07 nov 2015, alle ore 09:21, jan iversen <
>>> jancasacon...@gmail.com> ha scritto:
>>>
>>> Hi Massimiliano.
>>>
>>> Welcome.
>>>
>>> Sakunt meet Massimiliano
>>> Massimiliano meet Sakunt.
>>>
>>> As I wrote to Sakunt, I am would like to help you get started and help
>>

[Libreoffice-commits] core.git: cppu/source

[jan iversen]

 cppu/source/uno/lbenv.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 5ff684477d7cb67a52223d555ae5f1341c6f8517
Author: jan iversen <j...@documentfoundation.org>
Date:   Mon Nov 9 19:13:57 2015 +0100

cid#1338242 cid#1338241 removed throw from extern "C" function

Encapsulated throw from C++ to a return false in the "C" function

Change-Id: I2fc89b0dcf434395859300b3d3890247d1288295
Reviewed-on: https://gerrit.libreoffice.org/19872
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthieb...@gmail.com>

diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx
index d036212..e1d294f 100644
--- a/cppu/source/uno/lbenv.cxx
+++ b/cppu/source/uno/lbenv.cxx
@@ -1050,10 +1050,16 @@ static bool loadEnv(OUString const  & cLibStem,
 // late init with some code from matching uno language binding
 // will be unloaded by environment
 osl::Module aMod;
-bool bMod = cppu::detail::loadModule(aMod, cLibStem);
-
-if (!bMod)
+try {
+bool bMod = cppu::detail::loadModule(aMod, cLibStem);
+if (!bMod)
+return false;
+}
+catch(...) {
+// Catch everything and convert to return false
 return false;
+}
+
 
 uno_initEnvironmentFunc fpInit = 
reinterpret_cast(aMod.getSymbol(UNO_INIT_ENVIRONMENT));
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cppu/source

[jan iversen]

 cppu/source/uno/lbmap.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 6a2440ea91bb86cba74ecbb8afd520c8afa41ded
Author: jan iversen <j...@documentfoundation.org>
Date:   Mon Nov 9 19:30:30 2015 +0100

cid#1338241 removed throw from C function.

Lower level C++ make a throw, this cannot be passed
back in a C function.

Change-Id: I54ace0284d0291d54f53b8947e9f4ffc2e0a56ab
Reviewed-on: https://gerrit.libreoffice.org/19873
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthieb...@gmail.com>

diff --git a/cppu/source/uno/lbmap.cxx b/cppu/source/uno/lbmap.cxx
index 51e1c26..82060fd 100644
--- a/cppu/source/uno/lbmap.cxx
+++ b/cppu/source/uno/lbmap.cxx
@@ -350,7 +350,14 @@ static inline bool loadModule(osl::Module & rModule, const 
OUString & rBridgeNam
 
 if (!bNeg)
 {
-bool bModule = cppu::detail::loadModule(rModule, rBridgeName);
+bool bModule;
+try {
+bModule = cppu::detail::loadModule(rModule, rBridgeName);
+}
+catch(...) {
+// convert throw to return false
+bModule = false;
+}
 
 if (bModule)
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Coverity, read-only generic account.

[jan iversen]

> I don't even think the Coverity issues are a good set of tasks for
> newcomers.
>
> I respectfully disagree, I agree Coverity issues should not be picked by
newcomers, but there are a number of them that could be assigned to
newcomers with a mentors help.


> We mostly have close to zero open issues there anyway.
>
383 outstanding this morning, is of course not a lot considering the code
size, but still enough to do something about it.


>
> One example is when we recently started to get Coverity/FindBugs issues in
> Java code.  Many of the FindBugs findings need to be taken with a grain of
> salt, and fixing them naively means being overly optimistic. (For example,
> a private field of a class not being used in that class does not
> necessarily mean it should be removed, as it could be used via reflection.)
>
That is actually exactly one of the reasons why I like to use such issues,
it learns a newcomer to not only lot at the problem in itself, but also
consider the sideeffects.


>
> Another example is when the implementation of osl_getSystemPathFromFileURL
> recently happened to start to throw std::length_error,  That means that it
> is probably often better to let such an exception lead to std::unexpected
> -> std::abort and a core dump and backtrace that a developer can act upon,
> than to catch and somehow handle it, and there by obscure the root cause of
> a problem.

 I see your point, but do not agree in the general case (there are a lot of
examples on this where I do agree), however this again is a good example
for a newcomer, and should lead to a status change in coverty (Intended).

In general I prefer people to not only submit a patch, but also understand
the consequences...and sometimes not submitting a patch, but indicating
this is an intented behaivour is also a solution. What I do not like is
that such issues are kept open and thus potentially multiple people waste
time coming to the same conclusion.

rgds
jan i.

>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: license statement

[jan iversen]

Hi.

thanks for your license statement, if you need help getting started, I am
happy to help out, mail me directly.

have a nice day
rgds
jan i.



--
View this message in context: 
http://nabble.documentfoundation.org/Keigo-Kawamura-license-statement-tp4166221p4166287.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Solving Cygwin path breaking issue of autogen.sh

[jan iversen]

Hi.

Building on a "normal" VM is not a problem, as you note, but a USB disk
depend on the formatting, if you have formatted it with FAT32 instead of
NTFS, Cygwin sometimes "forget" the limitation and believes it is NTFS,
meaning long names. The fsutil statement forces cygwin to use good old 8.3
names.

If you need / want help with feel free to write here or directly.

rgds
jan i.



--
View this message in context: 
http://nabble.documentfoundation.org/Solving-Cygwin-path-breaking-issue-of-autogen-sh-tp4166300p4166410.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Getting Started with LO Dev

[jan iversen]

>
> Hope this helps others who ever face a similar problem.
>
>
Another solution is to use lode
 which highly
simplifies setting up the environment.

Let me know if I can help you getting more familiar with libreoffice, and
start submitting patches.

There are a number of tools and wiki pages that can help you, but I believe
human contact is the most important help,
which is why I offer it.

happy programming.
rgds
jan i.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java   |4 ++--
 qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e1fc599eb764186e5d511ace9785463eebbc7028
Author: jan iversen <j...@documentfoundation.org>
Date:   Fri Nov 6 09:15:51 2015 +0100

cid#1326599, cid#1326598: added throw (status generation)

Status.failed( ... ); is prepended with a throw
added import
and removed the return;

Change-Id: I73bc971e054c8726e45db0d5a37613c871691eab
Reviewed-on: https://gerrit.libreoffice.org/19793
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
Tested-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java 
b/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
index 2ba5bb6..1f3eb73 100644
--- a/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
+++ b/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
@@ -19,6 +19,7 @@
 package ifc.drawing;
 
 import lib.MultiMethodTest;
+import lib.StatusException;
 import lib.Status;
 
 import com.sun.star.drawing.XDrawPage;
@@ -51,8 +52,7 @@ public class _XDrawPageExpander extends MultiMethodTest {
 XDrawPage oDrawPage = (XDrawPage) tEnv.getObjRelation("DrawPage");
 if ( oDrawPage == null ) {
 // SKIPPED.FAILED - the ObjectRelation is not available
-Status.failed( "ObjectRelation('DrawPages') XDrawPages n.a.");
-return;
+throw new StatusException(Status.failed( 
"ObjectRelation('DrawPages') XDrawPages n.a."));
 }
 log.println("testing expand() ... ");
 
diff --git a/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java 
b/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
index dca8370..b346f93 100644
--- a/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
+++ b/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
@@ -19,6 +19,7 @@
 package ifc.drawing;
 
 import lib.MultiMethodTest;
+import lib.StatusException;
 import lib.Status;
 
 import com.sun.star.drawing.XDrawPageSummarizer;
@@ -50,8 +51,7 @@ public class _XDrawPageSummarizer extends MultiMethodTest {
 XDrawPages oDrawPages = (XDrawPages) tEnv.getObjRelation("DrawPages");
 if ( oDrawPages == null ) {
 // SKIPPED.FAILED - the ObjectRelation is not available
-Status.failed( "ObjectRelation('DrawPages') XDrawPages n.a." );
-return;
+throw new StatusException(Status.failed( 
"ObjectRelation('DrawPages') XDrawPages n.a." ));
 }
 log.println("testing summarize() ... ");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] install_cygwin.ps1

[jan iversen]

On 30 October 2015 at 01:13, Norbert Thiebaud <nthieb...@gmail.com> wrote:

> On Thu, Oct 29, 2015 at 6:32 PM, jan iversen <jancasacon...@gmail.com>
> wrote:
> >
> >
> >
> > Thanks for the answer, I will make a copy of that repo (so much for
> "core is
> > the only repo you will ever need")
>
> if you downloaded and used that ps1 file, that indicate that you were
> following the 'lode' ways of setting up a build environment (a good
> thing.. but I'm partial :-) ).
> step 2 of this process _is_ to download the lode.git repo.. so you
> should really already have it.
>

I did all of that, but surprise the logerrit in core only handles core, no
support for newbees that want to submit patches for different parts.

Please bear over with me, I am trying to follow the instructions to the
letter (as a newbee would), and have already made several changes to the
lode
wiki pages to clarify a couple of pitfalls. My intentions was to work as a
completely new person, which of course included submitting a patch by mail
(since logerrit does not work for lode) and see how it was handled.

with a little git magic (including copying .gitreview) I managed to push my
patch to gerrit:
https://gerrit.libreoffice.org/19681

Looking forward to see if it gets committed.


>
> And yes core.git is all you need to build the product ( although
> depending on the build option you may get dictionaries.git, help.git
> and/or translation.git as git submodule).
> lode.git is a separate 'tools' developed originally to help deploying
> ci slavebot.
> lode help among other thing 'manage' core.git using a local bare
> mirror clone --reference to deply build environment cheaply.
> it could not live in core.git again due to a chicken and egg problem.
>
> and as you can see here: https://gerrit.libreoffice.org/#/admin/projects/

I actually saw nearly the same, looking at the git repos, and then a nice
person at the hackfest told me to forget it all :-)



>
>
> we do have quite a few auxiliary git repo under management :-)
>
> >I was told (on irc) by mst that our web server content is not in git
> (which in my mind seems wrong)
>
> most of it is not, for good reason.. git is not the best way to manage
> a bunch of fat tar.gz source release of all the external dependencies
> we use.
> I've put that particular script _there_ as a convenience (convenient
> to me as that web server already existed and server plain file), but
> really the cygwin_install scrip is completely unrelated to the rest of
> the content there.
>
Sorry I should have been more strict in my wording, I meant the static
parts, of course source tar balls etc does not belong in git.

A case could be made as to where the script belongs, but I happen to agree
with you that it has a good place.

Sorry for being a pain, I am just trying to get up to speed on how TDF/LO
does things so I later can be better help to new people.

rgds
jan i.


>
> Norbert
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sal/qa

[jan iversen]

 sal/qa/osl/pipe/osl_Pipe.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit cdd6aca142495e433d70f85fee2851b60bc0d299
Author: jan iversen <j...@documentfoundation.org>
Date:   Tue Nov 3 08:49:45 2015 +0100

Solved CID 1338058 and CID 1338057

terminated buf correctly before calling printf.
This should be done automatically but coverity does not see it.

Change-Id: I0bcf8486b27dbfa9f7c49b338bbf483029b523cb
Reviewed-on: https://gerrit.libreoffice.org/19751
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
Tested-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/sal/qa/osl/pipe/osl_Pipe.cxx b/sal/qa/osl/pipe/osl_Pipe.cxx
index 9f1ae6e..9f04b50 100644
--- a/sal/qa/osl/pipe/osl_Pipe.cxx
+++ b/sal/qa/osl/pipe/osl_Pipe.cxx
@@ -766,6 +766,7 @@ namespace osl_StreamPipe
 printf("read failed! \n");
 return;
 }
+buf[sizeof(buf)-1] = '\0';
 printf("buffer is %s \n", buf);
 printf("send\n");
 nChars = aSenderPipe.send( m_pTestString2.getStr(), 
m_pTestString2.getLength() + 1 );
@@ -829,6 +830,7 @@ namespace osl_StreamPipe
 printf("server receive failed! \n");
 return;
 }
+buf[sizeof(buf)-1] = '\0';
 printf("received message is: %s\n", buf );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[DISCUSS] Gerrit setup.

[jan iversen]

Hi

First of all sorry if I post this on the wrong list, but it seems to be a
cross issue.

I am looking through all the open issues in Gerrit, and it would be really
helpful, to have an indication
of whether or not the submitter has commit access to the repo.

Having an indication (e.g. a * next to the user), would help identify who
are new users, that may need
more mentoring.

thoughts ?
jan I.

Ps. I did search the wiki, to see if I could find a list of people with
commit access, but I only found the 
total developer list.



--
View this message in context: 
http://nabble.documentfoundation.org/DISCUSS-Gerrit-setup-tp4164873.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [DISCUSS] Gerrit setup.

[jan iversen]

Thanks.

This was exactly what I looked for.

rgds
jan i



--
View this message in context: 
http://nabble.documentfoundation.org/DISCUSS-Gerrit-setup-tp4164873p4164875.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Developer Info

[jan iversen]

Hi Massimiliano.

Welcome.

Sakunt meet Massimiliano
Massimiliano meet Sakunt.

As I wrote to Sakunt, I am would like to help you get started and help you
get the first patches submitted.

The first 3-4 patches are always the most difficult, because you need to
get the environment setup, write
commit messagees correctly etc. but that is exactly the point where we can
work together.

Let us make a little "starter" and before you know it, you will be part of
our communty.

Please look around in the wiki, and get started with lode.

Feel free to mail me directly (this mail is cc to the mailing list, so the
other community member know what we
are doing) if you have questions or comments.

rgds
jan i.


On 7 November 2015 at 02:06, Massimiliano Fiori 
wrote:

> Hi,
> my name si Massimiliano and I have read your e-mail on list I would to
> help LibreOffice Project too and i would to take developer certificate in
> future, I've already worked on some easy hack, I can help in anyway?
> I have more experience in java but I also know C and Python
>
> Thanks a lot,
> Regards
>
> Massimiliano
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Two svg import filters

[jan iversen]

On 4 November 2015 at 15:40, Tomaž Vajngerl  wrote:

> Hi,
>
> On Wed, Nov 4, 2015 at 1:11 PM, Caolán McNamara 
> wrote:
> > We have svgio which is being used for insert->image->from file and
> > filter/source/svg which is being used for open file.
> >
> > Which one is "the future", and what prevents us from using it in both
> > places ?
>
> Both have its own uses. svgio is all about rendering fidelity and
> supports more svg features however the "filter/source/svg" filter
> tries to use standard features and attributes available in LO as much
> as possible - which is useful when you want to edit the shapes . For
> example you can see this with gradient shapes - svgio imports the
> shape correctly but is useless if you want to change the gradient.
>
But even so, it seems unwise to have 2 implementations, for sure larger
parts are identical.

If there are significant differences in how the svg file is delivered into
LO, it can be done with
a simple switch.

rgds
jan i.

>
> > C.
>
> Regards, Tomaž
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Jan Iversen - license statement

[jan iversen]

To the extent possible under law, I waive all copyright and related or
neighboring
   rights to my past & future contributions to LibreOffice:
   http://creativecommons.org/publicdomain/zero/1.0



--
View this message in context: 
http://nabble.documentfoundation.org/Jan-Iversen-license-statement-tp4165252.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Jan Iversen - license statement

[jan iversen]

And for any code I might make:

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.



--
View this message in context: 
http://nabble.documentfoundation.org/Jan-Iversen-license-statement-tp4165252p4165253.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: contributing to libreoffice

[jan iversen]

Hi.

My name is Jan Iversen (you find me around as jani), I am glad to see you
want to join a very
lively project.

You can (and should) for sure read you wiki about development, but it can be
rather hard to read through
all that material so I offer you another solution.

I would be happy to mentor you, and help you submit the first vital patches.
I am right now starting
an initative to reduce our open report in coverity (do you know this tool?),
and have a lot of simple
java stuff that needs to be done. It would help you get started.

If interested mail me directly at j...@documentfoundation.org

The very first thing you need to do it to get a development environment up
and running, please use this link
https://wiki.documentfoundation.org/Development/lode

And do let me know if you have any difficulties, or if you think some of the
items are explained too difficult.

Looking forward to help you work on LibreOffice.

rgds
jan I.




--
View this message in context: 
http://nabble.documentfoundation.org/contributing-to-libreoffice-tp4165514p4165523.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: contributing to libreoffice

[jan iversen]

Hi.

My name is Jan Iversen (you find me around as jani), I am glad to see you
want to join a very
lively project.

You can (and should) for sure read you wiki about development, but it can
be rather hard to read through
all that material so I offer you another solution.

I would be happy to mentor you, and help you submit the first vital
patches. I am right now starting
an initative to reduce our open report in coverity (do you know this
tool?), and have a lot of simple
java stuff that needs to be done. It would help you get started.

If interested mail me directly at j...@documentfoundation.org

The very first thing you need to do it to get a development environment up
and running, please use this link
https://wiki.documentfoundation.org/Development/lode

And do let me know if you have any difficulties, or if you think some of
the items are explained too difficult.

Looking forward to help you work on LibreOffice.

rgds
jan I.


On 6 November 2015 at 11:42, Sukant Kumar <sukant.kuma...@gmail.com> wrote:

> Hi, i am sukant kumar pursuing B.tech from Bhagalpur college of
> engineering.
> i want to contribute for LIBREOFFICE community.
> i have a prior knowledge of c , c++ and java .
> i have no prior experience in contributing to open source development.
> can any one please guide me for contributing to the community.
> expecting a positive reply.
>
> thank you,
> with regard.
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes

[jan iversen]

On 4 November 2015 at 11:21, Norbert Thiebaud  wrote:

> On Wed, Nov 4, 2015 at 3:42 AM, Stephan Bergmann 
> wrote:
> > On 11/04/2015 09:16 AM, Daniel Robertson wrote:
> >>
> >> commit f57a6593e21d45008173352fc29ededdbc2c8878
> >> Author: Daniel Robertson 
> >> Date:   Tue Nov 3 14:14:08 2015 -0500
> >>
> >>  editeng: Eliminate unecessary padding in classes
> >>
> >>  Edit the order of SvxLRSpaceItem and PaintFirstLineInfo members to
> >>  remove unecessary padding due to data alignment.
> >>
> >>  Change-Id: Icf2c92ef86a32384e51d1cb6f1a079b10995dfd5
> >>  Reviewed-on: https://gerrit.libreoffice.org/19763
> >>  Tested-by: Jenkins 
> >>  Reviewed-by: Norbert Thiebaud 
> >>
> > [...]
> >>
> >> diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx
> >> index 40da999..94daed8 100644
> >> --- a/include/editeng/lrspitem.hxx
> >> +++ b/include/editeng/lrspitem.hxx
> >> @@ -50,15 +50,15 @@
> >>
> >>   class EDITENG_DLLPUBLIC SvxLRSpaceItem : public SfxPoolItem
> >>   {
> >> -short   nFirstLineOfst; // First-line indent _always_ relative
> to
> >> nTxtLeft
> >>   longnTxtLeft;   // We spend a sal_uInt16
> >>   longnLeftMargin;// nLeft or the negative first-line
> >> indent
> >>   longnRightMargin;   // The unproblematic right edge
> >>
> >>   sal_uInt16  nPropFirstLineOfst, nPropLeftMargin, nPropRightMargin;
> >> +short   nFirstLineOfst; // First-line indent _always_ relative
> to
> >> nTxtLeft
> >
> >
> > With micro-optimization changes like these, I would leave it to some
> domain
> > expert to decide whether it is actually worth it (i.e., whether on the
> one
> > hand the existing member order had been chosen deliberately, to aid human
> > comprehension, and whether on the other hand enough instances of that
> class
> > are created to warrant any such optimization).
>
> Domain expert are the last one to reliably evaluate 'human
> comprehension", since they _are_ domain expert
> wrt to the number of instance... even if there is only one. is it a
> reason to be sloppy ?
>
> >
> >>   boolbAutoFirst  : 1;// Automatic calculation of the
> >> first line indent
> >> -boolbExplicitZeroMarginValRight;
> >> -boolbExplicitZeroMarginValLeft;
> >> +boolbExplicitZeroMarginValRight : 1;
> >> +boolbExplicitZeroMarginValLeft : 1;
> >
> >
> > It is unclear whether that is an optimization or a pessimization.
>
> you can choose size or perf.. but having a
> bool foo:1
> followed by 2 plain bool
> is wrong either way.
>
Correct, things like that make many compilers drop optimization for the
whole class.

Always foo:1 first and then others.

As a side note, also remember that when using initializers in the
constructor, while digging into the code I have seen a couple of places
where the
sequence of initializers do not match the declaration sequence.

rgds
jan i

>
> Norbert
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: alexey.chemichev license statement

[jan iversen]

Hi Alexey.

Just saw your license statement, welcome to a lively community.

I use part of my time, to help people getting patches submitted and finding
their hold in the community, so please feel free to contact me (directly)
if you have questions or comments.

have a nice hacking day.
rgds
jan i.


On 18 November 2015 at 18:03, Alexey Chemichev 
wrote:

> Hi
>
> All of my past & future contributions to LibreOffice may be licensed under 
> the MPLv2/LGPLv3+ dual license.
>
> Best Regards
> Alexey Chemichev
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: qadevOOo/runner

[jan iversen]

 qadevOOo/runner/util/ValueComparer.java |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit a9824e8e05bddbf8ec417c7e5447914dd22cb8e5
Author: jan iversen <j...@documentfoundation.org>
Date:   Fri Dec 4 12:45:43 2015 +0100

cid#1326591, cid#1326590 useless call

The call does not do anything, removed.

Change-Id: I24e37ec47551f7dc47a4be6f717f95800624500f
Reviewed-on: https://gerrit.libreoffice.org/20392
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Noel Grandin <noelgran...@gmail.com>

diff --git a/qadevOOo/runner/util/ValueComparer.java 
b/qadevOOo/runner/util/ValueComparer.java
index dfc0768..4d54d14 100644
--- a/qadevOOo/runner/util/ValueComparer.java
+++ b/qadevOOo/runner/util/ValueComparer.java
@@ -239,10 +239,13 @@ public class ValueComparer {
 result = true;
 
 else if(XInterface.class.isAssignableFrom(op1.getClass()) && 
XInterface.class.isAssignableFrom(op2.getClass()))
-compareInterfaces((XInterface)op1, (XInterface)op2);
-
+{
+// ignore
+}
 else if(Enum.class.isAssignableFrom(op1.getClass()) && 
Enum.class.isAssignableFrom(op2.getClass()))
-compareEnums((Enum)op1, (Enum)op2);
+{
+// ignore
+}
 
 else if(op1.getClass() == String.class && op2.getClass() == 
String.class) // is it a String ?
 result = ((String)op1).equals(op2);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Bad HTML output

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 06 Dec 2015, at 00:54, Thorsten Behrens  
> wrote:
> 
> Alexander wrote:
>> Please, make just and good quality HTML output: or as be before, or
>> remake with select HTML (html 4, xhtml, html5) versions and select
>> by user embed/separate images with.  Embed images in HTML without
>> select possibility -- it is wrong way.
> Hi Alexander,
> 
> this is the developer list - Regina already pointed out two bugs about
> this issue, both referencing the commit that introduced it:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5dd1b3da57862a6577717544dde56482add89170
> 
> Is that enough of a code pointer to get you started? Note that we'd
> want both ways to work going forward, so you'd want to hack up two
> branches, controlled by a flag.

Hi
If you need help getting started and preparing the patch, I am here to help.

Setting up the LO enviroment and getting the first build done, in order, to 
solve your problem can be a lot to learn, but I can take you through it step by 
step.

Looking forward to see a patch from you.
rgds
jan i.

> 
> Cheers,
> 
> -- Thorsten
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Clayton Cornell license statement

[jan iversen]

Hi Clayton

Nice to see you again, in another context.

Thanks for your license statement, I am here to help people getting their first 
patch submitted so please feel free to email me, if you have any problems or 
questions.

Looking forward to see a patch from you
rgds
jan i.

Sent from my iPad, please excuse any misspellings 

> On 06 Dec 2015, at 15:10, C  wrote:
> 
> All of my past & future contributions to LibreOffice may be licensed
> under the MPLv2/LGPLv3+ dual license.
> 
> Clayton Cornell
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Pierre Sauter license statement

[jan iversen]

Thanks for your license statement.

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings
> 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: pasqual milvaques license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: solenv/gbuild

[jan iversen]

 solenv/gbuild/gbuild.help.txt |   35 +--
 1 file changed, 21 insertions(+), 14 deletions(-)

New commits:
commit 361dfe0cced6e621eea7b6b5e087b1aec9c3ba4a
Author: jan iversen <j...@documentfoundation.org>
Date:   Sun Nov 29 09:59:37 2015 +0100

gbuild: expanded "make help" with missing targets.

Change-Id: I10d30097a7e7099d43a6760489dcbbf405828960
Reviewed-on: https://gerrit.libreoffice.org/20267
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
Tested-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/solenv/gbuild/gbuild.help.txt b/solenv/gbuild/gbuild.help.txt
index aead63d..9362667 100644
--- a/solenv/gbuild/gbuild.help.txt
+++ b/solenv/gbuild/gbuild.help.txt
@@ -27,20 +27,27 @@ IMPORTANT OPTIONS
(descriptions from GNU make man page)
 
 AVAILABLE TARGETS
-   all  build product and run unit tests (default goal)
-   unitcheckrun unit tests
-   slowcheckrun slow unit tests
-   subsequentcheck  run system tests (requires full installation)
-   stagingcheck run (unstable/failing) tests from staging area
-(requires full installation)
-   perfcheckrun performance/callgrind unit tests
-   checkrun unit tests and if in toplevel subsequentcheck
-   cleanremove all generated files
-   debugrun starts the INSTDIR instance and allows tests to be run
-against it
-   dump-deps-pngcreates dependency diagrams in PNG format
-NOTE: needs graphviz to work
-   showmodules  shows all registered modules
+   all  build product and run unit tests (default goal)
+   cleanremove all generated files
+   debugrun starts the INSTDIR instance and allows tests to
+be run against it
+   checkrun unit tests and if in toplevel subsequentcheck
+   unitcheckrun unit tests
+   slowcheckrun slow unit tests
+   subsequentcheck  run system tests (requires full installation)
+   stagingcheck run (unstable/failing) tests from staging area
+(requires full installation)
+   perfcheckrun performance/callgrind unit tests
+
+   build-l10n-only  builds translation files for the build products
+   build-non-l10n-only  builds the product without the localization files
+   translations extract .pot files to workdir/pot
+
+   packageinfo  generates package information for distros
+   dump-deps-pngcreates dependency diagrams in PNG format
+NOTE: needs graphviz to work
+   showmodules  shows all registered modules
+
 build the named module
.build   build the named module without running unittests
.check   run unittests of the named module
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/io/_XDataOutputStream.java |   31 +
 1 file changed, 8 insertions(+), 23 deletions(-)

New commits:
commit b0ef4a1618624dc506075aab789581e270a47654
Author: jan iversen <j...@documentfoundation.org>
Date:   Wed Dec 9 11:10:40 2015 +0100

cid#1326581-8 useless calls.

Rebuild the type check to one set of "or" and a throw

Change-Id: I99bf688bdf60c357be4cc5dcd9b7be2532b6fbdb
Reviewed-on: https://gerrit.libreoffice.org/20491
    Reviewed-by: jan iversen <j...@documentfoundation.org>
Tested-by: jan iversen <j...@documentfoundation.org>

diff --git a/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java 
b/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
index 3643c06..3ea1119 100644
--- a/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
+++ b/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
@@ -69,29 +69,14 @@ public class _XDataOutputStream extends MultiMethodTest {
 for (int i = 0; i < data.size(); i++) {
 dataElem = data.get(i) ;
 
-if (dataElem instanceof Boolean) {
-((Boolean)dataElem).booleanValue();
-}
-else if (dataElem instanceof Byte) {
-((Byte)dataElem).byteValue();
-}
-else if (dataElem instanceof Character) {
-((Character)dataElem).charValue();
-}
-else if (dataElem instanceof Short) {
-((Short)dataElem).shortValue();
-}
-else if (dataElem instanceof Integer) {
-((Integer)dataElem).intValue();
-}
-else if (dataElem instanceof Long) {
-((Long)dataElem).longValue();
-}
-else if (dataElem instanceof Float) {
-((Float)dataElem).floatValue();
-}
-else if (dataElem instanceof Double) {
-((Double)dataElem).doubleValue();
+if (!(dataElem instanceof Boolean   ||
+  dataElem instanceof Byte) ||
+  dataElem instanceof Character ||
+  dataElem instanceof Short ||
+  dataElem instanceof Integer   ||
+  dataElem instanceof Float ||
+  dataElem instanceof Double)   {
+throw new RuntimeException("Object dataElem type not found.");
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/awt/_XTabController.java |1 -
 1 file changed, 1 deletion(-)

New commits:
commit d118979da4a44691268dbfb1fb01b6ed3954885e
Author: jan iversen <j...@documentfoundation.org>
Date:   Wed Dec 9 11:18:47 2015 +0100

cid#1326589 useless call

Removed function call, the function changes nothing or controls anything

Change-Id: Ia243c31134ee5a32d50140faf8e64f55b30c218f
Reviewed-on: https://gerrit.libreoffice.org/20493
Reviewed-by: jan iversen <j...@documentfoundation.org>
    Tested-by: jan iversen <j...@documentfoundation.org>

diff --git a/qadevOOo/tests/java/ifc/awt/_XTabController.java 
b/qadevOOo/tests/java/ifc/awt/_XTabController.java
index 1271b72..8b64978 100644
--- a/qadevOOo/tests/java/ifc/awt/_XTabController.java
+++ b/qadevOOo/tests/java/ifc/awt/_XTabController.java
@@ -101,7 +101,6 @@ public class _XTabController extends MultiMethodTest {
 public void _getContainer() {
 requiredMethod( "setContainer()");
 oObj.getContainer();
-tEnv.getObjRelation("CONTAINER");
 tRes.tested("getContainer()", Status.skipped(true) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Congratulations.

[jan iversen]

I just merged your first patch. I modified the commit message a bit.

Looking forward to more java to python conversions from you. I think the 
easiest is to keep the documents in their place for now, and once you have all 
tests converted then move them and update the makefile.

Have fun
rgds
jan i.


Sent from my iPad, please excuse any misspellings 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: guihua,lin license statement

[jan iversen]

Thanks for your license statement.

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

> 
> Hi!
> All of my past & future contributions to LibreOffice may be
> licensed under the MPLv2/LGPLv3+ dual license.
> 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Request for upload HSQLDB 2.3.3.zip on http://dev-www.libreoffice.org/src

[jan iversen]

> 
> Let's just drop all of Base in 6.0. Split it off into a separate project. 
> Databases is a big enough area to have its own application suites. We don't 
> include email, photo editing, music production, or electronic design 
> automation in the LibreOffice "suite" either, to mention a few areas that 
> would equally "naturally" and "usefully" fit in.

Dropping it sounds hard, we should replace it by a generic interface, allowing 
our code to do sql operations, and third party can instanciate the interface to 
their pet db.
> 
> (Just my personal opinion. I don't expect anybody to actually agree.)
Surprise, we are (at least) 2.

rgds
jan i.
> 
> --tml
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: <Burçin Akalın> license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

> On 17 Dec 2015, at 11:11, Burçin Akalın <brcnaka...@gmail.com> wrote:
> 
> All of my past & future contributions to LibreOffice may be licensed under
> the MPLv2/LGPLv3+ dual license.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fix paint table border in DOUBLE_THIN style

[jan iversen]

Job well done !!

your patch is now on master. What will you work on next ?

rgds
jan i

Sent from my iPad, please excuse any misspellings 

> On 14 Dec 2015, at 16:26, "flw.aquar...@gmail.com"  
> wrote:
> 
> Hi, All!
> I had push the commit to the gerrit.: 
> https://gerrit.libreoffice.org/#/c/20701/ 
> But it build failed in 'CppunitTest/libtest_writerperfect_stream.so': 
> http://ci.libreoffice.org/job/lo_gerrit_master/9226/
> It work well in my machine. Is anyone have a good idear to fix this bug ?
> Thanks!
> 
> 
> flw.aquar...@gmail.com
>  
> From: flw.aquar...@gmail.com
> Date: 2015-12-13 20:26
> To: libreoffice
> Subject: fix paint table border in DOUBLE_THIN style
> Hi, I find a bug in the master branch and fixed it. But i am in trouble when 
> i push the patch to the gerrit. It the waring fllow:
> 
> The authenticity of host '[gerrit.libreoffice.org]:29418 
> ([89.238.68.148]:29418)' can't be established.
> 
> So, i show the screenshot to show the bug and patch fllow:
> 
> screenshot:
> http://7xjcd4.com1.z0.glb.clouddn.com/bog_lo_bug_cell_double_thin_1.png
> 
> patch:
> From f7d4b14cccb20ea39a90fb68986fb5578c6fd9a2 Mon Sep 17 00:00:00 2001
> From: aqcoder 
> Date: Sun, 13 Dec 2015 19:11:28 +0800
> Subject: [PATCH] fix paint table border in DOUBLE_THIN style
> 
> it always paint partial table border which have line style of DOUBLE_THIN.
> Becouse the partial of the border line is out of the invalid window rect.
> so, we extend it.
> 
> Change-Id: I9d95ca71a96cfa869c68d9d2200f29c7cd447eca
> ---
>  sw/source/core/layout/paintfrm.cxx | 18 ++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/sw/source/core/layout/paintfrm.cxx 
> b/sw/source/core/layout/paintfrm.cxx
> index 83a8638..9746df7 100644
> --- a/sw/source/core/layout/paintfrm.cxx
> +++ b/sw/source/core/layout/paintfrm.cxx
> @@ -2742,6 +2742,24 @@ void SwTabFramePainter::PaintLines(OutputDevice& rDev, 
> const SwRect& rRect) cons
>  aPaintEnd.Y()   += static_cast(offsetEnd   + 0.5);
>  }
>  
> +if( rEntryStyle.Type() == table::BorderLineStyle::DOUBLE_THIN )
> +{
> +long aPixel = rDev.PixelToLogic( Point(1, 1) ).getX();
> +SwRect aPaintEx( aPaintStart, aPaintEnd );
> +if( bHori )
> +{
> +aPaintEx.Pos().Y() -= aPixel;
> +aPaintEx.SSize().Height() += aPixel * 2;
> +}
> +else
> +{
> +aPaintEx.Pos().X() -= aPixel;
> +aPaintEx.SSize().Width() += aPixel * 2;
> +}
> +
> +gProp.pSGlobalShell->InvalidateWindows( aPaintEx );
> +}
> +
>  if (bHori)
>  {
>  mrTabFrame.ProcessPrimitives( 
> svx::frame::CreateBorderPrimitives(
> -- 
> 2.5.0
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: Contributing to LibreOffice.

[jan iversen]

Just for information.

I have contacted (as earlier agreed) developers who have not been active for 
quite a while, with the mail below.

I am every month monitoring the rate of new people entering the project, 
compared to people who have not added patches for a while, and the relation is 
slowly improving. Bear in mind it is natural that volunteers come and go, 
depending on the time and energy they have available so this is not a measure 
if the project grows but simply a "change rate".

rgds
jan i.


Begin forwarded message:

> From: jan iversen <j...@documentfoundation.org>
> Date: 16 December 2015 at 11:26:13 GMT+1
> To: j...@documentfoundation.org
> Subject: Contributing to LibreOffice.
> 
> Hi
> 
> Sorry for intruding on your mailbox. I am the development mentoring lead in 
> the document foundation (LibreOffice), which means it is my job to find out 
> how to make the community better, especially for new people.
> 
> I noticed it has been a while since you have contributed (I am sorry if I 
> overlooked something) therefore I would like to ask you a couple of questions.
> 
> It is totally free whether or not you want to answer the questions. I might 
> poke you again in a bit just in case, but promise not to nag you beyond that.
> 
> a) Is there a specific reason why you have not contributed in a while?
> 
> b) can you suggest anything we should have or can do better?
> 
> c) Did you feel welcome and helped in the community ?
> 
> d) Is there anything we can do, to motivate you again (remembering it is my 
> job to help people getting started) ?
> 
> 
> THANKS a lot for taking time to answer and thereby help us. I hope to see you 
> contributing again in the future.
> 
> merry christmas
> jan i.
> Development mentoring lead, LibreOffice.
> 
> 
> 
> Sent from my iPad, please excuse any misspellings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build error on branch libreoffice-5-0-4

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 04 Jan 2016, at 04:58, Chris Sherlock  wrote:
> 
> I’ve done a quick check of the cygwin documentation, and they say the 
> following:
> 
>"A few Windows tools, such as find.exe, link.exe andsort.exe, may conflict 
> with the Cygwin versions make sure that you use the full path 
> (/usr/bin/find) 
> or that your Cygwin bin directory comes first in your PATH." [1]
> 
> 1. https://cygwin.com/cygwin-ug-net/using-effectively.html
> 
> I’m afraid I’m not at all experienced with the whole gbuild process, and I 
> honestly
> dare not touch this because of that complete lack of knowledge - but can 
> someone
> check that we are actually doing this on Windows builds?

I can confirm that you can have different problems if cygwin/bin is added to 
PATH after some of the windows directories.

I had the problem on one vm, and it went away when I installed a new windows 
package, simply because the PATH statement changed.

Changing the PATH is not really part of the build system, it is something you 
normally do in the control panel or in the .bashrc (more effectively because it 
only affects cygwin).

rgds
jan i.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: vcl/null folder

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 04 Jan 2016, at 06:13, Chris Sherlock  wrote:
> 
> Hi all, 
> 
> There is a folder vcl/null - what is this intended for? There seems to be one 
> file in there added in 2011, it was apparently experimental at the time but 
> seems to have now been incorporated into the core code. 
> 
> If this is no longer experimental, could we move this into a better folder 
> than the “null” folder?

It sounds like a good idea to move it to vcl/generic.

rgds
jan i
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Gerrit patches from new people.

[jan iversen]

Hi

We have a long queue of pending gerrit patches, and it is especially important 
that new people get responses relative fast.

If you have a bit of time to review patches, please consider using
https://gerrit.libreoffice.org/#/q/status:open+-ownerin:committer

That shows all pending patches from non-committers.

thanks in advance for helping out.
rgds
jan i.


Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Contributing to LibreOffice

[jan iversen]

Welcome

We have a lot of challenges in the languages you know. Your first step however 
is to get Libreoffice build in your environment, so you can test your patches.

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

> On 01 Jan 2016, at 17:34, Akash B <akash.basab...@gmail.com> wrote:
> 
> Hi all,
> I'm interested in contribution to LibreOffice. I'm comfortable with 
> C++, C++11, Python and Java. I'd like some guidance as to how to contribute 
> to LibreOffice.
> 
> Regards,
> Akash PB
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Formatting _Numbering/ordered list_[Bug 42788]

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 30 Dec 2015, at 05:53, noseeba Al kindi  wrote:
> 
> Thanks for your reply,
> I changed the numbering alignment to the right and I increase the
> indentation but it affect all numbering list not only the Roman
> numbers.
> could you help me
> where should I look to correct the style and make it default for Roman
> numbers only

You changed the default, so I assume that is the reason it affects all 
numbering lists.

I am not sure it can be done for a specific font, but hopefully someone more 
experienced can help with that.

rgds
jan i.

> 
> regards
> Nusaiba
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Possible easy hack

[jan iversen]

Hi

> The bug is Bug 77667 - Remove gcc3 workaround where it could handle 
> instantiated objects as parameters (found here: 
> https://bugs.documentfoundation.org/show_bug.cgi?id=77667)

I think you are right, that looks like a easyhack to me.

All you have to do is to add keywords to the bug see
https://bugs.documentfoundation.org/show_bug.cgi?id=54169
for a C++ example.

have a nice day.
rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Dipankar Niranjan license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

> On 01 Jan 2016, at 19:27, Dipankar Niranjan <dipankar1...@gmail.com> wrote:
> 
> All of my past & future contributions to LibreOffice may be licensed under 
> the MPLv2/LGPLv3+ dual license
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [SOLVED] Calc code pointer appreciated

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 29 Dec 2015, at 07:25, Winfried Donkers  
> wrote:
> 
> Found it, sc/source/core/data/table4.cxx, ScTable::FillAnalyse().

Super if you need more help with e.g. setup of gerrit etc, please feel free to 
email me directly.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Strange error when compiling LibreOffice from master

[jan iversen]

Hi

I just installed a new ubuntu 14.10 today, and compiled LO without problems.

Could it be you are running with an old GCC (pointer to doc 4.9 suggest that).

Or alternatively you need to do a "git pull" to get the latest commits.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Susobhan Ghosh license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Yogesh Desai license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: pasqual milvaques license statement

[jan iversen]

> 
> Basically you submit a patch set of an amended commit with the same
> Change-Id, which replaces the previous patch set of the same gerrit
> change, see
> https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_a_new_version
> and
> https://wiki.documentfoundation.org/Development/GitReview#Amending_a_gerrit_change
> depending on which workflow, ./logerrit (or git push) or git-review, you use

just to avoid confusion, Pasqual has 2 merged patches (dec. 18 and dec. 28).

And we look forward to see more.
rgds
jan i
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Arul Michael license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: kumar thangavel license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: virus detection with GData

[jan iversen]

> 
> none of these files actually contains a virus, they just have malformed
> content that tend to trigger anti-virus heuristics.
> 
OK I stand corrected, but my proposal is the same, because it still informs 
people, that this is not something to worry about.

rgds
jan i.


> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: virus detection with GData

[jan iversen]

> the CVE-* files in the same directory are all encrypted with some dummy
> password, so that virus scanners don't complain about them.
> 
> vcl/qa/cppunit/graphicfilter/data/README
> 
> i've taken the liberty to encrypt these now on master with
> 18b0343010517daa1eaf52a17ef19564076e1f3a, so you should only get virus
> warnings when the tests are actually running (because the files will be
> written unencrypted to temporary files), which can be avoided with
> --disable-cve-tests.

Can I suggest we name files, that contain virus especially (like CVE-* and 
VIRUS-*) so that it is obvious that the file contains a "wanted" virus.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Hi! New to LibreOfiice

[jan iversen]

Welcome to libreoffice.

I hope you will have a lot of fun being part of our community.

I am helping new people get started, because Libreoffice is quite a big 
program, so it is easy to get confused.

Feel free to write me directly, so I can help you. 

The first thing you need to do is to get LO build on your platform (which is?) 
and then you need to setup gerrit in order to submit patches.

We have a lot of easy tasks for new people, to make it easy to get started.

Have you looked at our wiki ?

looking forward to see your mail.
rgds
jan i.


Sent from my iPad, please excuse any misspellings 

> On 05 Jan 2016, at 13:43, shubham tibra  wrote:
> 
> Hello,
> 
> I would really like to contribute in LibreOffice, but I am new to open source 
> community.
> I can code in C, C++ and I also know little python too.
> 
> Can someone help me get started?
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSOC Android App LibreOffice Viewer

[jan iversen]

 Welcome.


Please do not for  your license statement and to get gerrit setup.
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

I am not a specialist in the android viewer, but it is a place where a lot of 
work can be done.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Johannes Hauf license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings

Sent from my iPad, please excuse any misspellings 

> On 31 Dec 2015, at 17:14, Johannes Hauf <hauf.johan...@gmail.com> wrote:
> 
> All of my past & future contributions to LibreOffice may be
>licensed under the MPLv2/LGPLv3+ dual license.
> 
> Best regards ... Johannes
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Srishti Khatri license statement

[jan iversen]

welcome

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: about using test files in our unit tests

[jan iversen]

Hi

There are no guarantees, but I think that
http://ci.libreoffice.org/job/lo_gerrit_master/10073/

might be another one. The patch was rebased this morning before starting the
build.

rgds
jan i.



--
View this message in context: 
http://nabble.documentfoundation.org/about-using-test-files-in-our-unit-tests-tp4170853p4171166.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Automation Test for LibreOffice

[jan iversen]

Hi

I am a little bit confused as to what tests you refer. Currently you are 
converting the automated java unit scripts to python.

What did I miss ?

rgds
jan i.



Sent from my iPad, please excuse any misspellings 

> On 17 Dec 2015, at 21:03, Kader Tarlan  wrote:
> 
> Hi Sir,
> I'm curious about Automation Testing. Is there any news about this topic? 
> Still I can't access to the code.
> I want to work with a mentor to start . Is  there any mentor who can help me 
> about this topic?
> 
> Best,
> Kader.
> 
> 2015-12-06 1:56 GMT+02:00 Thorsten Behrens :
>> Michael Meeks wrote:
>> >   I was wondering what state your nice re-work of a dogtail-alike thing
>> > to python vs. the UNO a11y API is; is the code somewhere ? potentially
>> > JanI could help mentor Karlan for the first few tests.
>> >
>> Failing that - the Selenium approach is rather interesting,
>> i.e. getting a LibreOffice backend up for it...
>> 
>> Cheers,
>> 
>> -- Thorsten
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/source cui/uiconfig

[jan iversen]

 cui/source/options/optbasic.cxx|   11 -
 cui/source/options/optbasic.hxx|2 -
 cui/uiconfig/ui/optbasicidepage.ui |   70 -
 3 files changed, 53 insertions(+), 30 deletions(-)

New commits:
commit df862448b7400c0d7406afa0540c52c00632b62f
Author: jan iversen <j...@documentfoundation.org>
Date:   Thu Dec 24 14:47:22 2015 +

Revert "Basic IDE Options code completion tweak."

This reverts commit 536fcf91de1bdbfca4c300484ebe672f9cbca0e7.

Based on a IRC discussion, it seems that a comment is enough to block a 
patch, and not as defined a -1.

Furthermore this patch caused a core dump on the munich tinderbox, where 
the cause is very unclear.

Change-Id: I0caeeb35b33942ea08e056d26ead97264d74
Reviewed-on: https://gerrit.libreoffice.org/20924
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>

diff --git a/cui/source/options/optbasic.cxx b/cui/source/options/optbasic.cxx
index 5ee33b3..3feb235a 100644
--- a/cui/source/options/optbasic.cxx
+++ b/cui/source/options/optbasic.cxx
@@ -75,8 +75,6 @@ void SvxBasicIDEOptionsPage::LoadConfig()
 pAutocloseParenChk->Check( bParenClose );
 pAutoCorrectChk->Check( bCorrect );
 pUseExtendedTypesChk->Check( bExtended );
-pUseExtendedTypesChk->SetToggleHdl( LINK( this, SvxBasicIDEOptionsPage, 
EnableExtType ) );
-pCodeCompleteChk->Enable(pUseExtendedTypesChk->IsChecked());
 }
 
 bool SvxBasicIDEOptionsPage::FillItemSet( SfxItemSet* /*rCoreSet*/ )
@@ -160,13 +158,4 @@ void SvxBasicIDEOptionsPage::FillUserData()
 SetUserData( aUserData );
 }
 
-IMPL_LINK_NOARG_TYPED(SvxBasicIDEOptionsPage, EnableExtType, CheckBox&, void)
-{
-bool bEnable = pUseExtendedTypesChk->IsChecked();
-pCodeCompleteChk->Enable(bEnable);
-if (!pUseExtendedTypesChk->IsChecked())
-{
-pCodeCompleteChk->Check(false);
-}
-}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/optbasic.hxx b/cui/source/options/optbasic.hxx
index 918501c..3d33518 100644
--- a/cui/source/options/optbasic.hxx
+++ b/cui/source/options/optbasic.hxx
@@ -35,8 +35,6 @@ private:
 VclPtr pUseExtendedTypesChk;
 
 void LoadConfig();
-DECL_LINK_TYPED(EnableExtType, CheckBox&, void );
-
 
 public:
 SvxBasicIDEOptionsPage( vcl::Window* pParent, const SfxItemSet& rSet );
diff --git a/cui/uiconfig/ui/optbasicidepage.ui 
b/cui/uiconfig/ui/optbasicidepage.ui
index 5516d90..90ea4c8 100644
--- a/cui/uiconfig/ui/optbasicidepage.ui
+++ b/cui/uiconfig/ui/optbasicidepage.ui
@@ -9,6 +9,57 @@
 vertical
 12
 
+  
+True
+False
+0
+none
+
+  
+True
+False
+6
+12
+
+  
+True
+False
+
+  
+Enable code 
completion
+True
+True
+False
+0
+True
+  
+  
+0
+0
+  
+
+  
+
+  
+
+
+  
+True
+False
+Code 
Completion
+
+  
+
+  
+
+  
+  
+False
+True
+0
+  
+
+
   
 True
 False
@@ -100,7 +151,7 @@
   
 False
 True
-0
+1
   
 
 
@@ -134,21 +185,6 @@
 0
   
 
-
-  
-Enable code 
completion
-True
-True
-False
-25
-0
-True
-  
-  
-0
-1
-  
-
   
 
   
@@ -167,7 +203,7 @@
   
 False
 True
-1
+2
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

[jan iversen]

 dev/null |binary
 sw/qa/extras/inc/swmodeltestbase.hxx |   14 --
 sw/qa/extras/odfexport/odfexport.cxx |   11 ---
 sw/source/filter/xml/xmltble.cxx |   26 +-
 4 files changed, 1 insertion(+), 50 deletions(-)

New commits:
commit da5d3f0fc8edc38f3830644aee0507c7675b37b3
Author: jan iversen <j...@documentfoundation.org>
Date:   Fri Dec 25 12:53:34 2015 +

Revert "tdf#96412 Fix export text table cell UserDefinedAttributes to xml."

This reverts commit d3e57ccf2e56a75bd4f004de53793f1742e34bc4.

There is a problem with the test case, that breaks 2 tinderboxes.

A simple test, detected more errors, open the document in LO 5.0.x and save 
it, then the test case has a problem on all platforms.

Change-Id: If4d6a62ed5e7882e6e61e7d31ca0a29094df103c
Reviewed-on: https://gerrit.libreoffice.org/20935
    Reviewed-by: jan iversen <j...@documentfoundation.org>
Tested-by: jan iversen <j...@documentfoundation.org>

diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx 
b/sw/qa/extras/inc/swmodeltestbase.hxx
index dc977f1..ce02b3e 100644
--- a/sw/qa/extras/inc/swmodeltestbase.hxx
+++ b/sw/qa/extras/inc/swmodeltestbase.hxx
@@ -11,7 +11,6 @@
 #define INCLUDED_SW_QA_EXTRAS_INC_SWMODELTESTBASE_HXX
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -29,7 +28,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -435,18 +433,6 @@ protected:
 return properties->getPropertySetInfo()->hasPropertyByName(name);
 }
 
-xml::AttributeData getUserDefineAttribute(const uno::Any& obj, const 
OUString& name, const OUString& rValue = OUString()) const
-{
-uno::Reference 
attrsCnt(getProperty(obj, "UserDefinedAttributes"), 
uno::UNO_QUERY_THROW);
-
-xml::AttributeData aValue;
-attrsCnt->getByName(name) >>= aValue;
-if (!rValue.isEmpty())
-CPPUNIT_ASSERT_EQUAL_MESSAGE("attribtes of cell does not contain 
expected value", rValue, aValue.Value);
-
-return aValue;
-}
-
 /// Get number of paragraphs of the document.
 int getParagraphs()
 {
diff --git a/sw/qa/extras/odfexport/data/userdefattr-tablecell.odt 
b/sw/qa/extras/odfexport/data/userdefattr-tablecell.odt
deleted file mode 100644
index c8f6dcc..000
Binary files a/sw/qa/extras/odfexport/data/userdefattr-tablecell.odt and 
/dev/null differ
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index 1226228..addf9c5 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -770,17 +770,6 @@ DECLARE_ODFEXPORT_TEST(testOdtBorderTypes, 
"border_types.odt")
 } while (xParaEnum->hasMoreElements());
 }
 
-DECLARE_ODFEXPORT_TEST(testCellUserDefineAttr, "userdefattr-tablecell.odt")
-{
-uno::Reference xTable(getParagraphOrTable(0), 
uno::UNO_QUERY);
-uno::Reference const xCellA1(xTable->getCellByName("A1"), 
uno::UNO_SET_THROW);
-uno::Reference const xCellB1(xTable->getCellByName("B1"), 
uno::UNO_SET_THROW);
-uno::Reference const xCellC1(xTable->getCellByName("C1"), 
uno::UNO_SET_THROW);
-getUserDefineAttribute(uno::makeAny(xCellA1), "proName", "v1");
-getUserDefineAttribute(uno::makeAny(xCellB1), "proName", "v2");
-getUserDefineAttribute(uno::makeAny(xCellC1), "proName", "v3");
-}
-
 #endif
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/filter/xml/xmltble.cxx b/sw/source/filter/xml/xmltble.cxx
index 6b891a3..227ea83 100644
--- a/sw/source/filter/xml/xmltble.cxx
+++ b/sw/source/filter/xml/xmltble.cxx
@@ -29,7 +29,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -313,7 +312,6 @@ bool SwXMLTableFrameFormatsSort_Impl::AddCell( 
SwFrameFormat& rFrameFormat,
 const SvxBoxItem *pBox = nullptr;
 const SwTableBoxNumFormat *pNumFormat = nullptr;
 const SvxFrameDirectionItem *pFrameDir = nullptr;
-const SvXMLAttrContainerItem *pAttCnt = nullptr;
 
 const SfxItemSet& rItemSet = rFrameFormat.GetAttrSet();
 const SfxPoolItem *pItem;
@@ -333,12 +331,9 @@ bool SwXMLTableFrameFormatsSort_Impl::AddCell( 
SwFrameFormat& rFrameFormat,
 if ( SfxItemState::SET == rItemSet.GetItemState( RES_FRAMEDIR,
 false,  ) )
 pFrameDir = static_cast(pItem);
-if ( SfxItemState::SET == rItemSet.GetItemState( RES_UNKNOWNATR_CONTAINER,
-false,  ) )
-pAttCnt = static_cast(pItem);
 
 // empty styles have not to be exported
-if( !pVertOrient && !pBrush && !pBox && !pNumFormat && !pFrameDir && 
!pAttCnt )
+if( !pVertOrient && !pBrush && !pBo

Re: Automation Test for LibreOffice

[jan iversen]

> On 25 Dec 2015, at 19:26, Kader Tarlan  wrote:
> 
> Hi Jan,
> No, you've got that right. But I want to do more work in this area. I heard 
> that for this Matthew has made improvements in this area with Dogtail. Then 
> the idea of selenium  occurred here that on the mailing list. I want to add 
> more tests using dogtail or selenium with a mentor. but I can't see the codes 
> that is created with dogtail. I don't know where is the code.
> 
The reason you do not see it, is because it is not made it is currently (as far 
as I can judge) in the design stade. At least I cannot find anything in our 
repos, or gerrit issues.

Considering the responses on the other thread I do not think it is being 
developed very actively.

BUT that is a chance to be a doer, and come with suggestions.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Formatting _Numbering/ordered list_[Bug 42788]

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 23 Dec 2015, at 11:25, noseeba Al kindi  wrote:
> 
> I am solving this bug:
> 
> https://bugs.documentfoundation.org/show_bug.cgi?id=42788
> 
> I checked the MS office and it have the same problem appear there just
> that they have a longer indentation which let the issue start at
> number 18. Moreover, they make the numbering alignment to the right by
> default.
> 
> so I think the best behavior is to change the default setting to be:
> numbering alignment to the right and increase the indentation.

That sounds like the correct choise.

Btw, if you need help or have questions then do not hesitate to email me. I am 
trying to help new people getting their first patch successfully merged.

rgds
jan i.

> 
>> On Tue, Dec 22, 2015 at 12:03 PM, noseeba Al kindi  
>> wrote:
>> Dear,
>> 
>> I am new on solving bugs and this is the first bug I choose. I go
>> through the documentation of this issue and I found that it could be
>> solved by changing numbering alignment to the right. Another solution
>> is that when the length of the Roman number is longer than the
>> indentation, the whole list should be shift to right which give enough
>> space to contains the longest Roman number appear in the list.
>> 
>> I am not sure what is the right behavior here.
>> I am waiting for your reply.
>> Thank you
>> 
>> Nusaiba Al-kindi
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Guillaume Smaha license statement

[jan iversen]

Hi

Thanks for your license statement.

It is my job to help new people getting their first patch submitted and 
accepted, so please email me if there is anything I can help you with.

I am currently helping a couple of people, getting LO build and setting up the 
different tools you need to work, I would be happy to put you in contact with 
them.

Feel free to  email me directly offlist.

have a nice day
rgds
jan i.

Sent from my iPad, please excuse any misspellings 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: xmerge/source

[jan iversen]

 xmerge/source/bridge/java/XMergeBridge.java |  210 +---
 1 file changed, 102 insertions(+), 108 deletions(-)

New commits:
commit 03c37cee476d14d1d8644ccc7ea5c69d74d9c7f9
Author: jan iversen <j...@documentfoundation.org>
Date:   Thu Nov 5 15:19:56 2015 +0100

CID#1326472, CID#1326473, CID#1326474 use try/finalize

Coverity requires that closeable objects (use of new) call .close(),

git commit 5a29db7a9945c4cd095799451a6c563d5aeeed57
implemented a series of .close etc calls, update to
use a single try{}finalize{} instead.

Change-Id: Iadc9de13d6a0af4b0aaca2dfdd0e2d0940a5223d
Reviewed-on: https://gerrit.libreoffice.org/19807
Reviewed-by: Markus Mohrhard <markus.mohrh...@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrh...@googlemail.com>

diff --git a/xmerge/source/bridge/java/XMergeBridge.java 
b/xmerge/source/bridge/java/XMergeBridge.java
index 391232c..bbe3e2a 100644
--- a/xmerge/source/bridge/java/XMergeBridge.java
+++ b/xmerge/source/bridge/java/XMergeBridge.java
@@ -375,136 +375,130 @@ public class XMergeBridge {
 XInputStreamToInputStreamAdapter xis =new 
XInputStreamToInputStreamAdapter(xml);
 
 XOutputStreamToOutputStreamAdapter newxos =new 
XOutputStreamToOutputStreamAdapter(device);
-try{
-ConverterInfoReader cir = new 
ConverterInfoReader(jarName,false);
-ciEnum =cir.getConverterInfoEnumeration();
-}
-catch (ParserConfigurationException pexc){
-System.out.println("Error:"+pexc);
-}
-catch ( org.xml.sax.SAXException pexc){
-System.out.println("Error:"+pexc);
-}
-catch(Exception e){
-System.out.println("Error:"+e);
-}
-ConverterInfoMgr. removeByJar(jarName);
-if (convertFromOffice)
-{
-
-try {
-
-//Check to see if jar contains a plugin Impl
-
-ConverterInfoMgr.addPlugIn(ciEnum);
-ConverterFactory cf = new ConverterFactory();
-
-Convert cv = 
cf.getConverter(ConverterInfoMgr.findConverterInfo(sdMime,offMime),false);
-if (cv == null) {
-System.out.println("\nNo plug-in exists to convert 
from  to  ");
 
-}
-else
-{
-cv.addInputStream(name,xis,false);
-ConvertData dataOut = cv.convert();
+/* make sure newxos and xis get closed */
+try{
+try{
+ConverterInfoReader cir = new 
ConverterInfoReader(jarName,false);
+ciEnum =cir.getConverterInfoEnumeration();
+}
+catch (ParserConfigurationException pexc){
+System.out.println("Error:"+pexc);
+}
+catch ( org.xml.sax.SAXException pexc){
+System.out.println("Error:"+pexc);
+}
+catch(Exception e){
+System.out.println("Error:"+e);
+}
+ConverterInfoMgr. removeByJar(jarName);
+if (convertFromOffice)
+{
 
-Iterator docEnum = 
dataOut.getDocumentEnumeration();
+try {
 
-if (docEnum.hasNext()){
-Document docOut  = (Document)docEnum.next();
-docOut.write(newxos);
+//Check to see if jar contains a plugin Impl
 
-newxos.flush();
-newxos.close();
+ConverterInfoMgr.addPlugIn(ciEnum);
+ConverterFactory cf = new ConverterFactory();
 
-int i=1;
-while (docEnum.hasNext() && 
sURL.startsWith("file:")) {
+Convert cv = 
cf.getConverter(ConverterInfoMgr.findConverterInfo(sdMime,offMime),false);
+if (cv == null) {
+System.out.println("\nNo plug-in exists to convert 
from  to  ");
 
-URI uri=new URI(sURL);
-String  newFileName= getPath(uri);
+}
+else
+{
+cv.addInputStream(name,xis,false);
+ConvertData dataOut = cv.convert();
+
+Iterator docEnum = 
dataOut.getDocumentEnumeration();
+
+if (docEnum.hasNext()){
+Document docOut  = 
(Document)do

Confused about make.

[jan iversen]

Hi.

Can someone please tell what is the difference between:
"make test" and
"make check"

I could not find a description of the make options in our wiki (maybe they are 
just hidden).

Thanks in advance
jan i.


Sent from my iPad, please excuse any misspellings 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Confused about make.

[jan iversen]

Thanks and sorry for a stupid question, but sometimes you cannot the wood 
because of all the trees :-)

Rgds
jan i.

Sent from my iPad, please excuse any misspellings 

> On 28 Nov 2015, at 10:57, Andras Timar <tima...@gmail.com> wrote:
> 
> On Sat, Nov 28, 2015 at 10:26 AM, jan iversen
> <j...@documentfoundation.org> wrote:
>> Can someone please tell what is the difference between:
>> "make test" and
>> "make check"
>> 
>> I could not find a description of the make options in our wiki (maybe they 
>> are just hidden).
> 
> "test" is a toplevel module in LibreOffice source tree. Its README
> says it is a test harness code for C++ unit testing. "make test"
> builds this toplevel module. "make check" will first do a full build,
> then run all the subsequent tests.
> 
> Regards,
> Andras
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Nicola Povoleri license statement

[jan iversen]

Hi.

Thanks a lot for your license statement.

If you need help getting started please let me know, feel free to mail me 
directly.

rgds
jan i

Sent from my iPad, please excuse any misspellings 

> On 28 Nov 2015, at 17:05, nicola.povoleri  
> wrote:
> 
>All of my past & future contributions to LibreOffice may be
>licensed under the MPLv2/LGPLv3+ dual license.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ozcan license statement

[jan iversen]

Hi 

thanks for your license statement. Let me know if I can help you getting 
started. 

Getting your first patch submitted can be a learning curve, and I am here to 
help you so feel free to mail me directly if you want to.

welcome
rgds
jan i.


Sent from my iPad, please excuse any misspellings 

> On 28 Nov 2015, at 19:16, Özcan Esen  wrote:
> 
> All of my past & future contributions to LibreOffice may be licensed under 
> the MPLv2/LGPLv3+ dual license.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: patch

[jan iversen]

Thanks for your license statement.

I see you are already on our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: faruk license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

I you want help to get started or have any questions, then please contact me. I 
am here to help you (and others) getting their first patch submitted.

LibreOffice is a very big program and getting it build, setting up gerrit, and 
getting the first patch right, can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: bin/gbuild-to-ide

[jan iversen]

 bin/gbuild-to-ide |  121 +-
 1 file changed, 83 insertions(+), 38 deletions(-)

New commits:
commit 02b411818b79154bd41f1654e23c2422170e3629
Author: jan iversen <j...@documentfoundation.org>
Date:   Sat Nov 28 11:08:05 2015 +0100

gbuild-to-ide split state machine

Catching the needed information and the state machine is split.
gbuild-to-ide only finds 27 of 93 exe, due to the state machine
sequence:
 CXXOBJECTS for exe1
 CXXOBJECTS for exe2
 Recipe to execute for exe2
 Recipe to execute for exe1
only identifies exe2 and leaves exe1 without a project.

Solution is to have an array of state one for all pending exe.

This patch only contains the split

Change-Id: I2539f10a9850d956a85b6993b26561b1970575df
Reviewed-on: https://gerrit.libreoffice.org/20254
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michael...@canonical.com>

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 8b08380..1df534f 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -113,7 +113,7 @@ class GbuildParser:
 mapping_dict[target] = library
 return mapping_dict
 
-def _parse_hash(self, line, state):
+def _parse_hash_old(self, line, state):
 libmatch = GbuildParser.libpattern.match(line)
 if libmatch:
 libname = self.libnames.get(state.ilib, None)
@@ -169,55 +169,100 @@ class GbuildParser:
 # we could match a lot of other stuff here if needed for integration 
rpaths etc.
 return state
 
+def _parse_hash(self, line):
+libmatch = GbuildParser.libpattern.match(line)
+if libmatch:
+return True
+exematch = GbuildParser.exepattern.match(line)
+if exematch:
+return True
+if line.find('# INCLUDE :=') == 0:
+return True
+defsmatch = GbuildParser.defspattern.match(line)
+if defsmatch:
+return True
+cxxmatch = GbuildParser.cxxpattern.match(line)
+if cxxmatch:
+return True
+linkedlibsmatch = GbuildParser.linkedlibspattern.match(line)
+if linkedlibsmatch:
+return True
+ilibmatch = GbuildParser.ilibpattern.match(line)
+if ilibmatch:
+return True
+if line.find('# T_CXXFLAGS :=') == 0:
+return True
+# we could match a lot of other stuff here if needed for integration 
rpaths etc.
+return False
+
+def _parse_without_hash(self, line):
+makecmdmatch = GbuildParser.makecmdpattern.match(line)
+if makecmdmatch:
+self.makecmd = makecmdmatch.group(1)
+# FIXME: Hack
+if self.makecmd == 'make':
+self.makecmd = '/usr/bin/make'
+return False
+srcdirmatch = GbuildParser.srcdirpattern.match(line)
+if srcdirmatch:
+self.srcdir = srcdirmatch.group(1)
+return False
+builddirmatch = GbuildParser.builddirpattern.match(line)
+if builddirmatch:
+self.builddir = builddirmatch.group(1)
+return False
+instdirmatch = GbuildParser.instdirpattern.match(line)
+if instdirmatch:
+self.instdir = instdirmatch.group(1)
+return False
+binpathmatch = GbuildParser.binpathpattern.match(line)
+if binpathmatch:
+self.binpath = binpathmatch.group(1)
+return False
+libnamesmatch = GbuildParser.libnamespattern.match(line)
+if libnamesmatch:
+self.libnames = self.__mapping_to_dict(libnamesmatch.group(1))
+return False
+exenamesmatch = GbuildParser.exenamepattern.match(line)
+if exenamesmatch:
+self.exenames = self.__mapping_to_dict(exenamesmatch.group(1))
+return False
+rulematch = self.rulepattern.match(line)
+if rulematch:
+return True
+
 def parse(self, gbuildstate):
-state = GbuildParserState()
+workLines = []
+stateActive = False
 for line in gbuildstate:
 line = line.rstrip('\r\n')
 if line.startswith('#'):
-state = self._parse_hash(line, state)
+if self._parse_hash(line):
+stateActive = True
+workLines.append(line)
+else:
+if self._parse_without_hash(line):
+workLines.append(line)
+elif stateActive:
+workLines.append('!END OF STATE')
+
+state = GbuildParserState()
+for line in workLines:
+if line.startswith('!END OF STATE'):
+state = GbuildParserState()
+continue
+if line.startswith('#'):
+state = self._parse_hash_old(line, state)

[Libreoffice-commits] core.git: configure.ac

[jan iversen]

 configure.ac |4 
 1 file changed, 4 insertions(+)

New commits:
commit 75892872496175d71b4ad02c1a477dc9f463d803
Author: jan iversen <j...@documentfoundation.org>
Date:   Sat Nov 28 14:12:17 2015 +0100

check for missing COMSPEC variable in cygwin.

Cygwin unsets the COMSPEC environment variable on some installations.
This is due to an error reported first time in 2005, but not solved.
There are no exact pattern when this happens, in this case it happened
on 2 windows 8.1 VM installations (one private one azure).

added check in configure.ac to alert the user earlier

COMSPEC is used in sal/osl to start processes and as such vital, and in
some perl scripts, therefore hardcoding to e.g. cmd32.exe (or the power
shell) is not an option.

Limited check to work only for cygwin.

Change-Id: I52bb6667c52560ed1a239ac301811605b8cddcbf
Reviewed-on: https://gerrit.libreoffice.org/20255
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Meeks <michael.me...@collabora.com>
Tested-by: Michael Meeks <michael.me...@collabora.com>

diff --git a/configure.ac b/configure.ac
index 71f2037..9a13921 100644
--- a/configure.ac
+++ b/configure.ac
@@ -282,6 +282,10 @@ if test "$build_os" = "cygwin"; then
 PathFormat "$BUILDDIR"
 BUILDDIR="$formatted_path"
 x_Cygwin=
+AC_MSG_CHECKING(for explicit COMSPEC)
+if test -z "$COMSPEC"; then
+AC_MSG_ERROR([COMSPEC not set in Environment, please set it an rerun])
+fi
 fi
 
 AC_SUBST(SRC_ROOT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Bug 45904] move java based api tests to c++

[jan iversen]

Hi.

Yes this is ongoing work.

I am here to help new people getting their first patch successfully
implemented, so feel free to mail me directly if you have questions.

The first thing you need to do is to get build on your machine:
for linux (and similar) environments:
https://wiki.documentfoundation.org/Development/BuildingOnLinux
for windows:
https://wiki.documentfoundation.org/Development/lode

if you mail me a bit about your setup, and your experience I can guide you
(of course only if you like to).

you might also want to look at
https://wiki.documentfoundation.org/Development/Easy_Hacks
these are problems, experienced developers have looked at, and are a good
start for a first patch.

Looking forward to hear from you.
rgds
jan i.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: license statement

[jan iversen]

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Buildbot for Android

[jan iversen]

> On 12 Jan 2016, at 02:26, Chris Sherlock  wrote:
> 
> Is it feasible to have an Android buildbot?

With all the changes going on, I think it is a good idea. Making the android 
version, does not compile large parts of the code, so it should not be a heavy 
task for a vm. Should it turn out to be a heavy task, we can surely do some 
script filtering on the jenkins slave, and reduce non-android relevant jobs to 
consume a min.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: initialize new member variables

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 12 Jan 2016, at 12:05, Chris Sherlock  wrote:
> 
> Hi all,
> 
> Unfortunately that was the case - I definitely went down the wrong path with 
> that merge.
> 
> I've reverted it now - the commit can be found on 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b4b0cc2a5eef4243e51fda4a13fc48183aa0
> 
> I need to check that UBSan tool more regularly.
> 
> But I definitely have to put my hand up for causing these errors. Apologies 
> for this, I will do my level best not to let this occur again.
> 
> When I'm back home I've been meaning to send a post to the list summarising 
> how font handling works and some ideas and questions around the code.
Even better would be to make a wiki page :-)

rgds
jan i
> 
> Thanks all (especially Caolon and Stephan)!
> 
> Chris
> 
>>> On 12 Jan 2016, at 7:20 PM, Stephan Bergmann  wrote:
>>> 
>>> On 01/11/2016 06:29 PM, Caolán McNamara wrote:
>>> commit c93a43c0c9113bc1c787fe6b3c5e58a8bfd80be0
>>> Author: Caolán McNamara 
>>> Date:   Mon Jan 11 17:08:39 2016 +
>>> 
>>>initialize new member variables
>>> 
>>>Change-Id: I3839bc134b337ccb7cfdb2ee70524e4721c8f83c
>>> 
>>> diff --git a/vcl/source/font/fontattributes.cxx 
>>> b/vcl/source/font/fontattributes.cxx
>>> index be3ab68..49060f0 100644
>>> --- a/vcl/source/font/fontattributes.cxx
>>> +++ b/vcl/source/font/fontattributes.cxx
>>> @@ -93,7 +93,18 @@ bool 
>>> FontAttributes::CompareDeviceIndependentFontAttributes(const FontAttributes
>>> }
>>> 
>>> FontAttributes::FontAttributes()
>>> -: mnWidth ( 0 )
>>> +: meWeight(WEIGHT_DONTKNOW)
>>> +, meItalic(ITALIC_DONTKNOW)
>>> +, meFamily(FAMILY_DONTKNOW)
>>> +, mePitch(PITCH_DONTKNOW)
>>> +, meWidthType(WIDTH_DONTKNOW)
>>> +, mbSymbolFlag(false)
>>> +, mnQuality(0)
>>> +, mbOrientation(false)
>>> +, mbDevice(false)
>>> +, mbSubsettable(false)
>>> +, mbEmbeddable(false)
>>> +, mnWidth ( 0 )
>>> , mnOrientation( 0 )
>>> , mnAscent( 0 )
>>> , mnDescent( 0 )
>> [...]
>> 
>> Tools like UBSan or Valgrind's memcheck started to complain about reads of 
>> uninitialized members after a series of commits that merged font-related 
>> structs in VCL together.  What looked fishy is that those members had not 
>> been default-initialized in the original structs, the number of setter calls 
>> had not changed, and yet the code started to grow uninitialized reads of the 
>> members.  Without a clear understanding of what was going on, we were 
>> reluctant to blindly default-initialize those members now, as it might hide 
>> problems (at least from the eyes of UBSan and Valgrind) instead of fixing 
>> them.
>> 
>> Now, as I understand, Chris is going to revert those merges, as he came to 
>> the conclusion that they went in the wrong direction after all, and I assume 
>> that will obsolete the above potentially problematic commit anyway.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: officecfg/registry oox/source sd/qa sd/source sd/xml slideshow/source

[jan iversen]

 officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu |   33 ---
 oox/source/ppt/slidetransition.cxx   |   11 ---
 oox/source/ppt/slidetransitioncontext.cxx|7 --
 sd/qa/unit/data/AllTransitions.odp   |binary
 sd/qa/unit/export-tests.cxx  |3 -
 sd/source/filter/eppt/pptx-epptbase.cxx  |   11 ---
 sd/source/filter/eppt/pptx-epptooxml.cxx |6 --
 sd/source/filter/ppt/pptanimations.hxx   |2 
 sd/source/filter/ppt/pptin.cxx   |   12 
 sd/xml/effects.xml   |   16 -
 sd/xml/transitions.xml   |6 --
 slideshow/source/engine/transitions/ellipsewipe.cxx  |   25 ++--
 slideshow/source/engine/transitions/ellipsewipe.hxx  |4 -
 slideshow/source/engine/transitions/transitionfactorytab.cxx |2 
 14 files changed, 11 insertions(+), 127 deletions(-)

New commits:
commit 4bcb4774a331cbe7edbb8d92bc6b628e79eee9a6
Author: jan iversen <j...@documentfoundation.org>
Date:   Thu Jun 9 15:23:06 2016 +

Revert "Slideshow: Add 'Oval' Shape Transition variant"

The patch caused problems with the export filter tests, to check that you 
need to add --with-export-validation to your autopen.input

see 
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation
 for more info on how to set it up

This reverts commit 248c5ea771255b54e64394458a321ccf829bbd02.

Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162
Reviewed-on: https://gerrit.libreoffice.org/26114
    Reviewed-by: jan iversen <j...@documentfoundation.org>
Tested-by: jan iversen <j...@documentfoundation.org>

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu
index 23824c1..765a0d5 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu
@@ -50,11 +50,6 @@
   Circle
 
   
-  
-
-  Oval Vertical
-
-  
   
 
   Fly in Slow
@@ -1733,16 +1728,6 @@
   Circle
 
   
-  
-
-  Oval Horizontal
-
-  
-  
-
-  Oval Vertical
-
-  
   
 
   Diamond
@@ -2066,22 +2051,6 @@
   circle
 
   
-  
-
-  shape
-
-
-  oval-horizontal
-
-  
-  
-
-  shape
-
-
-  oval-vertical
-
-  
   
 
   shape
@@ -2414,7 +2383,7 @@
   Basic
 
 
-  ooo-entrance-appear;ooo-entrance-fly-in;ooo-entrance-venetian-blinds;ooo-entrance-box;ooo-entrance-checkerboard;ooo-entrance-circle;ooo-entrance-oval;ooo-entrance-fly-in-slow;ooo-entrance-diamond;ooo-entrance-dissolve-in;ooo-entrance-flash-once;ooo-entrance-peek-in;ooo-entrance-plus;ooo-entrance-random-bars;ooo-entrance-split;ooo-entrance-diagonal-squares;ooo-entrance-wedge;ooo-entrance-wheel;ooo-entrance-wipe;ooo-entrance-random
+  ooo-entrance-appear;ooo-entrance-fly-in;ooo-entrance-venetian-blinds;ooo-entrance-box;ooo-entrance-checkerboard;ooo-entrance-circle;ooo-entrance-fly-in-slow;ooo-entrance-diamond;ooo-entrance-dissolve-in;ooo-entrance-flash-once;ooo-entrance-peek-in;ooo-entrance-plus;ooo-entrance-random-bars;ooo-entrance-split;ooo-entrance-diagonal-squares;ooo-entrance-wedge;ooo-entrance-wheel;ooo-entrance-wipe;ooo-entrance-random
 
   
   
diff --git a/oox/source/ppt/slidetransition.cxx 
b/oox/source/ppt/slidetransition.cxx
index 49e24cf..9ae715f 100644
--- a/oox/source/ppt/slidetransition.cxx
+++ b/oox/source/ppt/slidetransition.cxx
@@ -371,17 +371,6 @@ namespace oox { namespace ppt {
 mnTransitionType = TransitionType::ELLIPSEWIPE;
 mnTransitionSubType = TransitionSubType::CIRCLE;
 break;
-case PPT_TOKEN( oval ):
-mnTransitionType = TransitionType::ELLIPSEWIPE;
-if( ooxToOdpDirection( param1 ) == TransitionSubType::VERTICAL )
-{
-mnTransitionSubType = TransitionSubType::VERTICAL;
-}
-else
-{
-mnTransitionSubType = TransitionSubType::HORIZONTAL;
-}
-break;
 case PPT_TOKEN( diamond ):
 mnTransitionType = TransitionType::IRISWIPE;
 mnTransitionSubType = TransitionSubType::DIAMOND;
diff --git a/oox/source/ppt/slidetransitioncontext.cxx 
b/oox/source/ppt/slidetransitioncontext.cxx
index 957d025..9b29653 100644
--- a/oox/source/ppt/slidetransitioncontext.cxx
+++ b/oox/source/ppt/slidetransitionc

Re: Alexis PAQUIN license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gökhan Gurbetoğlu license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Feature branch request

[jan iversen]

> On 10 Jun 2016, at 14:39, Khaled Hosny  wrote:
> 
>> On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote:
>> Therefore I request a feature branch with commit access so I can push
>> code faster then the current work flow will allow.
> 
> Can you we get a Akash commit access to push his work on a branch, he
> has sent several patches to gerrit already and I think he can be trusted
> with commit access (though in general I’d prefer if there was an
> alternative to push his work before it is ready to be merged, but there
> does not seem to be any).

How about using gerrit, it is designed for that purpose.

rgds
jan i
> 
> Regards,
> Khaled
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Welcome back

[jan iversen]

Welcome back

I saw your patch, and noted it has been quite a while since you last 
contributed, so I would like to take the opportunity to say "Welcome back".

We hope you will submit more patches, and help is highly appreciated.

It is part of my responsibilities to help contributors (yet to be committers) 
become committers, so feel free to contact me, if you need help.

We have made a step by step guide to help you:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Cleanup development WIKI structure and pages

[jan iversen]

Hi

I started a while ago to look at our development wiki pages, they contain an 
awful load of  very useful information, it is however amazing to see how well 
hidden some of the information are.

I created a new page (ONLY for maintenance, and keeping track of what needs to 
be done):

https://wiki.documentfoundation.org/ProjectCleanupDevelopmentWiki

The page contains extracts from Wiki's special pages, and each section calls 
for a special kind of work. Participation is welcomed, but please do not edit 
this page unless the work is done :-)

My intention is
first) solve orphans, redirects etc.
second) group all pages in meta groups, lilke one group for everything about 
build
third) update the entry page to provide links to the groups
fourth) slowly walk through the pages and make sure they are accurate

This is a rather big undertaking, but I hope by taking the initiative to 
motivate others to help.

have a nice weekend
rgds
jan I. ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

100.000 registred (and majority solved) bugs

[jan iversen]

Hi

We passed a golden number yesterday.

Bug 100.000 was registred in Bugzilla. The lucky "winner" was Cor Nouws.
https://bugs.documentfoundation.org/show_bug.cgi?id=10

A vibrant Bugzilla is one of the best indications, that LibreOffice is used and 
not just downloaded all over the world.

Please remark, all products have bugs, so getting bugs reported only shows the 
product is being used, in all different corner cases, and as long as the number 
of open bugs does not grow identically this is a good life sign.

For the last 6 month (my period of observation), we have kept pace and even 
reduced the number of open bugs. A lot of the patches come from contributors 
(yet to be committers), and even though they tend to solve the easy ones, it 
still tells a story.

Have fun out there.

Rgds
Jan Iversen___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Some thoughts about our tests and the build time

[jan iversen]

> 
> Along with that, we could then kill the "make build-nocheck" travesty and have
> 'make' and 'make build' each do the same regardless of if its on toplevel and
> in a module? Right?  Please?

When we talk about simplifying, it would be good if
"make" used pr default the same configuration as our release build on the 
platform.

Or at the very least have a "make release". 

Right now if people change e.g. 5.1 to make a local change and do a build they 
end up with a very different image, and finding the release configurations is 
not that easy.

rgds
jan I.

> 
> Best,
> 
> Bjoern
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: mechaxl license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Feature branch request

[jan iversen]

> On 10 Jun 2016, at 15:51, Khaled Hosny <khaledho...@eglug.org> wrote:
> 
>> On Fri, Jun 10, 2016 at 03:27:00PM +0200, jan iversen wrote:
>> 
>> 
>>>> On 10 Jun 2016, at 14:39, Khaled Hosny <khaledho...@eglug.org> wrote:
>>>> 
>>>> On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote:
>>>> Therefore I request a feature branch with commit access so I can push
>>>> code faster then the current work flow will allow.
>>> 
>>> Can you we get a Akash commit access to push his work on a branch, he
>>> has sent several patches to gerrit already and I think he can be trusted
>>> with commit access (though in general I’d prefer if there was an
>>> alternative to push his work before it is ready to be merged, but there
>>> does not seem to be any).
>> 
>> How about using gerrit, it is designed for that purpose.
> 
> Gerrit does not handle multiple commits quite well, and the code is
> still evolving so it will just make everything needlessly complex
> (rebasing, squashing commits etc.).

Well, you have rebasing and squashing on a branch as well. Using git commit 
--amend works very well for mutiple commits (and one merge), actually that 
saves the --squash.

We have a slot in the weekly ESC meeting where new committers are suggested, 
discussed and normally approved.

rgds
jan i

> 
> Regards,
> Khaled
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Aparajita Haldar license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Apurva Priyadarshi] License statement

[jan iversen]

Thanks for your license statement.

I can see Stephan has added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.

> On 30 May 2016, at 09:23, Stephan Bergmann <sberg...@redhat.com> wrote:
> 
>> On 05/27/2016 08:36 PM, Apurva Priyadarshi wrote:
>> All of my past & future contributions to LibreOffice may be
>>   licensed under the MPLv2/LGPLv3+ dual license.
> 
> put on file as 
> <https://wiki.documentfoundation.org/index.php?title=Development/Developers=125821>
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: new developer

[jan iversen]

Thanks for your license statement.

Please remark we are very carefull about not changing the text of the license 
statement, as it might weaken it (and thus have the opposite effect as you 
wanted), but since you have not modified the original statement we use that.
  
I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

[jan iversen]

> * Commit Access
>+ cleanup of stale? committers (Norbert)
>  + ran a script to find people with no commit >1 yr.
> + or should we let them stay around.
>  + some project revoked after 0.5 years (Miklos)
> + frugalware.
>  + do we have any problem with leaving them ? (Stephan)
> + no; but don't want to ever be (Norbert)
>  + concern wrt. removing committers (JanI)
> + openhub counts actual commits (Norbert)
>  + generate a mail if they arrive (JanI)
>  + social aspect concern (Michael)
> + if we can get people active again by poking (Bjoern)
>+ can be helpful.
> + otherwise leave open & put a watch on commits (Bjoern)
>+ just look at these carefully.
>+ and welcome them back.
>  + concern wrt. the work, some people move on (Norbert)
> + do we want to keep them open forever.
> + we have a bunch of ex. GSOC never seen again ?
>+ silently remove those we think are unlikely to come back
>+ concern wrt. creating lots of rules
>+ notify removing them.
>  + for sure - commit rights to random projects (Kendy)
> + not feel comfortable committing now.
> + if not for three years - through gerrit.
>=> leave up to JanI

Based on the above discussion, my intention is:

- To extend my nightly statistic script, to check new commits (probably 
restricted to our code repo).
- For every commit If the delta between the last commit from the author and 
this commit is more than 1Year, the script will notify me.
- I will write a "happy to see you again" mail, with copy the dev list, so the 
author hopefully starts to be an active part of the community again.

- We already have scripting in place, to mail authors who have not contributed 
for > 3 months. (see "20(20) to be emailed" in the stats.

- Before revoking anybodys commit right please notify me in advance, so I can 
write a nice email to them as a last poke before executing the revoke.

Suggestions and comments are welcome.
rgds
jan I




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: LIbreOffice integration into accessible software project

[jan iversen]

Forwarded from hostmaster mail.

Maybe someone in here, have a suggestion where to look ?

rgds
jan i


Begin forwarded message:

> From: Rebecca Luttmer 
> Date: 25 May 2016 at 17:52:24 GMT+2
> To: "hostmas...@documentfoundation.org" 
> Subject: LIbreOffice integration into accessible software project
> 
> Hello,
>  
> My name is Rebecca Luttmer, and I am part of a team developing a Java 
> application in the field of Visual Impairment and Accessibility.  We are 
> looking for a math editor to integrate into our existing project.  The math 
> editor must be completely accessible with a screen reader, and we are 
> interested in the LibreOffice math formula editor.  Please tell me who I can 
> talk to about adding some accessibility to the editor, and also getting 
> information about the formula editor API and documentation.  I have been to 
> this site: http://api.libreoffice.org/ which provides excellent documentation 
> on every aspect of LibreOffice except the formula editor. 
>  
> Thank you for your time,
> Rebecca Luttmer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Jason C. McDonald (CodeMouse) license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I can see you have added yourself to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Sam Tygier license statement

[jan iversen]

WELCOME
Thanks for your license statement.

I can you are added to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice