[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||kain...@gmail.com,
   ||stephane.guillou@libreoffic
   ||e.org
 OS|Windows (All)   |All
 Resolution|WORKSFORME  |FIXED
 Whiteboard||target:6.2.0

--- Comment #29 from Stéphane Guillou (stragu) 
 ---
Just for the record, the command for Insert > Slide Number was switched by
Andreas Kainz in 6.2 from .uno:InsertSlideNumber to .uno:InsertSlideField with
c50e4badfcb701d9e3927dae6617bb0d33f386e0

But now we have a duplicate in the menu, given that it's also in Insert >
Fields > Slide Number.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4902

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Timur  changed:

   What|Removed |Added

 CC||ti...@libreoffice.org
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #28 from Timur  ---
As Cor noted, Insert > Slide Number puts the slide number so this is WFM.
Slide number gets somewhat strange position in the slide center, and frame is
too large, but that's for another report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #25 from Cor Nouws  ---
In Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-08-09_06:28:42
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded

now Insert > Slide Number now puts the slide number where the cursor is.. If
that is really an improvement or more a affront..?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #24 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Yousuf Philips (jay)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |4175|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4175

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #22 from Cor Nouws  ---
(In reply to Jan Holesovsky from comment #20)
> For what it's worth, I like the Regina's proposal; particularly the "Keep


And what about "I think, these dialogs need a deep rework."?

When we start changing these area's, with so many remarks, quirks.. let's
please go all the way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2203

--- Comment #21 from Yousuf Philips (jay)  ---
What i mentioned in the gerrit patch "we have unified the location of 'header &
footer' in all modules to the insert menu, so i would not move it".

(In reply to Heiko Tietze from comment #6)
> So for consistency, we should change .uno:InsertPageNumber towards a toggle
> function which shows or hides the page number. The function itself should be
> disabled when there is no footer. Since master slides define page numbers
> on/off this option should be also taken into account.

Agree that this should be changed, as i believe i mentioned the same somewhere
else but cant remember where, but its code should only show and not hide the
slide/page number field, as it is in the insert menu. Google Docs has it in
this way as well.

(In reply to Jan Holesovsky from comment #20)
> For what it's worth, I like the Regina's proposal; particularly the "Keep
> the current "Header and Footer" dialog, but perhaps name it "Manage Field
> Areas" and put it into the Slide menu or Format menu."

Not sure about renaming it as the same dialog is in Powerpoint and WPS/Kingsoft
and named the same way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #20 from Jan Holesovsky  ---
For what it's worth, I like the Regina's proposal; particularly the "Keep the
current "Header and Footer" dialog, but perhaps name it "Manage Field Areas"
and put it into the Slide menu or Format menu." would sort out the confusion
that was reported in this bug in the first place :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #19 from Regina Henschel  ---
Created attachment 129398
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129398=edit
seeming different footer content on same master

(In reply to Cor Nouws from comment #18)

> But a problem you'll have with a dialog in that form, is that it may suggest
> that one can add different footer text to different master page slides. And
> that is not the case. So therefore more changes on a combined dialog are
> needed.

It is not a problem, which comes with a new dialog, but the problem exists
already in the current "Header and Footer" dialog. In Master View it looks, as
if you can set the content of the footer-field. But the content of the
footer-field never belongs to a Master page. [The footer-field is the part with
placeholder-text , which is gray.]

To see what I mean open the attached document.
Goto first slide, then switch to Master View. Open the 'Header and Footer'
dialog and look at the line 'Footer text:'. You will see "1First version inside
footer1". Cancel and close Master View.
Goto second slide, then switch to Master View. Again open the 'Header and
Footer' dialog and look at the line 'Footer text:'. You will see "2Second
version inside footer2". Cancel and close Master View.

I think, these dialogs need a deep rework.

An additional idea for a solution: Make different dialogs for Master View and
for Normal View.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #18 from Cor Nouws  ---
(In reply to Regina Henschel from comment #17)

> I suggest:
> Keep the current "Header and Footer" dialog, but perhaps name it "Manage
> Field Areas" and put it into the Slide menu or Format menu.
> Remove the "Master Elements" dialog and make the check boxes in the current
> "Header and Footer" dialog work the same as in the current "Master Elements"
> dialog.
> Disable options in the "Header and Footer" dialog in Normal view, in case
> that Area is hidden by the Master.

The idea of combining both in one dialog sounds attractive. But it implies that
is has two functions, what (partially) depends on the position where you would
open the dialog: if you want to hide master elements for a master page, you
have to open the dialog on a slide with that master page; if you want to insert
text etc. in the master elements, you must open it on a different slide. This
is not self explaining.. Could be circumvented by adding a list view to the
dialog, showing all the applied master pages, so that in one run, all master
pages can be handled. (Analogue to list view in e.g. Tools>Outline Numbering)
But a problem you'll have with a dialog in that form, is that it may suggest
that one can add different footer text to different master page slides. And
that is not the case. So therefore more changes on a combined dialog are
needed.

> Users might want a "Slide Number" item in the Insert menu. That should not
> open the "Header and Footer"-dialog, but insert a slide number same as via
> Insert > Field. That would be similar to the "Insert > Page Number" item in
> Writer.

Activating the slide number in the current dialog, puts the field in the master
page element(s). And you can check to omit the fist slide. This is quite
different from putting a page number field om the cursors position, so why not
simply ..:

> It might be useful to have an additional item "Show Slide Number Area", so
> that the user need not find this setting in a dialog, which has not "slide
> number" in its name.

what is what one does in the current dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #17 from Regina Henschel  ---
The page number field in Impress is the same as in Writer. It belongs to the
kind "Text Fields" and is an element  in both cases. A page
number field as such does neither belong to the page style in Writer nor to the
Master in Impress/Draw.

The  element can be child of a  element. And such
paragraph is child of a  element or of  or of
 or of other places which allow a paragraph. [I know that
LibreOffice has not implemented all possible places.]

Impress has the difference to Writer, that it has a predefined frame which has
a paragraph with the page number field. This frame is called "Slide Number
Area" in the UI. But you can add the page number field to the title too or use
a custom frame for example; that is via Insert > Field > Page Number. That is
the same  element. And you need not insert the page number in
a Master but you can add it into a slide directly, same as you can add a page
number to any text in Writer.

All these aspects make the page number different from the footer, header and
date/time placeholders, which are pure presentation fields.

Show/Hide in "Master Elements" dialog does actually mean to show/hide the
frame, that is called "NNN Area" in the Master UI. It is very confusing, that
its settings have priority over the checkboxes in "Header and Footer" dialog,
but the "Header and Footer" dialog does not reflect that.

I suggest:
Keep the current "Header and Footer" dialog, but perhaps name it "Manage Field
Areas" and put it into the Slide menu or Format menu.
Remove the "Master Elements" dialog and make the check boxes in the current
"Header and Footer" dialog work the same as in the current "Master Elements"
dialog.
Disable options in the "Header and Footer" dialog in Normal view, in case that
Area is hidden by the Master.

Users might want a "Slide Number" item in the Insert menu. That should not open
the "Header and Footer"-dialog, but insert a slide number same as via Insert >
Field. That would be similar to the "Insert > Page Number" item in Writer.

It might be useful to have an additional item "Show Slide Number Area", so that
the user need not find this setting in a dialog, which has not "slide number"
in its name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #16 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #15)

> You can insert the page number independently from the page formatting in
> Writer. The opposite is true for Impress where you insert a page number but
> remove it by changing the master layout. 

In Writer, the page number (format/position) is stuck to the specific page
style.
In Impress, the page number (format/position) is stuck to the specific.. master
page.

> The page number is furthermore part
> of the master details hardly comparable to page settings in Writer.

Semantic discussion..

> While I understand your concerns the issue remains: two functions lead to
> the same dialog. That's confusing for users.

I agree that that is unfortunate. But breaking the logic "design
versus inserting" (similar to Writer), and hiding the features that basic users
will look for, seems even less ideal to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #15 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #14)
> (Similar in Writer:
>- Format>Page for formatting header/footer and page number;
>- Insert>Header/Footer to actually add content; and > Page Number to 

You can insert the page number independently from the page formatting in
Writer. The opposite is true for Impress where you insert a page number but
remove it by changing the master layout. The page number is furthermore part of
the master details hardly comparable to page settings in Writer.

While I understand your concerns the issue remains: two functions lead to the
same dialog. That's confusing for users. And I believe we make it more clear
that page numbers are not the same as in Writer when the header/footer elements
go to some other place.

Alternatively (and even better IMHO) the page number would be a toggle function
disabled when the element is excluded in the master slide (see comment 6). But
the decision was made by ESC to better not touch .uno commands which brought us
to the current situation.

More opinions are welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #14 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #13)
> (In reply to Cor Nouws from comment #12)
> > I have the impress ;) ion that the following applies:
> 
> So you disagree with what kendy stated in comment 9? 

Yes.
The formatting aspect is done via Slide>Master Elements
The insert aspect is done via Insert>Slide Number (etc)
(As I expressed in my previous comment.)
(Similar in Writer:
   - Format>Page for formatting header/footer and page number;
   - Insert>Header/Footer to actually add content; and > Page Number to 
   actually insert the page number field ) 

> Do you suggest to
> change Impress so that the page number is not part of the master anymore?

No.

> These are rhetorical questions, we better discuss it in a meeting.

I'm always is favor of discussion in a meeting when enough factual information
(and interpretations) are gathered beforehand.

> If you, on the other hand, think my suggestion to have H next to master
> elements is a fail you could easily -1 the patch
> https://gerrit.libreoffice.org/#/c/31502/. 

Done.

> But please share a better idea in this case.

IMO the current situation is the best, most consequent across the modules.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #13 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #12)
> I have the impress ;) ion that the following applies:

So you disagree with what kendy stated in comment 9? Do you suggest to change
Impress so that the page number is not part of the master anymore? These are
rhetorical questions, we better discuss it in a meeting.

If you, on the other hand, think my suggestion to have H next to master
elements is a fail you could easily -1 the patch
https://gerrit.libreoffice.org/#/c/31502/. But please share a better idea in
this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #12 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #11)

> Made a patch last week which awaits approval. "Header and Footer" goes under
> Slide/Master Elements and Pagenumber will be removed from the main menu.

I have the impress ;) ion that the following applies:
Master Elements allows to show or hide elements per master page. Multiple
master pages are possible in one presentation.
When one enters text for a footer, or a slide number, that is applied to all
slides (except #1, by choice) that have the corresponding master page elements
set to visible.
Master Elements, show or hide, is more about the design of the presentation,
and not necessary to be 'right in the face'.
Inserting a page number or entering the desired text for footer (header) is a
matter for the basic user who makes the presentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #11 from Heiko Tietze  ---
(In reply to Cor Nouws from comment #10)
> I would suggest to leave as is.

Made a patch last week which awaits approval. "Header and Footer" goes under
Slide/Master Elements and Pagenumber will be removed from the main menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #10 from Cor Nouws  ---
Hmm, this has been discussed rather extensively when working on the new Menu
layout for Impress. :)

Logic would be to have one entry "Insert > Slide number / Header and Footer
text" But way too long.

(Note that the entry is "Header and Footer" since there is a header in the
Notes and Handouts..)

I would suggest to leave as is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #9 from Jan Holesovsky  ---
OK, so I think the confusion here is that the dialog that shows either with
Insert -> Page Number... or Insert -> Header and footer... is mis-categorized.

It is not an insert function at all; more like a formatting one (a bit
equivalent to Format -> Page Style... (tabs Header / Footer).  In the Writer,
Insert -> Page Number inserts a field with the actual page number, and Insert
-> Header and Footer inserts the actual header / footer.

I think the best solution would be to move the dialog to the Format menu, and
remove both "Page Number..." and "Header and Footer..." from the Insert menu;
but no idea what would be the impact on the user who are used to this location
of the dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Katarina Behrens (CIB)  changed:

   What|Removed |Added

   Keywords|needsDevEval, topicUI   |

--- Comment #8 from Katarina Behrens (CIB)  ---
First, not every change is an (incompatible) API change. Deleting a command is
an API change. Changing the type and number of arguments a command accepts is
an API change. However, changing return value of a command (which is what would
be required to make this .uno command a binary toggle) is NOT an API change,
thus it's fine to do it that way

Second, the code pointers are slightly misleading and rather incomplete. The
return value of SID_INSERT_PAGE_NUMBER slot is defined in sd/sdi/sdraw.sdi, it
should be changed from SfxVoidItem to SfxBoolItem. Then, a new case has to be
added to sd/source/ui/view/drviews3.cxx, DrawViewShell::ExecCtrl to serve the
changed slot. It has to contain some code to find out if the current page has a
page number visible and toggle it on/off

Come to think of it, maybe it'd be better to do this in a new, separate slot
(.uno:TogglePageNumber?) instead of sodomizing the old .uno:InsertPageNumber
one

And finally third, given all of the above, this is likely not an easy hack.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

jan iversen  changed:

   What|Removed |Added

   Keywords|difficultyBeginner, |needsDevEval
   |easyHack|

--- Comment #7 from jan iversen  ---
(In reply to Heiko Tietze from comment #6)
> So for consistency, we should change .uno:InsertPageNumber towards a toggle
> function which shows or hides the page number. The function itself should be
> disabled when there is no footer. Since master slides define page numbers
> on/off this option should be also taken into account.
> 
> Sounds like an easyhack to me. Code pointer is in comment 5.

This is a Uno api change, that need first to be aproved by ESC, then the
consequences for 3rh party programs. This requieres insight.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, topicUI
 Status|UNCONFIRMED |NEW
 CC||j...@documentfoundation.org
 Ever confirmed|0   |1

--- Comment #6 from Heiko Tietze  ---
So for consistency, we should change .uno:InsertPageNumber towards a toggle
function which shows or hides the page number. The function itself should be
disabled when there is no footer. Since master slides define page numbers
on/off this option should be also taken into account.

Sounds like an easyhack to me. Code pointer is in comment 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #5 from Katarina Behrens (CIB)  ---
The two commands/slots are served by the same Execute function and the same
branch in switch-case, see here:
http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviews3.cxx#289 

Afaics it has been like that since 2004 when the feature (header/footer support
in Impress'n'Draw) has been added

If you ask me, it's slightly substandard UX, but I'm "just" a developer, not a
UX expert

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #4 from Heiko Tietze  ---
At least the commands are different.

Page Number...  
Header and Footer...  

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Buovjaga  ---
(In reply to Telesto from comment #2)
> Didn't check it first, my bad! I suppose the menu-item Insert Page Number
> could be removed. It doesn't have a separate function as in Writer. The Calc
> Insert menu doesn't have Page Number item either. In Calc page-numbers can
> be created with 'Header/Footer' option.

I think it's separate because of easier discoverability. Let's throw this to UX
real quick.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

--- Comment #2 from Telesto  ---
(In reply to Buovjaga from comment #1)
> This is the same in 3.3. I think this is the intended behavior. There is the
> checkbox Slide number.
> 
> Do you have a proposal to make it different?

Didn't check it first, my bad! I suppose the menu-item Insert Page Number could
be removed. It doesn't have a separate function as in Writer. The Calc Insert
menu doesn't have Page Number item either. In Calc page-numbers can be created
with 'Header/Footer' option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104088] Impress: Insert Pagenumber and insert header and footer linking to the same dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104088

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
This is the same in 3.3. I think this is the intended behavior. There is the
checkbox Slide number.

Do you have a proposal to make it different?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs