[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #14 from sdc.bla...@youmail.dk --- (In reply to Telesto from comment #11) In short and in general: Problems in comment 11 seem to stem from difficulties in knowing how to select an anchor (see bug 146445 for relevant explanations), which is related to/interacts with difficulty in knowing how to interpret the current anchor icon properly to determine the anchor location. Bug 138351 discusses the issue of improving the display of anchor location -- but even if that is improved, it is necessary to know how to insure that the anchor is included in the selection. Possible "responses": - make it easier for a user to know when an anchor is included in a text selection (but no proposals offered for design changes.) - give better documentation about how to insure selection of an anchor (but less effective for those users who expect the interface to be "intuitive", and therefore will not read documentation). About selecting the anchor: Here are three examples that will illustrate how to "succeed" in places where you have "failed". Perhaps these positive examples (along with the explanations in bug 146445) will help you to form an understanding of what is needed to insure that an anchor is selected. > 3. Move the text up. Yellow and orange shape not moving Do NOT repro with cursor placed in paragraph and Ctrl+Alt+Up arrow. All shapes move. Do repro with Ctrl+X on selection and Ctrl+V. > 8. Double click 'Blue' > 9. Drag & drop below heading 1.. image not following > 11. Place cursor after 'yellow' and select blue with the space before > 12. Drag up below heading 1. -> Only "blue' text moves image stays 8 and 11 show examples where you have failed to select the anchor. Additional tests to show how to drag blue shape up, by including the anchor in the selection. 13. Open attachment 180813, place cursor before "b" in blue, then select two characters to left (i.e., space and "w" at end of yellow). Drag selection to Heading 1, see "blue" shape follow. 14. Open attachment 180813, select blue shape, move anchor to middle of word "blue". Double-click "blue", drag to Heading 1, see "blue" shape follow. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #13 from Eyal Rozenberg --- "Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section" Do you mean "an image anchored to a character or to a paragraph, or at the beginning of a paragraph, isn't included when selecting the single line containing that character, or the end of the paragraph, or the beginning of the paragraph respectively"? If not, please try to rephrase the title. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Telesto changed: What|Removed |Added CC||eyalr...@gmx.com, ||sdc.bla...@youmail.dk --- Comment #12 from Telesto --- I would like some extra input/ other perspectives on the topic here @Seth, You fixed quite a number of documentation issues... and well you're also good at investing a design.. This might become a documentation topic some point anyhow @Eyal You're comments are always appreciated.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #11 from Telesto --- Created attachment 180813 --> https://bugs.documentfoundation.org/attachment.cgi?id=180813=edit Example file Sorry that I keep going .. 1. Open the attached file 2. Select the highlighted text 3. Move the text up. Yellow and orange shape not moving (yes, I know: anchored at beginning and end of a singe paragraph) 4. CTRL+Z 5. Place arrow before 'ghi' 6. Press Shift Arrow Down (2 paragraph selected). Drag and drop the text below heading 1 -> all images follow 7. CTRL+Z 8. Double click 'Blue' 9. Drag & drop below heading 1.. image not following (image anchored 'before' b) 10. CTRL+Z 11. Place cursor after 'yellow' and select blue with the space before 12. Drag up below heading 1. -> Only "blue' text moves image stays I do not really understand why multi-line paragraph will include images.. but single paragraph not.. And why an anchor at the left of word isn't included with the selection (especially if the space is also included) There is obviously the possibility that I'm mistaking about what to character anchoring is and how it should be used. Aka I might have different expectations compared to the design (how I think it should working < - > How it's actually working). And there obviously also a difference between 'ideal situation' and the part which is technically possible. And yes, sure, there likely always which don't fit any model. (So being off) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #10 from Michael Stahl (allotropia) --- (In reply to Telesto from comment #9) > Created attachment 180761 [details] > Example file Second attempt > > (In reply to Michael Stahl (allotropia) from comment #8) > > i don't think there's an easy tweak to this that preserves the API > > compatibility that comment#4 is about, and it's a rather minor problem, you > > can always click on the image to delete it that way. > > A small retry probably better describing the 'issue'. Primary question: > What's the value of anchoring an image to an character if the anchor is > broken with ease. The anchor suggests a connection between 'the character' > and the image . The image is positioned relative to the anchor point, so if > the characters move (drag/drop or copy/paste) the image should be following. > > 1. Open the attached file > 2. Double click Lorem Ipsum > 3. Drag the text to the top of the page (say it's a list without bullets) wow, writer can do that? > 4. Notice the image moving (why: image is anchored to character, and the > anchor is manually attached to 'm' of ipsum the anchor is between "u" and "m" so it is not at the end of the paragraph so it is included in the selection. > 5. CTRL+Z > 6. Change the anchor of the image to 'to paragraph' > 7. Change the anchor back to 'to character' (anchor will but after ipsum). > Now drag the text up again.. Image stay's behind (expected to move along > with the text) as in 4 now the anchor is after "m" at the end of the paragraph so it is not included in the selection. > 8. Undo the dragging up (but anchor still behind 'ipsum') > 9. Press CTRL+A and enable bulleted list > 10. Move Ipsum Lorum up (with arrows). Notice the anchor moving along. now this moves entire nodes, so anything attached to the node will move with it (except things that span multiple nodes, then it gets complicated and maybe crash prone...). > I guess there being an explanation for each and every case in technical > sense. But from end-user perspective this kind of arbitrary. > > And well 'to character' has to states. (A). Truly positioned to a character. > (B) put after a characters (most common, I guess). Which is not truly a to > character anchor, IMHO generally anything in writer is either a character itself or positioned *between* 2 characters; "as-char" is an example of the former, "at-char" an example of the latter, and "at-para"/"at-fly"/"at-page" are weird exceptions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #9 from Telesto --- Created attachment 180761 --> https://bugs.documentfoundation.org/attachment.cgi?id=180761=edit Example file Second attempt (In reply to Michael Stahl (allotropia) from comment #8) > i don't think there's an easy tweak to this that preserves the API > compatibility that comment#4 is about, and it's a rather minor problem, you > can always click on the image to delete it that way. A small retry probably better describing the 'issue'. Primary question: What's the value of anchoring an image to an character if the anchor is broken with ease. The anchor suggests a connection between 'the character' and the image . The image is positioned relative to the anchor point, so if the characters move (drag/drop or copy/paste) the image should be following. 1. Open the attached file 2. Double click Lorem Ipsum 3. Drag the text to the top of the page (say it's a list without bullets) 4. Notice the image moving (why: image is anchored to character, and the anchor is manually attached to 'm' of ipsum 5. CTRL+Z 6. Change the anchor of the image to 'to paragraph' 7. Change the anchor back to 'to character' (anchor will but after ipsum). Now drag the text up again.. Image stay's behind (expected to move along with the text) as in 4 8. Undo the dragging up (but anchor still behind 'ipsum') 9. Press CTRL+A and enable bulleted list 10. Move Ipsum Lorum up (with arrows). Notice the anchor moving along. I guess there being an explanation for each and every case in technical sense. But from end-user perspective this kind of arbitrary. And well 'to character' has to states. (A). Truly positioned to a character. (B) put after a characters (most common, I guess). Which is not truly a to character anchor, IMHO In case of 'to paragraph' we end up' what 'anchor to paragraph' means. Is the image bound to the paragraph (the characters) or bound to paragraph location. Currently it's mixture of both (case dependent) A fix would be to actually anchoring the anchor to a character and not the 'invisible' behind or in case of to paragraph 'prior' the visible character. [sorry, for the bad terminology]. But I'm not overseeing the consequences.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |WONTFIX See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9668 Status|NEW |RESOLVED --- Comment #8 from Michael Stahl (allotropia) --- yep, the image anchored at the edge of a section will be selected only if the selection spans multiple paragraphs. but this is already the case if it's anchored at the end of any paragraph, the difference is just that in this case you can't extend the selection in the direction where the image is anchored, because there's nowhere to go, you have to extend it in the *other* direction. i don't think there's an easy tweak to this that preserves the API compatibility that comment#4 is about, and it's a rather minor problem, you can always click on the image to delete it that way. so i guess it could be NOTABUG or WONTFIX... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Gabor Kelemen (allotropia) changed: What|Removed |Added Regression By||Michael Stahl CC||kelem...@ubuntu.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Gabor Kelemen (allotropia) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from Gabor Kelemen (allotropia) --- Confirming in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ccbd2b0c663fa19be5301f0ea8ac74caa055fe47 CPU threads: 14; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #6 from Dieter --- Tested with Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL For me it seems, that there is the general rule: You can select an image (anchored to paragraph or to character), if paragaph has at least one character and it isn't the last paragraph. Not sure, if this is a bug or not, because I don't understand comment 4. Michael, what do you think? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Telesto changed: What|Removed |Added CC||michael.st...@cib.de --- Comment #5 from Telesto --- Adding CC: to Michael Stahl Didn't work properly in similar cases prior to this commit.. so this regression is also an improvement in the sense of more consistent.. Except the outcome isn't ideal from user point of view (who visually edits; no clue about the programmers of WollMux) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Telesto changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Version|7.2.0.0.alpha0+ Master |7.0.0.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057
--- Comment #4 from Telesto ---
Created attachment 168328
--> https://bugs.documentfoundation.org/attachment.cgi?id=168328=edit
Bibisect log
Bisected to:
author Michael Stahl 2020-04-09 18:31:50 +0200
committer Michael Stahl 2020-04-14 16:59:00
+0200
commit 971205dc2110c1c23ff1db1fc4041e2babf6fa9f (patch)
tree206e18ddc8ee58be806c59ed4e78724550647498
parent 11785217594d863efb518aa8b8f2910cdcb9c59d (diff)
sw: fix fly at-char deletion API behaviour change
28b77c89dfcafae82cf2a6d85731b643ff9290e5 changed at-char anchored fly
selection.
WollMux calls setString("") to remove one character in the first
paragraph and a fly anchored at the start of the body text is deleted
due to the new IsAtStartOfSection() check.
It would be possible to treat deletion via API differently than via UI,
as there is already a flag ExcludeFlyAtStartEnd but it would require
passing the flag through 10 functions and also to store it in
SwUndoDelete...
The main intent of the IsAtStartOfSection() check was that Ctrl+A should
delete every fly; this can be achieved by checking that everything was
selected, so that selections only inside the first/last paragraph don't
delete the flys at the edges.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=971205dc2110c1c23ff1db1fc4041e2babf6fa9f
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #3 from Telesto --- Also fine in 6.2.9 (for the exact issue as in this bug report) Moving the image to Lorem between the to headings.. and this same thing doesn't work.. which is even the case in 3.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #2 from Telesto --- Fine (for the to character anchoring in) Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section
https://bugs.documentfoundation.org/show_bug.cgi?id=139057 --- Comment #1 from Telesto --- Created attachment 168319 --> https://bugs.documentfoundation.org/attachment.cgi?id=168319=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
