[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2023-02-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

Caolán McNamara  changed:

   What|Removed |Added

  Regression By|Caolán McNamara |

--- Comment #8 from Caolán McNamara  ---
caolanm->raal: I think that bisect doesn't really help. In the version without
that fix add an initial set of adding a single character to the document before
following the other steps (this sets the document to "modified"). Then after
that, format page, and set height to 5cm, and ok and the same behavior is seen
without that commit which just faithfully recognized that there was a
modification done to the document by changing a page style.

If I bisect with that extra step then I get the result of:

commit c927ea4c5d8a9ede979e17c09c2303854ccdebec
Author: Muhammet Kara 
Date:   Mon Jun 24 01:46:42 2019 +0300

Sync page orientation of Endnote page

Description:
When changing the default page style to have a different orientation,
end-notes are placed on a page with a custom ‘Endnote’ page style.
This style does not inherit its orientation from the default style.

Repro:
Create a blank document, insert→End Note, Format→Page in the first page,
select the Page tab, and alter the Orientation to Landscape, ‘Ok’.
The End-note page should update its orientation too.

NB. If the Endnote page style is manually set to a different value
in a document template it will remain in the selected orientation.

After this patch, Default style and the Endnote style have their
orientations synced after each run of the Format > Page dialog.

Ideally, this should be solved by resolving tdf#41316 on master:
Page styles should support hierarchical parent-child relationships
(like paragraph or character styles)

Change-Id: I255b470d1aebb897f50a4a74b8678b771ffbab28
Reviewed-on: https://gerrit.libreoffice.org/79869
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/82173
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

If I go back to the oldest version I have, and manually toggle the "endnote"
page style from portrait to landscape then I think I get the odd behavior too.

So the change of the endnote orientation along with the default page style
orientation was deliberate, and not in itself a bad idea, but the result is
unsatisfactory I guess.

One possible tweak might be to only do the "syncEndnoteOrientation" if the
default page style paper size matches the endnote page style paper size?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2023-02-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

raal  changed:

   What|Removed |Added

  Regression By||Caolán McNamara
 CC||caol...@redhat.com,
   ||r...@post.cz
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #7 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks

a8461899f33e3a07713239130aeea1b29786f075 is the first bad commit
commit a8461899f33e3a07713239130aeea1b29786f075
Author: Jenkins Build User 
Date:   Mon Dec 14 21:34:13 2020 +0100

source sha:ccd89a02f8b5f0e7c542353c5bf0a774dbf781d2

https://git.libreoffice.org/core/+/ccd89a02f8b5f0e7c542353c5bf0a774dbf781d2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

--- Comment #6 from Heiko Tietze  ---
Changing the Default PgS also affects the Endnote PgS but no other in the
document (at least one manually created). => bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #5 from Mike Kaganski  ---
(In reply to Dieter from comment #4)
> (In reply to Heiko Tietze from comment #3)
> > Landscape = Width > Height, so I don't see a problem here.
> 
> Question was, if endote page syle should also change orientation.
> Your answer is yes, and that's O.K. for me.

And my answer is "no" ;)
This is a regression - at least it was not so in 4.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

--- Comment #4 from Dieter  ---
(In reply to Heiko Tietze from comment #3)
> Landscape = Width > Height, so I don't see a problem here.

It's not a problem, that page orientation of default page style changes to
landscape. Question was, if endote page syle should also change orientation.
Your answer is yes, and that's O.K. for me. Don't know what happens, if you
have - for example - first page style in portrait and then a default page style
in landscape.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mikekagan...@hotmail.com
   Keywords|needsUXEval |
 Status|UNCONFIRMED |NEW

--- Comment #3 from Heiko Tietze  ---
Landscape = Width > Height, so I don't see a problem here.

But in fact, endnotes are not updated when the page style changes. Happens also
when you change it from A4 to A5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Blocks||103164, 108576
 Whiteboard| QA:needsComment|

--- Comment #2 from Dieter  ---
(In reply to LeroyG from comment #0)
> After step 3:
> The page orientation for the endnotes change to landscape.

I confirm it with
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2934472ab888ebfe64a153984af2902fac63a7a0
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

As there is the basic rule "One bug report for each problem" let's focus this
report to the landscape problem. Feel free to open additional reports for the
other problems.

Further testings
Height of default page style 22 cm => Endnote page is still in portrait
Height of default page style 21 cm => Endnote page is still in portrait
Height of default page style 20 cm => Orientation of default page style changes
to landscape and also endnote page style changes to landscape

So there seems to be the rule "Orientation of endnote page style follows
orientation of default page style"

I don't know, if this is the expected behaviour or a bug. Let's ask design team
cc: Design-Team


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103164
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108576
[Bug 108576] [META] Writer page style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-12-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145936] FORMATTING: Changing text page size changes the page style for endnotes, and hides part of the endnotes

2021-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145936

--- Comment #1 from LeroyG  ---
+ Steps to Reproduce
==
Before step 6, choose multi-page view and adjust zoom factor to view at least
two pages side-by-side (or set zoom factor to Entire Page or Fit width and
height).

+ Actual Results
==
After step 6:
[…] and Ctrl+Arrow Down (always holding down Shift).

The same in this environment:
Version: 7.1.7.2 / LibreOffice Community
Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: kf5
Locale: es-MX (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.