[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 Jacek Frączek changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |fraczek.ja...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307
--- Comment #8 from Stephan Bergmann ---
(In reply to Jacek Frączek from comment #7)
> Hi, since this is not assinged to anyone I have started working on it. Can
> removal of
> >T * operator &() const { return pObj; }
> also be included here?
That's a reasonable change too, but better do it in two different commits (that
can both be part of this easy hack).
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307
--- Comment #7 from Jacek Frączek ---
Hi, since this is not assinged to anyone I have started working on it. Can
removal of
>T * operator &() const { return pObj; }
also be included here?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307
--- Comment #6 from Stephan Bergmann ---
The problematic operator is the (non-explicit) conversion operator
>operator T *()const { return pObj; }
not the dereference operator
>T & operator *() const { assert(pObj != nullptr); return *pObj; }
All uses of the former operator, and the operator itself, shall be removed.
(There is no benefit in keeping it around defined as deleted. But it can be
useful to temporarily define it as deleted, to find places that use this
conversion operator.)
Replacing uses of the latter operator with get() is of no benefit. (But
removing the address-of operator
>T * operator &() const { return pObj; }
would be beneficial, as an overloaded address-of operator can be confusing.)
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 --- Comment #5 from Alexander Zaitsev --- If i correctly understood task, i should: 1) Remove all using SvRef::operator*() in LO sourcebase and replace to SvRef::get() 2) Remove from SvRef operator*() or mark it as deleted of simply remove this operator from SvRef. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 --- Comment #4 from Alexander Zaitsev --- Hello. Can i try to assign this bug to me? It will be my first bug. And i hope, that i can solve it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 Stephan Bergmann changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Stephan Bergmann --- Yes, looks reasonable. Ultimately, uses of SvRef (include/tools/ref.hxx) should be replaced with other smart pointers (the standard ones, or maybe LO's rtl::Reference), but for the time beeing this is probably a good clean up. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 jan iversen changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp Status|UNCONFIRMED |NEEDINFO CC||sberg...@redhat.com Ever confirmed|0 |1 --- Comment #2 from jan iversen --- I could, but this is one of those, where I rely on the opinion of our C++ gurus. Sounds logical to me, and if Stephan agrees, it should be made a easyhack. I am putting it on NEEDINFO for now (We also miss a ref. to where SvRef lives). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89307] remove SvRef::operator T*() replacing use with explicit access through SvRef::get()
https://bugs.documentfoundation.org/show_bug.cgi?id=89307 raal changed: What|Removed |Added CC||j...@documentfoundation.org ||, r...@post.cz --- Comment #1 from raal --- Jan, could you look? Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
