Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings v2

2012-06-14 Thread Pete Batard
The 2 Clang patches as well as the speed designation patch suggested by 
Xiaofan have now been pushed to git.

As changes were applied to core, if you have an opportunity to test 
before release, please do so. These warning fixes should be fairly safe, 
but you never know...

Official v1.0.12 release should occur in a little more than 24 hours now.

Regards,

/Pete

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel


Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings v2

2012-06-14 Thread Xiaofan Chen
On Thu, Jun 14, 2012 at 7:50 PM, Pete Batard p...@akeo.ie wrote:
 The 2 Clang patches as well as the speed designation patch suggested by
 Xiaofan have now been pushed to git.

 As changes were applied to core, if you have an opportunity to test
 before release, please do so. These warning fixes should be fairly safe,
 but you never know...

 Official v1.0.12 release should occur in a little more than 24 hours now.


I just did some quick tests under Mac OS X10.7.4 and it works fine.


-- 
Xiaofan

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel


Re: [Libusbx-devel] [PATCH 1/2] Core: Fix Clang warnings

2012-06-14 Thread Pete Batard
On 2012.06.13 19:19, Sean McBride wrote:
 Have you looked at the HTML that scan-build generates?

Good point. Now that looked at it more closely, it is possible to fix 
the issue at core.c:647 by switching a malloc to a calloc. What happens 
there is that Clang sees a path where we may have a devlist that 
contains no device whatsoever, and therefore remains uninitialised.

I'll propose a v2 of the patch that includes this fix as well.

I'm still investigating the timerisset() one.

Regards,

/Pete


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel