Re: [libvirt] [PATCH v4 6/7] Fixed indentation in src/conf/*_event*

[Daniel P. Berrange]

On Wed, Dec 11, 2013 at 11:38:03AM +0100, Cédric Bosdonnat wrote:
> ---
>  src/conf/domain_event.c | 286 
> +++-
>  src/conf/domain_event.h | 271 +
>  src/conf/object_event.c |  47 ---
>  src/conf/object_event_private.h |  20 +--
>  4 files changed, 364 insertions(+), 260 deletions(-)
> 
> diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
> index da57129..45e48b6 100644
> --- a/src/conf/domain_event.c
> +++ b/src/conf/domain_event.c
> @@ -443,11 +443,12 @@ virDomainEventCallbackListAdd(virConnectPtr conn,
>  }
>  
>  
> -static void *virDomainEventNew(virClassPtr klass,
> -   int eventID,
> -   int id,
> -   const char *name,
> -   const unsigned char *uuid)
> +static void
> +*virDomainEventNew(virClassPtr klass,

The '*' should be on the same line as the void.

> +   int eventID,
> +   int id,
> +   const char *name,
> +   const unsigned char *uuid)
>  {
>  virDomainEventPtr event;



> @@ -460,11 +464,12 @@ error:
>  return NULL;
>  }
>  
> -void *virObjectEventNew(virClassPtr klass,
> -int eventID,
> -int id,
> -const char *name,
> -const unsigned char *uuid)
> +void
> +*virObjectEventNew(virClassPtr klass,

And here

> +   int eventID,
> +   int id,
> +   const char *name,
> +   const unsigned char *uuid)
>  {
>  virObjectEventPtr event;
>  

> -void *virObjectEventNew(virClassPtr klass,
> -int eventID,
> -int id,
> -const char *name,
> -const unsigned char *uuid);
> +void
> +*virObjectEventNew(virClassPtr klass,

And here

> +   int eventID,
> +   int id,
> +   const char *name,
> +   const unsigned char *uuid);


ACK will fix those bugs.

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v4 6/7] Fixed indentation in src/conf/*_event*

[Cédric Bosdonnat]

---
 src/conf/domain_event.c | 286 +++-
 src/conf/domain_event.h | 271 +
 src/conf/object_event.c |  47 ---
 src/conf/object_event_private.h |  20 +--
 4 files changed, 364 insertions(+), 260 deletions(-)

diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index da57129..45e48b6 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/domain_event.c
@@ -443,11 +443,12 @@ virDomainEventCallbackListAdd(virConnectPtr conn,
 }
 
 
-static void *virDomainEventNew(virClassPtr klass,
-   int eventID,
-   int id,
-   const char *name,
-   const unsigned char *uuid)
+static void
+*virDomainEventNew(virClassPtr klass,
+   int eventID,
+   int id,
+   const char *name,
+   const unsigned char *uuid)
 {
 virDomainEventPtr event;
 
@@ -468,9 +469,12 @@ static void *virDomainEventNew(virClassPtr klass,
 return (virObjectEventPtr)event;
 }
 
-virObjectEventPtr virDomainEventLifecycleNew(int id, const char *name,
- const unsigned char *uuid,
- int type, int detail)
+virObjectEventPtr
+virDomainEventLifecycleNew(int id,
+   const char *name,
+   const unsigned char *uuid,
+   int type,
+   int detail)
 {
 virDomainEventLifecyclePtr event;
 
@@ -488,25 +492,36 @@ virObjectEventPtr virDomainEventLifecycleNew(int id, 
const char *name,
 return (virObjectEventPtr)event;
 }
 
-virObjectEventPtr virDomainEventLifecycleNewFromDom(virDomainPtr dom, int 
type, int detail)
+virObjectEventPtr
+virDomainEventLifecycleNewFromDom(virDomainPtr dom,
+  int type,
+  int detail)
 {
 return virDomainEventLifecycleNew(dom->id, dom->name, dom->uuid,
   type, detail);
 }
 
-virObjectEventPtr virDomainEventLifecycleNewFromObj(virDomainObjPtr obj, int 
type, int detail)
+virObjectEventPtr
+virDomainEventLifecycleNewFromObj(virDomainObjPtr obj,
+  int type,
+  int detail)
 {
 return virDomainEventLifecycleNewFromDef(obj->def, type, detail);
 }
 
-virObjectEventPtr virDomainEventLifecycleNewFromDef(virDomainDefPtr def, int 
type, int detail)
+virObjectEventPtr
+virDomainEventLifecycleNewFromDef(virDomainDefPtr def,
+  int type,
+  int detail)
 {
 return virDomainEventLifecycleNew(def->id, def->name, def->uuid,
   type, detail);
 }
 
-virObjectEventPtr virDomainEventRebootNew(int id, const char *name,
-  const unsigned char *uuid)
+virObjectEventPtr
+virDomainEventRebootNew(int id,
+const char *name,
+const unsigned char *uuid)
 {
 if (virDomainEventsInitialize() < 0)
 return NULL;
@@ -516,7 +531,8 @@ virObjectEventPtr virDomainEventRebootNew(int id, const 
char *name,
  id, name, uuid);
 }
 
-virObjectEventPtr virDomainEventRebootNewFromDom(virDomainPtr dom)
+virObjectEventPtr
+virDomainEventRebootNewFromDom(virDomainPtr dom)
 {
 if (virDomainEventsInitialize() < 0)
 return NULL;
@@ -526,7 +542,8 @@ virObjectEventPtr 
virDomainEventRebootNewFromDom(virDomainPtr dom)
  dom->id, dom->name, dom->uuid);
 }
 
-virObjectEventPtr virDomainEventRebootNewFromObj(virDomainObjPtr obj)
+virObjectEventPtr
+virDomainEventRebootNewFromObj(virDomainObjPtr obj)
 {
 if (virDomainEventsInitialize() < 0)
 return NULL;
@@ -536,8 +553,9 @@ virObjectEventPtr 
virDomainEventRebootNewFromObj(virDomainObjPtr obj)
  obj->def->id, obj->def->name, obj->def->uuid);
 }
 
-virObjectEventPtr virDomainEventRTCChangeNewFromDom(virDomainPtr dom,
-long long offset)
+virObjectEventPtr
+virDomainEventRTCChangeNewFromDom(virDomainPtr dom,
+  long long offset)
 {
 virDomainEventRTCChangePtr ev;
 
@@ -553,8 +571,9 @@ virObjectEventPtr 
virDomainEventRTCChangeNewFromDom(virDomainPtr dom,
 
 return (virObjectEventPtr)ev;
 }
-virObjectEventPtr virDomainEventRTCChangeNewFromObj(virDomainObjPtr obj,
-long long offset)
+virObjectEventPtr
+virDomainEventRTCChangeNewFromObj(virDomainObjPtr obj,
+  long long offset)
 {
 virDomainEventRTCChangePtr ev;
 
@@ -572,7 +591,9 @@ virObjectEventPtr 
virDomainEventRTCChangeNewFromObj(virDomainObjPtr obj,
 return (virObjectEventPtr)ev;
 }
 
-virObjectEve