[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info
- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
commit aec018d7d4ed58e6d67e4621019a6cf2936b212f (HEAD ->
pushed/issue-5336-grob-array-downcasting, origin/staging)
Author: Dan Eble
Date: Mon Jun 4 17:51:24 2018 -0400
Issue 5336: Remove downcasting methods from Grob_array and Grob_info
Presenting dynamic casts as simple getters was hiding something that
is better left in the open.
---
** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Sun Jun 10, 2018 03:16 PM UTC
**Owner:** Dan Eble
There are methods of `Grob_array` and `Grob_info` which are basically dynamic
casts with the added cost of a function call.
~~~
Item *
Grob_array::item (vsize i)
{
return dynamic_cast (grobs_.at (i));
}
~~~
Making this operation more convenient to type is a rather perverse incentive.
These methods should probably be abolished.
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()
- **labels**: --> Fixed_2_21_0 - **status**: Started --> Fixed - **Patch**: push --> - **Comment**: commit 23534338bce94508ddbfbbbd4a746619eb403fd5 (HEAD -> pushed/issue-5335-grob-clone-covariance, origin/staging) Author: Dan Eble Date: Sun Jun 3 19:23:14 2018 -0400 Issue 5335/2: Remove other unnecessary dynamic_casts unrelated to the previous commit commit 2164bfe5d73b9a660627f43c001ea69453680d68 Author: Dan Eble Date: Sun Jun 3 18:30:17 2018 -0400 Issue 5335/1: Use covariant return types on virtual Grob::clone() and remove unnecessary dynamic_casts. --- ** [issues:#5335] Use covariant return types on virtual Grob::clone()** **Status:** Fixed **Labels:** Fixed_2_21_0 **Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble **Last Updated:** Sun Jun 10, 2018 03:14 PM UTC **Owner:** Dan Eble Use covariant return types on virtual Grob::clone() ... and remove unnecessary dynamic_casts. The casts in the parser were not Grob-related, but since they turned up during my search, I removed them too. http://codereview.appspot.com/341320043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser
The patch is ok. It eliminates an obvious and easily exploitable security problem. --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Sun Jun 10, 2018 03:24 PM UTC **Owner:** pkx166h **Attachments:** - [0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch) (1.3 kB; text/x-patch) Don Armstrong - 2018-05-11 I have just uploaded a fix to Debian which switches to using system* instead of system: https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78 Not sure if this is cross-platform enough, but it solves the issue for systems with a working system* call. --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5334 Use system* instead of system when invoking browser
- **Patch**: needs_work --> new --- ** [issues:#5334] Use system* instead of system when invoking browser** **Status:** Started **Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h **Last Updated:** Sun Jun 10, 2018 03:20 PM UTC **Owner:** pkx166h **Attachments:** - [0001-use-system-instead-of-system.patch](https://sourceforge.net/p/testlilyissues/issues/5334/attachment/0001-use-system-instead-of-system.patch) (1.3 kB; text/x-patch) Don Armstrong - 2018-05-11 I have just uploaded a fix to Debian which switches to using system* instead of system: https://salsa.debian.org/debian/lilypond/commit/788b56e4b7f62637481af65b4b2929649c30fe78 Not sure if this is cross-platform enough, but it solves the issue for systems with a working system* call. --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5337 Create Bottom contexts in a more general way
- **Patch**: review --> countdown - **Comment**: Patch on countdown for June 13th. --- ** [issues:#5337] Create Bottom contexts in a more general way** **Status:** Started **Created:** Tue Jun 05, 2018 04:59 PM UTC by Dan Eble **Last Updated:** Thu Jun 07, 2018 04:36 PM UTC **Owner:** Dan Eble Create Bottom contexts in a more general way Moving special treatment of "Bottom" into path_to_acceptable_context () makes it effective during calls to create_unique_context (), which is the basis of \new and (now) get_default_interpreter (). http://codereview.appspot.com/339710043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5336 Expose hidden dynamic_casts in Grob_array and Grob_info
- **Patch**: countdown --> push
- **Comment**:
Patch counted down - please push.
---
** [issues:#5336] Expose hidden dynamic_casts in Grob_array and Grob_info**
**Status:** Started
**Created:** Tue Jun 05, 2018 03:03 AM UTC by Dan Eble
**Last Updated:** Thu Jun 07, 2018 03:47 PM UTC
**Owner:** Dan Eble
There are methods of `Grob_array` and `Grob_info` which are basically dynamic
casts with the added cost of a function call.
~~~
Item *
Grob_array::item (vsize i)
{
return dynamic_cast (grobs_.at (i));
}
~~~
Making this operation more convenient to type is a rather perverse incentive.
These methods should probably be abolished.
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5333 musicxml2ly: hidden timesigs and tempo marks with text.
- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (based against current master) and I can push it for you. --- ** [issues:#5333] musicxml2ly: hidden timesigs and tempo marks with text.** **Status:** Started **Created:** Fri Jun 01, 2018 11:49 AM UTC by Alex Myltsev **Last Updated:** Thu Jun 07, 2018 03:47 PM UTC **Owner:** Alex Myltsev musicxml2ly: hidden timesigs and tempo marks with text. http://codereview.appspot.com/34443 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5335 Use covariant return types on virtual Grob::clone()
- **Patch**: countdown --> push - **Comment**: Patch counted down - please push. --- ** [issues:#5335] Use covariant return types on virtual Grob::clone()** **Status:** Started **Created:** Mon Jun 04, 2018 12:35 AM UTC by Dan Eble **Last Updated:** Thu Jun 07, 2018 03:47 PM UTC **Owner:** Dan Eble Use covariant return types on virtual Grob::clone() ... and remove unnecessary dynamic_casts. The casts in the parser were not Grob-related, but since they turned up during my search, I removed them too. http://codereview.appspot.com/341320043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs
- **Patch**: new --> review --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Sun Jun 10, 2018 01:02 PM UTC **Owner:** Knut Petersen Fix out-of-sync LilyScriptEncoding / ps script defs Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong. I did not care about the 80-characters per line limit, it is easier to maintain this format. The glyphs are now included in the order in which they are included in the emmentaler fonts. The order of the glyphs does not matter as long as the encoding vector and the corresponding commands match. The change occured because I decided to use otfinfo and sed to generate the new code, it seemed easier, safer and faster than correcting the old code by hand. Signed-off-by: Knut Petersen http://codereview.appspot.com/347870043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs
Passes make, make check and a full make doc. Reg test diff attached Attachments: - [5338_regtestdiff.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/39a197cb/73ff/attachment/5338_regtestdiff.png) (49.4 kB; image/png) --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Sun Jun 10, 2018 12:26 PM UTC **Owner:** Knut Petersen Fix out-of-sync LilyScriptEncoding / ps script defs Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong. I did not care about the 80-characters per line limit, it is easier to maintain this format. The glyphs are now included in the order in which they are included in the emmentaler fonts. The order of the glyphs does not matter as long as the encoding vector and the corresponding commands match. The change occured because I decided to use otfinfo and sed to generate the new code, it seemed easier, safer and faster than correcting the old code by hand. Signed-off-by: Knut Petersen http://codereview.appspot.com/347870043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5338 Fix out-of-sync LilyScriptEncoding / ps script defs
- Description has changed: Diff: --- old +++ new @@ -3,8 +3,7 @@ Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. -This patch will not pass 'make check', but this is ok -as the current state is wrong. +This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong. I did not care about the 80-characters per line limit, it is easier to maintain this format. - **Needs**: --> --- ** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs** **Status:** Started **Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen **Last Updated:** Fri Jun 08, 2018 09:49 AM UTC **Owner:** Knut Petersen Fix out-of-sync LilyScriptEncoding / ps script defs Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. This patch will pass 'make test-baseline/check', but visually the reg testdifferences that do occur are wrong. I did not care about the 80-characters per line limit, it is easier to maintain this format. The glyphs are now included in the order in which they are included in the emmentaler fonts. The order of the glyphs does not matter as long as the encoding vector and the corresponding commands match. The change occured because I decided to use otfinfo and sed to generate the new code, it seemed easier, safer and faster than correcting the old code by hand. Signed-off-by: Knut Petersen http://codereview.appspot.com/347870043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
