Re: PATCHES: 48-hour notice for event listener docs, ignoring note-heads, and spacing with empty contexts

2011-06-07 Thread m...@apollinemike.com
On Jun 7, 2011, at 12:45 AM, Carl Sorensen wrote:

 
 
 
 On 6/6/11 12:16 PM, Graham Percival gra...@percival-music.ca wrote:
 
 Wed, 20:00.
 
 
 Doc: writing music events to a .notes file
 http://codereview.appspot.com/4438054/
 
 Allows LilyPond to ignore certain note-heads in a stem
 http://codereview.appspot.com/4547058/
 
 I thought this patch was withdrawn.  See
 http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/36499

Confirmed - I'll take it off code-review (unless anyone can think of a reason 
to keep it).

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Gives each grob an integer hash. (issue4515166)

2011-06-07 Thread m...@apollinemike.com
Fair enough.  I used it for a few rather esoteric experiments w/ algorithmic 
composition - it's true that the utility of such a feature is limited to 
hardcore tweaking.

Cheers,
MS

On Jun 7, 2011, at 6:05 AM, Han-Wen Nienhuys wrote:

 We had something like this a long time ago.  Search for Object_key
 in the history, eg. commit 4a964b10c411827584eb720c63cd0d6fc5b65d72.
 
 This was intended for making persistent tweaks,  but it never got used
 so we scrapped it.
 
 I'm on a holiday, so I dont have time to look into this, but it seems
 a less versatile reimplementation of what we scrapped, so I am
 skeptical that this should be included this for general distribution.
 
 
 On Tue, May 31, 2011 at 12:57 PM,  mts...@gmail.com wrote:
 Reviewers: ,
 
 Message:
 This patch'll be useful for some advanced tweaks I'm doing while running
 LilyPond in multiple passes.  Lemme know if it looks all right.
 
 
 
 -- 
 Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New alist to replace special characters. (issue4553056)

2011-06-07 Thread bordage . bertrand


http://codereview.appspot.com/4553056/diff/9003/input/regression/markup-special-characters.ly
File input/regression/markup-special-characters.ly (right):

http://codereview.appspot.com/4553056/diff/9003/input/regression/markup-special-characters.ly#newcode7
input/regression/markup-special-characters.ly:7:
#(define-markup-list-command (show-special-characters layout props) ()
It was a way to remember this piece of code. I will not do all the
documentation before deciding if the list remains.
Anyway, there are other examples of such lists in regression testing.
For example, 'chord-name-entry' or 'woodwind-diagrams-empty'.

http://codereview.appspot.com/4553056/diff/9003/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4553056/diff/9003/scm/output-lib.scm#newcode958
scm/output-lib.scm:958: ; Punctuation
I understand your concerns and I'm a little embarrassed to introduce a
new syntax for the risk of disrupting the users understanding. But it
also lacks a lot of people.
In the list, I added the characters which are not allocated in the
French Linux keyboard (except the ellipsis, the non-breaking space and
the dashes).
It does bother me however to remove this list.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New alist to replace special characters. (issue4553056)

2011-06-07 Thread mtsolo


http://codereview.appspot.com/4553056/diff/9003/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4553056/diff/9003/scm/output-lib.scm#newcode958
scm/output-lib.scm:958: ; Punctuation
On 2011/06/07 09:45:12, Bertrand Bordage wrote:

I understand your concerns and I'm a little embarrassed to introduce a

new

syntax for the risk of disrupting the users understanding. But it also

lacks a

lot of people.
In the list, I added the characters which are not allocated in the

French Linux

keyboard (except the ellipsis, the non-breaking space and the dashes).
It does bother me however to remove this list.


It may be worth testing this out on multiple platforms - I've sometimes
had difficulty opening up my .ly files on Windows machines if they
contain special characters.  To what extent is UTF-8 easy to work with
outside of a posix environment?

In general, one way to work this into LilyPond may be to include the
basic functionality, send the string-replacement-alist out to
lilypond-user, and see to what extent people desire to use it.  I've
done this for a couple things and been able to scrap/add functionalities
accordingly.  If it seems like it's something that many people would
want to use, then it should probably be part of the distro.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: missing contributors/developers

2011-06-07 Thread Graham Percival
On Tue, Jun 07, 2011 at 09:56:39AM +1000, Peter Chubb wrote:
 Graham I believe that a few people are missing from the authors list.
 Graham We've asked for names a few times in the past 2.5 years, but
 Graham the last time was in early January:
 
 My name should probably be in there somewhere.  I did the first
 otttava-clef implementation (10 years ago?), and currently attempt to
 maintain articulate.

ok, added.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Git not working

2011-06-07 Thread Graham Percival
On Mon, Jun 06, 2011 at 06:39:18PM +0100, Phil Holmes wrote:
 I've clicked the Update Source on a number of occasions, and
 generally the script just sits there with no activity.

Yes, I see this too.  I think it's
http://code.google.com/p/lilypond/issues/detail?id=1615

 and then a load of tags added and then an error:
 
 * [new tag] release/2.9.7 - release/2.9.7
 * [new tag] tarball/HEAD - tarball/HEAD
 * [new tag] tarball/start - tarball/start
 |git --git-dir=/home/phil/lilypond-git/.git rebase origin/master 2@1
 fatal: bad revision 'HEAD'
 fatal: Needed a single revision

Sadly, I can't even get far enough to see this error.  :(


It would be really great if a git person could look into this
stuff.  An inability to reliably get the source code is extremely
problematic for an open-source project.  If for some reason it's
impossible to use
  git fetch --depth 1
reliably on savannah, then I think we should drop that and go with
git clone, if that works more reliably.

At this stage, I'll settle for 50% reliability... i.e. if it
doesn't do anything within 5 minutes, then cancel it and try it
again, and it will probably work the second or third time.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Git not working

2011-06-07 Thread Phil Holmes
- Original Message - 
From: Graham Percival gra...@percival-music.ca

To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Tuesday, June 07, 2011 12:24 PM
Subject: Re: Git not working



Sadly, I can't even get far enough to see this error.  :(


I now get a consistent:

|git --git-dir=/home/phil/lilypond-git/.git fetch origin 2@1

From git://git.sv.gnu.org/lilypond

  19d102a..3091c3e  master - origin/master
|git --git-dir=/home/phil/lilypond-git/.git rebase origin/master 2@1
fatal: bad revision 'HEAD'
fatal: Needed a single revision
Done.


Any ideas?

--
Phil Holmes




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Git not working

2011-06-07 Thread Reinhold Kainhofer
Am Dienstag, 7. Juni 2011, 13:45:58 schrieb Phil Holmes:
 I now get a consistent:
 |git --git-dir=/home/phil/lilypond-git/.git fetch origin 2@1
 |
 From git://git.sv.gnu.org/lilypond
 
19d102a..3091c3e  master - origin/master
 
 |git --git-dir=/home/phil/lilypond-git/.git rebase origin/master 2@1
 
 fatal: bad revision 'HEAD'
 fatal: Needed a single revision
 Done.
 
 
 Any ideas?

No ideas. Here it is working just fine:
reinhold@einstein:~/lilypond/lilypond$ git fetch origin
remote: Counting objects: 89, done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 52 (delta 36), reused 6 (delta 3)
Unpacking objects: 100% (52/52), done.
From ssh://git.sv.gnu.org/srv/git/lilypond
   bcfbe94..2940cdd  lilypond/translation - origin/lilypond/translation
   19d102a..8212a67  master - origin/master
   81ee37e..8126863  release/unstable - origin/release/unstable


Cheers,
Reinhold

-- 
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial  Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: NR rewrite of 3.2 Titles and Headers (issue4124056)

2011-06-07 Thread pkx166h

On 2011/05/04 17:08:39, Carl wrote:

Looks mostly good to me.



Carl



http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely

File Documentation/notation/input.itely (right):



http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667

Documentation/notation/input.itely:667: Text fields left unset in a
@code{\header} block are replaced with
This paragraph has three different ideas -- null markups, piece and

opus, and

forcing titles to start on a new page.



They should probably be separated into three different paragraphs.



http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode937

Documentation/notation/input.itely:937:
Need @seealso for the @ref in this node -- Title blocks explained,

Default

layout of book and score title blocks,.



http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode987

Documentation/notation/input.itely:987: @end lilypond
Need @seealso here, with all of the @ref in this node (Default layout

of book

and title blocks).


Carl, I have done this now (and the one above). We only really focused
on the 'first half' of the text that Mark did (and also hammer out all
the @lilypond settings too).

I am going to close this issue - I left it open only because I
remembered you wanted some additions that were not going to be in the
main patch, and open a new one with these and other changes. I also
wanted to make some more 'edits' to this text once the major changes
were done to keep some layout and style consistency.

http://codereview.appspot.com/4124056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Redirects lilypond output to reduce make doc noise (issue4550119)

2011-06-07 Thread PhilEHolmes

Reviewers: Graham Percival,

Message:
Please review this proposed change to the build system.
The change reduces the amount of un-needed information
echoed to the screen during make doc.

Description:
Redirects lilypond output to reduce make doc noise

Redirects the output from lilypond when lily is run from lilypond-book
as part of make doc.  Normal output goes to *.log, error output to
*.err.log.

Note that this looks more complex than needed, since redirecting output
appears to stop normal process monitoring, so I've had to use
process.poll.
I have tested this, and a polling rate of once per second does not
slow compilation significantly - most files take 100s of seconds to
compile.

Please review this at http://codereview.appspot.com/4550119/

Affected files:
  M make/ly-rules.make
  M python/lilylib.py
  M scripts/lilypond-book.py


Index: make/ly-rules.make
diff --git a/make/ly-rules.make b/make/ly-rules.make
index  
0df0643ee3158ec5ad2c0a685d752942ea30d18e..a876b04f1864ea548e03997b35aecccbed5bbcbd  
100644

--- a/make/ly-rules.make
+++ b/make/ly-rules.make
@@ -22,11 +22,11 @@ $(eval $(firstword $(TEXI_FILES_FROM_TELY)):\
 # don't do ``cd $(outdir)'', and assume that $(outdir)/.. is the src dir.
 # it is not, for --srcdir builds
 $(outdir)/%.texi: %.tely $(outdir)/version.itexi  
$(DOCUMENTATION_LOCALE_TARGET) $(INIT_LY_SOURCES) $(SCHEME_SOURCES)
-	LILYPOND_VERSION=$(TOPLEVEL_VERSION) $(PYTHON) $(LILYPOND_BOOK)  
$(LILYPOND_BOOK_INCLUDES) --process='$(LILYPOND_BOOK_PROCESS)  
$(LILYPOND_BOOK_LILYPOND_FLAGS)' --output=$(outdir)  
--format=$(LILYPOND_BOOK_FORMAT) $(LILYPOND_BOOK_FLAGS) $
+	LILYPOND_VERSION=$(TOPLEVEL_VERSION) $(PYTHON) $(LILYPOND_BOOK)  
$(LILYPOND_BOOK_INCLUDES) --process='$(LILYPOND_BOOK_PROCESS)  
$(LILYPOND_BOOK_LILYPOND_FLAGS)' --output=$(outdir)  
--format=$(LILYPOND_BOOK_FORMAT) $(LILYPOND_BOOK_FLAGS)  
--redirect-lilypond-output $



 $(outdir)/%.texi: $(outdir)/%.tely $(outdir)/version.itexi  
$(DOCUMENTATION_LOCALE_TARGET) $(INIT_LY_SOURCES) $(SCHEME_SOURCES)
-	LILYPOND_VERSION=$(TOPLEVEL_VERSION) $(PYTHON) $(LILYPOND_BOOK)  
$(LILYPOND_BOOK_INCLUDES) --process='$(LILYPOND_BOOK_PROCESS)  
$(LILYPOND_BOOK_INCLUDES) $(LILYPOND_BOOK_LILYPOND_FLAGS)'  
--output=$(outdir) --format=$(LILYPOND_BOOK_FORMAT) $(LILYPOND_BOOK_FLAGS)  
$
+	LILYPOND_VERSION=$(TOPLEVEL_VERSION) $(PYTHON) $(LILYPOND_BOOK)  
$(LILYPOND_BOOK_INCLUDES) --process='$(LILYPOND_BOOK_PROCESS)  
$(LILYPOND_BOOK_INCLUDES) $(LILYPOND_BOOK_LILYPOND_FLAGS)'  
--output=$(outdir) --format=$(LILYPOND_BOOK_FORMAT) $(LILYPOND_BOOK_FLAGS)  
--redirect-lilypond-output $



 $(outdir)/%.html.omf: %.tely
Index: python/lilylib.py
diff --git a/python/lilylib.py b/python/lilylib.py
index  
6fb96bbbf59959fccdc19a15cd846785a5befb0a..223af43138e01784fc01ab62140633e78e657315  
100644

--- a/python/lilylib.py
+++ b/python/lilylib.py
@@ -23,6 +23,7 @@ import re
 import shutil
 import sys
 import optparse
+import time

 
 # Users of python modules should include this snippet
@@ -118,6 +119,7 @@ def subprocess_system (cmd,
ignore_error=False,
progress_p=True,
be_verbose=False,
+   redirect_output=False,
log_file=None):
 import subprocess

@@ -125,16 +127,25 @@ def subprocess_system (cmd,
 name = command_name (cmd)
 error_log_file = ''

-if be_verbose:
-   show_progress = 1
-   progress (_ (Invoking `%s\') % cmd)
+if redirect_output:
+progress (_ (Processing %s.ly) % log_file)
 else:
-   progress ( _(Running %s...) % name)
-
+if be_verbose:
+show_progress = 1
+progress (_ (Invoking `%s\') % cmd)
+else:
+progress ( _(Running %s...) % name)

 stdout_setting = None
+stderr_setting = None
 if not show_progress:
-   stdout_setting = subprocess.PIPE
+stdout_setting = subprocess.PIPE
+
+if redirect_output:
+stdout_filename = ' '.join([log_file, '.log'])
+stderr_filename = ' '.join([log_file, '.err.log'])
+stdout_setting = open(stdout_filename, 'w')
+stderr_setting = open(stderr_filename, 'w')

 proc = subprocess.Popen (cmd,
 shell=True,
@@ -144,11 +155,18 @@ def subprocess_system (cmd,

 log = ''

-if show_progress:
-   retval = proc.wait()
+if redirect_output:
+while proc.poll()==None:
+time.sleep(1)
+retval = proc.returncode
+stdout_setting.close()
+stderr_setting.close()
 else:
-   log = proc.communicate ()
-   retval = proc.returncode
+if show_progress:
+retval = proc.wait()
+else:
+log = proc.communicate ()
+retval = proc.returncode


 if retval:
Index: scripts/lilypond-book.py
diff --git a/scripts/lilypond-book.py b/scripts/lilypond-book.py
index  

Re: Redirects lilypond output to reduce make doc noise (issue4550119)

2011-06-07 Thread percival . music . ca

hmm, on my machine this creates a log file like:
  snippets-names-173988768 .err.log
(note the space)
in the main dir.  Instead of that, could we:
1) not have a space
2) direct the log for each file to the corresponding .ly file?  I mean,
I see
  15/lily-f332c4db.ly
(you'll have different numbers for your stuff)

I'd like the output for
  15/lily-f332c4db.ly
to be written to
  15/lily-f332c4db.err.log
  15/lily-f332c4db.log
(maybe even .std.log ?)


it might also be good to consider the lilypond-book (and lilylib) patch
separately from the build system.  For example, just test it with
  out/bin/lilypond-book foo.tely
(after making a foo.tely) and make sure the log files work with that.
Then, once the lilypond-book patch is pushed, add it to the build
system.



http://codereview.appspot.com/4550119/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Redirects lilypond output to reduce make doc noise (issue4550119)

2011-06-07 Thread Phil Holmes
- Original Message - 
From: percival.music...@gmail.com

To: philehol...@googlemail.com
Cc: lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Sent: Tuesday, June 07, 2011 4:11 PM
Subject: Re: Redirects lilypond output to reduce make doc noise 
(issue4550119)




hmm, on my machine this creates a log file like:
  snippets-names-173988768 .err.log
(note the space)
in the main dir.  Instead of that, could we:
1) not have a space



The space is a bug that I'd not noticed - it comes from using the .join() 
function to concatenate, which is faster but since I copied another line 
which used ' '.join and not ''.join, then you get the added space.  You get 
the same for the logfile.  I think I can correct this by simply correcting 
the relevant file, create a new patch and re-upload?  This will upload the 
full set of changes, not just the correction for this bug.



2) direct the log for each file to the corresponding .ly file?  I mean,
I see
  15/lily-f332c4db.ly
(you'll have different numbers for your stuff)
I'd like the output for
  15/lily-f332c4db.ly
to be written to
  15/lily-f332c4db.err.log
  15/lily-f332c4db.log
(maybe even .std.log ?)



I don't know how you'd do this.  AFAICS there is only a single call to 
lilypond with the command line being the snippet-names file.  This file has 
a long list of included lilypond files, which I presume lilypond processes 
internally.  There is therefore no separate output to redirect.



it might also be good to consider the lilypond-book (and lilylib) patch
separately from the build system.  For example, just test it with
  out/bin/lilypond-book foo.tely
(after making a foo.tely) and make sure the log files work with that.
Then, once the lilypond-book patch is pushed, add it to the build
system.



http://codereview.appspot.com/4550119/


That's how I did my testing.  TBH the change to the build system 
(effectively adding one word) is so small it's not worth separating them.


--
Phil Holmes



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


[PATCH] Fix key signatures with cue clefs

2011-06-07 Thread Reinhold Kainhofer
CueClefs: Use middleCClefPosition in the key engraver

Otherwise the key signature would use the middle staff position of the cue part
(so the keysignature would be printed as if it were in the cue clef rather 
than the real clef), which is not what we want.

Please review:
http://codereview.appspot.com/4551101

Cheers,
Reinhold
-- 
--
Reinhold Kainhofer, Vienna University of Technology, Austria
email: reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * Edition Kainhofer Music Publishing, http://www.edition-kainhofer.com/
 * LilyPond music typesetting software, http://www.lilypond.org/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-07 Thread percival . music . ca

thanks, added as
http://code.google.com/p/lilypond/issues/detail?id=1684

http://codereview.appspot.com/4551101/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-07 Thread Carl . D . Sorensen

LGTM.

Carl

http://codereview.appspot.com/4551101/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: parameters in metafont files

2011-06-07 Thread Carl Sorensen
On 6/1/11 9:39 AM, Janek Warchoł lemniskata.bernoull...@gmail.com wrote:


 
 Please help!



I'm not ignoring you, but I have no idea on this!

I'm sorry,

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: make doc

2011-06-07 Thread Carl Sorensen



On 5/30/11 12:56 PM, Phil Holmes m...@philholmes.net wrote:

 - Original Message -
 From: Graham Percival gra...@percival-music.ca
 To: Phil Holmes m...@philholmes.net
 Cc: Carl Sorensen c_soren...@byu.edu; lilypond-devel@gnu.org
 Sent: Saturday, May 28, 2011 6:22 PM
 Subject: Re: make doc
 
 
 On Sat, May 28, 2011 at 05:48:39PM +0100, Phil Holmes wrote:
 
 So the command line would need to be something like
 lilypond filename.ly  filename.log?
 
 Something like that, probably.  Dunno.  What happens when you try
 that command on the command-line?
 
 Remember the first rule of build systems: a build system just sets
 up the environment and then runs command-line commands.  (no wait,
 that's the second rule.  The first rule is that all build systems
 suck; most of them suck exponentially.)
 
 Will have to look at how that could be done, since the times lily is
 called that I've so far found are initiated by lilypond-book.
 
 Well, figure out how to do it with lilypond by itself, then figure
 out how to do it with lilypond-book, then figure out how to do it
 inside the build system.
 
 Cheers,
 - Graham
 
 
 OK - so I now know how to redirect the output from lilypond-book.py when
 it's making, for example, collated-files.tely - I can redirect it to
 collated-files.log.  FWIW simply doing the redirect on
 /input/regression/out-www/collated-files.tely creates a logfile of 30 Meg
 and 68,000-odd lines!  I think this is a good first step.  For those who are
 interested in the build system, I attach my notes to date of how make doc
 works - slightly stream-of-consciousness, I'm afraid.

Phil, I'd like to see this dumped in the CG, even in its current
stream-of-consciousness form.  I'll put it in if you'd like.

Thanks,

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


developer IRC or skype chat

2011-06-07 Thread Graham Percival
Anybody interested in setting up a weekly chat?  Either IRC or
skype or some other chat protocol.

The idea is that we'd pick some time (say, 19:00 UTC on Tuesdays),
then whoever wanted to hang out could come by.  Or, if there's
enough interested (particularly from people in time zones which
don't work well with 19:00 UTC), we could have two chats at
different times.


I have a bias against voice chat since I'm much better at typing
than speaking, but if there's more interest in the human touch
of speech, I'm still game.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New alist to replace special characters. (issue4553056)

2011-06-07 Thread nicolas . sceaux

A replacement function for text is a very good idea, and would be very
useful.

General comments:
A regtest for lyrics might be missing.

The current implementation of replacement function, in the C++ part,
need some rework.

An alternate design might be:
Define in the guile part the replacement function. The C++ code would
just call that function on the string. By default, the replacement
function could do exactly the job that is done in current LilyPond
version (replacing line feeds, etc, by spaces).
Another replacement function would be proposed, doing the work you
propose here, e.g. compiling and applying a regexp, instead of manually
implementing the replacement (in a possibly less efficient way than the
built-in would do).
And a \useTheFancyTextReplacementThing switch could select the later
replacement function.
(just brainstorming)

If the second replacement function has not much impact on performances,
it may even be the default.


http://codereview.appspot.com/4553056/diff/9003/input/regression/markup-special-characters-shorthands.ly
File input/regression/markup-special-characters-shorthands.ly (right):

http://codereview.appspot.com/4553056/diff/9003/input/regression/markup-special-characters-shorthands.ly#newcode15
input/regression/markup-special-characters-shorthands.ly:15:
(additional-replacements text-font-defaults
The interface for adding replacements/shortcuts seems a bit complicated.
Maybe a function call modifying text-font-defaults behind the scene
would be better?

#(add-text-replacements! '(...))

http://codereview.appspot.com/4553056/diff/9003/lily/text-interface.cc
File lily/text-interface.cc (right):

http://codereview.appspot.com/4553056/diff/9003/lily/text-interface.cc#newcode46
lily/text-interface.cc:46: for (int j = 0; j  scm_to_int (scm_length
(replacement_alist)); j++)
This is not the way to loop over a list: the idiom can be found many
times in the C++ code. scm_length and scm_list_ref are O(n).

What's more, at this point the `str' argument is not yet used. So maybe
this could be cached to avoid being computed again each time.

http://codereview.appspot.com/4553056/diff/9003/lily/text-interface.cc#newcode62
lily/text-interface.cc:62: str-replace (i, j, ligature);
We see three embedded loops: while, for, and a call to ly_assoc_get...
The previous add only one loop.
What is the impact on performance, wrt to current version?

Have you considered compiling (and caching) a regexp and use the
appropriate builtin function which will do all the replacement work?

Or maybe... get this remplacement part out of C++ code, and define in
the scheme part a replacement function, that will be called here. A
default replacement function might do the \n, \t \v replacement alone
(as on current version). An other replacement function would be proposed
which does more complicated things.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: parameters in metafont files

2011-06-07 Thread Carl Sorensen
On 6/1/11 9:39 AM, Janek Warchoł lemniskata.bernoull...@gmail.com wrote:

 Hi again :)
 
 Congrats on 0 criticals!
 
 I have a question about parameters in metafont files: i want to create
 something similar to mf/out/feta20.otf-table, but i don't understand how it's
 done (i tried to find bbox and attachment in mf files or
 scripts/build/gen-emmentaler-scripts.py, but there are no results). I also
 tried adding
 autometric_parameter (someBogusName, someValue);
 inside mf code, but there were no results.
 Here is roughly what i want to achieve:
 add a magical command to feta-flags.mf
 
 fet_beginchar (8th Flag (up), u3);
 [...] % flags.u3 definition
 magical_command (arbitraryRealValueChosenByMe);
 fet_endchar;
 
 fet_beginchar (16th Flag (up), u4);
 [...] % flags.u4 definition
 magical_command (anotherArbitraryRealValueChosenByMe);
 fet_endchar;
 
 [...]
 
 and have it output a flags.otf-table file looking like this
 
 (flags .
 (u .
 ((3 . (arbitraryRealValueChosenByMe))
 (4 . (anotherArbitraryRealValueChosenByMe))
 [...] ))
 .
 (d .
 [...] )))
 
 Please help!


After looking more at this, it appears that the .otf-table files are created
by parsing the log files created during font creation.  See
scripts/build/mf-to-table.py

So this means that your magic command would need to emit a keyword and a
real value to the log file, and mf-to-table.py would need to be modified to
read the keyword and the value and put it in the table file.

HTH,

Carl

 Janek


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Redirects lilypond output to reduce make doc noise (issue4550119)

2011-06-07 Thread percival . music . ca

On 2011/06/07 15:23:53, email_philholmes.net wrote:

I think I can correct this by simply correcting
the relevant file, create a new patch and re-upload?


Please do amend previous commit instead, but yes, that's how to do it.


This will upload the
full set of changes, not just the correction for this bug.


Yes, but the reitveld interface takes care of that.


   15/lily-f332c4db.ly
 to be written to
   15/lily-f332c4db.log



I don't know how you'd do this.  AFAICS there is only a single call to



lilypond with the command line being the snippet-names file.


Ouch.  ok, so the way that it would be done would be by screwing around
in the scm/ or possibly even lily/ dir.  Forget it; that's too much work
for you and me.

(if somebody else wants to jump in and handle that stuff, that'd be
great!  But even without that, Phil's patch is a huge improvement over
the status quo, so we'll proceed with it)


TBH the change to the build system
(effectively adding one word) is so small it's not worth separating

them.

True.


ok, just make that one change, upload, and it should be good.

Cheers,
- Graham

http://codereview.appspot.com/4550119/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


./autogen.sh error: C++ preprocessor /lib/cpp fails sanity check

2011-06-07 Thread Villum Sejersen

Hello

I am sending this to devel, because it is about the configure script.

For several years I have compiled Lilypond development version from the 
git master branch, keeping the stable version alongside as a backup. 
This is easily done in Debian.


A few days ago I had to move my main installation to a new hard-disk, 
first installing from scratch Debian 6.0.1a (Squeeze), updating, and 
then installing the various applications needed for building lilypond. I 
have done these steps several times before.


However, running (as root) ./autogen.sh I now get the following error 
message:

===
root@Villums12:/usr/local/src/lilypond# ./autogen.sh
.
checking how to run the C++ preprocessor... /lib/cpp
configure: error: in `/usr/local/src/lilypond':
configure: error: C++ preprocessor /lib/cpp fails sanity check
See `config.log' for more details
===
and the script ends here without finishing.

First check:
===
root@Villums12:/usr/local/src/lilypond# cpp --version
cpp (Debian 4.4.5-8) 4.4.5
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
===
Anything apparently wrong there?

Next, looking into config.log I find some strange-looking lines like the 
following:

===
configure:4777: gpp -qversion 5

configure:4811: gpp -c   conftest.cpp 5
stdin:1: error: character not allowed to start a syntax specifier
===
Anything not intended there? gpp seems to have no directly callable -c 
or -q options?


--
Villum Sejersen
Nørregade  1 A
DK-4500  Nykøbing Sj. - Danmark
mobil+45   30 34  03 44


This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by configure, which was
generated by GNU Autoconf 2.67.  Invocation command line was

  $ ./configure 

## - ##
## Platform. ##
## - ##

hostname = Villums12
uname -m = x86_64
uname -r = 2.6.32-5-amd64
uname -s = Linux
uname -v = #1 SMP Wed May 18 23:13:22 UTC 2011

/usr/bin/uname -p = unknown
/bin/uname -X = unknown

/bin/arch  = unknown
/usr/bin/arch -k   = unknown
/usr/convex/getsysinfo = unknown
/usr/bin/hostinfo  = unknown
/bin/machine   = unknown
/usr/bin/oslevel   = unknown
/bin/universe  = unknown

PATH: /usr/local/sbin
PATH: /usr/local/bin
PATH: /usr/sbin
PATH: /usr/bin
PATH: /sbin
PATH: /bin


## --- ##
## Core tests. ##
## --- ##

configure:2284: checking build system type
configure:2298: result: x86_64-unknown-linux-gnu
configure:2318: checking host system type
configure:2331: result: x86_64-unknown-linux-gnu
configure:2385: checking Package
configure:2410: result: LILYPOND
configure:2413: checking builddir
configure:2425: result: /usr/local/src/lilypond
configure:2428: checking for stepmake
configure:2436: result: ./stepmake  (${datarootdir}/stepmake not found)
configure:2510: checking for gmake
configure:2540: result: no
configure:2510: checking for make
configure:2526: found /usr/bin/make
configure:2537: result: make
configure:2659: checking for find
configure:2675: found /usr/bin/find
configure:2686: result: find
configure:2809: checking for tar
configure:2825: found /bin/tar
configure:2836: result: tar
configure:3088: checking for bash
configure:3119: result: /bin/bash
configure:3132: checking for python
configure:3135: result: python
configure:3144: checking python version
configure:3207: result: 2.6.6
configure:3234: checking for python
configure:3252: found /usr/bin/python
configure:3264: result: /usr/bin/python
configure:3508: checking for gcc
configure:3524: found /usr/bin/gcc
configure:3535: result: gcc
configure:3764: checking for C compiler version
configure:3773: gcc --version 5
gcc (Debian 4.4.5-8) 4.4.5
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

configure:3784: $? = 0
configure:3773: gcc -v 5
Using built-in specs.
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 4.4.5-8' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.4 --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --with-arch-32=i586 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.4.5 (Debian 4.4.5-8) 
configure:3784: $? = 0
configure:3773: gcc -V 5
gcc: '-V' option must have argument
configure:3784: $? = 1
configure:3773: gcc -qversion 5
gcc: unrecognized 

Re: developer IRC or skype chat

2011-06-07 Thread Boris Shingarov

On 11-06-07 03:28 PM, Graham Percival wrote:

Anybody interested in setting up a weekly chat?

I'd be in, although 19:00UTC on a weekday does not really work for me.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel