Re: GOP-PROP 8: issue priorities (probable decision)

[Trevor Daniels]

Graham Percival wrote Thursday, August 11, 2011 6:06 AM



On Thu, Aug 11, 2011 at 04:59:02AM +, Keith OHara wrote:

Graham Percival  percival-music.ca> writes:
> * Type-ignorance: (fixme name?) it is not clear what the
>   correct output should look like. 

In a classification of Types, I'd drop this.  It is not a type 
of problem but rather a status of problem, and not something we

will likely want to sort under.  We can look in the comments to
see if the desired behavior is clear before starting to program.


I'm fine with that.


Glad to see Keith's comment has made you
change your mind.  Why not use a label to
indicate this?  That would enable a short
list of these to be displayed if someone
came across a pertinent example but couldn't
remember the issue number.

Trevor



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1392 / Virus Database: 1520/3825 - Release Date: 08/10/11


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Commas in section headings

[Trevor Daniels]

Graham

I vaguely remember commas should not be used in section headings, 
but can't remember why.  There is nothing about this in the CG that 
I can find.  Can you please remind me.


Trevor



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1392 / Virus Database: 1520/3826 - Release Date: 08/10/11


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Commas in section headings

[Jean-Charles Malahieude]

Le 11/08/2011 10:10, Trevor Daniels disait :

Graham

I vaguely remember commas should not be used in section headings, but
can't remember why. There is nothing about this in the CG that I can
find. Can you please remind me.

Trevor


You may not have a comma in a @node, but you can use it in its labeling 
*section:

look at usage/updating.itely

@node LilyPond une langue vivante
@section LilyPond, une langue vivante
@translationof Why does the syntax change?


Note that it might change, since once we update texinfo:
  . new command @xrefautomaticsectiontitle to allow using section titles
in cross references by default, instead of node names.

Cheers,
Jean-Charles

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Get rid of some compiler warnings (issue4854049)

[Benkő Pál]

generally signed-unsigned problems are better solved
by casting to size_t, not to unsigned - size_t works
equally well in 32 bit and 64 bit mode.  (even better,
some variables can be size_t instead of int.)

p

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Commas in section headings

[Trevor Daniels]

Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM



Le 11/08/2011 10:10, Trevor Daniels disait :


I vaguely remember commas should not be used in section headings, 
but
can't remember why. There is nothing about this in the CG that I 
can

find. Can you please remind me.


You may not have a comma in a @node, but you can use it in its 
labeling *section:


Ah, yes, I remember now.  Many thanks!

Trevor



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1392 / Virus Database: 1520/3826 - Release Date: 08/10/11


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Uses Y-offset for stem tremolos instead of translated stencil. (issue4867043)

[mtsolo]

Reviewers: ,

Message:
My summer of lily continues with this patch.  Currently, the pure height
function in stem tremolo leads to incorrect results, as without an
offset, it places every stem tremolo at the center of the staff for all
pure calculations.  This patch provides a conservative estimate for the
tremolo's offset and height in pure functions (with an exact estimate
when beam's are not involved).

If you want to see the pure height approximations in action, use:

\override StemTremolo #'stencil =
#(lambda (grob)
  (let ((y-ext (ly:stem-tremolo::pure-height grob 0 0))
(p-y-off (ly:stem-tremolo::pure-calc-y-offset grob 0 0))
(y-off (ly:stem-tremolo::calc-y-offset grob)))
  (ly:stencil-add (ly:stem-tremolo::print grob)
(stencil-with-color (ly:stencil-translate-axis (make-line-stencil
0.2 0 (car y-ext) 0 (cdr y-ext)) (- p-y-off y-off) Y) red

Note that overriding the stencil like this wipes out the effect of the
pure functions (as the pure height function is chained to the print
function), but it will show how the estimates are made (try it in
input/regression/stem-tremolo.ly).

Passes regtests.

Cheers,
MS

Description:
Uses Y-offset for stem tremolos instead of translated stencil.

Please review this at http://codereview.appspot.com/4867043/

Affected files:
  M lily/beam.cc
  M lily/include/beam.hh
  M lily/include/stem-tremolo.hh
  M lily/include/stem.hh
  M lily/stem-tremolo.cc
  M lily/stem.cc
  M scm/define-grobs.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

[Francisco Vila]

2011/8/11 Werner LEMBERG :
>
>>> An example is the second aria of Susanna in Mozart's `Le Nozze di
>>> Figaro', bar 16:
>>>
>>>   f2     f8  e8       g8        c8
>>>
>>>  fin -- chè l'a -- "ria è an" -- cor
>>>
>>> Almost all singers I've met during my work as a coach have problems
>>> if they sing it the first time :-)
>>
>> That makes four vowels! i+a+e+a
>
> Yes :-) Since this is completely unexpected (and I don't know any
> other work of Mozart with a similar situation), people are stumbling
> there.
>
>> Here http://cosinasdeleon.blogspot.com/2009/07/hinmo-leon.html are
>> two different instances of 'ioa' but they come from two words, not
>> three.  First "-- gio~a" , then "Dio~a".
>
> No lyric ties either...

So your view is that lyric ties are not used in the real world?  I
still feel them as a pedagogy resource for young musicians or
something.  Or maybe old scores did not use them and they are now more
often used. I don't know.
-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

[m...@apollinemike.com]

On Jul 19, 2011, at 6:11 PM, Neil Puttock wrote:

> On 19 July 2011 09:10, m...@apollinemike.com  wrote:
> 
>> After making several round-trips around the source this morning, I can't put 
>> off composition any longer, but I fear that all I will compose today are 
>> songs about the Axis_group_interface if I don't understand how this works.
>> I believe that line 80 of note-spacing.cc is where the two skylines for the 
>> two note columns are calculated.  How, by adding a pure-height to the 
>> Stem_tremolo, does the Stem_tremolo make its way into this skyline?  And, if 
>> it doesn't make its way into this skyline, how is it taken into account 
>> during horizontal spacing?
> 
> I'm afraid I don't know why it works. I just suggested it based on
> seeing how similar collisions have been solved in the past (e.g., for
> ez-noteheads).

I figured out why it works - I figured I'd post this to the list in case anyone 
else ever wants to mess around with pure properties.

The StemTremolo is added to the paper column's element grob array via the 
axis-group-engraver because it does not have an axis-group-parent-Y.
Then, when horizontal spacing happens, its pure height function is passed 
through for its print function (separation-item.cc).

I may write a "pure" tutorial for the contributor's guide.  It has taken me a 
long time to figure out how "pure" works in lilypond, and if other people are 
as mystified as I was when I started trying to figure this stuff out, then I 
think an addition to the CG would help.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

[Jean-Charles Malahieude]

Le 11/08/2011 13:16, Francisco Vila disait :

2011/8/11 Werner LEMBERG:



An example is the second aria of Susanna in Mozart's `Le Nozze
di Figaro', bar 16:

f2 f8  e8   g8c8

fin -- chè l'a -- "ria è an" -- cor

Almost all singers I've met during my work as a coach have
problems if they sing it the first time :-)


That makes four vowels! i+a+e+a


Yes :-) Since this is completely unexpected (and I don't know any
other work of Mozart with a similar situation), people are
stumbling there.


Here http://cosinasdeleon.blogspot.com/2009/07/hinmo-leon.html
are two different instances of 'ioa' but they come from two
words, not three.  First "-- gio~a" , then "Dio~a".


No lyric ties either...


So your view is that lyric ties are not used in the real world?  I
still feel them as a pedagogy resource for young musicians or
something.  Or maybe old scores did not use them and they are now
more often used. I don't know.


The first time I've seen tied syllables was in English engravings, but
I'm unable to mention where.

Cheers,
Jean-Charles


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

[bordage . bertrand]

I forgot these cases (o~è~in; a~è~in; o~è~an...).  They are often elided
("quest'in" instead of "questa~è~in") by editors and composers.


So your view is that lyric ties are not used in the real world?  I
still feel them as a pedagogy resource for young musicians or
something.  Or maybe old scores did not use them and they are now more
often used. I don't know.


Several famous editors use them, with no particular rule.
Let's take the example of Ricordi Milano.

In this score, published around 1982, there's no ties (we can see a "na
è in" in the beginning):
http://petrucci.mus.auth.gr/imglnks/usimg/2/20/IMSLP81325-PMLP165637-la_danza.pdf

In this one, published around 1925, we can find ties (and it's not a
beginner score!):
http://216.129.110.22/files/imglnks/usimg/2/29/IMSLP80146-PMLP162554-Vivaldi_-_Agitata_da_due_venti__Griselda_.pdf

In every recent score I have from them, they always use ties. Those
which were done using traditional engraving as those using Finale.

I will have to do a better patch...

http://codereview.appspot.com/4808074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

Response to Carl's comments, plus notes to self to sort out white-space
issues.

New Patchset will follow

Ian


http://codereview.appspot.com/4849054/diff/1/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode116
scm/lily.scm:116: "midi")
Sort out (increase) indentation for lines 115-116

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode229
scm/lily.scm:229: (ly:message
On 2011/08/11 00:01:29, Carl wrote:

Indent is wrong here -- should align with test, not with if.


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode272
scm/lily.scm:272: (ly:get-option 'trace-memory-frequency)
On 2011/08/11 00:01:29, Carl wrote:

Indentation needs to move in one parenthesis level on this line and

next.

Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode296
scm/lily.scm:296: (ly:error (_ "cannot find: ~A") x))
On 2011/08/11 00:01:29, Carl wrote:

indent one more level


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode299
scm/lily.scm:299: (ly:progress "]\n"
On 2011/08/11 00:01:29, Carl wrote:

indent one more level


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode303
scm/lily.scm:303: (vector-ref (uname) 0) char-set:letter+digit)))
On 2011/08/11 00:01:29, Carl wrote:

needs to be indented beyond string-tokenize


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode305
scm/lily.scm:305: (member (string-downcase (cadr platform)) '("95" "98"
"me")
On 2011/08/11 00:01:29, Carl wrote:

Indent one more level


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode312
scm/lily.scm:312: (string-regexp-substitute "" "/" x
Sort out (increase) indentation for lines 311-312

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode327
scm/lily.scm:327: (eq? (string-ref file-name 2) #\/))
Sort out (increase) indentation for lines 322-327

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode342
scm/lily.scm:342: (fresh-interface!
Sort out (increase) indentation for lines 336-340/342

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode359
scm/lily.scm:359: #t))
Sort out (increase) indentation for lines 352-359

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode364
scm/lily.scm:364: (recursion-helper (cdr signature) (cdr arguments) (1+
count)
Sort out (increase) indentation for lines 362-364

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode395
scm/lily.scm:395: (ly:version))
Sort out (increase) indentation for lines 393-395

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode603
scm/lily.scm:603: (stats (gc-stats)))
Increase indentation.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode607
scm/lily.scm:607: (assoc-get 'total-cells-allocated  stats 0
Increase indentation for 605-607

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode611
scm/lily.scm:611: (diff (map (lambda (y) (apply - y)) (zip this last
Increase indentation

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode618
scm/lily.scm:618: (cadr diff
Sort out (increase) indentation for lines 614-618

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode634
scm/lily.scm:634: (stringhttp://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode645
scm/lily.scm:645: (outfile (open-file out-file-name "w")))
Sort out (increase) indentation for lines 639 645

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode655
scm/lily.scm:655: protects))
Sort out (increase) indentation for lines 649 655

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode661
scm/lily.scm:661: protects)))
Sort out (increase) indentation for lines 657 661

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode704
scm/lily.scm:704: (mem (string->number (match:substring (car
interesting) 1
Sort out (increase) indentation for lines 698 704

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode722
scm/lily.scm:722: acc))
Sort out (increase) indentation for lines 718 722

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode760
scm/lily.scm:760: files)
Sort out (increase) indentation for lines 755 760

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode810
scm/lily.scm:810: (ly:exit 1 #f))
Sort out (increase) indentation for lines 764 810

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode823
scm/lily.scm:823: (ly:exit 0 #f)
Sort out (increase) indentation for lines 816-818, 820-823

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode836
scm/lily.scm:836: (set! failed (append (list failed-file) failed)
Sort out (increase) indentation for lines 828-836

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode864
scm/lily.scm:864: (dump-gc-protects)
Sort out (increase) indentation for lines 841-864

http://coderevi

Fixes footnote automatic numbering. (issue4877041)

[mtsolo]

Reviewers: ,

Message:
This gets the numbering of automatic footnotes correct for systems with
more than one staff.

Cheers,
MS

Description:
Fixes footnote automatic numbering.

Please review this at http://codereview.appspot.com/4877041/

Affected files:
  M lily/system.cc


Index: lily/system.cc
diff --git a/lily/system.cc b/lily/system.cc
index  
8a071cce90c9d89e6f88816eba4cfc43867ed0f1..4038c2b280ec887d25eb5f80fb9fa7640fce954a  
100644

--- a/lily/system.cc
+++ b/lily/system.cc
@@ -238,7 +238,7 @@ System::populate_footnote_grob_vector ()
 if (all_elts[i]->internal_has_interface (ly_symbol2scm  
("footnote-interface")))

   footnote_grobs_.push_back (all_elts[i]);

-  sort (footnote_grobs_.begin (), footnote_grobs_.end (), Grob::less);
+  vector_sort (footnote_grobs_, Grob::less);
   checked_footnotes_ = true;
 }

@@ -317,9 +317,41 @@ System::num_footnotes ()
   return footnote_grobs_.size ();
 }

+bool
+grob_2D_less (Grob *g1, Grob *g2)
+{
+  int sri[] = {0,0};
+  Grob *gs[] = {g1, g2};
+
+  for (int i = 0; i < 2; i++)
+{
+  sri[i] = gs[i]->spanned_rank_interval ()[LEFT];
+  if (Spanner *s = dynamic_cast (gs[i]))
+{
+  if (s->broken_intos_.size ())
+s = (scm_to_int (s->broken_intos_[0]->get_property  
("spanner-placement")) == LEFT

+ ? s->broken_intos_[0]
+ : s->broken_intos_.back ());
+  if (robust_scm2double (s->get_property ("X-offset"), 0.0) > 0)
+sri[i] = s->spanned_rank_interval ()[RIGHT];
+}
+}
+
+
+  if (sri[0] == sri[1])
+{
+  Grob *commony = g1->common_refpoint (g2, Y_AXIS);
+  if (commony)
+return g1->extent (commony, Y_AXIS)[DOWN] > g2->extent (commony,  
Y_AXIS)[DOWN];

+}
+ return sri[0] < sri[1];
+}
+
 vector*
 System::footnote_grobs ()
 {
+  // Careful - don't call this too soon, as it calls a VerticalAlignment
+  vector_sort (footnote_grobs_, grob_2D_less);
   return &footnote_grobs_;
 }




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode116
scm/lily.scm:116: "midi")
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 115-116


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode312
scm/lily.scm:312: (string-regexp-substitute "" "/" x
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 311-312


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode327
scm/lily.scm:327: (eq? (string-ref file-name 2) #\/))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 322-327


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode342
scm/lily.scm:342: (fresh-interface!
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 336-340/342


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode359
scm/lily.scm:359: #t))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 352-359


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode364
scm/lily.scm:364: (recursion-helper (cdr signature) (cdr arguments) (1+
count)
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 362-364


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode395
scm/lily.scm:395: (ly:version))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 393-395


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode603
scm/lily.scm:603: (stats (gc-stats)))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Increase indentation.


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode611
scm/lily.scm:611: (diff (map (lambda (y) (apply - y)) (zip this last
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Increase indentation


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode618
scm/lily.scm:618: (cadr diff
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 614-618


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode634
scm/lily.scm:634: (string
Sort out (increase) indentation for lines 631 634


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode645
scm/lily.scm:645: (outfile (open-file out-file-name "w")))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 639 645


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode655
scm/lily.scm:655: protects))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 649 655


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode661
scm/lily.scm:661: protects)))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 657 661


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode677
scm/lily.scm:677: (dump-live-object-stats outfile)))
Indentation sorted, lines 666-677

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode685
scm/lily.scm:685: '(protected-objects bytes-malloced cell-heap-size)))
Indentation sorted, lines 681-685

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode693
scm/lily.scm:693: (text (read-delimited "" file)))
Indentation increased

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode704
scm/lily.scm:704: (mem (string->number (match:substring (car
interesting) 1
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 698 704


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode709
scm/lily.scm:709: (raise 1)
Indentation sorted, line 708,709

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode722
scm/lily.scm:722: acc))
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 718 722


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode734
scm/lily.scm:734: (else (ly:message ""
Indentation sorted, lines 732-734

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode744
scm/lily.scm:744: (ly:exit 0 #t)))
Indentation sorted, line 744

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode747
scm/lily.scm:747: (ly:exit 0 #t)))
Indentation sorted, line 747

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode752
scm/lily.scm:752: (ly:exit 2 #t)))
Indentation sorted, line 752

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode760
scm/lily.scm:760: files)
On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote:

Sort out (increase) indentation for lines 755 760


Done.

http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode762
scm/lily.scm:762

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

New patch-set available for review.

Ian

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes footnote automatic numbering. (issue4877041)

[reinhold . kainhofer]

Regtest missing.

Much better now, but with my example there are still some
inconsistencies. In particular, the ordering of the six footnotes in
each of the systems is:

1st system:
2  3  5
1  4  6

2nd system (start at 7, shown here as 1):
1  4  5
2  3  6

3rd system (2nd page):
1  3  5
2  4  6

So, while the numbers are now sorted by moment, two footnotes at the
same moment are not consistently ordered.




http://codereview.appspot.com/4877041/diff/1/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/4877041/diff/1/lily/system.cc#newcode325
lily/system.cc:325:
Remove the spaces from that empty line (git complains)

http://codereview.appspot.com/4877041/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes footnote automatic numbering. (issue4877041)

[m...@apollinemike.com]

On Aug 11, 2011, at 4:48 PM, reinhold.kainho...@gmail.com wrote:

> Regtest missing.
> 
> Much better now, but with my example there are still some
> inconsistencies. In particular, the ordering of the six footnotes in
> each of the systems is:
> 
> 1st system:
> 2  3  5
> 1  4  6
> 
> 2nd system (start at 7, shown here as 1):
> 1  4  5
> 2  3  6
> 
> 3rd system (2nd page):
> 1  3  5
> 2  4  6
> 
> So, while the numbers are now sorted by moment, two footnotes at the
> same moment are not consistently ordered.
> 

I've put a new patchset up that should do the trick.
Before I add a regtest, I want to figure out why your example intersects with 
the footnotes - that may be a separate bug that I can fix in this patch.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Spanish PO file for 'lilypond' (version 2.15.9)

[Translation Project Robot]

Hello, gentle maintainer.

This is a message from the Translation Project robot.

A revised PO file for textual domain 'lilypond' has been submitted
by the Spanish team of translators.  The file is available at:

http://translationproject.org/latest/lilypond/es.po

(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive.  Ask at the address below if you want this.)

All other PO files for your package are available in:

http://translationproject.org/latest/lilypond/

Please consider including all of these in your next release, whether
official or a pretest.

Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below.  The tarball may be just a pretest or a
snapshot, it does not even have to compile.  It is just used by the
translators when they need some extra translation context.

The following HTML page has been updated:

http://translationproject.org/domain/lilypond.html

If any question arises, please contact the translation coordinator.

Thank you for all your work,

The Translation Project robot, in the
name of your translation coordinator.



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: custom engraver in scheme: accessing nested Music object

[Ricardo Wurmus]

On Aug 10, Reinhold Kainhofer wrote:
> Am Mittwoch, 10. August 2011, 17:11:44 schrieb Ricardo Wurmus:
> > On Aug 10, Neil Puttock wrote:
> > > BTW, if you're prepared to wrap the notes in a chord (so you have
> > > access to 'articulations), you won't even need a scheme engraver (all
> > > the processing can take place in the NoteHead's stencil callback).
> >
> > It should be a generic engraver, so I cannot assume that notes will
> > always be wrapped in a chord. I'll play around with defining a function
> > for process-acknowledged and see where it leads me.
>
> One detail that might be interesting for you is that you can define engraver-
> wide variables by wrapping the whole engraver in a (let (..) ...) block.
> See e.g. the scheme engraver instance regtest (input/regression/scheme-
> engraver-instance.ly in the source code tree):
>

>
>
> In this example, instance-counter is a global variable, which is reused by
> every voice, while instance-id and private-note-counter are variables that are
> separate for each voice. In this example, instance-id stores the number of the
> voice, while private-note-counter counts the number of notes in each voice
> separately.
> In particular, the engravers used in the first and in the second voice will
> have different private-note-counter variables.
>
> You can use this to collect information from all encountered objects and thin
> in 'process-acknowledged or 'stop-translation-timestep procell all of them at
> once. For a list of all possible "functions" inside the engraver, see
> input/regression/scheme-engraver.ly

Thanks, this helped me quite a bit. The engraver is already working
basically. Will just have to clean up and add a few more features.

> Cheers,
> Reinhold

Best,
Rekado

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Warning added to para for cueduring (issue4850051)

[tdanielsmusic]

LGTM

http://codereview.appspot.com/4850051/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

[Neil Puttock]

On 11 August 2011 12:34, m...@apollinemike.com  wrote:

> I figured out why it works - I figured I'd post this to the list in case 
> anyone else ever wants to mess around with pure properties.
>
> The StemTremolo is added to the paper column's element grob array via the 
> axis-group-engraver because it does not have an axis-group-parent-Y.

I think you mean the VerticalAxisGroup's elements array.

The StemTremolo is added to a PaperColumn's elements array (and gets
the column as axis-group-parent-X) in the Paper_column_engraver.

> Then, when horizontal spacing happens, its pure height function is passed 
> through for its print function (separation-item.cc).

I think I understand: before you added the print-to-height conversion,
the original height callback (ly:stem-tremolo::height) wasn't
pure-relevant; this resulted in Item::pure_height () returning an
empty extent, causing the StemTremolo to be left out of the skyline.
This didn't matter unless the spacing was really tight.

> I may write a "pure" tutorial for the contributor's guide.  It has taken me a 
> long time to figure out how "pure" works in lilypond, and if other people are 
> as mystified as I was when I started trying to figure this stuff out, then I 
> think an addition to the CG would help.

Sounds great.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[n . puttock]

On 2011/08/11 14:36:24, Ian Hulin (gmail) wrote:

New patch-set available for review.


Please rebase against master.

Cheers,
Neil



http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 8: issue priorities (probable decision)

[Keith OHara]

On Wed, 10 Aug 2011 22:06:16 -0700, Graham Percival  
wrote:


On Thu, Aug 11, 2011 at 04:59:02AM +, Keith OHara wrote:

Graham Percival  percival-music.ca> writes:

> Type-critical:
>
You might want to split this into two:
 regressions to the output of Lilypond, and
 critical impediments to development


Why bother splitting it?  I forsee an average weekly count of 2
Critical regressions, and 0.15 critical impediments to
development.


Good point. Probably not worth splitting them.
I was merely noting that they are conceptually different.

On Thu, 11 Aug 2011 00:02:51 -0700, Trevor Daniels  
wrote:


Graham Percival  percival-music.ca> writes:
> * Type-ignorance: (fixme name?) it is not clear what the
>   correct output should look like.


Why not use a label to indicate this? That would enable a short
list of these to be displayed if someone
came across a pertinent example but couldn't
remember the issue number.



That will work; now we can think of a name for the label.
Need_clarification
Need_goal
What_should_Lily_do


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

On 2011/08/11 17:35:22, Neil Puttock wrote:

On 2011/08/11 14:36:24, Ian Hulin (gmail) wrote:
> New patch-set available for review.



Please rebase against master.



Cheers,
Neil


Thanks for the catch.
Rebased, scm/lily.scm merged and new patch-set uploaded.

Cheers,
Ian

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 8: issue priorities (probable decision)

[Graham Percival]

On Thu, Aug 11, 2011 at 12:32:09PM -0700, Keith OHara wrote:
> On Wed, 10 Aug 2011 22:06:16 -0700, Graham Percival 
>  wrote:
> 
> On Thu, 11 Aug 2011 00:02:51 -0700, Trevor Daniels  
> wrote:
> 
> >>>Graham Percival  percival-music.ca> writes:
>  * Type-ignorance: (fixme name?) it is not clear what the
>    correct output should look like.
> 
> That will work; now we can think of a name for the label.
> Need_clarification
> Need_goal
> What_should_Lily_do

I like Colin's suggestion of "Type-ambiguous".

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Commas in section headings

[Graham Percival]

On Thu, Aug 11, 2011 at 11:45:39AM +0100, Trevor Daniels wrote:
> 
> Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM
> 
> >You may not have a comma in a @node, but you can use it in its
> >labeling *section:

Yes.  I disallow commas in @section headings because IMO we should
always have the @section heading match the @node -- doing
otherwise is just begging for trouble down the road.

> Ah, yes, I remember now.  Many thanks!

Could you update the CG?  James is away for the next week.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lily/auto-beam-engraver: keep a Context_handle to starting Staff (issue4830064)

[n . puttock]

LGTM.  Just needs a regtest.


http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc
File lily/auto-beam-engraver.cc (right):

http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc#newcode85
lily/auto-beam-engraver.cc:85: Handle on the starting staff keeps it
alive until beam is comlete
complete

http://codereview.appspot.com/4830064/diff/5001/lily/context.cc
File lily/context.cc (right):

http://codereview.appspot.com/4830064/diff/5001/lily/context.cc#newcode38
lily/context.cc:38: return context_list_ == SCM_EOL && ! client_count_
!client_count_

http://codereview.appspot.com/4830064/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: modifying default behaviour of tremolo slashes (issue4636081)

[n . puttock]

Needs a regression test exercising the different settings.


http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):

http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118
lily/stem-tremolo.cc:118: shape = ly_symbol2scm ("beam-like");
this is redundant unless you want to add a warning for invalid shape
setting (you only check for rectangle below; anything else falls through
to Lookup::beam ())

http://codereview.appspot.com/4636081/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

[n . puttock]

Needs a rebase.


http://codereview.appspot.com/4810072/diff/1003/input/regression/slur-height-capping.ly
File input/regression/slur-height-capping.ly (right):

http://codereview.appspot.com/4810072/diff/1003/input/regression/slur-height-capping.ly#newcode4
input/regression/slur-height-capping.ly:4: texidoc = "Slur shaping is
not adapted to accomodate objects
accommodate

http://codereview.appspot.com/4810072/diff/1003/input/regression/slur-height-capping.ly#newcode14
input/regression/slur-height-capping.ly:14: c,( des' as des c, des' as
des) |
c,8

http://codereview.appspot.com/4810072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Commas in section headings

[Trevor Daniels]

Graham Percival wrote Thursday, August 11, 2011 8:42 PM



On Thu, Aug 11, 2011 at 11:45:39AM +0100, Trevor Daniels wrote:


Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM

>You may not have a comma in a @node, but you can use it in its
>labeling *section:


Yes.  I disallow commas in @section headings because IMO we should
always have the @section heading match the @node -- doing
otherwise is just begging for trouble down the road.


OK.  I'll fix the two that slipped through,
although they look a little strange without the
commas.


Ah, yes, I remember now.  Many thanks!


Could you update the CG?  James is away for the next week.


OK

Trevor



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1392 / Virus Database: 1520/3827 - Release Date: 08/11/11


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[n . puttock]

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324
scm/lily.scm:324: (> file-name-length 2)
tab->space conversion has broken indentation here (and lines below)

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode408
scm/lily.scm:408: ;; Library definitions, need to be at the head of the
list
this is a top-level comment, so you can't indent it two spaces

(alternatively, put it inside the define)

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode412
scm/lily.scm:412: ;; Files containing definitions used later by other
files later in load
top-level comment; fix indent

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode415
scm/lily.scm:415: ;; Main body of files to be loaded
top-level comment; fix indent

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode467
scm/lily.scm:467: ;; Files to be loaded last
top-level comment; fix indent

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode476
scm/lily.scm:476: init-scheme-files-used
indent:

(append init-scheme-files-lib
init-scheme-files-used
...)

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode638
scm/lily.scm:638: (lambda (a b)
tab->space conversion has broken indentation here (and lines below)

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode770
scm/lily.scm:770: 'log-file (format #f "~a-~a"
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode779
scm/lily.scm:779: (acons (list-element-index joblist pid)
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode795
scm/lily.scm:795: job (status:term-sig state)))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode802
scm/lily.scm:802: (map car errors)))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode806
scm/lily.scm:806: '(0 0) (profile-measurements)))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode817
scm/lily.scm:817: (string-contains f "lilypond")
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode831
scm/lily.scm:831: (format #f "~a.log" (ly:get-option 'log-file))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode840
scm/lily.scm:840: (profile-measurements)
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode855
scm/lily.scm:855: (mtrace:dump-results base)))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode857
scm/lily.scm:857: (ly:set-option (car s) (cdr s)))
restore indentation

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm
File scm/markup.scm (left):

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm#oldcode239
scm/markup.scm:239: (defmacro*-public markup (#:rest body)
move this for consistency?

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Prevents nested tuplets from colliding. (issue4808082)

[n . puttock]

Hi Mike,

Have you tested this with broken tuplets?  I've tried adding breaks at
random in tuplet-nest.ly and get collisions in some cases.

Cheers,
Neil


http://codereview.appspot.com/4808082/diff/2001/input/regression/tuplet-nest.ly
File input/regression/tuplet-nest.ly (right):

http://codereview.appspot.com/4808082/diff/2001/input/regression/tuplet-nest.ly#newcode15
input/regression/tuplet-nest.ly:15: \times 2/3 { c8 [c8 c8 ]}
{ c8[ c c] }

etc.

http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):

http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc#newcode685
lily/tuplet-bracket.cc:685: If this function is over-ridden, this may
lead to bizarre results...
Would it be feasible to remove the centring from ly:tuplet-number::print
and use a callback for X-offset instead?

http://codereview.appspot.com/4808082/diff/2001/lily/tuplet-bracket.cc#newcode687
lily/tuplet-bracket.cc:687: Stencil *my_number_stencil = unsmob_stencil
(Text_interface::print (me->get_object ("tuplet-number")));
unsmob_stencil (Text_interface::print (my_number));

http://codereview.appspot.com/4808082/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

[m...@apollinemike.com]

On Aug 11, 2011, at 7:03 PM, Neil Puttock wrote:

> On 11 August 2011 12:34, m...@apollinemike.com  wrote:
> 
>> I figured out why it works - I figured I'd post this to the list in case 
>> anyone else ever wants to mess around with pure properties.
>> 
>> The StemTremolo is added to the paper column's element grob array via the 
>> axis-group-engraver because it does not have an axis-group-parent-Y.
> 
> I think you mean the VerticalAxisGroup's elements array.
> 
> The StemTremolo is added to a PaperColumn's elements array (and gets
> the column as axis-group-parent-X) in the Paper_column_engraver.
> 

Yes, you're absolutely right.

>> Then, when horizontal spacing happens, its pure height function is passed 
>> through for its print function (separation-item.cc).
> 
> I think I understand: before you added the print-to-height conversion,
> the original height callback (ly:stem-tremolo::height) wasn't
> pure-relevant; this resulted in Item::pure_height () returning an
> empty extent, causing the StemTremolo to be left out of the skyline.
> This didn't matter unless the spacing was really tight.
> 

Yup!

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

[mtsolo]

Pushed as e75f38b1a9adaf7752ced683fff0e6ec01bd8a13.

Cheers,
MS

http://codereview.appspot.com/4822046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

[mtsolo]

Pushed as 94ea10f3f341fff503599a9eb947c81f1803290f.

Cheers,
MS

http://codereview.appspot.com/4810072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324
scm/lily.scm:324: (> file-name-length 2)
On 2011/08/11 20:40:46, Neil Puttock wrote:

tab->space conversion has broken indentation here (and lines below)


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode408
scm/lily.scm:408: ;; Library definitions, need to be at the head of the
list
On 2011/08/11 20:40:46, Neil Puttock wrote:

this is a top-level comment, so you can't indent it two spaces



(alternatively, put it inside the define)


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode412
scm/lily.scm:412: ;; Files containing definitions used later by other
files later in load
On 2011/08/11 20:40:46, Neil Puttock wrote:

top-level comment; fix indent


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode415
scm/lily.scm:415: ;; Main body of files to be loaded
On 2011/08/11 20:40:46, Neil Puttock wrote:

top-level comment; fix indent


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode467
scm/lily.scm:467: ;; Files to be loaded last
On 2011/08/11 20:40:46, Neil Puttock wrote:

top-level comment; fix indent


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode476
scm/lily.scm:476: init-scheme-files-used
On 2011/08/11 20:40:46, Neil Puttock wrote:

indent:



(append init-scheme-files-lib
 init-scheme-files-used
 ...)


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode638
scm/lily.scm:638: (lambda (a b)
On 2011/08/11 20:40:46, Neil Puttock wrote:

tab->space conversion has broken indentation here (and lines below)


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode770
scm/lily.scm:770: 'log-file (format #f "~a-~a"
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode779
scm/lily.scm:779: (acons (list-element-index joblist pid)
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode795
scm/lily.scm:795: job (status:term-sig state)))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode802
scm/lily.scm:802: (map car errors)))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode806
scm/lily.scm:806: '(0 0) (profile-measurements)))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode817
scm/lily.scm:817: (string-contains f "lilypond")
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode831
scm/lily.scm:831: (format #f "~a.log" (ly:get-option 'log-file))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode840
scm/lily.scm:840: (profile-measurements)
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode855
scm/lily.scm:855: (mtrace:dump-results base)))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode857
scm/lily.scm:857: (ly:set-option (car s) (cdr s)))
On 2011/08/11 20:40:46, Neil Puttock wrote:

restore indentation


Done.

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm
File scm/markup.scm (left):

http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm#oldcode239
scm/markup.scm:239: (defmacro*-public markup (#:rest body)
On 2011/08/11 20:40:46, Neil Puttock wrote:

move this for consistency?


I had some problems with other files in the load list on V2 if I moved
it, it works here for running with V1.8.7 now, so I'd rather not touch
it yet.

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

Two more indentation problems in scm/lily.scm new patchset follows.
Ian


http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode394
scm/lily.scm:394: (ly:version))
Needs indenting to line up with (lambda in 391

http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode900
scm/lily.scm:900: (ly:exit 0 #f)
Indent block ll 892-900 by two spaces (one indent)

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

[ianhulin44]

On 2011/08/11 23:16:59, Ian Hulin (gmail) wrote:

Two more indentation problems in scm/lily.scm new patchset follows.
Ian



http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm
File scm/lily.scm (right):



http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode394

scm/lily.scm:394: (ly:version))
Needs indenting to line up with (lambda in 391



http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode900

scm/lily.scm:900: (ly:exit 0 #f)
Indent block ll 892-900 by two spaces (one indent)


New patch-set 6 available for review,
Ian

http://codereview.appspot.com/4849054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: test macosx 10.7 binaries

[Dan Eble]

On 2011-08-07, at 20:52 , Graham Percival wrote:

> On Wed, Aug 03, 2011 at 12:30:15PM -0700, Graham Percival wrote:
>> Get them here:
>> http://lilypond.org/~graham/
> 
> Hmm.  Nobody cares about MacOS X 10.7 ?  ok, no skin off my
> nose...


I never use the GUI, but for your special bulid of 2.15.9 x86, clicking the 
application icon opens the GUI, and the "Compile > Typeset file" menu first 
prompts me to save Untitled.ly, and then on the second attempt it creates 
Untitled.pdf and opens it in Preview.app.  Is that the kind of feedback you're 
looking for, or is there something more specific you'd like tested?

Incidentally, I have been running lilypond 2.14.1 from a Makefile with no 
noticeable problems, but I'm not using 2.14.2 because it produced a bus error 
when I tried it.

Your special 2.15.9 appears to work equally well from the command line.

Thanks,
-- 
Dan


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

script for auto-indenting .scm files.

[Carl Sorensen]

Having spent more time than I thought it would be necessary, I finally found
something that could work as a stand-alone script for indenting scheme
files.

It appears to follow standard Scheme indenting rules, which means that it
changes the indentation we have in lily.scm where the
scheme-options-definition is defined.

The call to guile is hardcoded at the top of the file, and will need to be
changed to use the appropriate lilypond environment variable that defines
the location of guile.

But I thought I'd pass it out for some third-party review.  It handled the
tabs->spaces conversion of scm/lily.scm perfectly, as near as I can tell.

Please give it a try.

Thanks,

Carl



scmindent.scm
Description: scmindent.scm
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: script for auto-indenting .scm files.

[Carl Sorensen]

On 8/11/11 6:07 PM, "Carl Sorensen"  wrote:

> Having spent more time than I thought it would be necessary, I finally found
> something that could work as a stand-alone script for indenting scheme
> files.
> 
> It appears to follow standard Scheme indenting rules, which means that it
> changes the indentation we have in lily.scm where the
> scheme-options-definition is defined.
> 
> The call to guile is hardcoded at the top of the file, and will need to be
> changed to use the appropriate lilypond environment variable that defines
> the location of guile.
> 
> But I thought I'd pass it out for some third-party review.  It handled the
> tabs->spaces conversion of scm/lily.scm perfectly, as near as I can tell.

Oops -- I have now found a problem with it.  The else part of an if doesn't
line up with the then part.  More work to do, I guess.

BTW, usage is

./scmindent.scm < input-file > output-file

Thanks,

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: script for auto-indenting .scm files.

[Carl Sorensen]

On 8/11/11 6:17 PM, "Carl Sorensen"  wrote:
> On 8/11/11 6:07 PM, "Carl Sorensen"  wrote:
> 
> 
> Oops -- I have now found a problem with it.  The else part of an if doesn't
> line up with the then part.  More work to do, I guess.

New version fixes that problem.

> 
> BTW, usage is
> 
> ./scmindent.scm < input-file > output-file
> 

Thanks,

Carl



scmindent.scm
Description: scmindent.scm
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: script for auto-indenting .scm files.

[Graham Percival]

On Thu, Aug 11, 2011 at 06:07:07PM -0600, Carl Sorensen wrote:
> The call to guile is hardcoded at the top of the file, and will need to be
> changed to use the appropriate lilypond environment variable that defines
> the location of guile.

Change it to:
#!/usr/bin/env guile
and all should be well.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: test macosx 10.7 binaries

[Graham Percival]

On Thu, Aug 11, 2011 at 07:35:30PM -0400, Dan Eble wrote:
> I never use the GUI, but for your special bulid of 2.15.9 x86, clicking the 
> application icon opens the GUI, and the "Compile > Typeset file" menu first 
> prompts me to save Untitled.ly, and then on the second attempt it creates 
> Untitled.pdf and opens it in Preview.app.  Is that the kind of feedback 
> you're looking for, or is there something more specific you'd like tested?

The feedback I wanted was "I tried it 10.7 and it didn't fail
spectacularly".  Thanks!  I'll move ahead with 2.15.9 official.

> Incidentally, I have been running lilypond 2.14.1 from a Makefile with no 
> noticeable problems, but I'm not using 2.14.2 because it produced a bus error 
> when I tried it.

http://lilypond.org/bug-reports.html
please.  If you can produce a Tiny example which works in 2.14.1
and fails in 2.14.2, we'll take that very seriously.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: script for auto-indenting .scm files.

[Graham Percival]

On Thu, Aug 11, 2011 at 06:28:09PM -0600, Carl Sorensen wrote:
> On 8/11/11 6:17 PM, "Carl Sorensen"  wrote:
> > BTW, usage is
> > 
> > ./scmindent.scm < input-file > output-file

Could we get that in a comment at the top of the file ?

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: script for auto-indenting .scm files.

[Carl Sorensen]

On 8/11/11 6:32 PM, "Graham Percival"  wrote:

> On Thu, Aug 11, 2011 at 06:28:09PM -0600, Carl Sorensen wrote:
>> On 8/11/11 6:17 PM, "Carl Sorensen"  wrote:
>>> BTW, usage is
>>> 
>>> ./scmindent.scm < input-file > output-file
> 
> Could we get that in a comment at the top of the file ?

Yep.  Here it is, along with the change to /usr/bin/env guile.

And I ran the file through itself to clean up some sloppy indenting I had
left behind when modifying things from Racket to Guile.

I think I'm really going to like having this, if we can get all the bugs
worked out..

Thanks,

Carl



scmindent.scm
Description: scmindent.scm
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCH: 48-Hour countdown

[Colin Campbell]

22:00 MDT Saturday, Aug 13

Issue T 1790 : 
Proper loglevels: cmd-line option 
--loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG - R  Issue 4822055 



Issue T 40 : 
collision glissando accidental (includes workaround) - R Issue 4801083 



Issue T 1807 : 
Adds a lyric tie glyph to feta font - R Issue 4808074 



Issue T 1787 : 
Hide ends of barlines inside staff lines - R Issue 4809057 



I'm seizing the chance for a 4-day weekend, after a *remarkably* 
unpleasant end to Folk Fest, so the next Patch Batch will resume the 
regular schedule on Monday.


Cheers,

Colin Campbell
Bug Squad

--
The human race has one really effective weapon, and that is laughter.
-- Mark Twain

 

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: test macosx 10.7 binaries

[Dan Eble]

On 2011-08-11, at 20:31 , Graham Percival wrote:

>> Incidentally, I have been running lilypond 2.14.1 from a Makefile with no 
>> noticeable problems, but I'm not using 2.14.2 because it produced a bus 
>> error when I tried it.
> 
> http://lilypond.org/bug-reports.html
> please.  If you can produce a Tiny example which works in 2.14.1
> and fails in 2.14.2, we'll take that very seriously.

Good grief--now I can't reproduce it.  So, I can supply neither a tiny nor a 
huge example, and for all I know it's not specific to 2.14.2; however, I did 
serendipitously discover a couple crash reports that OS X dumped.  Should I 
bother submitting such a bug report without an example?  I'd be happy to, but 
the instructions make it sound like it would be rejected.

Thanks,
-- 
Dan

P.S. for the curious...

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x000c

VM Regions Near 0xc:
--> __PAGEZERO -1000 [4K] ---/--- 
SM=NUL  /Applications/LilyPond-2.14.app/Contents/Resources/bin/lilypond
__TEXT 1000-0036d000 [ 3504K] r-x/rwx 
SM=COW  /Applications/LilyPond-2.14.app/Contents/Resources/bin/lilypond

Application Specific Information:
objc[2803]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   lilypond0x0018cbd2 
Prob::internal_get_property(scm_unused_struct*) const + 18
1   lilypond0x002c0061 
Dispatcher::dispatch(scm_unused_struct*) + 65
2   lilypond0x000817fb 
Dispatcher::broadcast(Stream_event*) + 27
3   lilypond0x00173085 
Part_combine_iterator::kill_mmrest(int) + 69
4   lilypond0x00174a79 
Part_combine_iterator::unisono(bool) + 249
5   lilypond0x001757f3 
Part_combine_iterator::process(Moment) + 1971
6   lilypond0x001c83ac 
Simultaneous_music_iterator::process(Moment) + 188
7   lilypond0x00124ea5 
Music_wrapper_iterator::process(Moment) + 101
8   lilypond0x001c83ac 
Simultaneous_music_iterator::process(Moment) + 188
9   lilypond0x00124ea5 
Music_wrapper_iterator::process(Moment) + 101
10  lilypond0x001c83ac 
Simultaneous_music_iterator::process(Moment) + 188
11  lilypond0x00124ea5 
Music_wrapper_iterator::process(Moment) + 101
12  lilypond0x000b3fa7 
Global_context::run_iterator_on_me(Music_iterator*) + 1127
13  lilypond0x000b2c8c 
ly_interpret_music_expression(scm_unused_struct*, scm_unused_struct*) + 764
14  lilypond0x000b3259 
ly_run_translator(scm_unused_struct*, scm_unused_struct*) + 377
15  lilypond0x001b0759 
Score::book_rendering(Output_def*, Output_def*) + 393
16  lilypond0x00050e22 
Book::process_score(scm_unused_struct*, Paper_book*, Output_def*) + 114
17  lilypond0x0005241e Book::process(Output_def*, 
Output_def*, Paper_book*) + 366
18  lilypond0x00052514 
Book::process_bookparts(Paper_book*, Output_def*, Output_def*) + 180
19  lilypond0x000523a2 Book::process(Output_def*, 
Output_def*, Paper_book*) + 242
20  lilypond0x00052567 Book::process(Output_def*, 
Output_def*) + 39
21  lilypond0x0004ee49 
ly_book_process(scm_unused_struct*, scm_unused_struct*, scm_unused_struct*, 
scm_unused_struct*) + 521
22  libguile.17.dylib   0x005b6b2d scm_gsubr_apply + 397
23  libguile.17.dylib   0x0059d5f5 scm_apply + 1093
24  libguile.17.dylib   0x0059a1c2 ceval + 1890
25  lilypond0x002627d7 yyparse(void*) + 17495
26  lilypond0x000ee556 
Lily_parser::parse_file(std::string, std::string, std::string) + 534
etc.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

[Werner LEMBERG]

>> No lyric ties either...
> 
> So your view is that lyric ties are not used in the real world?

No.  I simply can't discuss how lyric ties should look like since I
haven't seen real-world examples in the scores I've used up to now.
It seems that German engraving for classical music can live without
it.


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ugliness in the Learning Manual

[Werner LEMBERG]

I've now reported the cartouche problem to bug-texinfo.


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel