a weekly pause
Hi all, i'm moving to a new flat - i cannot do any Lily work now. I should be back no later than on 10.10. Graham: please find someone to look after issues owned by me - i've checked that every patch i know i'm mentoring is there. Colin: if i would be necessary for some Frog work, you can try reaching me at lemniskata.bernoulli...@gmail.com See you soon, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Build dependencies for .texi files (issue 1852). (issue 5169041)
the GNUmakefile and texinfo-rules.make look good http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi this should be taken care of with the texinfo -I includedir stuff. Which target does it fail with? I'll fix that .make file. http://codereview.appspot.com/5169041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
git-cl upload mimetypes fixed (issue 1491)
Following Nicholas' suggestion from last February, I've fixed the git-cl upload: https://github.com/gperciva/git-cl/commit/86d891d0817b0d4946fd22bd03554ea2685337b9 I suggest that everybody using git-cl upgrade to this. Also note that I've added a -s --no_code_issue option to skip uploading to code.google.com, in case you wanted to use git-cl for projects other than lilypond. :) Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Build dependencies for .texi files (issue 1852). (issue 5169041)
I don't really like the naive approach of using the exact include file as the make dependency, because that blatantly ignores all include path settings for texinfo... http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi On 2011/09/30 11:41:50, Graham Percival wrote: this should be taken care of with the texinfo -I includedir stuff. Which target does it fail with? I'll fix that .make file. The problem is not texinfo, but the way the .dep file for the dependencies is created. It simply greps through the .texi file anc extracts all @include entries as make dependencies. There are not include pathes involved. See the changes to texinfo-rules.make in this patch. http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make File stepmake/stepmake/texinfo-rules.make (right): http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28 stepmake/stepmake/texinfo-rules.make:28: sed -ne /^@include[[:space:]]/s/@include/.\/$(subst /,\/,$@):/p $ $(subst .texi,.dep,$@) Shouldn't we do this in a separate rule to create the .dep file? http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28 stepmake/stepmake/texinfo-rules.make:28: sed -ne /^@include[[:space:]]/s/@include/.\/$(subst /,\/,$@):/p $ $(subst .texi,.dep,$@) This also does not work with nested includes. http://codereview.appspot.com/5169041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketch for fix of issue 307 (issue 4813048)
Hello, On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: Am Thursday, 29. September 2011, 23:30:20 schrieb pkx1...@gmail.com: Passes make but fails make check --snip-- job 4 terminated with signal: 6 job 3 terminated with signal: 6 fatal error: Children (4 3) exited with errors. command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation -I /home/jlowe/lilypond-git/Documentation/snippets -I /home/jlowe/lilypond-git/input/regression/ -I /home/jlowe/lilypond-git/Documentation/included/ -I /home/jlowe/lilypond-git/build/mf/out/ -I /home/jlowe/lilypond-git/build/mf/out/ -I /home/jlowe/lilypond-git/Documentation/pictures -I /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I /home/jlowe/lilypond-git/build/out/lybook-testdb -I /home/jlowe/lilypond-git/build/input/regression -I /home/jlowe/lilypond-git/input/regression -I /home/jlowe/lilypond-git/build/input/regression/out-test -I /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation -I /home/jlowe/lilypond-git/Documentation/snippets -I /home/jlowe/lilypond-git/input/regression -I /home/jlowe/lilypond-git/Documentation/included -I /home/jlowe/lilypond-git/build/mf/out -I /home/jlowe/lilypond-git/build/mf/out -I /home/jlowe/lilypond-git/Documentation/pictures -I /home/jlowe/lilypond-git/build/Documentation/pictures/out-test --formats=eps -deps-box-padding=3.00 -dread-file-list -dno-strip-output-dir /home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111. ly Child returned 1 make[2]: *** [out-test/collated-files.texi] Error 1 rm out-test/weblinks.itexi make[2]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression' make[1]: *** [local-test] Error 2 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression' make: *** [test] Error 2 jlowe@jlowe-lilybuntu2:~/lilypond-git/build$ Hmm, it would be REALLY useful if the regtest run could print out the error. That's the relevant information, not how the regtests were built (i.e. the 30 lines of lilypond-book invocation that tells us nothing). Well the make check often does give me the ly file that has the problem but in this case for a reason I have never understood, during make check I get the 'texidoc strings' (if that is the right phrase) for the fingerings of the woodwind diagrams, and it is at this point I suddenly got job terminated. Usually I get a file that it was working on when this happened but not in this case. There are points in the make check process where it is impossible to see where teh process is at - and I guess this makes it harder if you are running -j7 makes. -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: a weekly pause
Janek, 2011/9/30 Janek Warchoł janek.lilyp...@gmail.com: Hi all, i'm moving to a new flat - i cannot do any Lily work now. I should be back no later than on 10.10. Graham: please find someone to look after issues owned by me - i've checked that every patch i know i'm mentoring is there. Colin: if i would be necessary for some Frog work, you can try reaching me at lemniskata.bernoulli...@gmail.com See you soon, Janek I can keep an eye on your Tracker issues that need pushing. regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Build dependencies for .texi files (issue 1852). (issue 5169041)
Publish comments. http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi On 2011/09/30 11:41:50, Graham Percival wrote: this should be taken care of with the texinfo -I includedir stuff. Which target does it fail with? I'll fix that .make file. Without the change, make fails on the second doc build, after the first one created a AUTHORS.dep file which links to macros.itexi: this file is not found by make in the current directory, since it is in the parent directory. I don't know if you can pass something like a -I switch to make. In any case I think it is better to be explicit about what we are including here. http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make File stepmake/stepmake/texinfo-rules.make (right): http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28 stepmake/stepmake/texinfo-rules.make:28: sed -ne /^@include[[:space:]]/s/@include/.\/$(subst /,\/,$@):/p $ $(subst .texi,.dep,$@) On 2011/09/30 12:17:12, Reinhold wrote: Shouldn't we do this in a separate rule to create the .dep file? For .tely files you run lilypond-book to produce the output .texi file and a .dep file is created as a byproduct. This is the same thing. Is there a use-case for specific .dep targets? http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28 stepmake/stepmake/texinfo-rules.make:28: sed -ne /^@include[[:space:]]/s/@include/.\/$(subst /,\/,$@):/p $ $(subst .texi,.dep,$@) On 2011/09/30 12:17:12, Reinhold wrote: This also does not work with nested includes. If there is a .dep file for the included file, which should be the case after this patch, then everything is being tracked by make, isn't it? http://codereview.appspot.com/5169041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New partcombineUp and partcombineDown functions (issue 4514042)
Pushed as bb7cac7b276bd7d1335523f3be8df815cf894ece. http://codereview.appspot.com/4514042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 1266: Dots in chords can not be moved
This issue bothers me, so I took a look at it. It appears that extremal_head_ of the Dot_position struct found in dot-configuration.hh/.cc and dot-column.cc exists solely to limit the Dots #'direction setting to the main note head. I removed this limitation and it fixed Issue 1266. I've run a few dotting tests and I didn't find any issues with doing this. Still, why was this limitation put in place and can it be removed? Git didn't tell me. Justin ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: countdown to 20111002
Actually, there aren't any patches to be counted down, so here's a weekend holiday for us all. Starting Sunday, I'll be putting out patch batches on Sunday, Tuesday and Thursday, as Mrs Bean Counter and I have dance class on Monday, she works late and I have cello lessons Wednesday, and we both have chorale rehearsal Friday. Cheers, Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
