Re: First stab at getting script offsets right. (issue 5235052)

2011-10-21 Thread m...@apollinemike.com
On Oct 21, 2011, at 3:41 AM, bordage.bertr...@gmail.com wrote:

 LGTM, but the result is really disturbing.  We need to think about a
 better approach of character boxes in MetaFont.  The ideal solution
 would be to create a mask for each character.  For example, a mask for
 the espressivo glyph would be a fill between its 6 dots.
 
 I know it's impossible to interpret this mask in C++...
 

Not necessarily - you can stash all sorts of information in font tables, which 
are then accessible via the otf_tables.
The same thing needs to be done for flags, which have been glued to stems via a 
kludge in the X-offset function for some time.
Janek was toying around with font tables last time I checked in with him - it'd 
take me some time to learn how the metafont part of the code works, so if this 
is something you think you could tackle, I'd be able to implement the C++ side.

 Anyway, I think this patch can be pushed as the first part of a fix to
 issue 1951.
 
 Bertrand
 
 
 http://codereview.appspot.com/5235052/diff/23001/lily/script-engraver.cc
 File lily/script-engraver.cc (right):
 
 http://codereview.appspot.com/5235052/diff/23001/lily/script-engraver.cc#newcode208
 lily/script-engraver.cc:208: int script_count = scripts_.size ();
 vsize instead of int.  Could you change the others above?

fixed.

 
 http://codereview.appspot.com/5235052/diff/23001/lily/script-engraver.cc#newcode209
 lily/script-engraver.cc:209: for (int i = 0; i  script_count; i++)
 vsize.

fixed.

 
 http://codereview.appspot.com/5235052/diff/23001/lily/slur.cc
 File lily/slur.cc (right):
 
 http://codereview.appspot.com/5235052/diff/23001/lily/slur.cc#newcode275
 lily/slur.cc:275: // cannot use is empty because some 0-extent scripts
 I don't understand.  Did you meant if empty?

I meant is_empty (the function).

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for broken beams with consistent slopes (issue 4961041)

2011-10-21 Thread Mike Solomon
Thanks Neil!

On Oct 20, 2011, at 9:24 PM, n.putt...@gmail.com wrote:

 http://codereview.appspot.com/4961041/diff/60001/scm/define-grob-properties.scm
 File scm/define-grob-properties.scm (right):
 
 http://codereview.appspot.com/4961041/diff/60001/scm/define-grob-properties.scm#newcode749
 scm/define-grob-properties.scm:749: (skip-quanting ,boolean? Should
 beam quanting be skipped?)
 Is this likely to be used outside regression testing?

Of this I am not sure.  My gut says yes, but I don't know why the regtest that 
skips quanting was added and the extent to which quantless-beams are used by 
users.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread bordage . bertrand

LGTM.

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: PATCH: Countdown to 20111023

2011-10-21 Thread m...@apollinemike.com
On Oct 21, 2011, at 4:45 AM, Colin Campbell wrote:

 For 22:00 MDT Sunday October 23
 Issue 1506: \tempo after StopStaff/StartStaff forces extension of staff 
 symbol - R 5303043
 
 Issue 1663: Images missing on web site - R 5276054
 
 Issue 1951: Scripts collide with accidentals - R 5235052

Hey all,

I mixed up what was on what countdown and pushed this patch thinking that it 
was on the last countdown.
The pushed version incorporates the comments from Bertrand and Neil, but I can 
revert if people don't want it in master yet.  Alternatively, if anyone has 
comments, please let me know and I'll push a patch on or after 22:00 MDT Sunday 
October 23.

Cheers,
MS___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Make accidental styles available as context mods. (issue 4819064)

2011-10-21 Thread David Kastrup
n.putt...@gmail.com writes:

 On 2011/10/20 05:44:38, dak wrote:
 Sorry, I always start thinking only when far too late in the game.
 Anyway, here
 is a musing:
 should't the _main_ interface to accidental modifications be context
 mods?  You
 won't need to set them in midcontext except in unusual situations, and
 then
 \applyContext (?) is available.

 That would be possible, though you'd probably want a nicer interface
 than using \applyContext directly.  A music function would have to
 have two args: the optional context string and the context-mod
 identifier.

I think the current state of dev/syntax should be committable.  It has
no problems accepting context modifications.  The function signature of
((string? Bottom) ly:context-mod?) should work just fine for accepting
an optional context string defaulting to Bottom and a mandatory
context modification.

I'll try submitting a Rietveld review soonish.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Make accidental styles available as context mods. (issue 4819064)

2011-10-21 Thread Neil Puttock
On 20 October 2011 15:01, David Kastrup d...@gnu.org wrote:

 I think the current state of dev/syntax should be committable.  It has
 no problems accepting context modifications.  The function signature of
 ((string? Bottom) ly:context-mod?) should work just fine for accepting
 an optional context string defaulting to Bottom and a mandatory
 context modification.

The default context would be Staff.  There's some code to switch to
GrandStaff for the piano styles.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: First stab at getting script offsets right. (issue 5235052)

2011-10-21 Thread Werner LEMBERG

 [...] We need to think about a better approach of character boxes
 in MetaFont.  The ideal solution would be to create a mask for each
 character.  [...]

 Not necessarily - you can stash all sorts of information in font
 tables, which are then accessible via the otf_tables.

Exactly.  The meta-ness really helps here in defining auxiliary points
which could serve for better metrics instead of plain boxes.  If you
look up the mailing list, such ideas have already been presented years
ago; cf. this thread:

  http://lists.gnu.org/archive/html/lilypond-devel/2006-11/msg00162.html


  Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: First stab at getting script offsets right. (issue 5235052)

2011-10-21 Thread Bertrand Bordage
Of course.  But I meant it's impossible to interpret a mask that would be a
MetaFont glyph.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread n . puttock


http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc
File lily/spring-smob.cc (right):

http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc#newcode48
lily/spring-smob.cc:48: spring, and @code{min-dist} is the minimum
distance.)
@var{min-dist}

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
Not sure why this doesn't use the DEFAULT_EQUAL_P macro.

Also should have IMPLEMENT_TYPE_P for ly:spring?

(+ entry in lily.scm)

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (right):

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode47
lily/spring-smob.cc:47: Make a spring.  @code{ideal} is the ideal
distance of the 
@var{ideal}

move space to start of next line

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode48
lily/spring-smob.cc:48: spring, and @code{min-dist} is the minimum
distance.)
@var{min-dist}

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode60
lily/spring-smob.cc:60: Set the inverse compress @code{strength} of
@code{spring}.)
@var{strength} @var{spring}

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode72
lily/spring-smob.cc:72: Set the inverse stretch @code{strength} of
@code{spring}.)
@var{strength} @var{spring}

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for broken beams with consistent slopes (issue 4961041)

2011-10-21 Thread Neil Puttock
On 21 October 2011 07:50, Mike Solomon mike...@ufl.edu wrote:

 Of this I am not sure.  My gut says yes, but I don't know why the regtest 
 that skips quanting was added and the extent to which quantless-beams are 
 used by users.

Never, I'd imagine.  I certainly don't recall any users wanting to
switch it off.  I'm just thinking it would be better off being an
internal property.

I might have a few more comments once I've got Ubuntu running again.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread dak


http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:18:06, Neil Puttock wrote:

Not sure why this doesn't use the DEFAULT_EQUAL_P macro.


I'd use scm_is_eq which is less obscure.  However, I have no idea
whether this should not rather be scm_is_true (scm_is_eqv (a, b)) since
otherwise we'll just compare for object identity rather than equal
values.

Is object identity sufficient here?

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread dak

On 2011/10/21 11:27:34, dak wrote:

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):



http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42

lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:18:06, Neil Puttock wrote:
 Not sure why this doesn't use the DEFAULT_EQUAL_P macro.



I'd use scm_is_eq which is less obscure.  However, I have no idea

whether this

should not rather be scm_is_true (scm_is_eqv (a, b)) since otherwise

we'll just

compare for object identity rather than equal values.



Is object identity sufficient here?


Make that scm_is_true (scm_eqv_p (...

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread bordage . bertrand


http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:27:35, dak wrote:

scm_is_true (scm_is_eqv (a, b))


You mean scm_is_true(scm_eqv_p (a, b))? :)

For me, this function is totally useless.  If we want to check whether
they are equal, we use scm_equal_p, if we want to see whether they are
the same object, we use scm_eqv_p.

Besides, I can't find any use for this function with git grep.

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread dak

On 2011/10/21 11:39:41, Bertrand Bordage wrote:

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):



http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42

lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:27:35, dak wrote:
 scm_is_true (scm_is_eqv (a, b))



You mean scm_is_true(scm_eqv_p (a, b))? :)


Yes.


For me, this function is totally useless.  If we want to check whether

they are

equal, we use scm_equal_p, if we want to see whether they are the same

object,

we use scm_eqv_p.


Cough, cough.


Besides, I can't find any use for this function with git grep.


Then it may be saner to just remove it instead of thinking about what we
would like it to do if we wanted it to do something.

http://codereview.appspot.com/5306050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds Scheme function for spring constructor. (issue 5306050)

2011-10-21 Thread Neil Puttock
On 21 October 2011 12:39,  bordage.bertr...@gmail.com wrote:

 For me, this function is totally useless.  If we want to check whether
 they are equal, we use scm_equal_p, if we want to see whether they are
 the same object, we use scm_eqv_p.

 Besides, I can't find any use for this function with git grep.

I think Guile requires it.  The documentation in lily/include/smobs.hh
says all smobs should implement an equal_p () function.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread mtsolo

I'm not sure how to deal with some of the déBordage of line lengths -
you're right that they're ugly, but I dont' see how to chop them down 
stay within good code style.

Thanks for the review!
~Mike


http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g-get_property
(footnote-stencil) != SCM_EOL;
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

footnotes_added = scm_is_pair (g-get_property (footnote-stencil));


Would this work?  footnote-stencil's value is a stencil (not a list), so
would it come up true in scm_is_pair ?

http://codereview.appspot.com/5293053/diff/12001/lily/page-spacing.cc
File lily/page-spacing.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-spacing.cc#newcode76
lily/page-spacing.cc:76: bool has_in_notes;
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

Shouldn't it be has_in_notes_ (with an underscore at the end)?
has_footnotes_ should be defined here too.


Nein, as this is internal to the function (because in_notes only matter
on a line to line basis) whereas has_footnotes_ is valid for the whole
page.

http://codereview.appspot.com/5293053/diff/12001/lily/page-spacing.cc#newcode79
lily/page-spacing.cc:79: in_note_height += (has_in_notes
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

What is the default value of an unset boolean?  I mean: the first

time, is it

adding 0.0 or breaker_-in_note_padding()?


unset_boolean = stupid_programmer

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc#newcode298
lily/system.cc:298: System::internal_get_note_heights_in_range (vsize
start, vsize end, bool foot)
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

Ugh...  A boolean to tell if we're in a footnote or in an in-note...


Why the ugh?

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc#newcode305
lily/system.cc:305: if (foot ? !to_boolean
(footnote_grobs[i]-get_property (footnote)) : to_boolean
(footnote_grobs[i]-get_property (footnote)))
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

Line length.  Plus, I don't really understand what's the use of this.


It keeps either footnotes or in-notes depending on what we want.

http://codereview.appspot.com/5293053/diff/12001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/5293053/diff/12001/scm/define-grob-properties.scm#newcode299
scm/define-grob-properties.scm:299: (footnote ,boolean? Should this be
a footnote or in-note?)
On 2011/10/21 11:52:25, Bertrand Bordage wrote:

Again, this is really ugly.


Perhaps a 'style property instead?  For now, I have it as a boolean
because it could only be one of two things.

http://codereview.appspot.com/5293053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Patch: Allow more argument types, interpret optional argument predicates syntactically.

2011-10-21 Thread David Kastrup

Issue number: 5298050 (http://codereview.appspot.com/5298050)
Issue description:
Allow more argument types, interpret optional argument predicates syntactically.

This is a patch series also available as the dev/syntax branch instead
of a big patch.  It is intended for timely inclusion into Lilypond.
The patches are:

parser.yy: Allow a few more syntactic classes for Scheme arguments


programming-interface.itely: explain extended function argument semantics


parser.yy: Allow markups, markup lists, and context modifications as Scheme
arguments


Add regtest for skipping optional arguments via predicate.


parser.yy: allow optional Scheme arguments to be skipped based on the predicate.


parser.yy: allow music rather than closed_music in connection with lyrics


parser.yy: let closed_music accept a few complex forms


parser: change order of arguments for context-specification constructor


parser.yy et al: move functionality of run_music_function into syntax
constructor

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Make doc broken - 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf

2011-10-21 Thread Peekay Ex
Mike

I think 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf is the checkin that
breaks make doc.

I've done a hard reset to the checkin before and had no problems as
soon as I have this checkin in the tree make doc fails.

Sorry.

-- 
--
James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread bordage . bertrand


http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g-get_property
(footnote-stencil) != SCM_EOL;
Of course not :o$  I recommend to_boolean.  It returns true for
everything except SCM_EOL and SCM_BOOL_F.

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc#newcode298
lily/system.cc:298: System::internal_get_note_heights_in_range (vsize
start, vsize end, bool foot)
I wanted to express my disgust.  Not the french Ugh that could refer
to your amerindian origins :)

http://codereview.appspot.com/5293053/diff/12001/lily/system.cc#newcode305
lily/system.cc:305: if (foot ? !to_boolean
(footnote_grobs[i]-get_property (footnote)) : to_boolean
(footnote_grobs[i]-get_property (footnote)))
Ok.  I thought footnote_grobs was only using footnotes.  Maybe you
should change the names of footnote_grobs and
get_footnote_grobs_in_range?
And change this long line for:
if (!to_boolean (footnote_grobs[i]-get_property (footnote)))

http://codereview.appspot.com/5293053/diff/12001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/5293053/diff/12001/scm/define-grob-properties.scm#newcode299
scm/define-grob-properties.scm:299: (footnote ,boolean? Should this be
a footnote or in-note?)
Something like that.  I think style implicitly stands for musical
notation style, so we need to find something better.

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread bordage . bertrand

A small comment to show you a possible solution for the indentation.
This can be apply at every line length comment.


http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
lily/page-breaking.cc:189: old.in_note_heights_.begin (),
old.in_note_heights_.end ());
I'm not sure, but maybe:
compressed.footnote_heights_.insert
(compressed.footnote_heights_.begin (),
 old.footnote_heights_.begin (),
 old.footnote_heights_.end ());

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread percival . music . ca


http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
lily/page-breaking.cc:189: old.in_note_heights_.begin (),
old.in_note_heights_.end ());
Why are we talking about C++ style?

Run it through fix-cc.py.  Whatever that produces is ok as far as this
patch goes.
(if something looks bad, then we can discuss modifying fix-cc.py in some
way -- but that's a separate issue from whether we accept this patch or
not.)

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread n . puttock


http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g-get_property
(footnote-stencil) != SCM_EOL;
On 2011/10/21 20:07:37, Bertrand Bordage wrote:

Of course not :o$  I recommend to_boolean.  It returns true for

everything

except SCM_EOL and SCM_BOOL_F.


Don't do this.  to_boolean should only be used with properties which are
booleans.

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread dak


http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g-get_property
(footnote-stencil) != SCM_EOL;
On 2011/10/21 20:07:37, Bertrand Bordage wrote:

Of course not :o$  I recommend to_boolean.  It returns true for

everything

except SCM_EOL and SCM_BOOL_F.

Since when?

It returns true for SCM_BOOL_T and nothing else.

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread bordage . bertrand

Sorry for this total mistake.  !ly_is_equal (..., SCM_EOL) should do it,
then.

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Sketch for in-notes. (issue 5293053)

2011-10-21 Thread dak

On 2011/10/21 23:49:26, Bertrand Bordage wrote:

Sorry for this total mistake.  !ly_is_equal (..., SCM_EOL) should do

it, then.

It is pretty pointless to use ly_is_equal instead of scm_is_eq on
SCM_EOL, and !scm_is_null (...) is prettier anyway.

http://codereview.appspot.com/5293053/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Make doc broken - 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf

2011-10-21 Thread Graham Percival
On Fri, Oct 21, 2011 at 08:18:39PM +0100, Peekay Ex wrote:
 I think 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf is the checkin that
 breaks make doc.

It's a good thing that I looked at this at 5am, because upon
examining the commit I unleashed a loud obscenity.  I use the word
mao in real life as well as online; I can count the number of
times that I've used a curse word within hearing of anybody else
on one hand.

Mike, please examine the fix carefully:
  a6a3f2bfa82f7c9e8f7b153a4cb649beaef80c16

In the future, please push to the dev/staging branch.  I'm not
asking you to check the compilation yourself, nor am I asking you
to refrain from making simple last-minute fixes.  But
there's been too many (i.e. more than 1 per year) little problems
like this.

dev/staging will be merged with master at least once every 24
hours[1] as long as it
compiles.  Furthermore, I pledge that I will *always* merge from
dev/staging (if it compiles) before making a release.  So it
really adds no significant delay to getting your bugfixes+features
in the hands of users.

[1] possibly once every 12, 8, or 4 hours, depending on whether
people with powerful computers want to leave their computers
running overnight, and/or if we could coordinate timing with
people in different time zones -- we could have each person run it
every 24 hours, but if we stagger it between 3 or 4 people we
could get great coverage.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel