Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)
On 2012/10/23 19:45:15, dak wrote: On 2012/10/23 19:05:09, marc wrote: Hey, that was quick! Thanks for solving this issue - LGTM! Well, there is no regtest and no documentation, so it is not like there is nothing left to do. That's right – we had this discussion before concerning new features and the documentation part. The 'LGTM' is just meant for the code you uploaded for review – I like the way you rework parts of lilypond on-the-fly while adding new features instead of just adding a lot of new stuff (as I had probably done it). And to be honest, the usual to check this feature, you have used some code and could equally well turn this into a regtest does not even apply. I haven't checked anything. This cannot be seen by reviewing this patch alone, so I had to trust on you ;-) http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: adds documentation for the new bar line interface (issue 6742061)
On 2012/10/23 23:22:03, J_lowe wrote:
One typo so, as we need to fix this, I also included a minor grammar
change.
Otherwise LGTM.
https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely#newcode2815
Documentation/notation/rhythms.itely:2815: The @code{=} bar line
provides the
double span bar line used
...bar line, used in combination...
Done.
https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely#newcode2821
Documentation/notation/rhythms.itely:2821: are useful to distinguish
bar lines
with identical appearance
...to distinguish those with identical...
Done.
Thanks for your comments and improvements!
https://codereview.appspot.com/6742061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This is the non-invasive version of the full Issue 2883 patch. (issue 6651053)
the description LGTM (i.e. i'm ok with what you say this patch does). I'm sorry that i don't give any feedback on the actual code, but it's about a thousand lines of changes and i don't have time to read them :( Janek http://codereview.appspot.com/6651053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: prevent collision of ligatures and next note (issue 6740046)
hi Pal, On Tue, Oct 23, 2012 at 8:56 PM, benko@gmail.com wrote: in C++ there should be a good reason to pass complex structures like std::vectorGrob_info by value, not by reference to const; in this case there's no such reason, pass-by-reference works perfectly. Ah, so this is a by-the-way fix. Can it be in a separate commit, please? As for the commit message, it you changed it, i don't see the new one. You may want to try updating your git-cl with Julien Rioux's changes - they improve description handling and other things. it _was_ related (see usage of dot_count lower); I hope the new organization is cleaner. ah, i see it now, thanks. best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Revert Archive baselines in LILYPOND_BASELINES directory if specified (issue 6709073)
LGTM http://codereview.appspot.com/6709073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)
LGTM shall the tracker issues write doc for this and add a regtest for this be added now or after this patch is pushed? (my concern is to make sure that we won't forget) cheers, Janek http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)
On 2012/10/24 09:58:12, janek wrote: LGTM shall the tracker issues write doc for this It is not as much write doc for this as the function itself has its docs updated. It is more update the existing docs in the manual to reflect the change. and add a regtest for this be added now or after this patch is pushed? (my concern is to make sure that we won't forget) I am not planning on working on this myself but that does not preclude someone else from submitting the respective parts which I would then incorporate into the patch. So I would lean towards waiting with creating the doc/regtest issues until the patch is indeed being pushed. http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix unproper nesting of various property overrides (issue 6685044)
LGTM can you please change tenses in the commit message? Every time i see a sentence like \acciaccatura and \slashedGrace lose any previous setting of Flag.stroke-style. i think that it means that *the result of the patch* is that previous settings are lost. I think it would be better to write before this patch, \acciaccatura and \slashedGrace were losing any previous setting of Flag.stroke-style. cheers, Janek PS as usual, i dedicate my code reviews to Graham Percival. btw, i hope that's not embarassing for him... http://codereview.appspot.com/6685044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: prevent collision of ligatures and next note (issue 6740046)
in C++ there should be a good reason to pass complex structures like std::vectorGrob_info by value, not by reference to const; in this case there's no such reason, pass-by-reference works perfectly. Ah, so this is a by-the-way fix. Can it be in a separate commit, please? it is; I meant to note it but forgot, sorry. is there interest in pushing such multi-commit patches to some dev branch? As for the commit message, it you changed it, i don't see the new one. You may want to try updating your git-cl with Julien Rioux's changes - they improve description handling and other things. will look at it. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
I found some ambiguities in descriptions.
Janek
http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly
File input/regression/measure-counter-broken.ly (right):
http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6
input/regression/measure-counter-broken.ly:6: enclosed in parentheses.
Do you mean that the number before the break is not parenthesized, and
the number of the part after the break is parenthesized?
It may be worth rewording this sentence.
http://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):
http://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm#newcode49
scm/define-event-classes.scm:49: tremolo-span-event tuplet-span-event))
i think there's something wrong with the indentation here, but
considering how nitpicking about indentation didn't do us any good in
the past i'm leaning towards not caring about it.
http://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm#newcode204
scm/define-grob-properties.scm:204: (count-from ,integer? The number
beginning a measure count.)
I suppose you mean In a measure count, don't print numbers lower than
this one?
I mean, count-from could work either like this
{
\override MeasureCount count-from = 3
\startMeasureCount
a1 % no number
b1 % no number
a1 % 3
b1 % 4
}
or like this
{
\override MeasureCount count-from = 3
\startMeasureCount
a1 % 3
b1 % 4
a1 % 5
b1 % 6
}
It's important to make it clear in which way count-from works.
http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode27
scm/scheme-engravers.scm:27: spanners. Each spanner is bounded by the
first command column of successive
what is a command column?
http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode61
scm/scheme-engravers.scm:61: ; if this is not done, _all_ command
columns will be numbered
so, sometimes all command columns will be nubmered?
or do you mean that the code needs to make sure that we're in a new bar
because if it didn't, all command columns would be numbered and that's
something we don't want?
In other words, maybe _all_ command columns would be numbered would be
a better wording?
http://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode67
scm/scheme-engravers.scm:67: ; first column of measure, even if grace
notes appear?
umm, i don't understand. Is it a question about what this code actually
does? Or some kind of rhethoric-question-comment? ;)
http://codereview.appspot.com/6730044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: prevent collision of ligatures and next note (issue 6740046)
On Wed, Oct 24, 2012 at 12:36 PM, Benkő Pál benko@gmail.com wrote: in C++ there should be a good reason to pass complex structures like std::vectorGrob_info by value, not by reference to const; in this case there's no such reason, pass-by-reference works perfectly. Ah, so this is a by-the-way fix. Can it be in a separate commit, please? it is; I meant to note it but forgot, sorry. is there interest in pushing such multi-commit patches to some dev branch? sometimes, but i don't think this one is big enough to be worth the trouble. cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: prevent collision of ligatures and next note (issue 6740046)
On 2012/10/24 10:36:52, benko.pal wrote: [...] Ah, so this is a by-the-way fix. Can it be in a separate commit, please? it is; I meant to note it but forgot, sorry. is there interest in pushing such multi-commit patches to some dev branch? If there is, people should ask. Substructuring an issue into several logical commits is good style and makes things easier afterwards, but only few people will actively prefer reviewing changes in a branch over using Rietveld, so you can save yourself the trouble of creating a public branch unless someone asks for it. Just make sure that every commit leaves the tree in compilable state. I've made branches available occasionally for humongous changes but I don't think they have been used much for reviewing. http://codereview.appspot.com/6740046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
Thanks for your review, Janek!
https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly
File input/regression/measure-counter-broken.ly (right):
https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6
input/regression/measure-counter-broken.ly:6: enclosed in parentheses.
On 2012/10/24 10:37:08, janek wrote:
Do you mean that the number before the break is not parenthesized, and
the
number of the part after the break is parenthesized?
It may be worth rewording this sentence.
Done.
https://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):
https://codereview.appspot.com/6730044/diff/10001/scm/define-event-classes.scm#newcode49
scm/define-event-classes.scm:49: tremolo-span-event tuplet-span-event))
On 2012/10/24 10:37:08, janek wrote:
i think there's something wrong with the indentation here, but
considering how
nitpicking about indentation didn't do us any good in the past i'm
leaning
towards not caring about it.
Yes, it looks pretty bad, and the original doesn't appear to be right
either. I made this consistent with `rhythmic-event' below.
https://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
https://codereview.appspot.com/6730044/diff/10001/scm/define-grob-properties.scm#newcode204
scm/define-grob-properties.scm:204: (count-from ,integer? The number
beginning a measure count.)
On 2012/10/24 10:37:08, janek wrote:
I mean, count-from could work either like this
{
\override MeasureCount count-from = 3
\startMeasureCount
a1 % no number
b1 % no number
a1 % 3
b1 % 4
}
or like this
{
\override MeasureCount count-from = 3
\startMeasureCount
a1 % 3
b1 % 4
a1 % 5
b1 % 6
}
The second example above is the way it works. Hopefully my revisions
make this a bit clearer!
https://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):
https://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode27
scm/scheme-engravers.scm:27: spanners. Each spanner is bounded by the
first command column of successive
On 2012/10/24 10:37:08, janek wrote:
what is a command column?
In the IR we find:
currentCommandColumn (graphical (layout) object)
Grob that is X-parent to all current breakable (clef, key signature,
etc.) items.
I changed the capitalization and enclosed it in @code{ } elsewhere.
Hope this makes it clearer (or a search more fruitful).
https://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode61
scm/scheme-engravers.scm:61: ; if this is not done, _all_ command
columns will be numbered
On 2012/10/24 10:37:08, janek wrote:
so, sometimes all command columns will be nubmered?
or do you mean that the code needs to make sure that we're in a new
bar because
if it didn't, all command columns would be numbered and that's
something we
don't want?
Yes, exactly. If this check weren't in place, you would get many many
numbers.
In other words, maybe _all_ command columns would be numbered would
be a
better wording?
Yes, it would. I made some more substantial changes here.
https://codereview.appspot.com/6730044/diff/10001/scm/scheme-engravers.scm#newcode67
scm/scheme-engravers.scm:67: ; first column of measure, even if grace
notes appear?
On 2012/10/24 10:37:08, janek wrote:
umm, i don't understand. Is it a question about what this code
actually does?
Or some kind of rhethoric-question-comment? ;)
Oh, I was just mimicking the variable name with its question mark. The
comment refers to the need to check for the first column of the measure.
I made this a little less chatty :)
https://codereview.appspot.com/6730044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
much clearer now, thanks! LGTM Janek https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: prevent collision of ligatures and next note (issue 6740046)
Ah, so this is a by-the-way fix. Can it be in a separate commit, please? it is; I meant to note it but forgot, sorry. is there interest in pushing such multi-commit patches to some dev branch? If there is, people should ask. Substructuring an issue into several logical commits is good style and makes things easier afterwards, but only few people will actively prefer reviewing changes in a branch over using Rietveld, so you can save yourself the trouble of creating a public branch unless someone asks for it. I meant opening a Rietveld issue with all changes and an announcement of a dev branch with several commits. Just make sure that every commit leaves the tree in compilable state. of course. I've verified that the pass-by-reference commit didn't change the regtests. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
I've opened http://code.google.com/p/lilypond/issues/detail?id=2924 for the Documentation in the NR https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
Also, should we include Measure_counter_engraver in the Staff context by default? (it'd make documenting it simpler in the @lilypond if nothing else :) ) https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: CG: fixed wrong link to Contact
Federico On 23 October 2012 07:35, Federico Bruni fedel...@gmail.com wrote: While investigating issue 2266, I found this wrong link in CG. Find micro-patch attached ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel This passes a make doc - I checked just in case - I see no reason why you cannot just push this one char change directly to staging. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: CG: fixed wrong link to Contact
2012/10/24 James pkx1...@gmail.com: This passes a make doc - I checked just in case - I see no reason why you cannot just push this one char change directly to staging. I can't because I'm not on my laptop (until Saturday). Could you push it for me? Thanks ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Doc: Pitches.itely @knownissue OctavateEight grob (issue 6761045)
LGTM, but just a thought - might it be better to override the colour so the change results in something visible rather than just an absence of the clef? Trevor http://codereview.appspot.com/6761045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: 2.16.1
- Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Saturday, October 20, 2012 10:17 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: David, I see you've done a lot of moving updates into 2.16.1. When do you expect to want a release for this? I've asked on the translator list whether they want to get something translated from all the cherry-picking, and feedback is incomplete yet. -- David Kastrup How are we looking now? There are a lot of changes in 16.1 compared with 16.0 - should it be released as a Release Candidate, do you think? (NB - I'm not sure how this would be done at present, just musing). -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: Pitches.itely @knownissue OctavateEight grob (issue 6761045)
Reviewers: Trevor Daniels,
Message:
On 2012/10/24 14:57:28, Trevor Daniels wrote:
LGTM, but just a thought - might it be better
to override the colour so the change results in
something visible rather than just an absence of
the clef?
Trevor
Good idea.
Next patch on its way.
James
Description:
Doc: Pitches.itely @knownissue OctavateEight grob
Issue 2832
Shows that any integers attached to a Clef is treated as a separate Grob
so any override applied to the Clef also has to be applied
as a separate override to the OctavateEight grob.
Includes brief description and @lilypond example.
Please review this at https://codereview.appspot.com/6761045/
Affected files:
M Documentation/notation/pitches.itely
Index: Documentation/notation/pitches.itely
diff --git a/Documentation/notation/pitches.itely
b/Documentation/notation/pitches.itely
index
860babdc821d081bef8a96ed4042c699f1fc4683..3b7ca08ce8ec83c5cc8282e616a7e1f2de92b940
100644
--- a/Documentation/notation/pitches.itely
+++ b/Documentation/notation/pitches.itely
@@ -1179,6 +1179,21 @@ Internals Reference:
@rinternals{OctavateEight},
@rinternals{clef-interface}.
+@knownissues
+Any integers that are attached to clefs are treated as separate grobs,
+so any @code{\override} done to the @var{Clef} will also need to be
+applied, as a separate @code{\override}, to the @var{OctavateEight}
+grob.
+
+@lilypond[fragment,quote,relative=1]
+\new Staff \with {
+ \override OctavateEight #'transparent = ##t
+ \override Clef #'transparent = ##t
+}
+
+\clef treble_8 c4
+@end lilypond
+
@node Key signature
@unnumberedsubsubsec Key signature
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: lilypond 2.16.0 and Windows 8 (enterprise)
Hello, On 3 October 2012 07:54, Janek Warchoł janek.lilyp...@gmail.com wrote: On Tue, Oct 2, 2012 at 3:09 PM, James pkx1...@gmail.com wrote: Hello, Just an FYI, I was able to download install and run LP's test file with no problems, on Windows 8.x (Enterprise Edition), I am not sure if that is really significant vs Standard Edition but anyway. Just thought I'd share this. thanks! If that is 'good enough' we could update http://lilypond.org/windows.html accordingly i think so. cheers, Janek http://code.google.com/p/lilypond/issues/detail?id=2925 Just to be polite. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: 2.16.1
Phil Holmes em...@philholmes.net writes: - Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Saturday, October 20, 2012 10:17 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: David, I see you've done a lot of moving updates into 2.16.1. When do you expect to want a release for this? I've asked on the translator list whether they want to get something translated from all the cherry-picking, and feedback is incomplete yet. -- David Kastrup How are we looking now? git log --oneline --summary origin/stable/2.16..origin/translation c78a460 Doc-es: update Changes. Documentation/es/changes.tely |9 + 1 file changed, 5 insertions(+), 4 deletions(-) d8f3f53 Doc-es: update Rhythms. Documentation/es/notation/rhythms.itely | 74 +-- 1 file changed, 60 insertions(+), 14 deletions(-) 09f338e Doc-es: fix another xref. Documentation/es/notation/input.itely |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) f199e87 Web-it: update for 2.16.1 release Documentation/it/learning/fundamental.itely |4 +- Documentation/it/learning/tweaks.itely | 16 Documentation/it/notation/pitches.itely |6 +-- Documentation/it/search-box.ihtml |2 +- Documentation/it/usage/lilypond-book.itely |2 +- Documentation/it/web/download.itexi |4 +- Documentation/it/web/introduction.itexi | 55 ++- 7 files changed, 61 insertions(+), 28 deletions(-) a072162 Doc-es: update Input. Documentation/es/notation/input.itely | 704 ++--- 1 file changed, 471 insertions(+), 233 deletions(-) c4248fd Doc-es: fix xref. Documentation/es/notation/text.itely |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) f5c01cc Doc-es: update Tweaks, Expressive, Keyboards and Spacing. Documentation/es/learning/common-notation.itely |9 ++-- Documentation/es/learning/tweaks.itely | 32 +++--- Documentation/es/notation/expressive.itely | 54 --- Documentation/es/notation/input.itely | 22 - Documentation/es/notation/keyboards.itely |7 ++- Documentation/es/notation/spacing.itely | 29 +++- 6 files changed, 103 insertions(+), 50 deletions(-) 7df3f88 Doc-es: partial update. Documentation/es/essay/engraving.itely|2 +- Documentation/es/learning/fundamental.itely |4 ++-- Documentation/es/notation/ancient.itely |2 +- Documentation/es/notation/changing-defaults.itely |2 +- Documentation/es/notation/fretted-strings.itely |2 +- Documentation/es/notation/percussion.itely|2 +- Documentation/es/notation/pitches.itely |6 +++--- Documentation/es/notation/simultaneous.itely | 12 ++-- Documentation/es/notation/vocal.itely |2 +- Documentation/es/search-box.ihtml |2 +- Documentation/es/usage/lilypond-book.itely|2 +- Documentation/es/web/download.itexi |4 +--- 12 files changed, 20 insertions(+), 22 deletions(-) 2784264 Merge remote-tracking branch 'origin/stable/2.16' into translation 94e770a Web-fr: update searchbox Documentation/fr/search-box.ihtml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 5198521 Doc-de: update commitsh strings to reflect status as up-to-date Documentation/de/essay/engraving.itely |2 +- Documentation/de/essay/literature.itely|2 +- .../de/extending/programming-interface.itely |2 +- Documentation/de/extending/scheme-tutorial.itely |2 +- Documentation/de/learning/common-notation.itely|2 +- Documentation/de/learning/fundamental.itely|2 +- Documentation/de/learning/preface.itely|2 +- Documentation/de/learning/templates.itely |2 +- Documentation/de/learning/tutorial.itely |2 +- Documentation/de/learning/tweaks.itely |2 +- Documentation/de/notation/ancient.itely|2 +- Documentation/de/notation/changing-defaults.itely |2 +- Documentation/de/notation/cheatsheet.itely |2 +- Documentation/de/notation/chords.itely |2 +- Documentation/de/notation/contemporary.itely |2 +- Documentation/de/notation/editorial.itely |2 +- Documentation/de/notation/expressive.itely |2 +- Documentation/de/notation/fretted-strings.itely|2 +- Documentation/de/notation/input.itely |2 +- Documentation/de/notation/keyboards.itely |2 +- .../de/notation/notation-appendices.itely |2 +- Documentation/de/notation/notation.itely |2 +- Documentation/de/notation/percussion.itely |2 +- Documentation/de/notation/pitches.itely|
Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)
On 2012/10/24 10:07:25, dak wrote: On 2012/10/24 09:58:12, janek wrote: LGTM shall the tracker issues write doc for this It is not as much write doc for this as the function itself has its docs updated. It is more update the existing docs in the manual to reflect the change. and add a regtest for this be added now or after this patch is pushed? (my concern is to make sure that we won't forget) I am not planning on working on this myself but that does not preclude someone else from submitting the respective parts which I would then incorporate into the patch. So I would lean towards waiting with creating the doc/regtest issues until the patch is indeed being pushed. NR Doc tracker is here http://code.google.com/p/lilypond/issues/detail?id=2922 I think someone who knows better than I ought to make the regression test. James https://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Web: Add reference to Windows 8 in downloads (issue 6762046)
LGTM https://codereview.appspot.com/6762046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: 2.16.1
- Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Wednesday, October 24, 2012 4:28 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: - Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Saturday, October 20, 2012 10:17 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: David, I see you've done a lot of moving updates into 2.16.1. When do you expect to want a release for this? I've asked on the translator list whether they want to get something translated from all the cherry-picking, and feedback is incomplete yet. -- David Kastrup How are we looking now? git log --oneline --summary origin/stable/2.16..origin/translation When do you want 2.16.1 built? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: 2.16.1
Phil Holmes m...@philholmes.net writes: - Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Wednesday, October 24, 2012 4:28 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: - Original Message - From: David Kastrup d...@gnu.org To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Saturday, October 20, 2012 10:17 PM Subject: Re: 2.16.1 Phil Holmes em...@philholmes.net writes: David, I see you've done a lot of moving updates into 2.16.1. When do you expect to want a release for this? I've asked on the translator list whether they want to get something translated from all the cherry-picking, and feedback is incomplete yet. -- David Kastrup How are we looking now? git log --oneline --summary origin/stable/2.16..origin/translation When do you want 2.16.1 built? Don't panic. I still have no idea for the changes.tely file. Anybody with experience for that? Just point to Fixed_2_16_1 tags in the tracker? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: 2.16.1
Le 24/10/2012 17:28, David Kastrup disait : Phil Holmes em...@philholmes.net writes: - Original Message - From: David Kastrup To: Phil Holmes Cc: Devel Sent: Saturday, October 20, 2012 10:17 PM Subject: Re: 2.16.1 Phil Holmes writes: David, I see you've done a lot of moving updates into 2.16.1. When do you expect to want a release for this? I've asked on the translator list whether they want to get something translated from all the cherry-picking, and feedback is incomplete yet. -- David Kastrup How are we looking now? git log --oneline --summary origin/stable/2.16..origin/translation [...] I apologize for the long read. I just wanted to point out just _how_ busy our translator team is, and usually their work is practically invisible to normal development. I just pushed a first part of updates for French. I still have to treat input.itely (titles headers), rhythms.itely and spacing.itely (because of xrefs), and hope to send them before Sunday. Cheers, Jean-Charles ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)
On Wed, Oct 24, 2012 at 4:10 PM, pkx1...@gmail.com wrote: Also, should we include Measure_counter_engraver in the Staff context by default? (it'd make documenting it simpler in the @lilypond if nothing else :) ) +1 from me :) Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
