Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 20:58:41, thomasmorley651 wrote: On 2015/07/12 18:09:03, dak wrote: It may be worth trying if this makes the rather awkward fix for issue 3388 unnecessary, but I would guess that the problem is likely sufficiently different that that fix is still needed. As far as I can tell my patch will not cure issue 3388. Though, I don't fully understand 3388. Maybe better to recheck yourself. The only other somehow related thing I've found is: C/P-error should read: Author: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-15 18:31:17 Committer: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-15 18:31:17 Parent: 3d571d9c80b7855422c96ecc6966bcbfa4dfb9ff (Add feature to link to a particular page or a page containing a given label) Child: 7703d5ed1ce797d92449a6a79ce593e6e5601396 (Fix problem with multiple markups on chord glissandos.) Branches: dev/toc-crash-with-link, master and many more (42) Follows: release/2.13.59-1 Precedes: release/2.13.60-1 Fix TOC: don't add links to non-existing labels in the .ps file https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 18:09:03, dak wrote: On 2015/07/12 17:49:44, thomasmorley651 wrote: Do the links actually work when first-page-number is, say, 10? yes If so, did they not work before? No, it was broken. Well, then we probably have to thank Ghostscript for bringing this long-standing problem to our attention. As far as I can tell other first-page-numbers than 1 are leading to wrong links right from the initial implementation of \with-link. Rereading the discussion http://lilypond.1069038.n5.nabble.com/PDF-hyperlinks-td93369.html and regarding the commit Author: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-12 12:16:59 Committer: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-15 15:49:25 Parent: 9f651e1f5143787aeda825a4061f82eede4943a3 (Doc: addition to MIDI and repeats by Tom Cloyd.) Child: 98b9439fda0b019a67cfe63b0c0c5bb99ded618e (Fix TOC: don't add links to non-existing labels in the .ps file) Branches: dev/toc-crash-with-link, master and many more (42) Follows: release/2.13.59-1 Precedes: release/2.13.60-1 Add feature to link to a particular page or a page containing a given label The main part of this patch was done by Dan Eble and posted to the lilypond-devel mailinglist on December 27, 2010. Like \with-url, this works only with the PDF backend. -) Add markup functions \with-link (links to the page containing the given label) and \page-link (links to the given page number) -) Internally, they are handled like the \with-url markup function, creating a pdfmark in the .ps file that creates the link in the PDF file. -) Add links to the pages for all TOC entries. I'd say it was never considered It may be worth trying if this makes the rather awkward fix for issue 3388 unnecessary, but I would guess that the problem is likely sufficiently different that that fix is still needed. As far as I can tell my patch will not cure issue 3388. Though, I don't fully understand 3388. Maybe better to recheck yourself. The only other somehow related thing I've found is: Author: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-12 12:16:59 Committer: Reinhold Kainhofer reinh...@kainhofer.com 2011-04-15 15:49:25 Parent: 9f651e1f5143787aeda825a4061f82eede4943a3 (Doc: addition to MIDI and repeats by Tom Cloyd.) Child: 98b9439fda0b019a67cfe63b0c0c5bb99ded618e (Fix TOC: don't add links to non-existing labels in the .ps file) Branches: dev/toc-crash-with-link, master and many more (42) Follows: release/2.13.59-1 Precedes: release/2.13.60-1 Add feature to link to a particular page or a page containing a given label The main part of this patch was done by Dan Eble and posted to the lilypond-devel mailinglist on December 27, 2010. Like \with-url, this works only with the PDF backend. -) Add markup functions \with-link (links to the page containing the given label) and \page-link (links to the given page number) -) Internally, they are handled like the \with-url markup function, creating a pdfmark in the .ps file that creates the link in the PDF file. -) Add links to the pages for all TOC entries. https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 23:39:52, dak wrote: On 2015/07/12 17:49:44, thomasmorley651 wrote: On 2015/07/12 17:01:06, dak wrote: https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 first-page-number Uh, (- table-page-number (1- first-page-number)) ? done Now I get second thoughts. The problem is that I actually have no clue how this calculation comes about. Is it because logical pages are counted from 1? If you mean that the pdf's first page is always page 1 of the document (whatever page-number is printed actually), then yes. If so, this likely should rather be (1+ (- table-page-number first-page-number)) instead. Basically, the calculation should reflect the underlying logic. Whatever that may be. Changed to your proposal. https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 17:49:44, thomasmorley651 wrote: On 2015/07/12 17:01:06, dak wrote: https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 first-page-number Uh, (- table-page-number (1- first-page-number)) ? done Now I get second thoughts. The problem is that I actually have no clue how this calculation comes about. Is it because logical pages are counted from 1? If so, this likely should rather be (1+ (- table-page-number first-page-number)) instead. Basically, the calculation should reflect the underlying logic. Whatever that may be. https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Provide music functions property-{override,revert,set,unset} (issue 251130043 by d...@gnu.org)
Reviewers: ,
Message:
Well, the consideration for choosing a hyphenated name here instead of
camel case (namely property-override instead of propertyOverride) was
that the main usage was from Scheme anyway. But since it is a proper
music function nevertheless, I now tend to think that I should not
diverge from the normal naming scheme and change that to
propertyOverride etc. Yes, it will look a bit out of place in Scheme
code but so do all the other music functions consisting of more than one
word. So I'll be uploading an appropriately changed version next.
Description:
Provide music functions property-{override,revert,set,unset}
The previous music functions `override' and `revert' (intentionally
colliding with the respective keywords) are removed. It would have been
too confusing to have collisions for `set' and `unset' as well which are
just too similar to existing Scheme constructs.
A convert-ly rule for the previous calls override/revert is not
attempted: they have not yet been documented and have been available
only for one unstable version. Whoever happened to use them already is
capable of replacing them.
Provide check-context-path function
Please review this at https://codereview.appspot.com/251130043/
Affected files (+103, -55 lines):
M ly/music-functions-init.ly
M scm/music-functions.scm
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Anything wrong with patchy-staging?
James Lowe p...@gnu.org writes: On 11/07/15 17:07, David Kastrup wrote: Issue 4475 has been pushed about 3.5h ago to staging. I thought we had a Patchy-staging run about every 2 hours? Does this mean that there has been a failure? Yes or my Internet connection is broken! - although I think there is a few of us running patchy-staging (i.e. the server in France?) and that usually sends an email. I think the server in France is my laptop and I've switched off the Emails to mailing lists by now. I pushed the more important change to staging anyway now (the one I definitely want to see in 2.19.23) and started my own lilypond-patchy-staging. But I'll be away if and when it finishes. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Anything wrong with patchy-staging?
James Lowe p...@gnu.org writes:
On 11/07/15 17:07, David Kastrup wrote:
Issue 4475 has been pushed about 3.5h ago to staging. I thought we
had a Patchy-staging run about every 2 hours? Does this mean that
there has been a failure?
Problem is that I'm likely off in about an hour, and if I start a
Patchy-staging run now, it will not be finished before I am gone.
And I'd like to push my remaining issues to staging anyway but
would prefer not having to rebase everything in case the current
staging _is_ rotten.
So is there anything worth noting concerning the current state of
staging and/or Patchy?
Its that same error we had yesterday when I was testing patches I think
--snip--
james@james-OptiPlex-990 /tmp$ more
build-lilypond-autobuild/input/regression/collated-files.texilog.log
*** '}' without opening '{' before: . The pitches in
@code{\autochange} are (in out-test/autochange-r
elative.texidoc l. 3)
--snip--
It's failing on the make test part of patchy staging
Yeah, just got the complaint from my server in France.
It's obviously
@{\\autochange}.
in a comment from Dan. Always a risk when pushing something that has
not been tested in that form.
Ok, so I'll back out the commit from Dan and put my commits in instead.
And then I'll have to be off.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
16:32:43 (UTC) Begin LilyPond compile, previous commit at ccad67c0a33e9b5d6e63ec8072f229026c777490 16:33:01 Merged staging, now at:ccad67c0a33e9b5d6e63ec8072f229026c777490 16:33:02Success:./autogen.sh --noconfigure 16:33:21Success:/tmp/lilypond-autobuild/configure --enable-checking 16:33:25Success:nice make clean 16:42:43Success:nice make -j3 CPU_COUNT=3 16:48:03 *** FAILED BUILD *** nice make test -j3 CPU_COUNT=3 Previous good commit: 8499cabe34365c7160ff32f777d3db428b8f8200 Current broken commit: ccad67c0a33e9b5d6e63ec8072f229026c777490 16:48:03 *** FAILED STEP *** merge from staging Failed runner: nice make test -j3 CPU_COUNT=3 See the log file log-staging-nice-make-test--j3-CPU_COUNT=3.txt 16:48:03 Traceback (most recent call last): File /usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py, line 528, in handle_staging self.build (issue_id=issue_id) File /usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py, line 328, in build issue_id) File /usr/local/tmp/lilypond-extra/patches/compile_lilypond_test/__init__.py, line 266, in runner raise FailedCommand (Failed runner: %s\nSee the log file %s % (command, this_logfilename)) FailedCommand: Failed runner: nice make test -j3 CPU_COUNT=3 See the log file log-staging-nice-make-test--j3-CPU_COUNT=3.txt ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR - 1.2.5 - Bar Numbers - added snippet (issue 106320046 by pkx1...@gmail.com)
https://codereview.appspot.com/106320046/diff/1/Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly File Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly (right): https://codereview.appspot.com/106320046/diff/1/Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly#newcode16 Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly:16: \override Score.BarNumber #'break-visibility = #end-of-line-invisible On 2014/07/04 12:10:56, david.nalesnik wrote: Score.BarNumber.break-visibility Done. https://codereview.appspot.com/106320046/diff/1/Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly#newcode16 Documentation/snippets/new/printing-bar-numbers-with-changing-regular-intervals.ly:16: \override Score.BarNumber #'break-visibility = #end-of-line-invisible On 2014/07/04 07:59:42, Mark Polesky wrote: CG 5.4.4 says to indent ly code with two spaces. Done. https://codereview.appspot.com/106320046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
GUB fail in mingw build - Issue 4462
I'm getting a failure to build GUB, as shown below: /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc: In member function 'void Scm_module::import()': /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:71:7: error: expected primary- expression before 'struct' SCM interface = scm_c_resolve_module (name_); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:76:5: error: expected primary- expression before 'struct' interface = Guile_user::module_public_interface (interface); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:80:24: error: expected primary- expression before 'struct' p-var_-import (interface, p-name_); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:85:13: error: expected primary- expression before 'struct' module_ = interface; ^ make[1]: *** [out/lily-modules.o] Error 1 Looks like this comes from Issue 4462: perhaps 'interface' is a reserved word for the Windows compiler? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GUB fail in mingw build - Issue 4462
Phil Holmes m...@philholmes.net writes: I'm getting a failure to build GUB, as shown below: /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc: In member function 'void Scm_module::import()': /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:71:7: error: expected primary- expression before 'struct' SCM interface = scm_c_resolve_module (name_); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:76:5: error: expected primary- expression before 'struct' interface = Guile_user::module_public_interface (interface); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:80:24: error: expected primary- expression before 'struct' p-var_-import (interface, p-name_); ^ /home/gub/NewGub/gub/target/mingw/src/lilypond-git.sv.gnu.org--lilypond.git- release-unstable/lily/lily-modules.cc:85:13: error: expected primary- expression before 'struct' module_ = interface; ^ make[1]: *** [out/lily-modules.o] Error 1 Looks like this comes from Issue 4462: perhaps 'interface' is a reserved word for the Windows compiler? Or its system libraries. It's only a small part of the code, I'll push a rename presently. Expect it in staging in 5 minutes. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4478: Disentangle some Tie and Semi_tie code. (issue 251840044 by nine.fierce.ball...@gmail.com)
On 2015/07/12 00:27:14, Dan Eble wrote: lily/tie.cc:128: one_head = Semi_tie::head (item); Whoops. This should have been Semi_tie::head (item, d). I am almost sure this code is reachable only under conditions that are detected as programming errors elsewhere. Therefore I am not going to worry about restoring it now, as it should disappear as my clean-up work continues. https://codereview.appspot.com/251840044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 4496: RepeatTieColumn shouldn't call a Tie callback (issue 255110043 by nine.fierce.ball...@gmail.com)
Reviewers: , Description: If anyone can explain that the lines I removed actually made sense, please do. Please review this at https://codereview.appspot.com/255110043/ Affected files (+0, -2 lines): M lily/semi-tie-column.cc M scm/define-grobs.scm Index: lily/semi-tie-column.cc diff --git a/lily/semi-tie-column.cc b/lily/semi-tie-column.cc index 8980a8cf1cd9d87731e7ac8a1c10eeb7d95d8d67..202195d830634fbb41f99dcd0f1cd041ab91802a 100644 --- a/lily/semi-tie-column.cc +++ b/lily/semi-tie-column.cc @@ -33,7 +33,6 @@ ADD_INTERFACE (Semi_tie_column, The interface for a column of l.v. (laissez vibrer) ties., /* properties */ - direction positioning-done head-direction tie-configuration Index: scm/define-grobs.scm diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm index f91ad54025caf8089c3040cb66ab716a89c5e874..a341cc45984481a081e50af54b0dc1ba06be9102 100644 --- a/scm/define-grobs.scm +++ b/scm/define-grobs.scm @@ -1870,7 +1870,6 @@ (RepeatTieColumn . ( -(direction . ,ly:tie::calc-direction) (head-direction . ,ly:semi-tie-column::calc-head-direction) (positioning-done . ,ly:semi-tie-column::calc-positioning-done) (X-extent . #f) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
Reviewers: , Description: Table Of Contents crash with negative first-page-number Issue 4494 Let \with-link point to the physical page-number Please review this at https://codereview.appspot.com/258740043/ Affected files (+20, -11 lines): M scm/define-markup-commands.scm Index: scm/define-markup-commands.scm diff --git a/scm/define-markup-commands.scm b/scm/define-markup-commands.scm index 5a08facce20b7d8c040c43722028b010cfa82b35..63a2303ea69d18f25f6f8e11dbcefdd66449f5fb 100644 --- a/scm/define-markup-commands.scm +++ b/scm/define-markup-commands.scm @@ -528,19 +528,28 @@ only works in the PDF backend. (let* ((arg-stencil (interpret-markup layout props arg)) (x-ext (ly:stencil-extent arg-stencil X)) (y-ext (ly:stencil-extent arg-stencil Y))) -(ly:stencil-add - (ly:make-stencil +(ly:make-stencil `(delay-stencil-evaluation -,(delay (let* ((table (ly:output-def-lookup layout 'label-page-table)) - (page-number (if (list? table) -(assoc-get label table) -#f))) - (list 'page-link page-number -`(quote ,x-ext) `(quote ,y-ext) +,(delay (ly:stencil-expr + (let* ((table (ly:output-def-lookup layout 'label-page-table)) +(table-page-number + (if (list? table) + (assoc-get label table) + #f)) +(first-page-number + (ly:output-def-lookup layout 'first-page-number)) +(current-page-number + (+ table-page-number (+ 1 (* -1 first-page-number +(link-expr + (list 'page-link +current-page-number +`(quote ,x-ext) +`(quote ,y-ext + (ly:stencil-add + (ly:make-stencil link-expr x-ext y-ext) + arg-stencil) x-ext - y-ext) - arg-stencil))) - + y-ext))) (define-markup-command (beam layout props width slope thickness) (number? number? number?) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 17:49:44, thomasmorley651 wrote: Do the links actually work when first-page-number is, say, 10? yes If so, did they not work before? No, it was broken. Well, then we probably have to thank Ghostscript for bringing this long-standing problem to our attention. It may be worth trying if this makes the rather awkward fix for issue 3388 unnecessary, but I would guess that the problem is likely sufficiently different that that fix is still needed. https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 first-page-number Uh, (- table-page-number (1- first-page-number)) ? Do the links actually work when first-page-number is, say, 10? If so, did they not work before? https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode548 scm/define-markup-commands.scm:548: (ly:stencil-add What's the reason for delaying this part of the stencil expression as well? https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Table Of Contents crash with negative first-page-number (issue 258740043 by thomasmorle...@gmail.com)
On 2015/07/12 17:01:06, dak wrote: https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode542 scm/define-markup-commands.scm:542: (+ table-page-number (+ 1 (* -1 first-page-number Uh, (- table-page-number (1- first-page-number)) ? done Do the links actually work when first-page-number is, say, 10? yes If so, did they not work before? No, it was broken. https://codereview.appspot.com/258740043/diff/1/scm/define-markup-commands.scm#newcode548 scm/define-markup-commands.scm:548: (ly:stencil-add What's the reason for delaying this part of the stencil expression as well? No reason, corrected. https://codereview.appspot.com/258740043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
