Re: Cleanup initialization of configure process (issue 549350043 by jonas.hahnf...@gmail.com)
Assuming no further comments, I'm planning to push this later today (evening CET). https://codereview.appspot.com/549350043/
Re: Cleanup initialization of configure process (issue 549350043 by jonas.hahnf...@gmail.com)
https://codereview.appspot.com/549350043/diff/545440043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8
configure.ac:8: [m4_esyscmd([. ${SRCDIR:-.}/VERSION; echo -n
$MAJOR_VERSION.$MINOR_VERSION.$PATCH_LEVEL])],
The proposal using m4_esyscmd_s allowed to use echo without -n option
(which is a bit of a portability thing). Was there a reason not to take
it?
https://codereview.appspot.com/549350043/
Re: Cleanup initialization of configure process (issue 549350043 by jonas.hahnf...@gmail.com)
On 2020/01/16 10:57:46, dak wrote:
https://codereview.appspot.com/549350043/diff/545440043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8
configure.ac:8: [m4_esyscmd([. ${SRCDIR:-.}/VERSION; echo -n
$MAJOR_VERSION.$MINOR_VERSION.$PATCH_LEVEL])],
The proposal using m4_esyscmd_s allowed to use echo without -n option
(which is
a bit of a portability thing). Was there a reason not to take it?
I didn't notice that you changed this and just took the changes with
SRCDIR. But is there an actual advantage of using m4_esyscmd_s?
https://codereview.appspot.com/549350043/
Re: Cleanup initialization of configure process (issue 549350043 by jonas.hahnf...@gmail.com)
On 2020/01/16 11:22:24, hahnjo wrote:
On 2020/01/16 10:57:46, dak wrote:
> https://codereview.appspot.com/549350043/diff/545440043/configure.ac
> File configure.ac (right):
>
>
https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8
> configure.ac:8: [m4_esyscmd([. ${SRCDIR:-.}/VERSION; echo -n
> $MAJOR_VERSION.$MINOR_VERSION.$PATCH_LEVEL])],
> The proposal using m4_esyscmd_s allowed to use echo without -n
option (which
is
> a bit of a portability thing). Was there a reason not to take it?
I didn't notice that you changed this and just took the changes with
SRCDIR. But
is there an actual advantage of using m4_esyscmd_s?
The bit of a portability thing? From the autoconf documentation:
'echo'
The simple 'echo' is probably the most surprising source of
portability troubles. It is not possible to use 'echo' portably
unless both options and escape sequences are omitted. Don't expect
any option.
Do not use backslashes in the arguments, as there is no consensus
on their handling. For 'echo '\n' | wc -l', the 'sh' of Solaris
outputs 2, but Bash and Zsh (in 'sh' emulation mode) output 1. The
problem is truly 'echo': all the shells understand ''\n'' as the
string composed of a backslash and an 'n'. Within a command
substitution, 'echo 'string\c'' will mess up the internal state of
ksh88 on AIX 6.1 so that it will print the first character 's'
only, followed by a newline, and then entirely drop the output of
the next echo in a command substitution.
Because of these problems, do not pass a string containing
arbitrary characters to 'echo'. For example, 'echo "$foo"' is safe
only if you know that FOO's value cannot contain backslashes and
cannot start with '-'.
If this may not be true, 'printf' is in general safer and easier to
use than 'echo' and 'echo -n'. Thus, scripts where portability is
not a major concern should use 'printf '%s\n'' whenever 'echo'
could fail, and similarly use 'printf %s' instead of 'echo -n'.
For portable shell scripts, instead, it is suggested to use a
here-document like this:
cat
Re: Is the CG out of date?
Hello, On 16/01/2020 14:52, Peter Toye wrote: > Tuesday, January 14, 2020, 10:31:49 PM, you wrote: > >> Yes, the CG is not up-to-date. >> Please follow the README files in Github. > ... > > It looks as if one of my jobs is going to be bringing the CG up to date. But > as I'm a total newbie here I'll need support in making sure that anything I > write is accurate. Will the LilyDev system be likely to change in the near > future? In that case there wouldn't be any point. > > Perhaps the best way would be to 'remove' information from the CG and replace it with reference/links to the github location rather than duplicate instructions. James
PATCHES - Countdown for January 16th
Hello, Here is the current patch countdown list. The next countdown will be on January 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5658 Include consistently, not - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5658 http://codereview.appspot.com/569220043 5652 Fix a few complaints in python/convertrules.py - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5652 http://codereview.appspot.com/583290043 5601 Changes.tely (2.20): \afterGrace command got an optional argument that should be documented - James Lowe https://sourceforge.net/p/testlilyissues/issues/5601 http://codereview.appspot.com/551260043 5309 find_score_context () and find_global_context () - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5309 http://codereview.appspot.com/561290043 Countdown: 5662 Remove shebang from langdefs.py - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5662 http://codereview.appspot.com/581440043 5661 Fix some conversion warnings in Source_file. - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5661 http://codereview.appspot.com/567090043 5659 Clean up to_string () etc. - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5659 http://codereview.appspot.com/583320043 Review: 5660 Doc: Added documentation for fill-line line-width - davidsg https://sourceforge.net/p/testlilyissues/issues/5660 http://codereview.appspot.com/583340043 New: 5663 Encoding preparations for Python 3.5 - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5663 http://codereview.appspot.com/551340043 5654 Cleanup initialization of configure process - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5654 http://codereview.appspot.com/549350043 *** Regards, James
Re: Is the CG out of date?
Hi all, the GitHub page has only little information that would be helpful for newbies, IMHO. I've already prepared a patch for the mentioned CG section but have not posted it for review yet, because it refers to some small changes I contributed to LilyDev in the last days (two of them have already been merged into master). I do not know, however, if Federico will make a new release soon. Michael Am 16.01.2020 um 20:40 schrieb pkx1...@posteo.net: Hello, On 16/01/2020 14:52, Peter Toye wrote: Tuesday, January 14, 2020, 10:31:49 PM, you wrote: Yes, the CG is not up-to-date. Please follow the README files in Github. ... It looks as if one of my jobs is going to be bringing the CG up to date. But as I'm a total newbie here I'll need support in making sure that anything I write is accurate. Will the LilyDev system be likely to change in the near future? In that case there wouldn't be any point. Perhaps the best way would be to 'remove' information from the CG and replace it with reference/links to the github location rather than duplicate instructions. James
Re: Is the CG out of date?
Am 16.01.2020 um 21:54 schrieb Michael Käppler: Hi all, the GitHub page has only little information that would be helpful for newbies, IMHO. I've already prepared a patch for the mentioned CG section but have not posted it for review yet, because it refers to some small changes I contributed to LilyDev in the last days (two of them have already been merged into master). I do not know, however, if Federico will make a new release soon. Michael To make it clear, I thought I'd better wait with publishing the patch until a release reflecting these changes exists. So that the instructions can be tested. Or should I post it for review, nevertheless? Am 16.01.2020 um 20:40 schrieb pkx1...@posteo.net: Hello, On 16/01/2020 14:52, Peter Toye wrote: Tuesday, January 14, 2020, 10:31:49 PM, you wrote: Yes, the CG is not up-to-date. Please follow the README files in Github. ... It looks as if one of my jobs is going to be bringing the CG up to date. But as I'm a total newbie here I'll need support in making sure that anything I write is accurate. Will the LilyDev system be likely to change in the near future? In that case there wouldn't be any point. Perhaps the best way would be to 'remove' information from the CG and replace it with reference/links to the github location rather than duplicate instructions. James
Re: Is the CG out of date?
Hi Michael I'll check the other two PRs tomorrow. I don't think I'll have time for a new release this week. Il giorno gio 16 gen 2020 alle 21:54, Michael Käppler ha scritto: Hi all, the GitHub page has only little information that would be helpful for newbies, IMHO. I've already prepared a patch for the mentioned CG section but have not posted it for review yet, because it refers to some small changes I contributed to LilyDev in the last days (two of them have already been merged into master). I do not know, however, if Federico will make a new release soon. Michael Am 16.01.2020 um 20:40 schrieb pkx1...@posteo.net: Hello, On 16/01/2020 14:52, Peter Toye wrote: Tuesday, January 14, 2020, 10:31:49 PM, you wrote: Yes, the CG is not up-to-date. Please follow the README files in Github. ... It looks as if one of my jobs is going to be bringing the CG up to date. But as I'm a total newbie here I'll need support in making sure that anything I write is accurate. Will the LilyDev system be likely to change in the near future? In that case there wouldn't be any point. Perhaps the best way would be to 'remove' information from the CG and replace it with reference/links to the github location rather than duplicate instructions. James
Re: Cleanup initialization of configure process (issue 549350043 by jonas.hahnf...@gmail.com)
I've run some builds with a writable source directory, and I'm fine with it. Feel free to move forward with the cleaner change. I'll submit a LilyDev pull request to cope with it. https://codereview.appspot.com/549350043/
