PATCHES - Countdown to November 4
Here is the current countdown report. The next countdown will begin on November 4th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !1701 Tuplet-related cleanups - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1701 !1700 Ties: reduce dynamic casting - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/1700 !1699 doc: Fix copy and paste in PDFs for typewriter `~` and `^` - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/1699 !1696 Misc. insignificant cleanups - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1696 !1695 musicxml2ly performance improvements - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/1695 !1694 Some work on LM - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/1694 !1690 lilypond-book syntax: fix `lilypond` environment option usage - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/1690 Countdown: !1707 Finger glide fixes - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1707 !1704 Documentation build cleanups - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/1704 !1703 Move numeric sorting to lily-sort.scm - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1703 Review: !1706 Make \tweak useful on chord repetitions - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1706 !1705 Vertically align tuplet numbers of flat brackets - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1705 !1697 LM: Revise chapters 'Tutorial' and 'Common Notation' - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/1697 !1677 max-slope-factor for tuplet brackets - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1677 !1578 New margins by default - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1578 New: No patches in New at this time. Waiting: No patches in Waiting at this time. Cheers, Colin
Re: strange pygments handling of LilyPond input, Re: strange pygments handling of LilyPond input
Le 02/11/2022 à 16:19, Werner LEMBERG a écrit : OK, thanks. I wonder how the heuristics could be improved. Given that a lyric hyphen must be preceded by whitespace, while normally `--` as an articulation is following a non-whitespace character, maybe a look-behind assertion for the latter would help? Something similar could be done for numbers. This is not a priority for me compared to contributions to LilyPond and I am already lacking time to review contributions on the Pygments repository (I was made a maintainer some time after I contributed the LilyPond support). I won't work on this, but feel free to open a PR at Pygments. OpenPGP_signature Description: OpenPGP digital signature
Re: strange pygments handling of LilyPond input,Re: strange pygments handling of LilyPond input
>> ```
>> c''4-3 e-5 b-2 a-1
>> ```
>>
>> which Pygments translates to
>>
>> ```
>> @t{c''} @t{4} @t{-3} @t{e} @t{-5} @t{b} @t{-2} @t{a} @t{-1}
>> ```
>>
>> that is, the `-` is not typeset in bold.
>
> Because "-3" could just as well be a number rather than a fingering,
> and it's hard to guess.
>
>> The next one
>> ```
>> c''4-ˆ c-+ c-- c-!
>> ```
>>
>> gets translated to
>>
>> ```
>> @t{c''} @t{4} @tb{-^} @t{c} @tb{-+} @t{c} @t{--} @t{c} @tb{-!}
>>^^
>> ```
>>
>> showing bold and non-bold for `-` in the same function.
>
> Because "--" could be a lyric hyphen.
OK, thanks. I wonder how the heuristics could be improved. Given
that a lyric hyphen must be preceded by whitespace, while normally
`--` as an articulation is following a non-whitespace character, maybe
a look-behind assertion for the latter would help? Something similar
could be done for numbers.
Werner
Re: strange pygments handling of LilyPond input
Le 02/11/2022 à 14:53, Werner LEMBERG a écrit :
The above example was the wrong one, sorry. What I actually wanted to
show are inconsistencies. In the same section you can find
```
c''4-3 e-5 b-2 a-1
```
which Pygments translates to
```
@t{c''} @t{4} @t{-3} @t{e} @t{-5} @t{b} @t{-2} @t{a} @t{-1}
```
that is, the `-` is not typeset in bold.
Because "-3" could just as well be a number rather than
a fingering, and it's hard to guess.
The next one
```
c''4-ˆ c-+ c-- c-!
```
gets translated to
```
@t{c''} @t{4} @tb{-^} @t{c} @tb{-+} @t{c} @t{--} @t{c} @tb{-!}
^^
```
showing bold and non-bold for `-` in the same function.
Because "--" could be a lyric hyphen.
OpenPGP_signature
Description: OpenPGP digital signature
Re: auto beam issue
>> While working on the LM I see the following example in section 4.1.3:
>> ```
>> \new Staff {
>> \relative {
>> r4 g'8 g c4 c8 d |
>> e4 r8
>> <<
>> { f8 c c }
>> \new Staff { f8 f c }
>> >>
>> r4 |
>> }
>> }
>> ```
>> I now wonder why the last two notes of the temporary (lower) staff
>> don't have a beam, similar to the upper staff. Is this a bug?
>
> This appears to be due to the default beamExceptions for 4/4 time.
> [...]
Thanks. I suspected something along this direction, so I will change
the example.
Werner
Re: auto beam issue
On 2022-11-02 4:42 am, Werner LEMBERG wrote:
While working on the LM I see the following example in section 4.1.3:
```
\new Staff {
\relative {
r4 g'8 g c4 c8 d |
e4 r8
<<
{ f8 c c }
\new Staff { f8 f c }
>>
r4 |
}
}
```
I now wonder why the last two notes of the temporary (lower) staff
don't have a beam, similar to the upper staff. Is this a bug?
This appears to be due to the default beamExceptions for 4/4 time.
Consider:
\new Staff {
\relative {
r4 g'8 g c4 c8 d |
e4 r8
<<
{ f8 c c }
\new Staff { \set Timing.beamExceptions = #'() f8 f c }
>>
r4 |
}
}
Note that if you allow both staves to include the rest explicitly, the
beam appears:
\new Staff {
\relative {
r4 g'8 g c4 c8 d |
e4 r8
<<
{ f8 c c r4 }
\new Staff { f8 f c r4 }
>>
}
}
-- Aaron Hill
Re: strange pygments handling of LilyPond input
>> Please have a look at the attached image; it's taken from the LM,
>> chapter 3.1.4. As can be seen, `_` and `-` are bold, and `^`
>> isn't. Is it possible to make `_` and `-` bold only if used as
>> articulation (i.e., *after* `[_^-]`)?
>
> The relevant part of the output generated by lilypond-book for this
> snippet is
>
> @ifnothtml
> @pygments
> @tb{\relative}@t{ }@t{@{}@t{ }@t{c''}@t{4}@tb{_-}@tb{^1}@t{
> }@t{d}@tb{^.}@t{ }@t{f}@tb{^4}@tb{_2}@tb{->}@t{
> }@t{e}@tb{^-}@tb{_+}@t{ }@t{@}}
> @endPygments
> @end ifnothtml
>
>
> That looks correct, [...]
The above example was the wrong one, sorry. What I actually wanted to
show are inconsistencies. In the same section you can find
```
c''4-3 e-5 b-2 a-1
```
which Pygments translates to
```
@t{c''} @t{4} @t{-3} @t{e} @t{-5} @t{b} @t{-2} @t{a} @t{-1}
```
that is, the `-` is not typeset in bold. The next one
```
c''4-ˆ c-+ c-- c-!
```
gets translated to
```
@t{c''} @t{4} @tb{-^} @t{c} @tb{-+} @t{c} @t{--} @t{c} @tb{-!}
^^
```
showing bold and non-bold for `-` in the same function.
Werner
auto beam issue
While working on the LM I see the following example in section 4.1.3:
```
\new Staff {
\relative {
r4 g'8 g c4 c8 d |
e4 r8
<<
{ f8 c c }
\new Staff { f8 f c }
>>
r4 |
}
}
```
I now wonder why the last two notes of the temporary (lower) staff
don't have a beam, similar to the upper staff. Is this a bug?
In case it works as intended I will change the example to not confuse
a beginner.
Werner
Re: source file ... .scm newer than compiled ... .go file
Le 02/11/2022 à 12:02, Federico Bruni a écrit :
Il giorno mer 2 nov 2022 alle 00:12:07 +0100, Jean Abou Samra
ha scritto:
Your patch to Guile disables recompilation with a "return 1;"
at the end of the function but keeps the logic of the check and
the messages. Just additionally remove the code just above the line
it's touching, or add "return 1;" at the beginning of the function
rather than at the end.
I tried removing the whole function, but it's used later, as I got
this error:
https://github.com/flathub/org.frescobaldi.Frescobaldi/pull/17
/usr/lib/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld:
./.libs/libguile-2.2.so: undefined reference to `compiled_is_fresh'
$ git grep -n compiled_is_fresh
libguile/load.c:550:compiled_is_fresh (SCM full_filename, SCM
compiled_filename,
libguile/load.c:749: !compiled_is_fresh (source_file_name, found,
libguile/load.c:1221: && compiled_is_fresh (full_filename, fallback,
So I'd better use "return 1;" at the beginning of the function? Where
exactly? After the opening "{"?
Yes.
Re: source file ... .scm newer than compiled ... .go file
Il giorno mer 2 nov 2022 alle 00:12:07 +0100, Jean Abou Samra
ha scritto:
Your patch to Guile disables recompilation with a "return 1;"
at the end of the function but keeps the logic of the check and
the messages. Just additionally remove the code just above the line
it's touching, or add "return 1;" at the beginning of the function
rather than at the end.
I tried removing the whole function, but it's used later, as I got this
error:
https://github.com/flathub/org.frescobaldi.Frescobaldi/pull/17
/usr/lib/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld:
./.libs/libguile-2.2.so: undefined reference to `compiled_is_fresh'
$ git grep -n compiled_is_fresh
libguile/load.c:550:compiled_is_fresh (SCM full_filename, SCM
compiled_filename,
libguile/load.c:749: !compiled_is_fresh (source_file_name, found,
libguile/load.c:1221: && compiled_is_fresh (full_filename, fallback,
So I'd better use "return 1;" at the beginning of the function? Where
exactly? After the opening "{"?
Thanks
Federico
