Re: [GUB] Github tracker issue

2011-01-29 Thread Patrick McCarty 
On Sat, Jan 29, 2011 at 8:45 AM, Carl Sorensen  wrote:
>
> On 1/29/11 6:20 AM, "Graham Percival"  wrote:
>
>> On Fri, Jan 28, 2011 at 11:19:10PM -0800, Patrick McCarty wrote:
>>> I meant to post this to -devel a while ago, but I opened a Github
>>> tracker issue for GUB.
>>> https://github.com/janneke/gub/issues#issue/2
>>
>> Interesting.  How do I get a proper git format-patch version of
>> this?  The raw link gives me a plain diff.  The "download" gives
>> me a tarball, which contains a plain diff.
>>
>> Why does it seem like every code review tool out there strips out
>> the commit message and author from git patches?  :(    I can
>> vaguely excuse codereview, since it was intended for svn... but
>> github?!
>>
>> Please tell me that my old eyes completely missed some "get patch"
>> button somewhere.
>
> It appears to me that the desired work flow for this is for the submitter
> (Patrick in this case) to make a "pull request", at which time the applier
> can do the pull and the patch will have the original author stuff.

Yes, this is the typical work flow for Github.  Once we figure out a
proper patch to merge, we have the option of submitting a pull
request.

Thanks,
Patrick

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [GUB] Github tracker issue

2011-01-29 Thread Carl Sorensen 



On 1/29/11 6:20 AM, "Graham Percival"  wrote:

> On Fri, Jan 28, 2011 at 11:19:10PM -0800, Patrick McCarty wrote:
>> I meant to post this to -devel a while ago, but I opened a Github
>> tracker issue for GUB.
>> https://github.com/janneke/gub/issues#issue/2
> 
> Interesting.  How do I get a proper git format-patch version of
> this?  The raw link gives me a plain diff.  The "download" gives
> me a tarball, which contains a plain diff.
> 
> Why does it seem like every code review tool out there strips out
> the commit message and author from git patches?  :(I can
> vaguely excuse codereview, since it was intended for svn... but
> github?!
> 
> Please tell me that my old eyes completely missed some "get patch"
> button somewhere.

It appears to me that the desired work flow for this is for the submitter
(Patrick in this case) to make a "pull request", at which time the applier
can do the pull and the patch will have the original author stuff.

Here's an email thread that addresses this issue:



Thanks,

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [GUB] Github tracker issue

2011-01-29 Thread Graham Percival 
On Fri, Jan 28, 2011 at 11:19:10PM -0800, Patrick McCarty wrote:
> I meant to post this to -devel a while ago, but I opened a Github
> tracker issue for GUB.
> https://github.com/janneke/gub/issues#issue/2

Interesting.  How do I get a proper git format-patch version of
this?  The raw link gives me a plain diff.  The "download" gives
me a tarball, which contains a plain diff.

Why does it seem like every code review tool out there strips out
the commit message and author from git patches?  :(I can
vaguely excuse codereview, since it was intended for svn... but
github?!

Please tell me that my old eyes completely missed some "get patch"
button somewhere.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

[GUB] Github tracker issue

2011-01-28 Thread Patrick McCarty 
Hello,

I meant to post this to -devel a while ago, but I opened a Github
tracker issue for GUB.

Here's the link:

https://github.com/janneke/gub/issues#issue/2

Thanks,
Patrick

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel