Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
On 2016/11/16 15:40:48, pkx166h wrote: Push patch set 1. Then we can worry about getting the download up to LilyPond site afterwards. I will create a tracker to document all this. I've pushed Patch Set 1 to staging. commit 855e8e36a0c75aa75076fabe19aa292a6902ec96 https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
On 2016/11/16 15:40:48, pkx166h wrote: On 2016/11/16 14:35:05, trueroad_trueroad.jp wrote: > > But, I think that the simplest way is to distribute the tarball at the > LilyPond site. > > e.g. > > > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > > > > And change the warning message of configure script. > > e.g. > > (download tarball from > > > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > > and extract it under '~/.local/share/fonts' etc., or use --with-urwotf-dir) > > I've made `urw-core35-fonts-79bcdfb.tar.xz`. > https://drive.google.com/file/d/0ByGBX3PDrqjsbm9TOWktWjFCRmM/view?usp=sharing > > If someone uploads it as > `http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.xz`, > I will upload Patch Set 2 to Rietveld for changing the warning message. > > Or should I push the current Patch Set 1? Push patch set 1. Then we can worry about getting the download up to LilyPond site afterwards. I will create a tracker to document all this. James https://sourceforge.net/p/testlilyissues/issues/4998/ has been created to document these changes. james https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
On 2016/11/16 14:35:05, trueroad_trueroad.jp wrote: > But, I think that the simplest way is to distribute the tarball at the LilyPond site. > e.g. > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > > And change the warning message of configure script. > e.g. > (download tarball from > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > and extract it under '~/.local/share/fonts' etc., or use --with-urwotf-dir) I've made `urw-core35-fonts-79bcdfb.tar.xz`. https://drive.google.com/file/d/0ByGBX3PDrqjsbm9TOWktWjFCRmM/view?usp=sharing If someone uploads it as `http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.xz`, I will upload Patch Set 2 to Rietveld for changing the warning message. Or should I push the current Patch Set 1? Push patch set 1. Then we can worry about getting the download up to LilyPond site afterwards. I will create a tracker to document all this. James https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
> But, I think that the simplest way is to distribute the tarball at the > LilyPond site. > e.g. > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > > And change the warning message of configure script. > e.g. > (download tarball from > http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz > and extract it under '~/.local/share/fonts' etc., or use --with-urwotf-dir) I've made `urw-core35-fonts-79bcdfb.tar.xz`. https://drive.google.com/file/d/0ByGBX3PDrqjsbm9TOWktWjFCRmM/view?usp=sharing If someone uploads it as `http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.xz`, I will upload Patch Set 2 to Rietveld for changing the warning message. Or should I push the current Patch Set 1? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
>> I attached the shell script which can download the 12 font files from > > 'http://git.ghostscript.com/?p=urw-core35-fonts.git;a=commit;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018'. > >> Its each download URL is just link of each font file in above URL. >> It works fine on my environment. > >> Would you try it and put the downloaded files to ~/.local/share/fonts > etc? > > Yes this works, but is this the most elegant/simplest way to get these > files? I've found a more simple way. The following commands can install the font files. $ wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=snapshot;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018;sf=tgz"; $ mkdir -p ~/.local/share/fonts $ tar xfvz urw-core35-fonts-79bcdfb.tar.gz -C ~/.local/share/fonts But, I think that the simplest way is to distribute the tarball at the LilyPond site. e.g. http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz And change the warning message of configure script. e.g. (download tarball from http://lilypond.org/downloads/gub-sources/urw-fonts/urw-core35-fonts-79bcdfb.tar.gz and extract it under '~/.local/share/fonts' etc., or use --with-urwotf-dir) > 1. If you look here: > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page.html#requirements-for-running-lilypond > > we already list a number of 'font requirements'. Does including > TexGyre > and now these URW++ fonts mean that all/some/none of these font > pacakges > we currently document can now be removed as a requirement? (e.g. > texlive-lang-cyrillic). > > 2. The same question but for > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page.html#requirements-for-building-documentation If I understand correctly, there is no requirement that can be deleted. `texlive-lang-cyrillic` is for Texinfo. It is not for LilyPond snippets. The URW++ fonts are for LilyPond snippets. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
On 2016/11/06 13:16:44, trueroad_trueroad.jp wrote: > I am sorry to still talk about this, but I have been unable to work > out > how I could install just these fonts without having to clone the > entire > repo. I have looked in places like stackoverflow and the various 'git' > sites but no one seems to be able to clearly state how to install just > this commit (with for example git fetch). I also have not been able to > 'download' the raw blobls from the repo either using 'right click/save > as'. I attached the shell script which can download the 12 font files from 'http://git.ghostscript.com/?p=urw-core35-fonts.git;a=commit;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018'. Its each download URL is just link of each font file in above URL. It works fine on my environment. Would you try it and put the downloaded files to ~/.local/share/fonts etc? Yes this works, but is this the most elegant/simplest way to get these files? If it is then that is fine, we just need to document this so that we don't get too many questions on the lily-dev mailing list about how to install 'a commit' or if they don't install these fonts if it will prevent 'them' being able to build LilyPond. I have other questions though, but these shouldn't stop this patch but I think it would be useful to understand if not just for me but other developers that might not understand 'font stuff' as much as yourself and Werner. 1. If you look here: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page.html#requirements-for-running-lilypond we already list a number of 'font requirements'. Does including TexGyre and now these URW++ fonts mean that all/some/none of these font pacakges we currently document can now be removed as a requirement? (e.g. texlive-lang-cyrillic). 2. The same question but for http://lilypond.org/doc/v2.19/Documentation/contributor-big-page.html#requirements-for-building-documentation Thanks again for your explanations. James https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
> I am sorry to still talk about this, but I have been unable to work > out > how I could install just these fonts without having to clone the > entire > repo. I have looked in places like stackoverflow and the various 'git' > sites but no one seems to be able to clearly state how to install just > this commit (with for example git fetch). I also have not been able to > 'download' the raw blobls from the repo either using 'right click/save > as'. I attached the shell script which can download the 12 font files from 'http://git.ghostscript.com/?p=urw-core35-fonts.git;a=commit;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018'. Its each download URL is just link of each font file in above URL. It works fine on my environment. Would you try it and put the downloaded files to ~/.local/share/fonts etc? #!/bin/sh wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=C059-BdIta.otf;h=0f59bb96119f289eb348c511764c9d2ceafb7f80;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=C059-Bold.otf;h=f8718a8d481b4483aa38667dba64e4949533945f;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=C059-Italic.otf;h=4abe846c09f3aaf8fafa2a4efa94484e842fd100;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=C059-Roman.otf;h=fcd5e4c18ae04338570e25fa3fb6eb1839afa7bf;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusMonoPS-Bold.otf;h=624871f6291b0346092ca0b6a571b6d7904e0f02;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusMonoPS-BoldItalic.otf;h=a8698a89d9d27dfc78431e89c930b35c5d003464;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusMonoPS-Italic.otf;h=a8fa428ec66b42e0f6d35599268050abbaad3de9;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusMonoPS-Regular.otf;h=f94f61a02a0deeba22fe41c2882c717d5aac1385;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusSans-Bold.otf;h=941f882eaf17d626a9960db75c32fc8296e81211;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusSans-BoldOblique.otf;h=91cf2e3529d456358fccc3d1006dfc910439fe11;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusSans-Oblique.otf;h=f47d0651c35849044142739aad1cf3b07822e8c3;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; wget --content-disposition "http://git.ghostscript.com/?p=urw-core35-fonts.git;a=blob;f=NimbusSans-Regular.otf;h=bdeb5c275eac2dc7b95655b55405f84489e2;hb=79bcdfb34fbce12b592cce389fa7a19da6b5b018"; ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
On 2016/11/05 11:50:52, trueroad wrote: On 2016/11/05 10:24:39, pkx166h wrote: > Hosoda-san (and perhaps others who know about font installation), > > I cannot seem to be able to install 'just' a git commit (as is described in the > warning message that is posted by the makefile when you run 'configure'), I can > git clone the repo of course and that works - as long as I know where my fonts > are supposed to be installed to be correctly discovered - so my questions are: > > 1. Should we really be telling people to install that entire repo (and not just > the commit, if you see what I mean?) or is there a more elegant way to just get > those few fonts without having to install the entire urw-core35-fonts git repo > > 2. Longer term, will this repo end up being installable by a simpler apt/dnf/yum > (or whatever your Linux Distro's Package Manager is) from their own respective > repositories? As that would be much simpler (i.e. apt-get install > urw-core35-fonts) than documenting how to clone git repos. I tried it literally > and got complaints because my .font dir was not empty, so you have to clone into > a dir inside your currently installed font location. > > > I'd just like to get a better understanding so I can help document this more > clearly in our Contributor Guide. > > Thank you. > > James The necessary files are only following 12 files. It is not all of the files in that repository. C059-BdIta.otf C059-Bold.otf C059-Italic.otf C059-Roman.otf NimbusMonoPS-Bold.otf NimbusMonoPS-BoldItalic.otf NimbusMonoPS-Italic.otf NimbusMonoPS-Regular.otf NimbusSans-Bold.otf NimbusSans-BoldOblique.otf NimbusSans-Oblique.otf NimbusSans-Regular.otf If you put these files in the Fontconfig search path (e.g. ~/.local/share/fonts, ~/.fonts etc.), configure script can find them. I am sorry to still talk about this, but I have been unable to work out how I could install just these fonts without having to clone the entire repo. I have looked in places like stackoverflow and the various 'git' sites but no one seems to be able to clearly state how to install just this commit (with for example git fetch). I also have not been able to 'download' the raw blobls from the repo either using 'right click/save as'. Making things too complicated for developers can put them off and doc building is quite integral to even just building the binaries - because of the makeinfo part (I think). So I don't want to stop this checkin but if there is an easy way to install this commit from that font repo (without simply cloning the entire repo or having to 'hunt' for each file separately) then I'd like to know what it is and perhaps we need to state this in the message that 'configure' gives you. For those that haven't tried the message looks like this: --snip-- ... (normal configure output) ... ... checking for zip... zip checking for rsync... rsync configure: creating ./config.status config.status: creating config.make config.status: creating config.hh WARNING: Please consider installing optional programs or files: URW++ OTF fonts (download OTF files from 'http://git.ghostscript.com/?p=urw-core35-fonts.git;a=commit;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018' and put them under '~/.local/share/fonts' etc., or use --with-urwotf-dir) See INSTALL.txt for more information on how to build LilyPond Type: make all to build LilyPond make install to install LilyPond make help to see all possible targets Edit local.make for local Makefile overrides. --snip-- I am not saying we )necessarily) need a more detailed message but we do need to document this in our CG and I like to think I am a good candidate for this kind of information, not being a real developer or programmer of any kind, but simply following instructions. Even if configure script cannot find them, compilation and installation is possible since the files are optional. Sorry for being 'stupid' but what would someone be gaining by installing these fonts, I have tried to follow the threads but because of my ignorance I cannot see why these 'suddenly' add something that didn't exist before. Unfortunately, perhaps because those fonts are too new, not yet been packaged. That's OK. If we're are imprioving something by adding these fonts, as long as we can document how to install them (see above) then even if it is a bit more complicated than just 'apt-get install' most people can follow clear steps, we just need to document them I think. I think that there are two ways to improve. 1. To suppress the display of warning. If configure script finds those files, `make` uses them and `make install` installs them. Even if configure script does not find them, it does not display the warning. I cannot comment here because I don't know what benefit someone would be getting by installing these extra fonts compared to what we do at the moment but I think it is better to display something in this message that i
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
Reviewers: lemzwerg, pkx166h, Message: On 2016/11/05 10:24:39, pkx166h wrote: Hosoda-san (and perhaps others who know about font installation), I cannot seem to be able to install 'just' a git commit (as is described in the warning message that is posted by the makefile when you run 'configure'), I can git clone the repo of course and that works - as long as I know where my fonts are supposed to be installed to be correctly discovered - so my questions are: 1. Should we really be telling people to install that entire repo (and not just the commit, if you see what I mean?) or is there a more elegant way to just get those few fonts without having to install the entire urw-core35-fonts git repo 2. Longer term, will this repo end up being installable by a simpler apt/dnf/yum (or whatever your Linux Distro's Package Manager is) from their own respective repositories? As that would be much simpler (i.e. apt-get install urw-core35-fonts) than documenting how to clone git repos. I tried it literally and got complaints because my .font dir was not empty, so you have to clone into a dir inside your currently installed font location. I'd just like to get a better understanding so I can help document this more clearly in our Contributor Guide. Thank you. James The necessary files are only following 12 files. It is not all of the files in that repository. C059-BdIta.otf C059-Bold.otf C059-Italic.otf C059-Roman.otf NimbusMonoPS-Bold.otf NimbusMonoPS-BoldItalic.otf NimbusMonoPS-Italic.otf NimbusMonoPS-Regular.otf NimbusSans-Bold.otf NimbusSans-BoldOblique.otf NimbusSans-Oblique.otf NimbusSans-Regular.otf If you put these files in the Fontconfig search path (e.g. ~/.local/share/fonts, ~/.fonts etc.), configure script can find them. Even if configure script cannot find them, compilation and installation is possible since the files are optional. Unfortunately, perhaps because those fonts are too new, not yet been packaged. I think that there are two ways to improve. 1. To suppress the display of warning. If configure script finds those files, `make` uses them and `make install` installs them. Even if configure script does not find them, it does not display the warning. Even in this case, we will be able to contain those fonts in binary to be distributed in lilypond.org. 2. To distribute the tarball of these 12 files from lilypond.org. You can download and extract the tarball and put the files in ~/.local/share/fonts etc. Description: Issue 4991: Add installing optional URW++ fonts LilyPond default fonts (TeX Gyre) do not have Greek and Cyrillic glyphs. Newest URW 35 fonts (June 2016) have them. http://git.ghostscript.com/?p=urw-core35-fonts.git;a=commit;h=79bcdfb34fbce12b592cce389fa7a19da6b5b018 This commit realizes the followings. . configure script finds the following 12 OTF files. . If they are found, `make install` installs them. (Both TeX Gyre and URW fons are installed under the lilypond fonts directory.) . Even if they are not found, configure script does not raise error. (Only TeX Gyre fonts are installed.) C059-BdIta.otf C059-Bold.otf C059-Italic.otf C059-Roman.otf NimbusMonoPS-Bold.otf NimbusMonoPS-BoldItalic.otf NimbusMonoPS-Italic.otf NimbusMonoPS-Regular.otf NimbusSans-Bold.otf NimbusSans-BoldOblique.otf NimbusSans-Oblique.otf NimbusSans-Regular.otf Please review this at https://codereview.appspot.com/315850043/ Affected files (+55, -1 lines): M GNUmakefile.in M config.make.in M configure.ac M mf/GNUmakefile Index: GNUmakefile.in diff --git a/GNUmakefile.in b/GNUmakefile.in index abc7ecaf6aba1eea6416582c9a590ec2690296b1..76f4515be93f6034c4fd0966788a8ff512afb9b3 100644 --- a/GNUmakefile.in +++ b/GNUmakefile.in @@ -260,6 +260,8 @@ $(tree-share-prefix)/mf-link-tree: $(tree-share-prefix)/lilypond-force cd $(tree-share-prefix)/fonts/otf && \ ln -s ../../../../../../mf/$(outconfbase)/*.otf . && \ $(foreach i,$(addprefix $(TEXGYRE_DIR)/,$(TEXGYRE_FILES)), \ + ln -s $i . && ) true && \ + $(foreach i,$(addprefix $(URWOTF_DIR)/,$(URWOTF_FILES)), \ ln -s $i . && ) true -cd $(tree-share-prefix)/fonts && \ ln -s ../../../../../mf/$(outconfbase)/fonts.conf . && \ Index: config.make.in diff --git a/config.make.in b/config.make.in index c681d761990ce0fe7cfa696a53c0ea1e1e12ed4f..d376a59f481c18a385d8b9703617d94ab8aa4662 100644 --- a/config.make.in +++ b/config.make.in @@ -92,6 +92,8 @@ vimdir = $(lilypond_datadir)/vim TEXGYRE_DIR = @TEXGYRE_DIR@ TEXGYRE_FILES = @TEXGYRE_FILES@ +URWOTF_DIR = @URWOTF_DIR@ +URWOTF_FILES = @URWOTF_FILES@ ## PROGRAMS Index: configure.ac diff --git a/configure.ac b/configure.ac index 0a753325d1eec6384b6c0972ae2d8330543bfdb6..1fa9d45b59497646232245deafc6bfb3a44ded81 100644 --- a/configure.ac +++ b/configur
Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
Hosoda-san (and perhaps others who know about font installation), I cannot seem to be able to install 'just' a git commit (as is described in the warning message that is posted by the makefile when you run 'configure'), I can git clone the repo of course and that works - as long as I know where my fonts are supposed to be installed to be correctly discovered - so my questions are: 1. Should we really be telling people to install that entire repo (and not just the commit, if you see what I mean?) or is there a more elegant way to just get those few fonts without having to install the entire urw-core35-fonts git repo 2. Longer term, will this repo end up being installable by a simpler apt/dnf/yum (or whatever your Linux Distro's Package Manager is) from their own respective repositories? As that would be much simpler (i.e. apt-get install urw-core35-fonts) than documenting how to clone git repos. I tried it literally and got complaints because my .font dir was not empty, so you have to clone into a dir inside your currently installed font location. I'd just like to get a better understanding so I can help document this more clearly in our Contributor Guide. Thank you. James https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)
LGTM. Thanks for working on this. https://codereview.appspot.com/315850043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
