Re: Improvements to \offset (issue 15850044)
On 2013/10/22 14:27:28, david.nalesnik wrote: On 2013/10/22 14:26:10, david.nalesnik wrote: Please review. Unfortunately, I'm getting the old chunk mismatch error when I attempt to see the side-by-side diffs. Is there a way to correct this without re-uploading the patch set? I went ahead and reuploaded. Same patch set as before. The side-by-sides are now visible. https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722
ly/music-functions-init.ly:722: (make-music 'Music)))
Hmm...
Shouldn't the return here be `item' since it is guaranteed to be music?
The following code
\relative c'' {
c e g-\offset foo #'(-1 . 1) \arpeggio
}
results in a failed file.
The way the code is now, the snippet returns an error about bad grob
property path (`foo') and post-event expected. No arpeggio appears.
With a return of item, we only get the warning about property path, and
the arpeggio is typeset. This seems more sensible.
https://codereview.appspot.com/15850044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
On 2013/10/23 14:24:33, david.nalesnik wrote:
https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722
ly/music-functions-init.ly:722: (make-music 'Music)))
Hmm...
Shouldn't the return here be `item' since it is guaranteed to be
music?
The following code
\relative c'' {
c e g-\offset foo #'(-1 . 1) \arpeggio
}
results in a failed file.
The way the code is now, the snippet returns an error about bad grob
property
path (`foo') and post-event expected. No arpeggio appears. With a
return of
item, we only get the warning about property path, and the arpeggio is
typeset.
This seems more sensible.
Indeed. I'll take a look at other occurences of the pattern.
https://codereview.appspot.com/15850044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
On 2013/10/23 14:30:42, dak wrote: The way the code is now, the snippet returns an error about bad grob property path (`foo') and post-event expected. No arpeggio appears. With a return of item, we only get the warning about property path, and the arpeggio is typeset. This seems more sensible. Indeed. I'll take a look at other occurences of the pattern. Looks like we don't have anything like it in master's ly/music-functions-init.ly right now (including offset's current definition), so the problem does not exist outside of the proposed code. Fixing the proposal should be all the action needed. https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
On 2013/10/23 14:36:41, dak wrote: Fixing the proposal should be all the action needed. OK, new patch set uploaded. https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
LGTM https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Improvements to \offset (issue 15850044)
On 2013/10/22 14:26:10, david.nalesnik wrote: Please review. Unfortunately, I'm getting the old chunk mismatch error when I attempt to see the side-by-side diffs. Is there a way to correct this without re-uploading the patch set? https://codereview.appspot.com/15850044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
