Re: change longas similarly to how breves were changed (issue 4962072)

[janek . lilypond]

pushed as a2d8779a847dab1b6622da59be3a0e9247ff2ab2
thanks,
Janek

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

[pkx166h]

passes make and reg tests - there are three reg tests that show up but
nothing significant.

See http://code.google.com/p/lilypond/issues/detail?id=1883#c1

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

[ianhulin44]

LGTM

Ian

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

[janek . lilypond]

New patch set uploaded.


http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120:
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:

foobar = quanted_line_length * staff_space;
% because you use 'quanted_line_length * staff_space' four times in

the code

below


Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123
mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:

bot y1 = -foobar;
top y2 = foobar;
% see comment above


Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133
mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:

top y2 = foobar;
% see comment above


Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140
mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:

bot y3 = -foobar;
% see comment above


Done.

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

[bordage . bertrand]

LGTM, with the same comment.

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

[ianhulin44]

Mostly LGTM, apart from one calculation you do four times.  Do it once
once and save as a variable and use that.

Cheers,
Ian


http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120:
foobar = quanted_line_length * staff_space;
% because you use 'quanted_line_length * staff_space' four times in the
code below

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123
mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space;
bot y1 = -foobar;
top y2 = foobar;
% see comment above

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133
mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space;
top y2 = foobar;
% see comment above

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140
mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space;
bot y3 = -foobar;
% see comment above

http://codereview.appspot.com/4962072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

change longas similarly to how breves were changed (issue 4962072)

[janek . lilypond]

Reviewers: Bertrand Bordage,

Message:
http://code.google.com/p/lilypond/issues/detail?id=1883

Description:
change longas similarly to how breves were changed

Put vertical lines farther apart,
make them longer to increase readability
and include them in X-extent.

Please review this at http://codereview.appspot.com/4962072/

Affected files:
  M mf/feta-noteheads.mf


Index: mf/feta-noteheads.mf
diff --git a/mf/feta-noteheads.mf b/mf/feta-noteheads.mf
index  
87d9034713359aeb5e9cd0d4266334c8cbbf23ae..8fee28083196dc04663c78dd38afb1697742b8e0  
100644

--- a/mf/feta-noteheads.mf
+++ b/mf/feta-noteheads.mf
@@ -82,42 +82,62 @@ endgroup;
 enddef;


-%
-% dimensions aren't entirely right.
-%
 def draw_longa (expr up) =
save stemthick, fudge;

stemthick# = 2 stafflinethickness#;
define_whole_blacker_pixels (stemthick);

-   fudge = hround (blot_diameter / 2);
+   % Longas of smaller design sizes should have their lines farther
+   % apart (the overlap with notehead ellipsoid should be smaller).
+   fudge = hround (blot_diameter
+   * min (max (-0.15,
+   (0.9
+- (20 / (design_size + 4,
+  0.3));

draw_outside_ellipse (1.80, 0, 0.707, 0);
undraw_inside_ellipse (1.30, 125, 0.68, 2 stafflinethickness#);

+   set_char_box (stemthick#,
+ width# + stemthick#,
+ noteheight# / 2,
+ noteheight# / 2);
+
pickup pencircle scaled stemthick;

+   % Longas of smaller design sizes should have their lines longer.
+   line_length := min (max (0.7, (64/60 - (design_size / 60))), 0.85);
+
+   % Line lengths between 0.72 and 0.77 are not nice
+   % because they are neither separate nor connected
+   % when there is an interval of fourth.
+   if line_length < 0.75:
+   quanted_line_length := min (0.72, line_length);
+   else:
+   quanted_line_length := max (0.77, line_length);
+   fi;
+
if up:
-   bot y1 = -d;
-   top y2 = h;
+   bot y1 = -quanted_line_length * staff_space;
+   top y2 = quanted_line_length * staff_space;
rt x1 - fudge = 0;
x1 = x2;

-   fudge + lft x3 = w;
+   fudge + lft x3 = width;
x4 = x3;
top y4 = h + 3.0 staff_space;
y3 = y1;
else:
bot y1 = -d - 3.0 staff_space;
-   top y2 = h;
+   top y2 = quanted_line_length * staff_space;
rt x1 - fudge = 0;
x1 = x2;

-   fudge + lft x3 = w;
+   fudge + lft x3 = width;
x4 = x3;
y4 = y2;
-   bot y3 = -d;
+   bot y3 = -quanted_line_length * staff_space;
fi;

draw_gridline (z1, z2, stemthick);



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel