Re: oops! I've changed files in the `snippet' directory
On Sun, Aug 21, 2011 at 07:53:35AM +0200, Werner LEMBERG wrote: I think the commit message is enough for that? LSR: local import LSR: full import ? Is the format of this commit message fixed? I'm asking because a script might search for it. No, because we don't have any fixed people doing these imports. Again, that's sucky, but recruiting (again! only a month or two after the first last one!) somebody to handle this isn't even on my top 10 list of lilypond problems. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
On Fri, Aug 19, 2011 at 10:29:12AM +0200, Werner LEMBERG wrote: No, it is not safe. Your changes will be elminated the next time Neil (or Valentin, or anybody who cares about LSR) does a full import. Historically, this only happens every 3-4 months, but it should be happening much more often than that. What about the following: There are a lot of things that could be done to improve our development process. This is sadly not even in the top 20. (2) The next time makelsr gets called, start with the status at commit 12345678 as a base, *not* with HEAD. Doing so, later fixes to the snippets within lilypond's git repository are saved. ... can you do this automatically in a python script, assuming a complete ignorance of git from the script-runner? If so, then patches appreciated. I think it's overkill, though. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
(2) The next time makelsr gets called, start with the status at commit 12345678 as a base, *not* with HEAD. Doing so, later fixes to the snippets within lilypond's git repository are saved. can you do this automatically in a python script, assuming a complete ignorance of git from the script-runner? Will have a look. I think it's overkill, though. Is it? You want to silently override fixes to the better? BTW, what about using git tags to mark the commits used for global/local LSR imports? Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
On Sun, Aug 21, 2011 at 06:55:02AM +0200, Werner LEMBERG wrote: I think it's overkill, though. Is it? You want to silently override fixes to the better? If somebody edits a file specifically marked %% DO NOT EDIT this file manually; it is automatically %% generated from LSR http://lsr.dsi.unimi.it ? BTW, what about using git tags to mark the commits used for global/local LSR imports? I think the commit message is enough for that? LSR: local import LSR: full import ? Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
Is it? You want to silently override fixes to the better? If somebody edits a file specifically marked %% DO NOT EDIT this file manually; it is automatically %% generated from LSR http://lsr.dsi.unimi.it ? Hehe, you have a point. BTW, what about using git tags to mark the commits used for global/local LSR imports? I think the commit message is enough for that? LSR: local import LSR: full import ? Is the format of this commit message fixed? I'm asking because a script might search for it. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
On 18 August 2011 22:46, Reinhold Kainhofer reinh...@kainhofer.com wrote: BTW, I managed to get the LSR-copy running on my machine: http://lsr.kainhofer.at/LSR/ (the jail is set up but not yet used for compiling) HOWTO as usual at http://wiki.kainhofer.com/lilypond/lsr_setup Wow, that's awesome work, Reinhold. :) I've tried following the instructions, but can't get it to work properly. I think I've followed the instructions to the letter (apart from adding setcp.sh to the sh/ directory, since it's missing here: http://wiki.kainhofer.com/_media/lilypond/lsr/setcp.sh), but my jail refuses to mount when booting up and the LSR site isn't found when I type the URL into my browser. Any ideas? Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
oops! I've changed files in the `snippet' directory
Folks, while doing some doc fixes I've also changed files directly in the `snippet' directory by accident. But this is not me alone, others do the same :-) My question: Is this really a problem? Are such fixes lost if someone is running makelsr? Or is someone taking care of such fixes, probably transferring them to the LSR? It's really tedious to add fixed files to the `new' directory... Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
On Thu, Aug 18, 2011 at 08:09:29AM +0200, Werner LEMBERG wrote: My question: Is this really a problem? Are such fixes lost if someone is running makelsr? Depends, and yes. Files are completely rewritten from a makelsr import. Whether or not this is a problem depends on the changes that you've been making. Or is someone taking care of such fixes, probably transferring them to the LSR? Certainly nobody is doing that. Of course, these days nobody is doing lsr imports either. It's really tedious to add fixed files to the `new' directory... This might be made easier with a script, or at least if we cleared out the old stuff from that new directory. Unfortunately, nobody is willing to demonstrate that they care about LSR, so we're floating in limbo. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
My question: Is this really a problem? Are such fixes lost if someone is running makelsr? Depends, and yes. Hmm, hmm, hmm. Files are completely rewritten from a makelsr import. Whether or not this is a problem depends on the changes that you've been making. Well, I consider it a `problem' if fixes get completely overwritten by non-fixed files... Or is someone taking care of such fixes, probably transferring them to the LSR? Certainly nobody is doing that. OK. Of course, these days nobody is doing lsr imports either. But makelsr gets called quite frequently (e.g. Jul 29th, Jul 20th, and you did it on Jul 16th)... Oh, wait. It seems that `makelsr' is a misnomer. The script actually takes care only of directories full of lilypond snippets, but it is not directly related to the LSR on the Italian host, right? You essentially use it to transfer snippets from your local (translation or whatever) git branch into the trunk. It's really tedious to add fixed files to the `new' directory... This might be made easier with a script, or at least if we cleared out the old stuff from that new directory. Unfortunately, nobody is willing to demonstrate that they care about LSR, so we're floating in limbo. And I've just remembered that the `snippets/new' directory refers to `new features' in lilypond, not to `new files'. My conclusion is that it is quite safe to directly edit files in the `snippets' directory. Relieved :-) Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
Am Donnerstag, 18. August 2011, 08:25:48 schrieb Graham Percival: It's really tedious to add fixed files to the `new' directory... This might be made easier with a script, or at least if we cleared out the old stuff from that new directory. Unfortunately, nobody is willing to demonstrate that they care about LSR, so we're floating in limbo. BTW, I managed to get the LSR-copy running on my machine: http://lsr.kainhofer.at/LSR/ (the jail is set up but not yet used for compiling) HOWTO as usual at http://wiki.kainhofer.com/lilypond/lsr_setup Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: oops! I've changed files in the `snippet' directory
On Thu, Aug 18, 2011 at 09:59:32AM +0200, Werner LEMBERG wrote: Files are completely rewritten from a makelsr import. Whether or not this is a problem depends on the changes that you've been making. Well, I consider it a `problem' if fixes get completely overwritten by non-fixed files... Then yes, it's a problem. Of course, these days nobody is doing lsr imports either. But makelsr gets called quite frequently (e.g. Jul 29th, Jul 20th, and you did it on Jul 16th)... Oh, wait. It seems that `makelsr' is a misnomer. The script actually takes care only of directories full of lilypond snippets, but it is not directly related to the LSR on the Italian host, right? You essentially use it to transfer snippets from your local (translation or whatever) git branch into the trunk. Oops, I see the uncertainty. makelsr.py can be run locally (which means just copying stuff from Documentation/snippets/new/ and updating translations), or with an import or full import. We haven't been consistent in how we indicate these in the git changelog. AFAIK the last full import was f47c92f6bb1148cf694883e688c8812417d5683e 2011-07-05 but it's just possible that Neil did one in 826b67718096de62e7564e19a05402740138398c 2011-08-07 I would like to have a weekly full import, though, so even if Neil did one a few weeks ago, I'm still not happy with the level of support that LSR is getting. This might be made easier with a script, or at least if we cleared out the old stuff from that new directory. And I've just remembered that the `snippets/new' directory refers to `new features' in lilypond, not to `new files'. Ideally they only refer to new features or changed syntax which requires manual attention', but some developers might dump a file into Documentation/snippets/new/ if they do not feel like using the LSR web interface. That's not precisely encouraged, but I'm not going to discourage that if somebody really dislikes the web interface. My conclusion is that it is quite safe to directly edit files in the `snippets' directory. Relieved :-) No, it is not safe. Your changes will be elminated the next time Neil (or Valentin, or anybody who cares about LSR) does a full import. Historically, this only happens every 3-4 months, but it should be happening much more often than that. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
