Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
On Mon, Nov 23, 2015 at 4:59 PM, Stephen Boyd wrote: > On 11/21, Bjorn Andersson wrote: >> On Fri 20 Nov 16:39 PST 2015, Stephen Boyd wrote: [..] >> Do you foresee that there will be an implementation of the generic rpmcc >> or is it just a way to "standardize" the dt binding? >> > > I don't see any problem with implementing the RPM clock > controller as one file or two files (one for platform bus based > RPM modules and one for SMD bus RPM modules). The compatible can > be the same for both struct driver instances, while the bus will > pick the right driver. I suspect we'll need SoC specific > compatibles though to export the right set of clocks, so having > the generic compatible is mostly to find these rpm clock > controllers so that we know to skip registering the XO clock from > the GCC driver and not some generic implementation of the driver. > Ahh, now I get it. So the generic rpmcc to be able to check if we have a rpmcc instance and then the specific for the actual implementation. I'm +1 on that. > There's probably a subset of the clocks that's always the same > between devices, so if we had to we could match the generic > compatible and provide limited functionality. > After looking at a couple of platforms I don't think it's worth the effort of having a common list of rpm clocks. My suggestion is that we just continue with the suggested approach (having platform specific rpmcc defines and tables) Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
On 11/21, Bjorn Andersson wrote: > On Fri 20 Nov 16:39 PST 2015, Stephen Boyd wrote: > > > On 11/19, Georgi Djakov wrote: > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > > b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > > new file mode 100644 > > > index ..bd0fd0cd50dc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > > @@ -0,0 +1,35 @@ > > > +Qualcomm RPM Clock Controller Binding > > > + > > > +The RPM is a dedicated hardware engine for managing the shared > > > +SoC resources in order to keep the lowest power profile. It > > > +communicates with other hardware subsystems via shared memory > > > +and accepts clock requests, aggregates the requests and turns > > > +the clocks on/off or scales them on demand. > > > + > > > +Required properties : > > > +- compatible : shall contain only one of the following: > > > + > > > + "qcom,rpmcc-msm8916" > > > > We need to add qcom,rpmcc as a generic compatible as well. > > > > The binding is generic and the clock defines global, so this should work > fine on the dt side of things. But how do we implement this? > > Which set of clocks does the generic rpmcc actually provide? > > Do you foresee that there will be an implementation of the generic rpmcc > or is it just a way to "standardize" the dt binding? > I don't see any problem with implementing the RPM clock controller as one file or two files (one for platform bus based RPM modules and one for SMD bus RPM modules). The compatible can be the same for both struct driver instances, while the bus will pick the right driver. I suspect we'll need SoC specific compatibles though to export the right set of clocks, so having the generic compatible is mostly to find these rpm clock controllers so that we know to skip registering the XO clock from the GCC driver and not some generic implementation of the driver. There's probably a subset of the clocks that's always the same between devices, so if we had to we could match the generic compatible and provide limited functionality. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
On Fri 20 Nov 16:39 PST 2015, Stephen Boyd wrote: > On 11/19, Georgi Djakov wrote: > > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > new file mode 100644 > > index ..bd0fd0cd50dc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > @@ -0,0 +1,35 @@ > > +Qualcomm RPM Clock Controller Binding > > + > > +The RPM is a dedicated hardware engine for managing the shared > > +SoC resources in order to keep the lowest power profile. It > > +communicates with other hardware subsystems via shared memory > > +and accepts clock requests, aggregates the requests and turns > > +the clocks on/off or scales them on demand. > > + > > +Required properties : > > +- compatible : shall contain only one of the following: > > + > > + "qcom,rpmcc-msm8916" > > We need to add qcom,rpmcc as a generic compatible as well. > The binding is generic and the clock defines global, so this should work fine on the dt side of things. But how do we implement this? Which set of clocks does the generic rpmcc actually provide? Do you foresee that there will be an implementation of the generic rpmcc or is it just a way to "standardize" the dt binding? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
On 11/19, Georgi Djakov wrote:
> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
> b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
> new file mode 100644
> index ..bd0fd0cd50dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
> @@ -0,0 +1,35 @@
> +Qualcomm RPM Clock Controller Binding
> +
> +The RPM is a dedicated hardware engine for managing the shared
> +SoC resources in order to keep the lowest power profile. It
> +communicates with other hardware subsystems via shared memory
> +and accepts clock requests, aggregates the requests and turns
> +the clocks on/off or scales them on demand.
> +
> +Required properties :
> +- compatible : shall contain only one of the following:
> +
> + "qcom,rpmcc-msm8916"
We need to add qcom,rpmcc as a generic compatible as well.
> +
> +- #clock-cells : shall contain 1
> +
> +Example:
> + smd {
> + compatible = "qcom,smd";
> +
> + rpm {
> + interrupts = <0 168 1>;
> + qcom,ipc = <&apcs 8 0>;
> + qcom,smd-edge = <15>;
> +
> + rpm_requests {
> + compatible = "qcom,rpm-msm8916";
> + qcom,smd-channels = "rpm_requests";
> +
> + rpmcc: qcom,rpmcc {
> + compatible = "qcom,rpmcc-msm8916";
And here in the example too.
> + #clock-cells = <1>;
> + };
> + };
> + };
> + };
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 4/5] clk: qcom: Add RPM clock controller driver
Add support for clocks that are controlled by the RPM processor
on Qualcomm msm8916 based platforms.
Signed-off-by: Georgi Djakov
---
.../devicetree/bindings/clock/qcom,rpmcc.txt | 35
drivers/clk/qcom/Kconfig |8 +
drivers/clk/qcom/Makefile |1 +
drivers/clk/qcom/rpmcc.c | 206
include/dt-bindings/clock/qcom,rpmcc-msm8916.h | 44 +
5 files changed, 294 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
create mode 100644 drivers/clk/qcom/rpmcc.c
create mode 100644 include/dt-bindings/clock/qcom,rpmcc-msm8916.h
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
new file mode 100644
index ..bd0fd0cd50dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
@@ -0,0 +1,35 @@
+Qualcomm RPM Clock Controller Binding
+
+The RPM is a dedicated hardware engine for managing the shared
+SoC resources in order to keep the lowest power profile. It
+communicates with other hardware subsystems via shared memory
+and accepts clock requests, aggregates the requests and turns
+the clocks on/off or scales them on demand.
+
+Required properties :
+- compatible : shall contain only one of the following:
+
+ "qcom,rpmcc-msm8916"
+
+- #clock-cells : shall contain 1
+
+Example:
+ smd {
+ compatible = "qcom,smd";
+
+ rpm {
+ interrupts = <0 168 1>;
+ qcom,ipc = <&apcs 8 0>;
+ qcom,smd-edge = <15>;
+
+ rpm_requests {
+ compatible = "qcom,rpm-msm8916";
+ qcom,smd-channels = "rpm_requests";
+
+ rpmcc: qcom,rpmcc {
+ compatible = "qcom,rpmcc-msm8916";
+ #clock-cells = <1>;
+ };
+ };
+ };
+ };
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index f06a331e9a24..29aaebcdeffa 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -12,6 +12,14 @@ config COMMON_CLK_QCOM
select REGMAP_MMIO
select RESET_CONTROLLER
+config QCOM_RPMCC
+ tristate "Qualcomm RPM Clock Controller"
+ depends on QCOM_SMD_RPM && COMMON_CLK_QCOM
+ select QCOM_CLK_SMD_RPM
+ help
+ Support for the clocks exposed by the Resource Power Manager
+ processor on devices like apq8016, apq8084 and msm8974.
+
config APQ_GCC_8084
tristate "APQ8084 Global Clock Controller"
select QCOM_GDSC
diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
index b0bc0d3d585f..e58a567ddb42 100644
--- a/drivers/clk/qcom/Makefile
+++ b/drivers/clk/qcom/Makefile
@@ -11,6 +11,7 @@ clk-qcom-y += clk-regmap-mux.o
clk-qcom-y += reset.o
clk-qcom-$(CONFIG_QCOM_CLK_SMD_RPM) += clk-smd-rpm.o
clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o
+clk-qcom-$(CONFIG_QCOM_RPMCC) += rpmcc.o
obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o
obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o
diff --git a/drivers/clk/qcom/rpmcc.c b/drivers/clk/qcom/rpmcc.c
new file mode 100644
index ..55d74a808356
--- /dev/null
+++ b/drivers/clk/qcom/rpmcc.c
@@ -0,0 +1,206 @@
+/*
+ * Copyright (c) 2015, Linaro Limited
+ * Copyright (c) 2014, The Linux Foundation. All rights reserved.
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "clk-smd-rpm.h"
+#include
+
+#define CXO_ID 0x0
+#define QDSS_ID0x1
+#define BUS_SCALING0x2
+
+#define PCNOC_ID 0x0
+#define SNOC_ID0x1
+#define BIMC_ID0x0
+
+#define BB_CLK1_ID 0x1
+#define BB_CLK2_ID 0x2
+#define RF_CLK1_ID 0x4
+#define RF_CLK2_ID 0x5
+
+struct rpm_cc {
+ struct qcom_rpm *rpm;
+ struct clk_onecell_data data;
+ struct clk *clks[];
+};
+
+/* SMD clocks */
+DEFINE_CLK_SMD_RPM(pcnoc_clk, pcnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, PCNOC_ID,
NULL);
+DEFINE_CLK_SMD_RPM(snoc_clk, snoc_a_clk, QCOM_SMD_RPM_BUS_CLK, SNOC_ID, NULL);
+DEFINE_CLK_SMD_RPM(bimc_clk, bimc_a_clk, QCOM_SMD_RPM_MEM_CLK, BIMC_
