Re: [PATCH 00/20] fix magic return value in btrfs-progs
Frist, thank you very much for the patches! I'm going to merge all except 18/20, expecting V2. On Thu, Sep 05, 2013 at 10:14:06AM +0800, Anand Jain wrote: On 09/04/2013 11:22 PM, Wang Shilong wrote: This patchset tries to fix all the magic return value in btrfs-progs. Most commands will have three kinds of return value: 0 success 1 usage of syntax errors Exceptions come from balance/scrub/replace. For example, replace cancel will return 2 if there is no operations in progress. Thanks for writing this much needed. Its better to have these return error codes defined in a header. So that it would guide the future developments. I agree. This means to add symbolic names to the scrub returns codes in 20/20, as an example of a command-specific return codes. I haven't found a good place where to document the generic return values (0/1/-errno etc). Something suites commands.h, others utils.h. If you find more appropriate locations, feel free to use them. david -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/20] fix magic return value in btrfs-progs
On 09/05/2013 10:14 AM, Anand Jain wrote: On 09/04/2013 11:22 PM, Wang Shilong wrote: This patchset tries to fix all the magic return value in btrfs-progs. Most commands will have three kinds of return value: 0 success 1 usage of syntax errors Exceptions come from balance/scrub/replace. For example, replace cancel will return 2 if there is no operations in progress. Thanks for writing this much needed. Its better to have these return error codes defined in a header. So that it would guide the future developments. Agree. We also need update man page.^_^ Thanks, Wang Anand -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/20] fix magic return value in btrfs-progs
This patchset tries to fix all the magic return value in btrfs-progs. Most commands will have three kinds of return value: 0 success 1 usage of syntax errors Exceptions come from balance/scrub/replace. For example, replace cancel will return 2 if there is no operations in progress. Some tools including(btrfsck,chunk-recover) since they are still under development. Also we should update man page if these magic return values have been corrected. Any comments are welcome. Notice: this patchset is based on David integration-20130902 Wang Shilong (20): Btrfs-progs: return 1 rather than 129 in usage() Btrfs-progs: fix magic return value in cmds-subvolume.c Btrfs-progs: fix magic return value in cmds-chunk.c Btrfs-progs: fix magic return value in cmds-dedup.c Btrfs-progs: fix magic return value in cmds-device.c Btrfs-progs: fix magic return value in cmds-filesystem.c Btrfs-progs: fix magic return value in cmds-inspect.c Btrfs-progs: fix magic return value in cmds-qgroup.c Btrfs-progs: fix magic return value in cmds-quota.c Btrfs-progs: fix magic return value in cmds-receive.c Btrfs-progs: fix magic return value in cmds-restore.c Btrfs-progs: fix magic return value in cmds-send.c Btrfs-progs: fix magic return value in btrfs-imgae.c Btrfs-progs: fix magic return value in btrfs-zero-log.c Btrfs-progs: fix magic return value in send-test.c Btrfs-progs: fix magic return value in dir-test.c Btrfs-progs: fix magic return value in random-test.c Btrfs-progs: fix magic return value in cmds-balance.c Btrfs-progs: fix magic return value in cmds-replace.c Btrfs-progs: fix magic return value in cmds-scrub.c btrfs-image.c | 2 +- btrfs-zero-log.c | 8 +++-- cmds-balance.c| 93 ++- cmds-chunk.c | 9 -- cmds-dedup.c | 6 ++-- cmds-device.c | 24 ++ cmds-filesystem.c | 28 - cmds-inspect.c| 10 +++--- cmds-qgroup.c | 26 +++- cmds-quota.c | 10 +++--- cmds-receive.c| 4 +-- cmds-replace.c| 16 ++ cmds-restore.c| 18 +-- cmds-scrub.c | 20 ++-- cmds-send.c | 2 +- cmds-subvolume.c | 45 --- dir-test.c| 16 +- help.c| 2 +- random-test.c | 18 +-- send-test.c | 2 +- 20 files changed, 189 insertions(+), 170 deletions(-) -- 1.7.11.7 -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/20] fix magic return value in btrfs-progs
On 09/04/2013 11:22 PM, Wang Shilong wrote: This patchset tries to fix all the magic return value in btrfs-progs. Most commands will have three kinds of return value: 0 success 1 usage of syntax errors Exceptions come from balance/scrub/replace. For example, replace cancel will return 2 if there is no operations in progress. Thanks for writing this much needed. Its better to have these return error codes defined in a header. So that it would guide the future developments. Anand -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
