Re: btrfs goes readonly + No space left on 4.3
Stefan Priebe - Profihost AG posted on Mon, 09 May 2016 14:59:25 +0200 as excerpted: > Am 03.05.2016 um 00:05 schrieb Omar Sandoval: >> On Fri, Apr 29, 2016 at 10:48:15PM +0200, Stefan Priebe wrote: >>> just want to drop a note that all those ENOSPC msg are gone with v4.5 >>> and space_cache=v2. Any plans to make space_cache=v2 default? >>> >> Yup, we want to make space_cache=v2 the default at some point. I'm >> running it on my own machines and testing it here at Facebook and >> haven't run into any issues yet. Besides stability, I also want to make >> sure there aren't any performance regressions versus the old free space >> cache that we haven't thought about yet. >> >> Thanks for trying it out :) > > Can i patch v2 as a default for me? I just looked at the code but didn't > find an easy way to make v2 the default. Based on previous posts, space_cache=v2 will rewrite the cache to tree form, and it'll stay that way (thus your default) until you specifically use the clear-cache option. IOW, the code detects existing v1 or v2 and continues to use it until a clear-cache mount and no v2 set on the mount after, to switch back to v1, or a space_cache=v2 to switch to it. IOW, the space_cache option doesn't need set more than once (and for v1, it doesn't actually need set at all, except perhaps after a clear_cache, I've never specifically set space_cache here, but it's always listed in the mount output and /proc/self/mounts). After that it carries on the way it was. Or did you mean that you're creating enough new btrfs that using space_cache=v2 even once is difficult, and you'd like to patch it to use v2 from the get-go? Presumably that can indeed be patched in, but not being a dev, even if I could figure out a patch that worked for it, there's a fair chance it would be more a hack than proper code. (As an admin I have a patch that switches the normal relatime default to noatime, so I don't have to have it in all my fstab entries, etc, and it works, but it's clearly a hack compared to what a proper dev would code.) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: btrfs goes readonly + No space left on 4.3
Am 03.05.2016 um 00:05 schrieb Omar Sandoval: > On Fri, Apr 29, 2016 at 10:48:15PM +0200, Stefan Priebe wrote: >> just want to drop a note that all those ENOSPC msg are gone with v4.5 and >> space_cache=v2. Any plans to make space_cache=v2 default? >> >> Greets, >> Stefan > > Yup, we want to make space_cache=v2 the default at some point. I'm > running it on my own machines and testing it here at Facebook and > haven't run into any issues yet. Besides stability, I also want to make > sure there aren't any performance regressions versus the old free space > cache that we haven't thought about yet. > > Thanks for trying it out :) Can i patch v2 as a default for me? I just looked at the code but didn't find an easy way to make v2 the default. Greets, Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: btrfs goes readonly + No space left on 4.3
On Tue, May 03, 2016 at 04:06:05AM +, Paul Jones wrote: > > -Original Message- > > From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs- > > ow...@vger.kernel.org] On Behalf Of Omar Sandoval > > Sent: Tuesday, 3 May 2016 8:06 AM > > To: Stefan Priebe <s.pri...@profihost.ag> > > Cc: linux-btrfs@vger.kernel.org > > Subject: Re: btrfs goes readonly + No space left on 4.3 > > > > On Fri, Apr 29, 2016 at 10:48:15PM +0200, Stefan Priebe wrote: > > > just want to drop a note that all those ENOSPC msg are gone with v4.5 > > > and space_cache=v2. Any plans to make space_cache=v2 default? > > > > > > Greets, > > > Stefan > > > > Yup, we want to make space_cache=v2 the default at some point. I'm > > running it on my own machines and testing it here at Facebook and haven't > > run into any issues yet. Besides stability, I also want to make sure there > > aren't any performance regressions versus the old free space cache that we > > haven't thought about yet. > > > > Thanks for trying it out :) > > I have also been testing it and have had no problems. > > One question I have about it: I use Grub2 to boot my systems directly from a > BTRFS root partition (i.e. no separate /boot), I assume Grub shouldn't need > to care about free space tree/cache as it's only reading data? I don't know > enough about either to know if it's an issue or not. > > Thanks, > Paul. Yeah, the free space tree doesn't make a difference when the filesystem is used read-only. In fact, you can mount a filesystem with space_cache=v2 enabled read-only on older kernel versions. -- Omar -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: btrfs goes readonly + No space left on 4.3
> -Original Message- > From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs- > ow...@vger.kernel.org] On Behalf Of Omar Sandoval > Sent: Tuesday, 3 May 2016 8:06 AM > To: Stefan Priebe <s.pri...@profihost.ag> > Cc: linux-btrfs@vger.kernel.org > Subject: Re: btrfs goes readonly + No space left on 4.3 > > On Fri, Apr 29, 2016 at 10:48:15PM +0200, Stefan Priebe wrote: > > just want to drop a note that all those ENOSPC msg are gone with v4.5 > > and space_cache=v2. Any plans to make space_cache=v2 default? > > > > Greets, > > Stefan > > Yup, we want to make space_cache=v2 the default at some point. I'm > running it on my own machines and testing it here at Facebook and haven't > run into any issues yet. Besides stability, I also want to make sure there > aren't any performance regressions versus the old free space cache that we > haven't thought about yet. > > Thanks for trying it out :) I have also been testing it and have had no problems. One question I have about it: I use Grub2 to boot my systems directly from a BTRFS root partition (i.e. no separate /boot), I assume Grub shouldn't need to care about free space tree/cache as it's only reading data? I don't know enough about either to know if it's an issue or not. Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: btrfs goes readonly + No space left on 4.3
On Fri, Apr 29, 2016 at 10:48:15PM +0200, Stefan Priebe wrote: > just want to drop a note that all those ENOSPC msg are gone with v4.5 and > space_cache=v2. Any plans to make space_cache=v2 default? > > Greets, > Stefan Yup, we want to make space_cache=v2 the default at some point. I'm running it on my own machines and testing it here at Facebook and haven't run into any issues yet. Besides stability, I also want to make sure there aren't any performance regressions versus the old free space cache that we haven't thought about yet. Thanks for trying it out :) -- Omar -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: btrfs goes readonly + No space left on 4.3
just want to drop a note that all those ENOSPC msg are gone with v4.5 and space_cache=v2. Any plans to make space_cache=v2 default? Greets, Stefan Am 12.10.2015 um 09:00 schrieb Stefan Priebe: Hi, while trying to write to my volume btrfs gets readonly: btrfs fi show /vmbackup/ Label: none uuid: f4afaac2-c587-4ff7-87b1-19e6a483215f Total devices 1 FS bytes used 35.56TiB devid1 size 50.93TiB used 35.72TiB path /dev/mapper/stripe0-vmbackup btrfs-progs v4.1.2 btrfs fi df /vmbackup/ Data, single: total=35.40TiB, used=35.40TiB System, DUP: total=8.00MiB, used=3.75MiB Metadata, DUP: total=162.00GiB, used=160.72GiB GlobalReserve, single: total=512.00MiB, used=0.00B This is 4.1.10 with all btrfs patches up to 4.3-rc3 [ 6230.406369] [ cut here ] [ 6230.411594] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.463718] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.466681] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.475887] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.505852] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.525233] BTRFS warning (device dm-0): btrfs_finish_ordered_io:2840: Aborting unused transaction(No space left). [ 6230.851050] WARNING: CPU: 8 PID: 8230 at fs/btrfs/extent-tree.c:6356 __btrfs_free_extent.isra.83+0x2cc/0xce0 [btrfs]() [ 6230.911727] BTRFS: Transaction aborted (error -28) [ 6230.911729] Modules linked in: netconsole ipt_REJECT nf_reject_ipv4 xt_multiport iptable_filter ip_tables x_tables bonding ext2 coretemp loop usbhid ehci_pci ehci_hcd sb_edac i2c_i801 ipmi_si usbcore edac_core i2c_core shpchp usb_common ipmi_msghandler button btrfs lzo_compress dm_mod raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq raid1 md_mod i40e(O) ixgbe vxlan ip6_udp_tunnel mdio udp_tunnel sg sd_mod ahci ptp aacraid libahci pps_core [ 6231.175922] CPU: 8 PID: 8230 Comm: btrfs-transacti Tainted: GO 4.1.10 #1 [ 6231.243585] Hardware name: Supermicro X10DRH/X10DRH-IT, BIOS 1.0c 02/18/2015 [ 6231.311584] c0433895 88085a8db9b8 8a639186 0001 [ 6231.380600] 88085a8dba08 88085a8db9f8 8a07fd57 88080850 [ 6231.449888] 880311fef2d0 1fcbf245 [ 6231.519402] Call Trace: [ 6231.586837] [] dump_stack+0x45/0x57 [ 6231.654260] [] warn_slowpath_common+0x97/0xe0 [ 6231.721958] [] warn_slowpath_fmt+0x46/0x50 [ 6231.789246] [] __btrfs_free_extent.isra.83+0x2cc/0xce0 [btrfs] [ 6231.857732] [] ? block_group_cache_tree_search+0x98/0xf0 [btrfs] [ 6231.926972] [] ? find_ref_head+0x6c/0x90 [btrfs] [ 6231.995254] [] __btrfs_run_delayed_refs+0x730/0x11a0 [btrfs] [ 6232.062995] [] btrfs_run_delayed_refs+0x7f/0x290 [btrfs] [ 6232.130929] [] btrfs_write_dirty_block_groups+0x103/0x2a0 [btrfs] [ 6232.199577] [] commit_cowonly_roots+0x225/0x2cf [btrfs] [ 6232.268690] [] btrfs_commit_transaction+0x538/0xa90 [btrfs] [ 6232.338554] [] transaction_kthread+0x1c5/0x240 [btrfs] [ 6232.407982] [] ? open_ctree+0x2390/0x2390 [btrfs] [ 6232.476521] [] kthread+0xc9/0xe0 [ 6232.544430] [] ? kthread_create_on_node+0x1a0/0x1a0 [ 6232.612249] [] ret_from_fork+0x42/0x70 [ 6232.680322] [] ? kthread_create_on_node+0x1a0/0x1a0 [ 6232.748832] ---[ end trace 4977add5c48cdc47 ]--- [ 6232.816367] BTRFS: error (device dm-0) in __btrfs_free_extent:6356: errno=-28 No space left [ 6232.885109] BTRFS info (device dm-0): forced readonly [ 6232.953994] BTRFS: error (device dm-0) in btrfs_run_delayed_refs:2854: errno=-28 No space left [ 6233.027127] BTRFS warning (device dm-0): Skipping commit of aborted transaction. [ 6233.098974] BTRFS: error (device dm-0) in cleanup_transaction:1726: errno=-28 No space left Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html