[linux-dvb] bug in szap utility
Hello Marcel, I did not try your patch, but the following one against linuxtv-dvb-apps-1.1.1.tar.bz2. (available @linuxtv.org). Unfortunately had to adjust the line numbers plus a blank in lines 3 and 6. Result: The trouble with the wrong polarization printout is gone. H conforms to h now. Guess you can commit that now, so that the Debian packagers can repackage that stuff. P. S.: I was missing an install-section in the Makefile of that tarball. Can you fix that too, please? Cause without that section it is only half. Thanks for the quick response and all your efforts! --- a/util/szap/szap.c Fri Feb 02 02:16:24 2007 +0100 +++ b/util/szap/szap.c Tue Mar 06 18:53:39 2007 +0100 @@ -383,7 +383,7 @@ again: if (!(field = strsep(tmp, :))) goto syntax_err; -pol = (field[0] == 'h' ? 0 : 1); +pol = (tolower(field[0]) == 'h' ? 0 : 1); if (!(field = strsep(tmp, :))) goto syntax_err; Uwe P. S.: Still waiting for my 2 contributions to be committed! (i. e. DST-deselect plus documentary fix) -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] bug in szap-utility
Original-Nachricht Datum: Tue, 06 Mar 2007 20:14:16 +0100 Von: Michel Verbraak [EMAIL PROTECTED] An: linux-dvb@linuxtv.org CC: Betreff: Re: [linux-dvb] bug in szap-utility Uwe Bugla schreef: Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 With which program did you create the trapz.txt file? Salut Michel, with a program called pere which is a new revolutionary development as it scans a lot of more accurate as scan or dvbscan ever did! But please ignore that and see the szap bug instead. The error only happens with H, not with V, OK? My scan or scandvb program creates only lower cases polarization characters (v or h). I think the szap program only recognizes lowercase by design. In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Regards Uwe -- Feel free - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] bug in szap-utility
Original-Nachricht Datum: Tue, 6 Mar 2007 18:55:51 +0100 Von: Marcel Siegert [EMAIL PROTECTED] An: Uwe Bugla [EMAIL PROTECTED] CC: linux-dvb@linuxtv.org, [EMAIL PROTECTED] Betreff: Re: [linux-dvb] bug in szap-utility On Tuesday 06 March 2007, Uwe Bugla wrote: Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? hi, could you please try if a --- a/util/szap/szap.c Fri Feb 02 02:16:24 2007 +0100 +++ b/util/szap/szap.c Tue Mar 06 18:53:39 2007 +0100 @@ -496,7 +496,7 @@ again: if (!(field = strsep(tmp, :))) goto syntax_err; -pol = (field[0] == 'h' ? 0 : 1); +pol = (tolower(field[0]) == 'h' ? 0 : 1); if (!(field = strsep(tmp, :))) goto syntax_err; would fix that problem? if reported fine, i'll commit that. thanks marcel Thanks Marcel, I am going to download the source code and try your patch. Gimme a couple of days time please. Thanks and regards Uwe -- Feel free - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] bug in szap-utility
On Friday 09 March 2007, Uwe Bugla wrote: Original-Nachricht Datum: Tue, 06 Mar 2007 20:14:16 +0100 Von: Michel Verbraak [EMAIL PROTECTED] An: linux-dvb@linuxtv.org CC: Betreff: Re: [linux-dvb] bug in szap-utility Uwe Bugla schreef: Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 With which program did you create the trapz.txt file? Salut Michel, with a program called pere which is a new revolutionary development as it scans a lot of more accurate as scan or dvbscan ever did! But please ignore that and see the szap bug instead. The error only happens with H, not with V, OK? My scan or scandvb program creates only lower cases polarization characters (v or h). I think the szap program only recognizes lowercase by design. In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Regards Uwe hi uwe, yes, your predication is correct on the is does not happen at v or V for polarization. if you have a look at the sources, and also at my proposed patch - i am still waiting for your answer - szap just check[s|ed] for the h and if that is NOT present is assumes v. so everything else than a h or (with my patch applied) H will be treated as vertical. regards marcel ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] bug in szap-utility
Original-Nachricht Datum: Fri, 9 Mar 2007 13:52:07 +0100 Von: Marcel Siegert [EMAIL PROTECTED] An: linux-dvb@linuxtv.org CC: Uwe Bugla [EMAIL PROTECTED] Betreff: Re: [linux-dvb] bug in szap-utility On Friday 09 March 2007, Uwe Bugla wrote: Original-Nachricht Datum: Tue, 06 Mar 2007 20:14:16 +0100 Von: Michel Verbraak [EMAIL PROTECTED] An: linux-dvb@linuxtv.org CC: Betreff: Re: [linux-dvb] bug in szap-utility Uwe Bugla schreef: Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 With which program did you create the trapz.txt file? Salut Michel, with a program called pere which is a new revolutionary development as it scans a lot of more accurate as scan or dvbscan ever did! But please ignore that and see the szap bug instead. The error only happens with H, not with V, OK? My scan or scandvb program creates only lower cases polarization characters (v or h). I think the szap program only recognizes lowercase by design. In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Regards Uwe hi uwe, yes, your predication is correct on the is does not happen at v or V for polarization. if you have a look at the sources, and also at my proposed patch - i am still waiting for your answer - szap just check[s|ed] for the h and if that is NOT present is assumes v. so everything else than a h or (with my patch applied) H will be treated as vertical. regards marcel Marcel, again: Thanks for your help. But please give me some time, OK? I aint no robot, OK? No sweat please, take it slow, OK? Regards Uwe -- Feel free - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] bug in szap-utility
Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] bug in szap-utility
Uwe Bugla schreef: Hi folks, as part of the Debain package dvb-utils 1.1.1-2 the szap utility has the following bug: 1. The start transponder file of Eutelsat Hotbird13.0E contains a H as description of the polarization. 2. Unfortunately this H is being interpreted as V. 3. So if you try to produce a transponder list with the start transponder you are trapped as nothing works! To see the error yourself, try the following example in the console: szap -r -a0 -c trapz.txt -n1 where trapz.txt looks like this: Hotbird-13.0E:12539:H:1:27500 With which program did you create the trapz.txt file? My scan or scandvb program creates only lower cases polarization characters (v or h). I think the szap program only recognizes lowercase by design. In the console you will see the right frequency and the right symbol rate. But the polarization will be printed out as V (vertical) instead of H (horizontal). In other words: The bug is: szap cannot set equal the letter h with the letter H Regards Uwe P. S.: I solved the problem by a TCL-TK workaround, but it rather should be solved in the sourcecode, shouldn't it? So can someone reading this please fix that bug in the source code? ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
