Re: [PATCH] Fix ext4 bitops
On Sun, 3 Feb 2008, Heiko Carstens wrote:
On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote:
On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:
On Fri, 1 Feb 2008 21:02:08 +0100
Bastian Blank [EMAIL PROTECTED] wrote:
Fix ext4 bitops.
This is incomplete. Please tell us what was fixed.
If it was a build error then please quote the compile error output in the
changelog, as well as the usual description of what the problem is, and
how
it was fixed.
| fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy':
| fs/ext4/mballoc.c:954: error: implicit declaration of function
'generic_find_next_le_bit'
The s390 specific bitops uses parts of the generic implementation.
Include the correct header.
That doesn't work:
fs/built-in.o: In function `ext4_mb_release_inode_pa':
mballoc.c:(.text+0x95a8a): undefined reference to `generic_find_next_le_bit'
fs/built-in.o: In function `ext4_mb_init_cache':
mballoc.c:(.text+0x967ea): undefined reference to `generic_find_next_le_bit'
This still needs generic_find_next_le_bit which comes
from lib/find_next_bit.c. That one doesn't get built on s390 since we
don't set GENERIC_FIND_NEXT_BIT.
Currently we have the lengthly patch below queued.
Similar issue on m68k. As Bastian also saw it on powerpc, I'm getting the
impression the ext4 people don't (compile) test on big endian machines?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Parallelize IO for e2fsck
Hi Pavel As user pages are always in highmem, this should be easy to decide: only send SIGDANGER when highmem is full. (Yes, there are inodes/dentries/file descriptors in lowmem, but I doubt apps will respond to SIGDANGER by closing files). Good point; for a system with at least (say) 2GB of memory, that definitely makes sense. For a system with less than 768 megs of memory (how quaint, but it wasn't that long ago this was a lot of memory :-), there wouldn't *be* any memory in highmem at all Ok, so it is 'send SIGDANGER when all zones are low', because user allocations can go from all zones (unless you have something really exotic, I'm not sure if that is true on huge NUMA machines similar). thank you good point out. to be honest, the zone awareness of current mem_notify is premature. I think we need enhancement rss statistics to per zone rss. but not implemented yet ;-) and, unfortunately I have no highmem machine. the mem_notify is not so tested on highmem machine. if you help to test, I am very happy! Thanks. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
- disable-ext4.patch removed from -mm tree
The patch titled disable-ext4 has been removed from the -mm tree. Its filename was disable-ext4.patch This patch was dropped because it is obsolete The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ -- Subject: disable-ext4 From: Andrew Morton [EMAIL PROTECTED] The defrag patches use iget(), which will not be present in 2.6.25 Cc: Theodore Ts'o [EMAIL PROTECTED] Cc: David Howells [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- fs/Kconfig |1 + 1 file changed, 1 insertion(+) diff -puN fs/Kconfig~disable-ext4 fs/Kconfig --- a/fs/Kconfig~disable-ext4 +++ a/fs/Kconfig @@ -139,6 +139,7 @@ config EXT3_FS_SECURITY config EXT4DEV_FS tristate Ext4dev/ext4 extended fs support development (EXPERIMENTAL) depends on EXPERIMENTAL + depends on BROKEN select JBD2 select CRC16 help _ Patches currently in -mm which might be from [EMAIL PROTECTED] are origin.patch kvm-i386-fix.patch drivers-net-wireless-b43-mainc-needs-ioh.patch get_task_comm-return-the-result.patch clone-prepare-to-recycle-clone_detached-and-clone_stopped.patch clone-prepare-to-recycle-clone_detached-and-clone_stopped-fix.patch timerfd-v3-new-timerfd-api-make-the-returned-time-to-be-the-remaining-time-till-the-next-expiration-checkpatch-fixes.patch timerfd-v3-new-timerfd-api-ia64-fix.patch timerfd-v3-new-timerfd-api-m68k-fix.patch timerfd-v3-new-timerfd-api-mips-fix.patch timerfd-v3-new-timerfd-api-arch-fixes.patch timerfd-v3-new-timerfd-api-powerpc-fix.patch timerfd-v3-new-timerfd-api-sparc64-fix.patch drivers-usb-serial-io_tic-remove-pointless-eye-candy-in-debug-statements.patch drivers-usb-serial-io_tic-remove-pointless-eye-candy-in-debug-statements-checkpatch-fixes.patch git-acpi.patch acpi-enable-c3-power-state-on-dell-inspiron-8200.patch small-acpica-extension-to-be-able-to-store-the-name-of.patch acpi-backlight-reset-brightness-on-resume-checkpatch-fixes.patch git-alsa-disable-sound-pci-ice1712-ice1724c.patch git-agpgart.patch git-agpgart-fix.patch git-audit-master.patch git-audit-printk-warning-fix.patch cifs-fix-warning.patch git-cpufreq.patch revert-agk-dm-dm-loop.patch include-asm-powerpc-nvramh-needs-listh.patch include-asm-powerpc-nvramh-needs-listh-fix.patch drivers-pcmcia-i82092c-fix-up-after-pci_bus_region-changes.patch git-drm.patch git-drm-fix.patch drm-convert-from-nopage-to-fault-checkpatch-fixes.patch drivers-media-video-em28xx-em28xx-corec-fix-use-of-potentially-uninitialized-variable.patch adt7473-new-driver-for-analog-devices-adt7473-sensor-chip-fix.patch revert-git-hrt.patch infiniband-is-scrogged-again.patch i8042-non-x86-build-fix.patch drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning.patch git-kbuild.patch git-kvm.patch ata-drivers-ata-sata_mvc-needs-dmapoolh.patch drivers-ide-ide-acpic-fix-uninitialized-var-warning.patch drivers-ide-legacy-hdc-fix-uninitialized-var-warning.patch git-md-accel.patch memstick-initial-commit-for-sony-memorystick-support-fix-2.patch memstick-git-busted.patch git-mmc.patch git-mtd.patch git-netdev-all-fix-conflicts-fix.patch drivers-net-dm9000c-vague-probably-wrong-build-fix.patch update-smc91x-driver-with-arm-versatile-board-info.patch git-backlight.patch bluetooth-uninlining.patch serial-add-addi-data-gmbh-communication-cardsin8250_pcic-and-pci_idsh-checkpatch-fixes.patch fix-gregkh-pci-pci-pcie-aspm-support.patch cleanup-gregkh-pci-pci-fix-bus-resource-assignment-on-32-bits-with-64b-resources.patch quirks-set-en-bit-of-msi-mapping-for-devices-onht-based-nvidia-platform-checkpatch-fixes.patch x86-validate-against-acpi-motherboard-resources.patch git-sched.patch git-scsi-misc.patch scsi-fix-isa-pcmcia-compile-problem-checkpatch-fixes.patch scsi-aic94xx-cleanups-checkpatch-fixes.patch scsi-aic94xx-cleanups-checkpatch-fixes-checkpatch-fixes.patch drivers-scsi-dc395xc-fix-uninitialized-var-warning.patch libsas-convert-ata-bridge-to-use-new-eh.patch git-unionfs.patch vfs-swap-do_ioctl-and-vfs_ioctl-names-fix.patch ehci-hcd-fix-sparse-warning-about-shadowing-status-symbol-checkpatch-fixes.patch drivers-usb-storage-sddr55c-fix-uninitialized-var-warnings.patch usb-ohci-sm501-driver-v2-fix.patch 9p-fix-p9_printfcall-export.patch git-watchdog.patch git-watchdog-fixup.patch b43-fix-build-with-config_ssb_pcihost=n.patch git-ipwireless_cs.patch git-x86.patch git-x86-fix-rejects.patch git-x86-vs-pm-acquire-device-locks-on-suspend-rev-3.patch pci-dont-load-acpi_php-when-acpi-is-disabled.patch pci-dont-load-acpi_php-when-acpi-is-disabled-fix.patch x86-amd-thermal-interrupt-support-fix-2.patch x86-mmconf-enable-mcfg-early-cleanup.patch git-xtensa.patch pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix.patch pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2.patch vmalloc-add-const-to-void-parameters-fix.patch
Re: - disable-ext4.patch removed from -mm tree
On Sun, 03 Feb 2008 12:18:35 -0800 [EMAIL PROTECTED] wrote: The patch titled disable-ext4 has been removed from the -mm tree. Its filename was disable-ext4.patch I dropped the entire ext4 patch series, because the newly-added convert-to-iget_locked patch has wrecked the iget-coversion patch which I have queued. Please do not merge that patch under my feet. When I merge David's iget coversion patches this will instead wreck the ext4 patchset. Dunno what to do about this sort of thing, apart from encouraging developers to take a look at what's happening in other trees before merging stuff. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: - disable-ext4.patch removed from -mm tree
On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: When I merge David's iget coversion patches this will instead wreck the ext4 patchset. That's ok, it shouldn't be hard for me to fix this up. How quickly will you be able to merge David's iget converstion patches? Could this get pushed to Linus, say, tomorrow? - Ted - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: - disable-ext4.patch removed from -mm tree
On Sun, 3 Feb 2008 20:36:26 -0500 Theodore Tso [EMAIL PROTECTED] wrote: On Sun, Feb 03, 2008 at 12:25:51PM -0800, Andrew Morton wrote: When I merge David's iget coversion patches this will instead wreck the ext4 patchset. That's ok, it shouldn't be hard for me to fix this up. How quickly will you be able to merge David's iget converstion patches? They're about 1,000 patches back. Could this get pushed to Linus, say, tomorrow? No. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
- pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2.patch removed from -mm tree
The patch titled
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
has been removed from the -mm tree. Its filename was
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2.patch
This patch was dropped because it was folded into
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
--
Subject:
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
From: Andrew Morton [EMAIL PROTECTED]
Cc: J. Bruce Fields [EMAIL PROTECTED]
Cc: linux-ext4@vger.kernel.org
Cc: Anton Altaparmakov [EMAIL PROTECTED]
Cc: Christoph Lameter [EMAIL PROTECTED]
Cc: David Chinner [EMAIL PROTECTED]
Cc: Mark Fasheh [EMAIL PROTECTED]
Cc: Michael Halcrow [EMAIL PROTECTED]
Cc: Steven French [EMAIL PROTECTED]
Cc: Steven Whitehouse [EMAIL PROTECTED]
Cc: Trond Myklebust [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
fs/ntfs/compress.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN
fs/nfs/write.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
fs/nfs/write.c
diff -puN
fs/ntfs/aops.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
fs/ntfs/aops.c
diff -puN
net/unix/af_unix.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
net/unix/af_unix.c
diff -puN
fs/ntfs/compress.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
fs/ntfs/compress.c
---
a/fs/ntfs/compress.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2
+++ a/fs/ntfs/compress.c
@@ -565,7 +565,7 @@ int ntfs_read_compressed_block(struct pa
if (xpage = max_page) {
kfree(bhs);
kfree(pages);
- zero_user_page(page, 0, PAGE_CACHE_SIZE, KM_USER0);
+ zero_user(page, 0, PAGE_CACHE_SIZE);
ntfs_debug(Compressed read outside i_size - truncated?);
SetPageUptodate(page);
unlock_page(page);
_
Patches currently in -mm which might be from [EMAIL PROTECTED] are
origin.patch
kvm-i386-fix.patch
drivers-net-wireless-b43-mainc-needs-ioh.patch
get_task_comm-return-the-result.patch
clone-prepare-to-recycle-clone_detached-and-clone_stopped.patch
timerfd-v3-new-timerfd-api.patch
include-asm-powerpc-nvramh-needs-listh.patch
serial-add-addi-data-gmbh-communication-cardsin8250_pcic-and-pci_idsh.patch
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2.patch
vmalloc-add-const-to-void-parameters-fix.patch
i386-resolve-dependency-of-asm-i386-pgtableh-on-highmemh-checkpatch-fixes.patch
slub-fix-coding-style-violations-checkpatch-fixes.patch
slub-provide-unique-end-marker-for-each-slab-fix.patch
slub-do-our-own-locking-via-slab_lock-and-slab_unlock-checkpatch-fixes.patch
bufferhead-revert-constructor-removal-checkpatch-fixes.patch
shmem-factor-out-sbi-free_inodes-manipulations-fix.patch
maps4-rework-task_size-macros-mips-fix.patch
maps4-add-proc-kpagecount-interface-fix.patch
maps4-add-proc-kpageflags-interface-fix.patch
maps4-add-proc-kpageflags-interface-fix-2-fix.patch
maps4-make-page-monitoring-proc-file-optional-fix.patch
page-allocator-clean-up-pcp-draining-functions-swsusp-fix-fix.patch
add-mm-argument-to-pte-pmd-pud-pgd_free-checkpatch-fixes.patch
mm-page-writeback-highmem_is_dirtyable-option-fix.patch
mm-remove-fastcall-from-mm-checkpatch-fixes.patch
page-migraton-handle-orphaned-pages-fix.patch
vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
vm-dont-run-touch_buffer-during-buffercache-lookups.patch
revert-capabilities-clean-up-file-capability-reading.patch
revert-capabilities-clean-up-file-capability-reading-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-fix.patch
add-64-bit-capability-support-to-the-kernel-fix-modify-old-libcap-warning-message-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-fix-modify-old-libcap-warning-message-fix.patch
smack-version-11c-simplified-mandatory-access-control-kernel-fix.patch
alpha-atomic_add_return-should-return-int.patch
alpha-fix-warning-by-fixing-flush_tlb_kernel_range.patch
pm-qos-infrastructure-and-interface.patch
pm-qos-infrastructure-and-interface-static-initialization-with-blocking-notifiers.patch
dio-array_size-cleanup-update-checkpatch-fixes.patch
uml-get-rid-of-asmlinkage-checkpatch-fixes.patch
uml-improve-detection-of-host-cmov-checkpatch-fixes.patch
uml-further-bugsc-tidying-checkpatch-fixes.patch
kernel-printkc-concerns-about-the-console-handover.patch
riscom8-fix-smp-brokenness-fix.patch
sound-oss-pss-set_io_base-always-returns-success-mark-it-void-checkpatch-fixes.patch
- pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix.patch removed from -mm tree
The patch titled
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
has been removed from the -mm tree. Its filename was
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix.patch
This patch was dropped because it was folded into
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
--
Subject:
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
From: Andrew Morton [EMAIL PROTECTED]
Cc: J. Bruce Fields [EMAIL PROTECTED]
Cc: linux-ext4@vger.kernel.org
Cc: Anton Altaparmakov [EMAIL PROTECTED]
Cc: Christoph Lameter [EMAIL PROTECTED]
Cc: David Chinner [EMAIL PROTECTED]
Cc: Mark Fasheh [EMAIL PROTECTED]
Cc: Michael Halcrow [EMAIL PROTECTED]
Cc: Steven French [EMAIL PROTECTED]
Cc: Steven Whitehouse [EMAIL PROTECTED]
Cc: Trond Myklebust [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
fs/nfs/write.c |2 +-
fs/ntfs/aops.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN
fs/nfs/write.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
fs/nfs/write.c
---
a/fs/nfs/write.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
+++ a/fs/nfs/write.c
@@ -669,7 +669,7 @@ zero_page:
* then we need to zero any uninitalised data. */
if (req-wb_pgbase == 0 req-wb_bytes != PAGE_CACHE_SIZE
!PageUptodate(req-wb_page))
- zero_user_page(req-wb_page, req-wb_bytes, PAGE_CACHE_SIZE);
+ zero_user_segment(req-wb_page, req-wb_bytes, PAGE_CACHE_SIZE);
return req;
}
diff -puN
fs/ntfs/aops.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
fs/ntfs/aops.c
---
a/fs/ntfs/aops.c~pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix
+++ a/fs/ntfs/aops.c
@@ -414,7 +414,7 @@ retry_readpage:
/* Is the page fully outside i_size? (truncate in progress) */
if (unlikely(page-index = (i_size + PAGE_CACHE_SIZE - 1)
PAGE_CACHE_SHIFT)) {
- zero_user_page(page, 0, PAGE_CACHE_SIZE, KM_USER0);
+ zero_user(page, 0, PAGE_CACHE_SIZE);
ntfs_debug(Read outside i_size - truncated?);
goto done;
}
_
Patches currently in -mm which might be from [EMAIL PROTECTED] are
origin.patch
kvm-i386-fix.patch
drivers-net-wireless-b43-mainc-needs-ioh.patch
get_task_comm-return-the-result.patch
clone-prepare-to-recycle-clone_detached-and-clone_stopped.patch
timerfd-v3-new-timerfd-api.patch
include-asm-powerpc-nvramh-needs-listh.patch
serial-add-addi-data-gmbh-communication-cardsin8250_pcic-and-pci_idsh.patch
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user.patch
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix.patch
pagecache-zeroing-zero_user_segment-zero_user_segments-and-zero_user-fix-2.patch
vmalloc-add-const-to-void-parameters-fix.patch
i386-resolve-dependency-of-asm-i386-pgtableh-on-highmemh-checkpatch-fixes.patch
slub-fix-coding-style-violations-checkpatch-fixes.patch
slub-provide-unique-end-marker-for-each-slab-fix.patch
slub-do-our-own-locking-via-slab_lock-and-slab_unlock-checkpatch-fixes.patch
bufferhead-revert-constructor-removal-checkpatch-fixes.patch
shmem-factor-out-sbi-free_inodes-manipulations-fix.patch
maps4-rework-task_size-macros-mips-fix.patch
maps4-add-proc-kpagecount-interface-fix.patch
maps4-add-proc-kpageflags-interface-fix.patch
maps4-add-proc-kpageflags-interface-fix-2-fix.patch
maps4-make-page-monitoring-proc-file-optional-fix.patch
page-allocator-clean-up-pcp-draining-functions-swsusp-fix-fix.patch
add-mm-argument-to-pte-pmd-pud-pgd_free-checkpatch-fixes.patch
mm-page-writeback-highmem_is_dirtyable-option-fix.patch
mm-remove-fastcall-from-mm-checkpatch-fixes.patch
page-migraton-handle-orphaned-pages-fix.patch
vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
vm-dont-run-touch_buffer-during-buffercache-lookups.patch
revert-capabilities-clean-up-file-capability-reading.patch
revert-capabilities-clean-up-file-capability-reading-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-fix.patch
add-64-bit-capability-support-to-the-kernel-fix-modify-old-libcap-warning-message-checkpatch-fixes.patch
add-64-bit-capability-support-to-the-kernel-fix-modify-old-libcap-warning-message-fix.patch
smack-version-11c-simplified-mandatory-access-control-kernel-fix.patch
alpha-atomic_add_return-should-return-int.patch
alpha-fix-warning-by-fixing-flush_tlb_kernel_range.patch
pm-qos-infrastructure-and-interface.patch
pm-qos-infrastructure-and-interface-static-initialization-with-blocking-notifiers.patch
dio-array_size-cleanup-update-checkpatch-fixes.patch
Re: [PATCH] Fix ext4 bitops
On Sun, Feb 03, 2008 at 01:39:02PM +0100, Geert Uytterhoeven wrote:
On Sun, 3 Feb 2008, Heiko Carstens wrote:
On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote:
On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:
On Fri, 1 Feb 2008 21:02:08 +0100
Bastian Blank [EMAIL PROTECTED] wrote:
Fix ext4 bitops.
This is incomplete. Please tell us what was fixed.
If it was a build error then please quote the compile error output in
the
changelog, as well as the usual description of what the problem is, and
how
it was fixed.
| fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy':
| fs/ext4/mballoc.c:954: error: implicit declaration of function
'generic_find_next_le_bit'
The s390 specific bitops uses parts of the generic implementation.
Include the correct header.
That doesn't work:
fs/built-in.o: In function `ext4_mb_release_inode_pa':
mballoc.c:(.text+0x95a8a): undefined reference to `generic_find_next_le_bit'
fs/built-in.o: In function `ext4_mb_init_cache':
mballoc.c:(.text+0x967ea): undefined reference to `generic_find_next_le_bit'
This still needs generic_find_next_le_bit which comes
from lib/find_next_bit.c. That one doesn't get built on s390 since we
don't set GENERIC_FIND_NEXT_BIT.
Currently we have the lengthly patch below queued.
Similar issue on m68k. As Bastian also saw it on powerpc, I'm getting the
impression the ext4 people don't (compile) test on big endian machines?
Gr{oetje,eeting}s,
I have sent this patches to linux-arch expecting a review from
different arch people. It is true that the patches are tested only on
powerpc, x86-64, x86. That's the primary reason of me sending the
patches to linux-arch.
http://marc.info/?l=linux-archm=119503501127737w=2
-aneesh
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: BUG_ON at mballoc.c:3752
On Thu, Jan 31, 2008 at 04:42:07PM +0100, Eric Sesterhenn wrote: * Eric Sesterhenn ([EMAIL PROTECTED]) wrote: hi, while running a modified version of fsfuzzer i triggered the BUG() in ext4_mb_release_inode_pa(). Sadly I am not able to reproduce this using the generated image, but running the fuzzer will usually trigger this in less than 40 attempts. Increasing the JBD2 Debug level didnt give more information. The kernel is current git with ext4-fix-null-pointer-deref-in-journal_wait_on_commit_record.patch applied. I am now able to reproduce this using this image: http://www.cccmz.de/~snakebyte/ext4.24.img.bz2 the following commands will trigger the oops for me mount cfs/ext4.24.img /media/test -t ext4dev -o extents -o loop mkdir /media/test/stress chown snakebyte:snakebyte /media/test/stress sudo -u snakebyte fstest -n 10 -l 10 -f 5 -s 4 -p /media/test/stress/ The file system is corrupted. The BUG_ON indicate that the free spcae marked in the prealloc space and found by looking at the bitmap are not same. Do you have a set of steps that i can follow to reproduce this ? on a clean file system ? Where do i find the fsfuzzer that you are using ? [EMAIL PROTECTED]:/tmp$/home/opensource/patches/e2fsprogs-1.40.4.cfs1/e2fsck/e2fsck.static -f ./ext4.24.img e2fsck 1.40.4.cfs1 (31-Dec-2007) Superblock has an invalid ext3 journal (inode 8). Cleary? yes *** ext3 journal has been deleted - filesystem is now ext2 only *** Pass 1: Checking inodes, blocks, and sizes Inode 7 has illegal block(s). Cleary? yes Illegal block #552 (9568256) in inode 7. CLEARED. Illegal block #647 (4063232) in inode 7. CLEARED. Illegal block #659 (12517376) in inode 7. CLEARED. Illegal block #766 (2600468480) in inode 7. CLEARED. Illegal block #944 (51200) in inode 7. CLEARED. Illegal block #1135 (2583691264) in inode 7. CLEARED. Illegal block #1214 (15925248) in inode 7. CLEARED. Illegal block #1345 (771751936) in inode 7. CLEARED. Illegal block #1384 (10092544) in inode 7. CLEARED. Illegal block #1416 (14811136) in inode 7. CLEARED. Illegal block #1470 (10420224) in inode 7. CLEARED. Illegal block #1709 (10158080) in inode 7. CLEARED. Too many illegal blocks in inode 7. Clear inodey? yes Journal inode is not in use, but contains data. Cleary? yes Deleted inode 160 has zero dtime. Fixy? yes Deleted inode 257 has zero dtime. Fixy? yes Deleted inode 638 has zero dtime. Fixy? yes Deleted inode 1407 has zero dtime. Fixy? yes Deleted inode 1650 has zero dtime. Fixy? yes Deleted inode 1656 has zero dtime. Fixy? yes Deleted inode 1677 has zero dtime. Fixy? yes Deleted inode 1720 has zero dtime. Fixy? yes Inode 11 has illegal block(s). Cleary? yes Illegal block #249 (15990784) in inode 11. CLEARED. Inode 11, i_size is 12288, should be 33792. Fixy? yes Inode 11, i_blocks is 24, should be 28. Fixy? yes Recreate journal to make the filesystem ext3 again? Fixy? yes -aneesh - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ext4: Fix Null dereference.
Repoted by Adrian Bunk [EMAIL PROTECTED]:
The Coverity checker spotted the following NULL dereference:
static int ext4_mb_mark_diskspace_used
{
...
if (!bitmap_bh)
goto out_err;
...
out_err:
sb-s_dirt = 1;
put_bh(bitmap_bh);
...
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/mballoc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 76e5fed..06d1f52 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3069,7 +3069,7 @@ static int ext4_mb_mark_diskspace_used(struct
ext4_allocation_context *ac,
out_err:
sb-s_dirt = 1;
- put_bh(bitmap_bh);
+ brelse(bitmap_bh);
return err;
}
--
1.5.4.rc3.24.gb53139-dirty
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
