Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 8
Hi Darren, On Thu, May 12, 2011 at 07:22:46AM +0930, Darren Thompson wrote: Florian Could you send me an actual file so I can use that as a template. There is no file you need with ocf-tester. Just do: # ocf-tester -n myrsc -o p1=v1 -o p2=v2 ... /.../lxc Replace pn with parameter names and vn with values for which the RA is supposed to be able to start the resource (in this case an lxc container). Thanks, Dejan I still do not have my head around what the actual requirements are. Darren On Wed, 2011-05-11 at 16:49 +0200, Florian Haas wrote: Darren, On 2011-05-05 15:07, Florian Haas wrote: On 2011-05-05 14:26, Darren Thompson wrote: Can you confirm that the current version is working for you and passes ocf-tester on your system? What is an ocf-tester??? http://www.linux-ha.org/doc/dev-guides/_testing_installing_and_packaging_resource_agents.html I have been testing this the hard way by actually creating and running the agents against actual LXC containers in a running cluster... If there is a simple way of streamlining this testing I'd love to hear more about it. (Did I mention that I'm not normally a coder/developer? - Yes I know that's getting repetitive ;-) ) But, back on topic... I can confirm that this agent is working correctly in a live fire environment. That's good to know. ocf-tester doesn't shoot blanks either (it operates on an actual incarnation of the resource), but it might run some tests that you manually do not, so it's always a wise idea to use it. Any news regarding running ocf-tester on your lxc agent? Cheers, Florian ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/ ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/ ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 8
Darren, On 2011-05-05 15:07, Florian Haas wrote: On 2011-05-05 14:26, Darren Thompson wrote: Can you confirm that the current version is working for you and passes ocf-tester on your system? What is an ocf-tester??? http://www.linux-ha.org/doc/dev-guides/_testing_installing_and_packaging_resource_agents.html I have been testing this the hard way by actually creating and running the agents against actual LXC containers in a running cluster... If there is a simple way of streamlining this testing I'd love to hear more about it. (Did I mention that I'm not normally a coder/developer? - Yes I know that's getting repetitive ;-) ) But, back on topic... I can confirm that this agent is working correctly in a live fire environment. That's good to know. ocf-tester doesn't shoot blanks either (it operates on an actual incarnation of the resource), but it might run some tests that you manually do not, so it's always a wise idea to use it. Any news regarding running ocf-tester on your lxc agent? Cheers, Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 8
Florian Could you send me an actual file so I can use that as a template. I still do not have my head around what the actual requirements are. Darren On Wed, 2011-05-11 at 16:49 +0200, Florian Haas wrote: Darren, On 2011-05-05 15:07, Florian Haas wrote: On 2011-05-05 14:26, Darren Thompson wrote: Can you confirm that the current version is working for you and passes ocf-tester on your system? What is an ocf-tester??? http://www.linux-ha.org/doc/dev-guides/_testing_installing_and_packaging_resource_agents.html I have been testing this the hard way by actually creating and running the agents against actual LXC containers in a running cluster... If there is a simple way of streamlining this testing I'd love to hear more about it. (Did I mention that I'm not normally a coder/developer? - Yes I know that's getting repetitive ;-) ) But, back on topic... I can confirm that this agent is working correctly in a live fire environment. That's good to know. ocf-tester doesn't shoot blanks either (it operates on an actual incarnation of the resource), but it might run some tests that you manually do not, so it's always a wise idea to use it. Any news regarding running ocf-tester on your lxc agent? Cheers, Florian ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/ ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 6
Darren,
can you please subscribe to the list as a normal subscriber rather than
to just the digest, so we can keep this discussion in one thread?
On 2011-05-05 04:47, Darren Thompson wrote:
Florian/Team
There was an error in the GIT-Hub version that was causing my re-base
attempts to fail, so I was forced to try to bring my last known good
version to the same configuration (mostly successful).
I have since found the error in the GIT-Hub version (the initialisation
section was wrong, the meta-data error was a 'red herring') so have been
found and resolved so I have done an actual re-base now based on the
GIT-Hub version.
Changes:
1. Corrected error in utilisation causing ocf to fail in HB_GUI.
That is not an error; the Github version is correct. The path to the
ocf-shellfuncs library was recently changed upstream; your installed
version is apparently still using the old path. For the Github version
to work on your system, you will have to apply the attached patch after
you check out.
Note that normally people would be building the whole resource-agents
package from a git checkout and use _that_ on their test system, but
you're not using git, so that option is out for you. Have I mentioned
that starting to use git would be a good option?
2. Added information to stop section, to provide more feedback on
container shutdown/stop (and to assist with future development of
containers using alternate 'init' systems).
Applied and pushed to my lxc branch.
Can you confirm that the current version is working for you and passes
ocf-tester on your system?
Cheers,
Florian
diff --git a/heartbeat/lxc b/heartbeat/lxc
index 3b0df91..07e0026 100755
--- a/heartbeat/lxc
+++ b/heartbeat/lxc
@@ -34,8 +34,8 @@
# OCF_RESKEY_config
# Initialization:
-: ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
-. ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
+: ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/resource.d/heartbeat}
+. ${OCF_FUNCTIONS_DIR}/.ocf-shellfuncs
# Set default TRANS_RES_STATE (temporary file to flag if resource was stated but not stopped)
TRANS_RES_STATE=${HA_RSCTMP}/${OCF_RESOURCE_INSTANCE}.state
signature.asc
Description: OpenPGP digital signature
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 8
Florian/Team Comments in-line... On Thu, 2011-05-05 at 05:47 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Darren, can you please subscribe to the list as a normal subscriber rather than to just the digest, so we can keep this discussion in one thread? Ok, done... The digest mode was a good idea at the time... On 2011-05-05 04:47, Darren Thompson wrote: Florian/Team There was an error in the GIT-Hub version that was causing my re-base attempts to fail, so I was forced to try to bring my last known good version to the same configuration (mostly successful). I have since found the error in the GIT-Hub version (the initialisation section was wrong, the meta-data error was a 'red herring') so have been found and resolved so I have done an actual re-base now based on the GIT-Hub version. Changes: 1. Corrected error in utilisation causing ocf to fail in HB_GUI. That is not an error; the Github version is correct. The path to the ocf-shellfuncs library was recently changed upstream; your installed version is apparently still using the old path. For the Github version to work on your system, you will have to apply the attached patch after you check out. If I had any idea how to use GIT and apply patches, this whole conversation would never be happening ;-) Did I mention that I'm not normally a coder/developer? Note that normally people would be building the whole resource-agents package from a git checkout and use _that_ on their test system, but you're not using git, so that option is out for you. Have I mentioned that starting to use git would be a good option? Did I ever claim to be normal... Mind you, if I told my partner... normally people would be building the whole resource-agents package from a git checkout and use _that_ on their test system... she would laugh her head off... I suppose it depends on your definition of normality... ;-) Using git would probably be a good option, but my requirement is for this to work under SLES11SP1 with the HA option pack, none of which is consistent with building the whole resource-agent package, although I do intend to raise a SR with Attachmate/Novell/SuSE for them to come in-line with these standards; as to support their environment on clients sites would be a PITA if they vary too much from the agreed standards. 2. Added information to stop section, to provide more feedback on container shutdown/stop (and to assist with future development of containers using alternate 'init' systems). Applied and pushed to my lxc branch. Thank you. Yes I can see that in the on-line version. Can you confirm that the current version is working for you and passes ocf-tester on your system? What is an ocf-tester??? I have been testing this the hard way by actually creating and running the agents against actual LXC containers in a running cluster... If there is a simple way of streamlining this testing I'd love to hear more about it. (Did I mention that I'm not normally a coder/developer? - Yes I know that's getting repetitive ;-) ) But, back on topic... I can confirm that this agent is working correctly in a live fire environment. Darren attachment: face-wink.png___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 8
On 2011-05-05 14:26, Darren Thompson wrote: Can you confirm that the current version is working for you and passes ocf-tester on your system? What is an ocf-tester??? http://www.linux-ha.org/doc/dev-guides/_testing_installing_and_packaging_resource_agents.html I have been testing this the hard way by actually creating and running the agents against actual LXC containers in a running cluster... If there is a simple way of streamlining this testing I'd love to hear more about it. (Did I mention that I'm not normally a coder/developer? - Yes I know that's getting repetitive ;-) ) But, back on topic... I can confirm that this agent is working correctly in a live fire environment. That's good to know. ocf-tester doesn't shoot blanks either (it operates on an actual incarnation of the resource), but it might run some tests that you manually do not, so it's always a wise idea to use it. Cheers, Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 2
Florian I have tried to re-base on your version but it just will not run for me. I keep getting Failed to parse the metadata of LXC syntax error line 1, column 1 I've no idea where this error is as it all looks fine... I'll attach my copy and a screen-shot of the error, HELP!!! Darren On Tue, 2011-05-03 at 07:59 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Date: Tue, 03 May 2011 08:20:56 +0200 From: Florian Haas florian.h...@linbit.com Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32 To: High-Availability Linux Development List linux-ha-dev@lists.linux-ha.org Message-ID: 4dbf9ec8.4060...@linbit.com Content-Type: text/plain; charset=utf-8 Hello Darren, Please get the current version from https://github.com/fghaas/resource-agents/blob/lxc/heartbeat/lxc, and also review the commit history at https://github.com/fghaas/resource-agents/commits/lxc/heartbeat/lxc. When you send more updates, please do make sure they track the latest version in my repo. I am doing my best splitting this up into patches as I can and check them in individually, but the re-introduction of errors that have already been fixed is not something that gives me thrills. Thanks. Cheers, Florian attachment: Screenshot-Message.png lxc Description: application/shellscript ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 2
On 05/04/2011 08:44 AM, Darren Thompson wrote: Florian I have tried to re-base on your version but it just will not run for me. I keep getting Failed to parse the metadata of LXC syntax error line 1, column 1 I've no idea where this error is as it all looks fine... I'll attach my copy and a screen-shot of the error, HELP!!! It's probably not a wise approach to test with the GUI while you're not even sure the resource agent will run. You will have to start the script from the command line and see where your error is coming from. Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 2
On 05/04/2011 09:09 AM, Florian Haas wrote:
On 05/04/2011 08:44 AM, Darren Thompson wrote:
Florian
I have tried to re-base on your version but it just will not run for me.
I keep getting Failed to parse the metadata of LXC syntax error line
1, column 1
I've no idea where this error is as it all looks fine...
I'll attach my copy and a screen-shot of the error, HELP!!!
It's probably not a wise approach to test with the GUI while you're
not even sure the resource agent will run. You will have to start the
script from the command line and see where your error is coming from.
Btw, your patch contains this:
diff --git a/heartbeat/lxc b/heartbeat/lxc
index 25ef6e3..9819a47 100755
--- a/heartbeat/lxc
+++ b/heartbeat/lxc
@@ -123,7 +123,6 @@ LXC_start() {
if ! LXC_monitor ; then
touch $TRANS_RES_STATE
ocf_log info Starting ${OCF_RESKEY_container}
- cd `dirname ${OCF_RESKEY_config`
ocf_run ${STARTCMD} || exit $OCF_ERR_GENERIC
else
# If already running, consider start
successful
Sorry, that was a typo on my part, should have been cd `dirname
${OCF_RESKEY_config}` (with closing brace) of course. Should I correct
the typo, or can we drop that line altogether?
Cheers,
Florian
signature.asc
Description: OpenPGP digital signature
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 3
On 05/04/2011 10:52 AM, Darren Thompson wrote: Florian/Team I have now updated my re-based ocf file to include the experimental support for upstart and systemd using containers. I can confirm that this is still working correctly for containers running 'sysv init' and in theory should now also work for containers using 'upstart' and 'systemd'. I'm currently doing a crash course' in installing containers to use these 'init replacments' but have not yet succedded in testing either 'upstart' or 'systemd' containers yet. If there is anyone with a better understanding of LXC containers and one/both of these other 'init systems', please contact me as your information/assistance would be invaluable. OK, updated my git branch. You really want to double check your rebasing method; you're constantly re-introducing things that I've removed or fixed in earlier commits. Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 6
Florian/Team There was an error in the GIT-Hub version that was causing my re-base attempts to fail, so I was forced to try to bring my last known good version to the same configuration (mostly successful). I have since found the error in the GIT-Hub version (the initialisation section was wrong, the meta-data error was a 'red herring') so have been found and resolved so I have done an actual re-base now based on the GIT-Hub version. Changes: 1. Corrected error in utilisation causing ocf to fail in HB_GUI. 2. Added information to stop section, to provide more feedback on container shutdown/stop (and to assist with future development of containers using alternate 'init' systems). Regards Darren On Wed, 2011-05-04 at 12:00 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Florian/Team I have now updated my re-based ocf file to include the experimental support for upstart and systemd using containers. I can confirm that this is still working correctly for containers running 'sysv init' and in theory should now also work for containers using 'upstart' and 'systemd'. I'm currently doing a crash course' in installing containers to use these 'init replacments' but have not yet succedded in testing either 'upstart' or 'systemd' containers yet. If there is anyone with a better understanding of LXC containers and one/both of these other 'init systems', please contact me as your information/assistance would be invaluable. OK, updated my git branch. You really want to double check your rebasing method; you're constantly re-introducing things that I've removed or fixed in earlier commits. Florian lxc Description: application/shellscript ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32
Hello Darren, Please get the current version from https://github.com/fghaas/resource-agents/blob/lxc/heartbeat/lxc, and also review the commit history at https://github.com/fghaas/resource-agents/commits/lxc/heartbeat/lxc. When you send more updates, please do make sure they track the latest version in my repo. I am doing my best splitting this up into patches as I can and check them in individually, but the re-introduction of errors that have already been fixed is not something that gives me thrills. Thanks. Cheers, Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 33
Florian/Team Another update to the lxc (Linux container) ocf file. (attached) Changes (summary): Added very very very experimental support for alternate init systems inside containers (it should now support sysvinit, upstart and systemd). Adding this support did not break the default sysvinit, but since I do not know how to create a LXC container that uses 'upstart' or 'systemd' my testing is very rudimentary for those two systems. I have made no progress whatsoever with removing the requirement for screen as I still have not found a working alternative to provide the root console created by lxc-start (it takes over the default console it's run on and that is lost when run as a cluster service, if screen is not used.) At this point I may have to confess that getting this working without using screen may be beyond my abilities (for now, I'm stubborn so will keep plugging away at this, but don't hold your breath). I'm still not sure why the use of screen is so repellent to some, as it works well and is quite innocuous generally. Regards Darren On Sat, 2011-04-30 at 12:00 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Date: Sat, 30 Apr 2011 16:10:52 +0930 From: Darren Thompson darr...@akurit.com.au Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32 To: linux-ha-dev@lists.linux-ha.org Message-ID: 1304145652.5625.50.ca...@darrenspc.akurit.com.au Content-Type: text/plain; charset=utf-8 Florin/TEAM Please find the latest instalment of the LXC containers ocf. Changes (summary): Moved cgroup_mounted out of default initialisation and made it a function (used by start/stop). Also cleaned up some other code sections, including expanding on verify_all section to more fully test configuration. Also merged validate and status sections. My next work will be determining the best way to make the containers init type independent (due to the rise of init replacements like systemd and upstart) and also investigating the removal of the screen tool from the startup as it's received negative feed back from a few sources Darren lxc Description: application/shellscript ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 1
Hi, On Tue, May 03, 2011 at 11:07:45PM +0930, Darren Thompson wrote: Lars/Team I agree. I can understand that there are some parameters that are MANDATORY and UNPREDICTABLE, but there are just as likely to be parameters that are MANDATORY and have a REASONABLE DEFAULT VALUE. As an example, the IP address is Mandatory and Unpredictable, but the path too and name of a configuration file (although still Mandatory) could have a Reasonable Default Value (although there may still be merit in allowing it to be overridden to provide localisations etc). I think it's too extreme to force all mandatory value to not be given default values, as (for example this particular case), there are a few mandatory values that do have reasonable defaults that could be used, in most cases. If the parameter is required (mandatory) under which circumstances can the default be used? If you want to let the user _not_ specify a parameter and use the default, then the parameter is optional. I really don't understand why all the confusion. Thanks, Dejan Darren On Mon, 2011-05-02 at 12:00 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Date: Sun, 1 May 2011 20:49:41 +0200 From: Lars Marowsky-Bree l...@novell.com Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) To: High-Availability Linux Development List linux-ha-dev@lists.linux-ha.org Message-ID: 20110501184941.gr17...@suse.de Content-Type: text/plain; charset=iso-8859-1 On 2011-04-26T16:03:48, Dejan Muhamedagic de...@suse.de wrote: - the required attributes in meta-data need to be reviewed, a parameter is either required or has a default, cannot be both Why would this be the case? Regards, Lars ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/ ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 90, Issue 2
Florian/Team Sorry I did not read this sooner, my last update will still have be messy for you (sorry). I'll grab a copy of the current version and re-base my work on that. I see that you have streamlined it quite a bit, I'll test it in my environment to ensure it's working as expected (I note that the parameters have changed names and some functionality so will re-create my cluster/lxc/containers using this and re-test). Darren On Tue, 2011-05-03 at 07:59 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Hello Darren, Please get the current version from https://github.com/fghaas/resource-agents/blob/lxc/heartbeat/lxc, and also review the commit history at https://github.com/fghaas/resource-agents/commits/lxc/heartbeat/lxc. When you send more updates, please do make sure they track the latest version in my repo. I am doing my best splitting this up into patches as I can and check them in individually, but the re-introduction of errors that have already been fixed is not something that gives me thrills. Thanks. Cheers, Florian ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
On 2011-04-26T16:03:48, Dejan Muhamedagic de...@suse.de wrote: - the required attributes in meta-data need to be reviewed, a parameter is either required or has a default, cannot be both Why would this be the case? Regards, Lars -- Architect Storage/HA, OPS Engineering, Novell, Inc. SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Experience is the name everyone gives to their mistakes. -- Oscar Wilde ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
On 5/2/2011 at 04:49 AM, Lars Marowsky-Bree l...@novell.com wrote: On 2011-04-26T16:03:48, Dejan Muhamedagic de...@suse.de wrote: - the required attributes in meta-data need to be reviewed, a parameter is either required or has a default, cannot be both Why would this be the case? There was some discussion about this last March: http://www.gossamer-threads.com/lists/linuxha/pacemaker/62163#62163 In summary (from lge): If a mandatory parameter has a default, then I'd think it is no longer mandatory, because, if not specified, it has its default to fall back to. [...] Mandatory paramters in my opinion should be such paramters that cannot possibly have a sane default, like the IP for IPaddr2. Regards, Tim -- Tim Serong tser...@novell.com Senior Clustering Engineer, OPS Engineering, Novell Inc. ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 32
Florin/TEAM Please find the latest instalment of the LXC containers ocf. Changes (summary): Moved cgroup_mounted out of default initialisation and made it a function (used by start/stop). Also cleaned up some other code sections, including expanding on verify_all section to more fully test configuration. Also merged validate and status sections. My next work will be determining the best way to make the containers init type independent (due to the rise of init replacements like systemd and upstart) and also investigating the removal of the screen tool from the startup as it's received negative feed back from a few sources Darren On Fri, 2011-04-29 at 12:00 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Date: Fri, 29 Apr 2011 09:57:04 +0200 From: Florian Haas florian.h...@linbit.com Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 30 To: High-Availability Linux Development List linux-ha-dev@lists.linux-ha.org Message-ID: 4dba6f50.7090...@linbit.com Content-Type: text/plain; charset=utf-8 On 2011-04-29 08:04, Darren Thompson wrote: You posted my first attempt and not the latest version, is it possible to add that one as it addresses some( most hopefully) of the issues you identified. Already there. Been there since yesterday. https://github.com/fghaas/resource-agents/commit/07827c42494dbec2c011133d9f82e831bc8b2eb6 There are still some valid points you have raised however, So I'm going to try to incorporate them into a third version. See how much easier this would be if you actually did this in your own github repo that we could just pull from? Cheers, Florian lxc Description: application/shellscript ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) - Linux-HA-Dev Digest, Vol 89, Issue 30
Florian/TEAM Thank you for the update. I'll thread my remaining replies into the message :-) On Thu, 2011-04-28 at 07:46 -0600, linux-ha-dev-requ...@lists.linux-ha.org wrote: Date: Thu, 28 Apr 2011 11:56:30 +0200 From: Florian Haas florian.h...@linbit.com Subject: Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers) To: High-Availability Linux Development List linux-ha-dev@lists.linux-ha.org Message-ID: 4db939ce.5000...@linbit.com Content-Type: text/plain; charset=utf-8 On 2011-04-28 10:21, Darren Thompson wrote: Florina/TEAM Thanks for your input and the link to the guidelines I have updated my original ocf file in line with the guidlines, it even gave me a few tips on how to do things better so was well worth the time spent. Please find the updated ocf file for LXC contianers as a cluster resource attached. Since I'm not an actual developer (or even a career coder) Do you think I am? Until Today, i have had no experience whatsoever with github, so compared to me... yes... I do not have the facility to host my own github fork so would appreciate someone adopting this and integrating it into their git repository. OK, I have added this to a separate lxc branch in my own github fork. I'd appreciate if you could at least get yourself an account on github so you can comment on commit line notes. I have added my comments to this page: https://github.com/fghaas/resource-agents/commit/73f80b31f1cee5eff1c2fe2b968f4ea593e8f405 Yep, done.. I responded to nearly all of the you points (most of the time to say, yep... agree). You posted my first attempt and not the latest version, is it possible to add that one as it addresses some( most hopefully) of the issues you identified. There are still some valid points you have raised however, So I'm going to try to incorporate them into a third version. Is there some clever way of re-integrating all of this? (did I mention that I'm not normally a coder). Some of those may have already been addresses in your updated version, but to keep things simple I've kept my comments to one commit for the time being. Florian PS: We can stop CC'ing the openais list, this is in no way Corosync/OpenAIS related. Agreed, I will stop pestering that list now :-) Darren attachment: face-smile.png___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
Florina/TEAM Thanks for your input and the link to the guidelines I have updated my original ocf file in line with the guidlines, it even gave me a few tips on how to do things better so was well worth the time spent. Please find the updated ocf file for LXC contianers as a cluster resource attached. Since I'm not an actual developer (or even a career coder) I do not have the facility to host my own github fork so would appreciate someone adopting this and integrating it into their git repository. I have since added myself the the developer mailing list so I should be able to contribute to the refining of this. Regards Darren On Tue, 2011-04-26 at 15:36 +0200, Florian Haas wrote: Thanks Darren! Thanks for the contribution! Can I suggest - we move this discussion to the linux-ha-dev list (where most OCF RA related discussions and reviews take place); - you give the RA a makeover following the OCF RA developer's guide (http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html); - you set up your own github fork off of https://github.com/ClusterLabs/resource-agents, and push your RA to that so we can eventually pull it into the mainline repo? Also, can you explain what the advantages of your approach are, versus using libvirt-managed lxc containers which Pacemaker can tie into via the existing VirtualDomain agent? Thanks! Cheers, Florian lxc Description: application/shellscript ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
On 2011-04-28 10:21, Darren Thompson wrote: Florina/TEAM Thanks for your input and the link to the guidelines I have updated my original ocf file in line with the guidlines, it even gave me a few tips on how to do things better so was well worth the time spent. Please find the updated ocf file for LXC contianers as a cluster resource attached. Since I'm not an actual developer (or even a career coder) Do you think I am? I do not have the facility to host my own github fork so would appreciate someone adopting this and integrating it into their git repository. OK, I have added this to a separate lxc branch in my own github fork. I'd appreciate if you could at least get yourself an account on github so you can comment on commit line notes. I have added my comments to this page: https://github.com/fghaas/resource-agents/commit/73f80b31f1cee5eff1c2fe2b968f4ea593e8f405 Some of those may have already been addresses in your updated version, but to keep things simple I've kept my comments to one commit for the time being. Florian PS: We can stop CC'ing the openais list, this is in no way Corosync/OpenAIS related. signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
On 2011-04-27 00:29, Darren Thompson wrote: Florian All good points. Unfortunately I'm not a programmer, so have no idea how to setup a 'git repo' and currently have no facility to host it even if I knew how. That's the point of github; they provide all that infrastructure for you. It all boils down to - go to https://github.com and set up an account - go to https://github.com/ClusterLabs/resource-agents and click Fork - open a command line and do git clone of the URL that the web page then shows (likely g...@github.com:yourusername/resource-agents.git) - add your resource agent into the heartbeat/ directory - do git add heartbeat/lxc - do git commit with a meaningful commit message - do git push to push the changes to your github repo. I will review the developers guide and as much as possible bring the OCF in-line with those recommendations Yes, please do. Why I did not use libvirt-manager LXC containers: 1. Frankly I could not get the libvirt integration to work and wasted weeks worth of testing trying, if someone more experienced would like to get that working, more power to them. 2. The libvirt works and acts like a competing fork and does not use any of the normal lxc tools, I'm not sold that it's the best approach. OK, fair enough. If we get your resource agent into mergeable shape then the fact that may duplicate some VirtualDomain functionality is not a show stopper. One other question: have you considered submitting this resource agent to the lxc folks? Cheers, Florian signature.asc Description: OpenPGP digital signature ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
Re: [Linux-ha-dev] [Openais] An OCF agent for LXC (Linux Containers)
On Tue, Apr 26, 2011 at 03:36:35PM +0200, Florian Haas wrote: Thanks Darren! Thanks for the contribution! Can I suggest - we move this discussion to the linux-ha-dev list (where most OCF RA related discussions and reviews take place); - you give the RA a makeover following the OCF RA developer's guide (http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html); - you set up your own github fork off of https://github.com/ClusterLabs/resource-agents, and push your RA to that so we can eventually pull it into the mainline repo? Also, can you explain what the advantages of your approach are, versus using libvirt-managed lxc containers which Pacemaker can tie into via the existing VirtualDomain agent? Yes, this is the first thing I thought about too. A few remarks: - the required attributes in meta-data need to be reviewed, a parameter is either required or has a default, cannot be both - why use screen(1) in start? BTW, since lxc seems to be easy to setup, it would be great to supply an ocft test file along with the RA. It's quite straightforward, just make a copy of one of the existing test files from tools/ocft. Cheers, Dejan Thanks! Cheers, Florian ___ Openais mailing list open...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais ___ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
