Re: [PATCH] ia64: cleanup header comments in mca related files

2008-01-06 Thread Hidetoshi Seto 
Happy late new year!

>> One possible worry is this bit: 
>>   * Copyright (C) 2003 Hewlett-Packard Co
>> - *  David Mosberger-Tang <[EMAIL PROTECTED]>
>> + * Copyright (C) David Mosberger-Tang <[EMAIL PROTECTED]>
>>
>> While this is in the same style as all the following entries, David
>> didn't explicitly claim copyright for himself with the old text, just
>> for Hewlett-Packard with a following note that he made the change.
>> You added the "Copyright (C)" against his name, and that doesn't
>> look like a good thing to do.
> 
> I agree; I don't think we should change copyright entries.

I see. The following is the 2nd version that keeps David's entry as is.

Thanks,
H.Seto
-

Unified changelog, 80 columns rule, and address form fix.

Signed-off-by: Hidetoshi Seto <[EMAIL PROTECTED]>

---
 arch/ia64/kernel/mca.c |   68 ++---
 arch/ia64/kernel/mca_asm.S |   46 +++
 arch/ia64/kernel/mca_drv.c |2 -
 arch/ia64/kernel/mca_drv.h |2 -
 arch/ia64/kernel/mca_drv_asm.S |2 -
 include/asm-ia64/mca.h |6 +--
 include/asm-ia64/mca_asm.h |3 +
 7 files changed, 71 insertions(+), 58 deletions(-)

Index: GIT-torvalds/arch/ia64/kernel/mca.c
===
--- GIT-torvalds.orig/arch/ia64/kernel/mca.c
+++ GIT-torvalds/arch/ia64/kernel/mca.c
@@ -2,61 +2,69 @@
  * File:   mca.c
  * Purpose:Generic MCA handling layer
  *
- * Updated for latest kernel
  * Copyright (C) 2003 Hewlett-Packard Co
  * David Mosberger-Tang <[EMAIL PROTECTED]>
  *
  * Copyright (C) 2002 Dell Inc.
- * Copyright (C) Matt Domsch ([EMAIL PROTECTED])
+ * Copyright (C) Matt Domsch <[EMAIL PROTECTED]>
  *
  * Copyright (C) 2002 Intel
- * Copyright (C) Jenna Hall ([EMAIL PROTECTED])
+ * Copyright (C) Jenna Hall <[EMAIL PROTECTED]>
  *
  * Copyright (C) 2001 Intel
- * Copyright (C) Fred Lewis ([EMAIL PROTECTED])
+ * Copyright (C) Fred Lewis <[EMAIL PROTECTED]>
  *
  * Copyright (C) 2000 Intel
- * Copyright (C) Chuck Fleckenstein ([EMAIL PROTECTED])
+ * Copyright (C) Chuck Fleckenstein <[EMAIL PROTECTED]>
  *
  * Copyright (C) 1999, 2004 Silicon Graphics, Inc.
- * Copyright (C) Vijay Chander([EMAIL PROTECTED])
+ * Copyright (C) Vijay Chander <[EMAIL PROTECTED]>
  *
- * 03/04/15 D. Mosberger Added INIT backtrace support.
- * 02/03/25 M. Domsch  GUID cleanups
+ * Copyright (C) 2006 FUJITSU LIMITED
+ * Copyright (C) Hidetoshi Seto <[EMAIL PROTECTED]>
  *
- * 02/01/04 J. HallAligned MCA stack to 16 bytes, added platform vs. CPU
- * error flag, set SAL default return values, changed
- * error record structure to linked list, added init call
- * to sal_get_state_info_size().
- *
- * 01/01/03 F. LewisAdded setup of CMCI and CPEI IRQs, logging of corrected
- *  platform errors, completed code for logging of
- *  corrected & uncorrected machine check errors, and
- *  updated for conformance with Nov. 2000 revision of the
- *  SAL 3.0 spec.
- * 00/03/29 C. Fleckenstein  Fixed PAL/SAL update issues, began MCA bug fixes, 
logging issues,
- *   added min save state dump, added INIT handler.
+ * 2000-03-29 Chuck Fleckenstein <[EMAIL PROTECTED]>
+ *   Fixed PAL/SAL update issues, began MCA bug fixes, logging issues,
+ *   added min save state dump, added INIT handler.
+ *
+ * 2001-01-03 Fred Lewis <[EMAIL PROTECTED]>
+ *   Added setup of CMCI and CPEI IRQs, logging of corrected platform
+ *   errors, completed code for logging of corrected & uncorrected
+ *   machine check errors, and updated for conformance with Nov. 2000
+ *   revision of the SAL 3.0 spec.
+ *
+ * 2002-01-04 Jenna Hall <[EMAIL PROTECTED]>
+ *   Aligned MCA stack to 16 bytes, added platform vs. CPU error flag,
+ *   set SAL default return values, changed error record structure to
+ *   linked list, added init call to sal_get_state_info_size().
+ *
+ * 2002-03-25 Matt Domsch <[EMAIL PROTECTED]>
+ *   GUID cleanups.
+ *
+ * 2003-04-15 David Mosberger-Tang <[EMAIL PROTECTED]>
+ *   Added INIT backtrace support.
  *
  * 2003-12-08 Keith Owens <[EMAIL PROTECTED]>
- *smp_call_function() must not be called from interrupt context 
(can
- *deadlock on tasklist_lock).  Use keventd to call 
smp_call_function().
+ *   smp_call_function() must not be called from interrupt context
+ *   (can deadlock on tasklist_lock).
+ *   Use keventd to call smp_call_function().
  *
  * 2004-02-01 Keith Owens <[EMAIL PROTECTED]>
- *Avoid deadlock when using printk() for MCA and INIT records.
- *Delete all record printing code, moved to salinfo_decode in user 
space.
- *Mark variables and functions static where possible.
-

Re: [PATCH] ia64: cleanup header comments in mca related files

2008-01-04 Thread Bjorn Helgaas 
On Thursday 03 January 2008 02:48:42 pm Luck, Tony wrote:
> This looks like a nice cleanup in general (though I'm not really sure
> how much we benefit by having e-mail addresses inside <...> style
> brackets rather than parentheses :-).

I actually like that change, because then I can easily copy & paste
it into a mail composer.  I wish MAINTAINERS used that same style.

> One possible worry is this bit: 
>   * Copyright (C) 2003 Hewlett-Packard Co
> - *   David Mosberger-Tang <[EMAIL PROTECTED]>
> + * Copyright (C) David Mosberger-Tang <[EMAIL PROTECTED]>
> 
> While this is in the same style as all the following entries, David
> didn't explicitly claim copyright for himself with the old text, just
> for Hewlett-Packard with a following note that he made the change.
> You added the "Copyright (C)" against his name, and that doesn't
> look like a good thing to do.

I agree; I don't think we should change copyright entries.

Speaking for myself, as an employee of HP, I think my Linux work
is considered a "work made for hire," so HP is considered the
legal author for copyright purposes.  I include my name only for
"blame" purposes :-)

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ia64: cleanup header comments in mca related files

2008-01-03 Thread Luck, Tony 
This looks like a nice cleanup in general (though I'm not really sure
how much we benefit by having e-mail addresses inside <...> style
brackets rather than parentheses :-).

One possible worry is this bit: 
  * Copyright (C) 2003 Hewlett-Packard Co
- * David Mosberger-Tang <[EMAIL PROTECTED]>
+ * Copyright (C) David Mosberger-Tang <[EMAIL PROTECTED]>

While this is in the same style as all the following entries, David
didn't explicitly claim copyright for himself with the old text, just
for Hewlett-Packard with a following note that he made the change.
You added the "Copyright (C)" against his name, and that doesn't
look like a good thing to do.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html