RE: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, July 05, 2007 1:30 PM To: Thorsten Leemhuis Cc: Thorsten Leemhuis; Chuck Ebbert; Jeff Garzik; IDE/ATA development list; Gaston, Jason D; Alan Cox; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller On Wednesday, 4. July 2007, Thorsten Leemhuis wrote: Maybe Alan or someone from Intel can answer that and thus tell us how to move forward; it would be really nice to get the patch that started this thread (it got posted by Chuck again today) could go into 2.6.22, but I assume the time runs away... Jeff is on holiday and Intel doesn't respond at all... So, if someone has a ICH5 or ICH7/7-R with a ATA133 captable HDD... could you please try the following patch? (Of course, I don't know if it works,... It may cause data loss, serve corruption, or damage your controller/hdd/pc, so make backups and keep a first-aid kit handy!) On the other hand, we can leave it, because of a off-by-one error in ata_piix.c, do_pata_set_dmamode, line ~770: [...] Thanks, Chr. I quickly tried this patch on an ICH7-R system with an ATA133 Maxtor HD and it did not seem to do anything bad. I see no difference in function or performance with the patch. Jason - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
Maybe Alan or someone from Intel can answer that and thus tell us how to move forward; it would be really nice to get the patch that started this thread (it got posted by Chuck again today) could go into 2.6.22, but I assume the time runs away... Folks should be back Monday I suspect. Its the US indepenence day (or from UK perspective 'they day the terrorists won' 8) I don't have suitable systems to hand to test this and investigate further. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
On 02.07.2007 07:02, Thorsten Leemhuis wrote:
On 28.06.2007 21:47, Chuck Ebbert wrote:
On 06/28/2007 03:16 PM, Chuck Ebbert wrote:
[Forgot to mark subj: as a patch; attached]
From: Christian Lamparter [EMAIL PROTECTED]
ATA: add a PCI ID for Intel Santa Rosa PATA controller.
Signed-off-by: Christian Lamparter [EMAIL PROTECTED]
---
[...]
+ /* ICH8 Mobile PATA Controller */
+ { 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
FYI: Patch works fine for me on my brand new Dell D630 (Santa Rosa) --
the DVD-Drive gets recognized with it applied.
Hmmm. From looking at the ICH8-Datasheet (
http://www.intel.com/design/chipsets/datashts/313056.htm
or http://download.intel.com/design/chipsets/datashts/31305603.pdf )
page 189 and later it seems to me that the ICH8M (just as all the other
Intel-Chipsets I know) officially only supports Ultra ATA 100 (and not
133!).
So is the ich_pata_133 correct in the patch (see quoted line above)?
CU
thl
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
On Monday, 2. July 2007, you wrote: On 02.07.2007 07:02, Thorsten Leemhuis wrote: Hmmm. From looking at the ICH8-Datasheet ( http://www.intel.com/design/chipsets/datashts/313056.htm or http://download.intel.com/design/chipsets/datashts/31305603.pdf ) page 189 and later it seems to me that the ICH8M (just as all the other Intel-Chipsets I know) officially only supports Ultra ATA 100 (and not 133!). So is the ich_pata_133 correct in the patch (see quoted line above)? CU thl (please keep the CC). For some strange reason, I can not get the pdf... Anyway, the original patch had ich_pata_100. see: http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07416.html but Alan Cox wrote: http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07417.html Its ich_pata_133 - all the newer chips are. They work even better if you set them into AHCI mode in the BIOS and then they should just work with recent kernels as the AHCI driver now matches by class. Alan And Gaston, Jason D [EMAIL PROTECTED] didn't complain about it. it's a bit confusing with all native AHCI SATA chipset that have to emulate PATA for compatibility reasons... So, whom can we trust? I've seen wrong specs, but you know To err is human. Thanks, Chr. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
On 02.07.2007 13:24, Chr wrote: On Monday, 2. July 2007, you wrote: On 02.07.2007 07:02, Thorsten Leemhuis wrote: Hmmm. From looking at the ICH8-Datasheet ( http://www.intel.com/design/chipsets/datashts/313056.htm or http://download.intel.com/design/chipsets/datashts/31305603.pdf ) page 189 and later it seems to me that the ICH8M (just as all the other Intel-Chipsets I know) officially only supports Ultra ATA 100 (and not 133!). So is the ich_pata_133 correct in the patch (see quoted line above)? For some strange reason, I can not get the pdf... Anyway, the original patch had ich_pata_100. see: http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07416.html k, missed that post. but Alan Cox wrote: http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07417.html Its ich_pata_133 - all the newer chips are. Intel afaik never supported Ultra ATA 133 officially in any of the mainstream desktop or mobile chipsets. They work even better if you set them into AHCI mode in the BIOS and then they should just work with recent kernels as the AHCI driver now matches by class. And Gaston, Jason D [EMAIL PROTECTED] didn't complain about it. it's a bit confusing with all native AHCI SATA chipset that have to emulate PATA for compatibility reasons... Well, just FYI: on my Laptop AHCI is enabled and used for the SATA hard disk. But the DVD drive still is a pata one afaics (I'm not in front of the machine, so I can't check), connected via the pata controller -- so for me there is no emulation involved (at least afaics). So, whom can we trust? I'd trust the public datasheet in this case. CU thl - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
On Monday, 2. July 2007, Thorsten Leemhuis wrote:
but Alan Cox wrote:
http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07417.html
Its ich_pata_133 - all the newer chips are.
Intel afaik never supported Ultra ATA 133 officially in any of the
mainstream desktop or mobile chipsets.
You're probably right! But, what about Intel's ICH5 and ICH7/7-R (i945, i975)?
see ata_piix.c: line 193ff
{ 0x8086, 0x24DB, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
[...]
{ 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
On the other hand, we can leave it, because of a off-by-one error in
ata_piix.c,
do_pata_set_dmamode, line ~770:
(the comment is important!)
/*
* -- UDMA is handled by a combination of clock switching and
* selection of dividers ---
* [...]
*/
u_speed = min(2 - (udma 1), udma);
if (udma == 5)
u_clock = 0x1000; /* 100Mhz */ -- wrong! it's 133Mhz.
else if (udma 2)
u_clock = 1;/* 66Mhz */
else
u_clock = 0;/* 33Mhz */
=
for udma = 6(133MB/s) , we get u_speed=2 and u_clock=1
for udma = 4(66MB/s), we get the same values! (u_speed=2 and u_clock=1)
...
so, atleast for ata_piix, UDMA6 and UDMA4 *is* the same, right?
They work even better if you
set them into AHCI mode in the BIOS and then they should just work with
recent kernels as the AHCI driver now matches by class.
And Gaston, Jason D [EMAIL PROTECTED] didn't complain about it.
it's a bit confusing with all native AHCI SATA chipset that have to
emulate
PATA for compatibility reasons...
Well, just FYI: on my Laptop AHCI is enabled and used for the SATA hard
disk. But the DVD drive still is a pata one afaics (I'm not in front of
the machine, so I can't check), connected via the pata controller -- so
for me there is no emulation involved (at least afaics).
I know. I wanted to say something else... but it doesn't really matter
(not every operating system supports AHCI-only controllers by default...)
Thanks,
Chr.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
On 28.06.2007 21:47, Chuck Ebbert wrote:
On 06/28/2007 03:16 PM, Chuck Ebbert wrote:
[Forgot to mark subj: as a patch; attached]
From: Christian Lamparter [EMAIL PROTECTED]
ATA: add a PCI ID for Intel Santa Rosa PATA controller.
Signed-off-by: Christian Lamparter [EMAIL PROTECTED]
---
[...]
+ /* ICH8 Mobile PATA Controller */
+ { 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
FYI: Patch works fine for me on my brand new Dell D630 (Santa Rosa) --
the DVD-Drive gets recognized with it applied.
CU
thl
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
Chuck Ebbert wrote: On 06/28/2007 03:16 PM, Chuck Ebbert wrote: [Forgot to mark subj: as a patch; attached] Sorry, using attachments (a) decreases reviewers and (b) makes your patch HARDER to apply. See #7 under Documentation/SubmittingPatches. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
