Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-09-01 Thread Jeff Garzik 

Krzysztof Oledzki wrote:

On 2007-08-01 17:46, Alan Cox wrote:

On Wed, 01 Aug 2007 09:49:19 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:


Alan Cox wrote:
Underneath all the HPT packaging, PCI identifiers, binary driver 
modules

and stuff you find that ...

Signed-off-by: Alan Cox [EMAIL PROTECTED]

--- drivers/ata/sata_mv.c~2007-07-09 13:19:57.003052904 +0100
+++ drivers/ata/sata_mv.c2007-07-09 13:19:57.004052752 +0100
@@ -573,6 +573,9 @@
 { PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
 { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
 { PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
+/* RocketRAID 1740/174x have different identifiers */
+{ PCI_VDEVICE(TTI, 0x1740), chip_508x },
+{ PCI_VDEVICE(TTI, 0x1742), chip_508x },

Is this still a test patch, or can it go upstream?


Upstream


Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] 
pictures there may be a 6042 chipset (GEN IIe) placed onboard.


[1] http://www.highpoint-tech.com/image/products/SATAII/RR1740_card_big.jpg
http://www.highpoint-tech.com/image/products/eSATA/RR1742_card_big.jpg


Good evidence!

SATAII is also an indicator that it is not 508x.

Jeff



-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-09-01 Thread Krzysztof Oledzki 

On 2007-08-01 17:46, Alan Cox wrote:

On Wed, 01 Aug 2007 09:49:19 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:


Alan Cox wrote:

Underneath all the HPT packaging, PCI identifiers, binary driver modules
and stuff you find that ...

Signed-off-by: Alan Cox [EMAIL PROTECTED]

--- drivers/ata/sata_mv.c~  2007-07-09 13:19:57.003052904 +0100
+++ drivers/ata/sata_mv.c   2007-07-09 13:19:57.004052752 +0100
@@ -573,6 +573,9 @@
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
+   /* RocketRAID 1740/174x have different identifiers */
+   { PCI_VDEVICE(TTI, 0x1740), chip_508x },
+   { PCI_VDEVICE(TTI, 0x1742), chip_508x },

Is this still a test patch, or can it go upstream?


Upstream


Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] 
pictures there may be a 6042 chipset (GEN IIe) placed onboard.


[1] http://www.highpoint-tech.com/image/products/SATAII/RR1740_card_big.jpg
http://www.highpoint-tech.com/image/products/eSATA/RR1742_card_big.jpg

Best regards,

Krzysztof Olędzki
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-09-01 Thread Alan Cox 
On Sat, 01 Sep 2007 15:38:43 +0200
Krzysztof Oledzki [EMAIL PROTECTED] wrote:

 On 2007-08-01 17:46, Alan Cox wrote:
  On Wed, 01 Aug 2007 09:49:19 -0400
  Jeff Garzik [EMAIL PROTECTED] wrote:
  
  Alan Cox wrote:
  Underneath all the HPT packaging, PCI identifiers, binary driver modules
  and stuff you find that ...
 
  Signed-off-by: Alan Cox [EMAIL PROTECTED]
 
  --- drivers/ata/sata_mv.c~2007-07-09 13:19:57.003052904 +0100
  +++ drivers/ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100
  @@ -573,6 +573,9 @@
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
  + /* RocketRAID 1740/174x have different identifiers */
  + { PCI_VDEVICE(TTI, 0x1740), chip_508x },
  + { PCI_VDEVICE(TTI, 0x1742), chip_508x },
  Is this still a test patch, or can it go upstream?
  
  Upstream
 
 Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] 
 pictures there may be a 6042 chipset (GEN IIe) placed onboard.

The ones I checked and the code used as a reference clearly indicate a
508x. I've had two reports of a TTI 0x23xx ID number which may perhaps be
a 6042 as it didn't appear to work with a 508x driver.

Alan
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Jeff Garzik 

Alan Cox wrote:

Underneath all the HPT packaging, PCI identifiers, binary driver modules
and stuff you find that ...

Signed-off-by: Alan Cox [EMAIL PROTECTED]

--- drivers/ata/sata_mv.c~  2007-07-09 13:19:57.003052904 +0100
+++ drivers/ata/sata_mv.c   2007-07-09 13:19:57.004052752 +0100
@@ -573,6 +573,9 @@
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
+   /* RocketRAID 1740/174x have different identifiers */
+   { PCI_VDEVICE(TTI, 0x1740), chip_508x },
+   { PCI_VDEVICE(TTI, 0x1742), chip_508x },


Is this still a test patch, or can it go upstream?

Jeff



-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Alan Cox 
On Wed, 01 Aug 2007 09:49:19 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:

 Alan Cox wrote:
  Underneath all the HPT packaging, PCI identifiers, binary driver modules
  and stuff you find that ...
  
  Signed-off-by: Alan Cox [EMAIL PROTECTED]
  
  --- drivers/ata/sata_mv.c~  2007-07-09 13:19:57.003052904 +0100
  +++ drivers/ata/sata_mv.c   2007-07-09 13:19:57.004052752 +0100
  @@ -573,6 +573,9 @@
  { PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
  { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
  { PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
  +   /* RocketRAID 1740/174x have different identifiers */
  +   { PCI_VDEVICE(TTI, 0x1740), chip_508x },
  +   { PCI_VDEVICE(TTI, 0x1742), chip_508x },
 
 Is this still a test patch, or can it go upstream?

Upstream
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-07-13 Thread Alan Cox 
 Since we're guessing (I assume?), I definitely want to make sure we have 
 the correct MV variant for use with RocketRAID.

We are not guessing. There is sufficient information in the driver to
identify the specific chip variant
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-07-12 Thread Jeff Garzik 

Alan Cox wrote:

Underneath all the HPT packaging, PCI identifiers, binary driver modules
and stuff you find that ...

Signed-off-by: Alan Cox [EMAIL PROTECTED]

--- drivers/ata/sata_mv.c~  2007-07-09 13:19:57.003052904 +0100
+++ drivers/ata/sata_mv.c   2007-07-09 13:19:57.004052752 +0100
@@ -573,6 +573,9 @@
{ PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
{ PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
+   /* RocketRAID 1740/174x have different identifiers */
+   { PCI_VDEVICE(TTI, 0x1740), chip_508x },
+   { PCI_VDEVICE(TTI, 0x1742), chip_508x },


If your testers could re-test on top of what I just submitted to Linus, 
that would be most helpful.  My non-RocketRAID 5081 works just fine, but 
sata_mv received some major changes and bug fixes, which could 
potentially change behavior here.


Since we're guessing (I assume?), I definitely want to make sure we have 
the correct MV variant for use with RocketRAID.


Any idea if RocketRAID is marketed as SATA-II or with NCQ support? 
(queueing in marketing lit doesn't help, alas).


Jeff



-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html