Re: Linux 2.6.25-rc3

2008-02-24 Thread S.Çağlar Onur
Hi;

25 Şub 2008 Pts tarihinde, Linus Torvalds şunları yazmıştı: 
> 
> Ok, it's out there, ready for your enjoyment.
[...] 
> So give it a good testing, please,

-rc3 still fails for this [1] config

ERROR: "LGUEST_PAGES_guest_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_cr3" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_idt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_gdt" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_sp" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs_trapnum" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_idt_desc" [drivers/lguest/lg.ko] undefined!

and following patch by Kyle McMartin solves this issue, this patch posted on 20 
Feb to LKML but not CC'd to you.

From: Kyle McMartin <[EMAIL PROTECTED]>

lguest uses asm-offsets to generate ... offsets, obviously, for use
in the lguest switcher code. When the hypervisor code is built as a
module though, the asm offsets it needs won't be generated since
CONFIG_LGUEST will be undefined.

Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>

---
diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
index a33d530..44bafdd 100644
--- a/arch/x86/kernel/asm-offsets_32.c
+++ b/arch/x86/kernel/asm-offsets_32.c
@@ -134,7 +134,7 @@ void foo(void)
OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
 #endif
 
-#ifdef CONFIG_LGUEST
+#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
BLANK();
OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);


[1] http://cekirdek.pardus.org.tr/~caglar/config.2.6.25-rc3
Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.25-rc3

2008-02-24 Thread S.Çağlar Onur
Hi;

25 Şub 2008 Pts tarihinde, Linus Torvalds şunları yazmıştı: 
 
 Ok, it's out there, ready for your enjoyment.
[...] 
 So give it a good testing, please,

-rc3 still fails for this [1] config

ERROR: LGUEST_PAGES_guest_gdt_desc [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_host_gdt_desc [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_host_cr3 [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_regs [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_host_idt_desc [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_guest_gdt [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_host_sp [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_regs_trapnum [drivers/lguest/lg.ko] undefined!
ERROR: LGUEST_PAGES_guest_idt_desc [drivers/lguest/lg.ko] undefined!

and following patch by Kyle McMartin solves this issue, this patch posted on 20 
Feb to LKML but not CC'd to you.

From: Kyle McMartin [EMAIL PROTECTED]

lguest uses asm-offsets to generate ... offsets, obviously, for use
in the lguest switcher code. When the hypervisor code is built as a
module though, the asm offsets it needs won't be generated since
CONFIG_LGUEST will be undefined.

Signed-off-by: Kyle McMartin [EMAIL PROTECTED]

---
diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
index a33d530..44bafdd 100644
--- a/arch/x86/kernel/asm-offsets_32.c
+++ b/arch/x86/kernel/asm-offsets_32.c
@@ -134,7 +134,7 @@ void foo(void)
OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
 #endif
 
-#ifdef CONFIG_LGUEST
+#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
BLANK();
OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);


[1] http://cekirdek.pardus.org.tr/~caglar/config.2.6.25-rc3
Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 12/14] fs/binfmt_aout.c: Use time_* macros

2008-02-14 Thread S.Çağlar Onur
14 Şub 2008 Per tarihinde, Geert Uytterhoeven şunları yazmıştı: 
> To me these constructs look like good candidates for replacement by
> printk_ratelimit()?
> 
> Gr{oetje,eeting}s,

What about something like following?


Use printk_ratelimit() instead of jiffies based arithmetic, suggested by Geert 
Uytterhoeven

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 fs/binfmt_aout.c |   12 +++-
 1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
index a1bb224..ba4cddb 100644
--- a/fs/binfmt_aout.c
+++ b/fs/binfmt_aout.c
@@ -372,21 +372,17 @@ static int load_aout_binary(struct linux_binprm * bprm, 
struct pt_regs * regs)
 
flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data);
} else {
-   static unsigned long error_time, error_time2;
if ((ex.a_text & 0xfff || ex.a_data & 0xfff) &&
-   (N_MAGIC(ex) != NMAGIC) && (jiffies-error_time2) > 5*HZ)
+   (N_MAGIC(ex) != NMAGIC) && printk_ratelimit())
{
printk(KERN_NOTICE "executable not page aligned\n");
-   error_time2 = jiffies;
}
 
-   if ((fd_offset & ~PAGE_MASK) != 0 &&
-   (jiffies-error_time) > 5*HZ)
+   if ((fd_offset & ~PAGE_MASK) != 0 && printk_ratelimit())
{
printk(KERN_WARNING 
   "fd_offset is not page aligned. Please convert 
program: %s\n",
   bprm->file->f_path.dentry->d_name.name);
-   error_time = jiffies;
}
 
if (!bprm->file->f_op->mmap||((fd_offset & ~PAGE_MASK) != 0)) {
@@ -495,15 +491,13 @@ static int load_aout_library(struct file *file)
start_addr =  ex.a_entry & 0xf000;
 
if ((N_TXTOFF(ex) & ~PAGE_MASK) != 0) {
-   static unsigned long error_time;
loff_t pos = N_TXTOFF(ex);
 
-   if ((jiffies-error_time) > 5*HZ)
+   if (printk_ratelimit())
{
printk(KERN_WARNING 
   "N_TXTOFF is not page aligned. Please convert 
library: %s\n",
   file->f_path.dentry->d_name.name);
-   error_time = jiffies;
    }
down_write(>mm->mmap_sem);
do_brk(start_addr, ex.a_text + ex.a_data + ex.a_bss);

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 12/14] fs/binfmt_aout.c: Use time_* macros

2008-02-14 Thread S.Çağlar Onur
14 Şub 2008 Per tarihinde, Geert Uytterhoeven şunları yazmıştı: 
 To me these constructs look like good candidates for replacement by
 printk_ratelimit()?
 
 Gr{oetje,eeting}s,

What about something like following?


Use printk_ratelimit() instead of jiffies based arithmetic, suggested by Geert 
Uytterhoeven

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 fs/binfmt_aout.c |   12 +++-
 1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
index a1bb224..ba4cddb 100644
--- a/fs/binfmt_aout.c
+++ b/fs/binfmt_aout.c
@@ -372,21 +372,17 @@ static int load_aout_binary(struct linux_binprm * bprm, 
struct pt_regs * regs)
 
flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data);
} else {
-   static unsigned long error_time, error_time2;
if ((ex.a_text  0xfff || ex.a_data  0xfff) 
-   (N_MAGIC(ex) != NMAGIC)  (jiffies-error_time2)  5*HZ)
+   (N_MAGIC(ex) != NMAGIC)  printk_ratelimit())
{
printk(KERN_NOTICE executable not page aligned\n);
-   error_time2 = jiffies;
}
 
-   if ((fd_offset  ~PAGE_MASK) != 0 
-   (jiffies-error_time)  5*HZ)
+   if ((fd_offset  ~PAGE_MASK) != 0  printk_ratelimit())
{
printk(KERN_WARNING 
   fd_offset is not page aligned. Please convert 
program: %s\n,
   bprm-file-f_path.dentry-d_name.name);
-   error_time = jiffies;
}
 
if (!bprm-file-f_op-mmap||((fd_offset  ~PAGE_MASK) != 0)) {
@@ -495,15 +491,13 @@ static int load_aout_library(struct file *file)
start_addr =  ex.a_entry  0xf000;
 
if ((N_TXTOFF(ex)  ~PAGE_MASK) != 0) {
-   static unsigned long error_time;
loff_t pos = N_TXTOFF(ex);
 
-   if ((jiffies-error_time)  5*HZ)
+   if (printk_ratelimit())
{
printk(KERN_WARNING 
   N_TXTOFF is not page aligned. Please convert 
library: %s\n,
   file-f_path.dentry-d_name.name);
-   error_time = jiffies;
}
down_write(current-mm-mmap_sem);
do_brk(start_addr, ex.a_text + ex.a_data + ex.a_bss);

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


2.6.24.x-stable request for 69f817b654d683265118188bbfb8bc0d8978cce6 and ece8edddf067d21c4e5abfe3f1205da1588edbb2

2008-02-10 Thread S.Çağlar Onur
Hi;

On 2.6.24.1-stable kernel review cycle, i requested inclusions of commit 
69f817b654d683265118188bbfb8bc0d8978cce6 (mac80211: Restore rx.fc before every 
invocation of ieee80211_invoke_rx_handlers) and 
ece8edddf067d21c4e5abfe3f1205da1588edbb2 (mac80211: hardware scan rework) into 
-stable one (they solved disable_hw_scan=1 workaround for wpa_secured hidden AP 
problem). And -stable team said they would rather these comes from either the 
wireless maintainer or the network maintainer to verify that they are needed, 
and the backports works properly.

So, if possible, could you please consider sending these to -stable?

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread S.Çağlar Onur
Hi;

10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: 
> I think this is not correct. You change the err which caused the failure. You 
> change it even to 0 if it doesn't fail and the whole function will seem like 
> non-failing.

My bad, sorry for not looking carefully. Assuming a refactoring is not desired 
for just a compiler warning, is following acceptable (this kind of plain 
messages seems heavily used in vmt.c, so i'm again assuming its OK to use such 
style)?

commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) 
introduced the warning

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect


 drivers/mtd/ubi/vmt.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..46410f6 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,8 @@ out_sysfs:
get_device(>dev);
volume_sysfs_close(vol);
 out_gluebi:
-   ubi_destroy_gluebi(vol);
+   if(ubi_destroy_gluebi(vol))
+   ubi_err("cannot destroy device");
 out_cdev:
cdev_del(>cdev);
 out_mapping:


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread S.Çağlar Onur
Hi;

10 Şub 2008 Paz tarihinde, Linus Torvalds şunları yazmıştı: 
> 
> On Sun, 10 Feb 2008, S.Çağlar Onur wrote:
> > > >
> > > > -   while (dev = device_find_child(>dev, NULL, __match_tty)) {
> > > > +   while ((dev = device_find_child(>dev, NULL, __match_tty)) 
> > > > != NULL) {
> > > >   
> > > Why do you need '!= NULL'?
> > 
> > I thought its more readable than
> > 
> > while ((dev = device_find_child(>dev, NULL, __match_tty))) {
> 
> Yes indeed. I hate the idiotic "double parenthesis without any meaning". 
> I'd much rather see "((..) != NULL)" than "((..))", because the latter is 
> totally meaningless semantically (although gcc gives it semantics).

But you still not merged this one :), is there any problem exists or would you 
prefer this comes from with a subsystem tree (which means i'm doing wrong thing 
with sending these trivial patches to you)?

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread S.Çağlar Onur
Hi;

10 Şub 2008 Paz tarihinde, Richard Knutsson şunları yazmıştı: 
> S.Çağlar Onur wrote:
> > Hi;
> >
> > Following patch silents
> >
> > net/bluetooth/hci_sysfs.c: In function `del_conn':
> > net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around 
> > assignment used as truth value
> >
> > compiler warning introduced by commit 
> > acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of 
> > connection device to NULL before connection down.)
> >
> > Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
> >
> >  net/bluetooth/hci_sysfs.c |2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
> > index e13cf5e..d2d1e4f 100644
> > --- a/net/bluetooth/hci_sysfs.c
> > +++ b/net/bluetooth/hci_sysfs.c
> > @@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
> > struct device *dev;
> > struct hci_conn *conn = container_of(work, struct hci_conn, work);
> >  
> > -   while (dev = device_find_child(>dev, NULL, __match_tty)) {
> > +   while ((dev = device_find_child(>dev, NULL, __match_tty)) != 
> > NULL) {
> >   
> Why do you need '!= NULL'?

I thought its more readable than

while ((dev = device_find_child(>dev, NULL, __match_tty))) {

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread S.Çağlar Onur
Hi;

10 Şub 2008 Paz tarihinde, Linus Torvalds şunları yazmıştı: 
 
 On Sun, 10 Feb 2008, S.Çağlar Onur wrote:
   
-   while (dev = device_find_child(conn-dev, NULL, __match_tty)) {
+   while ((dev = device_find_child(conn-dev, NULL, __match_tty)) 
!= NULL) {
  
   Why do you need '!= NULL'?
  
  I thought its more readable than
  
  while ((dev = device_find_child(conn-dev, NULL, __match_tty))) {
 
 Yes indeed. I hate the idiotic double parenthesis without any meaning. 
 I'd much rather see ((..) != NULL) than ((..)), because the latter is 
 totally meaningless semantically (although gcc gives it semantics).

But you still not merged this one :), is there any problem exists or would you 
prefer this comes from with a subsystem tree (which means i'm doing wrong thing 
with sending these trivial patches to you)?

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread S.Çağlar Onur
Hi;

10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: 
 I think this is not correct. You change the err which caused the failure. You 
 change it even to 0 if it doesn't fail and the whole function will seem like 
 non-failing.

My bad, sorry for not looking carefully. Assuming a refactoring is not desired 
for just a compiler warning, is following acceptable (this kind of plain 
messages seems heavily used in vmt.c, so i'm again assuming its OK to use such 
style)?

commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) 
introduced the warning

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect


 drivers/mtd/ubi/vmt.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..46410f6 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,8 @@ out_sysfs:
get_device(vol-dev);
volume_sysfs_close(vol);
 out_gluebi:
-   ubi_destroy_gluebi(vol);
+   if(ubi_destroy_gluebi(vol))
+   ubi_err(cannot destroy device);
 out_cdev:
cdev_del(vol-cdev);
 out_mapping:


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


2.6.24.x-stable request for 69f817b654d683265118188bbfb8bc0d8978cce6 and ece8edddf067d21c4e5abfe3f1205da1588edbb2

2008-02-10 Thread S.Çağlar Onur
Hi;

On 2.6.24.1-stable kernel review cycle, i requested inclusions of commit 
69f817b654d683265118188bbfb8bc0d8978cce6 (mac80211: Restore rx.fc before every 
invocation of ieee80211_invoke_rx_handlers) and 
ece8edddf067d21c4e5abfe3f1205da1588edbb2 (mac80211: hardware scan rework) into 
-stable one (they solved disable_hw_scan=1 workaround for wpa_secured hidden AP 
problem). And -stable team said they would rather these comes from either the 
wireless maintainer or the network maintainer to verify that they are needed, 
and the backports works properly.

So, if possible, could you please consider sending these to -stable?

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect

compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 
(UBI: Unsorted Block Images)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 drivers/mtd/ubi/vmt.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..eafeaf0 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,7 @@ out_sysfs:
get_device(>dev);
volume_sysfs_close(vol);
 out_gluebi:
-   ubi_destroy_gluebi(vol);
+   err = ubi_destroy_gluebi(vol);
 out_cdev:
cdev_del(>cdev);
 out_mapping:

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/media/video/em28xx/: Fix undefined symbol error with CONFIG_SND=N

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch fixes following undefined symbol errors with CONFIG_SND=N

ERROR: "snd_pcm_period_elapsed" [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: "snd_pcm_hw_constraint_integer" 
[drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: "snd_pcm_set_ops" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: "snd_card_new" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: "snd_card_free" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: "snd_card_register" [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: "snd_pcm_new" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]> 
 
 drivers/media/video/em28xx/Kconfig |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/em28xx/Kconfig 
b/drivers/media/video/em28xx/Kconfig
index abbd38c..0f7a0bd 100644
--- a/drivers/media/video/em28xx/Kconfig
+++ b/drivers/media/video/em28xx/Kconfig
@@ -13,7 +13,8 @@ config VIDEO_EM28XX
  module will be called em28xx
 
 config VIDEO_EM28XX_ALSA
-   depends on VIDEO_EM28XX
+   depends on VIDEO_EM28XX && SND
+   select SND_PCM
tristate "Empia EM28xx ALSA audio module"
    ---help---
  This is an ALSA driver for some Empia 28xx based TV cards.

Cheeer
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Update kernel/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch updates kernel/.gitignore with new auto-generated files

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 kernel/.gitignore |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/.gitignore b/kernel/.gitignore
index f2ab700..ab4f109 100644
--- a/kernel/.gitignore
+++ b/kernel/.gitignore
@@ -3,3 +3,4 @@
 #
 config_data.h
 config_data.gz
+timeconst.h

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Update arch/x86/boot/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch update arch/x86/boot/.gitignore with new auto-generated files

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 arch/x86/boot/.gitignore |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/boot/.gitignore b/arch/x86/boot/.gitignore
index 1846514..b1bdc4c 100644
--- a/arch/x86/boot/.gitignore
+++ b/arch/x86/boot/.gitignore
@@ -3,3 +3,5 @@ bzImage
 setup
 setup.bin
 setup.elf
+cpustr.h
+mkcpustr

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 (rtc: add support for Epson RTC-9701JE V4)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

drivers/rtc/rtc-r9701.c: In function `r9701_get_datetime':
drivers/rtc/rtc-r9701.c:74: warning: unused variable `time'

compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 
(rtc: add support for Epson RTC-9701JE V4)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
 
 drivers/rtc/rtc-r9701.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-r9701.c b/drivers/rtc/rtc-r9701.c
index a64626a..b35f9bf 100644
--- a/drivers/rtc/rtc-r9701.c
+++ b/drivers/rtc/rtc-r9701.c
@@ -71,7 +71,6 @@ static int read_regs(struct device *dev, unsigned char *regs, 
int no_regs)
 
 static int r9701_get_datetime(struct device *dev, struct rtc_time *dt)
 {
-   unsigned long time;
int ret;
unsigned char buf[] = { RSECCNT, RMINCNT, RHRCNT,
RDAYCNT, RMONCNT, RYRCNT };

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by 11b0cc3a4af65413ca3bb5698769e091486e0b22 (x25_asy: Fix ref count rule violation)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents
 
drivers/net/wan/x25_asy.c: In function `x25_asy_open_tty':
drivers/net/wan/x25_asy.c:557: warning: unused variable `ld'

compiler warning introduced by commit 11b0cc3a4af65413ca3bb5698769e091486e0b22 
(x25_asy: Fix ref count rule violation)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 drivers/net/wan/x25_asy.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index 5e2d763..0f8aca8 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
@@ -554,7 +554,6 @@ static void x25_asy_receive_buf(struct tty_struct *tty, 
const unsigned char *cp,
 static int x25_asy_open_tty(struct tty_struct *tty)
 {
struct x25_asy *sl = (struct x25_asy *) tty->disc_data;
-   struct tty_ldisc *ld;
int err;
 
/* First make sure we're not already connected. */

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

net/bluetooth/hci_sysfs.c: In function `del_conn':
net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment 
used as truth value

compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 
([BLUETOOTH]: Move children of connection device to NULL before connection 
down.)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 net/bluetooth/hci_sysfs.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index e13cf5e..d2d1e4f 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
struct device *dev;
struct hci_conn *conn = container_of(work, struct hci_conn, work);
 
-   while (dev = device_find_child(>dev, NULL, __match_tty)) {
+   while ((dev = device_find_child(>dev, NULL, __match_tty)) != 
NULL) {
device_move(dev, NULL);
put_device(dev);
}

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

net/bluetooth/hci_sysfs.c: In function `del_conn':
net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment 
used as truth value

compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 
([BLUETOOTH]: Move children of connection device to NULL before connection 
down.)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 net/bluetooth/hci_sysfs.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index e13cf5e..d2d1e4f 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
struct device *dev;
struct hci_conn *conn = container_of(work, struct hci_conn, work);
 
-   while (dev = device_find_child(conn-dev, NULL, __match_tty)) {
+   while ((dev = device_find_child(conn-dev, NULL, __match_tty)) != 
NULL) {
device_move(dev, NULL);
put_device(dev);
}

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by 11b0cc3a4af65413ca3bb5698769e091486e0b22 (x25_asy: Fix ref count rule violation)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents
 
drivers/net/wan/x25_asy.c: In function `x25_asy_open_tty':
drivers/net/wan/x25_asy.c:557: warning: unused variable `ld'

compiler warning introduced by commit 11b0cc3a4af65413ca3bb5698769e091486e0b22 
(x25_asy: Fix ref count rule violation)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 drivers/net/wan/x25_asy.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index 5e2d763..0f8aca8 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
@@ -554,7 +554,6 @@ static void x25_asy_receive_buf(struct tty_struct *tty, 
const unsigned char *cp,
 static int x25_asy_open_tty(struct tty_struct *tty)
 {
struct x25_asy *sl = (struct x25_asy *) tty-disc_data;
-   struct tty_ldisc *ld;
int err;
 
/* First make sure we're not already connected. */

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 (rtc: add support for Epson RTC-9701JE V4)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

drivers/rtc/rtc-r9701.c: In function `r9701_get_datetime':
drivers/rtc/rtc-r9701.c:74: warning: unused variable `time'

compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 
(rtc: add support for Epson RTC-9701JE V4)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]
 
 drivers/rtc/rtc-r9701.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-r9701.c b/drivers/rtc/rtc-r9701.c
index a64626a..b35f9bf 100644
--- a/drivers/rtc/rtc-r9701.c
+++ b/drivers/rtc/rtc-r9701.c
@@ -71,7 +71,6 @@ static int read_regs(struct device *dev, unsigned char *regs, 
int no_regs)
 
 static int r9701_get_datetime(struct device *dev, struct rtc_time *dt)
 {
-   unsigned long time;
int ret;
unsigned char buf[] = { RSECCNT, RMINCNT, RHRCNT,
RDAYCNT, RMONCNT, RYRCNT };

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Update arch/x86/boot/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch update arch/x86/boot/.gitignore with new auto-generated files

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 arch/x86/boot/.gitignore |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/boot/.gitignore b/arch/x86/boot/.gitignore
index 1846514..b1bdc4c 100644
--- a/arch/x86/boot/.gitignore
+++ b/arch/x86/boot/.gitignore
@@ -3,3 +3,5 @@ bzImage
 setup
 setup.bin
 setup.elf
+cpustr.h
+mkcpustr

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Update kernel/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch updates kernel/.gitignore with new auto-generated files

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 kernel/.gitignore |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/.gitignore b/kernel/.gitignore
index f2ab700..ab4f109 100644
--- a/kernel/.gitignore
+++ b/kernel/.gitignore
@@ -3,3 +3,4 @@
 #
 config_data.h
 config_data.gz
+timeconst.h

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/media/video/em28xx/: Fix undefined symbol error with CONFIG_SND=N

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch fixes following undefined symbol errors with CONFIG_SND=N

ERROR: snd_pcm_period_elapsed [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: snd_pcm_hw_constraint_integer 
[drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: snd_pcm_set_ops [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: snd_pcm_lib_ioctl [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: snd_card_new [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: snd_card_free [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!
ERROR: snd_card_register [drivers/media/video/em28xx/em28xx-alsa.ko] 
undefined!
ERROR: snd_pcm_new [drivers/media/video/em28xx/em28xx-alsa.ko] undefined!

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED] 
 
 drivers/media/video/em28xx/Kconfig |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/em28xx/Kconfig 
b/drivers/media/video/em28xx/Kconfig
index abbd38c..0f7a0bd 100644
--- a/drivers/media/video/em28xx/Kconfig
+++ b/drivers/media/video/em28xx/Kconfig
@@ -13,7 +13,8 @@ config VIDEO_EM28XX
  module will be called em28xx
 
 config VIDEO_EM28XX_ALSA
-   depends on VIDEO_EM28XX
+   depends on VIDEO_EM28XX  SND
+   select SND_PCM
tristate Empia EM28xx ALSA audio module
---help---
  This is an ALSA driver for some Empia 28xx based TV cards.

Cheeer
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-09 Thread S.Çağlar Onur
Hi;

Following patch silents

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect

compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 
(UBI: Unsorted Block Images)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 drivers/mtd/ubi/vmt.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..eafeaf0 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,7 @@ out_sysfs:
get_device(vol-dev);
volume_sysfs_close(vol);
 out_gluebi:
-   ubi_destroy_gluebi(vol);
+   err = ubi_destroy_gluebi(vol);
 out_cdev:
cdev_del(vol-cdev);
 out_mapping:

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch 00/45] 2.6.24-stable review

2008-02-07 Thread S.Çağlar Onur
Hi;

07 Şub 2008 Per tarihinde, Greg KH şunları yazmıştı: 
> This is the start of the stable review cycle for the 2.6.24.1 release.
> There are 45 patches in this series, all will be posted as a response to
> this one.  If anyone has any issues with these being applied, please let
> us know.  If anyone is a maintainer of the proper subsystem, and wants
> to add a Signed-off-by: line to the patch, please respond with it.

If its possible could you please add [1] "mac80211: hardware scan rework" and 
[2] "mac80211: Restore rx.fc before every invocation of 
ieee80211_invoke_rx_handlers" into -stable too?

[1] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ece8edddf067d21c4e5abfe3f1205da1588edbb2
[2] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=69f817b654d683265118188bbfb8bc0d8978cce6

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [patch 00/45] 2.6.24-stable review

2008-02-07 Thread S.Çağlar Onur
Hi;

07 Şub 2008 Per tarihinde, Greg KH şunları yazmıştı: 
 This is the start of the stable review cycle for the 2.6.24.1 release.
 There are 45 patches in this series, all will be posted as a response to
 this one.  If anyone has any issues with these being applied, please let
 us know.  If anyone is a maintainer of the proper subsystem, and wants
 to add a Signed-off-by: line to the patch, please respond with it.

If its possible could you please add [1] mac80211: hardware scan rework and 
[2] mac80211: Restore rx.fc before every invocation of 
ieee80211_invoke_rx_handlers into -stable too?

[1] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ece8edddf067d21c4e5abfe3f1205da1588edbb2
[2] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=69f817b654d683265118188bbfb8bc0d8978cce6

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, S.Çağlar Onur şunları yazmıştı: 
> > hm, the IPI sending and receiving is nicely paired up:
> > 
> > [  625.795008] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
> > [  625.795223] IPI (@native_smp_send_reschedule) from task amarokapp:2882 
> > on CPU#1:
> > 
> > amarokapp does wake up threads every 20 microseconds - that could 
> > explain it. It's probably Xorg running on one core, amarokapp on the 
> > other core. That's already 100 reschedules/sec.
> 
> Heh, killing amarok ends up with following;
> 
>  PowerTOP version 1.9   (C) 2007 Intel Corporation
> 
> CnAvg residency   P-states (frequencies)
> C0 (cpu running)( 0,9%)
> C10,0ms ( 0,0%)
> C20,2ms ( 0,0%)
> C35,1ms (99,1%)
> 
> 
> Wakeups-from-idle per second : 197,8interval: 10,0s
> no ACPI power usage estimate available
> 
> Top causes for wakeups:
>   34,7% (130,7)   USB device  3-2 : HP Integrated Module (Broadcom Corp)
>   26,5% (100,0): uhci_hcd:usb3
>5,8% ( 22,0)  java : futex_wait (hrtimer_wakeup)
>5,3% ( 20,0): iwl3945
>4,1% ( 15,4)   USB device  2-2 : Microsoft Wireless Optical Mouse .00 
> (Microsoft)
>2,9% ( 11,0): libata
>2,7% ( 10,1): extra timer interrupt
>2,7% ( 10,0)  java : schedule_timeout (process_timeout)
>2,7% ( 10,0)  : scan_async (ehci_watchdog)
>2,4% (  9,0)   : Rescheduling interrupts
>2,1% (  8,0): usb_hcd_poll_rh_status (rh_timer_func)
>1,7% (  6,4): uhci_hcd:usb2
>1,7% (  6,4) artsd : schedule_timeout (process_timeout)
>0,6% (  2,1): ohci1394, uhci_hcd:usb4, nvidia
>0,5% (  2,0)  : clocksource_check_watchdog 
> (clocksource_watchdog)
>0,5% (  1,7)wpa_supplicant : schedule_timeout (process_timeout)
>0,3% (  1,0)kicker : schedule_timeout (process_timeout)
>0,3% (  1,0)  kwin : schedule_timeout (process_timeout)
>0,3% (  1,0)  kdesktop : schedule_timeout (process_timeout)
>0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
>0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
>0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)
 
By the way loging out from KDE also suffers same problem, this time kdm 
migrated to CPU1 and powertop reports ~300 wakeups for " : 
Rescheduling interrupts" again.

[...]
[ 2058.246692] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.246737] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.246812] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.278947] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279070] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279175] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279251] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.279301] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279377] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279425] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279503] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.279565] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279637] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279683] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279758] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.311903] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.312028] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[...]

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
> 
> * S.Çağlar Onur <[EMAIL PROTECTED]> wrote:
> 
> > > My theory is that for whatever reason we get "repeat" IPIs: multiple 
> > > reschedule IPIs although the other CPU only initiated one.
> > 
> > Ok, please see http://cekirdek.pardus.org.tr/~caglar/dmesg.3rd :)
> 
> hm, the IPI sending and receiving is nicely paired up:
> 
> [  625.795008] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
> [  625.795223] IPI (@native_smp_send_reschedule) from task amarokapp:2882 on 
> CPU#1:
> 
> amarokapp does wake up threads every 20 microseconds - that could 
> explain it. It's probably Xorg running on one core, amarokapp on the 
> other core. That's already 100 reschedules/sec.

Heh, killing amarok ends up with following;

 PowerTOP version 1.9   (C) 2007 Intel Corporation

CnAvg residency   P-states (frequencies)
C0 (cpu running)( 0,9%)
C10,0ms ( 0,0%)
C20,2ms ( 0,0%)
C35,1ms (99,1%)


Wakeups-from-idle per second : 197,8interval: 10,0s
no ACPI power usage estimate available

Top causes for wakeups:
  34,7% (130,7)   USB device  3-2 : HP Integrated Module (Broadcom Corp)
  26,5% (100,0): uhci_hcd:usb3
   5,8% ( 22,0)  java : futex_wait (hrtimer_wakeup)
   5,3% ( 20,0): iwl3945
   4,1% ( 15,4)   USB device  2-2 : Microsoft Wireless Optical Mouse .00 
(Microsoft)
   2,9% ( 11,0): libata
   2,7% ( 10,1): extra timer interrupt
   2,7% ( 10,0)  java : schedule_timeout (process_timeout)
   2,7% ( 10,0)  : scan_async (ehci_watchdog)
   2,4% (  9,0)   : Rescheduling interrupts
   2,1% (  8,0): usb_hcd_poll_rh_status (rh_timer_func)
   1,7% (  6,4): uhci_hcd:usb2
   1,7% (  6,4) artsd : schedule_timeout (process_timeout)
   0,6% (  2,1): ohci1394, uhci_hcd:usb4, nvidia
   0,5% (  2,0)  : clocksource_check_watchdog 
(clocksource_watchdog)
   0,5% (  1,7)wpa_supplicant : schedule_timeout (process_timeout)
   0,3% (  1,0)kicker : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwin : schedule_timeout (process_timeout)
   0,3% (  1,0)  kdesktop : schedule_timeout (process_timeout)
   0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
   0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)

-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
> 
> also, this might reduce the number of cross-CPU wakeups on near-idle 
> systems:
> 
>   echo 1 > /sys/devices/system/cpu/sched_mc_power_savings
> 
> [ or if it doesnt, it should ;) ]
> 
>   Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Seems like nothing changes 


zangetsu ~ # cat /sys/devices/system/cpu/sched_mc_power_savings
1



Powertop still reports ~300 wakeups for " : Rescheduling interrupts"

 PowerTOP version 1.9   (C) 2007 Intel Corporation

CnAvg residency   P-states (frequencies)
C0 (cpu running)( 4,8%)
C10,0ms ( 0,0%)
C20,2ms ( 2,4%)
C32,4ms (92,8%)


Wakeups-from-idle per second : 495,2interval: 3,0s
no ACPI power usage estimate available

Top causes for wakeups:
  40,0% (330,7)   : Rescheduling interrupts
  12,3% (102,0)   USB device  3-2 : HP Integrated Module (Broadcom Corp)
  12,1% (100,0): uhci_hcd:usb3
   8,0% ( 66,3): extra timer interrupt
   7,0% ( 58,0) amarokapp : schedule_timeout (process_timeout)
   4,0% ( 33,0): uhci_hcd:usb2



and this is what system is doing while powertop reports above;

USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
root 1  0.1  0.0   1512   532 ?Ss   17:41   0:00 init [3]  
root 2  0.0  0.0  0 0 ?S<   17:41   0:00 [kthreadd]
root 3  0.0  0.0  0 0 ?S<   17:41   0:00 [migration/0]
root 4  0.0  0.0  0 0 ?S<   17:41   0:00 [ksoftirqd/0]
root 5  0.0  0.0  0 0 ?S<   17:41   0:00 [migration/1]
root 6  0.0  0.0  0 0 ?S<   17:41   0:00 [ksoftirqd/1]
root 7  0.0  0.0  0 0 ?S<   17:41   0:00 [events/0]
root 8  0.0  0.0  0 0 ?S<   17:41   0:00 [events/1]
root 9  0.0  0.0  0 0 ?S<   17:41   0:00 [khelper]
root10  0.0  0.0  0 0 ?S<   17:41   0:00 [kblockd/0]
root11  0.0  0.0  0 0 ?S<   17:41   0:00 [kblockd/1]
root12  0.0  0.0  0 0 ?S<   17:41   0:00 [kacpid]
root13  0.0  0.0  0 0 ?S<   17:41   0:00 [kacpi_notify]
root14  0.0  0.0  0 0 ?S<   17:41   0:00 [cqueue/0]
root15  0.0  0.0  0 0 ?S<   17:41   0:00 [cqueue/1]
root16  0.0  0.0  0 0 ?S<   17:41   0:00 [kseriod]
root17  0.0  0.0  0 0 ?S17:41   0:00 [pdflush]
root18  0.0  0.0  0 0 ?S17:41   0:00 [pdflush]
root19  0.0  0.0  0 0 ?S<   17:41   0:00 [kswapd0]
root20  0.0  0.0  0 0 ?S<   17:41   0:00 [aio/0]
root21  0.0  0.0  0 0 ?S<   17:41   0:00 [aio/1]
root22  0.0  0.0  0 0 ?S<   17:41   0:00 [kpsmoused]
root42  0.0  0.0  0 0 ?S<   17:41   0:00 [khpsbpkt]
root46  0.0  0.0  0 0 ?S<   17:41   0:00 [knodemgrd_0]
root55  0.0  0.0  0 0 ?S<   17:41   0:00 [ata/0]
root56  0.0  0.0  0 0 ?S<   17:41   0:00 [ata/1]
root57  0.0  0.0  0 0 ?S<   17:41   0:00 [ata_aux]
root61  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_0]
root62  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_1]
root63  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_2]
root64  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_3]
root70  0.0  0.0  0 0 ?S<   17:41   0:00 [ksuspend_usbd]
root71  0.0  0.0  0 0 ?S<   17:41   0:00 [khubd]
root80  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_4]
root81  0.0  0.0  0 0 ?S<   17:41   0:00 [scsi_eh_5]
root   159  0.0  0.0  0 0 ?S<   17:41   0:00 [kjournald]
root   194  0.0  0.0   2452  1304 ?S
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
> * S.Çağlar Onur <[EMAIL PROTECTED]> wrote:
> > I grabbed the logs two times to make sure to catch needed info. 1st [1]
> > one is generated while "Rescheduling interrupts" wakeups ~200 times and
> > 2nd one generated for ~350 wakeups.
> >
> > [1] http://cekirdek.pardus.org.tr/~caglar/dmesg.1st
> > [2] http://cekirdek.pardus.org.tr/~caglar/dmesg.2nd
>
> thanks, these seem to be mostly normal wakeups from standard tasks:
>
>  IPI from task kdm_greet:2118 on CPU#0:
>  IPI from task X:2079 on CPU#1:
>  IPI from task kdm_greet:2118 on CPU#0:
>  IPI from task hald-addon-inpu:2009 on CPU#1:
>  IPI from task events/0:7 on CPU#1:
>  IPI from task bash:2129 on CPU#0:
>  IPI from task kdm_greet:2118 on CPU#0:
>  IPI from task events/0:7 on CPU#1:
>  IPI from task events/0:7 on CPU#1:
>  IPI from task events/0:7 on CPU#1:
>  IPI from task bash:3902 on CPU#1:
>  IPI from task bash:3902 on CPU#1:
>  IPI from task amarokapp:3423 on CPU#1:
>  IPI from task amarokapp:3423 on CPU#1:
>  IPI from task amarokapp:3423 on CPU#1:
>  IPI from task X:2079 on CPU#0:
>  IPI from task yakuake:3422 on CPU#0:
>  IPI from task X:2079 on CPU#1:
>  IPI from task amarokapp:3423 on CPU#1:
>  IPI from task amarokapp:3423 on CPU#1:
>
> could you also add a similar IPI printouts (with the same panic_timeout
> logic) to arch/x86/kernel/smp_32.c's smp_reschedule_interrupt() function
> - while still keeping the other printouts too?
>
> Could you also enable PRINTK_TIME timestamps, so that we can see the
> timings? (And do a "dmesg -n 1" so that the printks happen fast and the
> timings are accurate.) I'd suggest to increase CONFIG_LOG_BUF_SHIFT to
> 20, so that your dmesg buffer is large enough. Plus try to capture 100
> events, ok?
>
> My theory is that for whatever reason we get "repeat" IPIs: multiple
> reschedule IPIs although the other CPU only initiated one.

Ok, please see http://cekirdek.pardus.org.tr/~caglar/dmesg.3rd :)

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
> * S.Çağlar Onur <[EMAIL PROTECTED]> wrote:
> 
> > Top causes for wakeups:
> >   59,9% (238,4)   : Rescheduling interrupts
> > ^^
> >   14,7% ( 58,6) amarokapp : schedule_timeout (process_timeout)
> 
> hm, would be nice to figure out what causes these IPIs. Could you stick 
> something like this into arch/x86/kernel/smp_32.c's 
> smp_send_reschedule() function [this is the function that generates the 
> IPI]:
> 
> static void native_smp_send_reschedule(int cpu)
> {
> WARN_ON(cpu_is_offline(cpu));
> send_IPI_mask(cpumask_of_cpu(cpu), RESCHEDULE_VECTOR);
>   if (panic_timeout > 0) {
>   panic_timeout--;
>   printk("IPI from task %s:%d on CPU#%d:\n", 
>   current->comm, current->pid, cpu);
>   dump_stack();
>   }
> }
> 
> NOTE: if you run an SMP kernel then first remove these two lines from 
> kernel/printk.c:
> 
> if (!oops_in_progress && waitqueue_active(_wait))
> wake_up_interruptible(_wait);
> 
> otherwise you'll get lockups. (the IPI is sent while holding the 
> runqueue lock, so the printks will lock up)
> 
> then wait for the bad condition to occur on your system and generate a 
> stream of ~10 backtraces, via:
> 
>   echo 10 > /proc/sys/kernel/panic
> 
> you should be getting 10 immediate backtraces - please send them to us. 
> The backtraces should show the place that generates the wakeups. [turn 
> on CONFIG_FRAME_POINTERS=y to get high quality backtraces.]
>  
> If you do _not_ get 10 immediate backtraces, then something in the 
> system is generating such IPIs outside of the scheduler's control. That 
> would suggest some other sort of borkage.
> 
>   Ingo

I grabbed the logs two times to make sure to catch needed info. 1st [1] one is 
generated while "Rescheduling interrupts" wakeups ~200 times and 2nd one 
generated for ~350 wakeups.

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.1st 
[2] http://cekirdek.pardus.org.tr/~caglar/dmesg.2nd

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
 * S.Çağlar Onur [EMAIL PROTECTED] wrote:
 
  Top causes for wakeups:
59,9% (238,4)  kernel IPI : Rescheduling interrupts
  ^^
14,7% ( 58,6) amarokapp : schedule_timeout (process_timeout)
 
 hm, would be nice to figure out what causes these IPIs. Could you stick 
 something like this into arch/x86/kernel/smp_32.c's 
 smp_send_reschedule() function [this is the function that generates the 
 IPI]:
 
 static void native_smp_send_reschedule(int cpu)
 {
 WARN_ON(cpu_is_offline(cpu));
 send_IPI_mask(cpumask_of_cpu(cpu), RESCHEDULE_VECTOR);
   if (panic_timeout  0) {
   panic_timeout--;
   printk(IPI from task %s:%d on CPU#%d:\n, 
   current-comm, current-pid, cpu);
   dump_stack();
   }
 }
 
 NOTE: if you run an SMP kernel then first remove these two lines from 
 kernel/printk.c:
 
 if (!oops_in_progress  waitqueue_active(log_wait))
 wake_up_interruptible(log_wait);
 
 otherwise you'll get lockups. (the IPI is sent while holding the 
 runqueue lock, so the printks will lock up)
 
 then wait for the bad condition to occur on your system and generate a 
 stream of ~10 backtraces, via:
 
   echo 10  /proc/sys/kernel/panic
 
 you should be getting 10 immediate backtraces - please send them to us. 
 The backtraces should show the place that generates the wakeups. [turn 
 on CONFIG_FRAME_POINTERS=y to get high quality backtraces.]
  
 If you do _not_ get 10 immediate backtraces, then something in the 
 system is generating such IPIs outside of the scheduler's control. That 
 would suggest some other sort of borkage.
 
   Ingo

I grabbed the logs two times to make sure to catch needed info. 1st [1] one is 
generated while Rescheduling interrupts wakeups ~200 times and 2nd one 
generated for ~350 wakeups.

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.1st 
[2] http://cekirdek.pardus.org.tr/~caglar/dmesg.2nd

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
 * S.Çağlar Onur [EMAIL PROTECTED] wrote:
  I grabbed the logs two times to make sure to catch needed info. 1st [1]
  one is generated while Rescheduling interrupts wakeups ~200 times and
  2nd one generated for ~350 wakeups.
 
  [1] http://cekirdek.pardus.org.tr/~caglar/dmesg.1st
  [2] http://cekirdek.pardus.org.tr/~caglar/dmesg.2nd

 thanks, these seem to be mostly normal wakeups from standard tasks:

  IPI from task kdm_greet:2118 on CPU#0:
  IPI from task X:2079 on CPU#1:
  IPI from task kdm_greet:2118 on CPU#0:
  IPI from task hald-addon-inpu:2009 on CPU#1:
  IPI from task events/0:7 on CPU#1:
  IPI from task bash:2129 on CPU#0:
  IPI from task kdm_greet:2118 on CPU#0:
  IPI from task events/0:7 on CPU#1:
  IPI from task events/0:7 on CPU#1:
  IPI from task events/0:7 on CPU#1:
  IPI from task bash:3902 on CPU#1:
  IPI from task bash:3902 on CPU#1:
  IPI from task amarokapp:3423 on CPU#1:
  IPI from task amarokapp:3423 on CPU#1:
  IPI from task amarokapp:3423 on CPU#1:
  IPI from task X:2079 on CPU#0:
  IPI from task yakuake:3422 on CPU#0:
  IPI from task X:2079 on CPU#1:
  IPI from task amarokapp:3423 on CPU#1:
  IPI from task amarokapp:3423 on CPU#1:

 could you also add a similar IPI printouts (with the same panic_timeout
 logic) to arch/x86/kernel/smp_32.c's smp_reschedule_interrupt() function
 - while still keeping the other printouts too?

 Could you also enable PRINTK_TIME timestamps, so that we can see the
 timings? (And do a dmesg -n 1 so that the printks happen fast and the
 timings are accurate.) I'd suggest to increase CONFIG_LOG_BUF_SHIFT to
 20, so that your dmesg buffer is large enough. Plus try to capture 100
 events, ok?

 My theory is that for whatever reason we get repeat IPIs: multiple
 reschedule IPIs although the other CPU only initiated one.

Ok, please see http://cekirdek.pardus.org.tr/~caglar/dmesg.3rd :)

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
]
caglar2862  0.0  0.3  25560  6688 ?S17:44   0:00 kio_file 
[kdeinit] file /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar2866  0.0  0.3  13736  7856 ?S17:44   0:00 
/usr/kde/3.5/bin/artsd -F 10 -S 4096 -s 3 -m artsmessage -c drkonqi -l 3 -f
caglar2871  0.0  0.6  29552 12728 ?S17:44   0:00 kmix [kdeinit] 
-session 10dfd5e1dc00011810921640036490013_1201  
caglar2873  0.3  1.2  57188 26548 ?S17:44   0:02 akregator 
-session 10dfd5e1dc00011973723640038700014_1201016429_751575
caglar2876  0.0  0.5  25972 10908 ?S17:44   0:00 knazar 
-session 10dfd5e1dc00011973834210051660022_1201016429_752054
caglar2877  0.0  0.5  35540 11524 ?S17:44   0:00 knotify 
[kdeinit]   
caglar2879  0.0  0.7  41988 14848 ?S17:44   0:00 kgpg -session 
10dfd5e1dc00011988545450040010017_1201016429_751902
caglar2881  0.4  0.7  29792 15976 ?S17:44   0:03 yakuake 
-session 10dfd5e1dc00011994900910068430023_1201016429_752567
caglar2882  3.5  2.7 152560 57376 ?Sl   17:44   0:26 amarokapp 
-session 10dfd5e1dc00012000114530022560015_1201016429_751762
caglar2890  1.2  4.0 148500 83704 ?Sl   17:44   0:09 kmail -session 
10dfd5e1dc00012010092460022060011_1201016429_752344
caglar2894  0.0  0.5  27664 11080 ?S17:44   0:00 klipper 
[kdeinit]   
caglar2898  0.0  0.5  29504 11512 ?S17:44   0:00 kpowersave 
[kdeinit]
caglar3080  0.0  0.3  54032  7924 ?S17:44   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3081  0.0  0.3  53912  7916 ?S17:44   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3150  0.0  0.1   4136  2600 pts/2Ss   17:44   0:00 /bin/bash
caglar3236  0.0  0.4  16604  8576 ?S17:44   0:00 
/usr/libexec/notification-daemon
caglar3273  0.0  0.3  27164  7028 ?S17:44   0:00 kio_file 
[kdeinit] file /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3274  0.0  0.1   3692  2348 ?S17:44   0:00 ruby 
/usr/kde/3.5/share/apps/amarok/scripts/score_default/score_default.rb
caglar3341  0.0  0.3  62224  8172 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3343  0.0  0.3  61208  8116 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3344  0.0  0.3  54036  8076 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3345  0.0  0.3  53012  8072 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3347  0.0  0.3  54040  8120 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3348  0.0  0.3  62232  8100 ?S17:46   0:00 kio_http 
[kdeinit] http /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
caglar3897  0.0  0.8  56212 17004 ?S17:50   0:00 
/usr/bin/python /usr/kde/3.5/bin/network-applet
caglar4265  0.0  0.0   2752  1308 ?S17:53   0:00 /bin/sh 
/usr/bin/firefox
caglar4267  1.1  1.6 131892 33644 ?Sl   17:53   0:01 
/usr/lib/MozillaFirefox//firefox-bin
caglar4271  0.0  0.1   4148  2392 ?S17:53   0:00 
/usr/libexec/gconfd-2 14
caglar4300  0.0  0.4  54932  9120 ?S17:54   0:00 kio_pop3 
[kdeinit] pop3 /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
root  4316  0.0  0.0   2524  1200 pts/2S17:55   0:00 su -
root  4318  0.2  0.1   4788  3476 pts/2S17:55   0:00 -su
root  4342  0.1  0.1   3200  2116 pts/2S+   17:55   0:00 powertop
caglar4345  0.1  0.1   4004  2540 pts/0Ss   17:55   0:00 /bin/bash
root  4451  0.0  0.0   2524  1200 pts/0S17:55   0:00 su -
root  4453  0.3  0.1   4788  3448 pts/0S17:55   0:00 -su
caglar4543  0.2  0.4  54064  9416 ?S17:55   0:00 kio_smtp 
[kdeinit] smtp /tmp/ksocket-caglar/klauncherTCaD9a.slave-  
root  4588  0.0  0.0   2272   964 pts/0R+   17:56   0:00 ps aux

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
22 Oca 2008 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
 
 * S.Çağlar Onur [EMAIL PROTECTED] wrote:
 
   My theory is that for whatever reason we get repeat IPIs: multiple 
   reschedule IPIs although the other CPU only initiated one.
  
  Ok, please see http://cekirdek.pardus.org.tr/~caglar/dmesg.3rd :)
 
 hm, the IPI sending and receiving is nicely paired up:
 
 [  625.795008] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
 [  625.795223] IPI (@native_smp_send_reschedule) from task amarokapp:2882 on 
 CPU#1:
 
 amarokapp does wake up threads every 20 microseconds - that could 
 explain it. It's probably Xorg running on one core, amarokapp on the 
 other core. That's already 100 reschedules/sec.

Heh, killing amarok ends up with following;

 PowerTOP version 1.9   (C) 2007 Intel Corporation

CnAvg residency   P-states (frequencies)
C0 (cpu running)( 0,9%)
C10,0ms ( 0,0%)
C20,2ms ( 0,0%)
C35,1ms (99,1%)


Wakeups-from-idle per second : 197,8interval: 10,0s
no ACPI power usage estimate available

Top causes for wakeups:
  34,7% (130,7)   USB device  3-2 : HP Integrated Module (Broadcom Corp)
  26,5% (100,0)   interrupt : uhci_hcd:usb3
   5,8% ( 22,0)  java : futex_wait (hrtimer_wakeup)
   5,3% ( 20,0)   interrupt : iwl3945
   4,1% ( 15,4)   USB device  2-2 : Microsoft Wireless Optical Mouse .00 
(Microsoft)
   2,9% ( 11,0)   interrupt : libata
   2,7% ( 10,1)   interrupt : extra timer interrupt
   2,7% ( 10,0)  java : schedule_timeout (process_timeout)
   2,7% ( 10,0) kernel core : scan_async (ehci_watchdog)
   2,4% (  9,0)  kernel IPI : Rescheduling interrupts
   2,1% (  8,0)   kernel module : usb_hcd_poll_rh_status (rh_timer_func)
   1,7% (  6,4)   interrupt : uhci_hcd:usb2
   1,7% (  6,4) artsd : schedule_timeout (process_timeout)
   0,6% (  2,1)   interrupt : ohci1394, uhci_hcd:usb4, nvidia
   0,5% (  2,0) kernel core : clocksource_check_watchdog 
(clocksource_watchdog)
   0,5% (  1,7)wpa_supplicant : schedule_timeout (process_timeout)
   0,3% (  1,0)kicker : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwin : schedule_timeout (process_timeout)
   0,3% (  1,0)  kdesktop : schedule_timeout (process_timeout)
   0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
   0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)

-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Rescheduling interrupts

2008-01-22 Thread S.Çağlar Onur
Hi;

22 Oca 2008 Sal tarihinde, S.Çağlar Onur şunları yazmıştı: 
  hm, the IPI sending and receiving is nicely paired up:
  
  [  625.795008] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
  [  625.795223] IPI (@native_smp_send_reschedule) from task amarokapp:2882 
  on CPU#1:
  
  amarokapp does wake up threads every 20 microseconds - that could 
  explain it. It's probably Xorg running on one core, amarokapp on the 
  other core. That's already 100 reschedules/sec.
 
 Heh, killing amarok ends up with following;
 
  PowerTOP version 1.9   (C) 2007 Intel Corporation
 
 CnAvg residency   P-states (frequencies)
 C0 (cpu running)( 0,9%)
 C10,0ms ( 0,0%)
 C20,2ms ( 0,0%)
 C35,1ms (99,1%)
 
 
 Wakeups-from-idle per second : 197,8interval: 10,0s
 no ACPI power usage estimate available
 
 Top causes for wakeups:
   34,7% (130,7)   USB device  3-2 : HP Integrated Module (Broadcom Corp)
   26,5% (100,0)   interrupt : uhci_hcd:usb3
5,8% ( 22,0)  java : futex_wait (hrtimer_wakeup)
5,3% ( 20,0)   interrupt : iwl3945
4,1% ( 15,4)   USB device  2-2 : Microsoft Wireless Optical Mouse .00 
 (Microsoft)
2,9% ( 11,0)   interrupt : libata
2,7% ( 10,1)   interrupt : extra timer interrupt
2,7% ( 10,0)  java : schedule_timeout (process_timeout)
2,7% ( 10,0) kernel core : scan_async (ehci_watchdog)
2,4% (  9,0)  kernel IPI : Rescheduling interrupts
2,1% (  8,0)   kernel module : usb_hcd_poll_rh_status (rh_timer_func)
1,7% (  6,4)   interrupt : uhci_hcd:usb2
1,7% (  6,4) artsd : schedule_timeout (process_timeout)
0,6% (  2,1)   interrupt : ohci1394, uhci_hcd:usb4, nvidia
0,5% (  2,0) kernel core : clocksource_check_watchdog 
 (clocksource_watchdog)
0,5% (  1,7)wpa_supplicant : schedule_timeout (process_timeout)
0,3% (  1,0)kicker : schedule_timeout (process_timeout)
0,3% (  1,0)  kwin : schedule_timeout (process_timeout)
0,3% (  1,0)  kdesktop : schedule_timeout (process_timeout)
0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)
 
By the way loging out from KDE also suffers same problem, this time kdm 
migrated to CPU1 and powertop reports ~300 wakeups for kernel IPI : 
Rescheduling interrupts again.

[...]
[ 2058.246692] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.246737] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.246812] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.278947] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279070] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279175] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279251] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.279301] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279377] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279425] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279503] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.279565] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.279637] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[ 2058.279683] IPI (@native_smp_send_reschedule) from task kdm_greet:6122 on 
CPU#1:
[ 2058.279758] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#1:
[ 2058.311903] IPI (@native_smp_send_reschedule) from task X:2073 on CPU#0:
[ 2058.312028] IPI (@smp_reschedule_interrupt) from task swapper:0 on CPU#0:
[...]

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Rescheduling interrupts

2008-01-21 Thread S.Çağlar Onur
Hi;

With Linus's latest git, powertop reports following while system nearly %100 
idle;

PowerTOP version 1.9   (C) 2007 Intel Corporation

CnAvg residency   P-states (frequencies)
C0 (cpu running)( 6,3%) 1,84 Ghz 0,4%
C10,0ms ( 0,0%) 1333 Mhz 0,0%
C20,1ms ( 0,5%) 1000 Mhz99,6%
C33,7ms (93,2%)


Wakeups-from-idle per second : 306,8interval: 10,0s
Power usage (5 minute ACPI estimate) :  23,1 W (0,5 hours left)

Top causes for wakeups:
  59,9% (238,4)   : Rescheduling interrupts
^^
  14,7% ( 58,6) amarokapp : schedule_timeout (process_timeout)
   5,5% ( 21,9)  java : futex_wait (hrtimer_wakeup)
   5,0% ( 19,8): iwl3945
   2,5% ( 10,0)  java : schedule_timeout (process_timeout)
   2,5% ( 10,0)  : ehci_work (ehci_watchdog)
   2,5% ( 10,0): extra timer interrupt
   1,6% (  6,4) artsd : schedule_timeout (process_timeout)
   1,0% (  4,0): usb_hcd_poll_rh_status (rh_timer_func)
   0,5% (  2,0): ohci1394, uhci_hcd:usb4, nvidia
   0,5% (  2,0)  : clocksource_check_watchdog 
(clocksource_watchdog)
   0,5% (  2,0)  kwin : schedule_timeout (process_timeout)
   0,5% (  1,9)wpa_supplicant : schedule_timeout (process_timeout)
   0,3% (  1,2)  kdesktop : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
   0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
   0,3% (  1,0) artsd : do_setitimer (it_real_fn)
   0,3% (  1,0) gpg-agent : schedule_timeout (process_timeout)
   0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)
   0,3% (  1,0)kicker : schedule_timeout (process_timeout)
   0,1% (  0,5)   iwl3945 : ieee80211_authenticate 
(ieee80211_sta_timer)
   0,1% (  0,5)  : neigh_table_init_no_netlink 
(neigh_periodic_timer)

This " : Rescheduling interrupts" causes at least 200 wakeups 
(sometimes i see ~400 wakeups) for me and a quick google search yields [1], 
but i didn't see this reported to LKML, so here it is :).

If anything else is needed please yell...

[1] http://www.mail-archive.com/[EMAIL PROTECTED]/msg01009.html
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Rescheduling interrupts

2008-01-21 Thread S.Çağlar Onur
Hi;

With Linus's latest git, powertop reports following while system nearly %100 
idle;

PowerTOP version 1.9   (C) 2007 Intel Corporation

CnAvg residency   P-states (frequencies)
C0 (cpu running)( 6,3%) 1,84 Ghz 0,4%
C10,0ms ( 0,0%) 1333 Mhz 0,0%
C20,1ms ( 0,5%) 1000 Mhz99,6%
C33,7ms (93,2%)


Wakeups-from-idle per second : 306,8interval: 10,0s
Power usage (5 minute ACPI estimate) :  23,1 W (0,5 hours left)

Top causes for wakeups:
  59,9% (238,4)  kernel IPI : Rescheduling interrupts
^^
  14,7% ( 58,6) amarokapp : schedule_timeout (process_timeout)
   5,5% ( 21,9)  java : futex_wait (hrtimer_wakeup)
   5,0% ( 19,8)   interrupt : iwl3945
   2,5% ( 10,0)  java : schedule_timeout (process_timeout)
   2,5% ( 10,0) kernel core : ehci_work (ehci_watchdog)
   2,5% ( 10,0)   interrupt : extra timer interrupt
   1,6% (  6,4) artsd : schedule_timeout (process_timeout)
   1,0% (  4,0)   kernel module : usb_hcd_poll_rh_status (rh_timer_func)
   0,5% (  2,0)   interrupt : ohci1394, uhci_hcd:usb4, nvidia
   0,5% (  2,0) kernel core : clocksource_check_watchdog 
(clocksource_watchdog)
   0,5% (  2,0)  kwin : schedule_timeout (process_timeout)
   0,5% (  1,9)wpa_supplicant : schedule_timeout (process_timeout)
   0,3% (  1,2)  kdesktop : schedule_timeout (process_timeout)
   0,3% (  1,0)  kwrapper : do_nanosleep (hrtimer_wakeup)
   0,3% (  1,0)   klipper : schedule_timeout (process_timeout)
   0,3% (  1,0) artsd : do_setitimer (it_real_fn)
   0,3% (  1,0) gpg-agent : schedule_timeout (process_timeout)
   0,3% (  1,0) X : nv_start_rc_timer (nv_kern_rc_timer)
   0,3% (  1,0)kicker : schedule_timeout (process_timeout)
   0,1% (  0,5)   iwl3945 : ieee80211_authenticate 
(ieee80211_sta_timer)
   0,1% (  0,5) kernel core : neigh_table_init_no_netlink 
(neigh_periodic_timer)

This kernel IPI : Rescheduling interrupts causes at least 200 wakeups 
(sometimes i see ~400 wakeups) for me and a quick google search yields [1], 
but i didn't see this reported to LKML, so here it is :).

If anything else is needed please yell...

[1] http://www.mail-archive.com/[EMAIL PROTECTED]/msg01009.html
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt2

2008-01-16 Thread S.Çağlar Onur
Hi Again;

16 Oca 2008 Çar tarihinde, S.Çağlar Onur şunları yazmıştı: 
> 16 Oca 2008 Çar tarihinde, Steven Rostedt şunları yazmıştı:
> > On Tue, 15 Jan 2008, [utf-8] S.Ã^GaÄ^_lar Onur wrote:
> > > 2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit
> > > 031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like
> > > following (full dmesg can be found @ [1]) when try to login from
> > > console (the other acpi related errors also existed in 2.6.24-rc5-rt1)
> > > and FYI, plain 2.6.24-rc7 (again commit
> > > 031f2dcd7075e218e74dd7f942ad015cf82dffab) has no issues.
> >
> > Do you get the same issues if you add to -rc7 and not git.
>
> I'll try after trying -rt3.

-rt3 on top of 2.6.24-rc8 works fine without that sysfs problem (acpi warnings 
still there and full dmesg can be found from [1]), whatever causes this seems 
solved :)

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt3

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt2

2008-01-16 Thread S.Çağlar Onur
Hi Again;

16 Oca 2008 Çar tarihinde, S.Çağlar Onur şunları yazmıştı: 
 16 Oca 2008 Çar tarihinde, Steven Rostedt şunları yazmıştı:
  On Tue, 15 Jan 2008, [utf-8] S.Ã^GaÄ^_lar Onur wrote:
   2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit
   031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like
   following (full dmesg can be found @ [1]) when try to login from
   console (the other acpi related errors also existed in 2.6.24-rc5-rt1)
   and FYI, plain 2.6.24-rc7 (again commit
   031f2dcd7075e218e74dd7f942ad015cf82dffab) has no issues.
 
  Do you get the same issues if you add to -rc7 and not git.

 I'll try after trying -rt3.

-rt3 on top of 2.6.24-rc8 works fine without that sysfs problem (acpi warnings 
still there and full dmesg can be found from [1]), whatever causes this seems 
solved :)

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt3

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt2

2008-01-15 Thread S.Çağlar Onur
Hi,

16 Oca 2008 Çar tarihinde, Steven Rostedt şunları yazmıştı: 
> On Tue, 15 Jan 2008, [utf-8] S.Ã^GaÄ^_lar Onur wrote:
> > 2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit
> > 031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like
> > following (full dmesg can be found @ [1]) when try to login from console
> > (the other acpi related errors also existed in 2.6.24-rc5-rt1) and FYI,
> > plain 2.6.24-rc7 (again commit 031f2dcd7075e218e74dd7f942ad015cf82dffab)
> > has no issues.
>
> Do you get the same issues if you add to -rc7 and not git.

I'll try after trying -rt3.

> > [...]
> > sysfs: duplicate filename 'vcs1' can not be created
> > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
> > Pid: 1298, comm: mingetty Not tainted 2.6.24-rc7-rt2-99 #1
> > [...]
> >
> > And because of mcount-add-basic-support-for-gcc-profiler-instrum.patch,
> > closed source nvidia-new module cannot be used with this release (mcount
> > is exported GPL only), i know this is not supported but i used it with
> > that [2] patch up until now without a single problem.
>
> Ah, sorry about that. I'll try to fix that later on. You should still be
> able to use NVidia by turning off function trace.

Wonderfull news :) [and yes turning off function trace works]

> > Please don't misunderstand this, i really do not want to start a
> > discussion for this, i just want to ask the possibility of converting
> > this into EXPORT_SYMBOL cause i thought some of the possible -rt users
> > may need this closed source module explicitly because of its 3D
> > performance.
> >
> > If anything else needed for sysfs warnings please just say it...
> >
> > [1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt
> > [2]
> > http://svn.pardus.org.tr/pardus/devel/kernel/drivers/nvidia-new/files/rt.
> >patch
>
> Thanks for the report. I'll see what I can do for the next release. But
> for now this will have to wait till after -rt3.

Thanks...

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt2

2008-01-15 Thread S.Çağlar Onur
Hi,

16 Oca 2008 Çar tarihinde, Steven Rostedt şunları yazmıştı: 
 On Tue, 15 Jan 2008, [utf-8] S.Ã^GaÄ^_lar Onur wrote:
  2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit
  031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like
  following (full dmesg can be found @ [1]) when try to login from console
  (the other acpi related errors also existed in 2.6.24-rc5-rt1) and FYI,
  plain 2.6.24-rc7 (again commit 031f2dcd7075e218e74dd7f942ad015cf82dffab)
  has no issues.

 Do you get the same issues if you add to -rc7 and not git.

I'll try after trying -rt3.

  [...]
  sysfs: duplicate filename 'vcs1' can not be created
  WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
  Pid: 1298, comm: mingetty Not tainted 2.6.24-rc7-rt2-99 #1
  [...]
 
  And because of mcount-add-basic-support-for-gcc-profiler-instrum.patch,
  closed source nvidia-new module cannot be used with this release (mcount
  is exported GPL only), i know this is not supported but i used it with
  that [2] patch up until now without a single problem.

 Ah, sorry about that. I'll try to fix that later on. You should still be
 able to use NVidia by turning off function trace.

Wonderfull news :) [and yes turning off function trace works]

  Please don't misunderstand this, i really do not want to start a
  discussion for this, i just want to ask the possibility of converting
  this into EXPORT_SYMBOL cause i thought some of the possible -rt users
  may need this closed source module explicitly because of its 3D
  performance.
 
  If anything else needed for sysfs warnings please just say it...
 
  [1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt
  [2]
  http://svn.pardus.org.tr/pardus/devel/kernel/drivers/nvidia-new/files/rt.
 patch

 Thanks for the report. I'll see what I can do for the next release. But
 for now this will have to wait till after -rt3.

Thanks...

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt2

2008-01-14 Thread S.Çağlar Onur
Hi;

14 Oca 2008 Pts tarihinde, Steven Rostedt şunları yazmıştı: 
> We are pleased to announce the 2.6.24-rc7-rt2 tree, which can be
> downloaded from the location:
[...]
> The broken out patches are also available.

2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit 
031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like following 
(full dmesg can be found @ [1]) when try to login from console (the other 
acpi related errors also existed in 2.6.24-rc5-rt1) and FYI, plain 2.6.24-rc7 
(again commit 031f2dcd7075e218e74dd7f942ad015cf82dffab) has no issues.

[...]
sysfs: duplicate filename 'vcs1' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Pid: 1298, comm: mingetty Not tainted 2.6.24-rc7-rt2-99 #1
[...]

And because of mcount-add-basic-support-for-gcc-profiler-instrum.patch, closed 
source nvidia-new module cannot be used with this release (mcount is exported 
GPL only), i know this is not supported but i used it with that [2] patch up 
until now without a single problem. 

Please don't misunderstand this, i really do not want to start a discussion 
for this, i just want to ask the possibility of converting this into 
EXPORT_SYMBOL cause i thought some of the possible -rt users may need this 
closed source module explicitly because of its 3D performance. 

If anything else needed for sysfs warnings please just say it...

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt
[2] 
http://svn.pardus.org.tr/pardus/devel/kernel/drivers/nvidia-new/files/rt.patch

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.24-rc7-rt1

2008-01-14 Thread S.Çağlar Onur
Hi;

14 Oca 2008 Pts tarihinde, Mike Galbraith şunları yazmıştı: 
> btw, CONFIG_INTEL_IOATDMA compile booboo
> 
>   CC  drivers/dma/ioat_dma.o
> drivers/dma/ioat_dma.c: In function ‘ioat1_tx_submit’:
> drivers/dma/ioat_dma.c:300: error: too few arguments to function 
> ‘__list_splice’
> make[2]: *** [drivers/dma/ioat_dma.o] Error 1

Following seems solves this issue;

Index: linux-2.6.23/drivers/dma/ioat_dma.c
===
--- linux-2.6.23.orig/drivers/dma/ioat_dma.c
+++ linux-2.6.23/drivers/dma/ioat_dma.c
@@ -260,7 +260,7 @@ static dma_cookie_t ioat1_tx_submit(stru
/* write address into NextDescriptor field of last desc in chain */
to_ioat_desc(ioat_chan->used_desc.prev)->hw->next =
first->async_tx.phys;
-   __list_splice(_chain, ioat_chan->used_desc.prev);
+   list_splice(_chain, _chan->used_desc);
 
ioat_chan->dmacount += desc_count;
ioat_chan->pending += desc_count;


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.24-rc7-rt1

2008-01-14 Thread S.Çağlar Onur
Hi;

14 Oca 2008 Pts tarihinde, Mike Galbraith şunları yazmıştı: 
 btw, CONFIG_INTEL_IOATDMA compile booboo
 
   CC  drivers/dma/ioat_dma.o
 drivers/dma/ioat_dma.c: In function ‘ioat1_tx_submit’:
 drivers/dma/ioat_dma.c:300: error: too few arguments to function 
 ‘__list_splice’
 make[2]: *** [drivers/dma/ioat_dma.o] Error 1

Following seems solves this issue;

Index: linux-2.6.23/drivers/dma/ioat_dma.c
===
--- linux-2.6.23.orig/drivers/dma/ioat_dma.c
+++ linux-2.6.23/drivers/dma/ioat_dma.c
@@ -260,7 +260,7 @@ static dma_cookie_t ioat1_tx_submit(stru
/* write address into NextDescriptor field of last desc in chain */
to_ioat_desc(ioat_chan-used_desc.prev)-hw-next =
first-async_tx.phys;
-   __list_splice(new_chain, ioat_chan-used_desc.prev);
+   list_splice(new_chain, ioat_chan-used_desc);
 
ioat_chan-dmacount += desc_count;
ioat_chan-pending += desc_count;


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.24-rc7-rt2

2008-01-14 Thread S.Çağlar Onur
Hi;

14 Oca 2008 Pts tarihinde, Steven Rostedt şunları yazmıştı: 
 We are pleased to announce the 2.6.24-rc7-rt2 tree, which can be
 downloaded from the location:
[...]
 The broken out patches are also available.

2.6.24-rc7-rt2 (-rt2 patchset on top of Linus's current git commit 
031f2dcd7075e218e74dd7f942ad015cf82dffab) starts to complain like following 
(full dmesg can be found @ [1]) when try to login from console (the other 
acpi related errors also existed in 2.6.24-rc5-rt1) and FYI, plain 2.6.24-rc7 
(again commit 031f2dcd7075e218e74dd7f942ad015cf82dffab) has no issues.

[...]
sysfs: duplicate filename 'vcs1' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Pid: 1298, comm: mingetty Not tainted 2.6.24-rc7-rt2-99 #1
[...]

And because of mcount-add-basic-support-for-gcc-profiler-instrum.patch, closed 
source nvidia-new module cannot be used with this release (mcount is exported 
GPL only), i know this is not supported but i used it with that [2] patch up 
until now without a single problem. 

Please don't misunderstand this, i really do not want to start a discussion 
for this, i just want to ask the possibility of converting this into 
EXPORT_SYMBOL cause i thought some of the possible -rt users may need this 
closed source module explicitly because of its 3D performance. 

If anything else needed for sysfs warnings please just say it...

[1] http://cekirdek.pardus.org.tr/~caglar/dmesg.rt
[2] 
http://svn.pardus.org.tr/pardus/devel/kernel/drivers/nvidia-new/files/rt.patch

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: Linux 2.6.24-rc6

2007-12-22 Thread S.Çağlar Onur
Hi;

21 Ara 2007 Cum tarihinde, Linus Torvalds şunları yazmıştı: 
> Here's to a merry christmas, doing the whole druidic festival around the
> tree thing,

With -rc6, dmesg shows following Unknown symbols;

[...]
[   26.883635] Bluetooth: Core ver 2.11
[   26.913123] hci_usb: Unknown symbol hci_suspend_dev
[   26.913155] hci_usb: Unknown symbol hci_free_dev
[   26.913495] hci_usb: Unknown symbol hci_resume_dev
[   26.913566] hci_usb: Unknown symbol hci_alloc_dev
[   26.913696] hci_usb: Unknown symbol hci_unregister_dev
[   26.913775] hci_usb: Unknown symbol hci_recv_fragment
[   26.913841] hci_usb: Unknown symbol hci_register_dev
[   26.914117] hci_usb: Unknown symbol hci_suspend_dev
[   26.914148] hci_usb: Unknown symbol hci_free_dev
[   26.914477] hci_usb: Unknown symbol hci_resume_dev
[   26.914548] hci_usb: Unknown symbol hci_alloc_dev
[   26.914678] hci_usb: Unknown symbol hci_unregister_dev
[   26.914757] hci_usb: Unknown symbol hci_recv_fragment
[   26.914823] hci_usb: Unknown symbol hci_register_dev
[   26.915070] hci_usb: Unknown symbol hci_suspend_dev
[   26.915101] hci_usb: Unknown symbol hci_free_dev
[   26.915429] hci_usb: Unknown symbol hci_resume_dev
[   26.915501] hci_usb: Unknown symbol hci_alloc_dev
[   26.915630] hci_usb: Unknown symbol hci_unregister_dev
[   26.915709] hci_usb: Unknown symbol hci_recv_fragment
[   26.915776] hci_usb: Unknown symbol hci_register_dev
[   26.928322] ACPI: Video Device [GFX0] (multi-head: yes  rom: no  post: no)
[   26.937433] ACPI: Thermal Zone [TZS0] (62 C)
[   26.942470] ACPI: Thermal Zone [TZS1] (66 C)
[   26.982668] NET: Registered protocol family 31
[   26.982671] Bluetooth: HCI device and connection manager initialized
[   26.982675] Bluetooth: HCI socket layer initialized
[   27.043943] Bluetooth: HCI USB driver ver 2.9
[   27.074386] usbcore: registered new interface driver hci_usb
[...]

A Google search found [1] and according to that old thread, its either a 
general module problem [2] or a module-init-tools (I'm using vanilla 
module-init-tools 3.3_pre11) problem [3]. 

I'm not sure whether its a user-space problem or these caused by bluetooth 
module's initialization phase so i decided to report LKML :). 

Although these shown in kern.log, bluetooth subsystem works without a problem.

You can find .config and full dmesg output from [4] and if anything else is 
needed, please just say it.

[1] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00043.html
[2] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00047.html
[3] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00054.html
[4] http://cekirdek.pardus.org.tr/~caglar/kernel/

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.24-rc6

2007-12-22 Thread S.Çağlar Onur
Hi;

21 Ara 2007 Cum tarihinde, Linus Torvalds şunları yazmıştı: 
 Here's to a merry christmas, doing the whole druidic festival around the
 tree thing,

With -rc6, dmesg shows following Unknown symbols;

[...]
[   26.883635] Bluetooth: Core ver 2.11
[   26.913123] hci_usb: Unknown symbol hci_suspend_dev
[   26.913155] hci_usb: Unknown symbol hci_free_dev
[   26.913495] hci_usb: Unknown symbol hci_resume_dev
[   26.913566] hci_usb: Unknown symbol hci_alloc_dev
[   26.913696] hci_usb: Unknown symbol hci_unregister_dev
[   26.913775] hci_usb: Unknown symbol hci_recv_fragment
[   26.913841] hci_usb: Unknown symbol hci_register_dev
[   26.914117] hci_usb: Unknown symbol hci_suspend_dev
[   26.914148] hci_usb: Unknown symbol hci_free_dev
[   26.914477] hci_usb: Unknown symbol hci_resume_dev
[   26.914548] hci_usb: Unknown symbol hci_alloc_dev
[   26.914678] hci_usb: Unknown symbol hci_unregister_dev
[   26.914757] hci_usb: Unknown symbol hci_recv_fragment
[   26.914823] hci_usb: Unknown symbol hci_register_dev
[   26.915070] hci_usb: Unknown symbol hci_suspend_dev
[   26.915101] hci_usb: Unknown symbol hci_free_dev
[   26.915429] hci_usb: Unknown symbol hci_resume_dev
[   26.915501] hci_usb: Unknown symbol hci_alloc_dev
[   26.915630] hci_usb: Unknown symbol hci_unregister_dev
[   26.915709] hci_usb: Unknown symbol hci_recv_fragment
[   26.915776] hci_usb: Unknown symbol hci_register_dev
[   26.928322] ACPI: Video Device [GFX0] (multi-head: yes  rom: no  post: no)
[   26.937433] ACPI: Thermal Zone [TZS0] (62 C)
[   26.942470] ACPI: Thermal Zone [TZS1] (66 C)
[   26.982668] NET: Registered protocol family 31
[   26.982671] Bluetooth: HCI device and connection manager initialized
[   26.982675] Bluetooth: HCI socket layer initialized
[   27.043943] Bluetooth: HCI USB driver ver 2.9
[   27.074386] usbcore: registered new interface driver hci_usb
[...]

A Google search found [1] and according to that old thread, its either a 
general module problem [2] or a module-init-tools (I'm using vanilla 
module-init-tools 3.3_pre11) problem [3]. 

I'm not sure whether its a user-space problem or these caused by bluetooth 
module's initialization phase so i decided to report LKML :). 

Although these shown in kern.log, bluetooth subsystem works without a problem.

You can find .config and full dmesg output from [4] and if anything else is 
needed, please just say it.

[1] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00043.html
[2] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00047.html
[3] http://osdir.com/ml/linux.bluez.devel/2004-10/msg00054.html
[4] http://cekirdek.pardus.org.tr/~caglar/kernel/

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/dma/ioat_dma.c: inlining failed

2007-12-14 Thread S.Çağlar Onur
Hi;

After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves 
following compiliation error with gcc-3.4.6. Following patch solves this issue 
for me;


[...]
  CC [M]  drivers/dma/ioat.o
  CC [M]  drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to 
'__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
index c1c2dcc..1d66b82 100644
--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -173,10 +173,25 @@ static void ioat_set_dest(dma_addr_t addr,
tx_to_ioat_desc(tx)->dst = addr;
 }
 
+/**
+ * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
+ * descriptors to hw
+ * @chan: DMA channel handle
+ */
 static inline void __ioat1_dma_memcpy_issue_pending(
-  struct ioat_dma_chan *ioat_chan);
+   struct ioat_dma_chan *ioat_chan)
+{
+   ioat_chan->pending = 0;
+   writeb(IOAT_CHANCMD_APPEND, ioat_chan->reg_base + IOAT1_CHANCMD_OFFSET);
+}
+
 static inline void __ioat2_dma_memcpy_issue_pending(
-  struct ioat_dma_chan *ioat_chan);
+   struct ioat_dma_chan *ioat_chan)
+{
+   ioat_chan->pending = 0;
+   writew(ioat_chan->dmacount,
+  ioat_chan->reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
+}
 
 static dma_cookie_t ioat1_tx_submit(struct dma_async_tx_descriptor *tx)
 {
@@ -700,18 +715,6 @@ static struct dma_async_tx_descriptor 
*ioat2_dma_prep_memcpy(
 }
 
 
-/**
- * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
- * descriptors to hw
- * @chan: DMA channel handle
- */
-static inline void __ioat1_dma_memcpy_issue_pending(
-   struct ioat_dma_chan *ioat_chan)
-{
-   ioat_chan->pending = 0;
-   writeb(IOAT_CHANCMD_APPEND, ioat_chan->reg_base + IOAT1_CHANCMD_OFFSET);
-}
-
 static void ioat1_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
@@ -723,14 +726,6 @@ static void ioat1_dma_memcpy_issue_pending(struct dma_chan 
*chan)
}
 }
 
-static inline void __ioat2_dma_memcpy_issue_pending(
-   struct ioat_dma_chan *ioat_chan)
-{
-   ioat_chan->pending = 0;
-   writew(ioat_chan->dmacount,
-  ioat_chan->reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
-}
-
 static void ioat2_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/dma/ioat_dma.c: inlining failed

2007-12-14 Thread S.Çağlar Onur
Hi;

After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves 
following compiliation error with gcc-3.4.6. Following patch solves this issue 
for me;


[...]
  CC [M]  drivers/dma/ioat.o
  CC [M]  drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to 
'__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
index c1c2dcc..1d66b82 100644
--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -173,10 +173,25 @@ static void ioat_set_dest(dma_addr_t addr,
tx_to_ioat_desc(tx)-dst = addr;
 }
 
+/**
+ * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
+ * descriptors to hw
+ * @chan: DMA channel handle
+ */
 static inline void __ioat1_dma_memcpy_issue_pending(
-  struct ioat_dma_chan *ioat_chan);
+   struct ioat_dma_chan *ioat_chan)
+{
+   ioat_chan-pending = 0;
+   writeb(IOAT_CHANCMD_APPEND, ioat_chan-reg_base + IOAT1_CHANCMD_OFFSET);
+}
+
 static inline void __ioat2_dma_memcpy_issue_pending(
-  struct ioat_dma_chan *ioat_chan);
+   struct ioat_dma_chan *ioat_chan)
+{
+   ioat_chan-pending = 0;
+   writew(ioat_chan-dmacount,
+  ioat_chan-reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
+}
 
 static dma_cookie_t ioat1_tx_submit(struct dma_async_tx_descriptor *tx)
 {
@@ -700,18 +715,6 @@ static struct dma_async_tx_descriptor 
*ioat2_dma_prep_memcpy(
 }
 
 
-/**
- * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
- * descriptors to hw
- * @chan: DMA channel handle
- */
-static inline void __ioat1_dma_memcpy_issue_pending(
-   struct ioat_dma_chan *ioat_chan)
-{
-   ioat_chan-pending = 0;
-   writeb(IOAT_CHANCMD_APPEND, ioat_chan-reg_base + IOAT1_CHANCMD_OFFSET);
-}
-
 static void ioat1_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
@@ -723,14 +726,6 @@ static void ioat1_dma_memcpy_issue_pending(struct dma_chan 
*chan)
}
 }
 
-static inline void __ioat2_dma_memcpy_issue_pending(
-   struct ioat_dma_chan *ioat_chan)
-{
-   ioat_chan-pending = 0;
-   writew(ioat_chan-dmacount,
-  ioat_chan-reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
-}
-
 static void ioat2_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] error: implicit declaration of function `get_softnet_dma'

2007-10-26 Thread S.Çağlar Onur
Hi;

Following trivial patch corrects 

[EMAIL PROTECTED] linux-2.6 $ make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CALLscripts/checksyscalls.sh
  CHK include/linux/compile.h
  LD  net/ipv6/built-in.o
  CC [M]  net/ipv6/tcp_ipv6.o
net/ipv6/tcp_ipv6.c: In function `tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function 
`get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer 
without a cast
make[2]: *** [net/ipv6/tcp_ipv6.o] Hata 1
make[1]: *** [net/ipv6] Hata 2
make: *** [net] Hata 2

compiliation error for current Linus's git tree

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 06fa4ba..8520802 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -59,6 +59,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] error: implicit declaration of function `get_softnet_dma'

2007-10-26 Thread S.Çağlar Onur
Hi;

Following trivial patch corrects 

[EMAIL PROTECTED] linux-2.6 $ make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CALLscripts/checksyscalls.sh
  CHK include/linux/compile.h
  LD  net/ipv6/built-in.o
  CC [M]  net/ipv6/tcp_ipv6.o
net/ipv6/tcp_ipv6.c: In function `tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function 
`get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer 
without a cast
make[2]: *** [net/ipv6/tcp_ipv6.o] Hata 1
make[1]: *** [net/ipv6] Hata 2
make: *** [net] Hata 2

compiliation error for current Linus's git tree

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 06fa4ba..8520802 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -59,6 +59,7 @@
 #include net/snmp.h
 #include net/dsfield.h
 #include net/timewait_sock.h
+#include net/netdma.h
 
 #include asm/uaccess.h
 
Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-26 Thread S.Çağlar Onur
26 Eyl 2007 Çar tarihinde, Ingo Molnar şunları yazmıştı: 
> By popular demand, here is release -v22 of the CFS scheduler. It is a
> full backport of the latest & greatest sched-devel.git code to
> v2.6.23-rc8, v2.6.22.8, v2.6.21.7 and v2.6.20.20. The patches can be
> downloaded from the usual place:
>
> http://people.redhat.com/mingo/cfs-scheduler/
>
> This is the first time the development version of the scheduler has been
> fed back into the stable backport series, so there's many changes since
> v20.5:

Compilation [against 2.6.20.20] fails with

buildfarm linux-2.6.20 # make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CHK include/linux/compile.h
  CC  kernel/sched.o
In file included from kernel/sched.c:850:
kernel/sched_fair.c:49: error: sysctl_sched_nr_latency causes a section type 
conflict
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2

@kernel/sched_fair.c
-const_debug unsigned int sysctl_sched_nr_latency __read_mostly = 20;
+const_debug unsigned int sysctl_sched_nr_latency = 20;

seems solve that issue but i'm not sure this is the right thing to do or 
not :)

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent drivers/char/hpet.c build warnings on i386

2007-09-26 Thread S.Çağlar Onur
Following patch silents;

...
drivers/char/hpet.c:72: warning: 'clocksource_hpet' defined but not used
drivers/char/hpet.c:81: warning: 'hpet_clocksource' defined but not used
...

build warnings on i386, they appeared after commit 
3b2b64fd311c92f2137eb7cee7025794cd854057

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 drivers/char/hpet.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 7ecffc9..b86d84a 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -62,6 +62,8 @@
 
 static u32 hpet_nhpet, hpet_max_freq = HPET_USER_FREQ;
 
+/* This clocksource driver currently only works on ia64 */
+#ifdef CONFIG_IA64
 static void __iomem *hpet_mctr;
 
 static cycle_t read_hpet(void)
@@ -79,6 +81,7 @@ static struct clocksource clocksource_hpet = {
 .flags  = CLOCK_SOURCE_IS_CONTINUOUS,
 };
 static struct clocksource *hpet_clocksource;
+#endif
 
 /* A lock for concurrent access by app and isr hpet activity. */
 static DEFINE_SPINLOCK(hpet_lock);


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Silent drivers/char/hpet.c build warnings on i386

2007-09-26 Thread S.Çağlar Onur
Following patch silents;

...
drivers/char/hpet.c:72: warning: 'clocksource_hpet' defined but not used
drivers/char/hpet.c:81: warning: 'hpet_clocksource' defined but not used
...

build warnings on i386, they appeared after commit 
3b2b64fd311c92f2137eb7cee7025794cd854057

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 drivers/char/hpet.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 7ecffc9..b86d84a 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -62,6 +62,8 @@
 
 static u32 hpet_nhpet, hpet_max_freq = HPET_USER_FREQ;
 
+/* This clocksource driver currently only works on ia64 */
+#ifdef CONFIG_IA64
 static void __iomem *hpet_mctr;
 
 static cycle_t read_hpet(void)
@@ -79,6 +81,7 @@ static struct clocksource clocksource_hpet = {
 .flags  = CLOCK_SOURCE_IS_CONTINUOUS,
 };
 static struct clocksource *hpet_clocksource;
+#endif
 
 /* A lock for concurrent access by app and isr hpet activity. */
 static DEFINE_SPINLOCK(hpet_lock);


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-26 Thread S.Çağlar Onur
26 Eyl 2007 Çar tarihinde, Ingo Molnar şunları yazmıştı: 
 By popular demand, here is release -v22 of the CFS scheduler. It is a
 full backport of the latest  greatest sched-devel.git code to
 v2.6.23-rc8, v2.6.22.8, v2.6.21.7 and v2.6.20.20. The patches can be
 downloaded from the usual place:

 http://people.redhat.com/mingo/cfs-scheduler/

 This is the first time the development version of the scheduler has been
 fed back into the stable backport series, so there's many changes since
 v20.5:

Compilation [against 2.6.20.20] fails with

buildfarm linux-2.6.20 # make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CHK include/linux/compile.h
  CC  kernel/sched.o
In file included from kernel/sched.c:850:
kernel/sched_fair.c:49: error: sysctl_sched_nr_latency causes a section type 
conflict
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2

@kernel/sched_fair.c
-const_debug unsigned int sysctl_sched_nr_latency __read_mostly = 20;
+const_debug unsigned int sysctl_sched_nr_latency = 20;

seems solve that issue but i'm not sure this is the right thing to do or 
not :)

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [git] CFS-devel, latest code

2007-09-25 Thread S.Çağlar Onur
Hi;

25 Eyl 2007 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
> 
> The latest sched-devel.git tree can be pulled from:
>  
>   
> git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git
> 
> Lots of scheduler updates in the past few days, done by many people. 
> Most importantly, the SMP latency problems reported and debugged by Mike 
> Galbraith should be fixed for good now.
> 
> I've also included the latest and greatest group-fairness scheduling 
> patch from Srivatsa Vaddagiri, which can now be used without containers 
> as well (in a simplified, each-uid-gets-its-fair-share mode). This 
> feature (CONFIG_FAIR_USER_SCHED) is now default-enabled.
> 
> Peter Zijlstra has been busy enhancing the math of the scheduler: we've 
> got the new 'vslice' forked-task code that should enable snappier shell 
> commands during load while still keeping kbuild workloads in check.
> 
> On my testsystems this codebase starts looking like something that could 
> be merged into v2.6.24, so please give it a good workout and let us know 
> if there's anything bad going on. (If this works out fine then i'll 
> propagate these changes back into the CFS backport, for wider testing.)

Seems like following trivial change needed to compile without CONFIG_SCHEDSTATS

[EMAIL PROTECTED] linux-2.6 $ LC_ALL=C make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CALLscripts/checksyscalls.sh
  CHK include/linux/compile.h
  CC  kernel/sched.o
In file included from kernel/sched.c:853:
kernel/sched_debug.c: In function `print_cfs_rq':
kernel/sched_debug.c:139: error: structure has no member named `bkl_cnt'
kernel/sched_debug.c:139: error: structure has no member named `bkl_cnt'
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

diff --git a/kernel/sched_debug.c b/kernel/sched_debug.c
index b68e593..4659c90 100644
--- a/kernel/sched_debug.c
+++ b/kernel/sched_debug.c
@@ -136,8 +136,10 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct 
cfs_rq *cfs_rq)
SPLIT_NS(spread0));
SEQ_printf(m, "  .%-30s: %ld\n", "nr_running", cfs_rq->nr_running);
SEQ_printf(m, "  .%-30s: %ld\n", "load", cfs_rq->load.weight);
+#ifdef CONFIG_SCHEDSTATS
SEQ_printf(m, "  .%-30s: %ld\n", "bkl_cnt",
rq->bkl_cnt);
+#endif
SEQ_printf(m, "  .%-30s: %ld\n", "nr_spread_over",
cfs_rq->nr_spread_over);
 }


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [git] CFS-devel, latest code

2007-09-25 Thread S.Çağlar Onur
Hi;

25 Eyl 2007 Sal tarihinde, Ingo Molnar şunları yazmıştı: 
 
 The latest sched-devel.git tree can be pulled from:
  
   
 git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git
 
 Lots of scheduler updates in the past few days, done by many people. 
 Most importantly, the SMP latency problems reported and debugged by Mike 
 Galbraith should be fixed for good now.
 
 I've also included the latest and greatest group-fairness scheduling 
 patch from Srivatsa Vaddagiri, which can now be used without containers 
 as well (in a simplified, each-uid-gets-its-fair-share mode). This 
 feature (CONFIG_FAIR_USER_SCHED) is now default-enabled.
 
 Peter Zijlstra has been busy enhancing the math of the scheduler: we've 
 got the new 'vslice' forked-task code that should enable snappier shell 
 commands during load while still keeping kbuild workloads in check.
 
 On my testsystems this codebase starts looking like something that could 
 be merged into v2.6.24, so please give it a good workout and let us know 
 if there's anything bad going on. (If this works out fine then i'll 
 propagate these changes back into the CFS backport, for wider testing.)

Seems like following trivial change needed to compile without CONFIG_SCHEDSTATS

[EMAIL PROTECTED] linux-2.6 $ LC_ALL=C make
  CHK include/linux/version.h
  CHK include/linux/utsrelease.h
  CALLscripts/checksyscalls.sh
  CHK include/linux/compile.h
  CC  kernel/sched.o
In file included from kernel/sched.c:853:
kernel/sched_debug.c: In function `print_cfs_rq':
kernel/sched_debug.c:139: error: structure has no member named `bkl_cnt'
kernel/sched_debug.c:139: error: structure has no member named `bkl_cnt'
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

diff --git a/kernel/sched_debug.c b/kernel/sched_debug.c
index b68e593..4659c90 100644
--- a/kernel/sched_debug.c
+++ b/kernel/sched_debug.c
@@ -136,8 +136,10 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct 
cfs_rq *cfs_rq)
SPLIT_NS(spread0));
SEQ_printf(m,   .%-30s: %ld\n, nr_running, cfs_rq-nr_running);
SEQ_printf(m,   .%-30s: %ld\n, load, cfs_rq-load.weight);
+#ifdef CONFIG_SCHEDSTATS
SEQ_printf(m,   .%-30s: %ld\n, bkl_cnt,
rq-bkl_cnt);
+#endif
SEQ_printf(m,   .%-30s: %ld\n, nr_spread_over,
cfs_rq-nr_spread_over);
 }


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: hci_sock.c build failure

2007-09-12 Thread S.Çağlar Onur
12 Eyl 2007 Çar tarihinde, Greg KH şunları yazmıştı: 
> No, this is worse, i386 doesn't have a compat_timeval structure defined,
> nor does any other 32 bit platform.
> 
> Marcel, I think you need to use a different structure, care to fix this
> up?

I sent a patch for this problem about ~4 hours ago :), see "[PATCH] Fix 
hci_sock build with CONFIG_COMPAT=n"

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix hci_sock build with CONFIG_COMPAT=n

2007-09-12 Thread S.Çağlar Onur
Hi;

Commit 66eb50d5c972cc16df2be730497b7f06d75d8132 introduces runtime check of 
CONFIG_COMPAT but without following patch compiliation failed with following 
error;

...
  CC [M]  net/bluetooth/hci_event.o
  CC [M]  net/bluetooth/hci_sock.o
net/bluetooth/hci_sock.c: In function `hci_sock_cmsg':
net/bluetooth/hci_sock.c:352: error: storage size of 'ctv' isn't known
net/bluetooth/hci_sock.c:352: warning: unused variable `ctv'
make[2]: *** [net/bluetooth/hci_sock.o] Hata 1
make[1]: *** [net/bluetooth] Hata 2
make: *** [net] Hata 2

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 net/bluetooth/hci_sock.c |5 -
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index d16ca8e..1364a90 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -347,7 +347,7 @@ static inline void hci_sock_cmsg(struct sock *sk, struct 
msghdr *msg, struct sk_
int len;
 
skb_get_timestamp(skb, );
-
+#ifdef CONFIG_COMPAT
if (msg->msg_flags & MSG_CMSG_COMPAT) {
struct compat_timeval ctv;
ctv.tv_sec = tv.tv_sec;
@@ -355,9 +355,12 @@ static inline void hci_sock_cmsg(struct sock *sk, struct 
msghdr *msg, struct sk_
data = 
len = sizeof(ctv);
} else {
+#endif
data = 
len = sizeof(tv);
+#ifdef CONFIG_COMPAT
}
+#endif
 
put_cmsg(msg, SOL_HCI, HCI_CMSG_TSTAMP, len, data);
}


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Fix hci_sock build with CONFIG_COMPAT=n

2007-09-12 Thread S.Çağlar Onur
Hi;

Commit 66eb50d5c972cc16df2be730497b7f06d75d8132 introduces runtime check of 
CONFIG_COMPAT but without following patch compiliation failed with following 
error;

...
  CC [M]  net/bluetooth/hci_event.o
  CC [M]  net/bluetooth/hci_sock.o
net/bluetooth/hci_sock.c: In function `hci_sock_cmsg':
net/bluetooth/hci_sock.c:352: error: storage size of 'ctv' isn't known
net/bluetooth/hci_sock.c:352: warning: unused variable `ctv'
make[2]: *** [net/bluetooth/hci_sock.o] Hata 1
make[1]: *** [net/bluetooth] Hata 2
make: *** [net] Hata 2

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 net/bluetooth/hci_sock.c |5 -
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index d16ca8e..1364a90 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -347,7 +347,7 @@ static inline void hci_sock_cmsg(struct sock *sk, struct 
msghdr *msg, struct sk_
int len;
 
skb_get_timestamp(skb, tv);
-
+#ifdef CONFIG_COMPAT
if (msg-msg_flags  MSG_CMSG_COMPAT) {
struct compat_timeval ctv;
ctv.tv_sec = tv.tv_sec;
@@ -355,9 +355,12 @@ static inline void hci_sock_cmsg(struct sock *sk, struct 
msghdr *msg, struct sk_
data = ctv;
len = sizeof(ctv);
} else {
+#endif
data = tv;
len = sizeof(tv);
+#ifdef CONFIG_COMPAT
}
+#endif
 
put_cmsg(msg, SOL_HCI, HCI_CMSG_TSTAMP, len, data);
}


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi Again;

04 Eyl 2007 Sal tarihinde, S.Çağlar Onur şunları yazmıştı: 
> Hi;
>
> 01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı:
> > So have fun, give it a go, and expect a quiet week next week.
>
> After upgrading -rc5 (i'm currently using linus's latest git + appArmor and
> bootsplash patchset) my CD/DVD-ROM suddenly disappeared :).
>
> [EMAIL PROTECTED] ~ $ diff -u rc4 rc5 | grep cd-rom -i
> -Sep  3 11:30:33 localhost kernel: [   19.328120] scsi 4:0:0:0: CD-ROM
> MATSHITA DVD-RAM UJ-851S  1.50 PQ: 0 ANSI: 5
> -Sep  3 11:30:33 localhost kernel: [   21.258819] Uniform CD-ROM driver
> Revision: 3.20
> -Sep  3 11:30:33 localhost kernel: [   21.258873] sr 4:0:0:0: Attached scsi
> CD-ROM sr0

Forget it :), it was a hardware problem caused by cdrom bay

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi;

01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı: 
> So have fun, give it a go, and expect a quiet week next week.

After upgrading -rc5 (i'm currently using linus's latest git + appArmor and 
bootsplash patchset) my CD/DVD-ROM suddenly disappeared :). 

[EMAIL PROTECTED] ~ $ diff -u rc4 rc5 | grep cd-rom -i
-Sep  3 11:30:33 localhost kernel: [   19.328120] scsi 4:0:0:0: CD-ROM  
  
MATSHITA DVD-RAM UJ-851S  1.50 PQ: 0 ANSI: 5
-Sep  3 11:30:33 localhost kernel: [   21.258819] Uniform CD-ROM driver 
Revision: 3.20
-Sep  3 11:30:33 localhost kernel: [   21.258873] sr 4:0:0:0: Attached scsi 
CD-ROM sr0

You can find the logs and config from [1], i'm on a vacation with unstable 
network connection so i may not respond fast enough and i don't have enough 
time to bisect for a while :(.

[1] http://cekirdek.pardus.org.tr/~caglar/kernel/

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi;

01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı: 
 So have fun, give it a go, and expect a quiet week next week.

After upgrading -rc5 (i'm currently using linus's latest git + appArmor and 
bootsplash patchset) my CD/DVD-ROM suddenly disappeared :). 

[EMAIL PROTECTED] ~ $ diff -u rc4 rc5 | grep cd-rom -i
-Sep  3 11:30:33 localhost kernel: [   19.328120] scsi 4:0:0:0: CD-ROM  
  
MATSHITA DVD-RAM UJ-851S  1.50 PQ: 0 ANSI: 5
-Sep  3 11:30:33 localhost kernel: [   21.258819] Uniform CD-ROM driver 
Revision: 3.20
-Sep  3 11:30:33 localhost kernel: [   21.258873] sr 4:0:0:0: Attached scsi 
CD-ROM sr0

You can find the logs and config from [1], i'm on a vacation with unstable 
network connection so i may not respond fast enough and i don't have enough 
time to bisect for a while :(.

[1] http://cekirdek.pardus.org.tr/~caglar/kernel/

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi Again;

04 Eyl 2007 Sal tarihinde, S.Çağlar Onur şunları yazmıştı: 
 Hi;

 01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı:
  So have fun, give it a go, and expect a quiet week next week.

 After upgrading -rc5 (i'm currently using linus's latest git + appArmor and
 bootsplash patchset) my CD/DVD-ROM suddenly disappeared :).

 [EMAIL PROTECTED] ~ $ diff -u rc4 rc5 | grep cd-rom -i
 -Sep  3 11:30:33 localhost kernel: [   19.328120] scsi 4:0:0:0: CD-ROM
 MATSHITA DVD-RAM UJ-851S  1.50 PQ: 0 ANSI: 5
 -Sep  3 11:30:33 localhost kernel: [   21.258819] Uniform CD-ROM driver
 Revision: 3.20
 -Sep  3 11:30:33 localhost kernel: [   21.258873] sr 4:0:0:0: Attached scsi
 CD-ROM sr0

Forget it :), it was a hardware problem caused by cdrom bay

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Remove unusued edac_reset_delay_period function

2007-07-21 Thread S.Çağlar Onur
Hi;

Following patch removes unused [1] edac_reset_delay_period function to silent

drivers/edac/edac_mc.c:334: warning: 'edac_reset_delay_period' defined but not 
used

compile warning.

[1] 
[EMAIL PROTECTED] linux-2.6 $ grep edac_reset_delay_period * -r
drivers/edac/edac_mc.c: * edac_reset_delay_period
drivers/edac/edac_mc.c:static void edac_reset_delay_period(struct mem_ctl_info 
*mci, unsigned long value)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 drivers/edac/edac_mc.c |   17 -
 1 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 4471be3..c36a19a 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -327,23 +327,6 @@ static void edac_mc_workq_teardown(struct mem_ctl_info 
*mci)
}
 }
 
-/*
- * edac_reset_delay_period
- */
-static void edac_reset_delay_period(struct mem_ctl_info *mci, unsigned long 
value)
-{
-   /* cancel the current workq request */
-   edac_mc_workq_teardown(mci);
-
-   /* lock the list of devices for the new setup */
-   mutex_lock(_ctls_mutex);
-
-   /* restart the workq request, with new delay value */
-   edac_mc_workq_setup(mci, value);
-
-   mutex_unlock(_ctls_mutex);
-}
-
 /* Return 0 on success, 1 on failure.
  * Before calling this function, caller must
  * assign a unique value to mci->mc_idx.

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/char/hpet.c: integer constant is too large for "long" type

2007-07-21 Thread S.Çağlar Onur
Hi;

Following trivial patch silents

drivers/char/hpet.c:76: warning: integer constant is too large for "long" type

warning (with gcc-3.4.6)

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
 
 drivers/char/hpet.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index ba0e74a..23fadf5 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -73,7 +73,7 @@ static struct clocksource clocksource_hpet = {
 .name   = "hpet",
 .rating = 250,
 .read   = read_hpet,
-.mask   = 0x,
+.mask   = 0xLL,
 .mult   = 0, /*to be caluclated*/
 .shift  = 10,
 .flags  = CLOCK_SOURCE_IS_CONTINUOUS,

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] drivers/char/hpet.c: integer constant is too large for long type

2007-07-21 Thread S.Çağlar Onur
Hi;

Following trivial patch silents

drivers/char/hpet.c:76: warning: integer constant is too large for long type

warning (with gcc-3.4.6)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]
 
 drivers/char/hpet.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index ba0e74a..23fadf5 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -73,7 +73,7 @@ static struct clocksource clocksource_hpet = {
 .name   = hpet,
 .rating = 250,
 .read   = read_hpet,
-.mask   = 0x,
+.mask   = 0xLL,
 .mult   = 0, /*to be caluclated*/
 .shift  = 10,
 .flags  = CLOCK_SOURCE_IS_CONTINUOUS,

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Remove unusued edac_reset_delay_period function

2007-07-21 Thread S.Çağlar Onur
Hi;

Following patch removes unused [1] edac_reset_delay_period function to silent

drivers/edac/edac_mc.c:334: warning: 'edac_reset_delay_period' defined but not 
used

compile warning.

[1] 
[EMAIL PROTECTED] linux-2.6 $ grep edac_reset_delay_period * -r
drivers/edac/edac_mc.c: * edac_reset_delay_period
drivers/edac/edac_mc.c:static void edac_reset_delay_period(struct mem_ctl_info 
*mci, unsigned long value)

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

 drivers/edac/edac_mc.c |   17 -
 1 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 4471be3..c36a19a 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -327,23 +327,6 @@ static void edac_mc_workq_teardown(struct mem_ctl_info 
*mci)
}
 }
 
-/*
- * edac_reset_delay_period
- */
-static void edac_reset_delay_period(struct mem_ctl_info *mci, unsigned long 
value)
-{
-   /* cancel the current workq request */
-   edac_mc_workq_teardown(mci);
-
-   /* lock the list of devices for the new setup */
-   mutex_lock(mem_ctls_mutex);
-
-   /* restart the workq request, with new delay value */
-   edac_mc_workq_setup(mci, value);
-
-   mutex_unlock(mem_ctls_mutex);
-}
-
 /* Return 0 on success, 1 on failure.
  * Before calling this function, caller must
  * assign a unique value to mci-mc_idx.

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread S.Çağlar Onur
Hi; 

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
> Please pull from the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
> 
> to get the following changes:
> 
> Avi Kivity (4):
>   KVM: MMU: Store nx bit for large page shadows
>   KVM: Fix memory slot management functions for guest smp
>   KVM: x86 emulator: implement rdmsr and wrmsr
>   KVM: MMU: Fix oopses with SLUB
> 
> The last commit is new since the last pull request.

With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
sometimes 
ends up like [1], this occured as soon as qemu window closed.

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-20 Thread S.Çağlar Onur
Hi;

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
> Turned out kvm and slub didn't like each other.  Please try applying
> these two patches, in order:
> 
>   http://people.qumranet.com:/avi/kvm-late-fixes-rollup.patch
>   http://people.qumranet.com:/avi/kvm-vs-slub-fix.patch

Yep, these solved the problems, thanks!

Tested-by: S.Çağlar Onur <[EMAIL PROTECTED]>

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-20 Thread S.Çağlar Onur
Hi;

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
 Turned out kvm and slub didn't like each other.  Please try applying
 these two patches, in order:
 
   http://people.qumranet.com:/avi/kvm-late-fixes-rollup.patch
   http://people.qumranet.com:/avi/kvm-vs-slub-fix.patch

Yep, these solved the problems, thanks!

Tested-by: S.Çağlar Onur [EMAIL PROTECTED]

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread S.Çağlar Onur
Hi; 

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
 Please pull from the git repository at:
 
   git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
 
 to get the following changes:
 
 Avi Kivity (4):
   KVM: MMU: Store nx bit for large page shadows
   KVM: Fix memory slot management functions for guest smp
   KVM: x86 emulator: implement rdmsr and wrmsr
   KVM: MMU: Fix oopses with SLUB
 
 The last commit is new since the last pull request.

With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
sometimes 
ends up like [1], this occured as soon as qemu window closed.

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


[PATCH] Remove -static from Documentation/lguest/Makefile

2007-07-19 Thread S.Çağlar Onur
Hi;

Remove -static from Documentation/lguest/Makefile, most distros only provides 
shared library form of zlib in their default installation. 
And shared linking also provides litte tiny security for hypotetical security 
problems will be introduced by zlib :).

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

Documentation/lguest/Makefile |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/lguest/Makefile b/Documentation/lguest/Makefile
index b9b9427..2331179 100644
--- a/Documentation/lguest/Makefile
+++ b/Documentation/lguest/Makefile
@@ -12,7 +12,7 @@ include $(KBUILD_OUTPUT)/.config
 LGUEST_GUEST_TOP := ($(CONFIG_PAGE_OFFSET) - 0x0800)
 
 CFLAGS:=-Wall -Wmissing-declarations -Wmissing-prototypes -O3 \
-   -static -DLGUEST_GUEST_TOP="$(LGUEST_GUEST_TOP)" -Wl,-T,lguest.lds
+   -DLGUEST_GUEST_TOP="$(LGUEST_GUEST_TOP)" -Wl,-T,lguest.lds
 LDLIBS:=-lz
 
 all: lguest.lds lguest

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread S.Çağlar Onur
Hi Michal;

19 Tem 2007 Per tarihinde, Michal Piotrowski şunları yazmıştı: 
> Block layer
>
> Subject : bsg.c:(.init.text+0x43d): undefined reference to
> `scsi_register_interface' References  :
> http://lkml.org/lkml/2007/7/16/343
> Last known good : ?
> Submitter   : Larry Finger <[EMAIL PROTECTED]>
> Caused-By   : ?
> Handled-By  : S.Çağlar Onur <[EMAIL PROTECTED]>
> Patch   : http://lkml.org/lkml/2007/7/16/380
> Status  : patch available

After a off-list discussion this was solved with Linus's commit [1], so please 
drop that one

[1] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=29417b899a77aaba1c060f5e123db4f50006f58a

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread S.Çağlar Onur
Hi Michal;

19 Tem 2007 Per tarihinde, Michal Piotrowski şunları yazmıştı: 
 Block layer

 Subject : bsg.c:(.init.text+0x43d): undefined reference to
 `scsi_register_interface' References  :
 http://lkml.org/lkml/2007/7/16/343
 Last known good : ?
 Submitter   : Larry Finger [EMAIL PROTECTED]
 Caused-By   : ?
 Handled-By  : S.Çağlar Onur [EMAIL PROTECTED]
 Patch   : http://lkml.org/lkml/2007/7/16/380
 Status  : patch available

After a off-list discussion this was solved with Linus's commit [1], so please 
drop that one

[1] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=29417b899a77aaba1c060f5e123db4f50006f58a

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


[PATCH] Remove -static from Documentation/lguest/Makefile

2007-07-19 Thread S.Çağlar Onur
Hi;

Remove -static from Documentation/lguest/Makefile, most distros only provides 
shared library form of zlib in their default installation. 
And shared linking also provides litte tiny security for hypotetical security 
problems will be introduced by zlib :).

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]

Documentation/lguest/Makefile |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/lguest/Makefile b/Documentation/lguest/Makefile
index b9b9427..2331179 100644
--- a/Documentation/lguest/Makefile
+++ b/Documentation/lguest/Makefile
@@ -12,7 +12,7 @@ include $(KBUILD_OUTPUT)/.config
 LGUEST_GUEST_TOP := ($(CONFIG_PAGE_OFFSET) - 0x0800)
 
 CFLAGS:=-Wall -Wmissing-declarations -Wmissing-prototypes -O3 \
-   -static -DLGUEST_GUEST_TOP=$(LGUEST_GUEST_TOP) -Wl,-T,lguest.lds
+   -DLGUEST_GUEST_TOP=$(LGUEST_GUEST_TOP) -Wl,-T,lguest.lds
 LDLIBS:=-lz
 
 all: lguest.lds lguest

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Alexey Dobriyan şunları yazmıştı: 
> *.orig are generated even if line numbers change a bit, so untrusted is
> a somewhat exaggerated.

:), although i prefer previous one, what about something like following?


With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts 
to ignore any *.rej files (for example "git status" cannot show what are 
they) but if there are some *.rej files exists, for whatever reason, that 
means some unresolved merge conflicts occured for that code tree and this 
tree is no longer trusted so better not to ignore this.

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
 
 .gitignore |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8d15830..e3a56e4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -47,4 +47,3 @@ series
 cscope.*
 
 *.orig
-*.rej

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi;

With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts 
to ignore any *.orig or *.rej files (for example "git status" cannot show 
what are they) but if there are some *.orig or *.rej files exists, for 
whatever reason, that means some unresolved merge conflicts occured for that 
code tree and this tree is no longer trusted so better not to ignore these.

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
 
 .gitignore |3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8d15830..060a71d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,6 +45,3 @@ series
 
 # cscope files
 cscope.*
-
-*.orig
-*.rej


Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi Avi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
> This trace is certainly a kvm bug.  What guest are you running?  If it
> is free (and does not contain private information), can you post it
> somewhere for me to download?

After seeing your "[PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64" mail i 
applied it on top of Linus's current git and disabled HIGHMEM64 (following is 
the diff between configs)

[EMAIL PROTECTED] linux-2.6 $ diff -u config .config
--- config  2007-07-18 12:34:36.0 +0300
+++ .config 2007-07-18 19:47:56.0 +0300
@@ -1,7 +1,7 @@
 #
 # Automatically generated make config: don't edit
 # Linux kernel version: 2.6.22
-# Wed Jul 18 02:32:10 2007
+# Wed Jul 18 19:47:56 2007
 #
 CONFIG_X86_32=y
 CONFIG_GENERIC_TIME=y
@@ -200,11 +200,10 @@
 CONFIG_DCDBAS=m
 CONFIG_DMIID=y
 # CONFIG_NOHIGHMEM is not set
-# CONFIG_HIGHMEM4G is not set
-CONFIG_HIGHMEM64G=y
+CONFIG_HIGHMEM4G=y
+# CONFIG_HIGHMEM64G is not set
 CONFIG_PAGE_OFFSET=0xC000
 CONFIG_HIGHMEM=y
-CONFIG_X86_PAE=y
 CONFIG_ARCH_FLATMEM_ENABLE=y
 CONFIG_ARCH_SPARSEMEM_ENABLE=y
 CONFIG_ARCH_SELECT_MEMORY_MODEL=y
@@ -1228,7 +1227,6 @@
 CONFIG_I2O=m
 CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=y
 CONFIG_I2O_EXT_ADAPTEC=y
-CONFIG_I2O_EXT_ADAPTEC_DMA64=y
 CONFIG_I2O_CONFIG=m
 CONFIG_I2O_CONFIG_OLD_IOCTL=y
 CONFIG_I2O_BUS=m

And this time i get another oops [1] and because my kernel is tainted by 
nvidia driver i also tried and get same with untainted one [2]. I hope they 
helps...

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/opps_tainted
[2] http://cekirdek.pardus.org.tr/~caglar/kvm/opps_not_tainted

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
> > http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the
> > vanilla one's netconsole output, by the way without apparmor patchset
> > system not hard freezes.
>
> This trace is certainly a kvm bug.  What guest are you running?  If it
> is free (and does not contain private information), can you post it
> somewhere for me to download?

I can reproduce same behaviour with fedora/opensuse/sled and pardus guests so 
i guess this is not a image problem but also if you want, i can provide a 
mini-pardus image for you to try?

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, S.Çağlar Onur şunları yazmıştı: 
> http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the
> vanilla one's netconsole output, by the way without apparmor patchset
> system not hard freezes.

Ahhh netconsole cannot grab whole output, full log from kern.log follows [1]

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/kern.log

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
> S.Çağlar Onur wrote:
> > Hi;
> >
> > 18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı:
> >> Can you reproduce without the appArmor patchset?
> >
> > If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the
> > appArmor patchset included kernel's output captured with netconsole and
> > yes i'll try to reproduce same with vanilla one whenever i found some
> > time :)
>
> It does look AppArmor related.

http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the 
vanilla one's netconsole output, by the way without apparmor patchset system 
not hard freezes.

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: 
> Can you reproduce without the appArmor patchset?

If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the appArmor 
patchset included kernel's output captured with netconsole and yes i'll try 
to reproduce same with vanilla one whenever i found some time :)

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: 
 Can you reproduce without the appArmor patchset?

If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the appArmor 
patchset included kernel's output captured with netconsole and yes i'll try 
to reproduce same with vanilla one whenever i found some time :)

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
 S.Çağlar Onur wrote:
  Hi;
 
  18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı:
  Can you reproduce without the appArmor patchset?
 
  If needed http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole is the
  appArmor patchset included kernel's output captured with netconsole and
  yes i'll try to reproduce same with vanilla one whenever i found some
  time :)

 It does look AppArmor related.

http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the 
vanilla one's netconsole output, by the way without apparmor patchset system 
not hard freezes.

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, S.Çağlar Onur şunları yazmıştı: 
 http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the
 vanilla one's netconsole output, by the way without apparmor patchset
 system not hard freezes.

Ahhh netconsole cannot grab whole output, full log from kern.log follows [1]

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/kern.log

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
  http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the
  vanilla one's netconsole output, by the way without apparmor patchset
  system not hard freezes.

 This trace is certainly a kvm bug.  What guest are you running?  If it
 is free (and does not contain private information), can you post it
 somewhere for me to download?

I can reproduce same behaviour with fedora/opensuse/sled and pardus guests so 
i guess this is not a image problem but also if you want, i can provide a 
mini-pardus image for you to try?

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi Avi;

18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: 
 This trace is certainly a kvm bug.  What guest are you running?  If it
 is free (and does not contain private information), can you post it
 somewhere for me to download?

After seeing your [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64 mail i 
applied it on top of Linus's current git and disabled HIGHMEM64 (following is 
the diff between configs)

[EMAIL PROTECTED] linux-2.6 $ diff -u config .config
--- config  2007-07-18 12:34:36.0 +0300
+++ .config 2007-07-18 19:47:56.0 +0300
@@ -1,7 +1,7 @@
 #
 # Automatically generated make config: don't edit
 # Linux kernel version: 2.6.22
-# Wed Jul 18 02:32:10 2007
+# Wed Jul 18 19:47:56 2007
 #
 CONFIG_X86_32=y
 CONFIG_GENERIC_TIME=y
@@ -200,11 +200,10 @@
 CONFIG_DCDBAS=m
 CONFIG_DMIID=y
 # CONFIG_NOHIGHMEM is not set
-# CONFIG_HIGHMEM4G is not set
-CONFIG_HIGHMEM64G=y
+CONFIG_HIGHMEM4G=y
+# CONFIG_HIGHMEM64G is not set
 CONFIG_PAGE_OFFSET=0xC000
 CONFIG_HIGHMEM=y
-CONFIG_X86_PAE=y
 CONFIG_ARCH_FLATMEM_ENABLE=y
 CONFIG_ARCH_SPARSEMEM_ENABLE=y
 CONFIG_ARCH_SELECT_MEMORY_MODEL=y
@@ -1228,7 +1227,6 @@
 CONFIG_I2O=m
 CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=y
 CONFIG_I2O_EXT_ADAPTEC=y
-CONFIG_I2O_EXT_ADAPTEC_DMA64=y
 CONFIG_I2O_CONFIG=m
 CONFIG_I2O_CONFIG_OLD_IOCTL=y
 CONFIG_I2O_BUS=m

And this time i get another oops [1] and because my kernel is tainted by 
nvidia driver i also tried and get same with untainted one [2]. I hope they 
helps...

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/opps_tainted
[2] http://cekirdek.pardus.org.tr/~caglar/kvm/opps_not_tainted

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


[PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi;

With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts 
to ignore any *.orig or *.rej files (for example git status cannot show 
what are they) but if there are some *.orig or *.rej files exists, for 
whatever reason, that means some unresolved merge conflicts occured for that 
code tree and this tree is no longer trusted so better not to ignore these.

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]
 
 .gitignore |3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8d15830..060a71d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -45,6 +45,3 @@ series
 
 # cscope files
 cscope.*
-
-*.orig
-*.rej


Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Alexey Dobriyan şunları yazmıştı: 
 *.orig are generated even if line numbers change a bit, so untrusted is
 a somewhat exaggerated.

:), although i prefer previous one, what about something like following?


With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts 
to ignore any *.rej files (for example git status cannot show what are 
they) but if there are some *.rej files exists, for whatever reason, that 
means some unresolved merge conflicts occured for that code tree and this 
tree is no longer trusted so better not to ignore this.

Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED]
 
 .gitignore |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8d15830..e3a56e4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -47,4 +47,3 @@ series
 cscope.*
 
 *.orig
-*.rej

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: 
> Can you reproduce without the appArmor patchset?

Tomorrow i'll also try with vanilla one but just for records same patchset 
worked without a problem until latest kvm merge :)

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

17 Tem 2007 Sal tarihinde, Avi Kivity şunları yazmıştı: 
> I fixed the issue with the previous patchset.  Please provide further
> feedback, or pull from:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
>
> This contains kvm updates for the 2.6.23 merge window, including

After that commit (+appArmor patchset) any guest image hangs the system 
completely as soon as started with kvm-29 userspace. Guest images works 
with "qemu-kvm -hda X.img -m 512 -no-kvm" works as expected

I cannot provide any more information for now causes system freezes at all and 
netconsole not works with ipw3945 (netconsole: eth1 doesn't support polling, 
aborting) but tomorrow i'll try with cable.

If needed you can find .config and dmesg from [1], if anything else needed 
please just say it...

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

17 Tem 2007 Sal tarihinde, Avi Kivity şunları yazmıştı: 
> I fixed the issue with the previous patchset.  Please provide further
> feedback, or pull from:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
>
> This contains kvm updates for the 2.6.23 merge window, including
>
>  - performance improvements
>  - suspend/resume fixes
>  - guest smp
>  - random fixes and cleanups

I have a tiny question triggered in my mind after seeing following, sorry if 
this was disccussed before;

config KVM
tristate "Kernel-based Virtual Machine (KVM) support"
depends on X86 && EXPERIMENTAL
depends on X86_CMPXCHG64 || 64BIT

If i'm not wrong X86_CMPXCHG64 depends on CONFIG_X86_PAE which depends on 
HIGHMEM64 and again if i'm not wrong this means distributions who wants to 
provide KVM must enable CONFIG_X86_PAE and CONFIG_HIGHMEM64G from now on?

Is this intentional or this is here because of an assumption like "processors 
supports virtualization already provides PAE", could you please enlighten me?

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

17 Tem 2007 Sal tarihinde, Avi Kivity şunları yazmıştı: 
 I fixed the issue with the previous patchset.  Please provide further
 feedback, or pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus

 This contains kvm updates for the 2.6.23 merge window, including

  - performance improvements
  - suspend/resume fixes
  - guest smp
  - random fixes and cleanups

I have a tiny question triggered in my mind after seeing following, sorry if 
this was disccussed before;

config KVM
tristate Kernel-based Virtual Machine (KVM) support
depends on X86  EXPERIMENTAL
depends on X86_CMPXCHG64 || 64BIT

If i'm not wrong X86_CMPXCHG64 depends on CONFIG_X86_PAE which depends on 
HIGHMEM64 and again if i'm not wrong this means distributions who wants to 
provide KVM must enable CONFIG_X86_PAE and CONFIG_HIGHMEM64G from now on?

Is this intentional or this is here because of an assumption like processors 
supports virtualization already provides PAE, could you please enlighten me?

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

17 Tem 2007 Sal tarihinde, Avi Kivity şunları yazmıştı: 
 I fixed the issue with the previous patchset.  Please provide further
 feedback, or pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus

 This contains kvm updates for the 2.6.23 merge window, including

After that commit (+appArmor patchset) any guest image hangs the system 
completely as soon as started with kvm-29 userspace. Guest images works 
with qemu-kvm -hda X.img -m 512 -no-kvm works as expected

I cannot provide any more information for now causes system freezes at all and 
netconsole not works with ipw3945 (netconsole: eth1 doesn't support polling, 
aborting) but tomorrow i'll try with cable.

If needed you can find .config and dmesg from [1], if anything else needed 
please just say it...

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-17 Thread S.Çağlar Onur
Hi;

18 Tem 2007 Çar tarihinde, Anthony Liguori şunları yazmıştı: 
 Can you reproduce without the appArmor patchset?

Tomorrow i'll also try with vanilla one but just for records same patchset 
worked without a problem until latest kvm merge :)

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: Build error with latest git

2007-07-16 Thread S.Çağlar Onur

[Resend, gnupg damaged the patch, sorry for noise]

16 Tem 2007 Pts tarihinde, Larry Finger şunları yazmıştı: 
> Using the latest git pull (commit
> abce891a10559343d8ac9f79b46d78afdba63a40), I get the following linker
> error:
>
> block/built-in.o: In function `bsg_init':
> bsg.c:(.init.text+0x43d): undefined reference to `scsi_register_interface'
>
> This is on an x86_64 system with the following .config:

I've hit that also (current git cannot compiled with CONFIG_BLK_DEV_BSG=y
), if i'm not wrongly interpret the Makefile it seems a ordering issue;

Makefile
...
ifeq ($(KBUILD_EXTMOD),)
core-y· ·   += kernel/ mm/ fs/ ipc/ security/ crypto/ block/
...
vmlinux-init := $(head-y) $(init-y)
vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
...

but block block/bsg.c uses "scsi_register_interface" exported by 
drivers/scsi/scsi_sysfs.c which lives in drivers-y. Moving bsg in 
drivers/scsi seems solves this issues, see following

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 block/Kconfig |8 
 block/Makefile|1 -
 drivers/scsi/Kconfig  |8 
 drivers/scsi/Makefile |1 +
 {block => drivers/scsi}/bsg.c |0 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index 1d16b08..2859351 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -51,12 +51,4 @@ config LSF
 
 endif # BLOCK
 
-config BLK_DEV_BSG
-   bool "Block layer SG support"
-   depends on SCSI && EXPERIMENTAL
-   default y
-   ---help---
-   Saying Y here will enable generic SG (SCSI generic) v4
-   support for any block device.
-
 source block/Kconfig.iosched
diff --git a/block/Makefile b/block/Makefile
index 959feeb..4b84d0d 100644
--- a/block/Makefile
+++ b/block/Makefile
@@ -4,7 +4,6 @@
 
 obj-$(CONFIG_BLOCK) := elevator.o ll_rw_blk.o ioctl.o genhd.o scsi_ioctl.o
 
-obj-$(CONFIG_BLK_DEV_BSG)  += bsg.o
 obj-$(CONFIG_IOSCHED_NOOP) += noop-iosched.o
 obj-$(CONFIG_IOSCHED_AS)   += as-iosched.o
 obj-$(CONFIG_IOSCHED_DEADLINE) += deadline-iosched.o
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 3727231..fbb06de 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -81,6 +81,14 @@ config BLK_DEV_SD
  In this case, do not compile the driver for your SCSI host adapter
  (below) as a module either.
 
+config BLK_DEV_BSG
+bool "Block layer SG support"
+   depends on SCSI && EXPERIMENTAL
+   default y
+   ---help---
+   Saying Y here will enable generic SG (SCSI generic) v4
+   support for any block device.
+
 config CHR_DEV_ST
tristate "SCSI tape support"
depends on SCSI
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 0f86895..15de029 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -139,6 +139,7 @@ obj-$(CONFIG_CHR_DEV_ST)+= st.o
 obj-$(CONFIG_CHR_DEV_OSST) += osst.o
 obj-$(CONFIG_BLK_DEV_SD)   += sd_mod.o
 obj-$(CONFIG_BLK_DEV_SR)   += sr_mod.o
+obj-$(CONFIG_BLK_DEV_BSG)  += bsg.o
 obj-$(CONFIG_CHR_DEV_SG)   += sg.o
 obj-$(CONFIG_CHR_DEV_SCH)  += ch.o
 
diff --git a/block/bsg.c b/drivers/scsi/bsg.c
similarity index 100%
rename from block/bsg.c
rename to drivers/scsi/bsg.c



Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build error with latest git

2007-07-16 Thread S.Çağlar Onur

[Adding needed CC's] 

16 Tem 2007 Pts tarihinde, Larry Finger şunları yazmıştı: 
> Using the latest git pull (commit
> abce891a10559343d8ac9f79b46d78afdba63a40), I get the following linker
> error:
>
> block/built-in.o: In function `bsg_init':
> bsg.c:(.init.text+0x43d): undefined reference to `scsi_register_interface'
>
> This is on an x86_64 system with the following .config:

I've hit that also (current git cannot compiled with CONFIG_BLK_DEV_BSG=y
), if i'm not wrongly interpret the Makefile it seems a ordering issue;

Makefile
...
ifeq ($(KBUILD_EXTMOD),)
core-y· ·   += kernel/ mm/ fs/ ipc/ security/ crypto/ block/
...
vmlinux-init := $(head-y) $(init-y)
vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
...

but block block/bsg.c uses "scsi_register_interface" exported by 
drivers/scsi/scsi_sysfs.c which lives in drivers-y. Moving bsg in 
drivers/scsi seems solves this issues, see following

Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>

 block/Kconfig |8 
 block/Makefile|1 -
 drivers/scsi/Kconfig  |8 
 drivers/scsi/Makefile |1 +
 {block => drivers/scsi}/bsg.c |0 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index 1d16b08..2859351 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -51,12 +51,4 @@ config LSF
 
 endif # BLOCK
 
-config BLK_DEV_BSG
-   bool "Block layer SG support"
-   depends on SCSI && EXPERIMENTAL
-   default y
-   ---help---
-   Saying Y here will enable generic SG (SCSI generic) v4
-   support for any block device.
-
 source block/Kconfig.iosched
diff --git a/block/Makefile b/block/Makefile
index 959feeb..4b84d0d 100644
--- a/block/Makefile
+++ b/block/Makefile
@@ -4,7 +4,6 @@
 
 obj-$(CONFIG_BLOCK) := elevator.o ll_rw_blk.o ioctl.o genhd.o scsi_ioctl.o
 
-obj-$(CONFIG_BLK_DEV_BSG)  += bsg.o
 obj-$(CONFIG_IOSCHED_NOOP) += noop-iosched.o
 obj-$(CONFIG_IOSCHED_AS)   += as-iosched.o
 obj-$(CONFIG_IOSCHED_DEADLINE) += deadline-iosched.o
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 3727231..fbb06de 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -81,6 +81,14 @@ config BLK_DEV_SD
  In this case, do not compile the driver for your SCSI host adapter
  (below) as a module either.
 
+config BLK_DEV_BSG
+bool "Block layer SG support"
+   depends on SCSI && EXPERIMENTAL
+   default y
+   ---help---
+   Saying Y here will enable generic SG (SCSI generic) v4
+   support for any block device.
+
 config CHR_DEV_ST
tristate "SCSI tape support"
depends on SCSI
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 0f86895..15de029 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -139,6 +139,7 @@ obj-$(CONFIG_CHR_DEV_ST)+= st.o
 obj-$(CONFIG_CHR_DEV_OSST) += osst.o
 obj-$(CONFIG_BLK_DEV_SD)   += sd_mod.o
 obj-$(CONFIG_BLK_DEV_SR)   += sr_mod.o
+obj-$(CONFIG_BLK_DEV_BSG)  += bsg.o
 obj-$(CONFIG_CHR_DEV_SG)   += sg.o
 obj-$(CONFIG_CHR_DEV_SCH)  += ch.o
 
diff --git a/block/bsg.c b/drivers/scsi/bsg.c
similarity index 100%
rename from block/bsg.c
rename to drivers/scsi/bsg.c



Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


  1   2   3   >