Re: Pause a process execution from external program

[Shyam Saini]

Hi Pintu,


> Hi All,
> I was just wondering if this is possible in the Linux world.
> My requirement is:
> For some reason, I want to halt/pause the execution (for some
> specified time) of a running process/thread (at some location),
> without modified the source, may be by firing some events/signals from
> an another external program, by specifying the address location or a
> line number.
>
> Is this possible ?
> May be by using some system call, or other mechanism using the process PID.
> Assume that its a debugging system with all root privileges.
>
> Basically, its just like how "gdb" is able to set the break-point in a
> program, and able to stop its execution exactly at that location.
> I am wondering what mechanism "gdb" uses to do this?

gdb uses ptrace system call, may you can explore ptrace?

> I tried to check here, but could find the exact place, where this is handled:
> https://github.com/bminor/binutils-gdb/blob/master/gdb/breakpoint.c

from command line we use ctrl-z to stop execution of a foreground
process but you can program
SIGTSTP signal handler in your application code to do the same.

is that you want ?

Thanks a lot,
Shyam

Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

[Shyam Saini]

Hi,

Did you read this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO


Thanks,
Shyam


> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Sumit Pundir 
> ---
>  drivers/staging/irda/drivers/act200l-sir.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/irda/drivers/act200l-sir.c 
> b/drivers/staging/irda/drivers/act200l-sir.c
> index e891751..62a02e5 100644
> --- a/drivers/staging/irda/drivers/act200l-sir.c
> +++ b/drivers/staging/irda/drivers/act200l-sir.c
> @@ -29,7 +29,7 @@
>  static int act200l_reset(struct sir_dev *dev);
>  static int act200l_open(struct sir_dev *dev);
>  static int act200l_close(struct sir_dev *dev);
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>
>  /* Regsiter 0: Control register #1 */
>  #define ACT200L_REG00x00
> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
>   *Set the speed for the ACTiSYS ACT-IR200L type dongle.
>   *
>   */
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
>  {
> u8 control[3];
> int ret = 0;
> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, 
> unsigned speed)
>
>  static int act200l_reset(struct sir_dev *dev)
>  {
> -   unsigned state = dev->fsm.substate;
> -   unsigned delay = 0;
> +   unsigned int state = dev->fsm.substate;
> +   unsigned int delay = 0;
> static const u8 control[9] = {
> ACT200L_REG15,
> ACT200L_REG13 | ACT200L_SHDW,
> --
> 2.7.4
>

Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

[Shyam Saini]

Hi,

Did you read this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO


Thanks,
Shyam


> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Sumit Pundir 
> ---
>  drivers/staging/irda/drivers/act200l-sir.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/irda/drivers/act200l-sir.c 
> b/drivers/staging/irda/drivers/act200l-sir.c
> index e891751..62a02e5 100644
> --- a/drivers/staging/irda/drivers/act200l-sir.c
> +++ b/drivers/staging/irda/drivers/act200l-sir.c
> @@ -29,7 +29,7 @@
>  static int act200l_reset(struct sir_dev *dev);
>  static int act200l_open(struct sir_dev *dev);
>  static int act200l_close(struct sir_dev *dev);
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>
>  /* Regsiter 0: Control register #1 */
>  #define ACT200L_REG00x00
> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
>   *Set the speed for the ACTiSYS ACT-IR200L type dongle.
>   *
>   */
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
>  {
> u8 control[3];
> int ret = 0;
> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, 
> unsigned speed)
>
>  static int act200l_reset(struct sir_dev *dev)
>  {
> -   unsigned state = dev->fsm.substate;
> -   unsigned delay = 0;
> +   unsigned int state = dev->fsm.substate;
> +   unsigned int delay = 0;
> static const u8 control[9] = {
> ACT200L_REG15,
> ACT200L_REG13 | ACT200L_SHDW,
> --
> 2.7.4
>

[PATCH] rtl8188eu: core: Remove NULL test before vfree

[Shyam Saini]

vfree frees the virtually continuous block of memory beginning at
addr. If addr is NULL, no operation is performed. So, NULL test is not
needed before vfree().

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c 
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index b60b126..2a65e32 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -246,8 +246,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv)
pxmitbuf++;
}
 
-   if (pxmitpriv->pallocated_xmit_extbuf)
-   vfree(pxmitpriv->pallocated_xmit_extbuf);
+   vfree(pxmitpriv->pallocated_xmit_extbuf);
 
rtw_free_hwxmits(padapter);
 
-- 
2.7.4

[PATCH] rtl8188eu: core: Remove NULL test before vfree

[Shyam Saini]

vfree frees the virtually continuous block of memory beginning at
addr. If addr is NULL, no operation is performed. So, NULL test is not
needed before vfree().

Signed-off-by: Shyam Saini 
---
 drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c 
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index b60b126..2a65e32 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -246,8 +246,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv)
pxmitbuf++;
}
 
-   if (pxmitpriv->pallocated_xmit_extbuf)
-   vfree(pxmitpriv->pallocated_xmit_extbuf);
+   vfree(pxmitpriv->pallocated_xmit_extbuf);
 
rtw_free_hwxmits(padapter);
 
-- 
2.7.4

[PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree

[Shyam Saini]

vfree frees the virtually continuous block of memory beginning at addr.
If addr is NULL, no operation is performed. So, NULL test is not needed
before vfree.

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c 
b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 8a9172a..4bf7041 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2695,10 +2695,8 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
priv->polling_timer_on = 0;
_rtl92e_down(dev, true);
rtl92e_dm_deinit(dev);
-   if (priv->pFirmware) {
-   vfree(priv->pFirmware);
-   priv->pFirmware = NULL;
-   }
+   vfree(priv->pFirmware);
+   priv->pFirmware = NULL;
_rtl92e_free_rx_ring(dev);
for (i = 0; i < MAX_TX_QUEUE_COUNT; i++)
_rtl92e_free_tx_ring(dev, i);
-- 
2.7.4

[PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree

[Shyam Saini]

vfree frees the virtually continuous block of memory beginning at addr.
If addr is NULL, no operation is performed. So, NULL test is not needed
before vfree.

Signed-off-by: Shyam Saini 
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c 
b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 8a9172a..4bf7041 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2695,10 +2695,8 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
priv->polling_timer_on = 0;
_rtl92e_down(dev, true);
rtl92e_dm_deinit(dev);
-   if (priv->pFirmware) {
-   vfree(priv->pFirmware);
-   priv->pFirmware = NULL;
-   }
+   vfree(priv->pFirmware);
+   priv->pFirmware = NULL;
_rtl92e_free_rx_ring(dev);
for (i = 0; i < MAX_TX_QUEUE_COUNT; i++)
_rtl92e_free_tx_ring(dev, i);
-- 
2.7.4

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by
the subsequent call to memcpy and thus makes the  memset redundant.

Also remove the memset((, 0, sizeof(info)) on line 398 because
info is memcpy()'ed to before being used in the loop and it isn't
used outside of the loop.

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..c902635 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -397,9 +397,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params info;
struct ch_sched_params tp;
 
-   memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
-
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
tp.u.params.class = SCHED_CLS_NONE;
@@ -409,7 +406,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +454,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by
the subsequent call to memcpy and thus makes the  memset redundant.

Also remove the memset((, 0, sizeof(info)) on line 398 because
info is memcpy()'ed to before being used in the loop and it isn't
used outside of the loop.

Signed-off-by: Shyam Saini 
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..c902635 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -397,9 +397,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params info;
struct ch_sched_params tp;
 
-   memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
-
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
tp.u.params.class = SCHED_CLS_NONE;
@@ -409,7 +406,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +454,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

Re: [PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote:
> On 2017-01-13 at 10:52:49 +0100, Shyam Saini <mayhs11sa...@gmail.com> wrote:
> > The region set by the call to memset, immediately overwritten by the
> > subsequent call to memcpy and thus makes the  memset redundant
> > 
> > Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
> > ---
> >  drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
> > b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > index cbd68a8..5725693 100644
> > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
> > port_info *pi,
> > struct ch_sched_params tp;
> >  
> > memset(, 0, sizeof(info));
> 
> This memset is also redundant because info is memcpy()'ed to before
> being used in the loop (and it isn't used outside of the loop).
Thanks a lot for pointing out that.

I'll remove that too and resend it.

Regards,
Shyam

Re: [PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote:
> On 2017-01-13 at 10:52:49 +0100, Shyam Saini  wrote:
> > The region set by the call to memset, immediately overwritten by the
> > subsequent call to memcpy and thus makes the  memset redundant
> > 
> > Signed-off-by: Shyam Saini 
> > ---
> >  drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
> > b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > index cbd68a8..5725693 100644
> > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> > @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
> > port_info *pi,
> > struct ch_sched_params tp;
> >  
> > memset(, 0, sizeof(info));
> 
> This memset is also redundant because info is memcpy()'ed to before
> being used in the loop (and it isn't used outside of the loop).
Thanks a lot for pointing out that.

I'll remove that too and resend it.

Regards,
Shyam

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by the
subsequent call to memcpy and thus makes the  memset redundant

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..5725693 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params tp;
 
memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
 
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
@@ -409,7 +408,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +456,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by the
subsequent call to memcpy and thus makes the  memset redundant

Signed-off-by: Shyam Saini 
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..5725693 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params tp;
 
memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
 
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
@@ -409,7 +408,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +456,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

[Shyam Saini]

Fixed following checkpatch warning
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c 
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 8ed4d39..19b550f 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -38,7 +38,7 @@ static u8 bits_magic[] = {
 static struct platform_device  *firmware_pdev;
 
 static char*file = "xlinx_fpga_firmware.bit";
-module_param(file, charp, S_IRUGO);
+module_param(file, charp, 0444);
 MODULE_PARM_DESC(file, "Xilinx FPGA firmware file.");
 
 static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize)
-- 
2.7.4

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

[Shyam Saini]

Fixed following checkpatch warning
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.

Signed-off-by: Shyam Saini 
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c 
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 8ed4d39..19b550f 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -38,7 +38,7 @@ static u8 bits_magic[] = {
 static struct platform_device  *firmware_pdev;
 
 static char*file = "xlinx_fpga_firmware.bit";
-module_param(file, charp, S_IRUGO);
+module_param(file, charp, 0444);
 MODULE_PARM_DESC(file, "Xilinx FPGA firmware file.");
 
 static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize)
-- 
2.7.4

Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()

[Shyam Saini]

On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini <mayhs11sa...@gmail.com>
> wrote:
> > 
> > Replace explicit computation of vma page count by a call to
> > vma_pages()
> Hi, I already have this patch in the "queue" from:
> Muhammad Falak R Wani <falakre...@gmail.com>
> 
> Will include that one when I get around to sending out a PR.
> 
> Thanks
> Patrik
> 
> > 
> > 
> > Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
> > ---
> >  drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > b/drivers/gpu/drm/gma500/framebuffer.c
> > index 3a44e70..0fde850 100644
> > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > *vma, struct vm_fault *vmf)
> > unsigned long phys_addr = (unsigned long)dev_priv-
> > >stolen_base +
> >   psbfb->gtt->offset;
> > 
> > -   page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > +   page_num = vma_pages(vma);
> > address = (unsigned long)vmf->virtual_address - (vmf->pgoff 
> > << PAGE_SHIFT);
> > 
> > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > --
> > 2.7.4
> > 

No issue.

Thanks

Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()

[Shyam Saini]

On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini 
> wrote:
> > 
> > Replace explicit computation of vma page count by a call to
> > vma_pages()
> Hi, I already have this patch in the "queue" from:
> Muhammad Falak R Wani 
> 
> Will include that one when I get around to sending out a PR.
> 
> Thanks
> Patrik
> 
> > 
> > 
> > Signed-off-by: Shyam Saini 
> > ---
> >  drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > b/drivers/gpu/drm/gma500/framebuffer.c
> > index 3a44e70..0fde850 100644
> > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > *vma, struct vm_fault *vmf)
> > unsigned long phys_addr = (unsigned long)dev_priv-
> > >stolen_base +
> >   psbfb->gtt->offset;
> > 
> > -   page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > +   page_num = vma_pages(vma);
> > address = (unsigned long)vmf->virtual_address - (vmf->pgoff 
> > << PAGE_SHIFT);
> > 
> > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > --
> > 2.7.4
> > 

No issue.

Thanks

[PATCH 1/1] cdrom: Remove unused variable using Coccinelle

[Shyam Saini]

The variable tocuse is initialized but never used otherwise.

semantic patch used for this change is as follows:

// 
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// 

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/cdrom/gdrom.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 584bc31..4a9d5ee 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -332,15 +332,13 @@ static int get_entry_track(int track)
 static int gdrom_get_last_session(struct cdrom_device_info *cd_info,
struct cdrom_multisession *ms_info)
 {
-   int fentry, lentry, track, data, tocuse, err;
+   int fentry, lentry, track, data, err;
if (!gd.toc)
return -ENOMEM;
-   tocuse = 1;
/* Check if GD-ROM */
err = gdrom_readtoc_cmd(gd.toc, 1);
/* Not a GD-ROM so check if standard CD-ROM */
if (err) {
-   tocuse = 0;
err = gdrom_readtoc_cmd(gd.toc, 0);
if (err) {
pr_info("Could not get CD table of contents\n");
-- 
2.7.4

[PATCH 1/1] cdrom: Remove unused variable using Coccinelle

[Shyam Saini]

The variable tocuse is initialized but never used otherwise.

semantic patch used for this change is as follows:

// 
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// 

Signed-off-by: Shyam Saini 
---
 drivers/cdrom/gdrom.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 584bc31..4a9d5ee 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -332,15 +332,13 @@ static int get_entry_track(int track)
 static int gdrom_get_last_session(struct cdrom_device_info *cd_info,
struct cdrom_multisession *ms_info)
 {
-   int fentry, lentry, track, data, tocuse, err;
+   int fentry, lentry, track, data, err;
if (!gd.toc)
return -ENOMEM;
-   tocuse = 1;
/* Check if GD-ROM */
err = gdrom_readtoc_cmd(gd.toc, 1);
/* Not a GD-ROM so check if standard CD-ROM */
if (err) {
-   tocuse = 0;
err = gdrom_readtoc_cmd(gd.toc, 0);
if (err) {
pr_info("Could not get CD table of contents\n");
-- 
2.7.4

[PATCH 1/1] arch: alpha: kernel: Use vma_pages()

[Shyam Saini]

Replace explicit computation of vma page count by a call to
vma_pages()

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 arch/alpha/kernel/pci-sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c
index 92c0d46..652449e 100644
--- a/arch/alpha/kernel/pci-sysfs.c
+++ b/arch/alpha/kernel/pci-sysfs.c
@@ -38,7 +38,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,
unsigned long nr, start, size;
int shift = sparse ? 5 : 0;
 
-   nr = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   nr = vma_pages(vma);
start = vma->vm_pgoff;
size = ((pci_resource_len(pdev, num) - 1) >> (PAGE_SHIFT - shift)) + 1;
 
@@ -255,7 +255,7 @@ static int __legacy_mmap_fits(struct pci_controller *hose,
 {
unsigned long nr, start, size;
 
-   nr = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   nr = vma_pages(vma);
start = vma->vm_pgoff;
size = ((res_size - 1) >> PAGE_SHIFT) + 1;
 
-- 
2.7.4

[PATCH 1/1] arch: alpha: kernel: Use vma_pages()

[Shyam Saini]

Replace explicit computation of vma page count by a call to
vma_pages()

Signed-off-by: Shyam Saini 
---
 arch/alpha/kernel/pci-sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c
index 92c0d46..652449e 100644
--- a/arch/alpha/kernel/pci-sysfs.c
+++ b/arch/alpha/kernel/pci-sysfs.c
@@ -38,7 +38,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,
unsigned long nr, start, size;
int shift = sparse ? 5 : 0;
 
-   nr = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   nr = vma_pages(vma);
start = vma->vm_pgoff;
size = ((pci_resource_len(pdev, num) - 1) >> (PAGE_SHIFT - shift)) + 1;
 
@@ -255,7 +255,7 @@ static int __legacy_mmap_fits(struct pci_controller *hose,
 {
unsigned long nr, start, size;
 
-   nr = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   nr = vma_pages(vma);
start = vma->vm_pgoff;
size = ((res_size - 1) >> PAGE_SHIFT) + 1;
 
-- 
2.7.4

[PATCH 1/1] gpu: drm: gma500: Use vma_pages()

[Shyam Saini]

Replace explicit computation of vma page count by a call to
vma_pages()

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/gpu/drm/gma500/framebuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/framebuffer.c 
b/drivers/gpu/drm/gma500/framebuffer.c
index 3a44e70..0fde850 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct *vma, 
struct vm_fault *vmf)
unsigned long phys_addr = (unsigned long)dev_priv->stolen_base +
  psbfb->gtt->offset;
 
-   page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   page_num = vma_pages(vma);
address = (unsigned long)vmf->virtual_address - (vmf->pgoff << 
PAGE_SHIFT);
 
vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
-- 
2.7.4

[PATCH 1/1] gpu: drm: gma500: Use vma_pages()

[Shyam Saini]

Replace explicit computation of vma page count by a call to
vma_pages()

Signed-off-by: Shyam Saini 
---
 drivers/gpu/drm/gma500/framebuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/framebuffer.c 
b/drivers/gpu/drm/gma500/framebuffer.c
index 3a44e70..0fde850 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct *vma, 
struct vm_fault *vmf)
unsigned long phys_addr = (unsigned long)dev_priv->stolen_base +
  psbfb->gtt->offset;
 
-   page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+   page_num = vma_pages(vma);
address = (unsigned long)vmf->virtual_address - (vmf->pgoff << 
PAGE_SHIFT);
 
vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
-- 
2.7.4

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[Shyam Saini]

On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote:
> > 
> > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> > > 
> > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > > > 
> > > > 
> > > > Remove the explicit NULL comparison and rewrite in a compact
> > > > form.
> > > > 
> > > > Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
> > > > ---
> > > >  drivers/staging/android/ion/ion_of.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > Does not apply to my tree :(
> > 
> > Do I need to rebase it? Because I have already included all the
> > maintainers in the patch which I got from
> >  scripts/get_maintainer.pl.
> If you want it applied, yes, you need to rebase it.  Listing the
> maintainers doesn't help the patch to somehow magically be able to be
> applied to the tree :)
> 
> Please work against my staging-testing branch of the staging.git
> tree,
> as it has a lot of patches I just accepted in it that are not yet in
> linux-next.
> 
> thanks,
> 
> greg k-h


>From now onward I will be working on your staging-testing tree. 

But then why some of my patches which were based on linux-next were
accepted?

for example today You've accepted 
my patch "Staging: vt6655: Remove explicit NULL comparison using
Coccinelle"

with commit id  4d932504b534584e116b400dd6e7b8ce7deb455c, 

which you can check on 
 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

This patch was based on linux-next tree.

Please clear my confusion.

Thanks,
Shyam

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[Shyam Saini]

On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote:
> > 
> > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> > > 
> > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > > > 
> > > > 
> > > > Remove the explicit NULL comparison and rewrite in a compact
> > > > form.
> > > > 
> > > > Signed-off-by: shyam saini 
> > > > ---
> > > >  drivers/staging/android/ion/ion_of.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > Does not apply to my tree :(
> > 
> > Do I need to rebase it? Because I have already included all the
> > maintainers in the patch which I got from
> >  scripts/get_maintainer.pl.
> If you want it applied, yes, you need to rebase it.  Listing the
> maintainers doesn't help the patch to somehow magically be able to be
> applied to the tree :)
> 
> Please work against my staging-testing branch of the staging.git
> tree,
> as it has a lot of patches I just accepted in it that are not yet in
> linux-next.
> 
> thanks,
> 
> greg k-h


>From now onward I will be working on your staging-testing tree. 

But then why some of my patches which were based on linux-next were
accepted?

for example today You've accepted 
my patch "Staging: vt6655: Remove explicit NULL comparison using
Coccinelle"

with commit id  4d932504b534584e116b400dd6e7b8ce7deb455c, 

which you can check on 
 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

This patch was based on linux-next tree.

Please clear my confusion.

Thanks,
Shyam

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[Shyam Saini]

On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > 
> > Remove the explicit NULL comparison and rewrite in a compact form.
> > 
> > Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
> > ---
> >  drivers/staging/android/ion/ion_of.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Does not apply to my tree :(


Do I need to rebase it? Because I have already included all the
maintainers in the patch which I got from  scripts/get_maintainer.pl.

Thanks,
Shyam

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[Shyam Saini]

On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > 
> > Remove the explicit NULL comparison and rewrite in a compact form.
> > 
> > Signed-off-by: shyam saini 
> > ---
> >  drivers/staging/android/ion/ion_of.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Does not apply to my tree :(


Do I need to rebase it? Because I have already included all the
maintainers in the patch which I got from  scripts/get_maintainer.pl.

Thanks,
Shyam

[PATCH 1/1] Staging: vt6655: Remove explicit NULL comparison using Coccinelle

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form.

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/vt6655/rxtx.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 890d108..7e69bc9 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -504,7 +504,7 @@ s_uFillDataHead(
 )
 {
 
-   if (pTxDataHead == NULL)
+   if (!pTxDataHead)
return 0;
 
 
@@ -648,7 +648,7 @@ s_vFillRTSHead(
 {
unsigned int uRTSFrameLen = 20;
 
-   if (pvRTS == NULL)
+   if (!pvRTS)
return;
 
if (bDisCRC) {
@@ -843,7 +843,7 @@ s_vFillCTSHead(
 {
unsigned int uCTSFrameLen = 14;
 
-   if (pvCTS == NULL)
+   if (!pvCTS)
return;
 
if (bDisCRC) {
@@ -1009,7 +1009,7 @@ s_vGenerateTxParameter(
 
/* Fill RTS */
s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, 
bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption);
-   } else if (pvRTS == NULL) {/* RTS_needless, non PCF mode */
+   } else if (!pvRTS) {/* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
 
buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, 
PK_TYPE_11A, cbFrameSize, wCurrentRate, bNeedACK);
-- 
2.7.4

[PATCH 1/1] Staging: vt6655: Remove explicit NULL comparison using Coccinelle

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form.

Signed-off-by: shyam saini 
---
 drivers/staging/vt6655/rxtx.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 890d108..7e69bc9 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -504,7 +504,7 @@ s_uFillDataHead(
 )
 {
 
-   if (pTxDataHead == NULL)
+   if (!pTxDataHead)
return 0;
 
 
@@ -648,7 +648,7 @@ s_vFillRTSHead(
 {
unsigned int uRTSFrameLen = 20;
 
-   if (pvRTS == NULL)
+   if (!pvRTS)
return;
 
if (bDisCRC) {
@@ -843,7 +843,7 @@ s_vFillCTSHead(
 {
unsigned int uCTSFrameLen = 14;
 
-   if (pvCTS == NULL)
+   if (!pvCTS)
return;
 
if (bDisCRC) {
@@ -1009,7 +1009,7 @@ s_vGenerateTxParameter(
 
/* Fill RTS */
s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, 
bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption);
-   } else if (pvRTS == NULL) {/* RTS_needless, non PCF mode */
+   } else if (!pvRTS) {/* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pvRrvTime;
 
buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, 
PK_TYPE_11A, cbFrameSize, wCurrentRate, bNeedACK);
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

[shyam saini]

Fixed switch case indentation issue and void function return statement
issue

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, 
struct device *dev)
 static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
 {
-   return;
+
 }
 
 static const struct reserved_mem_ops rmem_dma_ops = {
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

[shyam saini]

Fixed switch case indentation issue and void function return statement
issue

Signed-off-by: shyam saini 
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, 
struct device *dev)
 static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
 {
-   return;
+
 }
 
 static const struct reserved_mem_ops rmem_dma_ops = {
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form.

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/android/ion/ion_of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index 01f3067..485fb0f 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
 
-   if (compatible[i].name == NULL)
+   if (!compatible[i].name)
return -ENODEV;
 
heap->id = compatible[i].heap_id;
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form.

Signed-off-by: shyam saini 
---
 drivers/staging/android/ion/ion_of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index 01f3067..485fb0f 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
 
-   if (compatible[i].name == NULL)
+   if (!compatible[i].name)
return -ENODEV;
 
heap->id = compatible[i].heap_id;
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

[shyam saini]

Fixed checkpatch coding style issues

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, 
struct device *dev)
 static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
 {
-   return;
+
 }
 
 static const struct reserved_mem_ops rmem_dma_ops = {
-- 
2.7.4

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

[shyam saini]

Fixed checkpatch coding style issues

Signed-off-by: shyam saini 
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..01f3067 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
@@ -162,7 +162,7 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, 
struct device *dev)
 static void rmem_ion_device_release(struct reserved_mem *rmem,
struct device *dev)
 {
-   return;
+
 }
 
 static const struct reserved_mem_ops rmem_dma_ops = {
-- 
2.7.4

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form and
fixed switch case indentation issue.

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..0b7bb30 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
 
-   if (compatible[i].name == NULL)
+   if (!compatible[i].name)
return -ENODEV;
 
heap->id = compatible[i].heap_id;
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
-- 
2.7.4

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form and
fixed switch case indentation issue.

Signed-off-by: shyam saini 
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..0b7bb30 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
 
-   if (compatible[i].name == NULL)
+   if (!compatible[i].name)
return -ENODEV;
 
heap->id = compatible[i].heap_id;
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
-- 
2.7.4

[PATCH 1/1] staging: i4l: pcbit: Remove explicit NULL comparison

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form using 
Coccinelle

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/i4l/pcbit/callbacks.c |  4 ++--
 drivers/staging/i4l/pcbit/capi.c  | 18 +-
 drivers/staging/i4l/pcbit/drv.c   | 14 +++---
 drivers/staging/i4l/pcbit/layer2.c|  9 -
 4 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/i4l/pcbit/callbacks.c 
b/drivers/staging/i4l/pcbit/callbacks.c
index efb6d6a..41a95a5 100644
--- a/drivers/staging/i4l/pcbit/callbacks.c
+++ b/drivers/staging/i4l/pcbit/callbacks.c
@@ -144,14 +144,14 @@ void cb_in_1(struct pcbit_dev *dev, struct pcbit_chan 
*chan,
 *  ictl.num >= strlen() + strlen() + 5
 */
 
-   if (cbdata->data.setup.CallingPN == NULL) {
+   if (!cbdata->data.setup.CallingPN) {
printk(KERN_DEBUG "NULL CallingPN to phone; using 0\n");
strcpy(ictl.parm.setup.phone, "0");
}
else {
strcpy(ictl.parm.setup.phone, cbdata->data.setup.CallingPN);
}
-   if (cbdata->data.setup.CalledPN == NULL) {
+   if (!cbdata->data.setup.CalledPN) {
printk(KERN_DEBUG "NULL CalledPN to eazmsn; using 0\n");
strcpy(ictl.parm.setup.eazmsn, "0");
}
diff --git a/drivers/staging/i4l/pcbit/capi.c b/drivers/staging/i4l/pcbit/capi.c
index 4e3cbf8..b11895cb 100644
--- a/drivers/staging/i4l/pcbit/capi.c
+++ b/drivers/staging/i4l/pcbit/capi.c
@@ -76,7 +76,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff **skb, 
int proto)
if (proto == ISDN_PROTO_L2_TRANS)
len++;
 
-   if ((*skb = dev_alloc_skb(len)) == NULL) {
+   if (!(*skb = dev_alloc_skb(len))) {
 
printk(KERN_WARNING "capi_conn_req: alloc_skb failed\n");
return -1;
@@ -134,7 +134,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff 
**skb, int proto)
 int capi_conn_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(5)) == NULL) {
+   if (!(*skb = dev_alloc_skb(5))) {
 
printk(KERN_WARNING "capi_conn_resp: alloc_skb failed\n");
return -1;
@@ -154,7 +154,7 @@ int capi_conn_active_req(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 8 bytes
 */
 
-   if ((*skb = dev_alloc_skb(8)) == NULL) {
+   if (!(*skb = dev_alloc_skb(8))) {
 
printk(KERN_WARNING "capi_conn_active_req: alloc_skb failed\n");
return -1;
@@ -182,7 +182,7 @@ int capi_conn_active_resp(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 2 bytes
 */
 
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_conn_active_resp: alloc_skb 
failed\n");
return -1;
@@ -202,7 +202,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 * 18 bytes
 */
 
-   if ((*skb = dev_alloc_skb(18)) == NULL) {
+   if (!(*skb = dev_alloc_skb(18))) {
 
printk(KERN_WARNING "capi_select_proto_req: alloc_skb 
failed\n");
return -1;
@@ -263,7 +263,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 int capi_activate_transp_req(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(7)) == NULL) {
+   if (!(*skb = dev_alloc_skb(7))) {
 
printk(KERN_WARNING "capi_activate_transp_req: alloc_skb 
failed\n");
return -1;
@@ -321,7 +321,7 @@ int capi_tdata_req(struct pcbit_chan *chan, struct sk_buff 
*skb)
 int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 
 {
-   if ((*skb = dev_alloc_skb(4)) == NULL) {
+   if (!(*skb = dev_alloc_skb(4))) {
 
printk(KERN_WARNING "capi_tdata_resp: alloc_skb failed\n");
return -1;
@@ -338,7 +338,7 @@ int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff 
**skb)
 int capi_disc_req(ushort callref, struct sk_buff **skb, u_char cause)
 {
 
-   if ((*skb = dev_alloc_skb(6)) == NULL) {
+   if (!(*skb = dev_alloc_skb(6))) {
 
printk(KERN_WARNING "capi_disc_req: alloc_skb failed\n");
return -1;
@@ -361,7 +361,7 @@ int capi_disc_req(ushort callref, struct sk_buff **skb, 
u_char cause)
 
 int capi_disc_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_disc_resp: alloc_skb failed\n");
return -1;
diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index c5270e2..62a41d7 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+

[PATCH 1/1] staging: i4l: pcbit: Remove explicit NULL comparison

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form using 
Coccinelle

Signed-off-by: shyam saini 
---
 drivers/staging/i4l/pcbit/callbacks.c |  4 ++--
 drivers/staging/i4l/pcbit/capi.c  | 18 +-
 drivers/staging/i4l/pcbit/drv.c   | 14 +++---
 drivers/staging/i4l/pcbit/layer2.c|  9 -
 4 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/i4l/pcbit/callbacks.c 
b/drivers/staging/i4l/pcbit/callbacks.c
index efb6d6a..41a95a5 100644
--- a/drivers/staging/i4l/pcbit/callbacks.c
+++ b/drivers/staging/i4l/pcbit/callbacks.c
@@ -144,14 +144,14 @@ void cb_in_1(struct pcbit_dev *dev, struct pcbit_chan 
*chan,
 *  ictl.num >= strlen() + strlen() + 5
 */
 
-   if (cbdata->data.setup.CallingPN == NULL) {
+   if (!cbdata->data.setup.CallingPN) {
printk(KERN_DEBUG "NULL CallingPN to phone; using 0\n");
strcpy(ictl.parm.setup.phone, "0");
}
else {
strcpy(ictl.parm.setup.phone, cbdata->data.setup.CallingPN);
}
-   if (cbdata->data.setup.CalledPN == NULL) {
+   if (!cbdata->data.setup.CalledPN) {
printk(KERN_DEBUG "NULL CalledPN to eazmsn; using 0\n");
strcpy(ictl.parm.setup.eazmsn, "0");
}
diff --git a/drivers/staging/i4l/pcbit/capi.c b/drivers/staging/i4l/pcbit/capi.c
index 4e3cbf8..b11895cb 100644
--- a/drivers/staging/i4l/pcbit/capi.c
+++ b/drivers/staging/i4l/pcbit/capi.c
@@ -76,7 +76,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff **skb, 
int proto)
if (proto == ISDN_PROTO_L2_TRANS)
len++;
 
-   if ((*skb = dev_alloc_skb(len)) == NULL) {
+   if (!(*skb = dev_alloc_skb(len))) {
 
printk(KERN_WARNING "capi_conn_req: alloc_skb failed\n");
return -1;
@@ -134,7 +134,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff 
**skb, int proto)
 int capi_conn_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(5)) == NULL) {
+   if (!(*skb = dev_alloc_skb(5))) {
 
printk(KERN_WARNING "capi_conn_resp: alloc_skb failed\n");
return -1;
@@ -154,7 +154,7 @@ int capi_conn_active_req(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 8 bytes
 */
 
-   if ((*skb = dev_alloc_skb(8)) == NULL) {
+   if (!(*skb = dev_alloc_skb(8))) {
 
printk(KERN_WARNING "capi_conn_active_req: alloc_skb failed\n");
return -1;
@@ -182,7 +182,7 @@ int capi_conn_active_resp(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 2 bytes
 */
 
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_conn_active_resp: alloc_skb 
failed\n");
return -1;
@@ -202,7 +202,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 * 18 bytes
 */
 
-   if ((*skb = dev_alloc_skb(18)) == NULL) {
+   if (!(*skb = dev_alloc_skb(18))) {
 
printk(KERN_WARNING "capi_select_proto_req: alloc_skb 
failed\n");
return -1;
@@ -263,7 +263,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 int capi_activate_transp_req(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(7)) == NULL) {
+   if (!(*skb = dev_alloc_skb(7))) {
 
printk(KERN_WARNING "capi_activate_transp_req: alloc_skb 
failed\n");
return -1;
@@ -321,7 +321,7 @@ int capi_tdata_req(struct pcbit_chan *chan, struct sk_buff 
*skb)
 int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 
 {
-   if ((*skb = dev_alloc_skb(4)) == NULL) {
+   if (!(*skb = dev_alloc_skb(4))) {
 
printk(KERN_WARNING "capi_tdata_resp: alloc_skb failed\n");
return -1;
@@ -338,7 +338,7 @@ int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff 
**skb)
 int capi_disc_req(ushort callref, struct sk_buff **skb, u_char cause)
 {
 
-   if ((*skb = dev_alloc_skb(6)) == NULL) {
+   if (!(*skb = dev_alloc_skb(6))) {
 
printk(KERN_WARNING "capi_disc_req: alloc_skb failed\n");
return -1;
@@ -361,7 +361,7 @@ int capi_disc_req(ushort callref, struct sk_buff **skb, 
u_char cause)
 
 int capi_disc_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_disc_resp: alloc_skb failed\n");
return -1;
diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index c5270e2..62a41d7 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+++ b/drivers/staging/i4l/pcbit/drv

[PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form using 
Coccinelle

Signed-off-by: shyam saini <mayhs11sa...@gmail.com>
---
 drivers/staging/i4l/pcbit/callbacks.c |  4 ++--
 drivers/staging/i4l/pcbit/capi.c  | 18 +-
 drivers/staging/i4l/pcbit/drv.c   | 14 +++---
 drivers/staging/i4l/pcbit/layer2.c|  9 -
 4 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/i4l/pcbit/callbacks.c 
b/drivers/staging/i4l/pcbit/callbacks.c
index efb6d6a..41a95a5 100644
--- a/drivers/staging/i4l/pcbit/callbacks.c
+++ b/drivers/staging/i4l/pcbit/callbacks.c
@@ -144,14 +144,14 @@ void cb_in_1(struct pcbit_dev *dev, struct pcbit_chan 
*chan,
 *  ictl.num >= strlen() + strlen() + 5
 */
 
-   if (cbdata->data.setup.CallingPN == NULL) {
+   if (!cbdata->data.setup.CallingPN) {
printk(KERN_DEBUG "NULL CallingPN to phone; using 0\n");
strcpy(ictl.parm.setup.phone, "0");
}
else {
strcpy(ictl.parm.setup.phone, cbdata->data.setup.CallingPN);
}
-   if (cbdata->data.setup.CalledPN == NULL) {
+   if (!cbdata->data.setup.CalledPN) {
printk(KERN_DEBUG "NULL CalledPN to eazmsn; using 0\n");
strcpy(ictl.parm.setup.eazmsn, "0");
}
diff --git a/drivers/staging/i4l/pcbit/capi.c b/drivers/staging/i4l/pcbit/capi.c
index 4e3cbf8..b11895cb 100644
--- a/drivers/staging/i4l/pcbit/capi.c
+++ b/drivers/staging/i4l/pcbit/capi.c
@@ -76,7 +76,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff **skb, 
int proto)
if (proto == ISDN_PROTO_L2_TRANS)
len++;
 
-   if ((*skb = dev_alloc_skb(len)) == NULL) {
+   if (!(*skb = dev_alloc_skb(len))) {
 
printk(KERN_WARNING "capi_conn_req: alloc_skb failed\n");
return -1;
@@ -134,7 +134,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff 
**skb, int proto)
 int capi_conn_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(5)) == NULL) {
+   if (!(*skb = dev_alloc_skb(5))) {
 
printk(KERN_WARNING "capi_conn_resp: alloc_skb failed\n");
return -1;
@@ -154,7 +154,7 @@ int capi_conn_active_req(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 8 bytes
 */
 
-   if ((*skb = dev_alloc_skb(8)) == NULL) {
+   if (!(*skb = dev_alloc_skb(8))) {
 
printk(KERN_WARNING "capi_conn_active_req: alloc_skb failed\n");
return -1;
@@ -182,7 +182,7 @@ int capi_conn_active_resp(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 2 bytes
 */
 
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_conn_active_resp: alloc_skb 
failed\n");
return -1;
@@ -202,7 +202,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 * 18 bytes
 */
 
-   if ((*skb = dev_alloc_skb(18)) == NULL) {
+   if (!(*skb = dev_alloc_skb(18))) {
 
printk(KERN_WARNING "capi_select_proto_req: alloc_skb 
failed\n");
return -1;
@@ -263,7 +263,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 int capi_activate_transp_req(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(7)) == NULL) {
+   if (!(*skb = dev_alloc_skb(7))) {
 
printk(KERN_WARNING "capi_activate_transp_req: alloc_skb 
failed\n");
return -1;
@@ -321,7 +321,7 @@ int capi_tdata_req(struct pcbit_chan *chan, struct sk_buff 
*skb)
 int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 
 {
-   if ((*skb = dev_alloc_skb(4)) == NULL) {
+   if (!(*skb = dev_alloc_skb(4))) {
 
printk(KERN_WARNING "capi_tdata_resp: alloc_skb failed\n");
return -1;
@@ -338,7 +338,7 @@ int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff 
**skb)
 int capi_disc_req(ushort callref, struct sk_buff **skb, u_char cause)
 {
 
-   if ((*skb = dev_alloc_skb(6)) == NULL) {
+   if (!(*skb = dev_alloc_skb(6))) {
 
printk(KERN_WARNING "capi_disc_req: alloc_skb failed\n");
return -1;
@@ -361,7 +361,7 @@ int capi_disc_req(ushort callref, struct sk_buff **skb, 
u_char cause)
 
 int capi_disc_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_disc_resp: alloc_skb failed\n");
return -1;
diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index c5270e2..62a41d7 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+

[PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form using 
Coccinelle

Signed-off-by: shyam saini 
---
 drivers/staging/i4l/pcbit/callbacks.c |  4 ++--
 drivers/staging/i4l/pcbit/capi.c  | 18 +-
 drivers/staging/i4l/pcbit/drv.c   | 14 +++---
 drivers/staging/i4l/pcbit/layer2.c|  9 -
 4 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/i4l/pcbit/callbacks.c 
b/drivers/staging/i4l/pcbit/callbacks.c
index efb6d6a..41a95a5 100644
--- a/drivers/staging/i4l/pcbit/callbacks.c
+++ b/drivers/staging/i4l/pcbit/callbacks.c
@@ -144,14 +144,14 @@ void cb_in_1(struct pcbit_dev *dev, struct pcbit_chan 
*chan,
 *  ictl.num >= strlen() + strlen() + 5
 */
 
-   if (cbdata->data.setup.CallingPN == NULL) {
+   if (!cbdata->data.setup.CallingPN) {
printk(KERN_DEBUG "NULL CallingPN to phone; using 0\n");
strcpy(ictl.parm.setup.phone, "0");
}
else {
strcpy(ictl.parm.setup.phone, cbdata->data.setup.CallingPN);
}
-   if (cbdata->data.setup.CalledPN == NULL) {
+   if (!cbdata->data.setup.CalledPN) {
printk(KERN_DEBUG "NULL CalledPN to eazmsn; using 0\n");
strcpy(ictl.parm.setup.eazmsn, "0");
}
diff --git a/drivers/staging/i4l/pcbit/capi.c b/drivers/staging/i4l/pcbit/capi.c
index 4e3cbf8..b11895cb 100644
--- a/drivers/staging/i4l/pcbit/capi.c
+++ b/drivers/staging/i4l/pcbit/capi.c
@@ -76,7 +76,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff **skb, 
int proto)
if (proto == ISDN_PROTO_L2_TRANS)
len++;
 
-   if ((*skb = dev_alloc_skb(len)) == NULL) {
+   if (!(*skb = dev_alloc_skb(len))) {
 
printk(KERN_WARNING "capi_conn_req: alloc_skb failed\n");
return -1;
@@ -134,7 +134,7 @@ int capi_conn_req(const char *calledPN, struct sk_buff 
**skb, int proto)
 int capi_conn_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(5)) == NULL) {
+   if (!(*skb = dev_alloc_skb(5))) {
 
printk(KERN_WARNING "capi_conn_resp: alloc_skb failed\n");
return -1;
@@ -154,7 +154,7 @@ int capi_conn_active_req(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 8 bytes
 */
 
-   if ((*skb = dev_alloc_skb(8)) == NULL) {
+   if (!(*skb = dev_alloc_skb(8))) {
 
printk(KERN_WARNING "capi_conn_active_req: alloc_skb failed\n");
return -1;
@@ -182,7 +182,7 @@ int capi_conn_active_resp(struct pcbit_chan *chan, struct 
sk_buff **skb)
 * 2 bytes
 */
 
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_conn_active_resp: alloc_skb 
failed\n");
return -1;
@@ -202,7 +202,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 * 18 bytes
 */
 
-   if ((*skb = dev_alloc_skb(18)) == NULL) {
+   if (!(*skb = dev_alloc_skb(18))) {
 
printk(KERN_WARNING "capi_select_proto_req: alloc_skb 
failed\n");
return -1;
@@ -263,7 +263,7 @@ int capi_select_proto_req(struct pcbit_chan *chan, struct 
sk_buff **skb,
 int capi_activate_transp_req(struct pcbit_chan *chan, struct sk_buff **skb)
 {
 
-   if ((*skb = dev_alloc_skb(7)) == NULL) {
+   if (!(*skb = dev_alloc_skb(7))) {
 
printk(KERN_WARNING "capi_activate_transp_req: alloc_skb 
failed\n");
return -1;
@@ -321,7 +321,7 @@ int capi_tdata_req(struct pcbit_chan *chan, struct sk_buff 
*skb)
 int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 
 {
-   if ((*skb = dev_alloc_skb(4)) == NULL) {
+   if (!(*skb = dev_alloc_skb(4))) {
 
printk(KERN_WARNING "capi_tdata_resp: alloc_skb failed\n");
return -1;
@@ -338,7 +338,7 @@ int capi_tdata_resp(struct pcbit_chan *chan, struct sk_buff 
**skb)
 int capi_disc_req(ushort callref, struct sk_buff **skb, u_char cause)
 {
 
-   if ((*skb = dev_alloc_skb(6)) == NULL) {
+   if (!(*skb = dev_alloc_skb(6))) {
 
printk(KERN_WARNING "capi_disc_req: alloc_skb failed\n");
return -1;
@@ -361,7 +361,7 @@ int capi_disc_req(ushort callref, struct sk_buff **skb, 
u_char cause)
 
 int capi_disc_resp(struct pcbit_chan *chan, struct sk_buff **skb)
 {
-   if ((*skb = dev_alloc_skb(2)) == NULL) {
+   if (!(*skb = dev_alloc_skb(2))) {
 
printk(KERN_WARNING "capi_disc_resp: alloc_skb failed\n");
return -1;
diff --git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c
index c5270e2..62a41d7 100644
--- a/drivers/staging/i4l/pcbit/drv.c
+++ b/drivers/staging/i4l/pcbit/drv

[PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

[Shyam Saini]

Fixed following checkpatch.pl warnings:
Prefer 'unsigned int' to bare use of 'unsigned'
Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/rdma/hfi1/sdma.c | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index abb8ebc..c2e2856 100644
--- a/drivers/staging/rdma/hfi1/sdma.c
+++ b/drivers/staging/rdma/hfi1/sdma.c
@@ -234,7 +234,7 @@ static void sdma_put(struct sdma_state *);
 static void sdma_set_state(struct sdma_engine *, enum sdma_states);
 static void sdma_start_hw_clean_up(struct sdma_engine *);
 static void sdma_sw_clean_up_task(unsigned long);
-static void sdma_sendctrl(struct sdma_engine *, unsigned);
+static void sdma_sendctrl(struct sdma_engine *, unsigned int);
 static void init_sdma_regs(struct sdma_engine *, u32, uint);
 static void sdma_process_event(
struct sdma_engine *sde,
@@ -244,7 +244,7 @@ static void __sdma_process_event(
enum sdma_events event);
 static void dump_sdma_state(struct sdma_engine *sde);
 static void sdma_make_progress(struct sdma_engine *sde, u64 status);
-static void sdma_desc_avail(struct sdma_engine *sde, unsigned avail);
+static void sdma_desc_avail(struct sdma_engine *sde, unsigned int avail);
 static void sdma_flush_descq(struct sdma_engine *sde);
 
 /**
@@ -346,7 +346,7 @@ void sdma_wait(struct hfi1_devdata *dd)
}
 }
 
-static inline void sdma_set_desc_cnt(struct sdma_engine *sde, unsigned cnt)
+static inline void sdma_set_desc_cnt(struct sdma_engine *sde, unsigned int cnt)
 {
u64 reg;
 
@@ -472,7 +472,7 @@ static void sdma_err_halt_wait(struct work_struct *work)
 static void sdma_err_progress_check_schedule(struct sdma_engine *sde)
 {
if (!is_bx(sde->dd) && HFI1_CAP_IS_KSET(SDMA_AHG)) {
-   unsigned index;
+   unsigned int index;
struct hfi1_devdata *dd = sde->dd;
 
for (index = 0; index < dd->num_sdma; index++) {
@@ -491,7 +491,7 @@ static void sdma_err_progress_check_schedule(struct 
sdma_engine *sde)
 
 static void sdma_err_progress_check(unsigned long data)
 {
-   unsigned index;
+   unsigned int index;
struct sdma_engine *sde = (struct sdma_engine *)data;
 
dd_dev_err(sde->dd, "SDE progress check event\n");
@@ -657,7 +657,7 @@ static void sdma_set_state(struct sdma_engine *sde,
 {
struct sdma_state *ss = >state;
const struct sdma_set_state_action *action = sdma_action_table;
-   unsigned op = 0;
+   unsigned int op = 0;
 
trace_hfi1_sdma_state(
sde,
@@ -989,7 +989,7 @@ static void sdma_clean(struct hfi1_devdata *dd, size_t 
num_engines)
  */
 int sdma_init(struct hfi1_devdata *dd, u8 port)
 {
-   unsigned this_idx;
+   unsigned int this_idx;
struct sdma_engine *sde;
u16 descq_cnt;
void *curr_head;
@@ -1213,7 +1213,7 @@ void sdma_all_idle(struct hfi1_devdata *dd)
  */
 void sdma_start(struct hfi1_devdata *dd)
 {
-   unsigned i;
+   unsigned int i;
struct sdma_engine *sde;
 
/* kick off the engines state processing */
@@ -1229,7 +1229,7 @@ void sdma_start(struct hfi1_devdata *dd)
  */
 void sdma_exit(struct hfi1_devdata *dd)
 {
-   unsigned this_idx;
+   unsigned int this_idx;
struct sdma_engine *sde;
 
for (this_idx = 0; dd->per_sdma && this_idx < dd->num_sdma;
@@ -1351,7 +1351,7 @@ retry:
 
swhead = sde->descq_head & sde->sdma_mask;
/* this code is really bad for cache line trading */
-   swtail = ACCESS_ONCE(sde->descq_tail) & sde->sdma_mask;
+   swtail = READ_ONCE(sde->descq_tail) & sde->sdma_mask;
cnt = sde->descq_cnt;
 
if (swhead < swtail)
@@ -1557,7 +1557,7 @@ void sdma_engine_error(struct sdma_engine *sde, u64 
status)
spin_unlock_irqrestore(>tail_lock, flags);
 }
 
-static void sdma_sendctrl(struct sdma_engine *sde, unsigned op)
+static void sdma_sendctrl(struct sdma_engine *sde, unsigned int op)
 {
u64 set_senddmactrl = 0;
u64 clr_senddmactrl = 0;
@@ -1736,7 +1736,7 @@ static void init_sdma_regs(
 void sdma_dumpstate(struct sdma_engine *sde)
 {
u64 csr;
-   unsigned i;
+   unsigned int i;
 
sdma_dumpstate_helper(SD(CTRL));
sdma_dumpstate_helper(SD(STATUS));
@@ -1854,7 +1854,7 @@ void sdma_seqfile_dump_sde(struct seq_file *s, struct 
sdma_engine *sde)
u16 len;
 
head = sde->descq_head & sde->sdma_mask;
-   tail = ACCESS_ONCE(sde->descq_tail) & sde->sdma_mask;
+   tail = READ_ONCE(sde->descq_tail) & sde->sdma_mask;
seq_printf(s, SDE_FMT, sde->this_idx,
   sde->cpu,
   sdma_state_

[PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

[Shyam Saini]

Fixed following checkpatch.pl warnings:
  Prefer 'unsigned int' to bare use of 'unsigned'
  Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/rdma/hfi1/rc.c  | 12 ++--
 drivers/staging/rdma/hfi1/ruc.c |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/rc.c b/drivers/staging/rdma/hfi1/rc.c
index 792f15e..fb3a6c1 100644
--- a/drivers/staging/rdma/hfi1/rc.c
+++ b/drivers/staging/rdma/hfi1/rc.c
@@ -421,7 +421,7 @@ int hfi1_make_rc_req(struct rvt_qp *qp, struct 
hfi1_pkt_state *ps)
goto bail;
/* We are in the error state, flush the work request. */
smp_read_barrier_depends(); /* see post_one_send() */
-   if (qp->s_last == ACCESS_ONCE(qp->s_head))
+   if (qp->s_last == READ_ONCE(qp->s_head))
goto bail;
/* If DMAs are in progress, we can't flush immediately. */
if (iowait_sdma_pending(>s_iowait)) {
@@ -1103,7 +1103,7 @@ void hfi1_rc_send_complete(struct rvt_qp *qp, struct 
hfi1_ib_header *hdr)
struct hfi1_other_headers *ohdr;
struct rvt_swqe *wqe;
struct ib_wc wc;
-   unsigned i;
+   unsigned int i;
u32 opcode;
u32 psn;
 
@@ -1196,7 +1196,7 @@ static struct rvt_swqe *do_rc_completion(struct rvt_qp 
*qp,
 struct hfi1_ibport *ibp)
 {
struct ib_wc wc;
-   unsigned i;
+   unsigned int i;
 
/*
 * Don't decrement refcount and don't generate a
@@ -1571,7 +1571,7 @@ static void rc_rcv_resp(struct hfi1_ibport *ibp,
 
/* Ignore invalid responses. */
smp_read_barrier_depends(); /* see post_one_send */
-   if (cmp_psn(psn, ACCESS_ONCE(qp->s_next_psn)) >= 0)
+   if (cmp_psn(psn, READ_ONCE(qp->s_next_psn)) >= 0)
goto ack_done;
 
/* Ignore duplicate responses. */
@@ -1970,9 +1970,9 @@ void hfi1_rc_error(struct rvt_qp *qp, enum ib_wc_status 
err)
}
 }
 
-static inline void update_ack_queue(struct rvt_qp *qp, unsigned n)
+static inline void update_ack_queue(struct rvt_qp *qp, unsigned int n)
 {
-   unsigned next;
+   unsigned int next;
 
next = n + 1;
if (next > HFI1_MAX_RDMA_ATOMIC)
diff --git a/drivers/staging/rdma/hfi1/ruc.c b/drivers/staging/rdma/hfi1/ruc.c
index a659aec..cb64c80 100644
--- a/drivers/staging/rdma/hfi1/ruc.c
+++ b/drivers/staging/rdma/hfi1/ruc.c
@@ -239,7 +239,7 @@ bail:
return ret;
 }
 
-static __be64 get_sguid(struct hfi1_ibport *ibp, unsigned index)
+static __be64 get_sguid(struct hfi1_ibport *ibp, unsigned int index)
 {
if (!index) {
struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
@@ -393,7 +393,7 @@ static void ruc_loopback(struct rvt_qp *sqp)
 
 again:
smp_read_barrier_depends(); /* see post_one_send() */
-   if (sqp->s_last == ACCESS_ONCE(sqp->s_head))
+   if (sqp->s_last == READ_ONCE(sqp->s_head))
goto clr_busy;
wqe = rvt_get_swqe_ptr(sqp, sqp->s_last);
 
@@ -929,7 +929,7 @@ void hfi1_send_complete(struct rvt_qp *qp, struct rvt_swqe 
*wqe,
enum ib_wc_status status)
 {
u32 old_last, last;
-   unsigned i;
+   unsigned int i;
 
if (!(ib_rvt_state_ops[qp->state] & RVT_PROCESS_OR_FLUSH_SEND))
return;
-- 
1.9.1

[PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

[Shyam Saini]

Fixed following checkpatch.pl warnings:
Prefer 'unsigned int' to bare use of 'unsigned'
Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini 
---
 drivers/staging/rdma/hfi1/sdma.c | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index abb8ebc..c2e2856 100644
--- a/drivers/staging/rdma/hfi1/sdma.c
+++ b/drivers/staging/rdma/hfi1/sdma.c
@@ -234,7 +234,7 @@ static void sdma_put(struct sdma_state *);
 static void sdma_set_state(struct sdma_engine *, enum sdma_states);
 static void sdma_start_hw_clean_up(struct sdma_engine *);
 static void sdma_sw_clean_up_task(unsigned long);
-static void sdma_sendctrl(struct sdma_engine *, unsigned);
+static void sdma_sendctrl(struct sdma_engine *, unsigned int);
 static void init_sdma_regs(struct sdma_engine *, u32, uint);
 static void sdma_process_event(
struct sdma_engine *sde,
@@ -244,7 +244,7 @@ static void __sdma_process_event(
enum sdma_events event);
 static void dump_sdma_state(struct sdma_engine *sde);
 static void sdma_make_progress(struct sdma_engine *sde, u64 status);
-static void sdma_desc_avail(struct sdma_engine *sde, unsigned avail);
+static void sdma_desc_avail(struct sdma_engine *sde, unsigned int avail);
 static void sdma_flush_descq(struct sdma_engine *sde);
 
 /**
@@ -346,7 +346,7 @@ void sdma_wait(struct hfi1_devdata *dd)
}
 }
 
-static inline void sdma_set_desc_cnt(struct sdma_engine *sde, unsigned cnt)
+static inline void sdma_set_desc_cnt(struct sdma_engine *sde, unsigned int cnt)
 {
u64 reg;
 
@@ -472,7 +472,7 @@ static void sdma_err_halt_wait(struct work_struct *work)
 static void sdma_err_progress_check_schedule(struct sdma_engine *sde)
 {
if (!is_bx(sde->dd) && HFI1_CAP_IS_KSET(SDMA_AHG)) {
-   unsigned index;
+   unsigned int index;
struct hfi1_devdata *dd = sde->dd;
 
for (index = 0; index < dd->num_sdma; index++) {
@@ -491,7 +491,7 @@ static void sdma_err_progress_check_schedule(struct 
sdma_engine *sde)
 
 static void sdma_err_progress_check(unsigned long data)
 {
-   unsigned index;
+   unsigned int index;
struct sdma_engine *sde = (struct sdma_engine *)data;
 
dd_dev_err(sde->dd, "SDE progress check event\n");
@@ -657,7 +657,7 @@ static void sdma_set_state(struct sdma_engine *sde,
 {
struct sdma_state *ss = >state;
const struct sdma_set_state_action *action = sdma_action_table;
-   unsigned op = 0;
+   unsigned int op = 0;
 
trace_hfi1_sdma_state(
sde,
@@ -989,7 +989,7 @@ static void sdma_clean(struct hfi1_devdata *dd, size_t 
num_engines)
  */
 int sdma_init(struct hfi1_devdata *dd, u8 port)
 {
-   unsigned this_idx;
+   unsigned int this_idx;
struct sdma_engine *sde;
u16 descq_cnt;
void *curr_head;
@@ -1213,7 +1213,7 @@ void sdma_all_idle(struct hfi1_devdata *dd)
  */
 void sdma_start(struct hfi1_devdata *dd)
 {
-   unsigned i;
+   unsigned int i;
struct sdma_engine *sde;
 
/* kick off the engines state processing */
@@ -1229,7 +1229,7 @@ void sdma_start(struct hfi1_devdata *dd)
  */
 void sdma_exit(struct hfi1_devdata *dd)
 {
-   unsigned this_idx;
+   unsigned int this_idx;
struct sdma_engine *sde;
 
for (this_idx = 0; dd->per_sdma && this_idx < dd->num_sdma;
@@ -1351,7 +1351,7 @@ retry:
 
swhead = sde->descq_head & sde->sdma_mask;
/* this code is really bad for cache line trading */
-   swtail = ACCESS_ONCE(sde->descq_tail) & sde->sdma_mask;
+   swtail = READ_ONCE(sde->descq_tail) & sde->sdma_mask;
cnt = sde->descq_cnt;
 
if (swhead < swtail)
@@ -1557,7 +1557,7 @@ void sdma_engine_error(struct sdma_engine *sde, u64 
status)
spin_unlock_irqrestore(>tail_lock, flags);
 }
 
-static void sdma_sendctrl(struct sdma_engine *sde, unsigned op)
+static void sdma_sendctrl(struct sdma_engine *sde, unsigned int op)
 {
u64 set_senddmactrl = 0;
u64 clr_senddmactrl = 0;
@@ -1736,7 +1736,7 @@ static void init_sdma_regs(
 void sdma_dumpstate(struct sdma_engine *sde)
 {
u64 csr;
-   unsigned i;
+   unsigned int i;
 
sdma_dumpstate_helper(SD(CTRL));
sdma_dumpstate_helper(SD(STATUS));
@@ -1854,7 +1854,7 @@ void sdma_seqfile_dump_sde(struct seq_file *s, struct 
sdma_engine *sde)
u16 len;
 
head = sde->descq_head & sde->sdma_mask;
-   tail = ACCESS_ONCE(sde->descq_tail) & sde->sdma_mask;
+   tail = READ_ONCE(sde->descq_tail) & sde->sdma_mask;
seq_printf(s, SDE_FMT, sde->this_idx,
   sde->cpu,
   sdma_state_name(sde->state.current_state),
@@ -1

[PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

[Shyam Saini]

Fixed following checkpatch.pl warnings:
  Prefer 'unsigned int' to bare use of 'unsigned'
  Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini 
---
 drivers/staging/rdma/hfi1/rc.c  | 12 ++--
 drivers/staging/rdma/hfi1/ruc.c |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/rc.c b/drivers/staging/rdma/hfi1/rc.c
index 792f15e..fb3a6c1 100644
--- a/drivers/staging/rdma/hfi1/rc.c
+++ b/drivers/staging/rdma/hfi1/rc.c
@@ -421,7 +421,7 @@ int hfi1_make_rc_req(struct rvt_qp *qp, struct 
hfi1_pkt_state *ps)
goto bail;
/* We are in the error state, flush the work request. */
smp_read_barrier_depends(); /* see post_one_send() */
-   if (qp->s_last == ACCESS_ONCE(qp->s_head))
+   if (qp->s_last == READ_ONCE(qp->s_head))
goto bail;
/* If DMAs are in progress, we can't flush immediately. */
if (iowait_sdma_pending(>s_iowait)) {
@@ -1103,7 +1103,7 @@ void hfi1_rc_send_complete(struct rvt_qp *qp, struct 
hfi1_ib_header *hdr)
struct hfi1_other_headers *ohdr;
struct rvt_swqe *wqe;
struct ib_wc wc;
-   unsigned i;
+   unsigned int i;
u32 opcode;
u32 psn;
 
@@ -1196,7 +1196,7 @@ static struct rvt_swqe *do_rc_completion(struct rvt_qp 
*qp,
 struct hfi1_ibport *ibp)
 {
struct ib_wc wc;
-   unsigned i;
+   unsigned int i;
 
/*
 * Don't decrement refcount and don't generate a
@@ -1571,7 +1571,7 @@ static void rc_rcv_resp(struct hfi1_ibport *ibp,
 
/* Ignore invalid responses. */
smp_read_barrier_depends(); /* see post_one_send */
-   if (cmp_psn(psn, ACCESS_ONCE(qp->s_next_psn)) >= 0)
+   if (cmp_psn(psn, READ_ONCE(qp->s_next_psn)) >= 0)
goto ack_done;
 
/* Ignore duplicate responses. */
@@ -1970,9 +1970,9 @@ void hfi1_rc_error(struct rvt_qp *qp, enum ib_wc_status 
err)
}
 }
 
-static inline void update_ack_queue(struct rvt_qp *qp, unsigned n)
+static inline void update_ack_queue(struct rvt_qp *qp, unsigned int n)
 {
-   unsigned next;
+   unsigned int next;
 
next = n + 1;
if (next > HFI1_MAX_RDMA_ATOMIC)
diff --git a/drivers/staging/rdma/hfi1/ruc.c b/drivers/staging/rdma/hfi1/ruc.c
index a659aec..cb64c80 100644
--- a/drivers/staging/rdma/hfi1/ruc.c
+++ b/drivers/staging/rdma/hfi1/ruc.c
@@ -239,7 +239,7 @@ bail:
return ret;
 }
 
-static __be64 get_sguid(struct hfi1_ibport *ibp, unsigned index)
+static __be64 get_sguid(struct hfi1_ibport *ibp, unsigned int index)
 {
if (!index) {
struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
@@ -393,7 +393,7 @@ static void ruc_loopback(struct rvt_qp *sqp)
 
 again:
smp_read_barrier_depends(); /* see post_one_send() */
-   if (sqp->s_last == ACCESS_ONCE(sqp->s_head))
+   if (sqp->s_last == READ_ONCE(sqp->s_head))
goto clr_busy;
wqe = rvt_get_swqe_ptr(sqp, sqp->s_last);
 
@@ -929,7 +929,7 @@ void hfi1_send_complete(struct rvt_qp *qp, struct rvt_swqe 
*wqe,
enum ib_wc_status status)
 {
u32 old_last, last;
-   unsigned i;
+   unsigned int i;
 
if (!(ib_rvt_state_ops[qp->state] & RVT_PROCESS_OR_FLUSH_SEND))
return;
-- 
1.9.1

[PATCH 1/1] Staging: comedi: comedi_fops.c: Fixed coding style issue

[Shyam Saini]

Fixed following checkpatch.pl warnings
WARNING: Prefer WRITE_ONCE(, ) over ACCESS_ONCE() = 

WARNING: Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c 
b/drivers/staging/comedi/comedi_fops.c
index 629080f..4d87596 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -312,8 +312,8 @@ static void comedi_file_reset(struct file *file)
}
cfp->last_attached = dev->attached;
cfp->last_detach_count = dev->detach_count;
-   ACCESS_ONCE(cfp->read_subdev) = read_s;
-   ACCESS_ONCE(cfp->write_subdev) = write_s;
+   WRITE_ONCE(cfp->read_subdev, read_s);
+   WRITE_ONCE(cfp->write_subdev, write_s);
 }
 
 static void comedi_file_check(struct file *file)
@@ -331,7 +331,7 @@ static struct comedi_subdevice 
*comedi_file_read_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data;
 
comedi_file_check(file);
-   return ACCESS_ONCE(cfp->read_subdev);
+   return READ_ONCE(cfp->read_subdev);
 }
 
 static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
@@ -339,7 +339,7 @@ static struct comedi_subdevice 
*comedi_file_write_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data;
 
comedi_file_check(file);
-   return ACCESS_ONCE(cfp->write_subdev);
+   return READ_ONCE(cfp->write_subdev);
 }
 
 static int resize_async_buffer(struct comedi_device *dev,
@@ -1992,7 +1992,7 @@ static int do_setrsubd_ioctl(struct comedi_device *dev, 
unsigned long arg,
!(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
 
-   ACCESS_ONCE(cfp->read_subdev) = s_new;
+   WRITE_ONCE(cfp->read_subdev, s_new);
return 0;
 }
 
@@ -2034,7 +2034,7 @@ static int do_setwsubd_ioctl(struct comedi_device *dev, 
unsigned long arg,
(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
 
-   ACCESS_ONCE(cfp->write_subdev) = s_new;
+   WRITE_ONCE(cfp->write_subdev, s_new);
return 0;
 }
 
-- 
1.9.1

[PATCH 1/1] Staging: comedi: comedi_fops.c: Fixed coding style issue

[Shyam Saini]

Fixed following checkpatch.pl warnings
WARNING: Prefer WRITE_ONCE(, ) over ACCESS_ONCE() = 

WARNING: Prefer READ_ONCE() over ACCESS_ONCE()

Signed-off-by: Shyam Saini 
---
 drivers/staging/comedi/comedi_fops.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c 
b/drivers/staging/comedi/comedi_fops.c
index 629080f..4d87596 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -312,8 +312,8 @@ static void comedi_file_reset(struct file *file)
}
cfp->last_attached = dev->attached;
cfp->last_detach_count = dev->detach_count;
-   ACCESS_ONCE(cfp->read_subdev) = read_s;
-   ACCESS_ONCE(cfp->write_subdev) = write_s;
+   WRITE_ONCE(cfp->read_subdev, read_s);
+   WRITE_ONCE(cfp->write_subdev, write_s);
 }
 
 static void comedi_file_check(struct file *file)
@@ -331,7 +331,7 @@ static struct comedi_subdevice 
*comedi_file_read_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data;
 
comedi_file_check(file);
-   return ACCESS_ONCE(cfp->read_subdev);
+   return READ_ONCE(cfp->read_subdev);
 }
 
 static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
@@ -339,7 +339,7 @@ static struct comedi_subdevice 
*comedi_file_write_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data;
 
comedi_file_check(file);
-   return ACCESS_ONCE(cfp->write_subdev);
+   return READ_ONCE(cfp->write_subdev);
 }
 
 static int resize_async_buffer(struct comedi_device *dev,
@@ -1992,7 +1992,7 @@ static int do_setrsubd_ioctl(struct comedi_device *dev, 
unsigned long arg,
!(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
 
-   ACCESS_ONCE(cfp->read_subdev) = s_new;
+   WRITE_ONCE(cfp->read_subdev, s_new);
return 0;
 }
 
@@ -2034,7 +2034,7 @@ static int do_setwsubd_ioctl(struct comedi_device *dev, 
unsigned long arg,
(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
 
-   ACCESS_ONCE(cfp->write_subdev) = s_new;
+   WRITE_ONCE(cfp->write_subdev, s_new);
return 0;
 }
 
-- 
1.9.1

[PATCH 1/1] Staging: emxx_udc: emxx_udc: fixed coding style issue

[Shyam Saini]

fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned'

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c 
b/drivers/staging/emxx_udc/emxx_udc.c
index 58e189b7..3bd9175 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3051,7 +3051,7 @@ static int nbu2ss_gad_vbus_session(struct usb_gadget 
*pgadget, int is_active)
 }
 
 /*-*/
-static int nbu2ss_gad_vbus_draw(struct usb_gadget *pgadget, unsigned mA)
+static int nbu2ss_gad_vbus_draw(struct usb_gadget *pgadget, unsigned int mA)
 {
struct nbu2ss_udc   *udc;
unsigned long   flags;
@@ -3101,7 +3101,7 @@ static int nbu2ss_gad_pullup(struct usb_gadget *pgadget, 
int is_on)
 /*-*/
 static int nbu2ss_gad_ioctl(
struct usb_gadget *pgadget,
-   unsigned code,
+   unsigned int code,
unsigned long param)
 {
return 0;
-- 
1.9.1

[PATCH 1/1] Staging: emxx_udc: emxx_udc: fixed coding style issue

[Shyam Saini]

fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned'

Signed-off-by: Shyam Saini 
---
 drivers/staging/emxx_udc/emxx_udc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c 
b/drivers/staging/emxx_udc/emxx_udc.c
index 58e189b7..3bd9175 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3051,7 +3051,7 @@ static int nbu2ss_gad_vbus_session(struct usb_gadget 
*pgadget, int is_active)
 }
 
 /*-*/
-static int nbu2ss_gad_vbus_draw(struct usb_gadget *pgadget, unsigned mA)
+static int nbu2ss_gad_vbus_draw(struct usb_gadget *pgadget, unsigned int mA)
 {
struct nbu2ss_udc   *udc;
unsigned long   flags;
@@ -3101,7 +3101,7 @@ static int nbu2ss_gad_pullup(struct usb_gadget *pgadget, 
int is_on)
 /*-*/
 static int nbu2ss_gad_ioctl(
struct usb_gadget *pgadget,
-   unsigned code,
+   unsigned int code,
unsigned long param)
 {
return 0;
-- 
1.9.1

[PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

[Shyam Saini]

Fixed following warning detected by checkpatch.pl:
warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare 
__aligned(2)

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 25 +++
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c 
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index b76622d..3a5d04a 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -363,8 +363,8 @@ static void add_network_to_shadow(struct network_info 
*pstrNetworkInfo,
last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len;
memcpy(last_scanned_shadow[ap_index].ssid,
   pstrNetworkInfo->ssid, pstrNetworkInfo->ssid_len);
-   memcpy(last_scanned_shadow[ap_index].bssid,
-  pstrNetworkInfo->bssid, ETH_ALEN);
+   ether_addr_copy(last_scanned_shadow[ap_index].bssid,
+  pstrNetworkInfo->bssid);
last_scanned_shadow[ap_index].beacon_period = 
pstrNetworkInfo->beacon_period;
last_scanned_shadow[ap_index].dtim_period = 
pstrNetworkInfo->dtim_period;
last_scanned_shadow[ap_index].ch = pstrNetworkInfo->ch;
@@ -521,7 +521,7 @@ static void CfgConnectResult(enum conn_event 
enuConnDisconnEvent,
bool bNeedScanRefresh = false;
u32 i;
 
-   memcpy(priv->au8AssociatedBss, pstrConnectInfo->bssid, 
ETH_ALEN);
+   ether_addr_copy(priv->au8AssociatedBss, 
pstrConnectInfo->bssid);
 
 
for (i = 0; i < last_scanned_cnt; i++) {
@@ -1000,7 +1000,7 @@ static int add_key(struct wiphy *wiphy, struct net_device 
*netdev, u8 key_index,
g_add_gtk_key_params.mac_addr = 
NULL;
} else {
g_add_gtk_key_params.mac_addr = 
kmalloc(ETH_ALEN, GFP_KERNEL);
-   
memcpy(g_add_gtk_key_params.mac_addr, mac_addr, ETH_ALEN);
+   
ether_addr_copy(g_add_gtk_key_params.mac_addr, mac_addr);
}
g_key_gtk_params.key_len = 
params->key_len;
g_key_gtk_params.seq_len = 
params->seq_len;
@@ -1033,7 +1033,7 @@ static int add_key(struct wiphy *wiphy, struct net_device 
*netdev, u8 key_index,
g_add_ptk_key_params.mac_addr = 
NULL;
} else {
g_add_ptk_key_params.mac_addr = 
kmalloc(ETH_ALEN, GFP_KERNEL);
-   
memcpy(g_add_ptk_key_params.mac_addr, mac_addr, ETH_ALEN);
+   
ether_addr_copy(g_add_ptk_key_params.mac_addr, mac_addr);
}
g_key_ptk_params.key_len = 
params->key_len;
g_key_ptk_params.seq_len = 
params->seq_len;
@@ -1287,8 +1287,8 @@ static int set_pmksa(struct wiphy *wiphy, struct 
net_device *netdev,
}
}
if (i < WILC_MAX_NUM_PMKIDS) {
-   memcpy(priv->pmkid_list.pmkidlist[i].bssid, pmksa->bssid,
-   ETH_ALEN);
+   ether_addr_copy(priv->pmkid_list.pmkidlist[i].bssid,
+   pmksa->bssid);
memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
PMKID_LEN);
if (!(flag == PMKID_FOUND))
@@ -1322,9 +1322,8 @@ static int del_pmksa(struct wiphy *wiphy, struct 
net_device *netdev,
 
if (i < priv->pmkid_list.numpmkid && priv->pmkid_list.numpmkid > 0) {
for (; i < (priv->pmkid_list.numpmkid - 1); i++) {
-   memcpy(priv->pmkid_list.pmkidlist[i].bssid,
-   priv->pmkid_list.pmkidlist[i + 1].bssid,
-   ETH_ALEN);
+   ether_addr_copy(priv->pmkid_list.pmkidlist[i].bssid,
+   priv->pmkid_list.pmkidlist[i + 1].bssid);
memcpy(priv->pmkid_list.pmkidlist[i].pmkid,
priv->pmkid_list.pmkidlist[i].pmkid,
PMKID_LEN);
@@ -1983,8 +1982,8 @@ static int add_station(struct wiphy *wiphy, struct 
net_device *dev,
vif = netdev_priv(dev);
 
if (vif->iftype == AP_MODE || vif->iftype == GO_MODE) {
-   memcpy(strStaParams.bssid, mac, ETH_ALEN)

[PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

[Shyam Saini]

Fixed following warning detected by checkpatch.pl:
warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare 
__aligned(2)

Signed-off-by: Shyam Saini 
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 25 +++
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c 
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index b76622d..3a5d04a 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -363,8 +363,8 @@ static void add_network_to_shadow(struct network_info 
*pstrNetworkInfo,
last_scanned_shadow[ap_index].ssid_len = pstrNetworkInfo->ssid_len;
memcpy(last_scanned_shadow[ap_index].ssid,
   pstrNetworkInfo->ssid, pstrNetworkInfo->ssid_len);
-   memcpy(last_scanned_shadow[ap_index].bssid,
-  pstrNetworkInfo->bssid, ETH_ALEN);
+   ether_addr_copy(last_scanned_shadow[ap_index].bssid,
+  pstrNetworkInfo->bssid);
last_scanned_shadow[ap_index].beacon_period = 
pstrNetworkInfo->beacon_period;
last_scanned_shadow[ap_index].dtim_period = 
pstrNetworkInfo->dtim_period;
last_scanned_shadow[ap_index].ch = pstrNetworkInfo->ch;
@@ -521,7 +521,7 @@ static void CfgConnectResult(enum conn_event 
enuConnDisconnEvent,
bool bNeedScanRefresh = false;
u32 i;
 
-   memcpy(priv->au8AssociatedBss, pstrConnectInfo->bssid, 
ETH_ALEN);
+   ether_addr_copy(priv->au8AssociatedBss, 
pstrConnectInfo->bssid);
 
 
for (i = 0; i < last_scanned_cnt; i++) {
@@ -1000,7 +1000,7 @@ static int add_key(struct wiphy *wiphy, struct net_device 
*netdev, u8 key_index,
g_add_gtk_key_params.mac_addr = 
NULL;
} else {
g_add_gtk_key_params.mac_addr = 
kmalloc(ETH_ALEN, GFP_KERNEL);
-   
memcpy(g_add_gtk_key_params.mac_addr, mac_addr, ETH_ALEN);
+   
ether_addr_copy(g_add_gtk_key_params.mac_addr, mac_addr);
}
g_key_gtk_params.key_len = 
params->key_len;
g_key_gtk_params.seq_len = 
params->seq_len;
@@ -1033,7 +1033,7 @@ static int add_key(struct wiphy *wiphy, struct net_device 
*netdev, u8 key_index,
g_add_ptk_key_params.mac_addr = 
NULL;
} else {
g_add_ptk_key_params.mac_addr = 
kmalloc(ETH_ALEN, GFP_KERNEL);
-   
memcpy(g_add_ptk_key_params.mac_addr, mac_addr, ETH_ALEN);
+   
ether_addr_copy(g_add_ptk_key_params.mac_addr, mac_addr);
}
g_key_ptk_params.key_len = 
params->key_len;
g_key_ptk_params.seq_len = 
params->seq_len;
@@ -1287,8 +1287,8 @@ static int set_pmksa(struct wiphy *wiphy, struct 
net_device *netdev,
}
}
if (i < WILC_MAX_NUM_PMKIDS) {
-   memcpy(priv->pmkid_list.pmkidlist[i].bssid, pmksa->bssid,
-   ETH_ALEN);
+   ether_addr_copy(priv->pmkid_list.pmkidlist[i].bssid,
+   pmksa->bssid);
memcpy(priv->pmkid_list.pmkidlist[i].pmkid, pmksa->pmkid,
PMKID_LEN);
if (!(flag == PMKID_FOUND))
@@ -1322,9 +1322,8 @@ static int del_pmksa(struct wiphy *wiphy, struct 
net_device *netdev,
 
if (i < priv->pmkid_list.numpmkid && priv->pmkid_list.numpmkid > 0) {
for (; i < (priv->pmkid_list.numpmkid - 1); i++) {
-   memcpy(priv->pmkid_list.pmkidlist[i].bssid,
-   priv->pmkid_list.pmkidlist[i + 1].bssid,
-   ETH_ALEN);
+   ether_addr_copy(priv->pmkid_list.pmkidlist[i].bssid,
+   priv->pmkid_list.pmkidlist[i + 1].bssid);
memcpy(priv->pmkid_list.pmkidlist[i].pmkid,
priv->pmkid_list.pmkidlist[i].pmkid,
PMKID_LEN);
@@ -1983,8 +1982,8 @@ static int add_station(struct wiphy *wiphy, struct 
net_device *dev,
vif = netdev_priv(dev);
 
if (vif->iftype == AP_MODE || vif->iftype == GO_MODE) {
-   memcpy(strStaParams.bssid, mac, ETH_ALEN);
-   memcpy(priv-

[PATCH] Staging: android: timed_gpio: fixed bare use of 'unsigned'

[Shyam Saini]

'unsigned int gpio' is added in place of 'unsigned gpio'

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/staging/android/timed_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/timed_gpio.c 
b/drivers/staging/android/timed_gpio.c
index 914fd10..8926b3f 100644
--- a/drivers/staging/android/timed_gpio.c
+++ b/drivers/staging/android/timed_gpio.c
@@ -29,7 +29,7 @@ struct timed_gpio_data {
struct timed_output_dev dev;
struct hrtimer timer;
spinlock_t lock;
-   unsigned gpio;
+   unsigned int gpio;
int max_timeout;
u8 active_low;
 };
-- 
1.9.1

[PATCH] Staging: android: timed_gpio: fixed bare use of 'unsigned'

[Shyam Saini]

'unsigned int gpio' is added in place of 'unsigned gpio'

Signed-off-by: Shyam Saini 
---
 drivers/staging/android/timed_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/timed_gpio.c 
b/drivers/staging/android/timed_gpio.c
index 914fd10..8926b3f 100644
--- a/drivers/staging/android/timed_gpio.c
+++ b/drivers/staging/android/timed_gpio.c
@@ -29,7 +29,7 @@ struct timed_gpio_data {
struct timed_output_dev dev;
struct hrtimer timer;
spinlock_t lock;
-   unsigned gpio;
+   unsigned int gpio;
int max_timeout;
u8 active_low;
 };
-- 
1.9.1