Re: Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
On 1/23/18, Michael Ellerman <m...@ellerman.id.au> wrote: > This has been broken in linux-next for ~6 weeks now, can we please merge > this and get it fixed. Added Stephen Rothwell to cc -- Vincent Legoll
Re: Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
On 1/23/18, Michael Ellerman wrote: > This has been broken in linux-next for ~6 weeks now, can we please merge > this and get it fixed. Added Stephen Rothwell to cc -- Vincent Legoll
[PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: Added "default y" to avoid breaking existing configs v3: Fixed wrong indentation, added *-by from Randy Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> Reviewed-by: Randy Dunlap <rdun...@infradead.org> Tested-by: Randy Dunlap <rdun...@infradead.org> # works for me --- drivers/virtio/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..35897649c24f 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,11 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + default y + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.14.1
[PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: Added "default y" to avoid breaking existing configs v3: Fixed wrong indentation, added *-by from Randy Signed-off-by: Vincent Legoll Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap # works for me --- drivers/virtio/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..35897649c24f 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,11 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + default y + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.14.1
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- lib/Kconfig.debug | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9d5b78aad4c5..732f7b09ad6f 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1627,7 +1627,11 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + default y + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll --- lib/Kconfig.debug | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9d5b78aad4c5..732f7b09ad6f 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1627,7 +1627,11 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + default y + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
Argh, sorry for the forgotten "git add", hopefuly this one will be good
[PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
Argh, sorry for the forgotten "git add", hopefuly this one will be good
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9d5b78aad4c5..ef6db62a5deb 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1627,7 +1627,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1915,7 +1918,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9d5b78aad4c5..ef6db62a5deb 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1627,7 +1627,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1915,7 +1918,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
Is this one better ?
[PATCH, v2] make RUNTIME_TESTS a menuconfig to ease disabling it all
Is this one better ?
Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
Hello, On Fri, Jan 5, 2018 at 12:40 PM, Daniel Thompson <daniel.thomp...@linaro.org> wrote: > Wouldn't you need a "default y" applied to the menuconfig to achieve this? > > With this patch applied defconfigs that enable LKDTM by default will no > longer do so (default_defconfig from arch/s390 is an example although there > are others). Yes, you're right, I'll resend a v2 with the default y added Thanks -- Vincent Legoll
Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
Hello, On Fri, Jan 5, 2018 at 12:40 PM, Daniel Thompson wrote: > Wouldn't you need a "default y" applied to the menuconfig to achieve this? > > With this patch applied defconfigs that enable LKDTM by default will no > longer do so (default_defconfig from arch/s390 is an example although there > are others). Yes, you're right, I'll resend a v2 with the default y added Thanks -- Vincent Legoll
[PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: Added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com>
[PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: Added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll
[PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: add "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/virtio/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..290a1875e1d3 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,11 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + default y + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.11.0
[PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: add "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll --- drivers/virtio/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..290a1875e1d3 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,11 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + default y + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.11.0
Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
Hello, thanks for the help, and sorry for the poor patch, On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <m...@ellerman.id.au> wrote: > This breaks all existing .configs *and* defconfigs that use VIRTIO. > > Please don't do that. > > If you make it default y then everything will continue to work. Do you want me to respin it with the added default ? Tchuss -- Vincent Legoll
Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
Hello, thanks for the help, and sorry for the poor patch, On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman wrote: > This breaks all existing .configs *and* defconfigs that use VIRTIO. > > Please don't do that. > > If you make it default y then everything will continue to work. Do you want me to respin it with the added default ? Tchuss -- Vincent Legoll
Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
Hello, On Sat, Dec 16, 2017 at 6:51 PM, Stephen Hemminger <step...@networkplumber.org> wrote: > It makes sense to organize the config if you dont break old configs. > It would be more logical to group and treat all para-virtualized guest > support in same way. Hyper-V should be next to KVM and Xen. I agree, I can try to work on that too, as it would nicely complement the menuconfigifcation. -- Vincent Legoll
Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
Hello, On Sat, Dec 16, 2017 at 6:51 PM, Stephen Hemminger wrote: > It makes sense to organize the config if you dont break old configs. > It would be more logical to group and treat all para-virtualized guest > support in same way. Hyper-V should be next to KVM and Xen. I agree, I can try to work on that too, as it would nicely complement the menuconfigifcation. -- Vincent Legoll
[PATCH,v2] efi: make EFI a menuconfig to ease disabling it all
The following v2 patch adds the "default y" to avoid breaking existing configs. I don't know if using the CONFIG_EFI symbol would be better, it is spread in multiple arch/*/Kconfig files, and would make the changes more invasive. Please advise the way forward Thanks
[PATCH] efi: make EFI a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all EFI config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to menuconfig to avoid breaking existing configs. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/firmware/efi/Kconfig | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 2b4c39fdfa91..2ad237b24afb 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -1,5 +1,9 @@ -menu "EFI (Extensible Firmware Interface) Support" +menuconfig EFI_MENU + bool "EFI (Extensible Firmware Interface) Support" depends on EFI + default y + +if EFI_MENU config EFI_VARS tristate "EFI Variable Support via sysfs" @@ -81,9 +85,6 @@ config EFI_PARAMS_FROM_FDT the EFI runtime support gets system table address, memory map address, and other parameters from the device tree. -config EFI_RUNTIME_WRAPPERS - bool - config EFI_ARMSTUB bool @@ -161,7 +162,10 @@ config RESET_ATTACK_MITIGATION still contains secrets in RAM, booting another OS and extracting the secrets. -endmenu +endif # EFI_MENU + +config EFI_RUNTIME_WRAPPERS + bool config UEFI_CPER bool -- 2.14.1
[PATCH,v2] efi: make EFI a menuconfig to ease disabling it all
The following v2 patch adds the "default y" to avoid breaking existing configs. I don't know if using the CONFIG_EFI symbol would be better, it is spread in multiple arch/*/Kconfig files, and would make the changes more invasive. Please advise the way forward Thanks
[PATCH] efi: make EFI a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all EFI config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to menuconfig to avoid breaking existing configs. Signed-off-by: Vincent Legoll --- drivers/firmware/efi/Kconfig | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 2b4c39fdfa91..2ad237b24afb 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -1,5 +1,9 @@ -menu "EFI (Extensible Firmware Interface) Support" +menuconfig EFI_MENU + bool "EFI (Extensible Firmware Interface) Support" depends on EFI + default y + +if EFI_MENU config EFI_VARS tristate "EFI Variable Support via sysfs" @@ -81,9 +85,6 @@ config EFI_PARAMS_FROM_FDT the EFI runtime support gets system table address, memory map address, and other parameters from the device tree. -config EFI_RUNTIME_WRAPPERS - bool - config EFI_ARMSTUB bool @@ -161,7 +162,10 @@ config RESET_ATTACK_MITIGATION still contains secrets in RAM, booting another OS and extracting the secrets. -endmenu +endif # EFI_MENU + +config EFI_RUNTIME_WRAPPERS + bool config UEFI_CPER bool -- 2.14.1
[PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
No need to get into the submenu to disable all HYPERV-related config entries. This makes it easier to disable all HYPERV config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/hv/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 50b89ea0e60f..a6cda712135f 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -1,4 +1,8 @@ -menu "Microsoft Hyper-V guest support" +menuconfig HYPERV_MENU + bool "Microsoft Hyper-V guest support" + default y + +if HYPERV_MENU config HYPERV tristate "Microsoft Hyper-V client drivers" @@ -23,4 +27,4 @@ config HYPERV_BALLOON help Select this option to enable Hyper-V Balloon driver. -endmenu +endif # HYPERV_MENU -- 2.14.1
[PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
No need to get into the submenu to disable all HYPERV-related config entries. This makes it easier to disable all HYPERV config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. v2: added "default y" to avoid breaking existing configs Signed-off-by: Vincent Legoll --- drivers/hv/Kconfig | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 50b89ea0e60f..a6cda712135f 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -1,4 +1,8 @@ -menu "Microsoft Hyper-V guest support" +menuconfig HYPERV_MENU + bool "Microsoft Hyper-V guest support" + default y + +if HYPERV_MENU config HYPERV tristate "Microsoft Hyper-V client drivers" @@ -23,4 +27,4 @@ config HYPERV_BALLOON help Select this option to enable Hyper-V Balloon driver. -endmenu +endif # HYPERV_MENU -- 2.14.1
[PATCH,v2] hyperv: make HYPERV a menuconfig to ease disabling it al
Hello, The following patch add a "default y" to the menuconfig to avoid breaking existing configs. Please advise if this is better, and sufficient. Tell me if these kind of changes are not welcome in the kernel, so that I won't continue with other similar work. I am an actual user of menuconfig, and find it really harder to use than necessary. A lot of new drivers and config options have been added, with only a few relevant to my HW. It is getting very hard to go through menuconfig and disable all the unneeded stuff. I use distro kernels on some of my HW, but for the smaller armels or i686s, I actually want to strip the kernel config. I find the existing menuconfigs a good solution for that problem, because they allow me to disable huge lists of stuff when I know I don't need them without even bothering to enter the menu, an go to each one disabling it. I may not doing it all right, but I think this kind of patch helps at least some of us. Please advise if there's a better way. Thanks
[PATCH,v2] hyperv: make HYPERV a menuconfig to ease disabling it al
Hello, The following patch add a "default y" to the menuconfig to avoid breaking existing configs. Please advise if this is better, and sufficient. Tell me if these kind of changes are not welcome in the kernel, so that I won't continue with other similar work. I am an actual user of menuconfig, and find it really harder to use than necessary. A lot of new drivers and config options have been added, with only a few relevant to my HW. It is getting very hard to go through menuconfig and disable all the unneeded stuff. I use distro kernels on some of my HW, but for the smaller armels or i686s, I actually want to strip the kernel config. I find the existing menuconfigs a good solution for that problem, because they allow me to disable huge lists of stuff when I know I don't need them without even bothering to enter the menu, an go to each one disabling it. I may not doing it all right, but I think this kind of patch helps at least some of us. Please advise if there's a better way. Thanks
Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all
Hello, >> This looks fine to me. Ard? > > Doesn't this break existing configs? Would adding a "default yes" on the new menuconfig be OK. If yes, I'd respin it for a v2 -- Vincent Legoll
Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all
Hello, >> This looks fine to me. Ard? > > Doesn't this break existing configs? Would adding a "default yes" on the new menuconfig be OK. If yes, I'd respin it for a v2 -- Vincent Legoll
Re: [PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
Hello, looks like this one will need another spin, the kbuild test robot found some config mix that has unmet dependencies. Please drop until v3 -- Vincent Legoll
Re: [PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
Hello, looks like this one will need another spin, the kbuild test robot found some config mix that has unmet dependencies. Please drop until v3 -- Vincent Legoll
Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all
Hello, On Mon, Dec 11, 2017 at 4:28 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > NAK, you are introducing a new config option for no good reason. I don't think there are alternatives available in Kconfig to achieve the goal of easing the management of a .config with menuconfig. Do you have any idea about how to do it without using menuconfig ? Thanks -- Vincent Legoll
Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all
Hello, On Mon, Dec 11, 2017 at 4:28 AM, Richard Cochran wrote: > NAK, you are introducing a new config option for no good reason. I don't think there are alternatives available in Kconfig to achieve the goal of easing the management of a .config with menuconfig. Do you have any idea about how to do it without using menuconfig ? Thanks -- Vincent Legoll
Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
Hello, On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > Will this break existing configs? I don't think so. Last time I did some similar changes, the kbuild test robot found some warnings on some configurations, I hope it will find problems (if any) for that series too (this one is not alone, I've got a bunch of other similar patches in-flight) Thanks -- Vincent Legoll
Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
Hello, On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger wrote: > Will this break existing configs? I don't think so. Last time I did some similar changes, the kbuild test robot found some warnings on some configurations, I hope it will find problems (if any) for that series too (this one is not alone, I've got a bunch of other similar patches in-flight) Thanks -- Vincent Legoll
[PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all "Memory Debugging"-related config entries. This makes it easier to disable all "Memory Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Changes since v1: Move some invisible config options ouit of the if/endif DEBUG_MEMORY block to alleviate the warnings: "selects XXX which has unmet direct dependencies" This moves the HAVE_ARCH_KASAN out of Kconfig.kasan Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- lib/Kconfig.debug | 28 +--- lib/Kconfig.kasan | 3 --- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..19ca76e7b9ed 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -436,7 +436,10 @@ config DEBUG_KERNEL Say Y here if you are developing drivers or trying to debug and identify kernel problems. -menu "Memory Debugging" +menuconfig DEBUG_MEMORY + bool "Memory Debugging" + +if DEBUG_MEMORY source mm/Kconfig.debug @@ -539,9 +542,6 @@ config SLUB_STATS out which slabs are relevant to a particular load. Try running: slabinfo -DA -config HAVE_DEBUG_KMEMLEAK - bool - config DEBUG_KMEMLEAK bool "Kernel memory leak detector" depends on DEBUG_KERNEL && HAVE_DEBUG_KMEMLEAK @@ -636,9 +636,6 @@ config DEBUG_VM_PGFLAGS If unsure, say N. -config ARCH_HAS_DEBUG_VIRTUAL - bool - config DEBUG_VIRTUAL bool "Debug VM translations" depends on DEBUG_KERNEL && ARCH_HAS_DEBUG_VIRTUAL @@ -708,9 +705,6 @@ config DEBUG_HIGHMEM This option enables additional error checking for high memory systems. Disable for production systems. -config HAVE_DEBUG_STACKOVERFLOW - bool - config DEBUG_STACKOVERFLOW bool "Check for stack overflows" depends on DEBUG_KERNEL && HAVE_DEBUG_STACKOVERFLOW @@ -731,7 +725,19 @@ config DEBUG_STACKOVERFLOW source "lib/Kconfig.kasan" -endmenu # "Memory Debugging" +endif # DEBUG_MEMORY + +config HAVE_ARCH_KASAN + bool + +config ARCH_HAS_DEBUG_VIRTUAL + bool + +config HAVE_DEBUG_KMEMLEAK + bool + +config HAVE_DEBUG_STACKOVERFLOW + bool config ARCH_HAS_KCOV bool diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan index bd38aab05929..2396d5116e20 100644 --- a/lib/Kconfig.kasan +++ b/lib/Kconfig.kasan @@ -1,6 +1,3 @@ -config HAVE_ARCH_KASAN - bool - if HAVE_ARCH_KASAN config KASAN -- 2.14.1
[PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all "Memory Debugging"-related config entries. This makes it easier to disable all "Memory Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Changes since v1: Move some invisible config options ouit of the if/endif DEBUG_MEMORY block to alleviate the warnings: "selects XXX which has unmet direct dependencies" This moves the HAVE_ARCH_KASAN out of Kconfig.kasan Signed-off-by: Vincent Legoll --- lib/Kconfig.debug | 28 +--- lib/Kconfig.kasan | 3 --- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..19ca76e7b9ed 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -436,7 +436,10 @@ config DEBUG_KERNEL Say Y here if you are developing drivers or trying to debug and identify kernel problems. -menu "Memory Debugging" +menuconfig DEBUG_MEMORY + bool "Memory Debugging" + +if DEBUG_MEMORY source mm/Kconfig.debug @@ -539,9 +542,6 @@ config SLUB_STATS out which slabs are relevant to a particular load. Try running: slabinfo -DA -config HAVE_DEBUG_KMEMLEAK - bool - config DEBUG_KMEMLEAK bool "Kernel memory leak detector" depends on DEBUG_KERNEL && HAVE_DEBUG_KMEMLEAK @@ -636,9 +636,6 @@ config DEBUG_VM_PGFLAGS If unsure, say N. -config ARCH_HAS_DEBUG_VIRTUAL - bool - config DEBUG_VIRTUAL bool "Debug VM translations" depends on DEBUG_KERNEL && ARCH_HAS_DEBUG_VIRTUAL @@ -708,9 +705,6 @@ config DEBUG_HIGHMEM This option enables additional error checking for high memory systems. Disable for production systems. -config HAVE_DEBUG_STACKOVERFLOW - bool - config DEBUG_STACKOVERFLOW bool "Check for stack overflows" depends on DEBUG_KERNEL && HAVE_DEBUG_STACKOVERFLOW @@ -731,7 +725,19 @@ config DEBUG_STACKOVERFLOW source "lib/Kconfig.kasan" -endmenu # "Memory Debugging" +endif # DEBUG_MEMORY + +config HAVE_ARCH_KASAN + bool + +config ARCH_HAS_DEBUG_VIRTUAL + bool + +config HAVE_DEBUG_KMEMLEAK + bool + +config HAVE_DEBUG_STACKOVERFLOW + bool config ARCH_HAS_KCOV bool diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan index bd38aab05929..2396d5116e20 100644 --- a/lib/Kconfig.kasan +++ b/lib/Kconfig.kasan @@ -1,6 +1,3 @@ -config HAVE_ARCH_KASAN - bool - if HAVE_ARCH_KASAN config KASAN -- 2.14.1
[PATCH,v2] Make "Memory Debugging" a menuconfig to ease disabling it all
The v2 of the patch tries to do that, but the Kconfig.kasan modification is kind of infortunate, as it moves the HAVE_ARCH_KASAN config option out of that file. If this is not acceptable please advise on how I can achieve it. Thanks
[PATCH,v2] Make "Memory Debugging" a menuconfig to ease disabling it all
The v2 of the patch tries to do that, but the Kconfig.kasan modification is kind of infortunate, as it moves the HAVE_ARCH_KASAN config option out of that file. If this is not acceptable please advise on how I can achieve it. Thanks
[PATCH] Change some filesystem menus into menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all related config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- fs/Kconfig | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 7aee6d699fd6..94ee1422e995 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -105,29 +105,38 @@ source "fs/autofs4/Kconfig" source "fs/fuse/Kconfig" source "fs/overlayfs/Kconfig" -menu "Caches" +menuconfig FS_CACHE_MENU + bool "Caches" + +if FS_CACHE_MENU source "fs/fscache/Kconfig" source "fs/cachefiles/Kconfig" -endmenu +endif # FS_CACHE_MENU if BLOCK -menu "CD-ROM/DVD Filesystems" +menuconfig FS_CDVD_MENU + bool "CD-ROM/DVD Filesystems" + +if FS_CDVD_MENU source "fs/isofs/Kconfig" source "fs/udf/Kconfig" -endmenu +endif # FS_CDVD_MENU endif # BLOCK if BLOCK -menu "DOS/FAT/NT Filesystems" +menuconfig FS_FAT_MENU + bool "DOS/FAT/NT Filesystems" + +if FS_FAT_MENU source "fs/fat/Kconfig" source "fs/ntfs/Kconfig" -endmenu +endif # FS_FAT_MENU endif # BLOCK menu "Pseudo filesystems" -- 2.14.1
[PATCH] Change some filesystem menus into menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all related config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- fs/Kconfig | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 7aee6d699fd6..94ee1422e995 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -105,29 +105,38 @@ source "fs/autofs4/Kconfig" source "fs/fuse/Kconfig" source "fs/overlayfs/Kconfig" -menu "Caches" +menuconfig FS_CACHE_MENU + bool "Caches" + +if FS_CACHE_MENU source "fs/fscache/Kconfig" source "fs/cachefiles/Kconfig" -endmenu +endif # FS_CACHE_MENU if BLOCK -menu "CD-ROM/DVD Filesystems" +menuconfig FS_CDVD_MENU + bool "CD-ROM/DVD Filesystems" + +if FS_CDVD_MENU source "fs/isofs/Kconfig" source "fs/udf/Kconfig" -endmenu +endif # FS_CDVD_MENU endif # BLOCK if BLOCK -menu "DOS/FAT/NT Filesystems" +menuconfig FS_FAT_MENU + bool "DOS/FAT/NT Filesystems" + +if FS_FAT_MENU source "fs/fat/Kconfig" source "fs/ntfs/Kconfig" -endmenu +endif # FS_FAT_MENU endif # BLOCK menu "Pseudo filesystems" -- 2.14.1
[PATCH] make "RCU Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all "RCU Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- kernel/rcu/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug index 0ec7d1d33a14..f709bc50ac23 100644 --- a/kernel/rcu/Kconfig.debug +++ b/kernel/rcu/Kconfig.debug @@ -2,7 +2,10 @@ # RCU-related debugging configuration options # -menu "RCU Debugging" +menuconfig RCUDEBUG_MENU + bool "RCU Debugging" + +if RCUDEBUG_MENU config PROVE_RCU def_bool PROVE_LOCKING @@ -79,4 +82,4 @@ config RCU_EQS_DEBUG Say N here if you need ultimate kernel/user switch latencies Say Y if you are unsure -endmenu # "RCU Debugging" +endif # RCUDEBUG_MENU -- 2.14.1
[PATCH] make "RCU Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all "RCU Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- kernel/rcu/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug index 0ec7d1d33a14..f709bc50ac23 100644 --- a/kernel/rcu/Kconfig.debug +++ b/kernel/rcu/Kconfig.debug @@ -2,7 +2,10 @@ # RCU-related debugging configuration options # -menu "RCU Debugging" +menuconfig RCUDEBUG_MENU + bool "RCU Debugging" + +if RCUDEBUG_MENU config PROVE_RCU def_bool PROVE_LOCKING @@ -79,4 +82,4 @@ config RCU_EQS_DEBUG Say N here if you need ultimate kernel/user switch latencies Say Y if you are unsure -endmenu # "RCU Debugging" +endif # RCUDEBUG_MENU -- 2.14.1
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..9436714254b7 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..9436714254b7 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module" @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest" -- 2.14.1
[PATCH] efi: make EFI a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all EFI config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/firmware/efi/Kconfig | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 2b4c39fdfa91..8727b1aa8ef6 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -1,6 +1,9 @@ -menu "EFI (Extensible Firmware Interface) Support" +menuconfig EFI_MENU + bool "EFI (Extensible Firmware Interface) Support" depends on EFI +if EFI_MENU + config EFI_VARS tristate "EFI Variable Support via sysfs" depends on EFI @@ -81,9 +84,6 @@ config EFI_PARAMS_FROM_FDT the EFI runtime support gets system table address, memory map address, and other parameters from the device tree. -config EFI_RUNTIME_WRAPPERS - bool - config EFI_ARMSTUB bool @@ -161,7 +161,10 @@ config RESET_ATTACK_MITIGATION still contains secrets in RAM, booting another OS and extracting the secrets. -endmenu +endif # EFI_MENU + +config EFI_RUNTIME_WRAPPERS + bool config UEFI_CPER bool -- 2.14.1
[PATCH] efi: make EFI a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all EFI config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/firmware/efi/Kconfig | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 2b4c39fdfa91..8727b1aa8ef6 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -1,6 +1,9 @@ -menu "EFI (Extensible Firmware Interface) Support" +menuconfig EFI_MENU + bool "EFI (Extensible Firmware Interface) Support" depends on EFI +if EFI_MENU + config EFI_VARS tristate "EFI Variable Support via sysfs" depends on EFI @@ -81,9 +84,6 @@ config EFI_PARAMS_FROM_FDT the EFI runtime support gets system table address, memory map address, and other parameters from the device tree. -config EFI_RUNTIME_WRAPPERS - bool - config EFI_ARMSTUB bool @@ -161,7 +161,10 @@ config RESET_ATTACK_MITIGATION still contains secrets in RAM, booting another OS and extracting the secrets. -endmenu +endif # EFI_MENU + +config EFI_RUNTIME_WRAPPERS + bool config UEFI_CPER bool -- 2.14.1
[PATCH] nvme: make NVME a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all NVME config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/nvme/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/Kconfig b/drivers/nvme/Kconfig index 04008e0bbe81..aad33a0dfbce 100644 --- a/drivers/nvme/Kconfig +++ b/drivers/nvme/Kconfig @@ -1,6 +1,9 @@ -menu "NVME Support" +menuconfig NVME_MENU + bool "NVME Support" + +if NVME_MENU source "drivers/nvme/host/Kconfig" source "drivers/nvme/target/Kconfig" -endmenu +endif # NVME_MENU -- 2.14.1
[PATCH] nvme: make NVME a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all NVME config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/nvme/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/Kconfig b/drivers/nvme/Kconfig index 04008e0bbe81..aad33a0dfbce 100644 --- a/drivers/nvme/Kconfig +++ b/drivers/nvme/Kconfig @@ -1,6 +1,9 @@ -menu "NVME Support" +menuconfig NVME_MENU + bool "NVME Support" + +if NVME_MENU source "drivers/nvme/host/Kconfig" source "drivers/nvme/target/Kconfig" -endmenu +endif # NVME_MENU -- 2.14.1
[PATCH] remoteproc: make REMOTEPROC a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all REMOTEPROC config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/remoteproc/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index b609e1d3654b..29341c7d836d 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -1,4 +1,7 @@ -menu "Remoteproc drivers" +menuconfig REMOTEPROC_MENU + bool "Remoteproc drivers" + +if REMOTEPROC_MENU config REMOTEPROC tristate "Support for Remote Processor subsystem" @@ -10,8 +13,6 @@ config REMOTEPROC Support for remote processors (such as DSP coprocessors). These are mainly used on embedded systems. -if REMOTEPROC - config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on SOC_IMX6SX || SOC_IMX7D @@ -140,6 +141,5 @@ config ST_REMOTEPROC config ST_SLIM_REMOTEPROC tristate -endif # REMOTEPROC +endif # REMOTEPROC_MENU -endmenu -- 2.14.1
[PATCH] remoteproc: make REMOTEPROC a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries. This makes it easier to disable all REMOTEPROC config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/remoteproc/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index b609e1d3654b..29341c7d836d 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -1,4 +1,7 @@ -menu "Remoteproc drivers" +menuconfig REMOTEPROC_MENU + bool "Remoteproc drivers" + +if REMOTEPROC_MENU config REMOTEPROC tristate "Support for Remote Processor subsystem" @@ -10,8 +13,6 @@ config REMOTEPROC Support for remote processors (such as DSP coprocessors). These are mainly used on embedded systems. -if REMOTEPROC - config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" depends on SOC_IMX6SX || SOC_IMX7D @@ -140,6 +141,5 @@ config ST_REMOTEPROC config ST_SLIM_REMOTEPROC tristate -endif # REMOTEPROC +endif # REMOTEPROC_MENU -endmenu -- 2.14.1
[PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/virtio/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..d485a63a8233 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,10 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +82,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.14.1
[PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
No need to get into the submenu to disable all VIRTIO-related config entries. This makes it easier to disable all VIRTIO config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/virtio/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index cff773f15b7e..d485a63a8233 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -5,7 +5,10 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -menu "Virtio drivers" +menuconfig VIRTIO_MENU + bool "Virtio drivers" + +if VIRTIO_MENU config VIRTIO_PCI tristate "PCI driver for virtio devices" @@ -79,4 +82,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES If unsure, say 'N'. -endmenu +endif # VIRTIO_MENU -- 2.14.1
[PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
No need to get into the submenu to disable all HYPERV-related config entries. This makes it easier to disable all HYPERV config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/hv/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 50b89ea0e60f..5804081d936d 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -1,4 +1,7 @@ -menu "Microsoft Hyper-V guest support" +menuconfig HYPERV_MENU + bool "Microsoft Hyper-V guest support" + +if HYPERV_MENU config HYPERV tristate "Microsoft Hyper-V client drivers" @@ -23,4 +26,4 @@ config HYPERV_BALLOON help Select this option to enable Hyper-V Balloon driver. -endmenu +endif # HYPERV_MENU -- 2.14.1
[PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all
No need to get into the submenu to disable all HYPERV-related config entries. This makes it easier to disable all HYPERV config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/hv/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 50b89ea0e60f..5804081d936d 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -1,4 +1,7 @@ -menu "Microsoft Hyper-V guest support" +menuconfig HYPERV_MENU + bool "Microsoft Hyper-V guest support" + +if HYPERV_MENU config HYPERV tristate "Microsoft Hyper-V client drivers" @@ -23,4 +26,4 @@ config HYPERV_BALLOON help Select this option to enable Hyper-V Balloon driver. -endmenu +endif # HYPERV_MENU -- 2.14.1
[PATCH] ptp: make PTP a menuconfig to ease disabling it all
No need to get into the submenu to disable all PTP-related config entries. This makes it easier to disable all PTP config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/ptp/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index a21ad10d613c..d3f3a9f2b0b1 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -2,7 +2,10 @@ # PTP clock support configuration # -menu "PTP clock support" +menuconfig PTP_MENU + bool"PTP clock support" + +if PTP_MENU config PTP_1588_CLOCK tristate "PTP clock support" @@ -118,4 +121,4 @@ config PTP_1588_CLOCK_KVM To compile this driver as a module, choose M here: the module will be called ptp_kvm. -endmenu +endif # PTP_MENU -- 2.14.1
[PATCH] ptp: make PTP a menuconfig to ease disabling it all
No need to get into the submenu to disable all PTP-related config entries. This makes it easier to disable all PTP config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/ptp/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index a21ad10d613c..d3f3a9f2b0b1 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -2,7 +2,10 @@ # PTP clock support configuration # -menu "PTP clock support" +menuconfig PTP_MENU + bool"PTP clock support" + +if PTP_MENU config PTP_1588_CLOCK tristate "PTP clock support" @@ -118,4 +121,4 @@ config PTP_1588_CLOCK_KVM To compile this driver as a module, choose M here: the module will be called ptp_kvm. -endmenu +endif # PTP_MENU -- 2.14.1
Re: [PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
This patch introduces some Kconfig warnings: warning: (X86) selects HAVE_DEBUG_KMEMLEAK which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects HAVE_ARCH_KASAN which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects ARCH_HAS_DEBUG_VIRTUAL which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects HAVE_DEBUG_STACKOVERFLOW which has unmet direct dependencies (DEBUG_MEMORY) What would be the best way to fix that ? excluding those config options from the "if DEBUG_MEMORY" code block seems to alleviate the warnings, but is that OK to do ? Would moving them out of the if/endif block be acceptable ? Thanks -- Vincent Legoll
Re: [PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
This patch introduces some Kconfig warnings: warning: (X86) selects HAVE_DEBUG_KMEMLEAK which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects HAVE_ARCH_KASAN which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects ARCH_HAS_DEBUG_VIRTUAL which has unmet direct dependencies (DEBUG_MEMORY) warning: (X86) selects HAVE_DEBUG_STACKOVERFLOW which has unmet direct dependencies (DEBUG_MEMORY) What would be the best way to fix that ? excluding those config options from the "if DEBUG_MEMORY" code block seems to alleviate the warnings, but is that OK to do ? Would moving them out of the if/endif block be acceptable ? Thanks -- Vincent Legoll
[PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all "Memory Debugging"-related config entries. This makes it easier to disable all "Memory Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..5062f52dbeec 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -436,7 +436,10 @@ config DEBUG_KERNEL Say Y here if you are developing drivers or trying to debug and identify kernel problems. -menu "Memory Debugging" +menuconfig DEBUG_MEMORY + bool "Memory Debugging" + +if DEBUG_MEMORY source mm/Kconfig.debug @@ -731,7 +734,7 @@ config DEBUG_STACKOVERFLOW source "lib/Kconfig.kasan" -endmenu # "Memory Debugging" +endif # DEBUG_MEMORY config ARCH_HAS_KCOV bool -- 2.14.1
[PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all
No need to get into the submenu to disable all "Memory Debugging"-related config entries. This makes it easier to disable all "Memory Debugging" config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- lib/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 947d3e2ed5c2..5062f52dbeec 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -436,7 +436,10 @@ config DEBUG_KERNEL Say Y here if you are developing drivers or trying to debug and identify kernel problems. -menu "Memory Debugging" +menuconfig DEBUG_MEMORY + bool "Memory Debugging" + +if DEBUG_MEMORY source mm/Kconfig.debug @@ -731,7 +734,7 @@ config DEBUG_STACKOVERFLOW source "lib/Kconfig.kasan" -endmenu # "Memory Debugging" +endif # DEBUG_MEMORY config ARCH_HAS_KCOV bool -- 2.14.1
[PATCH] ssb: make SSB a menuconfig to ease disabling it all
No need to get into the submenu to disable all SSB-related config entries. This makes it easier to disable all SSB config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/ssb/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index d8e4219c2324..f48a2ee587a4 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -3,10 +3,7 @@ config SSB_POSSIBLE depends on HAS_IOMEM && HAS_DMA default y -menu "Sonics Silicon Backplane" - depends on SSB_POSSIBLE - -config SSB +menuconfig SSB tristate "Sonics Silicon Backplane support" depends on SSB_POSSIBLE help @@ -21,6 +18,8 @@ config SSB If unsure, say N. +if SSB + # Common SPROM support routines config SSB_SPROM bool @@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO If unsure, say N -endmenu +endif # SSB -- 2.11.0
[PATCH] ssb: make SSB a menuconfig to ease disabling it all
No need to get into the submenu to disable all SSB-related config entries. This makes it easier to disable all SSB config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll --- drivers/ssb/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index d8e4219c2324..f48a2ee587a4 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -3,10 +3,7 @@ config SSB_POSSIBLE depends on HAS_IOMEM && HAS_DMA default y -menu "Sonics Silicon Backplane" - depends on SSB_POSSIBLE - -config SSB +menuconfig SSB tristate "Sonics Silicon Backplane support" depends on SSB_POSSIBLE help @@ -21,6 +18,8 @@ config SSB If unsure, say N. +if SSB + # Common SPROM support routines config SSB_SPROM bool @@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO If unsure, say N -endmenu +endif # SSB -- 2.11.0
[PATCH,v2] ssb: make SSB a menuconfig to ease disabling it all
Hello, thanks for the feedback, is that better ?
[PATCH,v2] ssb: make SSB a menuconfig to ease disabling it all
Hello, thanks for the feedback, is that better ?
Make SSB a menuconfig to ease disabling it all
The following patch makes it easier to disable all SSB config options without entering the submenu. It will also enable one to see that en-disabled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies.
[PATCH] Make SSB a menuconfig to ease disabling it all
No need to get into the submenu to disable all SSB-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/ssb/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index d8e4219c2324..f48a2ee587a4 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -3,10 +3,7 @@ config SSB_POSSIBLE depends on HAS_IOMEM && HAS_DMA default y -menu "Sonics Silicon Backplane" - depends on SSB_POSSIBLE - -config SSB +menuconfig SSB tristate "Sonics Silicon Backplane support" depends on SSB_POSSIBLE help @@ -21,6 +18,8 @@ config SSB If unsure, say N. +if SSB + # Common SPROM support routines config SSB_SPROM bool @@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO If unsure, say N -endmenu +endif # SSB -- 2.11.0
Make SSB a menuconfig to ease disabling it all
The following patch makes it easier to disable all SSB config options without entering the submenu. It will also enable one to see that en-disabled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies.
[PATCH] Make SSB a menuconfig to ease disabling it all
No need to get into the submenu to disable all SSB-related config entries Signed-off-by: Vincent Legoll --- drivers/ssb/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index d8e4219c2324..f48a2ee587a4 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -3,10 +3,7 @@ config SSB_POSSIBLE depends on HAS_IOMEM && HAS_DMA default y -menu "Sonics Silicon Backplane" - depends on SSB_POSSIBLE - -config SSB +menuconfig SSB tristate "Sonics Silicon Backplane support" depends on SSB_POSSIBLE help @@ -21,6 +18,8 @@ config SSB If unsure, say N. +if SSB + # Common SPROM support routines config SSB_SPROM bool @@ -185,4 +184,4 @@ config SSB_DRIVER_GPIO If unsure, say N -endmenu +endif # SSB -- 2.11.0
[PATCH] Make ANDROID a menuconfig to ease disabling it all
No need to get into the submenu to disable all ANDROID-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/android/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig index 7dce3795b887..e9434777acba 100644 --- a/drivers/android/Kconfig +++ b/drivers/android/Kconfig @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -menu "Android" - -config ANDROID +menuconfig ANDROID bool "Android Drivers" ---help--- Enable support for various drivers needed on the Android platform @@ -56,5 +54,3 @@ config ANDROID_BINDER_IPC_SELFTEST alignments. endif # if ANDROID - -endmenu -- 2.11.0
[PATCH] Make ANDROID a menuconfig to ease disabling it all
No need to get into the submenu to disable all ANDROID-related config entries Signed-off-by: Vincent Legoll --- drivers/android/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig index 7dce3795b887..e9434777acba 100644 --- a/drivers/android/Kconfig +++ b/drivers/android/Kconfig @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -menu "Android" - -config ANDROID +menuconfig ANDROID bool "Android Drivers" ---help--- Enable support for various drivers needed on the Android platform @@ -56,5 +54,3 @@ config ANDROID_BINDER_IPC_SELFTEST alignments. endif # if ANDROID - -endmenu -- 2.11.0
[PATCH] Make MIC a menuconfig to ease disabling it all
No need to get into the submenu to disable all MIC-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/misc/mic/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig index 227cc7443671..badc84356715 100644 --- a/drivers/misc/mic/Kconfig +++ b/drivers/misc/mic/Kconfig @@ -1,4 +1,7 @@ -menu "Intel MIC & related support" +menuconfig INTEL_MISC_BUS + bool "Intel MIC & related support" + +if INTEL_MISC_BUS comment "Intel MIC Bus Driver" @@ -153,4 +156,4 @@ if VOP source "drivers/vhost/Kconfig.vringh" endif -endmenu +endif # INTEL_MISC_BUS -- 2.11.0
[PATCH] Make MIC a menuconfig to ease disabling it all
No need to get into the submenu to disable all MIC-related config entries Signed-off-by: Vincent Legoll --- drivers/misc/mic/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig index 227cc7443671..badc84356715 100644 --- a/drivers/misc/mic/Kconfig +++ b/drivers/misc/mic/Kconfig @@ -1,4 +1,7 @@ -menu "Intel MIC & related support" +menuconfig INTEL_MISC_BUS + bool "Intel MIC & related support" + +if INTEL_MISC_BUS comment "Intel MIC Bus Driver" @@ -153,4 +156,4 @@ if VOP source "drivers/vhost/Kconfig.vringh" endif -endmenu +endif # INTEL_MISC_BUS -- 2.11.0
[PATCH] Make FSI a menuconfig to ease disabling it all
No need to get into the submenu to disable all FSI-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/fsi/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig index 6821ed0cd5e8..513e35173aaa 100644 --- a/drivers/fsi/Kconfig +++ b/drivers/fsi/Kconfig @@ -2,9 +2,7 @@ # FSI subsystem # -menu "FSI support" - -config FSI +menuconfig FSI tristate "FSI support" select CRC4 ---help--- @@ -34,5 +32,3 @@ config FSI_SCOM This option enables an FSI based SCOM device driver. endif - -endmenu -- 2.11.0
[PATCH] Make FSI a menuconfig to ease disabling it all
No need to get into the submenu to disable all FSI-related config entries Signed-off-by: Vincent Legoll --- drivers/fsi/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig index 6821ed0cd5e8..513e35173aaa 100644 --- a/drivers/fsi/Kconfig +++ b/drivers/fsi/Kconfig @@ -2,9 +2,7 @@ # FSI subsystem # -menu "FSI support" - -config FSI +menuconfig FSI tristate "FSI support" select CRC4 ---help--- @@ -34,5 +32,3 @@ config FSI_SCOM This option enables an FSI based SCOM device driver. endif - -endmenu -- 2.11.0
[PATCH,v2] Make TI_ST a menuconfig to ease disabling it all
v2: using bool instead of tristate
[PATCH] Make TI_ST a menuconfig to ease disabling it all
No need to get into the submenu to disable all TI_ST-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/misc/ti-st/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig index f34dcc514730..f007cfa82b89 100644 --- a/drivers/misc/ti-st/Kconfig +++ b/drivers/misc/ti-st/Kconfig @@ -2,10 +2,12 @@ # TI's shared transport line discipline and the protocol # drivers (BT, FM and GPS) # -menu "Texas Instruments shared transport line discipline" +menuconfig TIST + bool "Texas Instruments shared transport line discipline" + config TI_ST tristate "Shared transport core driver" - depends on NET && GPIOLIB && TTY + depends on TIST && NET && GPIOLIB && TTY select FW_LOADER help This enables the shared transport core driver for TI @@ -13,5 +15,3 @@ config TI_ST to register themselves with core and send data, the responses are returned to relevant protocol drivers based on their packet types. - -endmenu -- 2.11.0
[PATCH,v2] Make TI_ST a menuconfig to ease disabling it all
v2: using bool instead of tristate
[PATCH] Make TI_ST a menuconfig to ease disabling it all
No need to get into the submenu to disable all TI_ST-related config entries Signed-off-by: Vincent Legoll --- drivers/misc/ti-st/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig index f34dcc514730..f007cfa82b89 100644 --- a/drivers/misc/ti-st/Kconfig +++ b/drivers/misc/ti-st/Kconfig @@ -2,10 +2,12 @@ # TI's shared transport line discipline and the protocol # drivers (BT, FM and GPS) # -menu "Texas Instruments shared transport line discipline" +menuconfig TIST + bool "Texas Instruments shared transport line discipline" + config TI_ST tristate "Shared transport core driver" - depends on NET && GPIOLIB && TTY + depends on TIST && NET && GPIOLIB && TTY select FW_LOADER help This enables the shared transport core driver for TI @@ -13,5 +15,3 @@ config TI_ST to register themselves with core and send data, the responses are returned to relevant protocol drivers based on their packet types. - -endmenu -- 2.11.0
Re: [linux-sunxi] [PATCH v3 1/5] dt-bindings: update the Allwinner GPADC device tree binding for H3
Hello, Sorry for the very-clueless question On Sun, Jul 23, 2017 at 4:13 PM, Icenowy Zheng <icen...@aosc.io> wrote: > + - clock-names: should be "bus" and "mod", When I first read that, I wondered what value clock-names should eally be given. Then... > + clock-names = "bus", "mod"; OK, now this is clearer, but still the documentation is less documenting than the code itself, sigh... I cannot think of a better wording, though, as a non-native-english speaker. Maybe just add a "(See example below)" would be sufficient... Or decide that this documentation is for clueful ones. WDYT ? -- Vincent Legoll
Re: [linux-sunxi] [PATCH v3 1/5] dt-bindings: update the Allwinner GPADC device tree binding for H3
Hello, Sorry for the very-clueless question On Sun, Jul 23, 2017 at 4:13 PM, Icenowy Zheng wrote: > + - clock-names: should be "bus" and "mod", When I first read that, I wondered what value clock-names should eally be given. Then... > + clock-names = "bus", "mod"; OK, now this is clearer, but still the documentation is less documenting than the code itself, sigh... I cannot think of a better wording, though, as a non-native-english speaker. Maybe just add a "(See example below)" would be sufficient... Or decide that this documentation is for clueful ones. WDYT ? -- Vincent Legoll
Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all
Hello, On Wed, Jul 5, 2017 at 11:15 PM, Stephen Boyd <sb...@codeaurora.org> wrote: > On 07/02, Vincent Legoll wrote: >> -menu "Common Clock Framework" >> +menuconfig COMMON_CLK_FRAMEWORK >> + tristate "Common Clock Framework" >> depends on COMMON_CLK > > Wouldn't this put the clk drivers inside the drivers menu? This does not move anything (at least I think), it just change the already existing submenu into a menuconfig, which you can choose to disable as a whole, which disable everything inside that menuconfig. Maybe there are side effects visible outside of this menu. > Which is already quite large right now. That's right, and I'm willing to tackle at least a part of this problem, first by making it easier to disable whole chunks at once. > Plus this makes common clk > tristate which so far we haven't supported. No thanks. OK that was an oversight, I'll revisit later (going for the low hanging fruits). But this is moot anyways, you should drop that patch because it introduces new compile warnings on ARM. Sorry -- Vincent Legoll
Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all
Hello, On Wed, Jul 5, 2017 at 11:15 PM, Stephen Boyd wrote: > On 07/02, Vincent Legoll wrote: >> -menu "Common Clock Framework" >> +menuconfig COMMON_CLK_FRAMEWORK >> + tristate "Common Clock Framework" >> depends on COMMON_CLK > > Wouldn't this put the clk drivers inside the drivers menu? This does not move anything (at least I think), it just change the already existing submenu into a menuconfig, which you can choose to disable as a whole, which disable everything inside that menuconfig. Maybe there are side effects visible outside of this menu. > Which is already quite large right now. That's right, and I'm willing to tackle at least a part of this problem, first by making it easier to disable whole chunks at once. > Plus this makes common clk > tristate which so far we haven't supported. No thanks. OK that was an oversight, I'll revisit later (going for the low hanging fruits). But this is moot anyways, you should drop that patch because it introduces new compile warnings on ARM. Sorry -- Vincent Legoll
Re: [PATCH] Make EEPROM a menuconfig to ease disabling it all
Hello, Please drop that patch, it will need to be fixed & tested more before resend -- Vincent Legoll
Re: [PATCH] Make EEPROM a menuconfig to ease disabling it all
Hello, Please drop that patch, it will need to be fixed & tested more before resend -- Vincent Legoll
Re: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all
Hello, On Sun, Jul 2, 2017 at 5:53 PM, Vincent Legoll <vincent.leg...@gmail.com> wrote: > No need to get into the submenu to disable all SCSI Transports-related > config entries > > Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> > --- > drivers/scsi/Kconfig | 7 +-- Please drop that patch, it will need to be fixed & tested more before resend -- Vincent Legoll
Re: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all
Hello, On Sun, Jul 2, 2017 at 5:53 PM, Vincent Legoll wrote: > No need to get into the submenu to disable all SCSI Transports-related > config entries > > Signed-off-by: Vincent Legoll > --- > drivers/scsi/Kconfig | 7 +-- Please drop that patch, it will need to be fixed & tested more before resend -- Vincent Legoll
[PATCH] Make Common clock framework a menuconfig to ease disabling it all
No need to get into the submenu to disable all common clock framework -related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/clk/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 36cfea3..a1b174c 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -19,9 +19,12 @@ config COMMON_CLK Architectures utilizing the common struct clk should select this option. -menu "Common Clock Framework" +menuconfig COMMON_CLK_FRAMEWORK + tristate "Common Clock Framework" depends on COMMON_CLK +if COMMON_CLK_FRAMEWORK + config COMMON_CLK_WM831X tristate "Clock driver for WM831x/2x PMICs" depends on MFD_WM831X @@ -230,4 +233,4 @@ source "drivers/clk/tegra/Kconfig" source "drivers/clk/ti/Kconfig" source "drivers/clk/uniphier/Kconfig" -endmenu +endif # COMMON_CLK_FRAMEWORK -- 2.7.4
[PATCH] Make Common clock framework a menuconfig to ease disabling it all
No need to get into the submenu to disable all common clock framework -related config entries Signed-off-by: Vincent Legoll --- drivers/clk/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 36cfea3..a1b174c 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -19,9 +19,12 @@ config COMMON_CLK Architectures utilizing the common struct clk should select this option. -menu "Common Clock Framework" +menuconfig COMMON_CLK_FRAMEWORK + tristate "Common Clock Framework" depends on COMMON_CLK +if COMMON_CLK_FRAMEWORK + config COMMON_CLK_WM831X tristate "Clock driver for WM831x/2x PMICs" depends on MFD_WM831X @@ -230,4 +233,4 @@ source "drivers/clk/tegra/Kconfig" source "drivers/clk/ti/Kconfig" source "drivers/clk/uniphier/Kconfig" -endmenu +endif # COMMON_CLK_FRAMEWORK -- 2.7.4
[PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all
No need to get into the submenu to disable all SCSI Transports-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/scsi/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 3c52867..53c97cc 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -251,9 +251,12 @@ config SCSI_SCAN_ASYNC Note that this setting also affects whether resuming from system suspend will be performed asynchronously. -menu "SCSI Transports" +menuconfig SCSI_TRANSPORTS + tristate "SCSI Transports" depends on SCSI +if SCSI_TRANSPORTS + config SCSI_SPI_ATTRS tristate "Parallel SCSI (SPI) Transport Attributes" depends on SCSI @@ -297,7 +300,7 @@ config SCSI_SRP_ATTRS If you wish to export transport-specific information about each attached SRP device to sysfs, say Y. -endmenu +endif # SCSI_TRANSPORTS menuconfig SCSI_LOWLEVEL bool "SCSI low-level drivers" -- 2.7.4
[PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all
No need to get into the submenu to disable all SCSI Transports-related config entries Signed-off-by: Vincent Legoll --- drivers/scsi/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 3c52867..53c97cc 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -251,9 +251,12 @@ config SCSI_SCAN_ASYNC Note that this setting also affects whether resuming from system suspend will be performed asynchronously. -menu "SCSI Transports" +menuconfig SCSI_TRANSPORTS + tristate "SCSI Transports" depends on SCSI +if SCSI_TRANSPORTS + config SCSI_SPI_ATTRS tristate "Parallel SCSI (SPI) Transport Attributes" depends on SCSI @@ -297,7 +300,7 @@ config SCSI_SRP_ATTRS If you wish to export transport-specific information about each attached SRP device to sysfs, say Y. -endmenu +endif # SCSI_TRANSPORTS menuconfig SCSI_LOWLEVEL bool "SCSI low-level drivers" -- 2.7.4
[PATCH] Make EEPROM a menuconfig to ease disabling it all
No need to get into the submenu to disable all EEPROM-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- drivers/misc/eeprom/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig index de58762..0ea5290 100644 --- a/drivers/misc/eeprom/Kconfig +++ b/drivers/misc/eeprom/Kconfig @@ -1,8 +1,9 @@ -menu "EEPROM support" +menuconfig EEPROM + tristate "EEPROM support" config EEPROM_AT24 tristate "I2C EEPROMs / RAMs / ROMs from most vendors" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS select NVMEM help Enable this driver to get read/write support to most I2C EEPROMs @@ -30,7 +31,7 @@ config EEPROM_AT24 config EEPROM_AT25 tristate "SPI EEPROMs from most vendors" - depends on SPI && SYSFS + depends on EEPROM && SPI && SYSFS select NVMEM help Enable this driver to get read/write support to most SPI EEPROMs, @@ -42,7 +43,7 @@ config EEPROM_AT25 config EEPROM_LEGACY tristate "Old I2C EEPROM reader" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS help If you say yes here you get read-only access to the EEPROM data available on modern memory DIMMs and Sony Vaio laptops via I2C. Such @@ -53,7 +54,7 @@ config EEPROM_LEGACY config EEPROM_MAX6875 tristate "Maxim MAX6874/5 power supply supervisor" - depends on I2C + depends on EEPROM && I2C help If you say yes here you get read-only support for the user EEPROM of the Maxim MAX6874/5 EEPROM-programmable, quad power-supply @@ -67,6 +68,7 @@ config EEPROM_MAX6875 config EEPROM_93CX6 tristate "EEPROM 93CX6 support" + depends on EEPROM help This is a driver for the EEPROM chipsets 93c46 and 93c66. The driver supports both read as well as write commands. @@ -75,7 +77,7 @@ config EEPROM_93CX6 config EEPROM_93XX46 tristate "Microwire EEPROM 93XX46 support" - depends on SPI && SYSFS + depends on EEPROM && SPI && SYSFS select REGMAP select NVMEM help @@ -90,7 +92,7 @@ config EEPROM_93XX46 config EEPROM_DIGSY_MTC_CFG bool "DigsyMTC display configuration EEPROMs device" - depends on GPIO_MPC5200 && SPI_GPIO + depends on EEPROM && GPIO_MPC5200 && SPI_GPIO help This option enables access to display configuration EEPROMs on digsy_mtc board. You have to additionally select Microwire @@ -102,12 +104,10 @@ config EEPROM_DIGSY_MTC_CFG config EEPROM_IDT_89HPESX tristate "IDT 89HPESx PCIe-swtiches EEPROM / CSR support" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS help Enable this driver to get read/write access to EEPROM / CSRs over IDT PCIe-swtich i2c-slave interface. This driver can also be built as a module. If so, the module will be called idt_89hpesx. - -endmenu -- 2.7.4
[PATCH] Make EEPROM a menuconfig to ease disabling it all
No need to get into the submenu to disable all EEPROM-related config entries Signed-off-by: Vincent Legoll --- drivers/misc/eeprom/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig index de58762..0ea5290 100644 --- a/drivers/misc/eeprom/Kconfig +++ b/drivers/misc/eeprom/Kconfig @@ -1,8 +1,9 @@ -menu "EEPROM support" +menuconfig EEPROM + tristate "EEPROM support" config EEPROM_AT24 tristate "I2C EEPROMs / RAMs / ROMs from most vendors" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS select NVMEM help Enable this driver to get read/write support to most I2C EEPROMs @@ -30,7 +31,7 @@ config EEPROM_AT24 config EEPROM_AT25 tristate "SPI EEPROMs from most vendors" - depends on SPI && SYSFS + depends on EEPROM && SPI && SYSFS select NVMEM help Enable this driver to get read/write support to most SPI EEPROMs, @@ -42,7 +43,7 @@ config EEPROM_AT25 config EEPROM_LEGACY tristate "Old I2C EEPROM reader" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS help If you say yes here you get read-only access to the EEPROM data available on modern memory DIMMs and Sony Vaio laptops via I2C. Such @@ -53,7 +54,7 @@ config EEPROM_LEGACY config EEPROM_MAX6875 tristate "Maxim MAX6874/5 power supply supervisor" - depends on I2C + depends on EEPROM && I2C help If you say yes here you get read-only support for the user EEPROM of the Maxim MAX6874/5 EEPROM-programmable, quad power-supply @@ -67,6 +68,7 @@ config EEPROM_MAX6875 config EEPROM_93CX6 tristate "EEPROM 93CX6 support" + depends on EEPROM help This is a driver for the EEPROM chipsets 93c46 and 93c66. The driver supports both read as well as write commands. @@ -75,7 +77,7 @@ config EEPROM_93CX6 config EEPROM_93XX46 tristate "Microwire EEPROM 93XX46 support" - depends on SPI && SYSFS + depends on EEPROM && SPI && SYSFS select REGMAP select NVMEM help @@ -90,7 +92,7 @@ config EEPROM_93XX46 config EEPROM_DIGSY_MTC_CFG bool "DigsyMTC display configuration EEPROMs device" - depends on GPIO_MPC5200 && SPI_GPIO + depends on EEPROM && GPIO_MPC5200 && SPI_GPIO help This option enables access to display configuration EEPROMs on digsy_mtc board. You have to additionally select Microwire @@ -102,12 +104,10 @@ config EEPROM_DIGSY_MTC_CFG config EEPROM_IDT_89HPESX tristate "IDT 89HPESx PCIe-swtiches EEPROM / CSR support" - depends on I2C && SYSFS + depends on EEPROM && I2C && SYSFS help Enable this driver to get read/write access to EEPROM / CSRs over IDT PCIe-swtich i2c-slave interface. This driver can also be built as a module. If so, the module will be called idt_89hpesx. - -endmenu -- 2.7.4
[tip:irq/core] genirq: Make early_irq_init() print out more informative
Commit-ID: 5a29ef22098874db79af7bf92a247a0f503bfa6e Gitweb: http://git.kernel.org/tip/5a29ef22098874db79af7bf92a247a0f503bfa6e Author: Vincent Legoll <vincent.leg...@gmail.com> AuthorDate: Tue, 9 May 2017 10:34:09 +0200 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Fri, 26 May 2017 14:54:05 +0200 genirq: Make early_irq_init() print out more informative The printk in early_irq_init() is cryptic and badly formatted: NR_IRQS:33024 nr_irqs:968 16 The last number is the number of preallocated interrupts, so add a prefix to it: NR_IRQS: 33024, nr_irqs: 968, preallocated irqs: 16 Cleanup the formatting for better readability as well. Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Link: http://lkml.kernel.org/r/1494318849-6733-1-git-send-email-vincent.leg...@gmail.com --- kernel/irq/irqdesc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 00bb0ae..09abce2 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -480,7 +480,8 @@ int __init early_irq_init(void) /* Let arch update nr_irqs and return the nr of preallocated irqs */ initcnt = arch_probe_nr_irqs(); - printk(KERN_INFO "NR_IRQS:%d nr_irqs:%d %d\n", NR_IRQS, nr_irqs, initcnt); + printk(KERN_INFO "NR_IRQS: %d, nr_irqs: %d, preallocated irqs: %d\n", + NR_IRQS, nr_irqs, initcnt); if (WARN_ON(nr_irqs > IRQ_BITMAP_BITS)) nr_irqs = IRQ_BITMAP_BITS; @@ -516,7 +517,7 @@ int __init early_irq_init(void) init_irq_default_affinity(); - printk(KERN_INFO "NR_IRQS:%d\n", NR_IRQS); + printk(KERN_INFO "NR_IRQS: %d\n", NR_IRQS); desc = irq_desc; count = ARRAY_SIZE(irq_desc);
[tip:irq/core] genirq: Make early_irq_init() print out more informative
Commit-ID: 5a29ef22098874db79af7bf92a247a0f503bfa6e Gitweb: http://git.kernel.org/tip/5a29ef22098874db79af7bf92a247a0f503bfa6e Author: Vincent Legoll AuthorDate: Tue, 9 May 2017 10:34:09 +0200 Committer: Thomas Gleixner CommitDate: Fri, 26 May 2017 14:54:05 +0200 genirq: Make early_irq_init() print out more informative The printk in early_irq_init() is cryptic and badly formatted: NR_IRQS:33024 nr_irqs:968 16 The last number is the number of preallocated interrupts, so add a prefix to it: NR_IRQS: 33024, nr_irqs: 968, preallocated irqs: 16 Cleanup the formatting for better readability as well. Signed-off-by: Vincent Legoll Signed-off-by: Thomas Gleixner Link: http://lkml.kernel.org/r/1494318849-6733-1-git-send-email-vincent.leg...@gmail.com --- kernel/irq/irqdesc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 00bb0ae..09abce2 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -480,7 +480,8 @@ int __init early_irq_init(void) /* Let arch update nr_irqs and return the nr of preallocated irqs */ initcnt = arch_probe_nr_irqs(); - printk(KERN_INFO "NR_IRQS:%d nr_irqs:%d %d\n", NR_IRQS, nr_irqs, initcnt); + printk(KERN_INFO "NR_IRQS: %d, nr_irqs: %d, preallocated irqs: %d\n", + NR_IRQS, nr_irqs, initcnt); if (WARN_ON(nr_irqs > IRQ_BITMAP_BITS)) nr_irqs = IRQ_BITMAP_BITS; @@ -516,7 +517,7 @@ int __init early_irq_init(void) init_irq_default_affinity(); - printk(KERN_INFO "NR_IRQS:%d\n", NR_IRQS); + printk(KERN_INFO "NR_IRQS: %d\n", NR_IRQS); desc = irq_desc; count = ARRAY_SIZE(irq_desc);
[PATCH] PCI: fix whitespace in printk() to align log entries
Remove the space character between "PCI" and the colon. This was printed before the patch: PCI : PCI BIOS area is rw and x. Use pci=nobios if you want it NX. Whereas other PCI printks are like that: $ dmesg | grep 'PCI:' [0.649178] PCI: MMCONFIG for domain [bus 00-7f] at [mem 0xf000-0xf7ff] (base 0xf000) [0.649180] PCI: MMCONFIG at [mem 0xf000-0xf7ff] reserved in E820 [0.649186] PCI: Using configuration type 1 for base access [0.676407] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug [0.784009] PCI: Using ACPI for IRQ routing [0.795599] PCI: pci_cache_line_size set to 64 bytes [0.811154] PCI: CLS 0 bytes, default 64 Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> --- arch/x86/pci/pcbios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/pci/pcbios.c b/arch/x86/pci/pcbios.c index c1bdb9e..7659540 100644 --- a/arch/x86/pci/pcbios.c +++ b/arch/x86/pci/pcbios.c @@ -46,7 +46,7 @@ static inline void set_bios_x(void) pcibios_enabled = 1; set_memory_x(PAGE_OFFSET + BIOS_BEGIN, (BIOS_END - BIOS_BEGIN) >> PAGE_SHIFT); if (__supported_pte_mask & _PAGE_NX) - printk(KERN_INFO "PCI : PCI BIOS area is rw and x. Use pci=nobios if you want it NX.\n"); + printk(KERN_INFO "PCI: PCI BIOS area is rw and x. Use pci=nobios if you want it NX.\n"); } /* -- 2.7.4
[PATCH] PCI: fix whitespace in printk() to align log entries
Remove the space character between "PCI" and the colon. This was printed before the patch: PCI : PCI BIOS area is rw and x. Use pci=nobios if you want it NX. Whereas other PCI printks are like that: $ dmesg | grep 'PCI:' [0.649178] PCI: MMCONFIG for domain [bus 00-7f] at [mem 0xf000-0xf7ff] (base 0xf000) [0.649180] PCI: MMCONFIG at [mem 0xf000-0xf7ff] reserved in E820 [0.649186] PCI: Using configuration type 1 for base access [0.676407] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug [0.784009] PCI: Using ACPI for IRQ routing [0.795599] PCI: pci_cache_line_size set to 64 bytes [0.811154] PCI: CLS 0 bytes, default 64 Signed-off-by: Vincent Legoll --- arch/x86/pci/pcbios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/pci/pcbios.c b/arch/x86/pci/pcbios.c index c1bdb9e..7659540 100644 --- a/arch/x86/pci/pcbios.c +++ b/arch/x86/pci/pcbios.c @@ -46,7 +46,7 @@ static inline void set_bios_x(void) pcibios_enabled = 1; set_memory_x(PAGE_OFFSET + BIOS_BEGIN, (BIOS_END - BIOS_BEGIN) >> PAGE_SHIFT); if (__supported_pte_mask & _PAGE_NX) - printk(KERN_INFO "PCI : PCI BIOS area is rw and x. Use pci=nobios if you want it NX.\n"); + printk(KERN_INFO "PCI: PCI BIOS area is rw and x. Use pci=nobios if you want it NX.\n"); } /* -- 2.7.4
