Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
Hi Kosta,
Let me chime in.
śr., 3 lut 2021 o 17:57 Kostya Porotchkin napisał(a):
>
> Hello, Russell,
> I agree that this patch needs rework.
> I will definitely do it and issue a new version.
>
> > On Wed, Feb 03, 2021 at 02:50:45PM +, Kostya Porotchkin wrote:
> > > [KP] So for older systems this "slow mode" parameter could be set on the
> > board level.
> > > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52,
> > > even
> > if they support HS400 on AP side.
> > > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v"
> > flag set, so it should remain in low speed anyway.
> >
> > Your reasoning does not make sense.
> >
> > The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode".
> > It is not specified at this level. It is already specified at board level.
> [KP] it does. In current armada-ap80x.dtsi File this specification is on row
> 260:
> ap_sdhci0: sdhci@6e {
> compatible = "marvell,armada-ap806-sdhci";
> reg = <0x6e 0x300>;
> interrupts = ;
> clock-names = "core";
> clocks = <_clk 4>;
> dma-coherent;
> marvell,xenon-phy-slow-mode;
> status = "disabled";
> };
> So I would like to remove this row.
>
> > Given that Macchiatobin will still use slow mode, why remove the
> > marvell,xenon-phy-slow-mode property from this file?
> [KP] Agree, I will keep this property in Macchiatobin DTS file.
>
Please do it another way around.
1. We need to leave the device tree bindings intact as much as
possible - specifically for Armada 7k8k changes in this area have
been causing enough problems in the past, breaking compatibility
between kernel revisions. Moving the property to board level can be
good here, but forces all other board dts files to adjust.
Unfortunately Linux is a source of truth for the arm64 device tree
bindings, but please note other OS's use those files as well - let's
minimize the impact for existing HW and drivers.
2. What I propose is to remove `marvell,xenon-phy-slow-mode` from
armada-ap80x.dtsi and add below in armada-ap806.dtsi:
_sdhci0 {
marvell,xenon-phy-slow-mode;
};
This way AP807 becomes free from the unwanted slow mode setting. Also
any user of Armada 7k8k the B0 revision can add below to the board
file:
_sdhci0 {
+ /delete-property/marvell,xenon-phy-slow-mode;
};
3. Contrary to the SDK version, sdhci-xenon.c is not capable of
checking the SoC revision. HS200 is disabled for all versions of AP806
there - I believe this place requires revisiting, to start relying
explicitly on the `marvell,xenon-phy-slow-mode` setting, rather than
the compatible string. I can handle this one.
4. Please move armada-8040-db.dts changes to a separate patch, please.
Thanks,
Marcin
> >
> > Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep the
> > bus-
> > width specifier of 8 in the board files?
> [KP] The bus width is updated in A8040 DB DTS. This board utilizes 8-bit
> interface.
> The armada-ap80x.dtsi file does not specifies the bus width since it is
> board-specific.
>
> >
> > This patch just doesn't make sense, and your responses to our points seem to
> > add to the confusion.
> [KP] I am sorry about it. Hope my last response clarifies it.
>
> Kosta
> >
> > --
> > RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__www.armlinux.org.uk_developer_patches_=DwIBAg=nKjWec2b6R0
> > mOyPaz7xtfQ=-
> > N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=V27OOcgNqKN2
> > WrlW2YFvHm_D_dXoP44wPd5zyOKvEBk=o3OrmStt1ZuXVNlYklTV_b1wY35
> > NvPPrdLqwGgtxRZU=
> > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
Hello, Russell,
I agree that this patch needs rework.
I will definitely do it and issue a new version.
> On Wed, Feb 03, 2021 at 02:50:45PM +, Kostya Porotchkin wrote:
> > [KP] So for older systems this "slow mode" parameter could be set on the
> board level.
> > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52,
> > even
> if they support HS400 on AP side.
> > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v"
> flag set, so it should remain in low speed anyway.
>
> Your reasoning does not make sense.
>
> The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode".
> It is not specified at this level. It is already specified at board level.
[KP] it does. In current armada-ap80x.dtsi File this specification is on row
260:
ap_sdhci0: sdhci@6e {
compatible = "marvell,armada-ap806-sdhci";
reg = <0x6e 0x300>;
interrupts = ;
clock-names = "core";
clocks = <_clk 4>;
dma-coherent;
marvell,xenon-phy-slow-mode;
status = "disabled";
};
So I would like to remove this row.
> Given that Macchiatobin will still use slow mode, why remove the
> marvell,xenon-phy-slow-mode property from this file?
[KP] Agree, I will keep this property in Macchiatobin DTS file.
>
> Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep the
> bus-
> width specifier of 8 in the board files?
[KP] The bus width is updated in A8040 DB DTS. This board utilizes 8-bit
interface.
The armada-ap80x.dtsi file does not specifies the bus width since it is
board-specific.
>
> This patch just doesn't make sense, and your responses to our points seem to
> add to the confusion.
[KP] I am sorry about it. Hope my last response clarifies it.
Kosta
>
> --
> RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.armlinux.org.uk_developer_patches_=DwIBAg=nKjWec2b6R0
> mOyPaz7xtfQ=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=V27OOcgNqKN2
> WrlW2YFvHm_D_dXoP44wPd5zyOKvEBk=o3OrmStt1ZuXVNlYklTV_b1wY35
> NvPPrdLqwGgtxRZU=
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
On Wed, Feb 03, 2021 at 02:50:45PM +, Kostya Porotchkin wrote: > [KP] So for older systems this "slow mode" parameter could be set on the > board level. > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52, even > if they support HS400 on AP side. > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v" flag > set, so it should remain in low speed anyway. Your reasoning does not make sense. The ap80x.dtsi file does not specify "marvell,xenon-phy-slow-mode". It is not specified at this level. It is already specified at board level. Given that Macchiatobin will still use slow mode, why remove the marvell,xenon-phy-slow-mode property from this file? Also, if you're upgrading ap80x.dtsi to use a bus-width of 8, why keep the bus-width specifier of 8 in the board files? This patch just doesn't make sense, and your responses to our points seem to add to the confusion. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
> -Original Message- > From: linux-arm-kernel On > Behalf Of Kostya Porotchkin > Sent: Wednesday, February 3, 2021 16:51 > To: Russell King - ARM Linux admin > Cc: devicet...@vger.kernel.org; Baruch Siach ; > and...@lunn.ch; j...@semihalf.com; gregory.clem...@bootlin.com; linux- > ker...@vger.kernel.org; Nadav Haklai ; > robh...@kernel.org; Stefan Chulski ; > m...@semihalf.com; Ben Peled ; linux-arm- > ker...@lists.infradead.org; sebastian.hesselba...@gmail.com > Subject: RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI > settings [KP] > > > > Hi Konstantin, > > > > > > > > On Wed, Feb 03 2021, kos...@marvell.com wrote: > > > > > From: Konstantin Porotchkin > > > > > > > > > > Update the settings for AP806 SDHCI interface according to > > > > > latest Xenon drivers changes. > > > > > - no need to select the PHY slow mode anymore > > > > > > > > Why? Has anything changed since the introduction of > > > > marvell,xenon-phy-slow- mode? > > > [KP] AP806 B0, AP807 and later do not need the "slow mode" set by > > > the > > default. > > > The HWE-7296210 errata is not applicable to these components and > > > they are able to run AP SDHCI in HS400 8-bit mode. > > > > So what about all those people, such as me, who have A0 silicon on > > their Macchiatobin boards? > > > > You can't just go around removing DT properties like this. > > > [KP] So for older systems this "slow mode" parameter could be set on the > board level. > When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52, even > if > they support HS400 on AP side. > MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v" flag > set, so it should remain in low speed anyway. [KP] I also forgot to mention this code piece in Xenon driver: /* Disable HS200 on Armada AP806 */ if (priv->hw_version == XENON_AP806) host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200; > > > -- > > RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https- > > > 3A__www.armlinux.org.uk_developer_patches_=DwIBAg=nKjWec2b6R0 > > mOyPaz7xtfQ=- > > > N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=yMC9YPQXZUm > > > QPwlD7KCTVoVTPXCTQwTXD2yVsAo6sxA=OuBO2QArzHvV4k_vsNZdmSoDX > > rL4Q_voTqxrlYU6KKE= > > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > https://urldefense.proofpoint.com/v2/url?u=http- > 3A__lists.infradead.org_mailman_listinfo_linux-2Darm- > 2Dkernel=DwICAg=nKjWec2b6R0mOyPaz7xtfQ=- > N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=8f- > 1fnISJVHCS4gZTeFgRPXGPiwBevUsFbmYDBmkRWM=RBlEEUXG0sOmZHsQ > Omurf018V8kSE_IMZR7bDLVJ0FA=
RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Wednesday, February 3, 2021 16:39 > To: Kostya Porotchkin > Cc: Baruch Siach ; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; and...@lunn.ch; j...@semihalf.com; > gregory.clem...@bootlin.com; Nadav Haklai ; > robh...@kernel.org; Stefan Chulski ; > m...@semihalf.com; Ben Peled ; > sebastian.hesselba...@gmail.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI > settings > > On Wed, Feb 03, 2021 at 02:37:22PM +, Kostya Porotchkin wrote: > > Hi, Baruch, > > > > > -Original Message- > > > From: Baruch Siach > > > Sent: Wednesday, February 3, 2021 15:59 > > > To: Kostya Porotchkin > > > Cc: linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; > > > and...@lunn.ch; j...@semihalf.com; gregory.clem...@bootlin.com; > > > li...@armlinux.org.uk; Nadav Haklai ; > > > robh...@kernel.org; Stefan Chulski ; > > > m...@semihalf.com; Ben Peled ; > > > sebastian.hesselba...@gmail.com; > > > linux-arm-ker...@lists.infradead.org > > > Subject: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI > > > settings > > > > > > External Email > > > > > > > > > -- > > > Hi Konstantin, > > > > > > On Wed, Feb 03 2021, kos...@marvell.com wrote: > > > > From: Konstantin Porotchkin > > > > > > > > Update the settings for AP806 SDHCI interface according to latest > > > > Xenon drivers changes. > > > > - no need to select the PHY slow mode anymore > > > > > > Why? Has anything changed since the introduction of > > > marvell,xenon-phy-slow- mode? > > [KP] AP806 B0, AP807 and later do not need the "slow mode" set by the > default. > > The HWE-7296210 errata is not applicable to these components and they > > are able to run AP SDHCI in HS400 8-bit mode. > > So what about all those people, such as me, who have A0 silicon on their > Macchiatobin boards? > > You can't just go around removing DT properties like this. > [KP] So for older systems this "slow mode" parameter could be set on the board level. When it is set in ap80x,dtsi file it downgrades all systems to HS-SDR52, even if they support HS400 on AP side. MacchiatoBIN AP eMMC is connected to 3.3v regulator and has "no-1-8-v" flag set, so it should remain in low speed anyway. > -- > RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__www.armlinux.org.uk_developer_patches_=DwIBAg=nKjWec2b6R0 > mOyPaz7xtfQ=- > N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=yMC9YPQXZUm > QPwlD7KCTVoVTPXCTQwTXD2yVsAo6sxA=OuBO2QArzHvV4k_vsNZdmSoDX > rL4Q_voTqxrlYU6KKE= > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
On Wed, Feb 03, 2021 at 02:37:22PM +, Kostya Porotchkin wrote: > Hi, Baruch, > > > -Original Message- > > From: Baruch Siach > > Sent: Wednesday, February 3, 2021 15:59 > > To: Kostya Porotchkin > > Cc: linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; > > and...@lunn.ch; j...@semihalf.com; gregory.clem...@bootlin.com; > > li...@armlinux.org.uk; Nadav Haklai ; > > robh...@kernel.org; Stefan Chulski ; > > m...@semihalf.com; Ben Peled ; > > sebastian.hesselba...@gmail.com; linux-arm-ker...@lists.infradead.org > > Subject: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI > > settings > > > > External Email > > > > -- > > Hi Konstantin, > > > > On Wed, Feb 03 2021, kos...@marvell.com wrote: > > > From: Konstantin Porotchkin > > > > > > Update the settings for AP806 SDHCI interface according to latest > > > Xenon drivers changes. > > > - no need to select the PHY slow mode anymore > > > > Why? Has anything changed since the introduction of marvell,xenon-phy-slow- > > mode? > [KP] AP806 B0, AP807 and later do not need the "slow mode" set by the default. > The HWE-7296210 errata is not applicable to these components and they are > able > to run AP SDHCI in HS400 8-bit mode. So what about all those people, such as me, who have A0 silicon on their Macchiatobin boards? You can't just go around removing DT properties like this. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings
Hi, Baruch,
> -Original Message-
> From: Baruch Siach
> Sent: Wednesday, February 3, 2021 15:59
> To: Kostya Porotchkin
> Cc: linux-kernel@vger.kernel.org; devicet...@vger.kernel.org;
> and...@lunn.ch; j...@semihalf.com; gregory.clem...@bootlin.com;
> li...@armlinux.org.uk; Nadav Haklai ;
> robh...@kernel.org; Stefan Chulski ;
> m...@semihalf.com; Ben Peled ;
> sebastian.hesselba...@gmail.com; linux-arm-ker...@lists.infradead.org
> Subject: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI
> settings
>
> External Email
>
> --
> Hi Konstantin,
>
> On Wed, Feb 03 2021, kos...@marvell.com wrote:
> > From: Konstantin Porotchkin
> >
> > Update the settings for AP806 SDHCI interface according to latest
> > Xenon drivers changes.
> > - no need to select the PHY slow mode anymore
>
> Why? Has anything changed since the introduction of marvell,xenon-phy-slow-
> mode?
[KP] AP806 B0, AP807 and later do not need the "slow mode" set by the default.
The HWE-7296210 errata is not applicable to these components and they are able
to run AP SDHCI in HS400 8-bit mode.
Kosta
>
> baruch
>
> > -* Not stable in HS modes - phy needs "more calibration", so add
> > -* the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> > -*/
> > - marvell,xenon-phy-slow-mode;
> > no-1-8-v;
> > no-sd;
> > no-sdio;
> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > index 12e477f1aeb9..edd6131a0587 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > @@ -257,7 +257,6 @@
> > clock-names = "core";
> > clocks = <_clk 4>;
> > dma-coherent;
> > - marvell,xenon-phy-slow-mode;
> > status = "disabled";
> > };
>
>
> --
> ~. .~ Tk Open Systems
> =}ooO--U--Ooo{=
>- bar...@tkos.co.il - tel: +972.52.368.4656,
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.tkos.co.il=DwIBAg=nKjWec2b6R0mOyPaz7xtfQ=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o=F567knLB6kbyr-
> BZRqLFLJgXHENu41578OHxsKQQ-
> sw=eXEBLtBC3CwWIF9XFbHrgSgASz4aMgHi5W1uuXTgdQ4= -
