RE: [PATCH] Use the correct size to set block max sectors

2016-06-03 Thread Long Li 
Hi Martin,

Yes I would like to test it. Please let me know when they get in there.

Thanks

Long


> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, May 31, 2016 7:44 PM
> To: Long Li <lon...@microsoft.com>
> Cc: Bart Van Assche <bart.vanass...@sandisk.com>; James E.J. Bottomley
> <j...@linux.vnet.ibm.com>; Martin K. Petersen
> <martin.peter...@oracle.com>; KY Srinivasan <k...@microsoft.com>; linux-
> s...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Use the correct size to set block max sectors
> 
> >>>>> "Long" == Long Li <lon...@microsoft.com> writes:
> 
> Long,
> 
> Long> Yes, this has been fixed in that patch.
> 
> I'd like to get my patch into scsi-fixes but it needs another set of eyes. 
> Would
> you mind either testing or reviewing it?
> 
> Thanks!
> 
> --
> Martin K. PetersenOracle Linux Engineering

RE: [PATCH] Use the correct size to set block max sectors

2016-06-03 Thread Long Li 
Hi Martin,

Yes I would like to test it. Please let me know when they get in there.

Thanks

Long


> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, May 31, 2016 7:44 PM
> To: Long Li 
> Cc: Bart Van Assche ; James E.J. Bottomley
> ; Martin K. Petersen
> ; KY Srinivasan ; linux-
> s...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Use the correct size to set block max sectors
> 
> >>>>> "Long" == Long Li  writes:
> 
> Long,
> 
> Long> Yes, this has been fixed in that patch.
> 
> I'd like to get my patch into scsi-fixes but it needs another set of eyes. 
> Would
> you mind either testing or reviewing it?
> 
> Thanks!
> 
> --
> Martin K. PetersenOracle Linux Engineering

Re: [PATCH] Use the correct size to set block max sectors

2016-05-31 Thread Martin K. Petersen 
> "Long" == Long Li  writes:

Long,

Long> Yes, this has been fixed in that patch.

I'd like to get my patch into scsi-fixes but it needs another set of
eyes. Would you mind either testing or reviewing it?

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] Use the correct size to set block max sectors

2016-05-31 Thread Martin K. Petersen 
> "Long" == Long Li  writes:

Long,

Long> Yes, this has been fixed in that patch.

I'd like to get my patch into scsi-fixes but it needs another set of
eyes. Would you mind either testing or reviewing it?

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

RE: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Long Li 
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Thursday, May 26, 2016 7:19 PM
> To: Long Li <lon...@microsoft.com>; James E.J. Bottomley
> <j...@linux.vnet.ibm.com>; Martin K. Petersen
> <martin.peter...@oracle.com>
> Cc: KY Srinivasan <k...@microsoft.com>; linux-s...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] Use the correct size to set block max sectors
> 
> On 05/26/16 17:08, Long Li wrote:
> > The block sector size should be in unit of 512 bytes, not in bytes.
> >
> > Signed-off-by: Long Li <lon...@microsoft.com>
> >
> > ---
> >  drivers/scsi/sd.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index
> > 428c03e..4bce17e 100644
> > --- a/drivers/scsi/sd.c
> > +++ b/drivers/scsi/sd.c
> > @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
> > if (sdkp->opt_xfer_blocks &&
> > sdkp->opt_xfer_blocks <= dev_max &&
> > sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> > -   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> > -   rw_max = q->limits.io_opt =
> > +   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> > +   q->limits.io_opt =
> > sdkp->opt_xfer_blocks * sdp->sector_size;
> > +   rw_max = (q->limits.io_opt >> 9);
> > +   }
> > else
> > rw_max = BLK_DEF_MAX_SECTORS;
> 
> Isn't this a duplicate of a patch Martin Petersen posted three weeks ago? See
> also
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fthread.g
> mane.org%2fgmane.linux.scsi%2f113746=01%7c01%7clongli%40micros
> oft.com%7c4396718e6f9749d178bf08d385d53bba%7c72f988bf86f141af91ab2
> d7cd011db47%7c1=UpiYwEdYMtqcwuNS1llVuXcQ6riFT3b5%2b44Sn56
> Bl14%3d.
> 
> Bart.
> 
> 

Yes, this has been fixed in that patch.

Please drop this one.

RE: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Long Li 
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Thursday, May 26, 2016 7:19 PM
> To: Long Li ; James E.J. Bottomley
> ; Martin K. Petersen
> 
> Cc: KY Srinivasan ; linux-s...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] Use the correct size to set block max sectors
> 
> On 05/26/16 17:08, Long Li wrote:
> > The block sector size should be in unit of 512 bytes, not in bytes.
> >
> > Signed-off-by: Long Li 
> >
> > ---
> >  drivers/scsi/sd.c | 6 --
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index
> > 428c03e..4bce17e 100644
> > --- a/drivers/scsi/sd.c
> > +++ b/drivers/scsi/sd.c
> > @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
> > if (sdkp->opt_xfer_blocks &&
> > sdkp->opt_xfer_blocks <= dev_max &&
> > sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> > -   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> > -   rw_max = q->limits.io_opt =
> > +   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> > +   q->limits.io_opt =
> > sdkp->opt_xfer_blocks * sdp->sector_size;
> > +   rw_max = (q->limits.io_opt >> 9);
> > +   }
> > else
> > rw_max = BLK_DEF_MAX_SECTORS;
> 
> Isn't this a duplicate of a patch Martin Petersen posted three weeks ago? See
> also
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fthread.g
> mane.org%2fgmane.linux.scsi%2f113746=01%7c01%7clongli%40micros
> oft.com%7c4396718e6f9749d178bf08d385d53bba%7c72f988bf86f141af91ab2
> d7cd011db47%7c1=UpiYwEdYMtqcwuNS1llVuXcQ6riFT3b5%2b44Sn56
> Bl14%3d.
> 
> Bart.
> 
> 

Yes, this has been fixed in that patch.

Please drop this one.

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Bart Van Assche 

On 05/26/16 17:08, Long Li wrote:

The block sector size should be in unit of 512 bytes, not in bytes.

Signed-off-by: Long Li 

---
 drivers/scsi/sd.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
if (sdkp->opt_xfer_blocks &&
sdkp->opt_xfer_blocks <= dev_max &&
sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
-   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
-   rw_max = q->limits.io_opt =
+   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
+   q->limits.io_opt =
sdkp->opt_xfer_blocks * sdp->sector_size;
+   rw_max = (q->limits.io_opt >> 9);
+   }
else
rw_max = BLK_DEF_MAX_SECTORS;


Isn't this a duplicate of a patch Martin Petersen posted three weeks 
ago? See also http://thread.gmane.org/gmane.linux.scsi/113746.


Bart.

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Bart Van Assche 

On 05/26/16 17:08, Long Li wrote:

The block sector size should be in unit of 512 bytes, not in bytes.

Signed-off-by: Long Li 

---
 drivers/scsi/sd.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
if (sdkp->opt_xfer_blocks &&
sdkp->opt_xfer_blocks <= dev_max &&
sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
-   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
-   rw_max = q->limits.io_opt =
+   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
+   q->limits.io_opt =
sdkp->opt_xfer_blocks * sdp->sector_size;
+   rw_max = (q->limits.io_opt >> 9);
+   }
else
rw_max = BLK_DEF_MAX_SECTORS;


Isn't this a duplicate of a patch Martin Petersen posted three weeks 
ago? See also http://thread.gmane.org/gmane.linux.scsi/113746.


Bart.

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Joe Perches 
dOn Thu, 2016-05-26 at 17:08 -0700, Long Li wrote:
> The block sector size should be in unit of 512 bytes, not in bytes.

Thanks.  The patch subject should use something like:

[PATCH] sd: Use the correct size to set block max sectors

to show what subsystem is being modified.

> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
[]
> @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
>   if (sdkp->opt_xfer_blocks &&
>   sdkp->opt_xfer_blocks <= dev_max &&
>   sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> - rw_max = q->limits.io_opt =
> + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> + q->limits.io_opt =
>   sdkp->opt_xfer_blocks * sdp->sector_size;
> + rw_max = (q->limits.io_opt >> 9);
> + }
>   else
>   rw_max = BLK_DEF_MAX_SECTORS;

And style trivia:  it'd be more kernel style consistent as:

if (...
    sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
q->limits.io_opt = sdkp->opt_xfer_blocks * sdp->sector_size;
rw_max = q->limits.io_opt >> 9;
} else {
rw_max = BLK_DEF_MAX_SECTORS;
}

ie: no parentheses necessary around the shifted value and
    braces around both arms.

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Joe Perches 
dOn Thu, 2016-05-26 at 17:08 -0700, Long Li wrote:
> The block sector size should be in unit of 512 bytes, not in bytes.

Thanks.  The patch subject should use something like:

[PATCH] sd: Use the correct size to set block max sectors

to show what subsystem is being modified.

> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
[]
> @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
>   if (sdkp->opt_xfer_blocks &&
>   sdkp->opt_xfer_blocks <= dev_max &&
>   sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> - rw_max = q->limits.io_opt =
> + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> + q->limits.io_opt =
>   sdkp->opt_xfer_blocks * sdp->sector_size;
> + rw_max = (q->limits.io_opt >> 9);
> + }
>   else
>   rw_max = BLK_DEF_MAX_SECTORS;

And style trivia:  it'd be more kernel style consistent as:

if (...
    sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
q->limits.io_opt = sdkp->opt_xfer_blocks * sdp->sector_size;
rw_max = q->limits.io_opt >> 9;
} else {
rw_max = BLK_DEF_MAX_SECTORS;
}

ie: no parentheses necessary around the shifted value and
    braces around both arms.

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Fam Zheng 
On Thu, 05/26 17:08, Long Li wrote:
> The block sector size should be in unit of 512 bytes, not in bytes.
> 
> Signed-off-by: Long Li 
> 
> ---
>  drivers/scsi/sd.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 428c03e..4bce17e 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
>   if (sdkp->opt_xfer_blocks &&
>   sdkp->opt_xfer_blocks <= dev_max &&
>   sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> - rw_max = q->limits.io_opt =
> + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> + q->limits.io_opt =
>   sdkp->opt_xfer_blocks * sdp->sector_size;
> + rw_max = (q->limits.io_opt >> 9);

Other than the superfluous parenthesis, looks good to me.

Fam

> + }
>   else
>   rw_max = BLK_DEF_MAX_SECTORS;
>  
> -- 
> 1.8.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Fam Zheng 
On Thu, 05/26 17:08, Long Li wrote:
> The block sector size should be in unit of 512 bytes, not in bytes.
> 
> Signed-off-by: Long Li 
> 
> ---
>  drivers/scsi/sd.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 428c03e..4bce17e 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
>   if (sdkp->opt_xfer_blocks &&
>   sdkp->opt_xfer_blocks <= dev_max &&
>   sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
> - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
> - rw_max = q->limits.io_opt =
> + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
> + q->limits.io_opt =
>   sdkp->opt_xfer_blocks * sdp->sector_size;
> + rw_max = (q->limits.io_opt >> 9);

Other than the superfluous parenthesis, looks good to me.

Fam

> + }
>   else
>   rw_max = BLK_DEF_MAX_SECTORS;
>  
> -- 
> 1.8.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Long Li 
The block sector size should be in unit of 512 bytes, not in bytes.

Signed-off-by: Long Li 

---
 drivers/scsi/sd.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
if (sdkp->opt_xfer_blocks &&
sdkp->opt_xfer_blocks <= dev_max &&
sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
-   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
-   rw_max = q->limits.io_opt =
+   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
+   q->limits.io_opt =
sdkp->opt_xfer_blocks * sdp->sector_size;
+   rw_max = (q->limits.io_opt >> 9);
+   }
else
rw_max = BLK_DEF_MAX_SECTORS;
 
-- 
1.8.5.6

[PATCH] Use the correct size to set block max sectors

2016-05-26 Thread Long Li 
The block sector size should be in unit of 512 bytes, not in bytes.

Signed-off-by: Long Li 

---
 drivers/scsi/sd.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk)
if (sdkp->opt_xfer_blocks &&
sdkp->opt_xfer_blocks <= dev_max &&
sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS &&
-   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE)
-   rw_max = q->limits.io_opt =
+   sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) {
+   q->limits.io_opt =
sdkp->opt_xfer_blocks * sdp->sector_size;
+   rw_max = (q->limits.io_opt >> 9);
+   }
else
rw_max = BLK_DEF_MAX_SECTORS;
 
-- 
1.8.5.6