[PATCH 0/2] net: macb: Add support for SiFive FU540-C000
On FU540, the management IP block is tightly coupled with the Cadence MACB IP block. It manages many of the boundary signals from the MACB IP This patchset controls the tx_clk input signal to the MACB IP. It switches between the local TX clock (125MHz) and PHY TX clocks. This is necessary to toggle between 1Gb and 100/10Mb speeds. Future patches may add support for monitoring or controlling other IP boundary signals. This patchset is mostly based on work done by Wesley Terpstra This patchset is based on Linux v5.2-rc1 and tested on HiFive Unleashed board with additional board related patches needed for testing can be found at dev/yashs/ethernet branch of: https://github.com/yashshah7/riscv-linux.git Yash Shah (2): net/macb: bindings doc: add sifive fu540-c000 binding net: macb: Add support for SiFive FU540-C000 Documentation/devicetree/bindings/net/macb.txt | 3 + drivers/net/ethernet/cadence/macb_main.c | 118 + 2 files changed, 121 insertions(+) -- 1.9.1
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
On Mai 23 2019, Yash Shah wrote: > On FU540, the management IP block is tightly coupled with the Cadence > MACB IP block. It manages many of the boundary signals from the MACB IP > This patchset controls the tx_clk input signal to the MACB IP. It > switches between the local TX clock (125MHz) and PHY TX clocks. This > is necessary to toggle between 1Gb and 100/10Mb speeds. Doesn't work for me: [ 365.842801] macb: probe of 1009.ethernet failed with error -17 Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
Please be consistent in your subsystem prefixes used in your Subject lines. You use "net: macb:" then "net/macb:" Really, plain "macb: " is sufficient. Thank you.
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
Hi Andreas, On Thu, May 23, 2019 at 6:19 PM Andreas Schwab wrote: > > On Mai 23 2019, Yash Shah wrote: > > > On FU540, the management IP block is tightly coupled with the Cadence > > MACB IP block. It manages many of the boundary signals from the MACB IP > > This patchset controls the tx_clk input signal to the MACB IP. It > > switches between the local TX clock (125MHz) and PHY TX clocks. This > > is necessary to toggle between 1Gb and 100/10Mb speeds. > > Doesn't work for me: > > [ 365.842801] macb: probe of 1009.ethernet failed with error -17 > Make sure you have applied all the patches needed for testing found at dev/yashs/ethernet branch of: https://github.com/yashshah7/riscv-linux.git In addition to that, make sure in your kernel config GPIO_SIFIVE=y In v2 of this patch, I will add this select GPIO_SIFIVE config in the Cadence Kconfig file. - Yash
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
On Thu, May 23, 2019 at 9:58 PM David Miller wrote: > > > Please be consistent in your subsystem prefixes used in your Subject lines. > You use "net: macb:" then "net/macb:" Really, plain "macb: " is sufficient. Sure, Will take care of this in the next revision of this patch. Thanks for your comment. - Yash
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
On Mai 24 2019, Yash Shah wrote: > Hi Andreas, > > On Thu, May 23, 2019 at 6:19 PM Andreas Schwab wrote: >> >> On Mai 23 2019, Yash Shah wrote: >> >> > On FU540, the management IP block is tightly coupled with the Cadence >> > MACB IP block. It manages many of the boundary signals from the MACB IP >> > This patchset controls the tx_clk input signal to the MACB IP. It >> > switches between the local TX clock (125MHz) and PHY TX clocks. This >> > is necessary to toggle between 1Gb and 100/10Mb speeds. >> >> Doesn't work for me: >> >> [ 365.842801] macb: probe of 1009.ethernet failed with error -17 >> > > Make sure you have applied all the patches needed for testing found at > dev/yashs/ethernet branch of: Nope, try reloading the module. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000
On Mon, May 27, 2019 at 1:34 PM Andreas Schwab wrote: > > On Mai 24 2019, Yash Shah wrote: > > > Hi Andreas, > > > > On Thu, May 23, 2019 at 6:19 PM Andreas Schwab wrote: > >> > >> On Mai 23 2019, Yash Shah wrote: > >> > >> > On FU540, the management IP block is tightly coupled with the Cadence > >> > MACB IP block. It manages many of the boundary signals from the MACB IP > >> > This patchset controls the tx_clk input signal to the MACB IP. It > >> > switches between the local TX clock (125MHz) and PHY TX clocks. This > >> > is necessary to toggle between 1Gb and 100/10Mb speeds. > >> > >> Doesn't work for me: > >> > >> [ 365.842801] macb: probe of 1009.ethernet failed with error -17 > >> > > > > Make sure you have applied all the patches needed for testing found at > > dev/yashs/ethernet branch of: > > Nope, try reloading the module. Yes, I could see the error on reloading the module. Thanks for the catch. I will fix this in the next version of this patch. - Yash
