[PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-12 Thread alexander . levin 
From: Mengting Zhang 

Commit 681fbec881de ("lockdep: Use consistent printing primitives")
has moved lockdep away from using printk() for printing.

Unfourtenatly, the commit added usage of pr_cont() which wasn't
wrapped in the userspace headers, causing the following warning:

../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration 
of function 'pr_cont' [-Wimplicit-function-declaration]

Adding an empty declaration of 'pr_cont' fixes the problem.

Reviewed-by: Alexander Sverdlin 
Signed-off-by: Mengting Zhang 
Signed-off-by: Sasha Levin 
---
 tools/include/linux/lockdep.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/include/linux/lockdep.h b/tools/include/linux/lockdep.h
index 940c1b075659..6b0c36a58fcb 100644
--- a/tools/include/linux/lockdep.h
+++ b/tools/include/linux/lockdep.h
@@ -48,6 +48,7 @@ static inline int debug_locks_off(void)
 #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__)
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
 #define pr_warn pr_err
+#define pr_cont pr_err
 
 #define list_del_rcu list_del
 
-- 
2.11.0

[PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-12 Thread alexander . levin 
From: Mengting Zhang 

Commit 681fbec881de ("lockdep: Use consistent printing primitives")
has moved lockdep away from using printk() for printing.

Unfourtenatly, the commit added usage of pr_cont() which wasn't
wrapped in the userspace headers, causing the following warning:

../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration 
of function 'pr_cont' [-Wimplicit-function-declaration]

Adding an empty declaration of 'pr_cont' fixes the problem.

Reviewed-by: Alexander Sverdlin 
Signed-off-by: Mengting Zhang 
Signed-off-by: Sasha Levin 
---
 tools/include/linux/lockdep.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/include/linux/lockdep.h b/tools/include/linux/lockdep.h
index 940c1b075659..6b0c36a58fcb 100644
--- a/tools/include/linux/lockdep.h
+++ b/tools/include/linux/lockdep.h
@@ -48,6 +48,7 @@ static inline int debug_locks_off(void)
 #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__)
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
 #define pr_warn pr_err
+#define pr_cont pr_err
 
 #define list_del_rcu list_del
 
-- 
2.11.0

Re: [PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-07 Thread Ingo Molnar 

* alexander.le...@verizon.com  wrote:

> From: Mengting Zhang 
> 
> An annoying compile warning due to missing declaration is shown below:
> In file included from lockdep.c:27:0:
> ../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' :
> ../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of 
> function 'pr_cont' [-Wimplicit-function-declaration]
>   pr_cont(") at:\n");
>   ^

All build warnings are annoying, please formulate this in a more neutral 
fashion.

Also, please separate the compiler splat from the changelog text with an empty 
line, and align it vertically as well so that it seprates more.

Please do this for the second patch as well, and try to harmonize the style of 
the 
changelogs.

This is an example of a clean changelog that fixes a build warning:

commit 1b3b5219abfd6a214e99018747e9fe98514b43ca
Author: Arnaldo Carvalho de Melo 
Date:   Mon Nov 27 12:18:23 2017 -0300

tools headers: Syncronize mman.h ABI header

To add support for the MAP_SYNC flag introduced in:

  b6fb293f2497 ("mm: Define MAP_SYNC and VM_SYNC flags")

Update tools/perf/trace/beauty/mmap.c to support that flag.

This silences this perf build warning:

  Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/mman.h' 
differs from latest version at 'include/uapi/asm-generic/mman.h'

Cc: Adrian Hunter 
Cc: Dan Williams 
Cc: David Ahern 
Cc: Jan Kara 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-14zyk3iywrj37c7g1eagm...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo 

Thanks,

Ingo

Re: [PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-07 Thread Ingo Molnar 

* alexander.le...@verizon.com  wrote:

> From: Mengting Zhang 
> 
> An annoying compile warning due to missing declaration is shown below:
> In file included from lockdep.c:27:0:
> ../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' :
> ../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of 
> function 'pr_cont' [-Wimplicit-function-declaration]
>   pr_cont(") at:\n");
>   ^

All build warnings are annoying, please formulate this in a more neutral 
fashion.

Also, please separate the compiler splat from the changelog text with an empty 
line, and align it vertically as well so that it seprates more.

Please do this for the second patch as well, and try to harmonize the style of 
the 
changelogs.

This is an example of a clean changelog that fixes a build warning:

commit 1b3b5219abfd6a214e99018747e9fe98514b43ca
Author: Arnaldo Carvalho de Melo 
Date:   Mon Nov 27 12:18:23 2017 -0300

tools headers: Syncronize mman.h ABI header

To add support for the MAP_SYNC flag introduced in:

  b6fb293f2497 ("mm: Define MAP_SYNC and VM_SYNC flags")

Update tools/perf/trace/beauty/mmap.c to support that flag.

This silences this perf build warning:

  Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/mman.h' 
differs from latest version at 'include/uapi/asm-generic/mman.h'

Cc: Adrian Hunter 
Cc: Dan Williams 
Cc: David Ahern 
Cc: Jan Kara 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-14zyk3iywrj37c7g1eagm...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo 

Thanks,

Ingo

[PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-07 Thread alexander . levin 
From: Mengting Zhang 

An annoying compile warning due to missing declaration is shown below:
In file included from lockdep.c:27:0:
../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' :
../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of 
function 'pr_cont' [-Wimplicit-function-declaration]
  pr_cont(") at:\n");
  ^
Adding the declaration of 'pr_cont' fixes the problem.

Reviewed-by: Alexander Sverdlin 
Signed-off-by: Mengting Zhang 
Signed-off-by: Sasha Levin 
---
 tools/include/linux/lockdep.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/include/linux/lockdep.h b/tools/include/linux/lockdep.h
index 940c1b075659..6b0c36a58fcb 100644
--- a/tools/include/linux/lockdep.h
+++ b/tools/include/linux/lockdep.h
@@ -48,6 +48,7 @@ static inline int debug_locks_off(void)
 #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__)
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
 #define pr_warn pr_err
+#define pr_cont pr_err
 
 #define list_del_rcu list_del
 
-- 
2.11.0

[PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()'

2017-12-07 Thread alexander . levin 
From: Mengting Zhang 

An annoying compile warning due to missing declaration is shown below:
In file included from lockdep.c:27:0:
../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' :
../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of 
function 'pr_cont' [-Wimplicit-function-declaration]
  pr_cont(") at:\n");
  ^
Adding the declaration of 'pr_cont' fixes the problem.

Reviewed-by: Alexander Sverdlin 
Signed-off-by: Mengting Zhang 
Signed-off-by: Sasha Levin 
---
 tools/include/linux/lockdep.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/include/linux/lockdep.h b/tools/include/linux/lockdep.h
index 940c1b075659..6b0c36a58fcb 100644
--- a/tools/include/linux/lockdep.h
+++ b/tools/include/linux/lockdep.h
@@ -48,6 +48,7 @@ static inline int debug_locks_off(void)
 #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__)
 #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__)
 #define pr_warn pr_err
+#define pr_cont pr_err
 
 #define list_del_rcu list_del
 
-- 
2.11.0