RE: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-18 Thread Anson Huang 
Hi, Fabio

Anson Huang
Best Regards!


> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Sunday, March 18, 2018 9:04 PM
> To: Anson Huang <anson.hu...@nxp.com>
> Cc: Shawn Guo <shawn...@kernel.org>; Sascha Hauer
> <ker...@pengutronix.de>; Fabio Estevam <fabio.este...@nxp.com>; Rob
> Herring <robh...@kernel.org>; Mark Rutland <mark.rutl...@arm.com>;
> Russell King - ARM Linux <li...@armlinux.org.uk>; Michael Turquette
> <mturque...@baylibre.com>; Stephen Boyd <sb...@kernel.org>; S.j. Wang
> <shengjiu.w...@nxp.com>; dl-linux-imx <linux-...@nxp.com>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-ker...@lists.infradead.org>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicet...@vger.kernel.org>; linux-kernel
> <linux-kernel@vger.kernel.org>; linux-clk <linux-...@vger.kernel.org>
> Subject: Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock
> source
> 
> On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang <anson.hu...@nxp.com>
> wrote:
> 
> > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > index 72da5ac..83f7cac 100644
> > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > @@ -18,6 +18,14 @@
> > reg = <0x8000 0x8000>;
> > };
> >
> > +   clocks {
> > +   codec_osc: anaclk2 {
> > +   #clock-cells = <0>;
> > +   compatible = "fixed-clock";
> > +   clock-frequency = <24576000>;
> > +   };
> > +   };
> 
> The clocks container should be removed and the clock node could be put 
> directly
> into the root node.
> 
> Also, I do not see 'codec_osc' being used in this dts.
 
This clock will be used by cs42888 codec, this patch is only to add basic clock 
source
to complete the clock tree. Thanks.

Anson.

RE: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-18 Thread Anson Huang 
Hi, Fabio

Anson Huang
Best Regards!


> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Sunday, March 18, 2018 9:04 PM
> To: Anson Huang 
> Cc: Shawn Guo ; Sascha Hauer
> ; Fabio Estevam ; Rob
> Herring ; Mark Rutland ;
> Russell King - ARM Linux ; Michael Turquette
> ; Stephen Boyd ; S.j. Wang
> ; dl-linux-imx ; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> ; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS ; linux-kernel
> ; linux-clk 
> Subject: Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock
> source
> 
> On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang 
> wrote:
> 
> > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > index 72da5ac..83f7cac 100644
> > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > @@ -18,6 +18,14 @@
> > reg = <0x8000 0x8000>;
> > };
> >
> > +   clocks {
> > +   codec_osc: anaclk2 {
> > +   #clock-cells = <0>;
> > +   compatible = "fixed-clock";
> > +   clock-frequency = <24576000>;
> > +   };
> > +   };
> 
> The clocks container should be removed and the clock node could be put 
> directly
> into the root node.
> 
> Also, I do not see 'codec_osc' being used in this dts.
 
This clock will be used by cs42888 codec, this patch is only to add basic clock 
source
to complete the clock tree. Thanks.

Anson.

Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-18 Thread Fabio Estevam 
On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang  wrote:

> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts 
> b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 72da5ac..83f7cac 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -18,6 +18,14 @@
> reg = <0x8000 0x8000>;
> };
>
> +   clocks {
> +   codec_osc: anaclk2 {
> +   #clock-cells = <0>;
> +   compatible = "fixed-clock";
> +   clock-frequency = <24576000>;
> +   };
> +   };

The clocks container should be removed and the clock node could be put
directly into the root node.

Also, I do not see 'codec_osc' being used in this dts.

Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-18 Thread Fabio Estevam 
On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang  wrote:

> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts 
> b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 72da5ac..83f7cac 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -18,6 +18,14 @@
> reg = <0x8000 0x8000>;
> };
>
> +   clocks {
> +   codec_osc: anaclk2 {
> +   #clock-cells = <0>;
> +   compatible = "fixed-clock";
> +   clock-frequency = <24576000>;
> +   };
> +   };

The clocks container should be removed and the clock node could be put
directly into the root node.

Also, I do not see 'codec_osc' being used in this dts.

[PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-17 Thread Anson Huang 
On i.MX6SX SabreAuto board, there is external 24MHz clock
source for analog clock2, add this clock source to clock tree.

Signed-off-by: Anson Huang 
---
 arch/arm/boot/dts/imx6sx-sabreauto.dts | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts 
b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index 72da5ac..83f7cac 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -18,6 +18,14 @@
reg = <0x8000 0x8000>;
};
 
+   clocks {
+   codec_osc: anaclk2 {
+   #clock-cells = <0>;
+   compatible = "fixed-clock";
+   clock-frequency = <24576000>;
+   };
+   };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
-- 
2.7.4

[PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-03-17 Thread Anson Huang 
On i.MX6SX SabreAuto board, there is external 24MHz clock
source for analog clock2, add this clock source to clock tree.

Signed-off-by: Anson Huang 
---
 arch/arm/boot/dts/imx6sx-sabreauto.dts | 8 
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts 
b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index 72da5ac..83f7cac 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -18,6 +18,14 @@
reg = <0x8000 0x8000>;
};
 
+   clocks {
+   codec_osc: anaclk2 {
+   #clock-cells = <0>;
+   compatible = "fixed-clock";
+   clock-frequency = <24576000>;
+   };
+   };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
-- 
2.7.4