RE: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet
Hi, Leonard > -Original Message- > From: Leonard Crestez > Sent: Friday, June 28, 2019 2:01 PM > To: Anson Huang ; Jacky Bai ; > l.st...@pengutronix.de > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > viresh.ku...@linaro.org; Daniel Baluta ; Abel > Vesa ; andrew.smir...@gmail.com; > ccai...@baylibre.com; an...@akkea.ca; a...@sigxcpu.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to > latest datasheet > > On 28.06.2019 06:37, anson.hu...@nxp.com wrote: > > > According to latest datasheet (Rev.0.2, 04/2019) from below links, > > 1.8GHz is ONLY available for consumer part, so the market segment bits > > for 1.8GHz opp should ONLY available for consumer part accordingly. > > > > opp-hz = /bits/ 64 <18>; > > opp-microvolt = <100>; > > /* Consumer only but rely on speed grading */ > > - opp-supported-hw = <0x8>, <0x7>; > > + opp-supported-hw = <0x8>, <0x3>; > > Only consumer parts should be fused for this highest OPP. If you don't want > to rely on this then maybe also delete the comment above? As I replied in previous i.MX8MQ patch, if the comments make reader confused, should we just remove all those comments? Thanks, Anson. > > -- > Regards, > leonard
Re: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet
On 28.06.2019 06:37, anson.hu...@nxp.com wrote: > According to latest datasheet (Rev.0.2, 04/2019) from below links, > 1.8GHz is ONLY available for consumer part, so the market segment > bits for 1.8GHz opp should ONLY available for consumer part accordingly. > > opp-hz = /bits/ 64 <18>; > opp-microvolt = <100>; > /* Consumer only but rely on speed grading */ > - opp-supported-hw = <0x8>, <0x7>; > + opp-supported-hw = <0x8>, <0x3>; Only consumer parts should be fused for this highest OPP. If you don't want to rely on this then maybe also delete the comment above? -- Regards, leonard
[PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet
From: Anson Huang According to latest datasheet (Rev.0.2, 04/2019) from below links, 1.8GHz is ONLY available for consumer part, so the market segment bits for 1.8GHz opp should ONLY available for consumer part accordingly. https://www.nxp.com/docs/en/data-sheet/IMX8MMIEC.pdf https://www.nxp.com/docs/en/data-sheet/IMX8MMCEC.pdf Fixes: f403a26c865b (arm64: dts: imx8mm: Add cpu speed grading and all OPPs) Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index c38813d..ab0d135 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi @@ -135,7 +135,7 @@ opp-hz = /bits/ 64 <18>; opp-microvolt = <100>; /* Consumer only but rely on speed grading */ - opp-supported-hw = <0x8>, <0x7>; + opp-supported-hw = <0x8>, <0x3>; clock-latency-ns = <15>; }; }; -- 2.7.4
