Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Tue, 29 Sep 2015, Dmitry Torokhov wrote: > On Mon, Sep 28, 2015 at 08:19:27AM +, Opensource [Steve Twiss] wrote: > > > > > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings > > > for DA9062 OnKey > > > > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > > > From: S Twiss > > > > > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > > > > > Signed-off-by: Steve Twiss > > > > > > > > > > --- > > > > > Changes in V3: > > > > > - Child driver specifics separated out into separate document > > > > >in this case ../input/da9062-onkey.txt > > > > > Changes in V2: > > > > > - No change > > > > > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > > ++ > > > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > > > 9063, folded into the onkey patch and applied. > > > > > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > > > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > > > mainline. > > > > > > > Hi Lee and Dmitry, > > > > This patch seems to have been missed. It is the main OnKey driver for > > DA9062 and this > > component was waiting for the DA9062 MFD core to make it into > > linux-mainline/v4.3-rc1. > > > > Is there any reply on this yet please? There just seems to be a little > > patch administration > > problem holding things up. > > I queued it for 4.4. Thanks Dmitry. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On 30 September 2015 00:54 Dmitry Torokhov wrote: > To: Opensource [Steve Twiss] > Cc: Lee Jones; DEVICETREE; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXKERNEL; Mark Rutland; Pawel Moll; RTCLINUX; Rob Herring; David > Dajun Chen; Samuel Ortiz; Support Opensource > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Sep 28, 2015 at 08:19:27AM +, Opensource [Steve Twiss] > wrote: > > > > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings > > for DA9062 OnKey > > > > Hi Lee and Dmitry, > > > > This patch seems to have been missed. It is the main OnKey driver for > > DA9062 and this > > component was waiting for the DA9062 MFD core to make it into linux- > > mainline/v4.3-rc1. > > > > > > I queued it for 4.4. > > Thanks. > > -- > Dmitry Hi Dmitry, I can see it in your repo now. (a27b5e0 Input: add DA9062 OnKey capability to DA9063 OnKey driver) Thanks for your efforts on this patch. Regards, Stephen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Mon, Sep 28, 2015 at 08:19:27AM +, Opensource [Steve Twiss] wrote: > > > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings > > for DA9062 OnKey > > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > > From: S Twiss > > > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > > > Signed-off-by: Steve Twiss > > > > > > > > --- > > > > Changes in V3: > > > > - Child driver specifics separated out into separate document > > > >in this case ../input/da9062-onkey.txt > > > > Changes in V2: > > > > - No change > > > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > ++ > > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > > 9063, folded into the onkey patch and applied. > > > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > > mainline. > > > > Hi Lee and Dmitry, > > This patch seems to have been missed. It is the main OnKey driver for DA9062 > and this > component was waiting for the DA9062 MFD core to make it into > linux-mainline/v4.3-rc1. > > Is there any reply on this yet please? There just seems to be a little patch > administration > problem holding things up. I queued it for 4.4. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for
> DA9062 OnKey
>
> On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote:
> > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote:
> > > From: S Twiss
> > >
> > > Add device tree bindings for the DA9062 OnKey driver component
> > >
> > > Signed-off-by: Steve Twiss
> > >
> > > ---
> > > Changes in V3:
> > > - Child driver specifics separated out into separate document
> > >in this case ../input/da9062-onkey.txt
> > > Changes in V2:
> > > - No change
> > >
> > > This patch applies against linux-next and next-20150708
> > >
> > >
> > > .../devicetree/bindings/input/da9062-onkey.txt | 36
> ++
> > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++
> >
> > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and
> > 9063, folded into the onkey patch and applied.
>
> Argh, da9062 core is not in mainline yet... OK, below is the patch I
> had; if Lee does not pick it up I'll re-apply it when da9062 core hits
> mainline.
>
Hi Lee and Dmitry,
This patch seems to have been missed. It is the main OnKey driver for DA9062
and this
component was waiting for the DA9062 MFD core to make it into
linux-mainline/v4.3-rc1.
Is there any reply on this yet please? There just seems to be a little patch
administration
problem holding things up.
Regards,
Steve
>
> Input: add DA9062 OnKey capability to DA9063 OnKey driver
>
> From: S Twiss
>
> Add DA9062 OnKey support into the existing DA9063 OnKey driver
> component by
> using generic access tables for common register and bit mask definitions.
>
> The following change will add generic register and bit mask support to the
> DA9063 OnKey.
>
> The following alterations have been made to the DA9063 OnKey:
>
> - Addition of a da906x_chip_config structure to hold all
> generic registers and bitmasks for this type of OnKey component.
> - Addition of an struct of_device_id table for DA9063 and DA9062
> defaults
> - Refactoring functions to use struct da9063_onkey accesses to generic
> registers/masks instead of using defines from registers.h
> - Re-work of da9063_onkey_probe() to use of_match_node() and
> dev_get_regmap() to provide initialisation of generic registers and
> masks and access to regmap
>
> Signed-off-by: Steve Twiss
> Signed-off-by: Dmitry Torokhov
> ---
> .../devicetree/bindings/input/da9062-onkey.txt | 32 +
> drivers/input/misc/Kconfig |8 +
> drivers/input/misc/da9063_onkey.c | 129
>
> 3 files changed, 140 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/da9062-
> onkey.txt
>
> diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> new file mode 100644
> index 000..ab0e048
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> @@ -0,0 +1,32 @@
> +* Dialog DA9062/63 OnKey Module
> +
> +This module is part of the DA9062/DA9063. For more details about entire
> +chips see Documentation/devicetree/bindings/mfd/da9062.txt and
> +Documentation/devicetree/bindings/mfd/da9063.txt
> +
> +This module provides KEY_POWER, KEY_SLEEP and events.
> +
> +Required properties:
> +
> + - compatible: should be one of:
> + dlg,da9062-onkey
> + dlg,da9063-onkey
> +
> +Optional properties:
> +
> + - dlg,disable-key-power : Disable power-down using a long key-press. If
> this
> +entry exists the OnKey driver will remove support for the KEY_POWER
> key
> +press. If this entry does not exist then by default the key-press
> +triggered power down is enabled and the OnKey will support both
> KEY_POWER
> +and KEY_SLEEP.
> +
> +Example:
> +
> + pmic0: da9062@58 {
> +
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + dlg,disable-key-power;
> + };
> +
> + };
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index d4f0a81..d4b993d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -611,11 +611,11 @@ config INPUT_DA9055_ONKEY
> will be called da9055_onkey.
>
> config INPUT_DA9063_ONKEY
> - tristate "Dialog DA9063 OnKey"
> - depends on MFD_DA9063
> + tristate "Dialog DA9062/63 OnKey"
> + depends on MFD_DA9063 || M
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Tue, 28 Jul 2015, Dmitry Torokhov wrote: > On Tue, Jul 28, 2015 at 09:40:19AM +0100, Lee Jones wrote: > > On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > > > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > > > From: S Twiss > > > > > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > > > > > Signed-off-by: Steve Twiss > > > > > > > > > > --- > > > > > Changes in V3: > > > > > - Child driver specifics separated out into separate document > > > > >in this case ../input/da9062-onkey.txt > > > > > Changes in V2: > > > > > - No change > > > > > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > > > > ++ > > > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > > > 9063, folded into the onkey patch and applied. > > > > > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > > > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > > > mainline. > > > > Hmm... that's annoying. You've put the patch below your signature > > '--', so my mailer cuts it off. > > OK, sorry, I'll make sure to put in before the signature next time. Appreciated. > > [pasting] > > > > > Input: add DA9062 OnKey capability to DA9063 OnKey driver > > > > > > From: S Twiss > > > > > > Add DA9062 OnKey support into the existing DA9063 OnKey driver component > > > by > > > using generic access tables for common register and bit mask definitions. > > > > > > The following change will add generic register and bit mask support to the > > > DA9063 OnKey. > > > > > > The following alterations have been made to the DA9063 OnKey: > > > > > > - Addition of a da906x_chip_config structure to hold all > > > generic registers and bitmasks for this type of OnKey component. > > > - Addition of an struct of_device_id table for DA9063 and DA9062 > > > defaults > > > - Refactoring functions to use struct da9063_onkey accesses to generic > > > registers/masks instead of using defines from registers.h > > > - Re-work of da9063_onkey_probe() to use of_match_node() and > > > dev_get_regmap() to provide initialisation of generic registers and > > > masks and access to regmap > > > > > > Signed-off-by: Steve Twiss > > > Signed-off-by: Dmitry Torokhov > > > --- > > > .../devicetree/bindings/input/da9062-onkey.txt | 32 + > > > drivers/input/misc/Kconfig |8 + > > > drivers/input/misc/da9063_onkey.c | 129 > > > > > > 3 files changed, 140 insertions(+), 29 deletions(-) > > > create mode 100644 > > > Documentation/devicetree/bindings/input/da9062-onkey.txt > > > > I'm confused. What's the dependency? > > > > There shouldn't be any issue applying input patches, just because > > there isn't an MFD counterpart. In fact, I would take prior > > acceptance of the child into consideration (would be like a +1 vote) > > when reviewing the MFD part. > > It's this chunk: > > +#include > +#include > > and these header files are not in mainline yet. Ah, thanks for the clarification. I will apply the other patches. > > One suggestion however, I would ask for the DT binding and the driver > > to be separated, as per [0]. > > > > [0] Documentation/devicetree/bindings/submitting-patches.txt > > Right, but that says about submitting patches, not applying them ;) > > When I chatted with Grant he said that the policy of separating binding > and code into separate patches is done so not to overwhelm devicetree > list and that is is perfectly fine to actually apply them as a single > commit. I try to combine them together so that when looking through > history they show up as one. Got you. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Tue, Jul 28, 2015 at 09:40:19AM +0100, Lee Jones wrote: > On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > > From: S Twiss > > > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > > > Signed-off-by: Steve Twiss > > > > > > > > --- > > > > Changes in V3: > > > > - Child driver specifics separated out into separate document > > > >in this case ../input/da9062-onkey.txt > > > > Changes in V2: > > > > - No change > > > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > > > ++ > > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > > 9063, folded into the onkey patch and applied. > > > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > > mainline. > > Hmm... that's annoying. You've put the patch below your signature > '--', so my mailer cuts it off. OK, sorry, I'll make sure to put in before the signature next time. > > [pasting] > > > Input: add DA9062 OnKey capability to DA9063 OnKey driver > > > > From: S Twiss > > > > Add DA9062 OnKey support into the existing DA9063 OnKey driver component by > > using generic access tables for common register and bit mask definitions. > > > > The following change will add generic register and bit mask support to the > > DA9063 OnKey. > > > > The following alterations have been made to the DA9063 OnKey: > > > > - Addition of a da906x_chip_config structure to hold all > > generic registers and bitmasks for this type of OnKey component. > > - Addition of an struct of_device_id table for DA9063 and DA9062 > > defaults > > - Refactoring functions to use struct da9063_onkey accesses to generic > > registers/masks instead of using defines from registers.h > > - Re-work of da9063_onkey_probe() to use of_match_node() and > > dev_get_regmap() to provide initialisation of generic registers and > > masks and access to regmap > > > > Signed-off-by: Steve Twiss > > Signed-off-by: Dmitry Torokhov > > --- > > .../devicetree/bindings/input/da9062-onkey.txt | 32 + > > drivers/input/misc/Kconfig |8 + > > drivers/input/misc/da9063_onkey.c | 129 > > > > 3 files changed, 140 insertions(+), 29 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt > > I'm confused. What's the dependency? > > There shouldn't be any issue applying input patches, just because > there isn't an MFD counterpart. In fact, I would take prior > acceptance of the child into consideration (would be like a +1 vote) > when reviewing the MFD part. It's this chunk: +#include +#include and these header files are not in mainline yet. > > One suggestion however, I would ask for the DT binding and the driver > to be separated, as per [0]. > > [0] Documentation/devicetree/bindings/submitting-patches.txt Right, but that says about submitting patches, not applying them ;) When I chatted with Grant he said that the policy of separating binding and code into separate patches is done so not to overwhelm devicetree list and that is is perfectly fine to actually apply them as a single commit. I try to combine them together so that when looking through history they show up as one. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Thu, 23 Jul 2015, S Twiss wrote: > From: S Twiss > > Add device tree bindings for the DA9062 OnKey driver component > > Signed-off-by: Steve Twiss > > --- > Changes in V3: > - Child driver specifics separated out into separate document >in this case ../input/da9062-onkey.txt > Changes in V2: > - No change > > This patch applies against linux-next and next-20150708 > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > ++ > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ For the MFD part: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > Signed-off-by: Steve Twiss > > > > > > --- > > > Changes in V3: > > > - Child driver specifics separated out into separate document > > >in this case ../input/da9062-onkey.txt > > > Changes in V2: > > > - No change > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > > ++ > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > 9063, folded into the onkey patch and applied. > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > mainline. Hmm... that's annoying. You've put the patch below your signature '--', so my mailer cuts it off. [pasting] > Input: add DA9062 OnKey capability to DA9063 OnKey driver > > From: S Twiss > > Add DA9062 OnKey support into the existing DA9063 OnKey driver component by > using generic access tables for common register and bit mask definitions. > > The following change will add generic register and bit mask support to the > DA9063 OnKey. > > The following alterations have been made to the DA9063 OnKey: > > - Addition of a da906x_chip_config structure to hold all > generic registers and bitmasks for this type of OnKey component. > - Addition of an struct of_device_id table for DA9063 and DA9062 > defaults > - Refactoring functions to use struct da9063_onkey accesses to generic > registers/masks instead of using defines from registers.h > - Re-work of da9063_onkey_probe() to use of_match_node() and > dev_get_regmap() to provide initialisation of generic registers and > masks and access to regmap > > Signed-off-by: Steve Twiss > Signed-off-by: Dmitry Torokhov > --- > .../devicetree/bindings/input/da9062-onkey.txt | 32 + > drivers/input/misc/Kconfig |8 + > drivers/input/misc/da9063_onkey.c | 129 > > 3 files changed, 140 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt I'm confused. What's the dependency? There shouldn't be any issue applying input patches, just because there isn't an MFD counterpart. In fact, I would take prior acceptance of the child into consideration (would be like a +1 vote) when reviewing the MFD part. One suggestion however, I would ask for the DT binding and the driver to be separated, as per [0]. [0] Documentation/devicetree/bindings/submitting-patches.txt -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On 28 July 2015 08:43 Lee Jones wrote:
> To: Dmitry Torokhov
> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for
> DA9062 OnKey
>
> On Mon, 27 Jul 2015, Dmitry Torokhov wrote:
>
> > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote:
> > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote:
> > > > From: S Twiss
> > > >
> > > > Add device tree bindings for the DA9062 OnKey driver component
> > > >
> > > > Signed-off-by: Steve Twiss
> > > >
> > > > ---
> > > > Changes in V3:
> > > > - Child driver specifics separated out into separate document
> > > >in this case ../input/da9062-onkey.txt
> > > > Changes in V2:
> > > > - No change
> > > >
> > > > This patch applies against linux-next and next-20150708
> > > >
> > > >
> > > > .../devicetree/bindings/input/da9062-onkey.txt | 36
> ++
> > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++
> > >
> > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and
> > > 9063, folded into the onkey patch and applied.
> >
> > Argh, da9062 core is not in mainline yet... OK, below is the patch I
> > had; if Lee does not pick it up I'll re-apply it when da9062 core hits
> > mainline.
>
> I guess all 3 patches should be taken though one tree? Happy to take
> them through MFD if that's okay with you.
Thanks Lee!
(please ignore my other e-mail ;)
Regards,
Stephen
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On 28 July 2015 06:40, Dmitry Torokhov wrote:
> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for
> DA9062 OnKey
>
> On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote:
> > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote:
> > > From: S Twiss
> > >
> > > Add device tree bindings for the DA9062 OnKey driver component
> > >
> > > Signed-off-by: Steve Twiss
> > > ---
> > > This patch applies against linux-next and next-20150708
> > >
> > >
> > > .../devicetree/bindings/input/da9062-onkey.txt | 36
> ++
> > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++
> >
> > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and
> > 9063, folded into the onkey patch and applied.
>
> Argh, da9062 core is not in mainline yet... OK, below is the patch I
> had; if Lee does not pick it up I'll re-apply it when da9062 core hits
> mainline.
>
> Thanks.
> --
> Dmitry
Thanks Dmitry,
The DA9062 core has been in linux-next for a couple of weeks now I think.
Hi Lee,
I'm not certain of the procedure with this: the DA9062 core is in
linux-next/next-2015mmdd
but has not yet made it to a mainline/v4.2-rcX so I guess it's not getting
picked up for some other
patches I have submitted for the DA9062 OnKey and RTC -- actually you already
know about
those two patch threads because you reviewed the MFD and DT parts last week!
Oh well -- I guess I have drawn your attention to this anyway, I'm just not
certain of the
timeline on this because it's something I've not done before.
Regards,
Stephen
> Input: add DA9062 OnKey capability to DA9063 OnKey driver
>
> From: S Twiss
>
> Add DA9062 OnKey support into the existing DA9063 OnKey driver
> component by
> using generic access tables for common register and bit mask definitions.
>
> The following change will add generic register and bit mask support to the
> DA9063 OnKey.
>
> The following alterations have been made to the DA9063 OnKey:
>
> - Addition of a da906x_chip_config structure to hold all
> generic registers and bitmasks for this type of OnKey component.
> - Addition of an struct of_device_id table for DA9063 and DA9062
> defaults
> - Refactoring functions to use struct da9063_onkey accesses to generic
> registers/masks instead of using defines from registers.h
> - Re-work of da9063_onkey_probe() to use of_match_node() and
> dev_get_regmap() to provide initialisation of generic registers and
> masks and access to regmap
>
> Signed-off-by: Steve Twiss
> Signed-off-by: Dmitry Torokhov
> ---
> .../devicetree/bindings/input/da9062-onkey.txt | 32 +
> drivers/input/misc/Kconfig |8 +
> drivers/input/misc/da9063_onkey.c | 129
>
> 3 files changed, 140 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/da9062-
> onkey.txt
>
> diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> new file mode 100644
> index 000..ab0e048
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> @@ -0,0 +1,32 @@
> +* Dialog DA9062/63 OnKey Module
> +
> +This module is part of the DA9062/DA9063. For more details about entire
> +chips see Documentation/devicetree/bindings/mfd/da9062.txt and
> +Documentation/devicetree/bindings/mfd/da9063.txt
> +
> +This module provides KEY_POWER, KEY_SLEEP and events.
> +
> +Required properties:
> +
> + - compatible: should be one of:
> + dlg,da9062-onkey
> + dlg,da9063-onkey
> +
> +Optional properties:
> +
> + - dlg,disable-key-power : Disable power-down using a long key-press. If
> this
> +entry exists the OnKey driver will remove support for the KEY_POWER
> key
> +press. If this entry does not exist then by default the key-press
> +triggered power down is enabled and the OnKey will support both
> KEY_POWER
> +and KEY_SLEEP.
> +
> +Example:
> +
> + pmic0: da9062@58 {
> +
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + dlg,disable-key-power;
> + };
> +
> + };
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index d4f0a81..d4b993d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -611,11 +611,11 @@ config INPUT_DA9055_ONKEY
> will be called da9055_onkey.
>
> config INPUT_DA9063_ONKEY
> - tristate "Dialog
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add device tree bindings for the DA9062 OnKey driver component > > > > > > Signed-off-by: Steve Twiss > > > > > > --- > > > Changes in V3: > > > - Child driver specifics separated out into separate document > > >in this case ../input/da9062-onkey.txt > > > Changes in V2: > > > - No change > > > > > > This patch applies against linux-next and next-20150708 > > > > > > > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > > > ++ > > > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ > > > > I dropped bits for mfd/da9062.txt, changed to mention both 9062 and > > 9063, folded into the onkey patch and applied. > > Argh, da9062 core is not in mainline yet... OK, below is the patch I > had; if Lee does not pick it up I'll re-apply it when da9062 core hits > mainline. I guess all 3 patches should be taken though one tree? Happy to take them through MFD if that's okay with you. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote:
> On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote:
> > From: S Twiss
> >
> > Add device tree bindings for the DA9062 OnKey driver component
> >
> > Signed-off-by: Steve Twiss
> >
> > ---
> > Changes in V3:
> > - Child driver specifics separated out into separate document
> >in this case ../input/da9062-onkey.txt
> > Changes in V2:
> > - No change
> >
> > This patch applies against linux-next and next-20150708
> >
> >
> > .../devicetree/bindings/input/da9062-onkey.txt | 36
> > ++
> > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++
>
> I dropped bits for mfd/da9062.txt, changed to mention both 9062 and
> 9063, folded into the onkey patch and applied.
Argh, da9062 core is not in mainline yet... OK, below is the patch I
had; if Lee does not pick it up I'll re-apply it when da9062 core hits
mainline.
Thanks.
--
Dmitry
Input: add DA9062 OnKey capability to DA9063 OnKey driver
From: S Twiss
Add DA9062 OnKey support into the existing DA9063 OnKey driver component by
using generic access tables for common register and bit mask definitions.
The following change will add generic register and bit mask support to the
DA9063 OnKey.
The following alterations have been made to the DA9063 OnKey:
- Addition of a da906x_chip_config structure to hold all
generic registers and bitmasks for this type of OnKey component.
- Addition of an struct of_device_id table for DA9063 and DA9062
defaults
- Refactoring functions to use struct da9063_onkey accesses to generic
registers/masks instead of using defines from registers.h
- Re-work of da9063_onkey_probe() to use of_match_node() and
dev_get_regmap() to provide initialisation of generic registers and
masks and access to regmap
Signed-off-by: Steve Twiss
Signed-off-by: Dmitry Torokhov
---
.../devicetree/bindings/input/da9062-onkey.txt | 32 +
drivers/input/misc/Kconfig |8 +
drivers/input/misc/da9063_onkey.c | 129
3 files changed, 140 insertions(+), 29 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt
diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt
b/Documentation/devicetree/bindings/input/da9062-onkey.txt
new file mode 100644
index 000..ab0e048
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
@@ -0,0 +1,32 @@
+* Dialog DA9062/63 OnKey Module
+
+This module is part of the DA9062/DA9063. For more details about entire
+chips see Documentation/devicetree/bindings/mfd/da9062.txt and
+Documentation/devicetree/bindings/mfd/da9063.txt
+
+This module provides KEY_POWER, KEY_SLEEP and events.
+
+Required properties:
+
+ - compatible: should be one of:
+ dlg,da9062-onkey
+ dlg,da9063-onkey
+
+Optional properties:
+
+ - dlg,disable-key-power : Disable power-down using a long key-press. If this
+entry exists the OnKey driver will remove support for the KEY_POWER key
+press. If this entry does not exist then by default the key-press
+triggered power down is enabled and the OnKey will support both KEY_POWER
+and KEY_SLEEP.
+
+Example:
+
+ pmic0: da9062@58 {
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ dlg,disable-key-power;
+ };
+
+ };
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index d4f0a81..d4b993d 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -611,11 +611,11 @@ config INPUT_DA9055_ONKEY
will be called da9055_onkey.
config INPUT_DA9063_ONKEY
- tristate "Dialog DA9063 OnKey"
- depends on MFD_DA9063
+ tristate "Dialog DA9062/63 OnKey"
+ depends on MFD_DA9063 || MFD_DA9062
help
- Support the ONKEY of Dialog DA9063 Power Management IC as an
- input device reporting power button statue.
+ Support the ONKEY of Dialog DA9063 and DA9062 Power Management ICs
+ as an input device capable of reporting the power button status.
To compile this driver as a module, choose M here: the module
will be called da9063_onkey.
diff --git a/drivers/input/misc/da9063_onkey.c
b/drivers/input/misc/da9063_onkey.c
index f577585..8eb697d 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -1,5 +1,5 @@
/*
- * OnKey device driver for DA9063
+ * OnKey device driver for DA9063 and DA9062 PMICs
* Copyright (C) 2015 Dialog Semiconductor Ltd.
*
* This program is free software; you can redistribute it and/or
@@ -24,36 +24,96 @@
#include
#include
#include
+#include
+#include
+
+struct da906x_chip_config {
+ /* REGS */
+ int onkey_status;
+ int onkey_pwr_signalling;
+ int onkey_fault_log;
+ int onkey_shutdown;
+ /* MASKS */
+ int onkey_nonkey_mask;
+
Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > From: S Twiss > > Add device tree bindings for the DA9062 OnKey driver component > > Signed-off-by: Steve Twiss > > --- > Changes in V3: > - Child driver specifics separated out into separate document >in this case ../input/da9062-onkey.txt > Changes in V2: > - No change > > This patch applies against linux-next and next-20150708 > > > .../devicetree/bindings/input/da9062-onkey.txt | 36 > ++ > Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++ I dropped bits for mfd/da9062.txt, changed to mention both 9062 and 9063, folded into the onkey patch and applied. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey
From: S Twiss
Add device tree bindings for the DA9062 OnKey driver component
Signed-off-by: Steve Twiss
---
Changes in V3:
- Child driver specifics separated out into separate document
in this case ../input/da9062-onkey.txt
Changes in V2:
- No change
This patch applies against linux-next and next-20150708
.../devicetree/bindings/input/da9062-onkey.txt | 36 ++
Documentation/devicetree/bindings/mfd/da9062.txt | 3 ++
2 files changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt
diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt
b/Documentation/devicetree/bindings/input/da9062-onkey.txt
new file mode 100644
index 000..c936902
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
@@ -0,0 +1,36 @@
+* Dialog DA9062 OnKey Module
+
+This module is part of the DA9062. For more details about the whole
+chip see Documentation/devicetree/bindings/mfd/da9062.txt.
+
+This module provides KEY_POWER, KEY_SLEEP and events.
+
+Required properties:
+
+- compatible: should be "dlg,da9062-onkey"
+
+Nodes:
+
+- onkey : This node defines the OnKey settings for controlling the key
+ functionality of the device. The node should contain the compatible property
+ with the value "dlg,da9062-onkey".
+
+ Optional onkey properties:
+
+ - dlg,disable-key-power : Disable power-down using a long key-press. If this
+entry exists the OnKey driver will remove support for the KEY_POWER key
+press. If this entry does not exist then by default the key-press
+triggered power down is enabled and the OnKey will support both KEY_POWER
+and KEY_SLEEP.
+
+Example:
+
+ pmic0: da9062@58 {
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ dlg,disable-key-power;
+ };
+
+ };
+
diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt
b/Documentation/devicetree/bindings/mfd/da9062.txt
index 5765ed9..d2e1730 100644
--- a/Documentation/devicetree/bindings/mfd/da9062.txt
+++ b/Documentation/devicetree/bindings/mfd/da9062.txt
@@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices:
Device Supply NamesDescription
-- ---
da9062-regulator: : LDOs & BUCKs
+da9062-onkey: : On Key
da9062-watchdog : : Watchdog Timer
==
@@ -40,6 +41,8 @@ Sub-nodes:
details of individual regulator device can be found in:
Documentation/devicetree/bindings/regulator/regulator.txt
+- onkey : For more details about the onkey node see
+ Documentation/devicetree/bindings/input/da9062-onkey.txt
- watchdog: This node defines the settings for the watchdog driver associated
with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added
--
end-of-patch for PATCH V3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
