Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

[Tony Jones]

On 1/18/19 5:12 PM, Tony Jones wrote:
> On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:
> 
>> +from __future__ import print_function
> 
> You don't need this unless you're actually requiring functionality that only 
> exists in v3.
> For example, you need it to handle the suppress newline functionality such as 
> "end=".

Also, it brings up a question I had.   What python versions are expected to be 
supported with PYTHON=python2?

https://python-future.org/imports.html   So importing from future (for end='' 
support) implies >= 2.6.   

The base release of 2.6 was October 2008 so maybe this is fine.  Otherwise it 
may be preferable to use sys.stdout.write which has more consistent semantics 
(see
tools/perf/scripts/python/compaction-times.py)

Tony

Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

[Tony Jones]

On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:

> +from __future__ import print_function

You don't need this unless you're actually requiring functionality that only 
exists in v3.
For example, you need it to handle the suppress newline functionality such as 
"end=".

>  def print_error_totals():
>  if for_comm is not None:
> - print "\nsyscall errors for %s:\n\n" % (for_comm),
> + print("\nsyscall errors for %s:\n\n" % (for_comm)),
>  else:
> - print "\nsyscall errors:\n\n",
> + print("\nsyscall errors:\n\n"),
>  
> -print "%-30s  %10s\n" % ("comm [pid]", "count"),
> -print "%-30s  %10s\n" % ("--", \
> - "--"),
> +print("%-30s  %10s\n" % ("comm [pid]", "count")),
> +print("%-30s  %10s\n" % ("--", \
> + "--")),

Same comments as before regarding trailing comma for function.

See: 
https://build.opensuse.org/package/view_file/devel:tools/perf/port-failed-syscalls-by-pid-script-to-python3.patch?expand=1

[PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

[Seeteena Thoufeek]

Support both Python 2 and Python 3 in failed-syscalls-by-pid.py.
``print`` is now a function rather than a statement. This should have
no functional change.

Fixes lambda syntax error.

Signed-off-by: Seeteena Thoufeek 
Reviewed-by: Ravi Bangoria 

Please enter the commit message for your changes. Lines starting
---
 tools/perf/scripts/python/failed-syscalls-by-pid.py | 21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tools/perf/scripts/python/failed-syscalls-by-pid.py 
b/tools/perf/scripts/python/failed-syscalls-by-pid.py
index cafeff3..a174755 100644
--- a/tools/perf/scripts/python/failed-syscalls-by-pid.py
+++ b/tools/perf/scripts/python/failed-syscalls-by-pid.py
@@ -4,6 +4,7 @@
 #
 # Displays system-wide failed system call totals, broken down by pid.
 # If a [comm] arg is specified, only syscalls called by [comm] are displayed.
+from __future__ import print_function
 
 import os
 import sys
@@ -32,7 +33,7 @@ if len(sys.argv) > 1:
 syscalls = autodict()
 
 def trace_begin():
-   print "Press control+C to stop and show the summary"
+   print("Press control+C to stop and show the summary")
 
 def trace_end():
print_error_totals()
@@ -57,22 +58,22 @@ def syscalls__sys_exit(event_name, context, common_cpu,
 
 def print_error_totals():
 if for_comm is not None:
-   print "\nsyscall errors for %s:\n\n" % (for_comm),
+   print("\nsyscall errors for %s:\n\n" % (for_comm)),
 else:
-   print "\nsyscall errors:\n\n",
+   print("\nsyscall errors:\n\n"),
 
-print "%-30s  %10s\n" % ("comm [pid]", "count"),
-print "%-30s  %10s\n" % ("--", \
- "--"),
+print("%-30s  %10s\n" % ("comm [pid]", "count")),
+print("%-30s  %10s\n" % ("--", \
+ "--")),
 
 comm_keys = syscalls.keys()
 for comm in comm_keys:
pid_keys = syscalls[comm].keys()
for pid in pid_keys:
-   print "\n%s [%d]\n" % (comm, pid),
+   print("\n%s [%d]\n" % (comm, pid)),
id_keys = syscalls[comm][pid].keys()
for id in id_keys:
-   print "  syscall: %-16s\n" % syscall_name(id),
+   print("  syscall: %-16s\n" % syscall_name(id)),
ret_keys = syscalls[comm][pid][id].keys()
-   for ret, val in 
sorted(syscalls[comm][pid][id].iteritems(), key = lambda(k, v): (v, k),  
reverse = True):
-   print "err = %-20s  %10d\n" % 
(strerror(ret), val),
+   for ret, val in 
sorted(syscalls[comm][pid][id].iteritems(), key = lambda k_v: (k_v[1], k_v[0]), 
 reverse = True):
+   print("err = %-20s  %10d\n" % 
(strerror(ret), val)),
-- 
1.8.3.1