Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Wolfram Sang]

On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
> 
> While being there, drop the -mfd suffix since isn't correct.
> 
> Signed-off-by: Javier Martinez Canillas 
> Acked-by: Rob Herring 
> Acked-by: Aaro Koskinen 
> Acked-by: Tony Lindgren 
> 

Reviewed-by: Wolfram Sang 

I assume this goes with the rest of the series and not via my tree.



signature.asc
Description: PGP signature

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Wolfram Sang]

On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
> 
> While being there, drop the -mfd suffix since isn't correct.
> 
> Signed-off-by: Javier Martinez Canillas 
> Acked-by: Rob Herring 
> Acked-by: Aaro Koskinen 
> Acked-by: Tony Lindgren 
> 

Reviewed-by: Wolfram Sang 

I assume this goes with the rest of the series and not via my tree.



signature.asc
Description: PGP signature

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Javier Martinez Canillas]

Hello Wolfram,

On 04/19/2017 02:51 PM, Wolfram Sang wrote:
> On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
>> The example contains a device node for a retu device, but
>> its compatible string doesn't have a vendor prefix.
>>
>> While being there, drop the -mfd suffix since isn't correct.
>>
>> Signed-off-by: Javier Martinez Canillas 
>> Acked-by: Rob Herring 
>> Acked-by: Aaro Koskinen 
>> Acked-by: Tony Lindgren 
> 
> Wouldn't it be nice if we fix the driver also so it actually matches the
> below compatible? I can't find such a change in linux-next.
> 

[snip]

>>  
>> -retu-mfd: retu@1 {
>> -compatible = "retu-mfd";
>> +retu: retu@1 {
>> +compatible = "nokia,retu";
>>  reg = <0x1>;
>>  };

You mean having a "nokia,retu" entry in a OF table?

That's done by patch 3/8 in this series:

http://www.spinics.net/lists/devicetree/msg173145.html

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Javier Martinez Canillas]

Hello Wolfram,

On 04/19/2017 02:51 PM, Wolfram Sang wrote:
> On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
>> The example contains a device node for a retu device, but
>> its compatible string doesn't have a vendor prefix.
>>
>> While being there, drop the -mfd suffix since isn't correct.
>>
>> Signed-off-by: Javier Martinez Canillas 
>> Acked-by: Rob Herring 
>> Acked-by: Aaro Koskinen 
>> Acked-by: Tony Lindgren 
> 
> Wouldn't it be nice if we fix the driver also so it actually matches the
> below compatible? I can't find such a change in linux-next.
> 

[snip]

>>  
>> -retu-mfd: retu@1 {
>> -compatible = "retu-mfd";
>> +retu: retu@1 {
>> +compatible = "nokia,retu";
>>  reg = <0x1>;
>>  };

You mean having a "nokia,retu" entry in a OF table?

That's done by patch 3/8 in this series:

http://www.spinics.net/lists/devicetree/msg173145.html

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Wolfram Sang]

On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
> 
> While being there, drop the -mfd suffix since isn't correct.
> 
> Signed-off-by: Javier Martinez Canillas 
> Acked-by: Rob Herring 
> Acked-by: Aaro Koskinen 
> Acked-by: Tony Lindgren 

Wouldn't it be nice if we fix the driver also so it actually matches the
below compatible? I can't find such a change in linux-next.

> ---
> 
> Changes in v5:
> - Add Rob Herring's Acked-by tag.
> - Add Aaro Koskinen's Acked-by tag.
> - Add Acked-by: Tony Lindgren 's Acked-by tag.
> 
> Changes in v4:
> - Avoid using MFD in Device Tree (Lee Jones).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt 
> b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> index 8ce9cd2855b5..c143948b2a37 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> @@ -20,8 +20,8 @@ i2c@0 {
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> - retu-mfd: retu@1 {
> - compatible = "retu-mfd";
> + retu: retu@1 {
> + compatible = "nokia,retu";
>   reg = <0x1>;
>   };
>  };
> -- 
> 2.9.3
> 


signature.asc
Description: PGP signature

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Wolfram Sang]

On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
> 
> While being there, drop the -mfd suffix since isn't correct.
> 
> Signed-off-by: Javier Martinez Canillas 
> Acked-by: Rob Herring 
> Acked-by: Aaro Koskinen 
> Acked-by: Tony Lindgren 

Wouldn't it be nice if we fix the driver also so it actually matches the
below compatible? I can't find such a change in linux-next.

> ---
> 
> Changes in v5:
> - Add Rob Herring's Acked-by tag.
> - Add Aaro Koskinen's Acked-by tag.
> - Add Acked-by: Tony Lindgren 's Acked-by tag.
> 
> Changes in v4:
> - Avoid using MFD in Device Tree (Lee Jones).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt 
> b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> index 8ce9cd2855b5..c143948b2a37 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> @@ -20,8 +20,8 @@ i2c@0 {
>   #address-cells = <1>;
>   #size-cells = <0>;
>  
> - retu-mfd: retu@1 {
> - compatible = "retu-mfd";
> + retu: retu@1 {
> + compatible = "nokia,retu";
>   reg = <0x1>;
>   };
>  };
> -- 
> 2.9.3
> 


signature.asc
Description: PGP signature

[PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Javier Martinez Canillas]

The example contains a device node for a retu device, but
its compatible string doesn't have a vendor prefix.

While being there, drop the -mfd suffix since isn't correct.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Rob Herring 
Acked-by: Aaro Koskinen 
Acked-by: Tony Lindgren 

---

Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren 's Acked-by tag.

Changes in v4:
- Avoid using MFD in Device Tree (Lee Jones).

Changes in v3: None
Changes in v2: None

 Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt 
b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
index 8ce9cd2855b5..c143948b2a37 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
@@ -20,8 +20,8 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
 
-   retu-mfd: retu@1 {
-   compatible = "retu-mfd";
+   retu: retu@1 {
+   compatible = "nokia,retu";
reg = <0x1>;
};
 };
-- 
2.9.3

[PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Javier Martinez Canillas]

The example contains a device node for a retu device, but
its compatible string doesn't have a vendor prefix.

While being there, drop the -mfd suffix since isn't correct.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Rob Herring 
Acked-by: Aaro Koskinen 
Acked-by: Tony Lindgren 

---

Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren 's Acked-by tag.

Changes in v4:
- Avoid using MFD in Device Tree (Lee Jones).

Changes in v3: None
Changes in v2: None

 Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt 
b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
index 8ce9cd2855b5..c143948b2a37 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
@@ -20,8 +20,8 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
 
-   retu-mfd: retu@1 {
-   compatible = "retu-mfd";
+   retu: retu@1 {
+   compatible = "nokia,retu";
reg = <0x1>;
};
 };
-- 
2.9.3